@atlaskit/editor-core 187.37.2 → 187.37.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 187.37.3
+
+### Patch Changes
+
+- [`e0f15f5af8a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e0f15f5af8a) - Fix invalid getPos issue happening for Media and Media group nodeviews
+
 ## 187.37.2
 
 ### Patch Changes

package/dist/cjs/plugins/media/nodeviews/mediaGroup.js

@@ -32,7 +32,17 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 var isMediaGroupSelectedFromProps = function isMediaGroupSelectedFromProps(props) {
-  var pos = props.getPos();
+  /**
+   *  ED-19831
+   *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+   *  directly to confluence since this bug is now iun production.
+   */
+  var pos;
+  try {
+    pos = typeof props.getPos === 'function' ? props.getPos() : undefined;
+  } catch (e) {
+    pos = undefined;
+  }
   if (typeof pos !== 'number') {
     return false;
   }

package/dist/cjs/plugins/media/nodeviews/mediaSingle.js

@@ -469,7 +469,19 @@ var MediaSingleNodeView = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this2), "checkAndUpdateSelectionType", function () {
       var getPos = _this2.getPos;
       var selection = _this2.view.state.selection;
-      var isNodeSelected = (0, _nodes.isNodeSelectedOrInRange)(selection.$anchor.pos, selection.$head.pos, getPos(), _this2.node.nodeSize);
+
+      /**
+       *  ED-19831
+       *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+       *  directly to confluence since this bug is now iun production.
+       */
+      var pos;
+      try {
+        pos = typeof getPos === 'function' ? getPos() : undefined;
+      } catch (e) {
+        pos = undefined;
+      }
+      var isNodeSelected = (0, _nodes.isNodeSelectedOrInRange)(selection.$anchor.pos, selection.$head.pos, pos, _this2.node.nodeSize);
       _this2.selectionType = isNodeSelected;
       return isNodeSelected;
     });

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "187.37.2";
+var version = "187.37.3";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/es2019/plugins/media/nodeviews/mediaGroup.js

@@ -13,7 +13,17 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 const isMediaGroupSelectedFromProps = props => {
-  const pos = props.getPos();
+  /**
+   *  ED-19831
+   *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+   *  directly to confluence since this bug is now iun production.
+   */
+  let pos;
+  try {
+    pos = typeof props.getPos === 'function' ? props.getPos() : undefined;
+  } catch (e) {
+    pos = undefined;
+  }
   if (typeof pos !== 'number') {
     return false;
   }

package/dist/es2019/plugins/media/nodeviews/mediaSingle.js

@@ -373,7 +373,19 @@ class MediaSingleNodeView extends ReactNodeView {
       const {
         selection
       } = this.view.state;
-      const isNodeSelected = isNodeSelectedOrInRange(selection.$anchor.pos, selection.$head.pos, getPos(), this.node.nodeSize);
+
+      /**
+       *  ED-19831
+       *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+       *  directly to confluence since this bug is now iun production.
+       */
+      let pos;
+      try {
+        pos = typeof getPos === 'function' ? getPos() : undefined;
+      } catch (e) {
+        pos = undefined;
+      }
+      const isNodeSelected = isNodeSelectedOrInRange(selection.$anchor.pos, selection.$head.pos, pos, this.node.nodeSize);
       this.selectionType = isNodeSelected;
       return isNodeSelected;
     });

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "187.37.2";
+export const version = "187.37.3";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/plugins/media/nodeviews/mediaGroup.js

@@ -25,7 +25,17 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 var isMediaGroupSelectedFromProps = function isMediaGroupSelectedFromProps(props) {
-  var pos = props.getPos();
+  /**
+   *  ED-19831
+   *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+   *  directly to confluence since this bug is now iun production.
+   */
+  var pos;
+  try {
+    pos = typeof props.getPos === 'function' ? props.getPos() : undefined;
+  } catch (e) {
+    pos = undefined;
+  }
   if (typeof pos !== 'number') {
     return false;
   }

package/dist/esm/plugins/media/nodeviews/mediaSingle.js

@@ -460,7 +460,19 @@ var MediaSingleNodeView = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_assertThisInitialized(_this2), "checkAndUpdateSelectionType", function () {
       var getPos = _this2.getPos;
       var selection = _this2.view.state.selection;
-      var isNodeSelected = isNodeSelectedOrInRange(selection.$anchor.pos, selection.$head.pos, getPos(), _this2.node.nodeSize);
+
+      /**
+       *  ED-19831
+       *  There is a getPos issue coming from this code. We need to apply this workaround for now and apply a patch
+       *  directly to confluence since this bug is now iun production.
+       */
+      var pos;
+      try {
+        pos = typeof getPos === 'function' ? getPos() : undefined;
+      } catch (e) {
+        pos = undefined;
+      }
+      var isNodeSelected = isNodeSelectedOrInRange(selection.$anchor.pos, selection.$head.pos, pos, _this2.node.nodeSize);
       _this2.selectionType = isNodeSelected;
       return isNodeSelected;
     });

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "187.37.2";
+export var version = "187.37.3";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "187.37.2",
+  "version": "187.37.3",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"