@atlaskit/editor-core 187.35.3 → 187.35.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 187.35.4
+
+### Patch Changes
+
+- [`10a82c0490c`](https://bitbucket.org/atlassian/atlassian-frontend/commits/10a82c0490c) - ED-19792 disable guideline plugin for comment and mobile.
+
 ## 187.35.3
 
 ### Patch Changes

package/dist/cjs/labs/next/presets/universal.js

@@ -39,6 +39,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function createUniversalPreset(appearance, props, featureFlags, prevAppearance, createAnalyticsEvent) {
   var isMobile = appearance === 'mobile';
   var isComment = appearance === 'comment';
+  var isChromeless = appearance === 'chromeless';
   var isFullPage = (0, _isFullPage.isFullPage)(appearance);
   var getEditorFeatureFlags = function getEditorFeatureFlags() {
     return featureFlags;
@@ -88,6 +89,9 @@ function createUniversalPreset(appearance, props, featureFlags, prevAppearance,
     }
     return builder;
   }).maybeAdd(_editorPluginGuideline.guidelinePlugin, function (plugin, builder) {
+    if (isMobile || isComment || isChromeless) {
+      return builder;
+    }
     if (props.media || props.allowTables) {
       return builder.add(plugin);
     }

package/dist/cjs/plugins/media/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -219,7 +219,9 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
       _this.setIsResizing(true);
       _this.updateSizeInPluginState(_this.state.size.width);
       // re-calculate guidelines
-      _this.updateGuidelines();
+      if (_this.isGuidelineEnabled) {
+        _this.updateGuidelines();
+      }
     });
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleResize", function (size, delta) {
       var _this$props4 = _this.props,
@@ -230,18 +232,27 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
         width = _this$calculateSizeSt.width,
         height = _this$calculateSizeSt.height,
         calculatedWidthWithLayout = _this$calculateSizeSt.calculatedWidthWithLayout;
-      var guidelineSnaps = (0, _guideline.getGuidelineSnaps)(_this.state.guidelines, lineLength, layout);
-      _this.updateActiveGuidelines(width, _this.state.guidelines, guidelineSnaps);
-      var relativeSnaps = (0, _guideline.getRelativeGuideSnaps)(_this.state.relativeGuides, _this.aspectRatio);
-      _this.setState({
-        size: {
-          width: width,
-          height: height
-        },
-        snaps: {
-          x: [].concat((0, _toConsumableArray2.default)(guidelineSnaps.snaps.x || []), (0, _toConsumableArray2.default)(relativeSnaps))
-        }
-      });
+      if (_this.isGuidelineEnabled) {
+        var guidelineSnaps = (0, _guideline.getGuidelineSnaps)(_this.state.guidelines, lineLength, layout);
+        _this.updateActiveGuidelines(width, _this.state.guidelines, guidelineSnaps);
+        var relativeSnaps = (0, _guideline.getRelativeGuideSnaps)(_this.state.relativeGuides, _this.aspectRatio);
+        _this.setState({
+          size: {
+            width: width,
+            height: height
+          },
+          snaps: {
+            x: [].concat((0, _toConsumableArray2.default)(guidelineSnaps.snaps.x || []), (0, _toConsumableArray2.default)(relativeSnaps))
+          }
+        });
+      } else {
+        _this.setState({
+          size: {
+            width: width,
+            height: height
+          }
+        });
+      }
       _this.updateSizeInPluginState(width);
       if (calculatedWidthWithLayout.layout !== layout) {
         updateSize(width, calculatedWidthWithLayout.layout);
@@ -423,6 +434,12 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
       var layoutColumn = this.props.view.state.schema.nodes.layoutColumn;
       return !!(0, _utils.findParentNodeOfTypeClosestToPos)($pos, [layoutColumn]);
     }
+  }, {
+    key: "isGuidelineEnabled",
+    get: function get() {
+      var _this$props$pluginInj7;
+      return !!((_this$props$pluginInj7 = this.props.pluginInjectionApi) !== null && _this$props$pluginInj7 !== void 0 && _this$props$pluginInj7.guideline);
+    }
 
     // check if is inside of layout, table, expand, nestedExpand and list item
   }, {

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "187.35.3";
+var version = "187.35.4";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/es2019/labs/next/presets/universal.js

@@ -28,6 +28,7 @@ import { shouldForceTracking } from '@atlaskit/editor-common/utils';
 export default function createUniversalPreset(appearance, props, featureFlags, prevAppearance, createAnalyticsEvent) {
   const isMobile = appearance === 'mobile';
   const isComment = appearance === 'comment';
+  const isChromeless = appearance === 'chromeless';
   const isFullPage = fullPageCheck(appearance);
   const getEditorFeatureFlags = () => featureFlags;
   const editorSelectionAPI = createEditorSelectionAPI();
@@ -76,6 +77,9 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
     }
     return builder;
   }).maybeAdd(guidelinePlugin, (plugin, builder) => {
+    if (isMobile || isComment || isChromeless) {
+      return builder;
+    }
     if (props.media || props.allowTables) {
       return builder.add(plugin);
     }

package/dist/es2019/plugins/media/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -196,7 +196,9 @@ class ResizableMediaSingleNext extends React.Component {
       this.setIsResizing(true);
       this.updateSizeInPluginState(this.state.size.width);
       // re-calculate guidelines
-      this.updateGuidelines();
+      if (this.isGuidelineEnabled) {
+        this.updateGuidelines();
+      }
     });
     _defineProperty(this, "handleResize", (size, delta) => {
       const {
@@ -209,18 +211,27 @@ class ResizableMediaSingleNext extends React.Component {
         height,
         calculatedWidthWithLayout
       } = this.calculateSizeState(size, delta);
-      const guidelineSnaps = getGuidelineSnaps(this.state.guidelines, lineLength, layout);
-      this.updateActiveGuidelines(width, this.state.guidelines, guidelineSnaps);
-      const relativeSnaps = getRelativeGuideSnaps(this.state.relativeGuides, this.aspectRatio);
-      this.setState({
-        size: {
-          width,
-          height
-        },
-        snaps: {
-          x: [...(guidelineSnaps.snaps.x || []), ...relativeSnaps]
-        }
-      });
+      if (this.isGuidelineEnabled) {
+        const guidelineSnaps = getGuidelineSnaps(this.state.guidelines, lineLength, layout);
+        this.updateActiveGuidelines(width, this.state.guidelines, guidelineSnaps);
+        const relativeSnaps = getRelativeGuideSnaps(this.state.relativeGuides, this.aspectRatio);
+        this.setState({
+          size: {
+            width,
+            height
+          },
+          snaps: {
+            x: [...(guidelineSnaps.snaps.x || []), ...relativeSnaps]
+          }
+        });
+      } else {
+        this.setState({
+          size: {
+            width,
+            height
+          }
+        });
+      }
       this.updateSizeInPluginState(width);
       if (calculatedWidthWithLayout.layout !== layout) {
         updateSize(width, calculatedWidthWithLayout.layout);
@@ -374,6 +385,10 @@ class ResizableMediaSingleNext extends React.Component {
     } = this.props.view.state.schema.nodes;
     return !!findParentNodeOfTypeClosestToPos($pos, [layoutColumn]);
   }
+  get isGuidelineEnabled() {
+    var _this$props$pluginInj7;
+    return !!((_this$props$pluginInj7 = this.props.pluginInjectionApi) !== null && _this$props$pluginInj7 !== void 0 && _this$props$pluginInj7.guideline);
+  }
 
   // check if is inside of layout, table, expand, nestedExpand and list item
   isNestedNode() {

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "187.35.3";
+export const version = "187.35.4";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/labs/next/presets/universal.js

@@ -32,6 +32,7 @@ import { shouldForceTracking } from '@atlaskit/editor-common/utils';
 export default function createUniversalPreset(appearance, props, featureFlags, prevAppearance, createAnalyticsEvent) {
   var isMobile = appearance === 'mobile';
   var isComment = appearance === 'comment';
+  var isChromeless = appearance === 'chromeless';
   var isFullPage = fullPageCheck(appearance);
   var getEditorFeatureFlags = function getEditorFeatureFlags() {
     return featureFlags;
@@ -81,6 +82,9 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
     }
     return builder;
   }).maybeAdd(guidelinePlugin, function (plugin, builder) {
+    if (isMobile || isComment || isChromeless) {
+      return builder;
+    }
     if (props.media || props.allowTables) {
       return builder.add(plugin);
     }

package/dist/esm/plugins/media/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -212,7 +212,9 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
       _this.setIsResizing(true);
       _this.updateSizeInPluginState(_this.state.size.width);
       // re-calculate guidelines
-      _this.updateGuidelines();
+      if (_this.isGuidelineEnabled) {
+        _this.updateGuidelines();
+      }
     });
     _defineProperty(_assertThisInitialized(_this), "handleResize", function (size, delta) {
       var _this$props4 = _this.props,
@@ -223,18 +225,27 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
         width = _this$calculateSizeSt.width,
         height = _this$calculateSizeSt.height,
         calculatedWidthWithLayout = _this$calculateSizeSt.calculatedWidthWithLayout;
-      var guidelineSnaps = getGuidelineSnaps(_this.state.guidelines, lineLength, layout);
-      _this.updateActiveGuidelines(width, _this.state.guidelines, guidelineSnaps);
-      var relativeSnaps = getRelativeGuideSnaps(_this.state.relativeGuides, _this.aspectRatio);
-      _this.setState({
-        size: {
-          width: width,
-          height: height
-        },
-        snaps: {
-          x: [].concat(_toConsumableArray(guidelineSnaps.snaps.x || []), _toConsumableArray(relativeSnaps))
-        }
-      });
+      if (_this.isGuidelineEnabled) {
+        var guidelineSnaps = getGuidelineSnaps(_this.state.guidelines, lineLength, layout);
+        _this.updateActiveGuidelines(width, _this.state.guidelines, guidelineSnaps);
+        var relativeSnaps = getRelativeGuideSnaps(_this.state.relativeGuides, _this.aspectRatio);
+        _this.setState({
+          size: {
+            width: width,
+            height: height
+          },
+          snaps: {
+            x: [].concat(_toConsumableArray(guidelineSnaps.snaps.x || []), _toConsumableArray(relativeSnaps))
+          }
+        });
+      } else {
+        _this.setState({
+          size: {
+            width: width,
+            height: height
+          }
+        });
+      }
       _this.updateSizeInPluginState(width);
       if (calculatedWidthWithLayout.layout !== layout) {
         updateSize(width, calculatedWidthWithLayout.layout);
@@ -416,6 +427,12 @@ var ResizableMediaSingleNext = /*#__PURE__*/function (_React$Component) {
       var layoutColumn = this.props.view.state.schema.nodes.layoutColumn;
       return !!findParentNodeOfTypeClosestToPos($pos, [layoutColumn]);
     }
+  }, {
+    key: "isGuidelineEnabled",
+    get: function get() {
+      var _this$props$pluginInj7;
+      return !!((_this$props$pluginInj7 = this.props.pluginInjectionApi) !== null && _this$props$pluginInj7 !== void 0 && _this$props$pluginInj7.guideline);
+    }
 
     // check if is inside of layout, table, expand, nestedExpand and list item
   }, {

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "187.35.3";
+export var version = "187.35.4";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/types/plugins/media/ui/ResizableMediaSingle/ResizableMediaSingleNext.d.ts

@@ -31,6 +31,7 @@ declare class ResizableMediaSingleNext extends React.Component<ResizableMediaSin
     get aspectRatio(): number;
     get insideInlineLike(): boolean;
     get insideLayout(): boolean;
+    get isGuidelineEnabled(): boolean;
     isNestedNode(): boolean;
     private getDefaultGuidelines;
     private updateGuidelines;

package/dist/types-ts4.5/plugins/media/ui/ResizableMediaSingle/ResizableMediaSingleNext.d.ts

@@ -31,6 +31,7 @@ declare class ResizableMediaSingleNext extends React.Component<ResizableMediaSin
     get aspectRatio(): number;
     get insideInlineLike(): boolean;
     get insideLayout(): boolean;
+    get isGuidelineEnabled(): boolean;
     isNestedNode(): boolean;
     private getDefaultGuidelines;
     private updateGuidelines;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "187.35.3",
+  "version": "187.35.4",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"