@atlaskit/editor-core 187.1.4 → 187.2.1

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-core
 
+## 187.2.1
+
+### Patch Changes
+
+- [`f4f06674b2f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/f4f06674b2f) - Fix additional typeahead character being added to editor when using composition.
+
+## 187.2.0
+
+### Minor Changes
+
+- [`e7ed90bad7c`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e7ed90bad7c) - Remove platform feature flag calls to editor-core and pass through a new option instead for custom table widths project, allowing for simpler clean up and reference
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 187.1.4
 
 ### Patch Changes

package/dist/cjs/labs/next/presets/universal.js

@@ -15,6 +15,7 @@ var _editorPluginGrid = require("@atlaskit/editor-plugin-grid");
 var _editorPluginCard = require("@atlaskit/editor-plugin-card");
 var _editorPluginTable = require("@atlaskit/editor-plugin-table");
 var _editorPluginContentInsertion = require("@atlaskit/editor-plugin-content-insertion");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _isFullPage = require("../../../utils/is-full-page");
 var _mediaCommon = require("@atlaskit/media-common");
 var _default = require("./default");
@@ -148,6 +149,9 @@ function createUniversalPreset(appearance, props, featureFlags, prevAppearance,
       var tableOptions = !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables;
       return builder.add([plugin, {
         tableOptions: tableOptions,
+        // tableResizingEnabled will replace breakoutEnabled once FF is 100% rolled out,
+        // logic below is to help codemod during cleanup
+        tableResizingEnabled: (0, _platformFeatureFlags.getBooleanFF)('platform.editor.custom-table-width') && ['full-page', 'full-width'].includes(appearance || ''),
         breakoutEnabled: appearance === 'full-page',
         allowContextualMenu: !isMobile,
         fullWidthEnabled: appearance === 'full-width',

package/dist/cjs/plugins/type-ahead/transforms/open-typeahead-at-cursor.js

@@ -8,7 +8,6 @@ var _prosemirrorState = require("prosemirror-state");
 var _selection = require("@atlaskit/editor-common/selection");
 var _key = require("../pm-plugins/key");
 var _actions = require("../pm-plugins/actions");
-var _utils = require("@atlaskit/editor-common/utils");
 var openTypeAhead = function openTypeAhead(props) {
   return function (tr) {
     var triggerHandler = props.triggerHandler,
@@ -61,7 +60,13 @@ var openTypeAheadAtCursor = function openTypeAheadAtCursor(_ref) {
 
       // ME-2375 remove the superfluous '@' inserted before decoration
       // by composition (https://github.com/ProseMirror/prosemirror/issues/903)
-      if (_utils.browser.chrome && _utils.browser.android && cursorPos > 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, '@')) {
+      //
+      // Update:
+      // Now also handles any use case with superfluous typeahead triggers (ie. '@', ':', '/')
+      // being inserted due to composition by checking if we have the trigger
+      // directly before the typeahead. This should not happen unless it has
+      // been eroneously added because we require whitespace/newline for typeahead.
+      if (cursorPos >= 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, triggerHandler.trigger)) {
         tr.delete(cursorPos - 1, cursorPos);
       }
     }

package/dist/cjs/plugins/type-ahead/ui/InputQuery.js

@@ -148,7 +148,7 @@ var InputQuery = /*#__PURE__*/_react.default.memo(function (_ref) {
         // ED-14758 - Under the W3C specification, any keycode sent under IME would return a keycode 229
         // event.isComposing can't be used alone as this also included a virtual keyboard under a keyboardless device, therefore, it seems the best practice would be intercepting the event as below.
         // Some suggested the other workaround maybe listen on`keypress` instead of `keydown`
-        if (!event.isComposing || event.which !== 229 && event.keyCode !== 229) {
+        if (!event.isComposing && event.which !== 229 && event.keyCode !== 229) {
           if (selectedIndex === -1) {
             if (useBetterTypeaheadNavigation) {
               /**

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "187.1.4";
+var version = "187.2.1";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "187.1.4",
+	"version": "187.2.1",
 	"sideEffects": false
 }

package/dist/es2019/labs/next/presets/universal.js

@@ -6,6 +6,7 @@ import { gridPlugin } from '@atlaskit/editor-plugin-grid';
 import { cardPlugin } from '@atlaskit/editor-plugin-card';
 import { tablesPlugin } from '@atlaskit/editor-plugin-table';
 import { contentInsertionPlugin } from '@atlaskit/editor-plugin-content-insertion';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isFullPage as fullPageCheck } from '../../../utils/is-full-page';
 import { getMediaFeatureFlag } from '@atlaskit/media-common';
 import { createDefaultPreset } from './default';
@@ -137,6 +138,9 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
       const tableOptions = !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables;
       return builder.add([plugin, {
         tableOptions,
+        // tableResizingEnabled will replace breakoutEnabled once FF is 100% rolled out,
+        // logic below is to help codemod during cleanup
+        tableResizingEnabled: getBooleanFF('platform.editor.custom-table-width') && ['full-page', 'full-width'].includes(appearance || ''),
         breakoutEnabled: appearance === 'full-page',
         allowContextualMenu: !isMobile,
         fullWidthEnabled: appearance === 'full-width',

package/dist/es2019/plugins/type-ahead/transforms/open-typeahead-at-cursor.js

@@ -2,7 +2,6 @@ import { TextSelection } from 'prosemirror-state';
 import { GapCursorSelection } from '@atlaskit/editor-common/selection';
 import { pluginKey } from '../pm-plugins/key';
 import { ACTIONS } from '../pm-plugins/actions';
-import { browser } from '@atlaskit/editor-common/utils';
 export const openTypeAhead = props => tr => {
   const {
     triggerHandler,
@@ -56,7 +55,13 @@ export const openTypeAheadAtCursor = ({
 
     // ME-2375 remove the superfluous '@' inserted before decoration
     // by composition (https://github.com/ProseMirror/prosemirror/issues/903)
-    if (browser.chrome && browser.android && cursorPos > 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, '@')) {
+    //
+    // Update:
+    // Now also handles any use case with superfluous typeahead triggers (ie. '@', ':', '/')
+    // being inserted due to composition by checking if we have the trigger
+    // directly before the typeahead. This should not happen unless it has
+    // been eroneously added because we require whitespace/newline for typeahead.
+    if (cursorPos >= 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, triggerHandler.trigger)) {
       tr.delete(cursorPos - 1, cursorPos);
     }
   }

package/dist/es2019/plugins/type-ahead/ui/InputQuery.js

@@ -133,7 +133,7 @@ export const InputQuery = /*#__PURE__*/React.memo(({
         // ED-14758 - Under the W3C specification, any keycode sent under IME would return a keycode 229
         // event.isComposing can't be used alone as this also included a virtual keyboard under a keyboardless device, therefore, it seems the best practice would be intercepting the event as below.
         // Some suggested the other workaround maybe listen on`keypress` instead of `keydown`
-        if (!event.isComposing || event.which !== 229 && event.keyCode !== 229) {
+        if (!event.isComposing && event.which !== 229 && event.keyCode !== 229) {
           if (selectedIndex === -1) {
             if (useBetterTypeaheadNavigation) {
               /**

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "187.1.4";
+export const version = "187.2.1";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "187.1.4",
+	"version": "187.2.1",
 	"sideEffects": false
 }

package/dist/esm/labs/next/presets/universal.js

@@ -10,6 +10,7 @@ import { gridPlugin } from '@atlaskit/editor-plugin-grid';
 import { cardPlugin } from '@atlaskit/editor-plugin-card';
 import { tablesPlugin } from '@atlaskit/editor-plugin-table';
 import { contentInsertionPlugin } from '@atlaskit/editor-plugin-content-insertion';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isFullPage as fullPageCheck } from '../../../utils/is-full-page';
 import { getMediaFeatureFlag } from '@atlaskit/media-common';
 import { createDefaultPreset } from './default';
@@ -141,6 +142,9 @@ export default function createUniversalPreset(appearance, props, featureFlags, p
       var tableOptions = !props.allowTables || typeof props.allowTables === 'boolean' ? {} : props.allowTables;
       return builder.add([plugin, {
         tableOptions: tableOptions,
+        // tableResizingEnabled will replace breakoutEnabled once FF is 100% rolled out,
+        // logic below is to help codemod during cleanup
+        tableResizingEnabled: getBooleanFF('platform.editor.custom-table-width') && ['full-page', 'full-width'].includes(appearance || ''),
         breakoutEnabled: appearance === 'full-page',
         allowContextualMenu: !isMobile,
         fullWidthEnabled: appearance === 'full-width',

package/dist/esm/plugins/type-ahead/transforms/open-typeahead-at-cursor.js

@@ -2,7 +2,6 @@ import { TextSelection } from 'prosemirror-state';
 import { GapCursorSelection } from '@atlaskit/editor-common/selection';
 import { pluginKey } from '../pm-plugins/key';
 import { ACTIONS } from '../pm-plugins/actions';
-import { browser } from '@atlaskit/editor-common/utils';
 export var openTypeAhead = function openTypeAhead(props) {
   return function (tr) {
     var triggerHandler = props.triggerHandler,
@@ -54,7 +53,13 @@ export var openTypeAheadAtCursor = function openTypeAheadAtCursor(_ref) {
 
       // ME-2375 remove the superfluous '@' inserted before decoration
       // by composition (https://github.com/ProseMirror/prosemirror/issues/903)
-      if (browser.chrome && browser.android && cursorPos > 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, '@')) {
+      //
+      // Update:
+      // Now also handles any use case with superfluous typeahead triggers (ie. '@', ':', '/')
+      // being inserted due to composition by checking if we have the trigger
+      // directly before the typeahead. This should not happen unless it has
+      // been eroneously added because we require whitespace/newline for typeahead.
+      if (cursorPos >= 2 && !!(selection !== null && selection !== void 0 && (_selection$$head = selection.$head) !== null && _selection$$head !== void 0 && (_selection$$head$pare = _selection$$head.parent) !== null && _selection$$head$pare !== void 0 && _selection$$head$pare.textContent) && (_selection$$head$pare2 = (_selection$$head$pare3 = selection.$head.parent.textContent).endsWith) !== null && _selection$$head$pare2 !== void 0 && _selection$$head$pare2.call(_selection$$head$pare3, triggerHandler.trigger)) {
         tr.delete(cursorPos - 1, cursorPos);
       }
     }

package/dist/esm/plugins/type-ahead/ui/InputQuery.js

@@ -138,7 +138,7 @@ export var InputQuery = /*#__PURE__*/React.memo(function (_ref) {
         // ED-14758 - Under the W3C specification, any keycode sent under IME would return a keycode 229
         // event.isComposing can't be used alone as this also included a virtual keyboard under a keyboardless device, therefore, it seems the best practice would be intercepting the event as below.
         // Some suggested the other workaround maybe listen on`keypress` instead of `keydown`
-        if (!event.isComposing || event.which !== 229 && event.keyCode !== 229) {
+        if (!event.isComposing && event.which !== 229 && event.keyCode !== 229) {
           if (selectedIndex === -1) {
             if (useBetterTypeaheadNavigation) {
               /**

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "187.1.4";
+export var version = "187.2.1";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "187.1.4",
+	"version": "187.2.1",
 	"sideEffects": false
 }

package/dist/types/labs/next/presets/universal.d.ts

@@ -1,11 +1,11 @@
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next';
 import type { EditorAppearance } from '@atlaskit/editor-common/types';
-import { DefaultPresetPluginOptions } from './default';
-import { EditorPresetProps } from './types';
-import { EditorSharedPropsWithPlugins } from '../../../types/editor-props';
-import { FeatureFlags } from '../../../types/feature-flags';
-import { EditorPluginFeatureProps, EditorProviderProps } from '../../../types/editor-props';
-import { EditorPresetBuilder } from '@atlaskit/editor-common/preset';
+import type { DefaultPresetPluginOptions } from './default';
+import type { EditorPresetProps } from './types';
+import type { EditorSharedPropsWithPlugins } from '../../../types/editor-props';
+import type { FeatureFlags } from '../../../types/feature-flags';
+import type { EditorPluginFeatureProps, EditorProviderProps } from '../../../types/editor-props';
+import type { EditorPresetBuilder } from '@atlaskit/editor-common/preset';
 type UniversalPresetProps = EditorPresetProps & DefaultPresetPluginOptions & EditorSharedPropsWithPlugins & EditorPluginFeatureProps & EditorProviderProps;
 /**
  * Creates a preset with all of the available plugins.

package/dist/types/plugins/type-ahead/transforms/open-typeahead-at-cursor.d.ts

@@ -1,4 +1,4 @@
-import { Transaction } from 'prosemirror-state';
+import type { Transaction } from 'prosemirror-state';
 import type { TypeAheadHandler, TypeAheadInputMethod } from '../types';
 type Props = {
     triggerHandler: TypeAheadHandler;

package/dist/types-ts4.5/labs/next/presets/universal.d.ts

@@ -1,11 +1,11 @@
 import type { CreateUIAnalyticsEvent } from '@atlaskit/analytics-next';
 import type { EditorAppearance } from '@atlaskit/editor-common/types';
-import { DefaultPresetPluginOptions } from './default';
-import { EditorPresetProps } from './types';
-import { EditorSharedPropsWithPlugins } from '../../../types/editor-props';
-import { FeatureFlags } from '../../../types/feature-flags';
-import { EditorPluginFeatureProps, EditorProviderProps } from '../../../types/editor-props';
-import { EditorPresetBuilder } from '@atlaskit/editor-common/preset';
+import type { DefaultPresetPluginOptions } from './default';
+import type { EditorPresetProps } from './types';
+import type { EditorSharedPropsWithPlugins } from '../../../types/editor-props';
+import type { FeatureFlags } from '../../../types/feature-flags';
+import type { EditorPluginFeatureProps, EditorProviderProps } from '../../../types/editor-props';
+import type { EditorPresetBuilder } from '@atlaskit/editor-common/preset';
 type UniversalPresetProps = EditorPresetProps & DefaultPresetPluginOptions & EditorSharedPropsWithPlugins & EditorPluginFeatureProps & EditorProviderProps;
 /**
  * Creates a preset with all of the available plugins.

package/dist/types-ts4.5/plugins/type-ahead/transforms/open-typeahead-at-cursor.d.ts

@@ -1,4 +1,4 @@
-import { Transaction } from 'prosemirror-state';
+import type { Transaction } from 'prosemirror-state';
 import type { TypeAheadHandler, TypeAheadInputMethod } from '../types';
 type Props = {
     triggerHandler: TypeAheadHandler;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "187.1.4",
+  "version": "187.2.1",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -69,7 +69,7 @@
     "@atlaskit/editor-plugin-grid": "^0.1.0",
     "@atlaskit/editor-plugin-guideline": "^0.3.4",
     "@atlaskit/editor-plugin-hyperlink": "^0.2.0",
-    "@atlaskit/editor-plugin-table": "^2.3.0",
+    "@atlaskit/editor-plugin-table": "^2.4.0",
     "@atlaskit/editor-plugin-width": "^0.1.0",
     "@atlaskit/editor-shared-styles": "^2.4.0",
     "@atlaskit/editor-tables": "^2.3.0",
@@ -150,7 +150,7 @@
     "@atlaskit/collab-provider": "9.7.2",
     "@atlaskit/dropdown-menu": "^11.10.0",
     "@atlaskit/editor-extension-dropbox": "^0.4.0",
-    "@atlaskit/editor-plugin-table": "^2.3.0",
+    "@atlaskit/editor-plugin-table": "^2.4.0",
     "@atlaskit/editor-test-helpers": "^18.10.0",
     "@atlaskit/flag": "^15.2.0",
     "@atlaskit/icon-object": "^6.3.0",
@@ -235,8 +235,7 @@
       "type": "boolean"
     },
     "platform.editor.custom-table-width": {
-      "type": "boolean",
-      "referenceOnly": "true"
+      "type": "boolean"
     },
     "platform.linking-platform.editor.fix-link-insert-analytics": {
       "type": "boolean"