@atlaskit/editor-core 185.3.0 → 185.4.0

package/dist/cjs/plugins/media/utils/media-common.js

@@ -124,6 +124,9 @@ var removeMediaNode = function removeMediaNode(view, node, getPos) {
     selection = state.selection,
     doc = state.doc;
   var currentMediaNodePos = getPos();
+  if (typeof currentMediaNodePos !== 'number') {
+    return;
+  }
   tr.deleteRange(currentMediaNodePos, currentMediaNodePos + node.nodeSize);
   if ((0, _utils.isTemporary)(id)) {
     tr.setMeta('addToHistory', false);

package/dist/cjs/plugins/placeholder-text/placeholder-text-nodeview.js

@@ -47,6 +47,9 @@ var PlaceholderTextNodeView = /*#__PURE__*/function () {
         e.preventDefault();
         var _view = this.view;
         var startNodePosition = this.getPos();
+        if (typeof startNodePosition !== 'number') {
+          return false;
+        }
         var tr = _view.state.tr;
         tr.setSelection(_prosemirrorState.Selection.near(tr.doc.resolve(startNodePosition)));
         _view.dispatch(tr);
@@ -63,7 +66,10 @@ var PlaceholderTextNodeView = /*#__PURE__*/function () {
       var view = this.view,
         node = this.node;
       var placeholderStartPosition = this.getPos();
-      var placeholderEndPosition = this.getPos() + node.nodeSize;
+      if (typeof placeholderStartPosition !== 'number') {
+        return false;
+      }
+      var placeholderEndPosition = placeholderStartPosition + node.nodeSize;
       var selection = view.state.selection;
 
       // when the selection is set right after the placeholder.

package/dist/cjs/plugins/tasks-and-decisions/nodeviews/taskItem.js

@@ -38,6 +38,9 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleOnChange", function (taskId, isChecked) {
       var tr = _this.view.state.tr;
       var nodePos = _this.getPos();
+      if (typeof nodePos !== 'number') {
+        return false;
+      }
 
       // SetAttrsStep should be used to prevent task updates from being dropped when mapping task ticks
       // from a previous version of the document, such as a published page.
@@ -59,7 +62,11 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
      */
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "addListAnalyticsData", function (event) {
       try {
-        var resolvedPos = _this.view.state.doc.resolve(_this.getPos());
+        var nodePos = _this.getPos();
+        if (typeof nodePos !== 'number') {
+          return false;
+        }
+        var resolvedPos = _this.view.state.doc.resolve(nodePos);
         var position = resolvedPos.index();
         var listSize = resolvedPos.parent.childCount;
         var listLocalId = resolvedPos.parent.attrs.localId;

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "185.3.0";
+var version = "185.4.0";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.3.0",
+	"version": "185.4.0",
 	"sideEffects": false
 }

package/dist/es2019/plugins/card/nodeviews/blockCard.js

@@ -28,11 +28,17 @@ export class BlockCardComponent extends React.PureComponent {
 
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      rafSchedule(() => view.dispatch(registerCard({
-        title,
-        url,
-        pos: getPos()
-      })(view.state.tr)))();
+      rafSchedule(() => {
+        const pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch(registerCard({
+          title,
+          url,
+          pos
+        })(view.state.tr));
+      })();
     });
     _defineProperty(this, "gapCursorSpan", () => {
       // Don't render in EdgeHTMl version <= 18 (Edge version 44)

package/dist/es2019/plugins/card/nodeviews/datasource.js

@@ -0,0 +1,100 @@
+import _defineProperty from "@babel/runtime/helpers/defineProperty";
+/** @jsx jsx */
+import React from 'react';
+import PropTypes from 'prop-types';
+import { css, jsx } from '@emotion/react';
+import ReactNodeView from '@atlaskit/editor-common/react-node-view';
+import { DatasourceTableView } from '@atlaskit/link-datasource';
+const containerStyles = css({
+  height: '500px',
+  overflow: 'auto'
+});
+export class DatasourceComponent extends React.PureComponent {
+  constructor(props) {
+    super(props);
+    _defineProperty(this, "getPosSafely", () => {
+      const {
+        getPos
+      } = this.props;
+      if (!getPos || typeof getPos === 'boolean') {
+        return;
+      }
+      try {
+        return getPos();
+      } catch (e) {
+        // Can blow up in rare cases, when node has been removed.
+      }
+    });
+    _defineProperty(this, "getDatasource", () => this.props.node.attrs.datasource);
+    _defineProperty(this, "getTableView", datasource => {
+      const views = (datasource || this.getDatasource()).views;
+      return views.find(view => view.type === 'table') || undefined;
+    });
+    _defineProperty(this, "handleColumnChange", columnKeys => {
+      const {
+        state,
+        dispatch
+      } = this.props.view;
+      const pos = this.getPosSafely();
+      if (pos === undefined) {
+        return;
+      }
+      const attrs = this.props.node.attrs;
+      const views = [{
+        type: 'table',
+        properties: {
+          columns: columnKeys.map(key => ({
+            key
+          }))
+        }
+      }];
+      const tr = state.tr.setNodeMarkup(pos, undefined, {
+        ...attrs,
+        datasource: {
+          ...attrs.datasource,
+          views
+        }
+      });
+      tr.setMeta('scrollIntoView', false);
+      dispatch(tr);
+    });
+  }
+  render() {
+    const cardContext = this.context.contextAdapter ? this.context.contextAdapter.card : undefined;
+    const datasource = this.getDatasource();
+    const tableView = this.getTableView();
+    if (tableView) {
+      var _tableView$properties;
+      const visibleColumnKeys = (_tableView$properties = tableView.properties) === null || _tableView$properties === void 0 ? void 0 : _tableView$properties.columns.map(({
+        key
+      }) => key);
+
+      // [WS-2307]: we only render card wrapped into a Provider when the value is ready
+      if (cardContext && cardContext.value) {
+        return jsx(cardContext.Provider, {
+          value: cardContext.value
+        }, jsx(DatasourceTableView, {
+          datasourceId: datasource.id,
+          parameters: datasource.parameters,
+          visibleColumnKeys: visibleColumnKeys,
+          onVisibleColumnKeysChange: this.handleColumnChange
+        }));
+      }
+    }
+    return null;
+  }
+}
+_defineProperty(DatasourceComponent, "contextTypes", {
+  contextAdapter: PropTypes.object
+});
+export class Datasource extends ReactNodeView {
+  render() {
+    return jsx("div", {
+      css: containerStyles
+    }, jsx(DatasourceComponent, {
+      node: this.node,
+      view: this.view,
+      getPos: this.getPos
+    }));
+  }
+}

package/dist/es2019/plugins/card/nodeviews/inlineCard.js

@@ -25,11 +25,18 @@ export class InlineCardComponent extends React.PureComponent {
       } = data;
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      rafSchedule(() => view.dispatch(registerCard({
-        title,
-        url,
-        pos: getPos()
-      })(view.state.tr)))();
+      rafSchedule(() => {
+        // prosemirror-bump-fix
+        const pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch(registerCard({
+          title,
+          url,
+          pos
+        })(view.state.tr));
+      })();
     });
     _defineProperty(this, "onError", data => {
       const {

package/dist/es2019/plugins/card/pm-plugins/main.js

@@ -9,6 +9,7 @@ import reducer from './reducers';
 import { handleProvider, resolveWithProvider } from './util/resolve';
 import { getNewRequests, getPluginState, getPluginStateWithUpdatedPos } from './util/state';
 import { createAnalyticsQueue, eventsFromTransaction } from './analytics';
+import { Datasource } from '../nodeviews/datasource';
 export { pluginKey } from './plugin-key';
 export const createPlugin = (options, pluginInjectionApi) => pmPluginFactoryParams => {
   const {
@@ -119,6 +120,9 @@ export const createPlugin = (options, pluginInjectionApi) => pmPluginFactoryPara
             showServerActions
           };
           const hasIntlContext = true;
+          if (node.attrs.datasource) {
+            return new Datasource(node, view, getPos, portalProviderAPI, eventDispatcher, undefined, undefined, true, undefined, hasIntlContext).init();
+          }
           return new BlockCard(node, view, getPos, portalProviderAPI, eventDispatcher, reactComponentProps, undefined, true, undefined, hasIntlContext).init();
         },
         embedCard: (node, view, getPos) => {

package/dist/es2019/plugins/date/nodeviews/date.js

@@ -21,10 +21,11 @@ export function DateNodeView(props) {
     getPos
   } = props;
   const intl = useIntl();
+  const pos = typeof getPos === 'function' ? getPos() : undefined;
 
   // We fall back to selection.$from even though it does not cover all use cases
   // eg. upon Editor init, selection is at the start, not at the Date node
-  const $nodePos = typeof getPos === 'function' ? doc.resolve(getPos()) : selection.$from;
+  const $nodePos = typeof pos === 'number' ? doc.resolve(pos) : selection.$from;
   const parent = $nodePos.parent;
   const withinIncompleteTask = parent.type === schema.nodes.taskItem && parent.attrs.state !== 'DONE';
   const color = withinIncompleteTask && isPastDate(timestamp) ? 'red' : undefined;

package/dist/es2019/plugins/expand/nodeviews/index.js

@@ -79,6 +79,10 @@ export class ExpandNodeView {
       return this.featureFlags && !!this.featureFlags.interactiveExpand;
     });
     _defineProperty(this, "handleClick", event => {
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const target = event.target;
       const {
         state,
@@ -95,7 +99,7 @@ export class ExpandNodeView {
         if (this.view.dom instanceof HTMLElement) {
           this.view.dom.blur();
         }
-        toggleExpandExpanded(this.getPos(), this.node.type)(state, dispatch);
+        toggleExpandExpanded(pos, this.node.type)(state, dispatch);
         return;
       }
       if (target === this.input) {
@@ -105,6 +109,10 @@ export class ExpandNodeView {
       }
     });
     _defineProperty(this, "handleInput", event => {
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const target = event.target;
       if (target === this.input) {
         event.stopPropagation();
@@ -112,7 +120,7 @@ export class ExpandNodeView {
           state,
           dispatch
         } = this.view;
-        updateExpandTitle(target.value, this.getPos(), this.node.type)(state, dispatch);
+        updateExpandTitle(target.value, pos, this.node.type)(state, dispatch);
       }
     });
     _defineProperty(this, "handleFocus", event => {
@@ -145,6 +153,10 @@ export class ExpandNodeView {
       if (!this.input) {
         return;
       }
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const {
         selectionStart,
         selectionEnd
@@ -157,16 +169,20 @@ export class ExpandNodeView {
       } = this.view;
       const expandNode = this.node;
       if (expandNode && isEmptyNode(state.schema)(expandNode)) {
-        deleteExpandAtPos(this.getPos(), expandNode)(state, this.view.dispatch);
+        deleteExpandAtPos(pos, expandNode)(state, this.view.dispatch);
       }
     });
     _defineProperty(this, "toggleExpand", () => {
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       if (this.isAllowInteractiveExpandEnabled()) {
         const {
           state,
           dispatch
         } = this.view;
-        toggleExpandExpanded(this.getPos(), this.node.type)(state, dispatch);
+        toggleExpandExpanded(pos, this.node.type)(state, dispatch);
       }
     });
     _defineProperty(this, "moveToOutsideOfTitle", event => {
@@ -205,6 +221,10 @@ export class ExpandNodeView {
       if (!this.input) {
         return;
       }
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const {
         value,
         selectionStart,
@@ -217,13 +237,17 @@ export class ExpandNodeView {
         } = this.view;
         event.preventDefault();
         this.view.focus();
-        dispatch(state.tr.setSelection(new GapCursorSelection(state.doc.resolve(this.node.nodeSize + this.getPos()), Side.RIGHT)));
+        dispatch(state.tr.setSelection(new GapCursorSelection(state.doc.resolve(this.node.nodeSize + pos), Side.RIGHT)));
       }
     });
     _defineProperty(this, "setLeftGapCursor", event => {
       if (!this.input) {
         return;
       }
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const {
         selectionStart,
         selectionEnd
@@ -235,13 +259,17 @@ export class ExpandNodeView {
           dispatch
         } = this.view;
         this.view.focus();
-        dispatch(state.tr.setSelection(new GapCursorSelection(state.doc.resolve(this.getPos()), Side.LEFT)));
+        dispatch(state.tr.setSelection(new GapCursorSelection(state.doc.resolve(pos), Side.LEFT)));
       }
     });
     _defineProperty(this, "handleArrowRightFromTitle", event => {
       if (!this.input) {
         return;
       }
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const {
         value,
         selectionStart,
@@ -254,13 +282,17 @@ export class ExpandNodeView {
           dispatch
         } = this.view;
         this.view.focus();
-        setSelectionRelativeToNode(RelativeSelectionPos.End, NodeSelection.create(state.doc, this.getPos()))(state, dispatch);
+        setSelectionRelativeToNode(RelativeSelectionPos.End, NodeSelection.create(state.doc, pos))(state, dispatch);
       }
     });
     _defineProperty(this, "handleArrowLeftFromTitle", event => {
       if (!this.input) {
         return;
       }
+      const pos = this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       const {
         selectionStart,
         selectionEnd
@@ -276,9 +308,9 @@ export class ExpandNodeView {
         // selectionRelativeToNode is undefined when user clicked to select node, then hit left to get focus in title
         // This is a special case where we want to bypass node selection and jump straight to gap cursor
         if (getSelectionPluginState(state).selectionRelativeToNode === undefined) {
-          setSelectionRelativeToNode(undefined, new GapCursorSelection(state.doc.resolve(this.getPos()), Side.LEFT))(state, dispatch);
+          setSelectionRelativeToNode(undefined, new GapCursorSelection(state.doc.resolve(pos), Side.LEFT))(state, dispatch);
         } else {
-          setSelectionRelativeToNode(RelativeSelectionPos.Start, NodeSelection.create(state.doc, this.getPos()))(state, dispatch);
+          setSelectionRelativeToNode(RelativeSelectionPos.Start, NodeSelection.create(state.doc, pos))(state, dispatch);
         }
       }
     });
@@ -288,7 +320,6 @@ export class ExpandNodeView {
       contentDOM
     } = DOMSerializer.renderSpec(document, toDOM(node, this.intl));
     this.getPos = getPos;
-    this.pos = getPos();
     this.view = view;
     this.node = node;
     this.dom = dom;

package/dist/es2019/plugins/extension/ui/Extension/Extension/index.js

@@ -26,7 +26,8 @@ function ExtensionWithPluginState(props) {
   const isMobile = editorAppearance === 'mobile';
   const hasChildren = !!children;
   const removeBorder = hideFrame && !isMobile && !hasBody || false;
-  const isTopLevelNode = props.getPos && !isNaN(props.getPos()) && props.view.state.doc.resolve(props.getPos()).depth === 0;
+  const pos = typeof props.getPos === 'function' ? props.getPos() : undefined;
+  const isTopLevelNode = typeof pos !== 'undefined' && !isNaN(pos) && props.view.state.doc.resolve(pos).depth === 0;
   const shouldBreakout =
   // Extension should breakout when the layout is set to 'full-width' or 'wide'.
   ['full-width', 'wide'].includes(node.attrs.layout) &&

package/dist/es2019/plugins/media/commands/captions.js

@@ -16,6 +16,9 @@ export const selectCaptionFromMediaSinglePos = (mediaSingleNodePos, mediaSingleN
   return true;
 };
 export const insertAndSelectCaptionFromMediaSinglePos = (mediaSingleNodePos, mediaSingleNode) => (state, dispatch) => {
+  if (typeof mediaSingleNodePos !== 'number') {
+    return false;
+  }
   let tr = state.tr;
 
   // node should have one child, media

package/dist/es2019/plugins/media/commands/helpers.js

@@ -42,7 +42,7 @@ export const updateAllMediaSingleNodesAttrs = (id, attrs) => (state, dispatch) =
     getPos
   }) => {
     const pos = getPos();
-    if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+    if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
       return acc;
     }
     acc.push(pos);
@@ -61,7 +61,7 @@ export const updateAllMediaSingleNodesAttrs = (id, attrs) => (state, dispatch) =
 };
 export const updateCurrentMediaNodeAttrs = (attrs, mediaNode) => (state, dispatch) => {
   const pos = mediaNode.getPos();
-  if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+  if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
     return false;
   }
   const tr = state.tr;
@@ -80,7 +80,7 @@ export const updateMediaSingleNodeAttrs = (id, attrs) => (state, dispatch) => {
   }
   const tr = state.tr;
   const pos = mediaNodeWithPos.getPos();
-  if (!isMediaNode(pos, state)) {
+  if (typeof pos !== 'number' || !isMediaNode(pos, state)) {
     return false;
   }
   tr.step(new SetAttrsStep(pos, attrs)).setMeta('addToHistory', false);

package/dist/es2019/plugins/media/nodeviews/mediaGroup.js

@@ -13,7 +13,11 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 const isMediaGroupSelectedFromProps = props => {
-  return isNodeSelectedOrInRange(props.anchorPos, props.headPos, props.getPos(), props.node.nodeSize);
+  const pos = props.getPos();
+  if (typeof pos !== 'number') {
+    return false;
+  }
+  return isNodeSelectedOrInRange(props.anchorPos, props.headPos, pos, props.node.nodeSize);
 };
 const hasSelectionChanged = (oldProps, newProps) => {
   if (isMediaGroupSelectedFromProps(oldProps) !== isMediaGroupSelectedFromProps(newProps)) {
@@ -52,7 +56,18 @@ class MediaGroup extends React.Component {
       const oldMediaNodes = this.mediaNodes;
       this.mediaNodes = [];
       node.forEach((item, childOffset) => {
-        const getPos = () => props.getPos() + childOffset + 1;
+        const getPos = () => {
+          const pos = props.getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + childOffset + 1;
+        };
         this.mediaNodes.push(item);
         if (updatedAttrs) {
           this.updateNodeAttrs(props, item, getPos);
@@ -96,7 +111,16 @@ class MediaGroup extends React.Component {
       const items = this.mediaNodes.map((item, idx) => {
         // We declared this to get a fresh position every time
         const getNodePos = () => {
-          return getPos() + idx + 1;
+          const pos = getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + idx + 1;
         };
 
         // Media Inline creates a floating toolbar with the same options, excludes these options if enabled
@@ -154,7 +178,18 @@ class MediaGroup extends React.Component {
         node,
         isMediaSingle: false
       });
-      const getPos = () => this.props.getPos() + 1;
+      const getPos = () => {
+        const pos = this.props.getPos();
+        if (typeof pos !== 'number') {
+          // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+          // Because the original code would return NaN on runtime
+          // We are just make it explict now.
+          // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+          // TODO: ED-13910 prosemirror-bump leftovers
+          return NaN;
+        }
+        return pos + 1;
+      };
       const contextId = mediaNodeUpdater.getNodeContextId();
       if (!contextId) {
         await mediaNodeUpdater.updateNodeContextId(getPos);

package/dist/es2019/plugins/media/nodeviews/mediaNodeUpdater.js

@@ -126,7 +126,11 @@ export class MediaNodeUpdater {
             uploadableFileUpfrontIds,
             dimensions
           } = uploader;
-          replaceExternalMedia(getPos() + 1, {
+          const pos = getPos();
+          if (typeof pos !== 'number') {
+            return;
+          }
+          replaceExternalMedia(pos + 1, {
             id: uploadableFileUpfrontIds.id,
             collection,
             height: dimensions.height,
@@ -230,7 +234,11 @@ export class MediaNodeUpdater {
         occurrenceKey: uuidV4()
       };
       const mediaFile = await mediaClient.file.copyFile(source, destination);
-      replaceExternalMedia(getPos() + 1, {
+      const pos = getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
+      replaceExternalMedia(pos + 1, {
         id: mediaFile.id,
         collection: currentCollectionName,
         height,

package/dist/es2019/plugins/media/nodeviews/mediaNodeView/media.js

@@ -30,10 +30,14 @@ export class MediaNode extends Component {
       this.selectMediaSingle(event);
     });
     _defineProperty(this, "selectMediaSingle", event => {
+      const propPos = this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      const propPos = this.props.getPos();
       const {
         state
       } = this.props.view;

package/dist/es2019/plugins/media/nodeviews/mediaSingle.js

@@ -99,10 +99,14 @@ export default class MediaSingleNode extends Component {
     _defineProperty(this, "selectMediaSingle", ({
       event
     }) => {
+      const propPos = this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      const propPos = this.props.getPos();
       const {
         state
       } = this.props.view;
@@ -180,6 +184,9 @@ export default class MediaSingleNode extends Component {
       insertAndSelectCaptionFromMediaSinglePos(getPos(), node)(view.state, view.dispatch);
     });
     _defineProperty(this, "getLineLength", (view, pos) => {
+      if (typeof pos !== 'number') {
+        return null;
+      }
       if (isRichMediaInsideOfBlockNode(view, pos)) {
         const $pos = view.state.doc.resolve(pos);
         const domNode = view.nodeDOM($pos.pos);

package/dist/es2019/plugins/media/pm-plugins/main.js

@@ -237,7 +237,11 @@ export class MediaPluginStateImplementation {
     _defineProperty(this, "handleMediaNodeRemoval", (node, getPos) => {
       let getNode = node;
       if (!getNode) {
-        getNode = this.view.state.doc.nodeAt(getPos());
+        const pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        getNode = this.view.state.doc.nodeAt(pos);
       }
       removeMediaNode(this.view, getNode, getPos);
     });

package/dist/es2019/plugins/media/utils/media-common.js

@@ -123,6 +123,9 @@ export const removeMediaNode = (view, node, getPos) => {
     doc
   } = state;
   const currentMediaNodePos = getPos();
+  if (typeof currentMediaNodePos !== 'number') {
+    return;
+  }
   tr.deleteRange(currentMediaNodePos, currentMediaNodePos + node.nodeSize);
   if (isTemporary(id)) {
     tr.setMeta('addToHistory', false);

package/dist/es2019/plugins/placeholder-text/placeholder-text-nodeview.js

@@ -37,6 +37,9 @@ export class PlaceholderTextNodeView {
         view
       } = this;
       const startNodePosition = this.getPos();
+      if (typeof startNodePosition !== 'number') {
+        return false;
+      }
       const tr = view.state.tr;
       tr.setSelection(Selection.near(tr.doc.resolve(startNodePosition)));
       view.dispatch(tr);
@@ -53,7 +56,10 @@ export class PlaceholderTextNodeView {
       node
     } = this;
     const placeholderStartPosition = this.getPos();
-    const placeholderEndPosition = this.getPos() + node.nodeSize;
+    if (typeof placeholderStartPosition !== 'number') {
+      return false;
+    }
+    const placeholderEndPosition = placeholderStartPosition + node.nodeSize;
     const selection = view.state.selection;
 
     // when the selection is set right after the placeholder.