@atlaskit/editor-core 185.3.0 → 185.3.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 185.3.1
+
+### Patch Changes
+
+- [`18344c31ea3`](https://bitbucket.org/atlassian/atlassian-frontend/commits/18344c31ea3) - [ED-13910] Fix EditorView getPos type
+
 ## 185.3.0
 
 ### Minor Changes

package/dist/cjs/plugins/card/nodeviews/blockCard.js

@@ -47,10 +47,14 @@ var BlockCardComponent = /*#__PURE__*/function (_React$PureComponent) {
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
       (0, _rafSchd.default)(function () {
-        return view.dispatch((0, _actions.registerCard)({
+        var pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch((0, _actions.registerCard)({
           title: title,
           url: url,
-          pos: getPos()
+          pos: pos
         })(view.state.tr));
       })();
     });

package/dist/cjs/plugins/card/nodeviews/inlineCard.js

@@ -45,10 +45,15 @@ var InlineCardComponent = /*#__PURE__*/function (_React$PureComponent) {
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
       (0, _rafSchd.default)(function () {
-        return view.dispatch((0, _actions.registerCard)({
+        // prosemirror-bump-fix
+        var pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch((0, _actions.registerCard)({
           title: title,
           url: url,
-          pos: getPos()
+          pos: pos
         })(view.state.tr));
       })();
     });

package/dist/cjs/plugins/date/nodeviews/date.js

@@ -19,10 +19,11 @@ function DateNodeView(props) {
     selection = _props$view$state.selection,
     getPos = props.getPos;
   var intl = (0, _reactIntlNext.useIntl)();
+  var pos = typeof getPos === 'function' ? getPos() : undefined;
 
   // We fall back to selection.$from even though it does not cover all use cases
   // eg. upon Editor init, selection is at the start, not at the Date node
-  var $nodePos = typeof getPos === 'function' ? doc.resolve(getPos()) : selection.$from;
+  var $nodePos = typeof pos === 'number' ? doc.resolve(pos) : selection.$from;
   var parent = $nodePos.parent;
   var withinIncompleteTask = parent.type === schema.nodes.taskItem && parent.attrs.state !== 'DONE';
   var color = withinIncompleteTask && (0, _utils.isPastDate)(timestamp) ? 'red' : undefined;

package/dist/cjs/plugins/expand/nodeviews/index.js

@@ -92,6 +92,10 @@ var ExpandNodeView = /*#__PURE__*/function () {
       return _this.featureFlags && !!_this.featureFlags.interactiveExpand;
     });
     (0, _defineProperty2.default)(this, "handleClick", function (event) {
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var target = event.target;
       var _this$view2 = _this.view,
         state = _this$view2.state,
@@ -107,7 +111,7 @@ var ExpandNodeView = /*#__PURE__*/function () {
         if (_this.view.dom instanceof HTMLElement) {
           _this.view.dom.blur();
         }
-        (0, _commands.toggleExpandExpanded)(_this.getPos(), _this.node.type)(state, dispatch);
+        (0, _commands.toggleExpandExpanded)(pos, _this.node.type)(state, dispatch);
         return;
       }
       if (target === _this.input) {
@@ -117,13 +121,17 @@ var ExpandNodeView = /*#__PURE__*/function () {
       }
     });
     (0, _defineProperty2.default)(this, "handleInput", function (event) {
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var target = event.target;
       if (target === _this.input) {
         event.stopPropagation();
         var _this$view3 = _this.view,
           state = _this$view3.state,
           dispatch = _this$view3.dispatch;
-        (0, _commands.updateExpandTitle)(target.value, _this.getPos(), _this.node.type)(state, dispatch);
+        (0, _commands.updateExpandTitle)(target.value, pos, _this.node.type)(state, dispatch);
       }
     });
     (0, _defineProperty2.default)(this, "handleFocus", function (event) {
@@ -156,6 +164,10 @@ var ExpandNodeView = /*#__PURE__*/function () {
       if (!_this.input) {
         return;
       }
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var _this$input = _this.input,
         selectionStart = _this$input.selectionStart,
         selectionEnd = _this$input.selectionEnd;
@@ -165,15 +177,19 @@ var ExpandNodeView = /*#__PURE__*/function () {
       var state = _this.view.state;
       var expandNode = _this.node;
       if (expandNode && (0, _utils.isEmptyNode)(state.schema)(expandNode)) {
-        (0, _commands.deleteExpandAtPos)(_this.getPos(), expandNode)(state, _this.view.dispatch);
+        (0, _commands.deleteExpandAtPos)(pos, expandNode)(state, _this.view.dispatch);
       }
     });
     (0, _defineProperty2.default)(this, "toggleExpand", function () {
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       if (_this.isAllowInteractiveExpandEnabled()) {
         var _this$view4 = _this.view,
           state = _this$view4.state,
           dispatch = _this$view4.dispatch;
-        (0, _commands.toggleExpandExpanded)(_this.getPos(), _this.node.type)(state, dispatch);
+        (0, _commands.toggleExpandExpanded)(pos, _this.node.type)(state, dispatch);
       }
     });
     (0, _defineProperty2.default)(this, "moveToOutsideOfTitle", function (event) {
@@ -211,6 +227,10 @@ var ExpandNodeView = /*#__PURE__*/function () {
       if (!_this.input) {
         return;
       }
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var _this$input2 = _this.input,
         value = _this$input2.value,
         selectionStart = _this$input2.selectionStart,
@@ -221,13 +241,17 @@ var ExpandNodeView = /*#__PURE__*/function () {
           dispatch = _this$view6.dispatch;
         event.preventDefault();
         _this.view.focus();
-        dispatch(state.tr.setSelection(new _gapCursorSelection.GapCursorSelection(state.doc.resolve(_this.node.nodeSize + _this.getPos()), _gapCursorSelection.Side.RIGHT)));
+        dispatch(state.tr.setSelection(new _gapCursorSelection.GapCursorSelection(state.doc.resolve(_this.node.nodeSize + pos), _gapCursorSelection.Side.RIGHT)));
       }
     });
     (0, _defineProperty2.default)(this, "setLeftGapCursor", function (event) {
       if (!_this.input) {
         return;
       }
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var _this$input3 = _this.input,
         selectionStart = _this$input3.selectionStart,
         selectionEnd = _this$input3.selectionEnd;
@@ -237,13 +261,17 @@ var ExpandNodeView = /*#__PURE__*/function () {
           state = _this$view7.state,
           dispatch = _this$view7.dispatch;
         _this.view.focus();
-        dispatch(state.tr.setSelection(new _gapCursorSelection.GapCursorSelection(state.doc.resolve(_this.getPos()), _gapCursorSelection.Side.LEFT)));
+        dispatch(state.tr.setSelection(new _gapCursorSelection.GapCursorSelection(state.doc.resolve(pos), _gapCursorSelection.Side.LEFT)));
       }
     });
     (0, _defineProperty2.default)(this, "handleArrowRightFromTitle", function (event) {
       if (!_this.input) {
         return;
       }
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var _this$input4 = _this.input,
         value = _this$input4.value,
         selectionStart = _this$input4.selectionStart,
@@ -254,13 +282,17 @@ var ExpandNodeView = /*#__PURE__*/function () {
           state = _this$view8.state,
           dispatch = _this$view8.dispatch;
         _this.view.focus();
-        (0, _commands2.setSelectionRelativeToNode)(_types.RelativeSelectionPos.End, _prosemirrorState.NodeSelection.create(state.doc, _this.getPos()))(state, dispatch);
+        (0, _commands2.setSelectionRelativeToNode)(_types.RelativeSelectionPos.End, _prosemirrorState.NodeSelection.create(state.doc, pos))(state, dispatch);
       }
     });
     (0, _defineProperty2.default)(this, "handleArrowLeftFromTitle", function (event) {
       if (!_this.input) {
         return;
       }
+      var pos = _this.getPos();
+      if (typeof pos !== 'number') {
+        return;
+      }
       var _this$input5 = _this.input,
         selectionStart = _this$input5.selectionStart,
         selectionEnd = _this$input5.selectionEnd;
@@ -274,9 +306,9 @@ var ExpandNodeView = /*#__PURE__*/function () {
         // selectionRelativeToNode is undefined when user clicked to select node, then hit left to get focus in title
         // This is a special case where we want to bypass node selection and jump straight to gap cursor
         if ((0, _pluginFactory.getPluginState)(state).selectionRelativeToNode === undefined) {
-          (0, _commands2.setSelectionRelativeToNode)(undefined, new _gapCursorSelection.GapCursorSelection(state.doc.resolve(_this.getPos()), _gapCursorSelection.Side.LEFT))(state, dispatch);
+          (0, _commands2.setSelectionRelativeToNode)(undefined, new _gapCursorSelection.GapCursorSelection(state.doc.resolve(pos), _gapCursorSelection.Side.LEFT))(state, dispatch);
         } else {
-          (0, _commands2.setSelectionRelativeToNode)(_types.RelativeSelectionPos.Start, _prosemirrorState.NodeSelection.create(state.doc, _this.getPos()))(state, dispatch);
+          (0, _commands2.setSelectionRelativeToNode)(_types.RelativeSelectionPos.Start, _prosemirrorState.NodeSelection.create(state.doc, pos))(state, dispatch);
         }
       }
     });
@@ -285,7 +317,6 @@ var ExpandNodeView = /*#__PURE__*/function () {
       dom = _DOMSerializer$render.dom,
       contentDOM = _DOMSerializer$render.contentDOM;
     this.getPos = getPos;
-    this.pos = getPos();
     this.view = view;
     this.node = node;
     this.dom = dom;

package/dist/cjs/plugins/extension/ui/Extension/Extension/index.js

@@ -38,7 +38,8 @@ function ExtensionWithPluginState(props) {
   var isMobile = editorAppearance === 'mobile';
   var hasChildren = !!children;
   var removeBorder = hideFrame && !isMobile && !hasBody || false;
-  var isTopLevelNode = props.getPos && !isNaN(props.getPos()) && props.view.state.doc.resolve(props.getPos()).depth === 0;
+  var pos = typeof props.getPos === 'function' ? props.getPos() : undefined;
+  var isTopLevelNode = typeof pos !== 'undefined' && !isNaN(pos) && props.view.state.doc.resolve(pos).depth === 0;
   var shouldBreakout =
   // Extension should breakout when the layout is set to 'full-width' or 'wide'.
   ['full-width', 'wide'].includes(node.attrs.layout) &&

package/dist/cjs/plugins/media/commands/captions.js

@@ -26,6 +26,9 @@ var selectCaptionFromMediaSinglePos = function selectCaptionFromMediaSinglePos(m
 exports.selectCaptionFromMediaSinglePos = selectCaptionFromMediaSinglePos;
 var insertAndSelectCaptionFromMediaSinglePos = function insertAndSelectCaptionFromMediaSinglePos(mediaSingleNodePos, mediaSingleNode) {
   return function (state, dispatch) {
+    if (typeof mediaSingleNodePos !== 'number') {
+      return false;
+    }
     var tr = state.tr;
 
     // node should have one child, media

package/dist/cjs/plugins/media/commands/helpers.js

@@ -51,7 +51,7 @@ var updateAllMediaSingleNodesAttrs = function updateAllMediaSingleNodesAttrs(id,
     var validMediaNodePositions = mediaNodes.reduce(function (acc, _ref) {
       var getPos = _ref.getPos;
       var pos = getPos();
-      if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+      if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
         return acc;
       }
       acc.push(pos);
@@ -75,7 +75,7 @@ exports.updateAllMediaSingleNodesAttrs = updateAllMediaSingleNodesAttrs;
 var updateCurrentMediaNodeAttrs = function updateCurrentMediaNodeAttrs(attrs, mediaNode) {
   return function (state, dispatch) {
     var pos = mediaNode.getPos();
-    if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+    if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
       return false;
     }
     var tr = state.tr;
@@ -97,7 +97,7 @@ var updateMediaSingleNodeAttrs = function updateMediaSingleNodeAttrs(id, attrs)
     }
     var tr = state.tr;
     var pos = mediaNodeWithPos.getPos();
-    if (!isMediaNode(pos, state)) {
+    if (typeof pos !== 'number' || !isMediaNode(pos, state)) {
       return false;
     }
     tr.step(new _steps.SetAttrsStep(pos, attrs)).setMeta('addToHistory', false);

package/dist/cjs/plugins/media/nodeviews/mediaGroup.js

@@ -32,7 +32,11 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 var isMediaGroupSelectedFromProps = function isMediaGroupSelectedFromProps(props) {
-  return (0, _nodes.isNodeSelectedOrInRange)(props.anchorPos, props.headPos, props.getPos(), props.node.nodeSize);
+  var pos = props.getPos();
+  if (typeof pos !== 'number') {
+    return false;
+  }
+  return (0, _nodes.isNodeSelectedOrInRange)(props.anchorPos, props.headPos, pos, props.node.nodeSize);
 };
 var hasSelectionChanged = function hasSelectionChanged(oldProps, newProps) {
   if (isMediaGroupSelectedFromProps(oldProps) !== isMediaGroupSelectedFromProps(newProps)) {
@@ -73,7 +77,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
       _this.mediaNodes = [];
       node.forEach(function (item, childOffset) {
         var getPos = function getPos() {
-          return props.getPos() + childOffset + 1;
+          var pos = props.getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + childOffset + 1;
         };
         _this.mediaNodes.push(item);
         if (updatedAttrs) {
@@ -115,7 +128,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
       var items = _this.mediaNodes.map(function (item, idx) {
         // We declared this to get a fresh position every time
         var getNodePos = function getNodePos() {
-          return getPos() + idx + 1;
+          var pos = getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + idx + 1;
         };
 
         // Media Inline creates a floating toolbar with the same options, excludes these options if enabled
@@ -182,7 +204,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
                   isMediaSingle: false
                 });
                 getPos = function getPos() {
-                  return _this2.props.getPos() + 1;
+                  var pos = _this2.props.getPos();
+                  if (typeof pos !== 'number') {
+                    // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+                    // Because the original code would return NaN on runtime
+                    // We are just make it explict now.
+                    // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+                    // TODO: ED-13910 prosemirror-bump leftovers
+                    return NaN;
+                  }
+                  return pos + 1;
                 };
                 contextId = mediaNodeUpdater.getNodeContextId();
                 if (contextId) {

package/dist/cjs/plugins/media/nodeviews/mediaNodeUpdater.js

@@ -223,7 +223,7 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
     })));
     (0, _defineProperty2.default)(this, "uploadExternalMedia", /*#__PURE__*/function () {
       var _ref8 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee7(getPos) {
-        var node, mediaProvider, uploadMediaClientConfig, mediaClient, collection, uploader, uploadableFileUpfrontIds, dimensions;
+        var node, mediaProvider, uploadMediaClientConfig, mediaClient, collection, uploader, uploadableFileUpfrontIds, dimensions, pos;
         return _regenerator.default.wrap(function _callee7$(_context7) {
           while (1) switch (_context7.prev = _context7.next) {
             case 0:
@@ -233,7 +233,7 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
             case 3:
               mediaProvider = _context7.sent;
               if (!(node && mediaProvider)) {
-                _context7.next = 21;
+                _context7.next = 24;
                 break;
               }
               uploadMediaClientConfig = mediaProvider.uploadMediaClientConfig;
@@ -251,17 +251,24 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
             case 13:
               uploader = _context7.sent;
               uploadableFileUpfrontIds = uploader.uploadableFileUpfrontIds, dimensions = uploader.dimensions;
-              (0, _helpers.replaceExternalMedia)(getPos() + 1, {
+              pos = getPos();
+              if (!(typeof pos !== 'number')) {
+                _context7.next = 18;
+                break;
+              }
+              return _context7.abrupt("return");
+            case 18:
+              (0, _helpers.replaceExternalMedia)(pos + 1, {
                 id: uploadableFileUpfrontIds.id,
                 collection: collection,
                 height: dimensions.height,
                 width: dimensions.width,
                 occurrenceKey: uploadableFileUpfrontIds.occurrenceKey
               })(_this.props.view.state, _this.props.view.dispatch);
-              _context7.next = 21;
+              _context7.next = 24;
               break;
-            case 18:
-              _context7.prev = 18;
+            case 21:
+              _context7.prev = 21;
               _context7.t0 = _context7["catch"](10);
               //keep it as external media
               if (_this.props.dispatchAnalyticsEvent) {
@@ -271,11 +278,11 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
                   eventType: _analytics.EVENT_TYPE.OPERATIONAL
                 });
               }
-            case 21:
+            case 24:
             case "end":
               return _context7.stop();
           }
-        }, _callee7, null, [[10, 18]]);
+        }, _callee7, null, [[10, 21]]);
       }));
       return function (_x3) {
         return _ref8.apply(this, arguments);
@@ -367,7 +374,7 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
     })));
     (0, _defineProperty2.default)(this, "copyNodeFromBlobUrl", /*#__PURE__*/function () {
       var _ref11 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee10(getPos) {
-        var attrs, url, mediaAttrs, mediaProvider, currentCollectionName, contextId, id, collection, height, width, mimeType, name, size, uploadMediaClientConfig, mediaClient, auth, source, destination, mediaFile;
+        var attrs, url, mediaAttrs, mediaProvider, currentCollectionName, contextId, id, collection, height, width, mimeType, name, size, uploadMediaClientConfig, mediaClient, auth, source, destination, mediaFile, pos;
         return _regenerator.default.wrap(function _callee10$(_context10) {
           while (1) switch (_context10.prev = _context10.next) {
             case 0:
@@ -426,7 +433,14 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
               return mediaClient.file.copyFile(source, destination);
             case 25:
               mediaFile = _context10.sent;
-              (0, _helpers.replaceExternalMedia)(getPos() + 1, {
+              pos = getPos();
+              if (!(typeof pos !== 'number')) {
+                _context10.next = 29;
+                break;
+              }
+              return _context10.abrupt("return");
+            case 29:
+              (0, _helpers.replaceExternalMedia)(pos + 1, {
                 id: mediaFile.id,
                 collection: currentCollectionName,
                 height: height,
@@ -435,7 +449,7 @@ var MediaNodeUpdater = /*#__PURE__*/function () {
                 __fileMimeType: mimeType,
                 __fileSize: size
               })(_this.props.view.state, _this.props.view.dispatch);
-            case 27:
+            case 30:
             case "end":
               return _context10.stop();
           }

package/dist/cjs/plugins/media/nodeviews/mediaNodeView/media.js

@@ -67,10 +67,14 @@ var MediaNode = /*#__PURE__*/function (_Component) {
       _this.selectMediaSingle(event);
     });
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "selectMediaSingle", function (event) {
+      var propPos = _this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      var propPos = _this.props.getPos();
       var state = _this.props.view.state;
       if (event.shiftKey) {
         // don't select text if there is current selection in a table (as this would override selected cells)

package/dist/cjs/plugins/media/nodeviews/mediaSingle.js

@@ -177,10 +177,14 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
     }());
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "selectMediaSingle", function (_ref3) {
       var event = _ref3.event;
+      var propPos = _this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      var propPos = _this.props.getPos();
       var state = _this.props.view.state;
       if (event.shiftKey) {
         // don't select text if there is current selection in a table (as this would override selected cells)
@@ -252,6 +256,9 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
       (0, _captions.insertAndSelectCaptionFromMediaSinglePos)(getPos(), node)(view.state, view.dispatch);
     });
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "getLineLength", function (view, pos) {
+      if (typeof pos !== 'number') {
+        return null;
+      }
       if ((0, _utils.isRichMediaInsideOfBlockNode)(view, pos)) {
         var $pos = view.state.doc.resolve(pos);
         var domNode = view.nodeDOM($pos.pos);

package/dist/cjs/plugins/media/pm-plugins/main.js

@@ -308,7 +308,11 @@ var MediaPluginStateImplementation = /*#__PURE__*/function () {
     (0, _defineProperty2.default)(this, "handleMediaNodeRemoval", function (node, getPos) {
       var getNode = node;
       if (!getNode) {
-        getNode = _this.view.state.doc.nodeAt(getPos());
+        var pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        getNode = _this.view.state.doc.nodeAt(pos);
       }
       (0, _mediaCommon.removeMediaNode)(_this.view, getNode, getPos);
     });

package/dist/cjs/plugins/media/utils/media-common.js

@@ -124,6 +124,9 @@ var removeMediaNode = function removeMediaNode(view, node, getPos) {
     selection = state.selection,
     doc = state.doc;
   var currentMediaNodePos = getPos();
+  if (typeof currentMediaNodePos !== 'number') {
+    return;
+  }
   tr.deleteRange(currentMediaNodePos, currentMediaNodePos + node.nodeSize);
   if ((0, _utils.isTemporary)(id)) {
     tr.setMeta('addToHistory', false);

package/dist/cjs/plugins/placeholder-text/placeholder-text-nodeview.js

@@ -47,6 +47,9 @@ var PlaceholderTextNodeView = /*#__PURE__*/function () {
         e.preventDefault();
         var _view = this.view;
         var startNodePosition = this.getPos();
+        if (typeof startNodePosition !== 'number') {
+          return false;
+        }
         var tr = _view.state.tr;
         tr.setSelection(_prosemirrorState.Selection.near(tr.doc.resolve(startNodePosition)));
         _view.dispatch(tr);
@@ -63,7 +66,10 @@ var PlaceholderTextNodeView = /*#__PURE__*/function () {
       var view = this.view,
         node = this.node;
       var placeholderStartPosition = this.getPos();
-      var placeholderEndPosition = this.getPos() + node.nodeSize;
+      if (typeof placeholderStartPosition !== 'number') {
+        return false;
+      }
+      var placeholderEndPosition = placeholderStartPosition + node.nodeSize;
       var selection = view.state.selection;
 
       // when the selection is set right after the placeholder.

package/dist/cjs/plugins/tasks-and-decisions/nodeviews/taskItem.js

@@ -38,6 +38,9 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleOnChange", function (taskId, isChecked) {
       var tr = _this.view.state.tr;
       var nodePos = _this.getPos();
+      if (typeof nodePos !== 'number') {
+        return false;
+      }
 
       // SetAttrsStep should be used to prevent task updates from being dropped when mapping task ticks
       // from a previous version of the document, such as a published page.
@@ -59,7 +62,11 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
      */
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "addListAnalyticsData", function (event) {
       try {
-        var resolvedPos = _this.view.state.doc.resolve(_this.getPos());
+        var nodePos = _this.getPos();
+        if (typeof nodePos !== 'number') {
+          return false;
+        }
+        var resolvedPos = _this.view.state.doc.resolve(nodePos);
         var position = resolvedPos.index();
         var listSize = resolvedPos.parent.childCount;
         var listLocalId = resolvedPos.parent.attrs.localId;

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "185.3.0";
+var version = "185.3.1";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.3.0",
+	"version": "185.3.1",
 	"sideEffects": false
 }

package/dist/es2019/plugins/card/nodeviews/blockCard.js

@@ -28,11 +28,17 @@ export class BlockCardComponent extends React.PureComponent {
 
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      rafSchedule(() => view.dispatch(registerCard({
-        title,
-        url,
-        pos: getPos()
-      })(view.state.tr)))();
+      rafSchedule(() => {
+        const pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch(registerCard({
+          title,
+          url,
+          pos
+        })(view.state.tr));
+      })();
     });
     _defineProperty(this, "gapCursorSpan", () => {
       // Don't render in EdgeHTMl version <= 18 (Edge version 44)

package/dist/es2019/plugins/card/nodeviews/inlineCard.js

@@ -25,11 +25,18 @@ export class InlineCardComponent extends React.PureComponent {
       } = data;
       // don't dispatch immediately since we might be in the middle of
       // rendering a nodeview
-      rafSchedule(() => view.dispatch(registerCard({
-        title,
-        url,
-        pos: getPos()
-      })(view.state.tr)))();
+      rafSchedule(() => {
+        // prosemirror-bump-fix
+        const pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        view.dispatch(registerCard({
+          title,
+          url,
+          pos
+        })(view.state.tr));
+      })();
     });
     _defineProperty(this, "onError", data => {
       const {

package/dist/es2019/plugins/date/nodeviews/date.js

@@ -21,10 +21,11 @@ export function DateNodeView(props) {
     getPos
   } = props;
   const intl = useIntl();
+  const pos = typeof getPos === 'function' ? getPos() : undefined;
 
   // We fall back to selection.$from even though it does not cover all use cases
   // eg. upon Editor init, selection is at the start, not at the Date node
-  const $nodePos = typeof getPos === 'function' ? doc.resolve(getPos()) : selection.$from;
+  const $nodePos = typeof pos === 'number' ? doc.resolve(pos) : selection.$from;
   const parent = $nodePos.parent;
   const withinIncompleteTask = parent.type === schema.nodes.taskItem && parent.attrs.state !== 'DONE';
   const color = withinIncompleteTask && isPastDate(timestamp) ? 'red' : undefined;