@atlaskit/editor-core 185.2.27 → 185.3.1

package/dist/esm/plugins/media/commands/helpers.js

@@ -41,7 +41,7 @@ export var updateAllMediaSingleNodesAttrs = function updateAllMediaSingleNodesAt
     var validMediaNodePositions = mediaNodes.reduce(function (acc, _ref) {
       var getPos = _ref.getPos;
       var pos = getPos();
-      if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+      if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
         return acc;
       }
       acc.push(pos);
@@ -64,7 +64,7 @@ export var updateAllMediaSingleNodesAttrs = function updateAllMediaSingleNodesAt
 export var updateCurrentMediaNodeAttrs = function updateCurrentMediaNodeAttrs(attrs, mediaNode) {
   return function (state, dispatch) {
     var pos = mediaNode.getPos();
-    if (isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
+    if (typeof pos !== 'number' || isNaN(pos) || typeof pos === 'number' && !isMediaNode(pos, state)) {
       return false;
     }
     var tr = state.tr;
@@ -85,7 +85,7 @@ export var updateMediaSingleNodeAttrs = function updateMediaSingleNodeAttrs(id,
     }
     var tr = state.tr;
     var pos = mediaNodeWithPos.getPos();
-    if (!isMediaNode(pos, state)) {
+    if (typeof pos !== 'number' || !isMediaNode(pos, state)) {
       return false;
     }
     tr.step(new SetAttrsStep(pos, attrs)).setMeta('addToHistory', false);

package/dist/esm/plugins/media/nodeviews/mediaGroup.js

@@ -25,7 +25,11 @@ import { injectIntl } from 'react-intl-next';
 import { messages } from './messages';
 import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 var isMediaGroupSelectedFromProps = function isMediaGroupSelectedFromProps(props) {
-  return isNodeSelectedOrInRange(props.anchorPos, props.headPos, props.getPos(), props.node.nodeSize);
+  var pos = props.getPos();
+  if (typeof pos !== 'number') {
+    return false;
+  }
+  return isNodeSelectedOrInRange(props.anchorPos, props.headPos, pos, props.node.nodeSize);
 };
 var hasSelectionChanged = function hasSelectionChanged(oldProps, newProps) {
   if (isMediaGroupSelectedFromProps(oldProps) !== isMediaGroupSelectedFromProps(newProps)) {
@@ -66,7 +70,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
       _this.mediaNodes = [];
       node.forEach(function (item, childOffset) {
         var getPos = function getPos() {
-          return props.getPos() + childOffset + 1;
+          var pos = props.getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + childOffset + 1;
         };
         _this.mediaNodes.push(item);
         if (updatedAttrs) {
@@ -108,7 +121,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
       var items = _this.mediaNodes.map(function (item, idx) {
         // We declared this to get a fresh position every time
         var getNodePos = function getNodePos() {
-          return getPos() + idx + 1;
+          var pos = getPos();
+          if (typeof pos !== 'number') {
+            // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+            // Because the original code would return NaN on runtime
+            // We are just make it explict now.
+            // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+            // TODO: ED-13910 prosemirror-bump leftovers
+            return NaN;
+          }
+          return pos + idx + 1;
         };
 
         // Media Inline creates a floating toolbar with the same options, excludes these options if enabled
@@ -175,7 +197,16 @@ var MediaGroup = /*#__PURE__*/function (_React$Component) {
                   isMediaSingle: false
                 });
                 getPos = function getPos() {
-                  return _this2.props.getPos() + 1;
+                  var pos = _this2.props.getPos();
+                  if (typeof pos !== 'number') {
+                    // That may seems weird, but the previous type wasn't match with the real ProseMirror code. And a lot of Media API was built expecting a number
+                    // Because the original code would return NaN on runtime
+                    // We are just make it explict now.
+                    // We may run a deep investagation on Media code to figure out a better fix. But, for now, we want to keep the current behavior.
+                    // TODO: ED-13910 prosemirror-bump leftovers
+                    return NaN;
+                  }
+                  return pos + 1;
                 };
                 contextId = mediaNodeUpdater.getNodeContextId();
                 if (contextId) {

package/dist/esm/plugins/media/nodeviews/mediaNodeUpdater.js

@@ -216,7 +216,7 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
     })));
     _defineProperty(this, "uploadExternalMedia", /*#__PURE__*/function () {
       var _ref8 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7(getPos) {
-        var node, mediaProvider, uploadMediaClientConfig, mediaClient, collection, uploader, uploadableFileUpfrontIds, dimensions;
+        var node, mediaProvider, uploadMediaClientConfig, mediaClient, collection, uploader, uploadableFileUpfrontIds, dimensions, pos;
         return _regeneratorRuntime.wrap(function _callee7$(_context7) {
           while (1) switch (_context7.prev = _context7.next) {
             case 0:
@@ -226,7 +226,7 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
             case 3:
               mediaProvider = _context7.sent;
               if (!(node && mediaProvider)) {
-                _context7.next = 21;
+                _context7.next = 24;
                 break;
               }
               uploadMediaClientConfig = mediaProvider.uploadMediaClientConfig;
@@ -244,17 +244,24 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
             case 13:
               uploader = _context7.sent;
               uploadableFileUpfrontIds = uploader.uploadableFileUpfrontIds, dimensions = uploader.dimensions;
-              replaceExternalMedia(getPos() + 1, {
+              pos = getPos();
+              if (!(typeof pos !== 'number')) {
+                _context7.next = 18;
+                break;
+              }
+              return _context7.abrupt("return");
+            case 18:
+              replaceExternalMedia(pos + 1, {
                 id: uploadableFileUpfrontIds.id,
                 collection: collection,
                 height: dimensions.height,
                 width: dimensions.width,
                 occurrenceKey: uploadableFileUpfrontIds.occurrenceKey
               })(_this.props.view.state, _this.props.view.dispatch);
-              _context7.next = 21;
+              _context7.next = 24;
               break;
-            case 18:
-              _context7.prev = 18;
+            case 21:
+              _context7.prev = 21;
               _context7.t0 = _context7["catch"](10);
               //keep it as external media
               if (_this.props.dispatchAnalyticsEvent) {
@@ -264,11 +271,11 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
                   eventType: EVENT_TYPE.OPERATIONAL
                 });
               }
-            case 21:
+            case 24:
             case "end":
               return _context7.stop();
           }
-        }, _callee7, null, [[10, 18]]);
+        }, _callee7, null, [[10, 21]]);
       }));
       return function (_x3) {
         return _ref8.apply(this, arguments);
@@ -360,7 +367,7 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
     })));
     _defineProperty(this, "copyNodeFromBlobUrl", /*#__PURE__*/function () {
       var _ref11 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee10(getPos) {
-        var attrs, url, mediaAttrs, mediaProvider, currentCollectionName, contextId, id, collection, height, width, mimeType, name, size, uploadMediaClientConfig, mediaClient, auth, source, destination, mediaFile;
+        var attrs, url, mediaAttrs, mediaProvider, currentCollectionName, contextId, id, collection, height, width, mimeType, name, size, uploadMediaClientConfig, mediaClient, auth, source, destination, mediaFile, pos;
         return _regeneratorRuntime.wrap(function _callee10$(_context10) {
           while (1) switch (_context10.prev = _context10.next) {
             case 0:
@@ -419,7 +426,14 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
               return mediaClient.file.copyFile(source, destination);
             case 25:
               mediaFile = _context10.sent;
-              replaceExternalMedia(getPos() + 1, {
+              pos = getPos();
+              if (!(typeof pos !== 'number')) {
+                _context10.next = 29;
+                break;
+              }
+              return _context10.abrupt("return");
+            case 29:
+              replaceExternalMedia(pos + 1, {
                 id: mediaFile.id,
                 collection: currentCollectionName,
                 height: height,
@@ -428,7 +442,7 @@ export var MediaNodeUpdater = /*#__PURE__*/function () {
                 __fileMimeType: mimeType,
                 __fileSize: size
               })(_this.props.view.state, _this.props.view.dispatch);
-            case 27:
+            case 30:
             case "end":
               return _context10.stop();
           }

package/dist/esm/plugins/media/nodeviews/mediaNodeView/media.js

@@ -55,10 +55,14 @@ export var MediaNode = /*#__PURE__*/function (_Component) {
       _this.selectMediaSingle(event);
     });
     _defineProperty(_assertThisInitialized(_this), "selectMediaSingle", function (event) {
+      var propPos = _this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      var propPos = _this.props.getPos();
       var state = _this.props.view.state;
       if (event.shiftKey) {
         // don't select text if there is current selection in a table (as this would override selected cells)

package/dist/esm/plugins/media/nodeviews/mediaSingle.js

@@ -169,10 +169,14 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
     }());
     _defineProperty(_assertThisInitialized(_this), "selectMediaSingle", function (_ref3) {
       var event = _ref3.event;
+      var propPos = _this.props.getPos();
+      if (typeof propPos !== 'number') {
+        return;
+      }
+
       // We need to call "stopPropagation" here in order to prevent the browser from navigating to
       // another URL if the media node is wrapped in a link mark.
       event.stopPropagation();
-      var propPos = _this.props.getPos();
       var state = _this.props.view.state;
       if (event.shiftKey) {
         // don't select text if there is current selection in a table (as this would override selected cells)
@@ -244,6 +248,9 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
       insertAndSelectCaptionFromMediaSinglePos(getPos(), node)(view.state, view.dispatch);
     });
     _defineProperty(_assertThisInitialized(_this), "getLineLength", function (view, pos) {
+      if (typeof pos !== 'number') {
+        return null;
+      }
       if (isRichMediaInsideOfBlockNode(view, pos)) {
         var $pos = view.state.doc.resolve(pos);
         var domNode = view.nodeDOM($pos.pos);

package/dist/esm/plugins/media/pm-plugins/main.js

@@ -293,7 +293,11 @@ export var MediaPluginStateImplementation = /*#__PURE__*/function () {
     _defineProperty(this, "handleMediaNodeRemoval", function (node, getPos) {
       var getNode = node;
       if (!getNode) {
-        getNode = _this.view.state.doc.nodeAt(getPos());
+        var pos = getPos();
+        if (typeof pos !== 'number') {
+          return;
+        }
+        getNode = _this.view.state.doc.nodeAt(pos);
       }
       removeMediaNode(_this.view, getNode, getPos);
     });

package/dist/esm/plugins/media/utils/media-common.js

@@ -111,6 +111,9 @@ export var removeMediaNode = function removeMediaNode(view, node, getPos) {
     selection = state.selection,
     doc = state.doc;
   var currentMediaNodePos = getPos();
+  if (typeof currentMediaNodePos !== 'number') {
+    return;
+  }
   tr.deleteRange(currentMediaNodePos, currentMediaNodePos + node.nodeSize);
   if (isTemporary(id)) {
     tr.setMeta('addToHistory', false);

package/dist/esm/plugins/placeholder-text/placeholder-text-nodeview.js

@@ -40,6 +40,9 @@ export var PlaceholderTextNodeView = /*#__PURE__*/function () {
         e.preventDefault();
         var _view = this.view;
         var startNodePosition = this.getPos();
+        if (typeof startNodePosition !== 'number') {
+          return false;
+        }
         var tr = _view.state.tr;
         tr.setSelection(Selection.near(tr.doc.resolve(startNodePosition)));
         _view.dispatch(tr);
@@ -56,7 +59,10 @@ export var PlaceholderTextNodeView = /*#__PURE__*/function () {
       var view = this.view,
         node = this.node;
       var placeholderStartPosition = this.getPos();
-      var placeholderEndPosition = this.getPos() + node.nodeSize;
+      if (typeof placeholderStartPosition !== 'number') {
+        return false;
+      }
+      var placeholderEndPosition = placeholderStartPosition + node.nodeSize;
       var selection = view.state.selection;
 
       // when the selection is set right after the placeholder.

package/dist/esm/plugins/tasks-and-decisions/nodeviews/taskItem.js

@@ -31,6 +31,9 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
     _defineProperty(_assertThisInitialized(_this), "handleOnChange", function (taskId, isChecked) {
       var tr = _this.view.state.tr;
       var nodePos = _this.getPos();
+      if (typeof nodePos !== 'number') {
+        return false;
+      }
 
       // SetAttrsStep should be used to prevent task updates from being dropped when mapping task ticks
       // from a previous version of the document, such as a published page.
@@ -52,7 +55,11 @@ var Task = /*#__PURE__*/function (_ReactNodeView) {
      */
     _defineProperty(_assertThisInitialized(_this), "addListAnalyticsData", function (event) {
       try {
-        var resolvedPos = _this.view.state.doc.resolve(_this.getPos());
+        var nodePos = _this.getPos();
+        if (typeof nodePos !== 'number') {
+          return false;
+        }
+        var resolvedPos = _this.view.state.doc.resolve(nodePos);
         var position = resolvedPos.index();
         var listSize = resolvedPos.parent.childCount;
         var listLocalId = resolvedPos.parent.attrs.localId;

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "185.2.27";
+export var version = "185.3.1";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.2.27",
+	"version": "185.3.1",
 	"sideEffects": false
 }

package/dist/types/nodeviews/types.d.ts

@@ -2,9 +2,9 @@ import { Node as PMNode } from 'prosemirror-model';
 export interface ReactNodeProps {
     selected: boolean;
 }
-export type ProsemirrorGetPosHandler = () => number;
+export type ProsemirrorGetPosHandler = () => number | undefined;
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export type ReactComponentProps = {
     [key: string]: unknown;
 };

package/dist/types/plugins/expand/nodeviews/index.d.ts

@@ -13,7 +13,6 @@ export declare class ExpandNodeView implements NodeView {
     titleContainer?: HTMLElement | null;
     content?: HTMLElement | null;
     getPos: getPosHandlerNode;
-    pos: number;
     intl: IntlShape;
     allowInteractiveExpand: boolean;
     isMobile: boolean;

package/dist/types/plugins/media/commands/captions.d.ts

@@ -1,4 +1,4 @@
 import { Node as PMNode } from 'prosemirror-model';
 import { Command } from '../../../types';
 export declare const selectCaptionFromMediaSinglePos: (mediaSingleNodePos: number, mediaSingleNode: PMNode) => Command;
-export declare const insertAndSelectCaptionFromMediaSinglePos: (mediaSingleNodePos: number, mediaSingleNode: PMNode) => Command;
+export declare const insertAndSelectCaptionFromMediaSinglePos: (mediaSingleNodePos: number | undefined, mediaSingleNode: PMNode) => Command;

package/dist/types/plugins/media/nodeviews/mediaGroup.d.ts

@@ -15,7 +15,7 @@ export type MediaGroupProps = {
     forwardRef?: (ref: HTMLElement) => void;
     node: PMNode;
     view: EditorView;
-    getPos: () => number;
+    getPos: () => number | undefined;
     disabled?: boolean;
     allowLazyLoading?: boolean;
     mediaProvider: Promise<MediaProvider>;

package/dist/types-ts4.5/nodeviews/types.d.ts

@@ -2,9 +2,9 @@ import { Node as PMNode } from 'prosemirror-model';
 export interface ReactNodeProps {
     selected: boolean;
 }
-export type ProsemirrorGetPosHandler = () => number;
+export type ProsemirrorGetPosHandler = () => number | undefined;
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export type ReactComponentProps = {
     [key: string]: unknown;
 };

package/dist/types-ts4.5/plugins/expand/nodeviews/index.d.ts

@@ -13,7 +13,6 @@ export declare class ExpandNodeView implements NodeView {
     titleContainer?: HTMLElement | null;
     content?: HTMLElement | null;
     getPos: getPosHandlerNode;
-    pos: number;
     intl: IntlShape;
     allowInteractiveExpand: boolean;
     isMobile: boolean;

package/dist/types-ts4.5/plugins/media/commands/captions.d.ts

@@ -1,4 +1,4 @@
 import { Node as PMNode } from 'prosemirror-model';
 import { Command } from '../../../types';
 export declare const selectCaptionFromMediaSinglePos: (mediaSingleNodePos: number, mediaSingleNode: PMNode) => Command;
-export declare const insertAndSelectCaptionFromMediaSinglePos: (mediaSingleNodePos: number, mediaSingleNode: PMNode) => Command;
+export declare const insertAndSelectCaptionFromMediaSinglePos: (mediaSingleNodePos: number | undefined, mediaSingleNode: PMNode) => Command;

package/dist/types-ts4.5/plugins/media/nodeviews/mediaGroup.d.ts

@@ -15,7 +15,7 @@ export type MediaGroupProps = {
     forwardRef?: (ref: HTMLElement) => void;
     node: PMNode;
     view: EditorView;
-    getPos: () => number;
+    getPos: () => number | undefined;
     disabled?: boolean;
     allowLazyLoading?: boolean;
     mediaProvider: Promise<MediaProvider>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "185.2.27",
+  "version": "185.3.1",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -49,12 +49,12 @@
     "@atlaskit/code": "^14.6.0",
     "@atlaskit/date": "^0.10.0",
     "@atlaskit/datetime-picker": "^12.7.0",
-    "@atlaskit/editor-common": "^74.8.0",
+    "@atlaskit/editor-common": "^74.9.0",
     "@atlaskit/editor-json-transformer": "^8.9.0",
     "@atlaskit/editor-markdown-transformer": "^5.2.0",
-    "@atlaskit/editor-palette": "1.5.0",
-    "@atlaskit/editor-plugin-analytics": "^0.0.2",
-    "@atlaskit/editor-plugin-content-insertion": "^0.0.2",
+    "@atlaskit/editor-palette": "1.5.1",
+    "@atlaskit/editor-plugin-analytics": "^0.0.3",
+    "@atlaskit/editor-plugin-content-insertion": "^0.0.3",
     "@atlaskit/editor-plugin-context-panel": "^0.1.0",
     "@atlaskit/editor-plugin-decorations": "^0.1.0",
     "@atlaskit/editor-plugin-feature-flags": "^0.1.0",
@@ -65,7 +65,7 @@
     "@atlaskit/editor-shared-styles": "^2.4.0",
     "@atlaskit/editor-tables": "^2.3.0",
     "@atlaskit/emoji": "^67.4.0",
-    "@atlaskit/empty-state": "^7.5.0",
+    "@atlaskit/empty-state": "^7.6.0",
     "@atlaskit/form": "^8.11.0",
     "@atlaskit/icon": "^21.12.0",
     "@atlaskit/icon-object": "^6.3.0",
@@ -77,8 +77,8 @@
     "@atlaskit/media-client": "^23.1.0",
     "@atlaskit/media-common": "^7.0.0",
     "@atlaskit/media-filmstrip": "^47.0.0",
-    "@atlaskit/media-picker": "^66.0.0",
-    "@atlaskit/media-ui": "^23.0.0",
+    "@atlaskit/media-picker": "^66.1.0",
+    "@atlaskit/media-ui": "^23.1.0",
     "@atlaskit/media-viewer": "^48.0.0",
     "@atlaskit/mention": "^22.1.0",
     "@atlaskit/menu": "^1.7.0",
@@ -99,7 +99,7 @@
     "@atlaskit/textfield": "^5.5.0",
     "@atlaskit/theme": "^12.5.0",
     "@atlaskit/toggle": "^12.6.0",
-    "@atlaskit/tokens": "^1.8.0",
+    "@atlaskit/tokens": "^1.9.0",
     "@atlaskit/tooltip": "^17.8.0",
     "@atlaskit/width-detector": "^4.1.0",
     "@babel/runtime": "^7.0.0",
@@ -248,6 +248,10 @@
     },
     "platform.linking-platform.editor.fix-link-insert-analytics": {
       "type": "boolean"
+    },
+    "platform.design-system-team.menu-selected-state-change_0see9": {
+      "type": "boolean",
+      "referenceOnly": "true"
     }
   }
 }

package/report.api.md

@@ -1202,7 +1202,7 @@ export function getNodesCount(node: Node_2): Record<string, number>;
 type getPosHandler = boolean | getPosHandlerNode;
 
 // @public (undocumented)
-type getPosHandlerNode = () => number;
+type getPosHandlerNode = () => number | undefined;
 
 // @public
 export function hasVisibleContent(node: Node_2): boolean;
@@ -2003,7 +2003,7 @@ type Props_5 = {
 };
 
 // @public (undocumented)
-type ProsemirrorGetPosHandler = () => number;
+type ProsemirrorGetPosHandler = () => number | undefined;
 
 export { QuickInsertActionInsert };
 

package/tmp/api-report-tmp.d.ts

@@ -1101,7 +1101,7 @@ export function getNodesCount(node: Node_2): Record<string, number>;
 type getPosHandler = boolean | getPosHandlerNode;
 
 // @public (undocumented)
-type getPosHandlerNode = () => number;
+type getPosHandlerNode = () => number | undefined;
 
 // @public
 export function hasVisibleContent(node: Node_2): boolean;
@@ -1784,7 +1784,7 @@ type Props_5 = {
 };
 
 // @public (undocumented)
-type ProsemirrorGetPosHandler = () => number;
+type ProsemirrorGetPosHandler = () => number | undefined;
 
 export { QuickInsertActionInsert }