@atlaskit/editor-core 185.2.20 → 185.2.23

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-core
 
+## 185.2.23
+
+### Patch Changes
+
+- [`91ea76040d5`](https://bitbucket.org/atlassian/atlassian-frontend/commits/91ea76040d5) - Fix editor not providing creation method for link created events triggered by link picker insertions on text selections
+
 ## 185.2.20
 
 ### Patch Changes

package/dist/cjs/plugins/card/ui/EditorSmartCardEventsNext.js

@@ -129,13 +129,16 @@ var EventsBinding = function EventsBinding(_ref4) {
           display = _ref5.display,
           nodeContext = _ref5.nodeContext,
           metadata = (0, _objectWithoutProperties2.default)(_ref5, _excluded);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var creationMethod = getMethod(metadata);
         linkCreated({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           nodeContext: nodeContext,
-          creationMethod: getMethod(metadata)
+          creationMethod: creationMethod
         });
       },
       updated: function updated(_ref6) {
@@ -144,15 +147,19 @@ var EventsBinding = function EventsBinding(_ref4) {
           previousDisplay = _ref6.previousDisplay,
           nodeContext = _ref6.nodeContext,
           metadata = (0, _objectWithoutProperties2.default)(_ref6, _excluded2);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var updateMethod = getMethod(metadata);
+        var updateType = getUpdateType(metadata);
         linkUpdated({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           previousDisplay: previousDisplay,
           nodeContext: nodeContext,
-          updateMethod: getMethod(metadata),
-          updateType: getUpdateType(metadata)
+          updateMethod: updateMethod,
+          updateType: updateType
         });
       },
       deleted: function deleted(_ref7) {
@@ -160,14 +167,18 @@ var EventsBinding = function EventsBinding(_ref4) {
           display = _ref7.display,
           nodeContext = _ref7.nodeContext,
           metadata = (0, _objectWithoutProperties2.default)(_ref7, _excluded3);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var deleteMethod = getMethod(metadata);
+        var deleteType = getDeleteType(metadata);
         linkDeleted({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           nodeContext: nodeContext,
-          deleteMethod: getMethod(metadata),
-          deleteType: getDeleteType(metadata)
+          deleteMethod: deleteMethod,
+          deleteType: deleteType
         });
       }
     };

package/dist/cjs/plugins/hyperlink/commands.js

@@ -16,6 +16,7 @@ exports.showLinkToolbar = showLinkToolbar;
 exports.updateLink = updateLink;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _card = require("@atlaskit/editor-common/card");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("@atlaskit/editor-common/utils");
 var _main = require("./pm-plugins/main");
 var _prosemirrorState = require("prosemirror-state");
@@ -126,6 +127,15 @@ function insertLink(from, to, incomingHref, incomingTitle, displayText, source,
       tr.setSelection(_prosemirrorState.Selection.near(tr.doc.resolve(markEnd)));
       if (!displayText || displayText === incomingHref) {
         (0, _doc.queueCardsFromChangedTr)(state, tr, source, _analytics2.ACTION.INSERTED, false, sourceEvent);
+      } else if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.editor.fix-link-insert-analytics')) {
+        /**
+         * Add link metadata because queue cards would have otherwise handled this for us
+         */
+        (0, _card.addLinkMetadata)(state.selection, tr, {
+          action: _analytics2.ACTION.INSERTED,
+          inputMethod: source,
+          sourceEvent: sourceEvent
+        });
       }
       tr.setMeta(_main.stateKey, {
         type: _main.LinkAction.HIDE_TOOLBAR

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "185.2.20";
+var version = "185.2.23";
 exports.version = version;
 var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.2.20",
+	"version": "185.2.23",
 	"sideEffects": false
 }

package/dist/es2019/plugins/card/ui/EditorSmartCardEventsNext.js

@@ -117,13 +117,16 @@ export const EventsBinding = ({
         nodeContext,
         ...metadata
       }) => {
+        const displayCategory = displayCategoryFromDisplay(display);
+        const sourceEvent = getSourceEventFromMetadata(metadata);
+        const creationMethod = getMethod(metadata);
         linkCreated({
           url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory
+        }, sourceEvent, {
           display,
           nodeContext,
-          creationMethod: getMethod(metadata)
+          creationMethod
         });
       },
       updated: ({
@@ -133,15 +136,19 @@ export const EventsBinding = ({
         nodeContext,
         ...metadata
       }) => {
+        const displayCategory = displayCategoryFromDisplay(display);
+        const sourceEvent = getSourceEventFromMetadata(metadata);
+        const updateMethod = getMethod(metadata);
+        const updateType = getUpdateType(metadata);
         linkUpdated({
           url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory
+        }, sourceEvent, {
           display,
           previousDisplay,
           nodeContext,
-          updateMethod: getMethod(metadata),
-          updateType: getUpdateType(metadata)
+          updateMethod,
+          updateType
         });
       },
       deleted: ({
@@ -150,14 +157,18 @@ export const EventsBinding = ({
         nodeContext,
         ...metadata
       }) => {
+        const displayCategory = displayCategoryFromDisplay(display);
+        const sourceEvent = getSourceEventFromMetadata(metadata);
+        const deleteMethod = getMethod(metadata);
+        const deleteType = getDeleteType(metadata);
         linkDeleted({
           url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory
+        }, sourceEvent, {
           display,
           nodeContext,
-          deleteMethod: getMethod(metadata),
-          deleteType: getDeleteType(metadata)
+          deleteMethod,
+          deleteType
         });
       }
     };

package/dist/es2019/plugins/hyperlink/commands.js

@@ -1,4 +1,5 @@
-import { commandWithMetadata } from '@atlaskit/editor-common/card';
+import { addLinkMetadata, commandWithMetadata } from '@atlaskit/editor-common/card';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { normalizeUrl, getLinkCreationAnalyticsEvent } from '@atlaskit/editor-common/utils';
 import { stateKey, LinkAction } from './pm-plugins/main';
 import { Selection } from 'prosemirror-state';
@@ -111,6 +112,15 @@ export function insertLink(from, to, incomingHref, incomingTitle, displayText, s
       tr.setSelection(Selection.near(tr.doc.resolve(markEnd)));
       if (!displayText || displayText === incomingHref) {
         queueCardsFromChangedTr(state, tr, source, ACTION.INSERTED, false, sourceEvent);
+      } else if (getBooleanFF('platform.linking-platform.editor.fix-link-insert-analytics')) {
+        /**
+         * Add link metadata because queue cards would have otherwise handled this for us
+         */
+        addLinkMetadata(state.selection, tr, {
+          action: ACTION.INSERTED,
+          inputMethod: source,
+          sourceEvent
+        });
       }
       tr.setMeta(stateKey, {
         type: LinkAction.HIDE_TOOLBAR

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "185.2.20";
+export const version = "185.2.23";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.2.20",
+	"version": "185.2.23",
 	"sideEffects": false
 }

package/dist/esm/plugins/card/ui/EditorSmartCardEventsNext.js

@@ -120,13 +120,16 @@ export var EventsBinding = function EventsBinding(_ref4) {
           display = _ref5.display,
           nodeContext = _ref5.nodeContext,
           metadata = _objectWithoutProperties(_ref5, _excluded);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var creationMethod = getMethod(metadata);
         linkCreated({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           nodeContext: nodeContext,
-          creationMethod: getMethod(metadata)
+          creationMethod: creationMethod
         });
       },
       updated: function updated(_ref6) {
@@ -135,15 +138,19 @@ export var EventsBinding = function EventsBinding(_ref4) {
           previousDisplay = _ref6.previousDisplay,
           nodeContext = _ref6.nodeContext,
           metadata = _objectWithoutProperties(_ref6, _excluded2);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var updateMethod = getMethod(metadata);
+        var updateType = getUpdateType(metadata);
         linkUpdated({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           previousDisplay: previousDisplay,
           nodeContext: nodeContext,
-          updateMethod: getMethod(metadata),
-          updateType: getUpdateType(metadata)
+          updateMethod: updateMethod,
+          updateType: updateType
         });
       },
       deleted: function deleted(_ref7) {
@@ -151,14 +158,18 @@ export var EventsBinding = function EventsBinding(_ref4) {
           display = _ref7.display,
           nodeContext = _ref7.nodeContext,
           metadata = _objectWithoutProperties(_ref7, _excluded3);
+        var displayCategory = displayCategoryFromDisplay(display);
+        var sourceEvent = getSourceEventFromMetadata(metadata);
+        var deleteMethod = getMethod(metadata);
+        var deleteType = getDeleteType(metadata);
         linkDeleted({
           url: url,
-          displayCategory: displayCategoryFromDisplay(display)
-        }, getSourceEventFromMetadata(metadata), {
+          displayCategory: displayCategory
+        }, sourceEvent, {
           display: display,
           nodeContext: nodeContext,
-          deleteMethod: getMethod(metadata),
-          deleteType: getDeleteType(metadata)
+          deleteMethod: deleteMethod,
+          deleteType: deleteType
         });
       }
     };

package/dist/esm/plugins/hyperlink/commands.js

@@ -1,7 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-import { commandWithMetadata } from '@atlaskit/editor-common/card';
+import { addLinkMetadata, commandWithMetadata } from '@atlaskit/editor-common/card';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { normalizeUrl, getLinkCreationAnalyticsEvent } from '@atlaskit/editor-common/utils';
 import { stateKey, LinkAction } from './pm-plugins/main';
 import { Selection } from 'prosemirror-state';
@@ -110,6 +111,15 @@ export function insertLink(from, to, incomingHref, incomingTitle, displayText, s
       tr.setSelection(Selection.near(tr.doc.resolve(markEnd)));
       if (!displayText || displayText === incomingHref) {
         queueCardsFromChangedTr(state, tr, source, ACTION.INSERTED, false, sourceEvent);
+      } else if (getBooleanFF('platform.linking-platform.editor.fix-link-insert-analytics')) {
+        /**
+         * Add link metadata because queue cards would have otherwise handled this for us
+         */
+        addLinkMetadata(state.selection, tr, {
+          action: ACTION.INSERTED,
+          inputMethod: source,
+          sourceEvent: sourceEvent
+        });
       }
       tr.setMeta(stateKey, {
         type: LinkAction.HIDE_TOOLBAR

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "185.2.20";
+export var version = "185.2.23";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "185.2.20",
+	"version": "185.2.23",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "185.2.20",
+  "version": "185.2.23",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -98,7 +98,7 @@
     "@atlaskit/textfield": "^5.5.0",
     "@atlaskit/theme": "^12.5.0",
     "@atlaskit/toggle": "^12.6.0",
-    "@atlaskit/tokens": "^1.6.0",
+    "@atlaskit/tokens": "^1.8.0",
     "@atlaskit/tooltip": "^17.8.0",
     "@atlaskit/width-detector": "^4.1.0",
     "@babel/runtime": "^7.0.0",
@@ -181,6 +181,7 @@
     "@atlaskit/visual-regression": "*",
     "@atlaskit/webdriver-runner": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
+    "@atlassian/feature-flags-test-utils": "^0.1.1",
     "@atlassian/link-picker-plugins": "^23.0.0",
     "@atlassian/search-provider": "2.4.6",
     "@atlassian/ufo": "^0.2.0",
@@ -243,6 +244,9 @@
     "platform.editor.custom-table-width": {
       "type": "boolean",
       "referenceOnly": "true"
+    },
+    "platform.linking-platform.editor.fix-link-insert-analytics": {
+      "type": "boolean"
     }
   }
 }