@atlaskit/editor-core 175.0.5 → 176.0.0

package/.eslintrc.js

@@ -1,64 +1,30 @@
 module.exports = {
+  rules: {
+    'import/no-restricted-paths': [
+      'warn',
+      {
+        zones: [
+          {
+            target: 'packages/editor/editor-core/src/**/*',
+            from: `packages/editor/editor-core/src/plugins/*/!(types)*`,
+            message:
+              '[ELR101] Avoid importing dependencies from editor plugins. Move shared code to a common location. https://developer.atlassian.com/cloud/framework/atlassian-frontend/editor/lint#elr101',
+          },
+          {
+            target: 'packages/editor/editor-core/src/**/*',
+            from: `packages/editor/editor-core/src/plugins/*/!(types)**/*`,
+            message:
+              '[ELR101] Avoid importing dependencies from editor plugins. Move shared code to a common location. https://developer.atlassian.com/cloud/framework/atlassian-frontend/editor/lint#elr101',
+          },
+        ],
+      },
+    ],
+  },
   overrides: [
     {
-      // Temporary override to apply tokens lint rules to a subset of editor packages
-      // TODO remove in https://product-fabric.atlassian.net/browse/DSP-4001
-      files: [
-        './src/keymaps/index.tsx',
-        './src/labs/next/full-page.tsx',
-        './src/plugins/alignment/**/*',
-        './src/plugins/block-type/**/*',
-        './src/plugins/breakout/**/*',
-        './src/plugins/card/**/*',
-        './src/plugins/code-block/**/*',
-        './src/plugins/collab-edit/**/*',
-        './src/plugins/date/**/*',
-        './src/plugins/emoji/**/*',
-        './src/plugins/expand/**/*',
-        './src/plugins/extension/**/*',
-        './src/plugins/fake-text-cursor/**/*',
-        './src/plugins/find-replace/**/*',
-        './src/plugins/floating-toolbar/**/*',
-        './src/plugins/grid/**/*',
-        './src/plugins/help-dialog/**/*',
-        './src/plugins/hyperlink/**/*',
-        './src/plugins/jira-issue/**/*',
-        './src/plugins/layout/**/*',
-        './src/plugins/media/**/*',
-        './src/plugins/mentions/**/*',
-        './src/plugins/panel/**/*',
-        './src/plugins/placeholder-text/**/*',
-        './src/plugins/placeholder/**/*',
-        './src/plugins/status/**/*',
-        './src/plugins/table/**/*',
-        './src/plugins/type-ahead/**/*',
-        './src/ui/Addon/**/*',
-        './src/ui/Appearance/**/*',
-        './src/ui/ChromeCollapsed/**/*',
-        './src/ui/ConfigPanel/**/*',
-        './src/ui/ContentStyles/**/*',
-        './src/ui/ContextPanel/**/*',
-        './src/ui/DropdownMenu/**/*',
-        './src/ui/ElementBrowser/**/*',
-        './src/ui/ElementBrowser/**/*',
-        './src/ui/FloatingToolbar/**/*',
-        './src/ui/LinkSearch/**/*',
-        './src/ui/PanelTextInput/**/*',
-        './src/ui/Separator/**/*',
-        './src/ui/styles.ts',
-        './src/ui/ToolbarFeedback/**/*',
-        './src/ui/WithFlash/**/*',
-      ],
+      files: ['**/__tests__/**/*.{js,ts,tsx}', 'examples/**/*.{js,ts,tsx}'],
       rules: {
-        '@atlaskit/design-system/ensure-design-token-usage': [
-          'error',
-          { shouldEnforceFallbacks: true },
-        ],
-        '@atlaskit/design-system/no-unsafe-design-token-usage': [
-          'error',
-          { shouldEnforceFallbacks: true },
-        ],
-        '@atlaskit/design-system/no-deprecated-design-token-usage': ['warn'],
+        'import/no-restricted-paths': ['off'],
       },
     },
   ],

package/CHANGELOG.md

@@ -1,5 +1,75 @@
 # @atlaskit/editor-core
 
+## 176.0.0
+
+### Major Changes
+
+- [`2df5ab17c10`](https://bitbucket.org/atlassian/atlassian-frontend/commits/2df5ab17c10) - DSP-6459: Adds a background to code blocks in the editor to remove transparency. E.g. prevents table cell background colors from affecting code blocks. Also modifies code blocks in table headers to have a border instead of a different color when design tokens are enabled.
+
+### Minor Changes
+
+- [`e657779ba39`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e657779ba39) - [ux] ED-15877 Added plain text fallback when using the copy button. When copying links, the url would be the plain text fallback. This also resolves ED-15955: copy button does not work on Android
+- [`2e7d2c81d2f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/2e7d2c81d2f) - EDM-3626 Remove plain text paste linkification feature flag
+  the feature flag will not exist anymore so this cannot be enabled/disabled
+  plain text containing URLs will always be 'linkified' using shift-cmd-v/shift-ctrl-v
+
+### Patch Changes
+
+- [`cb8f8e76d25`](https://bitbucket.org/atlassian/atlassian-frontend/commits/cb8f8e76d25) - Update types for react-select and @atlaskit/select upgrade
+  Update commerce-ui entrypoints that caused a pipeline issue.
+- [`1a798ec6296`](https://bitbucket.org/atlassian/atlassian-frontend/commits/1a798ec6296) - ED-15425 Adds table row check when using up arrow in table
+- [`352f2b5a90f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/352f2b5a90f) - ED-15984 fix sticky toolbar on JIRA
+- [`25617fe0633`](https://bitbucket.org/atlassian/atlassian-frontend/commits/25617fe0633) - [ux] ED-16010 this updates the text color picker to use design tokens when available.
+- [`9f597c3c697`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9f597c3c697) - ED-14996 allow start/end line selection when cursor is next to an inline comment
+- [`94f8a899d36`](https://bitbucket.org/atlassian/atlassian-frontend/commits/94f8a899d36) - [ED-15851] Add feature flags for the restart numbered lists project. These include:
+
+  - restartNumberedLists: Allow numbered lists to start from any number greater than 0, not just 1
+  - listNumberContinuity: Allow lists to continue their numbering when split by other nodes
+  - restartNumberedListsToolbar: Show a toolbar for users to restart the numbering of a list
+
+  We will be encapsulating all dev work under these flags.
+
+  These flags are for development purposes only, please don't turn these on. Only feature leads can turn these on.
+
+- [`c472a1eed2f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c472a1eed2f) - DSP-3443 Updates tokens used for floating buttons; updated appearances only visible in applications configured to use the new Tokens API (currently in alpha).
+- [`01472b73d72`](https://bitbucket.org/atlassian/atlassian-frontend/commits/01472b73d72) - DSP-4815 - Adds design tokens to non-custom panels. Updated appearances only visible in applications configured to use the new Tokens API (currently in alpha).
+- [`7a1a5d392ef`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7a1a5d392ef) - [ux][ed-15366] remove right align shortcut as it was interfering with default browser activity
+- [`9995644eec0`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9995644eec0) - [ux] ED-16095: Resolve a bug where the codeblock floating toolbar disappeared on selecting a language from the dropdown menu. (Add getter paths for atlaskit/select refs that safely work for both react-select v5 and v4 scenarios).
+- [`8a11811caca`](https://bitbucket.org/atlassian/atlassian-frontend/commits/8a11811caca) - ED-15298 clean up table cell optimisation
+- [`10a6576545e`](https://bitbucket.org/atlassian/atlassian-frontend/commits/10a6576545e) - [ED-16104] To fix a regression caused by [ED-15947] The arrow key behaviour is unexpected when we open find and replace button.
+- [`be6ac35db24`](https://bitbucket.org/atlassian/atlassian-frontend/commits/be6ac35db24) - [ED-15485 & ED-15486] changes to make emojis and mention nodes screen reader compatible (only the ones which are rendered in the editor - toolbar and typeahead emojis are out of scope)
+- [`0606572f9b8`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0606572f9b8) - [ux] ED-15348 docs(changeset): ED-15348 Fix a bug preventing typeahead actions to be fired from a gap cursor. Typing a typeahead trigger key (/, : or @) should pop-up a typeahead menu. However, if the current selection is inside a gap cursor, the trigger character is inserted and the pop-up menu doesn't open. This changeset fixes that.
+- [`e143a0cc82e`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e143a0cc82e) - [ED-15851] Adjust set up of feature flags for the restart numbered lists project so that they work for mobile.
+- [`b80e36ad1fb`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b80e36ad1fb) - ED-15290 adds padding bottom to chromeless editor
+- [`6a9d0618b08`](https://bitbucket.org/atlassian/atlassian-frontend/commits/6a9d0618b08) - Fix bug on safari where the caret briefly appears in the middle of a mention after autocompleting a mention.
+- [`e3f86801895`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e3f86801895) - To Focus the last typeahead list item when up arrow key is pressed [ED-15805]
+- [`d5fd6da78ab`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d5fd6da78ab) - To add arrow key navigation for the main toolbar items and menu items [ED-15497]
+
+  To make the editor main toolbar items accessible using left and right arrow keys.
+  The menus are expandable using Space or Enter key, once the menus are expanded the options are accessible using up/down arrow keys.
+  'Esc' key closes the menus and focuses the toolbar item.
+
+- [`1b489f87e1e`](https://bitbucket.org/atlassian/atlassian-frontend/commits/1b489f87e1e) - Removed unused prop 'stickToolbarToBottom' from editor-core
+- [`46561872fb9`](https://bitbucket.org/atlassian/atlassian-frontend/commits/46561872fb9) - ED-16357 To restore default keyboard navigation in emoji popup in main toolbar
+- [`9176a182f13`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9176a182f13) - [MEX-2012] Fix iOS 16 introduced regression in media single selection
+- [`7bf4281949a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7bf4281949a) - ED-15704 - Fix missing hover inducators on Delete column and Delete row under table floating toolbar context menu
+- [`e55b07b8fcd`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e55b07b8fcd) - fix whole media caption is removed if delete emoji in it
+- [`e5792780377`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e5792780377) - don't encode PM node twice when rendering table toolbar
+- [`db75d733f3c`](https://bitbucket.org/atlassian/atlassian-frontend/commits/db75d733f3c) - [ux] DSP-4354 - Adds design tokens for code snippet deletion hover state. Adds overlay for code snippet gutter to create a more saturated color for the deletion hover state. Updated appearances only visible in applications configured to use the new Tokens API (currently in alpha).
+- [`c80ef2d3bd0`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c80ef2d3bd0) - [ux] Allow tabbing past the save indicator
+- [`3a66592edd7`](https://bitbucket.org/atlassian/atlassian-frontend/commits/3a66592edd7) - [ED-16104] To fix a regression caused by [ED-15947] The arrow key behaviour is unexpected when we open find and replace button.
+- [`17014a9004c`](https://bitbucket.org/atlassian/atlassian-frontend/commits/17014a9004c) - [ux] ED-15632 preprocess invalid media adf to avoid empty mediaSingle node and duplicated captions and media inside mediaSingle.The document will be transformed for this cases and validation error not thrown.When mediaSingle with empty content is encountered - it will be removed.When mediaSingle with duplicated captions or media nodes is encountered - duplicate captions or media nodes will be removed, prioritising removal of nodes with empty content first.
+- [`8cc8e807222`](https://bitbucket.org/atlassian/atlassian-frontend/commits/8cc8e807222) - DSP-4001 - Removes custom eslint rule for design token usage to follow a standard design token tech stack.
+- [`c2510fa261f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c2510fa261f) - [ux] ED-15961 [ux] Updates the presentation of text color to use dark and light mode colors when those modes are enabled
+- [`0724b5e6562`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0724b5e6562) - Fixed typeahead behaviour after undoing insertion.
+- [`9116ae65eaf`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9116ae65eaf) - [ux] ED-15345 fix annotation should work with leading and trailing whitespace across mark
+- [`28e25520771`](https://bitbucket.org/atlassian/atlassian-frontend/commits/28e25520771) - [ED-16264] changes made to fix a regression caused in ED-15483 and ED-15497 , The arrow key navigation in 'Edit Link' 'Alt Text' popup and 'cell options' popup of table is hijacked incorrectly. post this fix the arrow key navigation behaviour should be deafult in these two popups
+- [`84254f9842e`](https://bitbucket.org/atlassian/atlassian-frontend/commits/84254f9842e) - ED-14828 Make sure typeahead does not show when it is at the beginning of the slash command
+- [`47dfcc04652`](https://bitbucket.org/atlassian/atlassian-frontend/commits/47dfcc04652) - ED-15703 - Minor change on floating toolbar to allow z-index value to be passed as parameter
+- [`58365aae521`](https://bitbucket.org/atlassian/atlassian-frontend/commits/58365aae521) - [ux] Refactor messages on tooltip of media toolbar item and media slash commend result to show video as an explicit upload option.
+- [`3354633aa75`](https://bitbucket.org/atlassian/atlassian-frontend/commits/3354633aa75) - Modified quick insert menu items such that they are read according to content design by screen readers.
+- Updated dependencies
+
 ## 175.0.5
 
 ### Patch Changes

package/dist/cjs/create-editor/ReactEditorView.js

@@ -125,7 +125,7 @@ function shouldReconfigureState(props, nextProps) {
   }
 
   var mobileProperties = props.appearance === 'mobile' ? ['featureFlags', 'quickInsert'] : [];
-  var properties = ['appearance', 'persistScrollGutter', 'allowUndoRedoButtons', 'placeholder'].concat(mobileProperties);
+  var properties = ['appearance', 'persistScrollGutter', 'allowUndoRedoButtons', 'placeholder', 'sanitizePrivateContent'].concat(mobileProperties);
   return properties.reduce(function (acc, curr) {
     return acc || props[curr] !== nextProps[curr];
   }, false);

package/dist/cjs/create-editor/create-plugins-list.js

@@ -67,7 +67,7 @@ function getScrollGutterOptions(props) {
 }
 
 function getDefaultPresetOptionsFromEditorProps(props, createAnalyticsEvent) {
-  var _props$performanceTra, _props$linking, _props$featureFlags, _props$performanceTra2, _props$textFormatting, _props$linking2;
+  var _props$performanceTra, _props$linking, _props$performanceTra2, _props$textFormatting, _props$linking2;
 
   var appearance = props.appearance;
   var isMobile = appearance === 'mobile';
@@ -82,8 +82,7 @@ function getDefaultPresetOptionsFromEditorProps(props, createAnalyticsEvent) {
     featureFlags: (0, _featureFlagsFromProps.createFeatureFlagsFromProps)(props),
     paste: {
       cardOptions: cardOptions,
-      sanitizePrivateContent: props.sanitizePrivateContent,
-      plainTextPasteLinkification: ((_props$featureFlags = props.featureFlags) === null || _props$featureFlags === void 0 ? void 0 : _props$featureFlags.plainTextPasteLinkification) === true
+      sanitizePrivateContent: props.sanitizePrivateContent
     },
     base: {
       allowInlineCursorTarget: !isMobile,
@@ -322,7 +321,6 @@ function createPluginsList(props, prevProps, createAnalyticsEvent, insertNodeAPI
     var extensionConfig = (0, _typeof2.default)(props.allowExtension) === 'object' ? props.allowExtension : {};
     preset.add([_plugins.extensionPlugin, {
       breakoutEnabled: props.appearance === 'full-page' && extensionConfig.allowBreakout !== false,
-      stickToolbarToBottom: extensionConfig.stickToolbarToBottom,
       allowAutoSave: extensionConfig.allowAutoSave,
       extensionHandlers: props.extensionHandlers,
       useLongPressSelection: false,

package/dist/cjs/keymaps/index.js

@@ -129,12 +129,6 @@ Object.defineProperty(exports, "alignLeft", {
     return _keymaps.alignLeft;
   }
 });
-Object.defineProperty(exports, "alignRight", {
-  enumerable: true,
-  get: function get() {
-    return _keymaps.alignRight;
-  }
-});
 Object.defineProperty(exports, "altPaste", {
   enumerable: true,
   get: function get() {

package/dist/cjs/labs/next/presets/cxhtml.js

@@ -29,9 +29,7 @@ function useCXHTMLPreset(_ref) {
 
   var _useDefaultPreset = (0, _default.useDefaultPreset)({
     featureFlags: featureFlags,
-    paste: {
-      plainTextPasteLinkification: featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.plainTextPasteLinkification
-    }
+    paste: {}
   }),
       _useDefaultPreset2 = (0, _slicedToArray2.default)(_useDefaultPreset, 1),
       preset = _useDefaultPreset2[0];

package/dist/cjs/labs/next/presets/mobile.js

@@ -75,9 +75,7 @@ function useMobilePreset(_ref) {
 
   var _useDefaultPreset = (0, _default.useDefaultPreset)({
     featureFlags: featureFlags,
-    paste: {
-      plainTextPasteLinkification: featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.plainTextPasteLinkification
-    }
+    paste: {}
   }),
       _useDefaultPreset2 = (0, _slicedToArray2.default)(_useDefaultPreset, 1),
       preset = _useDefaultPreset2[0];

package/dist/cjs/nodeviews/getInlineNodeViewProducer.js

@@ -10,7 +10,9 @@ exports.inlineNodeViewClassname = void 0;
 
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 
-var _react = _interopRequireDefault(require("react"));
+var _react = require("@emotion/react");
+
+var _react2 = _interopRequireDefault(require("react"));
 
 var _utils = require("@atlaskit/editor-common/utils");
 
@@ -22,6 +24,7 @@ var _ErrorBoundary = require("../ui/ErrorBoundary");
 
 var _getPerformanceOptions = require("./getPerformanceOptions");
 
+/** @jsx jsx */
 var inlineNodeViewClassname = 'inlineNodeView';
 exports.inlineNodeViewClassname = inlineNodeViewClassname;
 
@@ -176,17 +179,21 @@ function getPortalChildren(_ref2) {
     //  within inline node view Components however would require a sizable
     //  refactor. A test suite to catch any instances of this is ideal however
     //  the refactor required is currently out of scope for https://product-fabric.atlassian.net/browse/ED-14176
-    return /*#__PURE__*/_react.default.createElement(_ErrorBoundary.ErrorBoundary, {
+    return (0, _react.jsx)(_ErrorBoundary.ErrorBoundary, {
       component: _analytics.ACTION_SUBJECT.REACT_NODE_VIEW,
       componentId: (_currentNode$type$nam = currentNode === null || currentNode === void 0 ? void 0 : (_currentNode$type = currentNode.type) === null || _currentNode$type === void 0 ? void 0 : _currentNode$type.name) !== null && _currentNode$type$nam !== void 0 ? _currentNode$type$nam : _analytics.ACTION_SUBJECT_ID.UNKNOWN_NODE,
       dispatchAnalyticsEvent: dispatchAnalyticsEvent
-    }, /*#__PURE__*/_react.default.createElement("span", {
+    }, (0, _react.jsx)("span", {
+      "aria-hidden": "true",
+      className: "zeroWidthSpaceContainer"
+    }, (0, _react.jsx)("span", {
       className: "".concat(inlineNodeViewClassname, "AddZeroWidthSpace")
-    }), _utils.ZERO_WIDTH_SPACE, /*#__PURE__*/_react.default.createElement(Component, (0, _extends2.default)({
+    }), _utils.ZERO_WIDTH_SPACE), (0, _react.jsx)(Component, (0, _extends2.default)({
       view: nodeViewParams.view,
       getPos: nodeViewParams.getPos,
       node: currentNode
-    }, extraComponentProps)), /*#__PURE__*/_react.default.createElement("span", {
+    }, extraComponentProps)), (0, _react.jsx)("span", {
+      "aria-hidden": "true",
       className: "".concat(inlineNodeViewClassname, "AddZeroWidthSpace")
     }));
   };

package/dist/cjs/nodeviews/getInlineNodeViewProducer.styles.js

@@ -19,5 +19,5 @@ var _templateObject;
 
 // For reasoning behind styles, see comments in:
 // ./getInlineNodeViewProducer -> portalChildren()
-var InlineNodeViewSharedStyles = (0, _react.css)(_templateObject || (_templateObject = (0, _taggedTemplateLiteral2.default)(["\n  .", " {\n    display: inline;\n    user-select: all;\n    /* Collapses zero width spaces inside the inline node view\n    to prevent the node from line breaking too early.\n    */\n    white-space: nowrap;\n    /* Then reset to the Editor default so we don't interfere\n    with any component styling. */\n    & > * {\n      white-space: pre-wrap;\n    }\n  }\n  /** Remove browser deafult selections style. This prevents\n    unexpected visual artefacts in Safari when navigating\n    with the keyboard or making range selections. */\n  &.ua-safari {\n    .", " {\n      ::selection,\n      *::selection {\n        background: transparent;\n      }\n    }\n  }\n\n  &.ua-chrome .", " > span {\n    user-select: none;\n  }\n\n  .", "AddZeroWidthSpace {\n    ::after {\n      content: '", "';\n    }\n  }\n"])), _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _utils.ZERO_WIDTH_SPACE);
+var InlineNodeViewSharedStyles = (0, _react.css)(_templateObject || (_templateObject = (0, _taggedTemplateLiteral2.default)(["\n  .", " {\n    display: inline;\n    user-select: all;\n    /* Collapses zero width spaces inside the inline node view\n    to prevent the node from line breaking too early.\n    */\n    white-space: nowrap;\n    /* Then reset to the Editor default so we don't interfere\n    with any component styling. */\n    & > *:not(span[aria-hidden='true'].zeroWidthSpaceContainer) {\n      white-space: pre-wrap;\n    }\n  }\n  /** Remove browser deafult selections style. This prevents\n    unexpected visual artefacts in Safari when navigating\n    with the keyboard or making range selections. */\n  &.ua-safari {\n    .", " {\n      ::selection,\n      *::selection {\n        background: transparent;\n      }\n    }\n  }\n\n  &.ua-chrome .", " > span {\n    user-select: none;\n  }\n\n  .", "AddZeroWidthSpace {\n    ::after {\n      content: '", "';\n    }\n  }\n"])), _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _getInlineNodeViewProducer.inlineNodeViewClassname, _utils.ZERO_WIDTH_SPACE);
 exports.InlineNodeViewSharedStyles = InlineNodeViewSharedStyles;

package/dist/cjs/plugins/alignment/pm-plugins/keymap.js

@@ -14,6 +14,5 @@ var _commands = require("../commands");
 function keymapPlugin() {
   var list = {};
   (0, _keymaps.bindKeymapWithCommand)(_keymaps.alignLeft.common, (0, _commands.changeAlignment)('start'), list);
-  (0, _keymaps.bindKeymapWithCommand)(_keymaps.alignRight.common, (0, _commands.changeAlignment)('end'), list);
   return (0, _prosemirrorKeymap.keymap)(list);
 }

package/dist/cjs/plugins/alignment/ui/ToolbarAlignment/index.js

@@ -60,6 +60,7 @@ var AlignmentToolbar = /*#__PURE__*/function (_React$Component) {
     }
 
     _this = _super.call.apply(_super, [this].concat(args));
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "toolbarItemRef", /*#__PURE__*/_react.default.createRef());
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "state", {
       isOpen: false
     });
@@ -80,13 +81,27 @@ var AlignmentToolbar = /*#__PURE__*/function (_React$Component) {
         isOpen: isOpen
       });
     });
-    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "hide", function () {
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "hide", function (attrs) {
       if (_this.state.isOpen) {
         _this.setState({
           isOpen: false
         });
+
+        if ((attrs === null || attrs === void 0 ? void 0 : attrs.event) instanceof KeyboardEvent && attrs.event.key === 'Escape') {
+          var _this$toolbarItemRef, _this$toolbarItemRef$;
+
+          (_this$toolbarItemRef = _this.toolbarItemRef) === null || _this$toolbarItemRef === void 0 ? void 0 : (_this$toolbarItemRef$ = _this$toolbarItemRef.current) === null || _this$toolbarItemRef$ === void 0 ? void 0 : _this$toolbarItemRef$.focus();
+        }
       }
     });
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "hideonEsc", function () {
+      var _this$toolbarItemRef2, _this$toolbarItemRef3;
+
+      _this.hide(); //To set the focus on the textcolor button when the menu is closed by 'Esc' only (aria guidelines)
+
+
+      (_this$toolbarItemRef2 = _this.toolbarItemRef) === null || _this$toolbarItemRef2 === void 0 ? void 0 : (_this$toolbarItemRef3 = _this$toolbarItemRef2.current) === null || _this$toolbarItemRef3 === void 0 ? void 0 : _this$toolbarItemRef3.focus();
+    });
     return _this;
   }
 
@@ -112,10 +127,17 @@ var AlignmentToolbar = /*#__PURE__*/function (_React$Component) {
         boundariesElement: popupsBoundariesElement,
         scrollableElement: popupsScrollableElement,
         isOpen: isOpen,
-        handleClickOutside: this.hide,
-        handleEscapeKeydown: this.hide,
+        handleClickOutside: function handleClickOutside(event) {
+          return _this2.hide({
+            isOpen: false,
+            event: event
+          });
+        },
+        handleEscapeKeydown: this.hideonEsc,
+        onOpenChange: this.hide,
         fitWidth: 112,
         fitHeight: 80,
+        closeonTab: true,
         trigger: (0, _react2.jsx)(_ToolbarButton.default, {
           spacing: isReducedSpacing ? 'none' : 'default',
           disabled: disabled,
@@ -134,7 +156,8 @@ var AlignmentToolbar = /*#__PURE__*/function (_React$Component) {
             css: _styles.expandIconWrapper
           }, (0, _react2.jsx)(_chevronDown.default, {
             label: ""
-          })))
+          }))),
+          ref: this.toolbarItemRef
         })
       }, (0, _react2.jsx)(_Alignment.default, {
         onClick: function onClick(align) {

package/dist/cjs/plugins/annotation/nodeviews/index.js

@@ -23,10 +23,6 @@ var _styles = require("@atlaskit/editor-common/styles");
 
 var _nodeviews = require("../../../nodeviews");
 
-var _WithPluginState = _interopRequireDefault(require("../../../ui/WithPluginState"));
-
-var _utils = require("../utils");
-
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
@@ -58,37 +54,13 @@ var AnnotationNodeView = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "render",
     value: function render(_props, forwardRef) {
-      var _this = this;
-
-      return /*#__PURE__*/_react.default.createElement(_WithPluginState.default, {
-        plugins: {
-          inlineCommentState: _utils.inlineCommentPluginKey
-        },
-        editorView: this.view,
-        render: function render(_ref) {
-          var inlineCommentState = _ref.inlineCommentState;
-
-          if (!(inlineCommentState !== null && inlineCommentState !== void 0 && inlineCommentState.isVisible)) {
-            return /*#__PURE__*/_react.default.createElement("span", {
-              ref: forwardRef
-            });
-          } // Check if selection includes current annotation ID
-
-
-          var annotations = inlineCommentState.annotations,
-              selectedAnnotations = inlineCommentState.selectedAnnotations;
-          var id = _this.node.attrs.id;
-          var isUnresolved = annotations[id] === false;
-          var annotationHasFocus = selectedAnnotations.some(function (x) {
-            return x.id === id;
-          });
-          var className = getAnnotationViewClassname(isUnresolved, annotationHasFocus);
-          return /*#__PURE__*/_react.default.createElement("span", {
-            className: className,
-            ref: forwardRef
-          });
-        }
-      });
+      return (
+        /*#__PURE__*/
+        // all inline comment states are now set in decorations at ../pm-plugins/inline-comment.ts
+        _react.default.createElement("span", {
+          ref: forwardRef
+        })
+      );
     }
   }]);
   return AnnotationNodeView;

package/dist/cjs/plugins/annotation/pm-plugins/inline-comment.js

@@ -17,6 +17,8 @@ var _inlineCommentEvents = require("./../../analytics/types/inline-comment-event
 
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 
+var _prosemirrorView = require("prosemirror-view");
+
 var _adfSchema = require("@atlaskit/adf-schema");
 
 var _nodeviews = require("../nodeviews");
@@ -237,10 +239,34 @@ var inlineCommentPlugin = function inlineCommentPlugin(options) {
         }
       },
       decorations: function decorations(state) {
+        // highlight comments, depending on state
         var _getPluginState3 = (0, _utils.getPluginState)(state),
-            draftDecorationSet = _getPluginState3.draftDecorationSet;
+            draftDecorationSet = _getPluginState3.draftDecorationSet,
+            annotations = _getPluginState3.annotations,
+            selectedAnnotations = _getPluginState3.selectedAnnotations,
+            isVisible = _getPluginState3.isVisible;
+
+        var decorations = draftDecorationSet !== null && draftDecorationSet !== void 0 ? draftDecorationSet : _prosemirrorView.DecorationSet.empty;
+        var focusDecorations = [];
+        state.doc.descendants(function (node, pos) {
+          node.marks.filter(function (mark) {
+            return mark.type === state.schema.marks.annotation;
+          }).forEach(function (mark) {
+            var isSelected = selectedAnnotations.some(function (selectedAnnotation) {
+              return selectedAnnotation.id === mark.attrs.id;
+            });
+            var isUnresolved = annotations[mark.attrs.id] === false;
 
-        return draftDecorationSet;
+            if (isVisible) {
+              focusDecorations.push(_prosemirrorView.Decoration.inline(pos, pos + node.nodeSize, {
+                class: "".concat((0, _nodeviews.getAnnotationViewClassname)(isUnresolved, isSelected), " ").concat(isUnresolved),
+                nodeName: 'span'
+              }));
+            }
+          });
+        });
+        decorations = decorations.add(state.doc, focusDecorations);
+        return decorations;
       }
     }
   });

package/dist/cjs/plugins/annotation/utils.js

@@ -323,7 +323,7 @@ var isSelectionValid = function isSelectionValid(state) {
     return _types.AnnotationSelectionType.DISABLED;
   }
 
-  if (disallowOnWhitespace && hasInvalidWhitespaceNode(selection)) {
+  if (disallowOnWhitespace && hasInvalidWhitespaceNode(selection, state.schema)) {
     return _types.AnnotationSelectionType.INVALID;
   }
 
@@ -379,10 +379,14 @@ function isEmptyTextSelection(selection, schema) {
  */
 
 
-function hasInvalidWhitespaceNode(selection) {
+function hasInvalidWhitespaceNode(selection, schema) {
   var foundInvalidWhitespace = false;
   var content = selection.content().content;
   content.descendants(function (node) {
+    if ((0, _utils2.isText)(node, schema)) {
+      return false;
+    }
+
     if (node.textContent.trim() === '') {
       // Trailing new lines do not result in the annotation spanning into
       // the trailing new line so can be ignored when looking for invalid
@@ -390,7 +394,7 @@ function hasInvalidWhitespaceNode(selection) {
       var nodeIsTrailingNewLine = // it is the final node
       node.eq(content.lastChild) && // and there are multiple nodes
       !node.eq(content.firstChild) && // and it is a paragraph node
-      node.type.name === 'paragraph';
+      (0, _utils2.isParagraph)(node, schema);
 
       if (!nodeIsTrailingNewLine) {
         foundInvalidWhitespace = true;

package/dist/cjs/plugins/base/pm-plugins/inline-cursor-target.js

@@ -58,6 +58,7 @@ var _default = function _default() {
           var createWidget = function createWidget(side) {
             var node = document.createElement('span');
             node.contentEditable = 'true';
+            node.setAttribute('aria-hidden', 'true');
             node.appendChild(document.createTextNode(_utils.ZERO_WIDTH_SPACE));
             node.className = 'cursor-target';
             return _prosemirrorView.Decoration.widget(selection.from, node, {

package/dist/cjs/plugins/caption/nodeviews/index.js

@@ -61,7 +61,10 @@ var CaptionNodeView = /*#__PURE__*/function (_SelectionBasedNodeVi) {
   }, {
     key: "getContentDOM",
     value: function getContentDOM() {
-      var dom = document.createElement('div');
+      var dom = document.createElement('div'); // setting a className prevents PM/Chrome mutation observer from
+      // incorrectly deleting nodes
+
+      dom.className = 'caption-wrapper';
       return {
         dom: dom
       };

package/dist/cjs/plugins/card/ui/EditLinkToolbar.js

@@ -124,6 +124,7 @@ var buildEditLinkToolbar = function buildEditLinkToolbar(_ref) {
   return {
     type: 'custom',
     fallback: [],
+    disableArrowNavigation: true,
     render: function render(view, idx) {
       if (!view || !providerFactory) {
         return null;

package/dist/cjs/plugins/card/ui/LinkToolbarIconDropdown.js

@@ -86,9 +86,10 @@ var getCustomStyles = function getCustomStyles(selected, disabled) {
   return [primitiveStyles, unselectedStyles, interactiveStyles];
 };
 
+//tabindex is -1 as the menu options should be focusable explicitly only by arrow keys.
 var OptionRoot = function OptionRoot(props) {
   return (0, _react2.jsx)("div", (0, _extends2.default)({}, props, {
-    tabIndex: 0
+    tabIndex: -1
   }));
 };
 

package/dist/cjs/plugins/code-block/nodeviews/code-block.js

@@ -36,6 +36,8 @@ var toDOM = function toDOM(node) {
     class: _classNames.codeBlockClassNames.start,
     contenteditable: 'false'
   }], ['div', {
+    class: _classNames.codeBlockClassNames.contentWrapper
+  }, ['div', {
     class: _classNames.codeBlockClassNames.gutter,
     contenteditable: 'false'
   }], ['div', {
@@ -45,7 +47,7 @@ var toDOM = function toDOM(node) {
     spellcheck: 'false',
     contenteditable: 'true',
     'data-testid': 'code-block--code'
-  }, 0]], ['div', {
+  }, 0]]], ['div', {
     class: _classNames.codeBlockClassNames.end,
     contenteditable: 'false'
   }]];
@@ -97,7 +99,8 @@ var CodeBlockView = /*#__PURE__*/function () {
       if ((_this$dom = this.dom) !== null && _this$dom !== void 0 && _this$dom.childNodes && this.dom.childNodes.length > 1) {
         var _contentView$childNod;
 
-        var contentView = this.dom.childNodes[1];
+        var contentWrapper = this.dom.childNodes[1];
+        var contentView = contentWrapper === null || contentWrapper === void 0 ? void 0 : contentWrapper.childNodes[1];
 
         if ((contentView === null || contentView === void 0 ? void 0 : (_contentView$childNod = contentView.childNodes) === null || _contentView$childNod === void 0 ? void 0 : _contentView$childNod.length) > 0) {
           var codeElement = contentView.firstChild;
@@ -121,7 +124,8 @@ var CodeBlockView = /*#__PURE__*/function () {
       var _this$dom2;
 
       if ((_this$dom2 = this.dom) !== null && _this$dom2 !== void 0 && _this$dom2.childNodes && this.dom.childNodes.length > 1) {
-        var contentView = this.dom.childNodes[1];
+        var contentWrapper = this.dom.childNodes[1];
+        var contentView = contentWrapper === null || contentWrapper === void 0 ? void 0 : contentWrapper.childNodes[1];
 
         if (contentView !== null && contentView !== void 0 && contentView.childNodes && contentView.childNodes.length > 1) {
           var savedInnerHTML = '';

package/dist/cjs/plugins/code-block/refresh-browser-selection.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.default = void 0;
+exports.refreshBrowserSelection = exports.default = void 0;
 
 var _utils = require("@atlaskit/editor-common/utils");
 
@@ -24,6 +24,8 @@ var refreshBrowserSelection = function refreshBrowserSelection() {
   }
 };
 
+exports.refreshBrowserSelection = refreshBrowserSelection;
+
 var refreshBrowserSelectionOnChange = function refreshBrowserSelectionOnChange(transaction, editorState) {
   var _pluginKey$getState;