@atlaskit/editor-core 172.1.1 → 172.2.0

package/dist/es2019/plugins/extension/actions.js

@@ -1,7 +1,6 @@
-import { Slice } from 'prosemirror-model';
 import { Selection, NodeSelection, TextSelection } from 'prosemirror-state';
 import { replaceSelectedNode, findSelectedNodeOfType, replaceParentNodeOfType } from 'prosemirror-utils';
-import { mapFragment } from '../../utils/slice';
+export { transformSliceToRemoveOpenBodiedExtension } from '@atlaskit/editor-common/transforms';
 import { ACTION, ACTION_SUBJECT, INPUT_METHOD, EVENT_TYPE, addAnalytics } from '../analytics';
 import { TARGET_SELECTION_SOURCE } from '../analytics/types/extension-events';
 import { findExtensionWithLocalId } from './utils';
@@ -189,28 +188,4 @@ export const editExtension = (macroProvider, updateExtension) => (state, dispatc
   }
 
   return true;
-};
-/**
- * Lift content out of "open" top-level bodiedExtensions.
- * Will not work if bodiedExtensions are nested, or when bodiedExtensions are not in the top level
- */
-
-export const transformSliceToRemoveOpenBodiedExtension = (slice, schema) => {
-  const {
-    bodiedExtension
-  } = schema.nodes;
-  const fragment = mapFragment(slice.content, (node, parent, index) => {
-    if (node.type === bodiedExtension && !parent) {
-      const currentNodeIsAtStartAndIsOpen = slice.openStart && index === 0;
-      const currentNodeIsAtEndAndIsOpen = slice.openEnd && index + 1 === slice.content.childCount;
-
-      if (currentNodeIsAtStartAndIsOpen || currentNodeIsAtEndAndIsOpen) {
-        return node.content;
-      }
-    }
-
-    return node;
-  }); // If the first/last child has changed - then we know we've removed a bodied extension & to decrement the open depth
-
-  return new Slice(fragment, fragment.firstChild && fragment.firstChild.type !== slice.content.firstChild.type ? slice.openStart - 1 : slice.openStart, fragment.lastChild && fragment.lastChild.type !== slice.content.lastChild.type ? slice.openEnd - 1 : slice.openEnd);
 };

package/dist/es2019/plugins/extension/ui/Extension/styles.js

@@ -1,11 +1,10 @@
 import { css } from '@emotion/react';
-import { gridSize } from '@atlaskit/theme/constants';
 import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import { N20, DN50, DN700, B200, N20A, N70 } from '@atlaskit/theme/colors';
 import { token } from '@atlaskit/tokens';
-export const padding = gridSize();
-export const BODIED_EXT_PADDING = padding * 2;
+import { EXTENSION_PADDING, BODIED_EXT_PADDING } from '@atlaskit/editor-common/styles';
+export { EXTENSION_PADDING as padding, BODIED_EXT_PADDING };
 export const wrapperDefault = theme => css`
   background: ${themed({
   light: token('color.background.neutral', N20),

package/dist/es2019/plugins/insert-block/index.js

@@ -89,6 +89,7 @@ const insertBlockPlugin = (options = {}) => ({
           placeholderTextState,
           layoutState
         }) => /*#__PURE__*/React.createElement(ToolbarInsertBlock, {
+          insertNodeAPI: options.insertNodeAPI,
           buttons: buttons,
           isReducedSpacing: isToolbarReducedSpacing,
           isDisabled: disabled,

package/dist/es2019/plugins/insert-block/ui/ToolbarInsertBlock/index.js

@@ -9,7 +9,6 @@ import { EmojiPicker as AkEmojiPicker } from '@atlaskit/emoji/picker';
 import { Popup } from '@atlaskit/editor-common/ui';
 import ToolbarButton from '../../../../ui/ToolbarButton';
 import { separatorStyles, buttonGroupStyle, wrapperStyle } from '../../../../ui/styles';
-import { createTable } from '../../../table/commands';
 import { insertDate } from '../../../date/actions';
 import { openElementBrowserModal } from '../../../quick-insert/commands';
 import { showPlaceholderFloatingToolbar } from '../../../placeholder-text/actions';
@@ -19,7 +18,7 @@ import { insertExpand } from '../../../expand/commands';
 import { showLinkToolbar } from '../../../hyperlink/commands';
 import { createTypeAheadTools } from '../../../type-ahead/api';
 import { updateStatusWithAnalytics } from '../../../status/actions';
-import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD, withAnalytics as commandWithAnalytics } from '../../../analytics';
+import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '../../../analytics';
 import { insertEmoji } from '../../../emoji/commands/insert-emoji';
 import { messages } from './messages';
 import { createItems } from './create-items';
@@ -179,17 +178,28 @@ export class ToolbarInsertBlock extends React.PureComponent {
 
     _defineProperty(this, "insertTable", inputMethod => {
       const {
-        editorView
+        insertNodeAPI
       } = this.props;
-      return commandWithAnalytics({
-        action: ACTION.INSERTED,
-        actionSubject: ACTION_SUBJECT.DOCUMENT,
-        actionSubjectId: ACTION_SUBJECT_ID.TABLE,
-        attributes: {
-          inputMethod
-        },
-        eventType: EVENT_TYPE.TRACK
-      })(createTable())(editorView.state, editorView.dispatch);
+
+      if (!insertNodeAPI) {
+        return false;
+      }
+
+      return insertNodeAPI.insert({
+        node: 'table',
+        options: {
+          selectNodeInserted: false,
+          analyticsPayload: {
+            action: ACTION.INSERTED,
+            actionSubject: ACTION_SUBJECT.DOCUMENT,
+            actionSubjectId: ACTION_SUBJECT_ID.TABLE,
+            attributes: {
+              inputMethod
+            },
+            eventType: EVENT_TYPE.TRACK
+          }
+        }
+      });
     });
 
     _defineProperty(this, "createDate", inputMethod => {

package/dist/es2019/plugins/insert-block/ui/ToolbarInsertBlock/messages.js

@@ -1,168 +1 @@
-import { defineMessages } from 'react-intl-next';
-export const messages = defineMessages({
-  action: {
-    id: 'fabric.editor.action',
-    defaultMessage: 'Action item',
-    description: 'Also known as a “task”, “to do item”, or a checklist'
-  },
-  actionDescription: {
-    id: 'fabric.editor.action.description',
-    defaultMessage: 'Create and assign action items',
-    description: ''
-  },
-  link: {
-    id: 'fabric.editor.link',
-    defaultMessage: 'Link',
-    description: 'Insert a hyperlink'
-  },
-  linkDescription: {
-    id: 'fabric.editor.link.description',
-    defaultMessage: 'Insert a link',
-    description: 'Insert a hyperlink'
-  },
-  filesAndImages: {
-    id: 'fabric.editor.filesAndImages',
-    defaultMessage: 'Files & images',
-    description: 'Insert one or more files or images'
-  },
-  filesAndImagesDescription: {
-    id: 'fabric.editor.filesAndImages.description',
-    defaultMessage: 'Add images and other files to your page',
-    description: 'Insert one or more files or images'
-  },
-  image: {
-    id: 'fabric.editor.image',
-    defaultMessage: 'Image',
-    description: 'Insert an image.'
-  },
-  mention: {
-    id: 'fabric.editor.mention',
-    defaultMessage: 'Mention',
-    description: 'Reference another person in your document'
-  },
-  mentionDescription: {
-    id: 'fabric.editor.mention.description',
-    defaultMessage: 'Mention someone to send them a notification',
-    description: 'Reference another person in your document'
-  },
-  emoji: {
-    id: 'fabric.editor.emoji',
-    defaultMessage: 'Emoji',
-    description: 'Insert an emoticon or smiley :-)'
-  },
-  emojiDescription: {
-    id: 'fabric.editor.emoji.description',
-    defaultMessage: 'Use emojis to express ideas 🎉 and emotions 😄',
-    description: 'Insert an emoticon or smiley :-)'
-  },
-  table: {
-    id: 'fabric.editor.table',
-    defaultMessage: 'Table',
-    description: 'Inserts a table in the document'
-  },
-  tableDescription: {
-    id: 'fabric.editor.table.description',
-    defaultMessage: 'Insert a table',
-    description: 'Inserts a table in the document'
-  },
-  expand: {
-    id: 'fabric.editor.expand',
-    defaultMessage: 'Expand',
-    description: 'Inserts an expand in the document'
-  },
-  expandDescription: {
-    id: 'fabric.editor.expand.description',
-    defaultMessage: 'Insert an expand',
-    description: 'Inserts an expand in the document'
-  },
-  decision: {
-    id: 'fabric.editor.decision',
-    defaultMessage: 'Decision',
-    description: 'Capture a decision you’ve made'
-  },
-  decisionDescription: {
-    id: 'fabric.editor.decision.description',
-    defaultMessage: 'Capture decisions so they’re easy to track',
-    description: 'Capture a decision you’ve made'
-  },
-  feedbackDialog: {
-    id: 'fabric.editor.feedbackDialog',
-    defaultMessage: 'Give feedback',
-    description: 'Open the feedback dialog from editor'
-  },
-  feedbackDialogDescription: {
-    id: 'fabric.editor.feedbackDialog.description',
-    defaultMessage: 'Tell us about your experience using the new editor',
-    description: 'Description for feedback option under quick insert dropdown'
-  },
-  horizontalRule: {
-    id: 'fabric.editor.horizontalRule',
-    defaultMessage: 'Divider',
-    description: 'A horizontal rule or divider'
-  },
-  horizontalRuleDescription: {
-    id: 'fabric.editor.horizontalRule.description',
-    defaultMessage: 'Separate content with a horizontal line',
-    description: 'A horizontal rule or divider'
-  },
-  date: {
-    id: 'fabric.editor.date',
-    defaultMessage: 'Date',
-    description: 'Opens a date picker that lets you select a date'
-  },
-  dateDescription: {
-    id: 'fabric.editor.date.description',
-    defaultMessage: 'Add a date using a calendar',
-    description: 'Opens a date picker that lets you select a date'
-  },
-  placeholderText: {
-    id: 'fabric.editor.placeholderText',
-    defaultMessage: 'Placeholder text',
-    description: 'Inserts a text placeholder into the page'
-  },
-  placeholderTextDescription: {
-    id: 'fabric.editor.placeholderText.description',
-    defaultMessage: 'Insert a text placeholder into the page',
-    description: 'Inserts a text placeholder into the page'
-  },
-  columns: {
-    id: 'fabric.editor.columns',
-    defaultMessage: 'Layouts',
-    description: 'Create a multi column section or layout'
-  },
-  columnsDescription: {
-    id: 'fabric.editor.columns.description',
-    defaultMessage: 'Structure your page using sections',
-    description: 'Create a multi column section or layout'
-  },
-  status: {
-    id: 'fabric.editor.status',
-    defaultMessage: 'Status',
-    description: 'Inserts an item representing the status of an activity to task.'
-  },
-  statusDescription: {
-    id: 'fabric.editor.status.description',
-    defaultMessage: 'Add a custom status label',
-    description: 'Inserts an item representing the status of an activity to task.'
-  },
-  viewMore: {
-    id: 'fabric.editor.viewMore',
-    defaultMessage: 'View more',
-    description: ''
-  },
-  insertMenu: {
-    id: 'fabric.editor.insertMenu',
-    defaultMessage: 'Insert',
-    description: 'Opens a menu of additional items that can be inserted into your document.'
-  },
-  help: {
-    id: 'fabric.editor.help',
-    defaultMessage: 'Help',
-    description: 'Opens up the help dialog'
-  },
-  helpDescription: {
-    id: 'fabric.editor.help.description',
-    defaultMessage: 'Browse all the keyboard shortcuts and markdown options',
-    description: 'Browse all the keyboard shortcuts and markdown options'
-  }
-});
+export { toolbarInsertBlockMessages as messages } from '@atlaskit/editor-common/messages';

package/dist/es2019/plugins/layout/styles.js

@@ -1,13 +1,12 @@
 import { css } from '@emotion/react';
 import { gridSize } from '@atlaskit/theme/constants';
 import { N40A, N50A } from '@atlaskit/theme/colors';
-import { columnLayoutSharedStyle } from '@atlaskit/editor-common/styles';
+import { columnLayoutSharedStyle, LAYOUT_SECTION_MARGIN, LAYOUT_COLUMN_PADDING } from '@atlaskit/editor-common/styles';
 import { gridMediumMaxWidth, akEditorDeleteBackground, akEditorDeleteBorder, akEditorSelectedBorderSize, akLayoutGutterOffset, akEditorSwoopCubicBezier, SelectionStyle, getSelectionStyles, akEditorSelectedNodeClassName } from '@atlaskit/editor-shared-styles';
 import { token } from '@atlaskit/tokens';
 import { TableCssClassName } from '../table/types';
 import { tableMarginFullWidthMode } from '../table/ui/consts';
-export const LAYOUT_SECTION_MARGIN = gridSize();
-export const LAYOUT_COLUMN_PADDING = gridSize() * 1.5;
+export { LAYOUT_COLUMN_PADDING, LAYOUT_SECTION_MARGIN };
 export const layoutStyles = css`
   .ProseMirror {
     ${columnLayoutSharedStyle} [data-layout-section] {

package/dist/es2019/plugins/layout/utils.js

@@ -1,54 +1 @@
-import { Fragment, Slice } from 'prosemirror-model';
-import { flatmap, mapFragment } from '../../utils/slice';
-
-const isLayoutNode = node => node.type === node.type.schema.nodes.layoutSection || node.type === node.type.schema.nodes.layoutColumn;
-
-export function unwrapContentFromLayout(maybeLayoutSection) {
-  const fragment = mapFragment(Fragment.from(maybeLayoutSection), node => {
-    return isLayoutNode(node) ? node.content : node;
-  });
-  const nodes = [];
-  fragment.forEach(i => nodes.push(i));
-  return nodes;
-}
-export function removeLayoutFromFirstChild(node, i) {
-  return i === 0 ? unwrapContentFromLayout(node) : node;
-}
-export function removeLayoutFromLastChild(node, i, fragment) {
-  return i === fragment.childCount - 1 ? unwrapContentFromLayout(node) : node;
-}
-/**
- * When we have a slice that cuts across a layoutSection/layoutColumn
- * we can end up with unexpected behaviour on paste/drop where a user
- * is able to add columns to a layoutSection. By 'lifting' any content
- * inside an 'open' layoutSection/layoutColumn to the top level, we
- * can ensure prevent this.
- *
- * We only care about slices with non-zero openStart / openEnd's here
- * as we're totally fine for people to copy/paste a full layoutSection
- */
-
-export function transformSliceToRemoveOpenLayoutNodes(slice, schema) {
-  // Case 1: A slice entirely within a single layoutSection
-  if (slice.openStart && slice.openEnd && slice.content.childCount === 1) {
-    const maybeLayoutSection = slice.content.firstChild;
-
-    if (maybeLayoutSection.type === schema.nodes.layoutSection) {
-      return new Slice(flatmap(slice.content, removeLayoutFromFirstChild), // '-2' here because we've removed the layoutSection/layoutColumn; reducing the open depth.
-      slice.openStart - 2, slice.openEnd - 2);
-    }
-  } // Case 2: A slice starting inside a layoutSection and finishing outside
-
-
-  if (slice.openStart && slice.content.firstChild.type === schema.nodes.layoutSection) {
-    slice = new Slice(flatmap(slice.content, removeLayoutFromFirstChild), slice.openStart - 2, slice.openEnd);
-  } // Case 3: A slice starting outside a layoutSection and finishing inside
-
-
-  if (slice.openEnd && slice.content.lastChild.type === schema.nodes.layoutSection) {
-    slice = new Slice(flatmap(slice.content, removeLayoutFromLastChild), slice.openStart, slice.openEnd - 2);
-  } // Case 2 & 3 also handles a slice starting in one layoutSection & finishing in a different layoutSection
-
-
-  return slice;
-}
+export { unwrapContentFromLayout, removeLayoutFromFirstChild, removeLayoutFromLastChild, transformSliceToRemoveOpenLayoutNodes } from '@atlaskit/editor-common/transforms';

package/dist/es2019/plugins/media/nodeviews/mediaSingle.js

@@ -148,6 +148,16 @@ export default class MediaSingleNode extends Component {
         width
       });
       tr.setMeta('scrollIntoView', false);
+      /**
+       * Any changes to attributes of a node count the node as "recreated" in Prosemirror[1]
+       * This makes it so Prosemirror resets the selection to the child i.e. "media" instead of "media-single"
+       * The recommended fix is to reset the selection.[2]
+       *
+       * [1] https://discuss.prosemirror.net/t/setnodemarkup-loses-current-nodeselection/976
+       * [2] https://discuss.prosemirror.net/t/setnodemarkup-and-deselect/3673
+       */
+
+      tr.setSelection(NodeSelection.create(tr.doc, pos));
       return dispatch(tr);
     });
 

package/dist/es2019/plugins/paste/handlers.js

@@ -2,6 +2,7 @@ import { closeHistory } from 'prosemirror-history';
 import { Fragment, Node as PMNode, Slice } from 'prosemirror-model';
 import { TextSelection, NodeSelection } from 'prosemirror-state';
 import { findParentNodeOfType, hasParentNodeOfType, safeInsert } from 'prosemirror-utils';
+import { replaceSelectedTable } from '@atlaskit/editor-tables/utils';
 import { compose, insideTable, isParagraph, isText, isLinkMark, insideTableCell } from '../../utils';
 import { mapSlice } from '../../utils/slice';
 import { INPUT_METHOD } from '../analytics';
@@ -11,8 +12,7 @@ import { linkifyContent } from '../hyperlink/utils';
 import { runMacroAutoConvert } from '../macro';
 import { insertMediaAsMediaSingle } from '../media/utils/media-single';
 import { pluginKey as textFormattingPluginKey } from '../text-formatting/pm-plugins/main';
-import { replaceSelectedTable } from '../table/transforms/replace-table';
-import { applyTextMarksToSlice, hasOnlyNodesOfType } from './util';
+import { addReplaceSelectedTableAnalytics, applyTextMarksToSlice, hasOnlyNodesOfType } from './util';
 import { isListNode, isListItemNode } from '../list/utils/node';
 import { canLinkBeCreatedInRange } from '../hyperlink/pm-plugins/main';
 import { insertSliceForLists } from './edge-cases'; // remove text attribute from mention for copy/paste (GDPR)
@@ -191,7 +191,9 @@ export function handlePasteAsPlainText(slice, _event) {
       } = tr; // <- using the same internal flag that prosemirror-view is using
       // if user has selected table we need custom logic to replace the table
 
-      tr = replaceSelectedTable(state, slice, INPUT_METHOD.CLIPBOARD); // otherwise just replace the selection
+      tr = replaceSelectedTable(state, slice); // add analytics after replacing selected table
+
+      tr = addReplaceSelectedTableAnalytics(state, tr); // otherwise just replace the selection
 
       if (!tr.docChanged) {
         tr.replaceSelection(slice);
@@ -754,7 +756,9 @@ export function handlePasteIntoCaption(slice) {
   };
 }
 export const handleSelectedTable = slice => (state, dispatch) => {
-  const tr = replaceSelectedTable(state, slice, INPUT_METHOD.CLIPBOARD);
+  let tr = replaceSelectedTable(state, slice); // add analytics after replacing selected table
+
+  tr = addReplaceSelectedTableAnalytics(state, tr);
 
   if (tr.docChanged) {
     if (dispatch) {

package/dist/es2019/plugins/paste/util/index.js

@@ -1,7 +1,9 @@
 import { Slice, Mark } from 'prosemirror-model';
 import { isMediaBlobUrl } from '@atlaskit/media-client';
+import { ACTION_SUBJECT, addAnalytics, EVENT_TYPE, INPUT_METHOD, TABLE_ACTION } from '../../analytics';
 import { TextSelection, NodeSelection } from 'prosemirror-state';
 import { findParentNodeOfType } from 'prosemirror-utils';
+import { getSelectedTableInfo, isTableSelected } from '@atlaskit/editor-tables/utils';
 export function isPastedFromWord(html) {
   return !!html && html.indexOf('urn:schemas-microsoft-com:office:word') >= 0;
 }
@@ -207,4 +209,25 @@ export const removeDuplicateInvalidLinks = html => {
   }
 
   return html;
+};
+export const addReplaceSelectedTableAnalytics = (state, tr) => {
+  if (isTableSelected(state.selection)) {
+    const {
+      totalRowCount,
+      totalColumnCount
+    } = getSelectedTableInfo(state.selection);
+    addAnalytics(state, tr, {
+      action: TABLE_ACTION.REPLACED,
+      actionSubject: ACTION_SUBJECT.TABLE,
+      attributes: {
+        totalColumnCount,
+        totalRowCount,
+        inputMethod: INPUT_METHOD.CLIPBOARD
+      },
+      eventType: EVENT_TYPE.TRACK
+    });
+    return tr;
+  }
+
+  return state.tr;
 };

package/dist/es2019/plugins/selection/gap-cursor/selection.js

@@ -1,136 +1 @@
-import _defineProperty from "@babel/runtime/helpers/defineProperty";
-import { Selection } from 'prosemirror-state';
-import { Slice } from 'prosemirror-model';
-import { isValidTargetNode } from './utils/is-valid-target-node';
-export let Side;
-
-(function (Side) {
-  Side["LEFT"] = "left";
-  Side["RIGHT"] = "right";
-})(Side || (Side = {}));
-
-export const JSON_ID = 'gapcursor';
-export class GapCursorSelection extends Selection {
-  /**
-   * Construct a GapCursorSelection
-   * @param {ResolvedPos} $pos resolved position
-   * @param {Side} side side where the gap cursor is drawn
-   */
-  constructor($pos, side = Side.LEFT) {
-    super($pos, $pos);
-
-    _defineProperty(this, "visible", false);
-
-    this.side = side;
-  }
-
-  static valid($pos) {
-    const {
-      parent,
-      nodeBefore,
-      nodeAfter
-    } = $pos;
-    const targetNode = isValidTargetNode(nodeBefore) ? nodeBefore : isValidTargetNode(nodeAfter) ? nodeAfter : null;
-
-    if (!targetNode || parent.isTextblock) {
-      return false;
-    }
-
-    const deflt = parent.contentMatchAt($pos.index()).defaultType;
-    return deflt && deflt.isTextblock;
-  }
-
-  static findFrom($pos, dir, mustMove = false) {
-    const side = dir === 1 ? Side.RIGHT : Side.LEFT;
-
-    if (!mustMove && GapCursorSelection.valid($pos)) {
-      return new GapCursorSelection($pos, side);
-    }
-
-    let pos = $pos.pos; // TODO: Fix any, potential issue. ED-5048
-
-    let next = null; // Scan up from this position
-
-    for (let d = $pos.depth;; d--) {
-      const parent = $pos.node(d);
-
-      if (side === Side.RIGHT ? $pos.indexAfter(d) < parent.childCount : $pos.index(d) > 0) {
-        next = parent.maybeChild(side === Side.RIGHT ? $pos.indexAfter(d) : $pos.index(d) - 1);
-        break;
-      } else if (d === 0) {
-        return null;
-      }
-
-      pos += dir;
-      const $cur = $pos.doc.resolve(pos);
-
-      if (GapCursorSelection.valid($cur)) {
-        return new GapCursorSelection($cur, side);
-      }
-    } // And then down into the next node
-
-
-    for (;;) {
-      next = side === Side.RIGHT ? next.firstChild : next.lastChild;
-
-      if (next === null) {
-        break;
-      }
-
-      pos += dir;
-      const $cur = $pos.doc.resolve(pos);
-
-      if (GapCursorSelection.valid($cur)) {
-        return new GapCursorSelection($cur, side);
-      }
-    }
-
-    return null;
-  }
-
-  static fromJSON(doc, json) {
-    return new GapCursorSelection(doc.resolve(json.pos), json.side);
-  }
-
-  map(doc, mapping) {
-    const $pos = doc.resolve(mapping.map(this.head));
-    return GapCursorSelection.valid($pos) ? new GapCursorSelection($pos, this.side) : Selection.near($pos);
-  }
-
-  eq(other) {
-    return other instanceof GapCursorSelection && other.head === this.head;
-  }
-
-  content() {
-    return Slice.empty;
-  }
-
-  getBookmark() {
-    return new GapBookmark(this.anchor);
-  }
-
-  toJSON() {
-    return {
-      pos: this.head,
-      type: JSON_ID,
-      side: this.side
-    };
-  }
-
-}
-Selection.jsonID(JSON_ID, GapCursorSelection);
-export class GapBookmark {
-  constructor(pos) {
-    this.pos = pos;
-  }
-
-  map(mapping) {
-    return new GapBookmark(mapping.map(this.pos));
-  }
-
-  resolve(doc) {
-    const $pos = doc.resolve(this.pos);
-    return GapCursorSelection.valid($pos) ? new GapCursorSelection($pos) : Selection.near($pos);
-  }
-
-}
+export { GapCursorSelection, JSON_ID, Side, GapBookmark } from '@atlaskit/editor-common/selection';

package/dist/es2019/plugins/selection/gap-cursor/utils/is-ignored.js

@@ -1,5 +1 @@
-// we don't show gap cursor for those nodes
-const IGNORED_NODES = ['paragraph', 'bulletList', 'orderedList', 'listItem', 'taskItem', 'decisionItem', 'heading', 'blockquote', 'layoutColumn', 'caption', 'media'];
-export const isIgnored = node => {
-  return !!node && IGNORED_NODES.indexOf(node.type.name) !== -1;
-};
+export { isIgnored } from '@atlaskit/editor-common/selection';

package/dist/es2019/plugins/selection/gap-cursor/utils/is-valid-target-node.js

@@ -1,4 +1 @@
-import { isIgnored } from './is-ignored';
-export const isValidTargetNode = node => {
-  return !!node && !isIgnored(node);
-};
+export { isValidTargetNode } from '@atlaskit/editor-common/selection';

package/dist/es2019/plugins/selection/gap-cursor/utils.js

@@ -1,4 +1,4 @@
-import { TableCssClassName } from '../../table/types';
+import { TableSharedCssClassName } from '@atlaskit/editor-common/styles';
 import { Side } from './selection';
 import { UnsupportedSharedCssClassName } from '../../unsupported-content/styles';
 import { CAPTION_PLACEHOLDER_ID } from '../../media/ui/CaptionPlaceholder';
@@ -106,7 +106,7 @@ export const isIgnoredClick = elem => {
   let node = elem;
 
   while (node) {
-    if (node.className && (node.getAttribute('class') || '').indexOf(TableCssClassName.TABLE_CONTAINER) > -1) {
+    if (node.className && (node.getAttribute('class') || '').indexOf(TableSharedCssClassName.TABLE_CONTAINER) > -1) {
       tableWrap = node;
       break;
     }
@@ -115,8 +115,8 @@ export const isIgnoredClick = elem => {
   }
 
   if (tableWrap) {
-    const rowControls = tableWrap.querySelector(`.${TableCssClassName.ROW_CONTROLS_WRAPPER}`);
-    const isColumnControlsDecoration = elem && elem.classList && elem.classList.contains(TableCssClassName.COLUMN_CONTROLS_DECORATIONS);
+    const rowControls = tableWrap.querySelector(`.${TableSharedCssClassName.TABLE_ROW_CONTROLS_WRAPPER}`);
+    const isColumnControlsDecoration = elem && elem.classList && elem.classList.contains(TableSharedCssClassName.TABLE_COLUMN_CONTROLS_DECORATIONS);
     return rowControls && rowControls.contains(elem) || isColumnControlsDecoration;
   } // Check if unsupported node selection
   // (without this, selection requires double clicking in FF due to posAtCoords differences)

package/dist/es2019/plugins/selection/gap-cursor-selection.js

@@ -1,2 +1,2 @@
-export { GapCursorSelection, Side } from './gap-cursor/selection';
+export { GapCursorSelection, Side } from '@atlaskit/editor-common/selection';
 export { setCursorForTopLevelBlocks, setSelectionTopLevelBlocks, hasGapCursorPlugin } from './gap-cursor/actions';

package/dist/es2019/plugins/selection/types.js

@@ -1,14 +1,7 @@
 import { PluginKey } from 'prosemirror-state';
+import { RelativeSelectionPos } from '@atlaskit/editor-common/selection';
 export const selectionPluginKey = new PluginKey('selection');
-export let RelativeSelectionPos;
-
-(function (RelativeSelectionPos) {
-  RelativeSelectionPos["Before"] = "Before";
-  RelativeSelectionPos["Start"] = "Start";
-  RelativeSelectionPos["Inside"] = "Inside";
-  RelativeSelectionPos["End"] = "End";
-})(RelativeSelectionPos || (RelativeSelectionPos = {}));
-
+export { RelativeSelectionPos };
 export let SelectionDirection;
 
 (function (SelectionDirection) {