@atlaskit/editor-core 166.0.1 → 166.0.4

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-core
 
+## 166.0.4
+
+### Patch Changes
+
+- [`08b3ceadbe3`](https://bitbucket.org/atlassian/atlassian-frontend/commits/08b3ceadbe3) - [Hotfix] Revert of ED-14241
+
+## 166.0.3
+
+### Patch Changes
+
+- [`56238fdc70e`](https://bitbucket.org/atlassian/atlassian-frontend/commits/56238fdc70e) - ED-14998 Fix paste issue in a table inside a bodied extension. Copying and pasting inline nodes inside the table should not create a new table during paste
+
+## 166.0.2
+
+### Patch Changes
+
+- [`61b504d9af7`](https://bitbucket.org/atlassian/atlassian-frontend/commits/61b504d9af7) - [ED-15023] Fix editor crashing when first line contains only sub or super script
+
 ## 166.0.1
 
 ### Patch Changes

package/dist/cjs/plugins/annotation/pm-plugins/plugin-factory.js

@@ -63,7 +63,6 @@ var _pluginFactory = (0, _pluginStateFactory.pluginFactory)(_utils.inlineComment
     } // return same pluginState if mappings did not change
 
 
-    // return same pluginState if mappings did not change
     if (mappedBookmark === bookmark && mappedDecorationSet === draftDecorationSet) {
       return pluginState;
     }

package/dist/cjs/plugins/extension/plugin-factory.js

@@ -15,8 +15,6 @@ var _reducer = _interopRequireDefault(require("./reducer"));
 
 var _pluginKey = require("./plugin-key");
 
-var _utils = require("./utils");
-
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
@@ -39,8 +37,7 @@ var factory = (0, _pluginStateFactory.pluginFactory)(_pluginKey.pluginKey, _redu
     return _objectSpread(_objectSpread({}, state), {}, {
       positions: positions
     });
-  },
-  onSelectionChanged: _utils.onSelectionChanged
+  }
 });
 var createPluginState = factory.createPluginState;
 exports.createPluginState = createPluginState;

package/dist/cjs/plugins/extension/pm-plugins/main.js

@@ -296,7 +296,6 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
   var useLongPressSelection = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
   var options = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : {};
   var state = (0, _pluginFactory.createPluginState)(dispatch, {
-    shouldRefreshEditButton: false,
     showEditButton: false,
     showContextPanel: false
   });
@@ -320,45 +319,25 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
               element = _getPluginState.element,
               localId = _getPluginState.localId,
               extensionProvider = _getPluginState.extensionProvider,
-              showContextPanel = _getPluginState.showContextPanel,
-              shouldRefreshEditButton = _getPluginState.shouldRefreshEditButton;
+              showContextPanel = _getPluginState.showContextPanel; // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
 
-          if (!shouldRefreshEditButton) {
-            return false;
-          } // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
 
-
-          var selectedExtension = (0, _utils2.getSelectedExtension)(state, true); // If our selection isn't on an extension node, clear some state and hide the config panel
+          var selectedExtension = (0, _utils2.getSelectedExtension)(state, true);
 
           if (!selectedExtension) {
             if (showContextPanel) {
               (0, _commands.clearEditingContext)(state, dispatch);
             }
 
-            (0, _commands.updateState)({
-              shouldRefreshEditButton: false,
-              localId: undefined,
-              element: undefined,
-              showEditButton: false,
-              updateExtension: undefined
-            })(state, dispatch);
             return;
-          } // By this point we're certain we've selected an extension node.
-          // But we need to determine if the selection has changed to another
-          // extension node or remained on the same node.
-
+          }
 
           var node = selectedExtension.node;
           var newElement = (0, _utils2.getSelectedDomElement)(state.schema, domAtPos, selectedExtension); // New node is selection
 
-          var hasSelectedNodeChanged = node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
+          if (node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
           // as fallback in case we need to turn off `allowLocalIdGeneration`
-          element !== newElement;
-          var nextState = {
-            shouldRefreshEditButton: false
-          };
-
-          if (hasSelectedNodeChanged) {
+          element !== newElement) {
             if (showContextPanel) {
               (0, _commands.clearEditingContext)(state, dispatch);
             }
@@ -369,20 +348,20 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
             var showEditButton = shouldShowEditButton(extensionHandler, extensionProvider);
             var updateExtension = getUpdateExtensionPromise(view, extensionHandler, extensionProvider).catch(function () {// do nothing;
             });
-            Object.assign(nextState, {
+            (0, _commands.updateState)({
               localId: node.attrs.localId,
+              showContextPanel: false,
               element: newElement,
               showEditButton: showEditButton,
               updateExtension: updateExtension
-            });
+            })(state, dispatch);
           } // New DOM element doesn't necessarily mean it's a new Node
           else if (element !== newElement) {
-            Object.assign(nextState, {
+            (0, _commands.updateState)({
               element: newElement
-            });
+            })(state, dispatch);
           }
 
-          (0, _commands.updateState)(nextState)(state, dispatch);
           return true;
         },
         destroy: function destroy() {
@@ -399,9 +378,7 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
         inlineExtension: (0, _extension.default)(portalProviderAPI, eventDispatcher, providerFactory, extensionHandlers, extensionNodeViewOptions)
       },
       handleClickOn: (0, _utils.createSelectionClickHandler)(['extension', 'bodiedExtension'], function (target) {
-        // Clicked on anything around the extension content
-        // or specifically on the content border of a bodied extension
-        return !target.closest('.extension-content') || target.classList.contains('extension-content');
+        return !target.closest('.extension-content');
       }, {
         useLongPressSelection: useLongPressSelection
       })

package/dist/cjs/plugins/extension/utils.js

@@ -1,13 +1,9 @@
 "use strict";
 
-var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
-
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.onSelectionChanged = exports.getSelectedExtension = exports.getSelectedDomElement = exports.getNodeTypesReferenced = exports.getDataConsumerMark = exports.findNodePosWithLocalId = exports.findExtensionWithLocalId = void 0;
-
-var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+exports.getSelectedExtension = exports.getSelectedDomElement = exports.getNodeTypesReferenced = exports.getDataConsumerMark = exports.findNodePosWithLocalId = exports.findExtensionWithLocalId = void 0;
 
 var _prosemirrorUtils = require("prosemirror-utils");
 
@@ -15,31 +11,18 @@ var _dom = require("../../utils/dom");
 
 var _nodesByLocalIds = require("../../utils/nodes-by-localIds");
 
-function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
-
-function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-
-var getSelectedExtensionByTransaction = function getSelectedExtensionByTransaction(transaction) {
-  var searchParent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : true;
-  return _getSelectedExtension(transaction.doc.type.schema, transaction.selection, searchParent);
-};
-
 var getSelectedExtension = function getSelectedExtension(state) {
   var searchParent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
-  return _getSelectedExtension(state.schema, state.selection, searchParent);
+  var _state$schema$nodes = state.schema.nodes,
+      inlineExtension = _state$schema$nodes.inlineExtension,
+      extension = _state$schema$nodes.extension,
+      bodiedExtension = _state$schema$nodes.bodiedExtension;
+  var nodeTypes = [extension, bodiedExtension, inlineExtension];
+  return (0, _prosemirrorUtils.findSelectedNodeOfType)(nodeTypes)(state.selection) || searchParent && (0, _prosemirrorUtils.findParentNodeOfType)(nodeTypes)(state.selection) || undefined;
 };
 
 exports.getSelectedExtension = getSelectedExtension;
 
-var _getSelectedExtension = function _getSelectedExtension(schema, selection, searchParent) {
-  var _schema$nodes = schema.nodes,
-      inlineExtension = _schema$nodes.inlineExtension,
-      extension = _schema$nodes.extension,
-      bodiedExtension = _schema$nodes.bodiedExtension;
-  var nodeTypes = [extension, bodiedExtension, inlineExtension];
-  return (0, _prosemirrorUtils.findSelectedNodeOfType)(nodeTypes)(selection) || searchParent && (0, _prosemirrorUtils.findParentNodeOfType)(nodeTypes)(selection) || undefined;
-};
-
 var findExtensionWithLocalId = function findExtensionWithLocalId(state, localId) {
   var selectedExtension = getSelectedExtension(state, true);
 
@@ -51,10 +34,10 @@ var findExtensionWithLocalId = function findExtensionWithLocalId(state, localId)
     return selectedExtension;
   }
 
-  var _state$schema$nodes = state.schema.nodes,
-      inlineExtension = _state$schema$nodes.inlineExtension,
-      extension = _state$schema$nodes.extension,
-      bodiedExtension = _state$schema$nodes.bodiedExtension;
+  var _state$schema$nodes2 = state.schema.nodes,
+      inlineExtension = _state$schema$nodes2.inlineExtension,
+      extension = _state$schema$nodes2.extension,
+      bodiedExtension = _state$schema$nodes2.bodiedExtension;
   var nodeTypes = [extension, bodiedExtension, inlineExtension];
   var matched;
   state.doc.descendants(function (node, pos) {
@@ -108,32 +91,4 @@ var findNodePosWithLocalId = function findNodePosWithLocalId(state, localId) {
   return nodes.length >= 1 ? nodes[0] : undefined;
 };
 
-exports.findNodePosWithLocalId = findNodePosWithLocalId;
-
-var onSelectionChanged = function onSelectionChanged(tr, state) {
-  var selectedExtension = getSelectedExtensionByTransaction(tr, true);
-  var hasUnselectedExtension = !!state.element && !selectedExtension;
-  /*
-   * We use this to indicate to our plugin that the selection has changed.
-   *
-   * - ignore if shouldRefreshEditButton already set
-   * - restrict to scenarios when an extension is
-   * - a) actually selected
-   * - b) or un-selected (not accounting for selection extensionA -> extensionB)
-   *
-   * The rest of the logic will be handled in Extension main plugin view update().
-   *
-   * Known issue: typing inside of a bodiedExtension will trigger state changes each keystroke
-   * as the toolbar always being open while it is focused.
-   */
-
-  if (!state.shouldRefreshEditButton && (selectedExtension || hasUnselectedExtension)) {
-    return _objectSpread(_objectSpread({}, state), {}, {
-      shouldRefreshEditButton: true
-    });
-  }
-
-  return state;
-};
-
-exports.onSelectionChanged = onSelectionChanged;
+exports.findNodePosWithLocalId = findNodePosWithLocalId;

package/dist/cjs/plugins/feedback-dialog/index.js

@@ -94,7 +94,6 @@ var openFeedbackDialog = /*#__PURE__*/function () {
                       case 13:
                         timeoutId = window.setTimeout(showJiraCollectorDialog, 0); // Return the timoutId for consumers to call clearTimeout if they need to.
 
-                        // Return the timoutId for consumers to call clearTimeout if they need to.
                         resolve(timeoutId);
 
                       case 15:

package/dist/cjs/plugins/find-replace/utils/batch-decorations.js

@@ -263,7 +263,6 @@ var BatchDecorations = /*#__PURE__*/function () {
                   } // only get those decorations whose from >= startPos
 
 
-                  // only get those decorations whose from >= startPos
                   for (var i = 0; i < decorationsToRemove.length; i++) {
                     if (decorationsToRemove[i].from >= startPos) {
                       break;

package/dist/cjs/plugins/paste/handlers.js

@@ -700,7 +700,7 @@ function insertIntoPanel(tr, slice, panel) {
 
 function handleRichText(slice) {
   return function (state, dispatch) {
-    var _slice$content, _panelParentOverCurre;
+    var _slice$content, _slice$content2, _panelParentOverCurre;
 
     var _state$schema$nodes2 = state.schema.nodes,
         codeBlock = _state$schema$nodes2.codeBlock,
@@ -708,7 +708,8 @@ function handleRichText(slice) {
         paragraph = _state$schema$nodes2.paragraph,
         panel = _state$schema$nodes2.panel;
     var selection = state.selection;
-    var firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild; // In case user is pasting inline code,
+    var firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild;
+    var lastChildOfSlice = (_slice$content2 = slice.content) === null || _slice$content2 === void 0 ? void 0 : _slice$content2.lastChild; // In case user is pasting inline code,
     // any backtick ` immediately preceding it should be removed.
 
     var tr = state.tr;
@@ -723,7 +724,7 @@ function handleRichText(slice) {
 
     (0, _prosemirrorHistory.closeHistory)(tr);
     var isFirstChildListNode = (0, _node.isListNode)(firstChildOfSlice);
-    var isLastChildListNode = (0, _node.isListNode)(firstChildOfSlice);
+    var isLastChildListNode = (0, _node.isListNode)(lastChildOfSlice);
     var isSliceContentListNodes = isFirstChildListNode || isLastChildListNode; // We want to use safeInsert to insert invalid content, as it inserts at the closest non schema violating position
     // rather than spliting the selection parent node in half (which is what replaceSelection does)
     // Exception is paragraph and heading nodes, these should be split, provided their parent supports the pasted content
@@ -742,9 +743,23 @@ function handleRichText(slice) {
     } else if (noNeedForSafeInsert) {
       tr.replaceSelection(slice);
     } else {
-      // need safeInsert rather than replaceSelection, so that nodes aren't split in half
-      // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
-      tr = (0, _prosemirrorUtils.safeInsert)(slice.content, tr.selection.$to.pos)(tr);
+      // need to scan the slice if there's a block node inside it
+      var doesBlockNodeExist = false;
+      slice.content.nodesBetween(0, slice.content.size, function (node, start) {
+        if (start >= slice.openStart && start <= slice.content.size - slice.openEnd && node.isBlock) {
+          doesBlockNodeExist = true;
+          return false;
+        }
+      });
+
+      if ((0, _utils.insideTableCell)(state) && !doesBlockNodeExist) {
+        // bring back the old code for inline nodes
+        insertIntoPanel(tr, slice, panel);
+      } else {
+        // need safeInsert rather than replaceSelection, so that nodes aren't split in half
+        // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
+        tr = (0, _prosemirrorUtils.safeInsert)(slice.content, tr.selection.$to.pos)(tr);
+      }
     }
 
     tr.setStoredMarks([]);

package/dist/cjs/plugins/table/event-handlers.js

@@ -303,9 +303,9 @@ var handleMouseMove = function handleMouseMove(view, event, tableCellOptimizatio
   var useMouseMoveOptimisation = tableCellOptimization && mouseMoveOptimization;
 
   if (!(0, _utils4.isResizeHandleDecoration)(element) && (0, _utils4.isCell)(element)) {
-    var _positionColumn = (0, _utils4.getMousePositionHorizontalRelativeByElement)(event, useMouseMoveOptimisation, elementContentRects, _types.RESIZE_HANDLE_AREA_DECORATION_GAP);
+    var positionColumn = (0, _utils4.getMousePositionHorizontalRelativeByElement)(event, useMouseMoveOptimisation, elementContentRects, _types.RESIZE_HANDLE_AREA_DECORATION_GAP);
 
-    if (_positionColumn !== null) {
+    if (positionColumn !== null) {
       var _state4 = view.state,
           _dispatch5 = view.dispatch;
 
@@ -317,7 +317,7 @@ var handleMouseMove = function handleMouseMove(view, event, tableCellOptimizatio
       var rect = (0, _utils.findCellRectClosestToPos)(_state4.doc.resolve(cellStartPosition));
 
       if (rect) {
-        var columnEndIndexTarget = _positionColumn === 'left' ? rect.left : rect.right;
+        var columnEndIndexTarget = positionColumn === 'left' ? rect.left : rect.right;
 
         if (columnEndIndexTarget !== resizeHandleColumnIndex || !(0, _utils4.hasResizeHandler)({
           target: element,

package/dist/cjs/plugins/text-formatting/utils.js

@@ -164,7 +164,7 @@ var checkFormattingIsPresent = function checkFormattingIsPresent(state) {
 exports.checkFormattingIsPresent = checkFormattingIsPresent;
 
 var usePreviousObjectState = function usePreviousObjectState(value) {
-  var ref = (0, _react.useRef)();
+  var ref = (0, _react.useRef)([]);
   (0, _react.useEffect)(function () {
     ref.current = value;
   });

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.version = exports.nextMajorVersion = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "166.0.1";
+var version = "166.0.4";
 exports.version = version;
 
 var nextMajorVersion = function nextMajorVersion() {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "166.0.1",
+	"version": "166.0.4",
 	"sideEffects": false
 }

package/dist/es2019/plugins/extension/plugin-factory.js

@@ -1,7 +1,6 @@
 import { pluginFactory } from '../../utils/plugin-state-factory';
 import reducer from './reducer';
 import { pluginKey } from './plugin-key';
-import { onSelectionChanged } from './utils';
 const factory = pluginFactory(pluginKey, reducer, {
   mapping(tr, state) {
     const {
@@ -22,9 +21,8 @@ const factory = pluginFactory(pluginKey, reducer, {
     return { ...state,
       positions
     };
-  },
+  }
 
-  onSelectionChanged: onSelectionChanged
 });
 export const createPluginState = factory.createPluginState;
 export const createCommand = factory.createCommand;

package/dist/es2019/plugins/extension/pm-plugins/main.js

@@ -97,7 +97,6 @@ export const createContextIdentifierProviderHandler = view => async (name, provi
 
 const createPlugin = (dispatch, providerFactory, extensionHandlers, portalProviderAPI, eventDispatcher, useLongPressSelection = false, options = {}) => {
   const state = createPluginState(dispatch, {
-    shouldRefreshEditButton: false,
     showEditButton: false,
     showContextPanel: false
   });
@@ -122,48 +121,27 @@ const createPlugin = (dispatch, providerFactory, extensionHandlers, portalProvid
             element,
             localId,
             extensionProvider,
-            showContextPanel,
-            shouldRefreshEditButton
-          } = getPluginState(state);
+            showContextPanel
+          } = getPluginState(state); // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
 
-          if (!shouldRefreshEditButton) {
-            return false;
-          } // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
-
-
-          const selectedExtension = getSelectedExtension(state, true); // If our selection isn't on an extension node, clear some state and hide the config panel
+          const selectedExtension = getSelectedExtension(state, true);
 
           if (!selectedExtension) {
             if (showContextPanel) {
               clearEditingContext(state, dispatch);
             }
 
-            updateState({
-              shouldRefreshEditButton: false,
-              localId: undefined,
-              element: undefined,
-              showEditButton: false,
-              updateExtension: undefined
-            })(state, dispatch);
             return;
-          } // By this point we're certain we've selected an extension node.
-          // But we need to determine if the selection has changed to another
-          // extension node or remained on the same node.
-
+          }
 
           const {
             node
           } = selectedExtension;
           const newElement = getSelectedDomElement(state.schema, domAtPos, selectedExtension); // New node is selection
 
-          const hasSelectedNodeChanged = node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
+          if (node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
           // as fallback in case we need to turn off `allowLocalIdGeneration`
-          element !== newElement;
-          const nextState = {
-            shouldRefreshEditButton: false
-          };
-
-          if (hasSelectedNodeChanged) {
+          element !== newElement) {
             if (showContextPanel) {
               clearEditingContext(state, dispatch);
             }
@@ -176,20 +154,20 @@ const createPlugin = (dispatch, providerFactory, extensionHandlers, portalProvid
             const showEditButton = shouldShowEditButton(extensionHandler, extensionProvider);
             const updateExtension = getUpdateExtensionPromise(view, extensionHandler, extensionProvider).catch(() => {// do nothing;
             });
-            Object.assign(nextState, {
+            updateState({
               localId: node.attrs.localId,
+              showContextPanel: false,
               element: newElement,
               showEditButton,
               updateExtension
-            });
+            })(state, dispatch);
           } // New DOM element doesn't necessarily mean it's a new Node
           else if (element !== newElement) {
-            Object.assign(nextState, {
+            updateState({
               element: newElement
-            });
+            })(state, dispatch);
           }
 
-          updateState(nextState)(state, dispatch);
           return true;
         },
         destroy: () => {
@@ -205,11 +183,7 @@ const createPlugin = (dispatch, providerFactory, extensionHandlers, portalProvid
         bodiedExtension: ExtensionNodeView(portalProviderAPI, eventDispatcher, providerFactory, extensionHandlers, extensionNodeViewOptions),
         inlineExtension: ExtensionNodeView(portalProviderAPI, eventDispatcher, providerFactory, extensionHandlers, extensionNodeViewOptions)
       },
-      handleClickOn: createSelectionClickHandler(['extension', 'bodiedExtension'], target => {
-        // Clicked on anything around the extension content
-        // or specifically on the content border of a bodied extension
-        return !target.closest('.extension-content') || target.classList.contains('extension-content');
-      }, {
+      handleClickOn: createSelectionClickHandler(['extension', 'bodiedExtension'], target => !target.closest('.extension-content'), {
         useLongPressSelection
       })
     }

package/dist/es2019/plugins/extension/utils.js

@@ -1,25 +1,15 @@
 import { findParentNodeOfType, findSelectedNodeOfType, findDomRefAtPos } from 'prosemirror-utils';
 import { closestElement } from '../../utils/dom';
 import { findNodePosByLocalIds } from '../../utils/nodes-by-localIds';
-
-const getSelectedExtensionByTransaction = (transaction, searchParent = true) => {
-  return _getSelectedExtension(transaction.doc.type.schema, transaction.selection, searchParent);
-};
-
 export const getSelectedExtension = (state, searchParent = false) => {
-  return _getSelectedExtension(state.schema, state.selection, searchParent);
-};
-
-const _getSelectedExtension = (schema, selection, searchParent) => {
   const {
     inlineExtension,
     extension,
     bodiedExtension
-  } = schema.nodes;
+  } = state.schema.nodes;
   const nodeTypes = [extension, bodiedExtension, inlineExtension];
-  return findSelectedNodeOfType(nodeTypes)(selection) || searchParent && findParentNodeOfType(nodeTypes)(selection) || undefined;
+  return findSelectedNodeOfType(nodeTypes)(state.selection) || searchParent && findParentNodeOfType(nodeTypes)(state.selection) || undefined;
 };
-
 export const findExtensionWithLocalId = (state, localId) => {
   const selectedExtension = getSelectedExtension(state, true);
 
@@ -72,29 +62,4 @@ export const getNodeTypesReferenced = (ids, state) => {
 export const findNodePosWithLocalId = (state, localId) => {
   const nodes = findNodePosByLocalIds(state, [localId]);
   return nodes.length >= 1 ? nodes[0] : undefined;
-};
-export const onSelectionChanged = (tr, state) => {
-  const selectedExtension = getSelectedExtensionByTransaction(tr, true);
-  const hasUnselectedExtension = !!state.element && !selectedExtension;
-  /*
-   * We use this to indicate to our plugin that the selection has changed.
-   *
-   * - ignore if shouldRefreshEditButton already set
-   * - restrict to scenarios when an extension is
-   * - a) actually selected
-   * - b) or un-selected (not accounting for selection extensionA -> extensionB)
-   *
-   * The rest of the logic will be handled in Extension main plugin view update().
-   *
-   * Known issue: typing inside of a bodiedExtension will trigger state changes each keystroke
-   * as the toolbar always being open while it is focused.
-   */
-
-  if (!state.shouldRefreshEditButton && (selectedExtension || hasUnselectedExtension)) {
-    return { ...state,
-      shouldRefreshEditButton: true
-    };
-  }
-
-  return state;
 };

package/dist/es2019/plugins/paste/handlers.js

@@ -2,7 +2,7 @@ import { closeHistory } from 'prosemirror-history';
 import { Fragment, Node as PMNode, Slice } from 'prosemirror-model';
 import { TextSelection, NodeSelection } from 'prosemirror-state';
 import { findParentNodeOfType, hasParentNodeOfType, safeInsert } from 'prosemirror-utils';
-import { compose, insideTable, isParagraph, isText, isLinkMark, processRawValue } from '../../utils';
+import { compose, insideTable, isParagraph, isText, isLinkMark, processRawValue, insideTableCell } from '../../utils';
 import { mapSlice } from '../../utils/slice';
 import { INPUT_METHOD } from '../analytics';
 import { insertCard, queueCardsFromChangedTr } from '../card/pm-plugins/doc';
@@ -610,7 +610,7 @@ export function insertIntoPanel(tr, slice, panel) {
 }
 export function handleRichText(slice) {
   return (state, dispatch) => {
-    var _slice$content, _panelParentOverCurre;
+    var _slice$content, _slice$content2, _panelParentOverCurre;
 
     const {
       codeBlock,
@@ -621,7 +621,8 @@ export function handleRichText(slice) {
     const {
       selection
     } = state;
-    const firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild; // In case user is pasting inline code,
+    const firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild;
+    const lastChildOfSlice = (_slice$content2 = slice.content) === null || _slice$content2 === void 0 ? void 0 : _slice$content2.lastChild; // In case user is pasting inline code,
     // any backtick ` immediately preceding it should be removed.
 
     let tr = state.tr;
@@ -636,7 +637,7 @@ export function handleRichText(slice) {
 
     closeHistory(tr);
     const isFirstChildListNode = isListNode(firstChildOfSlice);
-    const isLastChildListNode = isListNode(firstChildOfSlice);
+    const isLastChildListNode = isListNode(lastChildOfSlice);
     const isSliceContentListNodes = isFirstChildListNode || isLastChildListNode; // We want to use safeInsert to insert invalid content, as it inserts at the closest non schema violating position
     // rather than spliting the selection parent node in half (which is what replaceSelection does)
     // Exception is paragraph and heading nodes, these should be split, provided their parent supports the pasted content
@@ -655,9 +656,23 @@ export function handleRichText(slice) {
     } else if (noNeedForSafeInsert) {
       tr.replaceSelection(slice);
     } else {
-      // need safeInsert rather than replaceSelection, so that nodes aren't split in half
-      // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
-      tr = safeInsert(slice.content, tr.selection.$to.pos)(tr);
+      // need to scan the slice if there's a block node inside it
+      let doesBlockNodeExist = false;
+      slice.content.nodesBetween(0, slice.content.size, (node, start) => {
+        if (start >= slice.openStart && start <= slice.content.size - slice.openEnd && node.isBlock) {
+          doesBlockNodeExist = true;
+          return false;
+        }
+      });
+
+      if (insideTableCell(state) && !doesBlockNodeExist) {
+        // bring back the old code for inline nodes
+        insertIntoPanel(tr, slice, panel);
+      } else {
+        // need safeInsert rather than replaceSelection, so that nodes aren't split in half
+        // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
+        tr = safeInsert(slice.content, tr.selection.$to.pos)(tr);
+      }
     }
 
     tr.setStoredMarks([]);

package/dist/es2019/plugins/text-formatting/utils.js

@@ -134,7 +134,7 @@ export const checkFormattingIsPresent = state => {
   return marksArePresent(state) || blockStylingIsPresent(state);
 };
 export const usePreviousObjectState = value => {
-  const ref = useRef();
+  const ref = useRef([]);
   useEffect(() => {
     ref.current = value;
   });

package/dist/es2019/version-wrapper.js

@@ -1,5 +1,5 @@
 export const name = "@atlaskit/editor-core";
-export const version = "166.0.1";
+export const version = "166.0.4";
 export const nextMajorVersion = () => {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "166.0.1",
+	"version": "166.0.4",
 	"sideEffects": false
 }

package/dist/esm/plugins/annotation/pm-plugins/plugin-factory.js

@@ -52,7 +52,6 @@ var _pluginFactory = pluginFactory(inlineCommentPluginKey, reducer, {
     } // return same pluginState if mappings did not change
 
 
-    // return same pluginState if mappings did not change
     if (mappedBookmark === bookmark && mappedDecorationSet === draftDecorationSet) {
       return pluginState;
     }

package/dist/esm/plugins/extension/plugin-factory.js

@@ -7,7 +7,6 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
 import { pluginFactory } from '../../utils/plugin-state-factory';
 import reducer from './reducer';
 import { pluginKey } from './plugin-key';
-import { onSelectionChanged } from './utils';
 var factory = pluginFactory(pluginKey, reducer, {
   mapping: function mapping(tr, state) {
     var _ref = state,
@@ -26,8 +25,7 @@ var factory = pluginFactory(pluginKey, reducer, {
     return _objectSpread(_objectSpread({}, state), {}, {
       positions: positions
     });
-  },
-  onSelectionChanged: onSelectionChanged
+  }
 });
 export var createPluginState = factory.createPluginState;
 export var createCommand = factory.createCommand;

package/dist/esm/plugins/extension/pm-plugins/main.js

@@ -251,7 +251,6 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
   var useLongPressSelection = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
   var options = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : {};
   var state = createPluginState(dispatch, {
-    shouldRefreshEditButton: false,
     showEditButton: false,
     showContextPanel: false
   });
@@ -275,45 +274,25 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
               element = _getPluginState.element,
               localId = _getPluginState.localId,
               extensionProvider = _getPluginState.extensionProvider,
-              showContextPanel = _getPluginState.showContextPanel,
-              shouldRefreshEditButton = _getPluginState.shouldRefreshEditButton;
+              showContextPanel = _getPluginState.showContextPanel; // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
 
-          if (!shouldRefreshEditButton) {
-            return false;
-          } // This fetches the selected extension node, either by keyboard selection or click for all types of extensions
 
-
-          var selectedExtension = getSelectedExtension(state, true); // If our selection isn't on an extension node, clear some state and hide the config panel
+          var selectedExtension = getSelectedExtension(state, true);
 
           if (!selectedExtension) {
             if (showContextPanel) {
               clearEditingContext(state, dispatch);
             }
 
-            updateState({
-              shouldRefreshEditButton: false,
-              localId: undefined,
-              element: undefined,
-              showEditButton: false,
-              updateExtension: undefined
-            })(state, dispatch);
             return;
-          } // By this point we're certain we've selected an extension node.
-          // But we need to determine if the selection has changed to another
-          // extension node or remained on the same node.
-
+          }
 
           var node = selectedExtension.node;
           var newElement = getSelectedDomElement(state.schema, domAtPos, selectedExtension); // New node is selection
 
-          var hasSelectedNodeChanged = node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
+          if (node.attrs.localId ? localId !== node.attrs.localId : // This is the current assumption and it's wrong but we are keeping it
           // as fallback in case we need to turn off `allowLocalIdGeneration`
-          element !== newElement;
-          var nextState = {
-            shouldRefreshEditButton: false
-          };
-
-          if (hasSelectedNodeChanged) {
+          element !== newElement) {
             if (showContextPanel) {
               clearEditingContext(state, dispatch);
             }
@@ -324,20 +303,20 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
             var showEditButton = shouldShowEditButton(extensionHandler, extensionProvider);
             var updateExtension = getUpdateExtensionPromise(view, extensionHandler, extensionProvider).catch(function () {// do nothing;
             });
-            Object.assign(nextState, {
+            updateState({
               localId: node.attrs.localId,
+              showContextPanel: false,
               element: newElement,
               showEditButton: showEditButton,
               updateExtension: updateExtension
-            });
+            })(state, dispatch);
           } // New DOM element doesn't necessarily mean it's a new Node
           else if (element !== newElement) {
-            Object.assign(nextState, {
+            updateState({
               element: newElement
-            });
+            })(state, dispatch);
           }
 
-          updateState(nextState)(state, dispatch);
           return true;
         },
         destroy: function destroy() {
@@ -354,9 +333,7 @@ var createPlugin = function createPlugin(dispatch, providerFactory, extensionHan
         inlineExtension: ExtensionNodeView(portalProviderAPI, eventDispatcher, providerFactory, extensionHandlers, extensionNodeViewOptions)
       },
       handleClickOn: createSelectionClickHandler(['extension', 'bodiedExtension'], function (target) {
-        // Clicked on anything around the extension content
-        // or specifically on the content border of a bodied extension
-        return !target.closest('.extension-content') || target.classList.contains('extension-content');
+        return !target.closest('.extension-content');
       }, {
         useLongPressSelection: useLongPressSelection
       })

package/dist/esm/plugins/extension/utils.js

@@ -1,32 +1,15 @@
-import _defineProperty from "@babel/runtime/helpers/defineProperty";
-
-function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
-
-function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-
 import { findParentNodeOfType, findSelectedNodeOfType, findDomRefAtPos } from 'prosemirror-utils';
 import { closestElement } from '../../utils/dom';
 import { findNodePosByLocalIds } from '../../utils/nodes-by-localIds';
-
-var getSelectedExtensionByTransaction = function getSelectedExtensionByTransaction(transaction) {
-  var searchParent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : true;
-  return _getSelectedExtension(transaction.doc.type.schema, transaction.selection, searchParent);
-};
-
 export var getSelectedExtension = function getSelectedExtension(state) {
   var searchParent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
-  return _getSelectedExtension(state.schema, state.selection, searchParent);
-};
-
-var _getSelectedExtension = function _getSelectedExtension(schema, selection, searchParent) {
-  var _schema$nodes = schema.nodes,
-      inlineExtension = _schema$nodes.inlineExtension,
-      extension = _schema$nodes.extension,
-      bodiedExtension = _schema$nodes.bodiedExtension;
+  var _state$schema$nodes = state.schema.nodes,
+      inlineExtension = _state$schema$nodes.inlineExtension,
+      extension = _state$schema$nodes.extension,
+      bodiedExtension = _state$schema$nodes.bodiedExtension;
   var nodeTypes = [extension, bodiedExtension, inlineExtension];
-  return findSelectedNodeOfType(nodeTypes)(selection) || searchParent && findParentNodeOfType(nodeTypes)(selection) || undefined;
+  return findSelectedNodeOfType(nodeTypes)(state.selection) || searchParent && findParentNodeOfType(nodeTypes)(state.selection) || undefined;
 };
-
 export var findExtensionWithLocalId = function findExtensionWithLocalId(state, localId) {
   var selectedExtension = getSelectedExtension(state, true);
 
@@ -38,10 +21,10 @@ export var findExtensionWithLocalId = function findExtensionWithLocalId(state, l
     return selectedExtension;
   }
 
-  var _state$schema$nodes = state.schema.nodes,
-      inlineExtension = _state$schema$nodes.inlineExtension,
-      extension = _state$schema$nodes.extension,
-      bodiedExtension = _state$schema$nodes.bodiedExtension;
+  var _state$schema$nodes2 = state.schema.nodes,
+      inlineExtension = _state$schema$nodes2.inlineExtension,
+      extension = _state$schema$nodes2.extension,
+      bodiedExtension = _state$schema$nodes2.bodiedExtension;
   var nodeTypes = [extension, bodiedExtension, inlineExtension];
   var matched;
   state.doc.descendants(function (node, pos) {
@@ -81,29 +64,4 @@ export var getNodeTypesReferenced = function getNodeTypesReferenced(ids, state)
 export var findNodePosWithLocalId = function findNodePosWithLocalId(state, localId) {
   var nodes = findNodePosByLocalIds(state, [localId]);
   return nodes.length >= 1 ? nodes[0] : undefined;
-};
-export var onSelectionChanged = function onSelectionChanged(tr, state) {
-  var selectedExtension = getSelectedExtensionByTransaction(tr, true);
-  var hasUnselectedExtension = !!state.element && !selectedExtension;
-  /*
-   * We use this to indicate to our plugin that the selection has changed.
-   *
-   * - ignore if shouldRefreshEditButton already set
-   * - restrict to scenarios when an extension is
-   * - a) actually selected
-   * - b) or un-selected (not accounting for selection extensionA -> extensionB)
-   *
-   * The rest of the logic will be handled in Extension main plugin view update().
-   *
-   * Known issue: typing inside of a bodiedExtension will trigger state changes each keystroke
-   * as the toolbar always being open while it is focused.
-   */
-
-  if (!state.shouldRefreshEditButton && (selectedExtension || hasUnselectedExtension)) {
-    return _objectSpread(_objectSpread({}, state), {}, {
-      shouldRefreshEditButton: true
-    });
-  }
-
-  return state;
 };

package/dist/esm/plugins/feedback-dialog/index.js

@@ -74,7 +74,6 @@ export var openFeedbackDialog = /*#__PURE__*/function () {
                       case 13:
                         timeoutId = window.setTimeout(showJiraCollectorDialog, 0); // Return the timoutId for consumers to call clearTimeout if they need to.
 
-                        // Return the timoutId for consumers to call clearTimeout if they need to.
                         resolve(timeoutId);
 
                       case 15:

package/dist/esm/plugins/find-replace/utils/batch-decorations.js

@@ -248,7 +248,6 @@ var BatchDecorations = /*#__PURE__*/function () {
                   } // only get those decorations whose from >= startPos
 
 
-                  // only get those decorations whose from >= startPos
                   for (var i = 0; i < decorationsToRemove.length; i++) {
                     if (decorationsToRemove[i].from >= startPos) {
                       break;

package/dist/esm/plugins/paste/handlers.js

@@ -16,7 +16,7 @@ import { closeHistory } from 'prosemirror-history';
 import { Fragment, Node as PMNode, Slice } from 'prosemirror-model';
 import { TextSelection, NodeSelection } from 'prosemirror-state';
 import { findParentNodeOfType, hasParentNodeOfType, safeInsert } from 'prosemirror-utils';
-import { compose, insideTable, isParagraph, isText, isLinkMark, processRawValue } from '../../utils';
+import { compose, insideTable, isParagraph, isText, isLinkMark, processRawValue, insideTableCell } from '../../utils';
 import { mapSlice } from '../../utils/slice';
 import { INPUT_METHOD } from '../analytics';
 import { insertCard, queueCardsFromChangedTr } from '../card/pm-plugins/doc';
@@ -644,7 +644,7 @@ export function insertIntoPanel(tr, slice, panel) {
 }
 export function handleRichText(slice) {
   return function (state, dispatch) {
-    var _slice$content, _panelParentOverCurre;
+    var _slice$content, _slice$content2, _panelParentOverCurre;
 
     var _state$schema$nodes2 = state.schema.nodes,
         codeBlock = _state$schema$nodes2.codeBlock,
@@ -652,7 +652,8 @@ export function handleRichText(slice) {
         paragraph = _state$schema$nodes2.paragraph,
         panel = _state$schema$nodes2.panel;
     var selection = state.selection;
-    var firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild; // In case user is pasting inline code,
+    var firstChildOfSlice = (_slice$content = slice.content) === null || _slice$content === void 0 ? void 0 : _slice$content.firstChild;
+    var lastChildOfSlice = (_slice$content2 = slice.content) === null || _slice$content2 === void 0 ? void 0 : _slice$content2.lastChild; // In case user is pasting inline code,
     // any backtick ` immediately preceding it should be removed.
 
     var tr = state.tr;
@@ -667,7 +668,7 @@ export function handleRichText(slice) {
 
     closeHistory(tr);
     var isFirstChildListNode = isListNode(firstChildOfSlice);
-    var isLastChildListNode = isListNode(firstChildOfSlice);
+    var isLastChildListNode = isListNode(lastChildOfSlice);
     var isSliceContentListNodes = isFirstChildListNode || isLastChildListNode; // We want to use safeInsert to insert invalid content, as it inserts at the closest non schema violating position
     // rather than spliting the selection parent node in half (which is what replaceSelection does)
     // Exception is paragraph and heading nodes, these should be split, provided their parent supports the pasted content
@@ -686,9 +687,23 @@ export function handleRichText(slice) {
     } else if (noNeedForSafeInsert) {
       tr.replaceSelection(slice);
     } else {
-      // need safeInsert rather than replaceSelection, so that nodes aren't split in half
-      // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
-      tr = safeInsert(slice.content, tr.selection.$to.pos)(tr);
+      // need to scan the slice if there's a block node inside it
+      var doesBlockNodeExist = false;
+      slice.content.nodesBetween(0, slice.content.size, function (node, start) {
+        if (start >= slice.openStart && start <= slice.content.size - slice.openEnd && node.isBlock) {
+          doesBlockNodeExist = true;
+          return false;
+        }
+      });
+
+      if (insideTableCell(state) && !doesBlockNodeExist) {
+        // bring back the old code for inline nodes
+        insertIntoPanel(tr, slice, panel);
+      } else {
+        // need safeInsert rather than replaceSelection, so that nodes aren't split in half
+        // e.g. when pasting a layout into a table, replaceSelection splits the table in half and adds the layout in the middle
+        tr = safeInsert(slice.content, tr.selection.$to.pos)(tr);
+      }
     }
 
     tr.setStoredMarks([]);

package/dist/esm/plugins/table/event-handlers.js

@@ -254,9 +254,9 @@ export var handleMouseMove = function handleMouseMove(view, event, tableCellOpti
   var useMouseMoveOptimisation = tableCellOptimization && mouseMoveOptimization;
 
   if (!isResizeHandleDecoration(element) && isCell(element)) {
-    var _positionColumn = getMousePositionHorizontalRelativeByElement(event, useMouseMoveOptimisation, elementContentRects, RESIZE_HANDLE_AREA_DECORATION_GAP);
+    var positionColumn = getMousePositionHorizontalRelativeByElement(event, useMouseMoveOptimisation, elementContentRects, RESIZE_HANDLE_AREA_DECORATION_GAP);
 
-    if (_positionColumn !== null) {
+    if (positionColumn !== null) {
       var _state4 = view.state,
           _dispatch5 = view.dispatch;
 
@@ -268,7 +268,7 @@ export var handleMouseMove = function handleMouseMove(view, event, tableCellOpti
       var rect = findCellRectClosestToPos(_state4.doc.resolve(cellStartPosition));
 
       if (rect) {
-        var columnEndIndexTarget = _positionColumn === 'left' ? rect.left : rect.right;
+        var columnEndIndexTarget = positionColumn === 'left' ? rect.left : rect.right;
 
         if (columnEndIndexTarget !== resizeHandleColumnIndex || !hasResizeHandler({
           target: element,

package/dist/esm/plugins/text-formatting/utils.js

@@ -130,7 +130,7 @@ export var checkFormattingIsPresent = function checkFormattingIsPresent(state) {
   return marksArePresent(state) || blockStylingIsPresent(state);
 };
 export var usePreviousObjectState = function usePreviousObjectState(value) {
-  var ref = useRef();
+  var ref = useRef([]);
   useEffect(function () {
     ref.current = value;
   });

package/dist/esm/version-wrapper.js

@@ -1,5 +1,5 @@
 export var name = "@atlaskit/editor-core";
-export var version = "166.0.1";
+export var version = "166.0.4";
 export var nextMajorVersion = function nextMajorVersion() {
   return [Number(version.split('.')[0]) + 1, 0, 0].join('.');
 };

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "166.0.1",
+	"version": "166.0.4",
 	"sideEffects": false
 }

package/dist/types/plugins/extension/pm-plugins/main.d.ts

@@ -6,7 +6,6 @@ import type { ContextIdentifierProvider } from '@atlaskit/editor-common/provider
 import { EditorAppearance } from '../../../types/editor-appearance';
 import { Dispatch, EventDispatcher } from '../../../event-dispatcher';
 import { PortalProviderAPI } from '../../../ui/PortalProvider';
-import type { ExtensionState } from '../types';
 import { getPluginState, createCommand } from '../plugin-factory';
 import { pluginKey } from '../plugin-key';
 export declare const updateEditButton: (view: EditorView, extensionProvider: ExtensionProvider) => Promise<UpdateExtension<any> | undefined>;
@@ -14,5 +13,5 @@ export declare const createExtensionProviderHandler: (view: EditorView) => (name
 export declare const createContextIdentifierProviderHandler: (view: EditorView) => (name: string, provider?: Promise<ContextIdentifierProvider> | undefined) => Promise<void>;
 declare const createPlugin: (dispatch: Dispatch, providerFactory: ProviderFactory, extensionHandlers: ExtensionHandlers, portalProviderAPI: PortalProviderAPI, eventDispatcher: EventDispatcher, useLongPressSelection?: boolean, options?: {
     appearance?: EditorAppearance;
-}) => SafePlugin<ExtensionState<import("@atlaskit/editor-common/extensions").Parameters>, import("prosemirror-model").Schema<any, any>>;
+}) => SafePlugin<import("../types").ExtensionState<import("@atlaskit/editor-common/extensions").Parameters>, import("prosemirror-model").Schema<any, any>>;
 export { pluginKey, createPlugin, createCommand, getPluginState };

package/dist/types/plugins/extension/types.d.ts

@@ -3,7 +3,6 @@ import { UpdateExtension, ExtensionProvider, Parameters, TransformBefore, Transf
 export declare type ExtensionState<T extends Parameters = Parameters> = {
     localId?: string;
     autoSaveResolve?: () => void;
-    shouldRefreshEditButton: boolean;
     showEditButton: boolean;
     showContextPanel: boolean;
     updateExtension?: Promise<UpdateExtension<T> | void>;

package/dist/types/plugins/extension/utils.d.ts

@@ -1,12 +1,10 @@
 import { Schema, Mark } from 'prosemirror-model';
-import { EditorState, ReadonlyTransaction } from 'prosemirror-state';
+import { EditorState } from 'prosemirror-state';
 import { Node as PMNode } from 'prosemirror-model';
 import { NodeWithPos, DomAtPos } from 'prosemirror-utils';
-import type { ExtensionState } from './types';
 export declare const getSelectedExtension: (state: EditorState, searchParent?: boolean) => import("prosemirror-utils").ContentNodeWithPos | undefined;
 export declare const findExtensionWithLocalId: (state: EditorState, localId?: string | undefined) => NodeWithPos | undefined;
 export declare const getSelectedDomElement: (schema: Schema, domAtPos: DomAtPos, selectedExtensionNode: NodeWithPos) => HTMLElement;
 export declare const getDataConsumerMark: (newNode: PMNode) => Mark | undefined;
 export declare const getNodeTypesReferenced: (ids: string[], state: EditorState) => string[];
 export declare const findNodePosWithLocalId: (state: EditorState, localId: string) => NodeWithPos | undefined;
-export declare const onSelectionChanged: (tr: ReadonlyTransaction, state: ExtensionState) => ExtensionState;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-core",
-  "version": "166.0.1",
+  "version": "166.0.4",
   "description": "A package contains Atlassian editor core functionality",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -69,7 +69,7 @@
     "@atlaskit/radio": "^5.3.0",
     "@atlaskit/section-message": "^6.1.0",
     "@atlaskit/select": "^15.2.0",
-    "@atlaskit/smart-user-picker": "^5.0.2",
+    "@atlaskit/smart-user-picker": "^5.1.0",
     "@atlaskit/spinner": "^15.1.0",
     "@atlaskit/status": "^1.1.0",
     "@atlaskit/tabs": "^13.2.0",
@@ -159,7 +159,7 @@
     "@atlaskit/section-message": "^6.1.0",
     "@atlaskit/share": "*",
     "@atlaskit/smart-card": "^19.1.0",
-    "@atlaskit/smart-user-picker": "^5.0.2",
+    "@atlaskit/smart-user-picker": "^5.1.0",
     "@atlaskit/synchrony-test-helpers": "^2.3.0",
     "@atlaskit/textarea": "^4.3.0",
     "@atlaskit/toggle": "^12.4.0",
@@ -168,7 +168,7 @@
     "@atlaskit/visual-regression": "*",
     "@atlaskit/webdriver-runner": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
-    "@atlassian/search-provider": "2.2.4",
+    "@atlassian/search-provider": "2.3.0",
     "@atlassian/ufo": "^0.1.0",
     "@emotion/jest": "^11.8.0",
     "@testing-library/dom": "^7.7.3",