@atlaskit/editor-core 151.0.0 → 151.1.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-core
 
+## 151.1.0
+
+### Minor Changes
+
+- [`c80c71b537d`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c80c71b537d) - [ux] ED-13860 add bidi warning decorations to code components
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 151.0.0
 
 ### Major Changes

package/dist/cjs/create-editor/create-plugins-list.js

@@ -413,6 +413,10 @@ function createPluginsList(props, prevProps, createAnalyticsEvent) {
     preset.add([_plugins.viewUpdateSubscriptionPlugin]);
   }
 
+  if (featureFlags.codeBidiWarnings) {
+    preset.add(_plugins.codeBidiWarningPlugin);
+  }
+
   var excludes = new Set();
 
   if (!isCodeBlockAllowed({

package/dist/cjs/plugins/code-bidi-warning/index.js

@@ -0,0 +1,25 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+
+var _main = require("./pm-plugins/main");
+
+var codeBidiWarning = function codeBidiWarning() {
+  return {
+    name: 'codeBidiWarning',
+    pmPlugins: function pmPlugins() {
+      return [{
+        name: 'codeBidiWarning',
+        plugin: function plugin(options) {
+          return (0, _main.createPlugin)(options);
+        }
+      }];
+    }
+  };
+};
+
+var _default = codeBidiWarning;
+exports.default = _default;

package/dist/cjs/plugins/code-bidi-warning/plugin-key.js

@@ -0,0 +1,11 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.codeBidiWarningPluginKey = void 0;
+
+var _prosemirrorState = require("prosemirror-state");
+
+var codeBidiWarningPluginKey = new _prosemirrorState.PluginKey('codeBidiWarningPlugin');
+exports.codeBidiWarningPluginKey = codeBidiWarningPluginKey;

package/dist/cjs/plugins/code-bidi-warning/pm-plugins/main.js

@@ -0,0 +1,43 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.createPlugin = void 0;
+
+var _prosemirrorState = require("prosemirror-state");
+
+var _messages = require("@atlaskit/editor-common/messages");
+
+var _pluginKey = require("../plugin-key");
+
+var _pluginFactory = require("./plugin-factory");
+
+var createPlugin = function createPlugin(_ref) {
+  var dispatch = _ref.dispatch,
+      reactContext = _ref.reactContext;
+  var intl = reactContext().intl;
+  var codeBidiWarningLabel = intl.formatMessage(_messages.codeBidiWarningMessages.label);
+  return new _prosemirrorState.Plugin({
+    key: _pluginKey.codeBidiWarningPluginKey,
+    state: (0, _pluginFactory.createPluginState)(dispatch, function (state) {
+      return {
+        decorationSet: (0, _pluginFactory.createBidiWarningsDecorationSetFromDoc)({
+          doc: state.doc,
+          codeBidiWarningLabel: codeBidiWarningLabel
+        }),
+        codeBidiWarningLabel: codeBidiWarningLabel
+      };
+    }),
+    props: {
+      decorations: function decorations(state) {
+        var _getPluginState = (0, _pluginFactory.getPluginState)(state),
+            decorationSet = _getPluginState.decorationSet;
+
+        return decorationSet;
+      }
+    }
+  });
+};
+
+exports.createPlugin = createPlugin;

package/dist/cjs/plugins/code-bidi-warning/pm-plugins/plugin-factory.js

@@ -0,0 +1,118 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.createBidiWarningsDecorationSetFromDoc = createBidiWarningsDecorationSetFromDoc;
+exports.getPluginState = exports.createPluginState = void 0;
+
+var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+
+var _react = _interopRequireDefault(require("react"));
+
+var _reactDom = _interopRequireDefault(require("react-dom"));
+
+var _prosemirrorView = require("prosemirror-view");
+
+var _bidiWarning = _interopRequireDefault(require("@atlaskit/code/bidi-warning"));
+
+var _bidiWarningDecorator = _interopRequireDefault(require("@atlaskit/code/bidi-warning-decorator"));
+
+var _pluginStateFactory = require("../../../utils/plugin-state-factory");
+
+var _step = require("../../../utils/step");
+
+var _pluginKey = require("../plugin-key");
+
+var _reducer = _interopRequireDefault(require("./reducer"));
+
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) { symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); } keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(Object(source), true).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
+var _pluginFactory = (0, _pluginStateFactory.pluginFactory)(_pluginKey.codeBidiWarningPluginKey, _reducer.default, {
+  onDocChanged: function onDocChanged(tr, pluginState) {
+    if (!tr.steps.find(_step.stepHasSlice)) {
+      return pluginState;
+    }
+
+    var newBidiWarningsDecorationSet = createBidiWarningsDecorationSetFromDoc({
+      doc: tr.doc,
+      codeBidiWarningLabel: pluginState.codeBidiWarningLabel
+    });
+    return _objectSpread(_objectSpread({}, pluginState), {}, {
+      decorationSet: newBidiWarningsDecorationSet
+    });
+  }
+}),
+    createPluginState = _pluginFactory.createPluginState,
+    getPluginState = _pluginFactory.getPluginState;
+
+exports.getPluginState = getPluginState;
+exports.createPluginState = createPluginState;
+
+function createBidiWarningsDecorationSetFromDoc(_ref) {
+  var doc = _ref.doc,
+      codeBidiWarningLabel = _ref.codeBidiWarningLabel;
+  var bidiCharactersAndTheirPositions = [];
+  doc.descendants(function (node, pos) {
+    var isTextWithCodeMark = node.type.name === 'text' && node.marks && node.marks.some(function (mark) {
+      return mark.type.name === 'code';
+    });
+
+    if (isTextWithCodeMark) {
+      (0, _bidiWarningDecorator.default)(node.textContent, function (_ref2) {
+        var bidiCharacter = _ref2.bidiCharacter,
+            index = _ref2.index;
+        bidiCharactersAndTheirPositions.push({
+          position: pos + index,
+          bidiCharacter: bidiCharacter
+        });
+      });
+      return false;
+    }
+
+    var isCodeBlock = node.type.name === 'codeBlock';
+
+    if (isCodeBlock) {
+      (0, _bidiWarningDecorator.default)(node.textContent, function (_ref3) {
+        var bidiCharacter = _ref3.bidiCharacter,
+            index = _ref3.index;
+        bidiCharactersAndTheirPositions.push({
+          position: pos + index + 1,
+          bidiCharacter: bidiCharacter
+        });
+      });
+    }
+  }); // Bidi characters are not expected to commonly appear in code snippets, so recreating the decoration set
+  // for documents rather than reusing existing decorations seems a reasonable performance/complexity tradeoff.
+
+  if (bidiCharactersAndTheirPositions.length === 0) {
+    return _prosemirrorView.DecorationSet.empty;
+  }
+
+  var newBidiWarningsDecorationSet = _prosemirrorView.DecorationSet.create(doc, bidiCharactersAndTheirPositions.map(function (_ref4) {
+    var position = _ref4.position,
+        bidiCharacter = _ref4.bidiCharacter;
+    return _prosemirrorView.Decoration.widget(position, function () {
+      return renderDOM(bidiCharacter, codeBidiWarningLabel);
+    });
+  }));
+
+  return newBidiWarningsDecorationSet;
+}
+
+function renderDOM(bidiCharacter, codeBidiWarningLabel) {
+  var element = document.createElement('span'); // Note: we use this pattern elsewhere (see highlighting code block, and drop cursor widget decoration)
+  // we should investigate if there is a memory leak with such usage.
+
+  _reactDom.default.render( /*#__PURE__*/_react.default.createElement(_bidiWarning.default, {
+    bidiCharacter: bidiCharacter,
+    skipChildren: true,
+    label: codeBidiWarningLabel
+  }), element);
+
+  return element;
+}

package/dist/cjs/plugins/code-bidi-warning/pm-plugins/reducer.js

@@ -0,0 +1,12 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+
+var _default = function _default(pluginState, action) {
+  return pluginState;
+};
+
+exports.default = _default;

package/dist/cjs/plugins/code-bidi-warning/pm-plugins/types.js

@@ -0,0 +1,5 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});

package/dist/cjs/plugins/code-block/index.js

@@ -40,8 +40,12 @@ var codeBlockPlugin = function codeBlockPlugin() {
     pmPlugins: function pmPlugins() {
       return [{
         name: 'codeBlock',
-        plugin: function plugin() {
-          return (0, _main.createPlugin)(options.useLongPressSelection);
+        plugin: function plugin(_ref) {
+          var reactContext = _ref.reactContext;
+          return (0, _main.createPlugin)({
+            useLongPressSelection: options.useLongPressSelection,
+            reactContext: reactContext
+          });
         }
       }, {
         name: 'codeBlockIDEKeyBindings',
@@ -50,8 +54,8 @@ var codeBlockPlugin = function codeBlockPlugin() {
         }
       }, {
         name: 'codeBlockKeyMap',
-        plugin: function plugin(_ref) {
-          var schema = _ref.schema;
+        plugin: function plugin(_ref2) {
+          var schema = _ref2.schema;
           return (0, _keymaps.default)(schema);
         }
       }];
@@ -62,8 +66,8 @@ var codeBlockPlugin = function codeBlockPlugin() {
       (0, _refreshBrowserSelection.default)(props.originalTransaction, props.newEditorState);
     },
     pluginsOptions: {
-      quickInsert: function quickInsert(_ref2) {
-        var formatMessage = _ref2.formatMessage;
+      quickInsert: function quickInsert(_ref3) {
+        var formatMessage = _ref3.formatMessage;
         return [{
           id: 'codeblock',
           title: formatMessage(_messages.messages.codeblock),

package/dist/cjs/plugins/code-block/nodeviews/highlighting-code-block.js

@@ -50,7 +50,7 @@ var toDOM = function toDOM(node) {
 };
 
 var CodeBlockView = /*#__PURE__*/function () {
-  function CodeBlockView(_node, view, getPos) {
+  function CodeBlockView(_node, view, getPos, codeBidiWarningOptions) {
     var _this = this;
 
     (0, _classCallCheck2.default)(this, CodeBlockView);
@@ -77,6 +77,7 @@ var CodeBlockView = /*#__PURE__*/function () {
         dom = _DOMSerializer$render.dom,
         contentDOM = _DOMSerializer$render.contentDOM;
 
+    this.codeBidiWarningOptions = codeBidiWarningOptions;
     this.getPos = getPos;
     this.view = view;
     this.node = _node;
@@ -130,7 +131,9 @@ var CodeBlockView = /*#__PURE__*/function () {
       _reactDom.default.render( /*#__PURE__*/_react.default.createElement(_code.CodeBlock, {
         text: node.textContent,
         language: node.attrs.language,
-        showLineNumbers: false
+        showLineNumbers: false,
+        codeBidiWarnings: this.codeBidiWarningOptions.enabled,
+        codeBidiWarningLabel: this.codeBidiWarningOptions.label
       }), highlighting);
 
       this.measure(performance.now() - start);
@@ -164,7 +167,10 @@ var CodeBlockView = /*#__PURE__*/function () {
     value: function ignoreMutation(record) {
       var _this$highlighting$co, _this$highlighting;
 
-      return record.target === this.lineNumberGutter || record.target.parentNode === this.lineNumberGutter || ((_this$highlighting$co = (_this$highlighting = this.highlighting) === null || _this$highlighting === void 0 ? void 0 : _this$highlighting.contains(record.target)) !== null && _this$highlighting$co !== void 0 ? _this$highlighting$co : false);
+      var lineNumberChanges = record.target === this.lineNumberGutter || record.target.parentNode === this.lineNumberGutter;
+      var outsideTheCodeBlockChanges = (_this$highlighting$co = (_this$highlighting = this.highlighting) === null || _this$highlighting === void 0 ? void 0 : _this$highlighting.contains(record.target)) !== null && _this$highlighting$co !== void 0 ? _this$highlighting$co : false;
+      var codeBidiWarningDecorationChanges = record.type === 'attributes' && record.attributeName === 'aria-describedby';
+      return lineNumberChanges || outsideTheCodeBlockChanges || codeBidiWarningDecorationChanges;
     }
   }]);
   return CodeBlockView;
@@ -172,9 +178,14 @@ var CodeBlockView = /*#__PURE__*/function () {
 
 exports.CodeBlockView = CodeBlockView;
 
-var highlightingCodeBlockNodeView = function highlightingCodeBlockNodeView() {
+var highlightingCodeBlockNodeView = function highlightingCodeBlockNodeView(_ref) {
+  var codeBidiWarnings = _ref.codeBidiWarnings,
+      codeBidiWarningLabel = _ref.codeBidiWarningLabel;
   return function (node, view, getPos) {
-    return new CodeBlockView(node, view, getPos);
+    return new CodeBlockView(node, view, getPos, {
+      enabled: codeBidiWarnings,
+      label: codeBidiWarningLabel
+    });
   };
 };
 

package/dist/cjs/plugins/code-block/pm-plugins/main.js

@@ -11,6 +11,8 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 
 var _prosemirrorState = require("prosemirror-state");
 
+var _messages = require("@atlaskit/editor-common/messages");
+
 var _codeBlock = require("../nodeviews/code-block");
 
 var _highlightingCodeBlock = require("../nodeviews/highlighting-code-block");
@@ -31,8 +33,12 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(Object(source), true).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
 
-var createPlugin = function createPlugin() {
-  var useLongPressSelection = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : false;
+var createPlugin = function createPlugin(_ref) {
+  var _ref$useLongPressSele = _ref.useLongPressSelection,
+      useLongPressSelection = _ref$useLongPressSele === void 0 ? false : _ref$useLongPressSele,
+      reactContext = _ref.reactContext;
+  var intl = reactContext().intl;
+  var codeBidiWarningLabel = intl.formatMessage(_messages.codeBidiWarningMessages.label);
   return new _prosemirrorState.Plugin({
     state: {
       init: function init(_, state) {
@@ -71,7 +77,10 @@ var createPlugin = function createPlugin() {
       nodeViews: {
         codeBlock: function codeBlock(node, view, getPos) {
           var featureFlags = (0, _featureFlagsContext.getFeatureFlags)(view.state);
-          var createCodeBlockNodeView = featureFlags !== null && featureFlags !== void 0 && featureFlags.codeBlockSyntaxHighlighting ? (0, _highlightingCodeBlock.highlightingCodeBlockNodeView)() : (0, _codeBlock.codeBlockNodeView)();
+          var createCodeBlockNodeView = featureFlags !== null && featureFlags !== void 0 && featureFlags.codeBlockSyntaxHighlighting ? (0, _highlightingCodeBlock.highlightingCodeBlockNodeView)({
+            codeBidiWarnings: featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.codeBidiWarnings,
+            codeBidiWarningLabel: codeBidiWarningLabel
+          }) : (0, _codeBlock.codeBlockNodeView)();
           return createCodeBlockNodeView(node, view, getPos);
         }
       },

package/dist/cjs/plugins/feature-flags-context/feature-flags-from-props.js

@@ -24,7 +24,7 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
  * which is used by both current and archv3 editors.
  */
 function createFeatureFlagsFromProps(props) {
-  var _props$allowTextColor, _props$performanceTra, _props$performanceTra2, _props$featureFlags, _props$featureFlags2, _props$featureFlags3, _props$allowTables, _props$featureFlags4, _props$featureFlags5, _props$allowTables2, _props$featureFlags6, _props$featureFlags7, _props$allowTables3, _props$featureFlags8, _props$featureFlags9, _props$allowTables4, _props$featureFlags10, _props$featureFlags11, _props$allowTables5, _props$allowExtension, _props$featureFlags12, _props$featureFlags13, _props$featureFlags14, _props$featureFlags15, _props$featureFlags16, _props$featureFlags17, _props$featureFlags18, _props$featureFlags19, _props$featureFlags20, _props$featureFlags21, _props$featureFlags22, _props$featureFlags23, _props$featureFlags24, _props$featureFlags25, _props$featureFlags26, _props$featureFlags27;
+  var _props$allowTextColor, _props$performanceTra, _props$performanceTra2, _props$featureFlags, _props$featureFlags2, _props$featureFlags3, _props$allowTables, _props$featureFlags4, _props$featureFlags5, _props$allowTables2, _props$featureFlags6, _props$featureFlags7, _props$allowTables3, _props$featureFlags8, _props$featureFlags9, _props$allowTables4, _props$featureFlags10, _props$featureFlags11, _props$allowTables5, _props$allowExtension, _props$featureFlags12, _props$featureFlags13, _props$featureFlags14, _props$featureFlags15, _props$featureFlags16, _props$featureFlags17, _props$featureFlags18, _props$featureFlags19, _props$featureFlags20, _props$featureFlags21, _props$featureFlags22, _props$featureFlags23, _props$featureFlags24, _props$featureFlags25, _props$featureFlags26, _props$featureFlags27, _props$featureFlags28, _props$featureFlags29;
 
   var normalizedFeatureFlags = (0, _normalizeFeatureFlags.normalizeFeatureFlags)(props.featureFlags);
   return _objectSpread(_objectSpread({}, normalizedFeatureFlags), {}, {
@@ -54,6 +54,7 @@ function createFeatureFlagsFromProps(props) {
     enableViewUpdateSubscription: Boolean(typeof ((_props$featureFlags22 = props.featureFlags) === null || _props$featureFlags22 === void 0 ? void 0 : _props$featureFlags22.enableViewUpdateSubscription) === 'boolean' ? !!((_props$featureFlags23 = props.featureFlags) !== null && _props$featureFlags23 !== void 0 && _props$featureFlags23.enableViewUpdateSubscription) : false),
     collabAvatarScroll: Boolean(typeof ((_props$featureFlags24 = props.featureFlags) === null || _props$featureFlags24 === void 0 ? void 0 : _props$featureFlags24.collabAvatarScroll) === 'boolean' ? !!((_props$featureFlags25 = props.featureFlags) !== null && _props$featureFlags25 !== void 0 && _props$featureFlags25.collabAvatarScroll) : false),
     ufo: Boolean(typeof ((_props$featureFlags26 = props.featureFlags) === null || _props$featureFlags26 === void 0 ? void 0 : _props$featureFlags26.ufo) === 'boolean' ? !!((_props$featureFlags27 = props.featureFlags) !== null && _props$featureFlags27 !== void 0 && _props$featureFlags27.ufo) : false),
-    codeBlockSyntaxHighlighting: Boolean(typeof normalizedFeatureFlags.codeBlockSyntaxHighlighting === 'boolean' ? !!normalizedFeatureFlags.codeBlockSyntaxHighlighting && !_editorCommon.browser.safari : false)
+    codeBlockSyntaxHighlighting: Boolean(typeof normalizedFeatureFlags.codeBlockSyntaxHighlighting === 'boolean' ? !!normalizedFeatureFlags.codeBlockSyntaxHighlighting && !_editorCommon.browser.safari : false),
+    codeBidiWarnings: Boolean(typeof ((_props$featureFlags28 = props.featureFlags) === null || _props$featureFlags28 === void 0 ? void 0 : _props$featureFlags28.codeBidiWarnings) === 'boolean' ? !!((_props$featureFlags29 = props.featureFlags) !== null && _props$featureFlags29 !== void 0 && _props$featureFlags29.codeBidiWarnings) : true)
   });
 }

package/dist/cjs/plugins/index.js

@@ -391,6 +391,12 @@ Object.defineProperty(exports, "viewUpdateSubscriptionPlugin", {
     return _viewUpdateSubscription.default;
   }
 });
+Object.defineProperty(exports, "codeBidiWarningPlugin", {
+  enumerable: true,
+  get: function get() {
+    return _codeBidiWarning.default;
+  }
+});
 
 var _base = _interopRequireDefault(require("./base"));
 
@@ -516,6 +522,8 @@ var _avatarGroup = _interopRequireDefault(require("./avatar-group"));
 
 var _viewUpdateSubscription = _interopRequireDefault(require("./view-update-subscription"));
 
+var _codeBidiWarning = _interopRequireDefault(require("./code-bidi-warning"));
+
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }

package/dist/cjs/plugins/rank.js

@@ -12,7 +12,7 @@ var _default = {
   // https://product-fabric.atlassian.net/wiki/spaces/E/pages/1113098008/Selection+Guide#Special-Cases
   'expandKeymap', 'tableSelectionKeymap', 'tableKeymap', 'captionKeymap', // selection keymap needs to be above gap cursor keymap so it can set node selections from
   // left/right arrows
-  'selectionKeymap', 'gapCursorKeymap', 'gapCursor', 'syncUrlText', 'fakeCursorToolbarPlugin', 'hyperLink', 'table', 'tableDecorations', 'hyperlinkInputRule', 'tablePMColResizing', 'hyperlinkKeymap', 'tableColResizing', 'undoRedoKeyMap', 'blockTypeKeyMap', 'tableEditing', 'filterStepsPlugin', 'pmCollab', 'collab', 'ruleInputRule', 'ruleKeymap', 'panel', 'media', 'mediaKeymap', 'mediaSingleKeymap', 'mediaEditor', 'unsupportedContent', 'jiraIssue', 'fakeTextCursor', 'helpDialog', 'helpDialogKeymap', 'macro', 'expand', 'extension', 'layout', 'contextPanel', 'floatingToolbar', 'clearMarksOnChange', 'reactNodeView', 'history', 'undoRedoPlugin', 'codeBlockIndent', 'placeholder', 'width', 'maxContentSize', 'multilineContent', 'grid', 'mobileDimensions', 'scrollGutterPlugin', 'analytics', 'findReplace', 'selection', 'avatarGroup', 'viewUpdateSubscription'],
+  'selectionKeymap', 'gapCursorKeymap', 'gapCursor', 'syncUrlText', 'fakeCursorToolbarPlugin', 'hyperLink', 'table', 'tableDecorations', 'hyperlinkInputRule', 'tablePMColResizing', 'hyperlinkKeymap', 'tableColResizing', 'undoRedoKeyMap', 'blockTypeKeyMap', 'tableEditing', 'filterStepsPlugin', 'pmCollab', 'collab', 'ruleInputRule', 'ruleKeymap', 'panel', 'media', 'mediaKeymap', 'mediaSingleKeymap', 'mediaEditor', 'unsupportedContent', 'jiraIssue', 'fakeTextCursor', 'helpDialog', 'helpDialogKeymap', 'macro', 'expand', 'extension', 'layout', 'contextPanel', 'floatingToolbar', 'clearMarksOnChange', 'reactNodeView', 'history', 'undoRedoPlugin', 'codeBlockIndent', 'placeholder', 'width', 'maxContentSize', 'multilineContent', 'grid', 'mobileDimensions', 'scrollGutterPlugin', 'analytics', 'findReplace', 'selection', 'avatarGroup', 'viewUpdateSubscription', 'inlineCode'],
   nodes: ['doc', 'paragraph', 'text', 'bulletList', 'orderedList', 'listItem', 'heading', 'blockquote', 'codeBlock', 'rule', 'panel', 'mention', 'confluenceUnsupportedBlock', 'confluenceUnsupportedInline', 'unsupportedBlock', 'unsupportedInline', 'confluenceJiraIssue', 'hardBreak', 'emoji', 'placeholder', 'mediaSingle', 'mediaGroup', 'table', 'expand', 'nestedExpand', 'media', 'tableHeader', 'decisionList', 'tableRow', 'decisionItem', 'tableCell', 'taskList', 'taskItem', 'extension', 'bodiedExtension', 'inlineExtension', 'layoutSection', 'layoutColumn', 'inlineCard', 'blockCard', 'embedCard'],
   marks: [// Inline marks
   'link', 'em', 'strong', 'textColor', 'strike', 'subsup', 'underline', 'code', 'typeAheadQuery', // Block marks

package/dist/cjs/version-wrapper.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.nextMajorVersion = exports.version = exports.name = void 0;
 var name = "@atlaskit/editor-core";
 exports.name = name;
-var version = "151.0.0";
+var version = "151.1.0";
 exports.version = version;
 
 var nextMajorVersion = function nextMajorVersion() {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-core",
-	"version": "151.0.0",
+	"version": "151.1.0",
 	"sideEffects": false
 }

package/dist/es2019/create-editor/create-plugins-list.js

@@ -1,4 +1,4 @@
-import { breakoutPlugin, collabEditPlugin, dataConsumerMarkPlugin, datePlugin, emojiPlugin, extensionPlugin, helpDialogPlugin, imageUploadPlugin, insertBlockPlugin, jiraIssuePlugin, layoutPlugin, listPlugin, macroPlugin, maxContentSizePlugin, mediaPlugin, mentionsPlugin, panelPlugin, placeholderTextPlugin, rulePlugin, saveOnEnterPlugin, tablesPlugin, tasksAndDecisionsPlugin, textColorPlugin, cardPlugin, gridPlugin, statusPlugin, alignmentPlugin, indentationPlugin, analyticsPlugin, customAutoformatPlugin, feedbackDialogPlugin, historyPlugin, expandPlugin, isExpandInsertionEnabled, scrollIntoViewPlugin, mobileDimensionsPlugin, findReplacePlugin, contextPanelPlugin, mobileSelectionPlugin, annotationPlugin, captionPlugin, avatarGroupPlugin, viewUpdateSubscriptionPlugin } from '../plugins';
+import { breakoutPlugin, collabEditPlugin, dataConsumerMarkPlugin, datePlugin, emojiPlugin, extensionPlugin, helpDialogPlugin, imageUploadPlugin, insertBlockPlugin, jiraIssuePlugin, layoutPlugin, listPlugin, macroPlugin, maxContentSizePlugin, mediaPlugin, mentionsPlugin, panelPlugin, placeholderTextPlugin, rulePlugin, saveOnEnterPlugin, tablesPlugin, tasksAndDecisionsPlugin, textColorPlugin, cardPlugin, gridPlugin, statusPlugin, alignmentPlugin, indentationPlugin, analyticsPlugin, customAutoformatPlugin, feedbackDialogPlugin, historyPlugin, expandPlugin, isExpandInsertionEnabled, scrollIntoViewPlugin, mobileDimensionsPlugin, findReplacePlugin, contextPanelPlugin, mobileSelectionPlugin, annotationPlugin, captionPlugin, avatarGroupPlugin, viewUpdateSubscriptionPlugin, codeBidiWarningPlugin } from '../plugins';
 import { isFullPage as fullPageCheck } from '../utils/is-full-page';
 import { GUTTER_SIZE_MOBILE_IN_PX } from '../plugins/base/pm-plugins/scroll-gutter';
 import { createFeatureFlagsFromProps } from '../plugins/feature-flags-context/feature-flags-from-props';
@@ -389,6 +389,10 @@ export default function createPluginsList(props, prevProps, createAnalyticsEvent
     preset.add([viewUpdateSubscriptionPlugin]);
   }
 
+  if (featureFlags.codeBidiWarnings) {
+    preset.add(codeBidiWarningPlugin);
+  }
+
   const excludes = new Set();
 
   if (!isCodeBlockAllowed({

package/dist/es2019/plugins/code-bidi-warning/index.js

@@ -0,0 +1,15 @@
+import { createPlugin } from './pm-plugins/main';
+
+const codeBidiWarning = () => ({
+  name: 'codeBidiWarning',
+
+  pmPlugins() {
+    return [{
+      name: 'codeBidiWarning',
+      plugin: options => createPlugin(options)
+    }];
+  }
+
+});
+
+export default codeBidiWarning;

package/dist/es2019/plugins/code-bidi-warning/plugin-key.js

@@ -0,0 +1,2 @@
+import { PluginKey } from 'prosemirror-state';
+export const codeBidiWarningPluginKey = new PluginKey('codeBidiWarningPlugin');

package/dist/es2019/plugins/code-bidi-warning/pm-plugins/main.js

@@ -0,0 +1,31 @@
+import { Plugin } from 'prosemirror-state';
+import { codeBidiWarningMessages } from '@atlaskit/editor-common/messages';
+import { codeBidiWarningPluginKey } from '../plugin-key';
+import { createBidiWarningsDecorationSetFromDoc, createPluginState, getPluginState } from './plugin-factory';
+export const createPlugin = ({
+  dispatch,
+  reactContext
+}) => {
+  const intl = reactContext().intl;
+  const codeBidiWarningLabel = intl.formatMessage(codeBidiWarningMessages.label);
+  return new Plugin({
+    key: codeBidiWarningPluginKey,
+    state: createPluginState(dispatch, state => {
+      return {
+        decorationSet: createBidiWarningsDecorationSetFromDoc({
+          doc: state.doc,
+          codeBidiWarningLabel
+        }),
+        codeBidiWarningLabel
+      };
+    }),
+    props: {
+      decorations: state => {
+        const {
+          decorationSet
+        } = getPluginState(state);
+        return decorationSet;
+      }
+    }
+  });
+};

package/dist/es2019/plugins/code-bidi-warning/pm-plugins/plugin-factory.js

@@ -0,0 +1,88 @@
+import React from 'react';
+import ReactDOM from 'react-dom';
+import { Decoration, DecorationSet } from 'prosemirror-view';
+import CodeBidiWarning from '@atlaskit/code/bidi-warning';
+import codeBidiWarningDecorator from '@atlaskit/code/bidi-warning-decorator';
+import { pluginFactory } from '../../../utils/plugin-state-factory';
+import { stepHasSlice } from '../../../utils/step';
+import { codeBidiWarningPluginKey } from '../plugin-key';
+import reducer from './reducer';
+export const {
+  createPluginState,
+  getPluginState
+} = pluginFactory(codeBidiWarningPluginKey, reducer, {
+  onDocChanged: (tr, pluginState) => {
+    if (!tr.steps.find(stepHasSlice)) {
+      return pluginState;
+    }
+
+    const newBidiWarningsDecorationSet = createBidiWarningsDecorationSetFromDoc({
+      doc: tr.doc,
+      codeBidiWarningLabel: pluginState.codeBidiWarningLabel
+    });
+    return { ...pluginState,
+      decorationSet: newBidiWarningsDecorationSet
+    };
+  }
+});
+export function createBidiWarningsDecorationSetFromDoc({
+  doc,
+  codeBidiWarningLabel
+}) {
+  const bidiCharactersAndTheirPositions = [];
+  doc.descendants((node, pos) => {
+    const isTextWithCodeMark = node.type.name === 'text' && node.marks && node.marks.some(mark => mark.type.name === 'code');
+
+    if (isTextWithCodeMark) {
+      codeBidiWarningDecorator(node.textContent, ({
+        bidiCharacter,
+        index
+      }) => {
+        bidiCharactersAndTheirPositions.push({
+          position: pos + index,
+          bidiCharacter
+        });
+      });
+      return false;
+    }
+
+    const isCodeBlock = node.type.name === 'codeBlock';
+
+    if (isCodeBlock) {
+      codeBidiWarningDecorator(node.textContent, ({
+        bidiCharacter,
+        index
+      }) => {
+        bidiCharactersAndTheirPositions.push({
+          position: pos + index + 1,
+          bidiCharacter
+        });
+      });
+    }
+  }); // Bidi characters are not expected to commonly appear in code snippets, so recreating the decoration set
+  // for documents rather than reusing existing decorations seems a reasonable performance/complexity tradeoff.
+
+  if (bidiCharactersAndTheirPositions.length === 0) {
+    return DecorationSet.empty;
+  }
+
+  const newBidiWarningsDecorationSet = DecorationSet.create(doc, bidiCharactersAndTheirPositions.map(({
+    position,
+    bidiCharacter
+  }) => {
+    return Decoration.widget(position, () => renderDOM(bidiCharacter, codeBidiWarningLabel));
+  }));
+  return newBidiWarningsDecorationSet;
+}
+
+function renderDOM(bidiCharacter, codeBidiWarningLabel) {
+  const element = document.createElement('span'); // Note: we use this pattern elsewhere (see highlighting code block, and drop cursor widget decoration)
+  // we should investigate if there is a memory leak with such usage.
+
+  ReactDOM.render( /*#__PURE__*/React.createElement(CodeBidiWarning, {
+    bidiCharacter: bidiCharacter,
+    skipChildren: true,
+    label: codeBidiWarningLabel
+  }), element);
+  return element;
+}

package/dist/es2019/plugins/code-bidi-warning/pm-plugins/reducer.js

@@ -0,0 +1,3 @@
+export default ((pluginState, action) => {
+  return pluginState;
+});

package/dist/es2019/plugins/code-bidi-warning/pm-plugins/types.js

@@ -0,0 +1 @@
+export {};

package/dist/es2019/plugins/code-block/index.js

@@ -22,7 +22,12 @@ const codeBlockPlugin = (options = {}) => ({
   pmPlugins() {
     return [{
       name: 'codeBlock',
-      plugin: () => createPlugin(options.useLongPressSelection)
+      plugin: ({
+        reactContext
+      }) => createPlugin({
+        useLongPressSelection: options.useLongPressSelection,
+        reactContext
+      })
     }, {
       name: 'codeBlockIDEKeyBindings',
       plugin: () => ideUX