@atlaskit/editor-common 94.5.1 → 94.6.1

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @atlaskit/editor-common
 
+## 94.6.1
+
+### Patch Changes
+
+- [#157477](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/157477)
+  [`b62c7289b73f2`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/b62c7289b73f2) -
+  ED-24722 Clean up platform.editor.media.inline-image.base-support FF
+
+## 94.6.0
+
+### Minor Changes
+
+- [#157489](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/157489)
+  [`00657197923b2`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/00657197923b2) -
+  We are testing replacing findDOMNode with an explicit ref behind a feature flag. If this fix is
+  successful it will be available in a later release.
+
+### Patch Changes
+
+- [#157432](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/157432)
+  [`f42393192e79d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/f42393192e79d) -
+  set button appearance to subtle to remove unwanted grey border
+
 ## 94.5.1
 
 ### Patch Changes

package/afm-cc/tsconfig.json

@@ -5,8 +5,7 @@
         "target": "es5",
         "composite": true,
         "outDir": "../dist",
-        "rootDir": "../",
-        "baseUrl": "../"
+        "rootDir": "../"
     },
     "include": [
         "../src/**/*.ts",

package/dist/cjs/media-inline/utils.js

@@ -4,10 +4,9 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.mediaInlineImagesEnabled = void 0;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 /**
  * Enable media inline images feature based on
- * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages and platform FF platform.editor.media.inline-image.base-support
+ * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages
  *
  * The reason not using mediaOption as param is because MediaOption is from editor-plugin-media
  * we want to avoid circular deps
@@ -16,5 +15,5 @@ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
  * @returns boolean
  */
 var mediaInlineImagesEnabled = exports.mediaInlineImagesEnabled = function mediaInlineImagesEnabled(allowMediaInline, allowMediaInlineImages) {
-  return allowMediaInline && allowMediaInlineImages && (0, _platformFeatureFlags.getBooleanFF)('platform.editor.media.inline-image.base-support');
+  return allowMediaInline && allowMediaInlineImages;
 };

package/dist/cjs/monitoring/error.js

@@ -17,7 +17,7 @@ function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "94.5.1";
+var packageVersion = "94.6.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "94.5.1";
+var packageVersion = "94.6.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/cjs/ui/index.js

@@ -137,6 +137,12 @@ Object.defineProperty(exports, "PanelTextInput", {
     return _PanelTextInput.default;
   }
 });
+Object.defineProperty(exports, "PlainOutsideClickTargetRefContext", {
+  enumerable: true,
+  get: function get() {
+    return _withOuterListeners.PlainOutsideClickTargetRefContext;
+  }
+});
 Object.defineProperty(exports, "Popup", {
   enumerable: true,
   get: function get() {
@@ -404,7 +410,7 @@ var _Popup = _interopRequireWildcard(require("./Popup"));
 var _UnsupportedBlock = _interopRequireDefault(require("./UnsupportedBlock"));
 var _UnsupportedInline = _interopRequireDefault(require("./UnsupportedInline"));
 var _BaseTheme = require("./BaseTheme");
-var _withOuterListeners = _interopRequireDefault(require("./with-outer-listeners"));
+var _withOuterListeners = _interopRequireWildcard(require("./with-outer-listeners"));
 var _WidthProvider = require("./WidthProvider");
 var _OverflowShadow = _interopRequireWildcard(require("./OverflowShadow"));
 var _shadowObserver = require("./OverflowShadow/shadowObserver");

package/dist/cjs/ui/with-outer-listeners.js

@@ -5,6 +5,7 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.PlainOutsideClickTargetRefContext = void 0;
 exports.default = withOuterListeners;
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
@@ -15,10 +16,14 @@ var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/ge
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireWildcard(require("react"));
 var _reactDom = _interopRequireDefault(require("react-dom"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function _createSuper(t) { var r = _isNativeReflectConstruct(); return function () { var e, o = (0, _getPrototypeOf2.default)(t); if (r) { var s = (0, _getPrototypeOf2.default)(this).constructor; e = Reflect.construct(o, arguments, s); } else e = o.apply(this, arguments); return (0, _possibleConstructorReturn2.default)(this, e); }; }
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
+// Use this context to pass in the reference of the element that should be considered as the outside click target
+// The outside click target is the element that should be clicked outside of to trigger the `handleClickOutside` event
+var PlainOutsideClickTargetRefContext = exports.PlainOutsideClickTargetRefContext = /*#__PURE__*/_react.default.createContext(function () {});
 function withOuterListeners(Component) {
   return /*#__PURE__*/function (_PureComponent) {
     (0, _inherits2.default)(WithOutsideClick, _PureComponent);
@@ -30,13 +35,14 @@ function withOuterListeners(Component) {
         args[_key] = arguments[_key];
       }
       _this = _super.call.apply(_super, [this].concat(args));
+      (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "outsideClickTargetRef", /*#__PURE__*/_react.default.createRef());
       (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleClick", function (evt) {
-        var domNode = _reactDom.default.findDOMNode((0, _assertThisInitialized2.default)(_this)); // eslint-disable-line react/no-find-dom-node
+        var _this$outsideClickTar;
+        var domNode = (0, _platformFeatureFlags.fg)('platform_editor_replace_finddomnode_in_common') ? (_this$outsideClickTar = _this.outsideClickTargetRef.current) === null || _this$outsideClickTar === void 0 ? void 0 : _this$outsideClickTar.deref() : _reactDom.default.findDOMNode((0, _assertThisInitialized2.default)(_this)); // eslint-disable-line react/no-find-dom-node
 
         if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
-          if (_this.props.handleClickOutside) {
-            _this.props.handleClickOutside(evt);
-          }
+          var _this$props$handleCli, _this$props;
+          (_this$props$handleCli = (_this$props = _this.props).handleClickOutside) === null || _this$props$handleCli === void 0 || _this$props$handleCli.call(_this$props, evt);
         }
       });
       (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleKeydown", function (evt) {
@@ -44,6 +50,9 @@ function withOuterListeners(Component) {
           _this.props.handleEscapeKeydown(evt);
         }
       });
+      (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "setOutsideClickTargetRef", function (el) {
+        _this.outsideClickTargetRef.current = el && new WeakRef(el);
+      });
       return _this;
     }
     (0, _createClass2.default)(WithOutsideClick, [{
@@ -69,7 +78,9 @@ function withOuterListeners(Component) {
     }, {
       key: "render",
       value: function render() {
-        return /*#__PURE__*/_react.default.createElement(Component, this.props);
+        return /*#__PURE__*/_react.default.createElement(PlainOutsideClickTargetRefContext.Provider, {
+          value: this.setOutsideClickTargetRef
+        }, /*#__PURE__*/_react.default.createElement(Component, this.props));
       }
     }]);
     return WithOutsideClick;

package/dist/cjs/ui-menu/ColorPickerButton/index.js

@@ -218,6 +218,7 @@ var ColorPickerButton = function ColorPickerButton(props) {
     content: title,
     position: "top"
   }, (0, _react2.jsx)(_standardButton.default, {
+    appearance: 'subtle',
     ref: buttonRef,
     "aria-label": title,
     "aria-expanded": props.isAriaExpanded ? isPopupOpen : undefined,

package/dist/cjs/ui-react/with-react-editor-view-outer-listeners.js

@@ -41,10 +41,11 @@ var WithOutsideClick = /*#__PURE__*/function (_PureComponent) {
     }
     _this = _super.call.apply(_super, [this].concat(args));
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleClick", function (evt) {
+      var _this$props$outsideCl;
       if (!_this.props.isActiveComponent || !_this.props.handleClickOutside) {
         return;
       }
-      var domNode = (0, _platformFeatureFlags.fg)('platform_editor_replace_finddomnode_in_common') ? _this.props.outsideClickTargetRef.current : _reactDom.default.findDOMNode((0, _assertThisInitialized2.default)(_this));
+      var domNode = (0, _platformFeatureFlags.fg)('platform_editor_replace_finddomnode_in_common') ? (_this$props$outsideCl = _this.props.outsideClickTargetRef.current) === null || _this$props$outsideCl === void 0 ? void 0 : _this$props$outsideCl.deref() : _reactDom.default.findDOMNode((0, _assertThisInitialized2.default)(_this));
       if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
         var _this$props$editorVie;
         _this.props.handleClickOutside(evt);
@@ -122,7 +123,7 @@ function withReactEditorViewOuterListeners(Component) {
       setActiveComponent = _useState2[1];
     var outsideClickTargetRef = (0, _react.useRef)(null);
     var setOutsideClickTargetRef = (0, _react.useCallback)(function (el) {
-      outsideClickTargetRef.current = el;
+      outsideClickTargetRef.current = el && new WeakRef(el);
     }, [outsideClickTargetRef]);
     (0, _react.useEffect)(function () {
       requestAnimationFrame(function () {

package/dist/es2019/media-inline/utils.js

@@ -1,8 +1,6 @@
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-
 /**
  * Enable media inline images feature based on
- * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages and platform FF platform.editor.media.inline-image.base-support
+ * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages
  *
  * The reason not using mediaOption as param is because MediaOption is from editor-plugin-media
  * we want to avoid circular deps
@@ -11,5 +9,5 @@ import { getBooleanFF } from '@atlaskit/platform-feature-flags';
  * @returns boolean
  */
 export const mediaInlineImagesEnabled = (allowMediaInline, allowMediaInlineImages) => {
-  return allowMediaInline && allowMediaInlineImages && getBooleanFF('platform.editor.media.inline-image.base-support');
+  return allowMediaInline && allowMediaInlineImages;
 };

package/dist/es2019/monitoring/error.js

@@ -1,7 +1,7 @@
 import { isFedRamp } from './environment';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "94.5.1";
+const packageVersion = "94.6.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/ui/DropList/index.js

@@ -13,7 +13,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "94.5.1";
+const packageVersion = "94.6.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/es2019/ui/index.js

@@ -7,7 +7,7 @@ export { default as Popup, findOverflowScrollParent } from './Popup';
 export { default as UnsupportedBlock } from './UnsupportedBlock';
 export { default as UnsupportedInline } from './UnsupportedInline';
 export { BaseTheme, mapBreakpointToLayoutMaxWidth } from './BaseTheme';
-export { default as withOuterListeners } from './with-outer-listeners';
+export { default as withOuterListeners, PlainOutsideClickTargetRefContext } from './with-outer-listeners';
 export { WidthContext, WidthConsumer, WidthProvider, createWidthContext, getBreakpoint } from './WidthProvider';
 export { default as overflowShadow, shadowClassNames } from './OverflowShadow';
 export { shadowObserverClassNames, ShadowObserver } from './OverflowShadow/shadowObserver';

package/dist/es2019/ui/with-outer-listeners.js

@@ -1,17 +1,22 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import React, { PureComponent } from 'react';
 import ReactDOM from 'react-dom';
+import { fg } from '@atlaskit/platform-feature-flags';
+// Use this context to pass in the reference of the element that should be considered as the outside click target
+// The outside click target is the element that should be clicked outside of to trigger the `handleClickOutside` event
+export const PlainOutsideClickTargetRefContext = /*#__PURE__*/React.createContext(() => {});
 export default function withOuterListeners(Component) {
   return class WithOutsideClick extends PureComponent {
     constructor(...args) {
       super(...args);
+      _defineProperty(this, "outsideClickTargetRef", /*#__PURE__*/React.createRef());
       _defineProperty(this, "handleClick", evt => {
-        const domNode = ReactDOM.findDOMNode(this); // eslint-disable-line react/no-find-dom-node
+        var _this$outsideClickTar;
+        const domNode = fg('platform_editor_replace_finddomnode_in_common') ? (_this$outsideClickTar = this.outsideClickTargetRef.current) === null || _this$outsideClickTar === void 0 ? void 0 : _this$outsideClickTar.deref() : ReactDOM.findDOMNode(this); // eslint-disable-line react/no-find-dom-node
 
         if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
-          if (this.props.handleClickOutside) {
-            this.props.handleClickOutside(evt);
-          }
+          var _this$props$handleCli, _this$props;
+          (_this$props$handleCli = (_this$props = this.props).handleClickOutside) === null || _this$props$handleCli === void 0 ? void 0 : _this$props$handleCli.call(_this$props, evt);
         }
       });
       _defineProperty(this, "handleKeydown", evt => {
@@ -19,6 +24,9 @@ export default function withOuterListeners(Component) {
           this.props.handleEscapeKeydown(evt);
         }
       });
+      _defineProperty(this, "setOutsideClickTargetRef", el => {
+        this.outsideClickTargetRef.current = el && new WeakRef(el);
+      });
     }
     componentDidMount() {
       if (this.props.handleClickOutside) {
@@ -37,7 +45,9 @@ export default function withOuterListeners(Component) {
       }
     }
     render() {
-      return /*#__PURE__*/React.createElement(Component, this.props);
+      return /*#__PURE__*/React.createElement(PlainOutsideClickTargetRefContext.Provider, {
+        value: this.setOutsideClickTargetRef
+      }, /*#__PURE__*/React.createElement(Component, this.props));
     }
   };
 }

package/dist/es2019/ui-menu/ColorPickerButton/index.js

@@ -198,6 +198,7 @@ const ColorPickerButton = props => {
     content: title,
     position: "top"
   }, jsx(Button, {
+    appearance: 'subtle',
     ref: buttonRef,
     "aria-label": title,
     "aria-expanded": props.isAriaExpanded ? isPopupOpen : undefined,

package/dist/es2019/ui-react/with-react-editor-view-outer-listeners.js

@@ -13,10 +13,11 @@ class WithOutsideClick extends PureComponent {
   constructor(...args) {
     super(...args);
     _defineProperty(this, "handleClick", evt => {
+      var _this$props$outsideCl;
       if (!this.props.isActiveComponent || !this.props.handleClickOutside) {
         return;
       }
-      const domNode = fg('platform_editor_replace_finddomnode_in_common') ? this.props.outsideClickTargetRef.current : ReactDOM.findDOMNode(this);
+      const domNode = fg('platform_editor_replace_finddomnode_in_common') ? (_this$props$outsideCl = this.props.outsideClickTargetRef.current) === null || _this$props$outsideCl === void 0 ? void 0 : _this$props$outsideCl.deref() : ReactDOM.findDOMNode(this);
       if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
         var _this$props$editorVie;
         this.props.handleClickOutside(evt);
@@ -83,7 +84,7 @@ export default function withReactEditorViewOuterListeners(Component) {
     const [isActiveComponent, setActiveComponent] = useState(false);
     const outsideClickTargetRef = useRef(null);
     const setOutsideClickTargetRef = useCallback(el => {
-      outsideClickTargetRef.current = el;
+      outsideClickTargetRef.current = el && new WeakRef(el);
     }, [outsideClickTargetRef]);
     useEffect(() => {
       requestAnimationFrame(() => {

package/dist/esm/media-inline/utils.js

@@ -1,8 +1,6 @@
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-
 /**
  * Enable media inline images feature based on
- * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages and platform FF platform.editor.media.inline-image.base-support
+ * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages
  *
  * The reason not using mediaOption as param is because MediaOption is from editor-plugin-media
  * we want to avoid circular deps
@@ -11,5 +9,5 @@ import { getBooleanFF } from '@atlaskit/platform-feature-flags';
  * @returns boolean
  */
 export var mediaInlineImagesEnabled = function mediaInlineImagesEnabled(allowMediaInline, allowMediaInlineImages) {
-  return allowMediaInline && allowMediaInlineImages && getBooleanFF('platform.editor.media.inline-image.base-support');
+  return allowMediaInline && allowMediaInlineImages;
 };

package/dist/esm/monitoring/error.js

@@ -7,7 +7,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import { isFedRamp } from './environment';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "94.5.1";
+var packageVersion = "94.6.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "94.5.1";
+var packageVersion = "94.6.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/esm/ui/index.js

@@ -7,7 +7,7 @@ export { default as Popup, findOverflowScrollParent } from './Popup';
 export { default as UnsupportedBlock } from './UnsupportedBlock';
 export { default as UnsupportedInline } from './UnsupportedInline';
 export { BaseTheme, mapBreakpointToLayoutMaxWidth } from './BaseTheme';
-export { default as withOuterListeners } from './with-outer-listeners';
+export { default as withOuterListeners, PlainOutsideClickTargetRefContext } from './with-outer-listeners';
 export { WidthContext, WidthConsumer, WidthProvider, createWidthContext, getBreakpoint } from './WidthProvider';
 export { default as overflowShadow, shadowClassNames } from './OverflowShadow';
 export { shadowObserverClassNames, ShadowObserver } from './OverflowShadow/shadowObserver';

package/dist/esm/ui/with-outer-listeners.js

@@ -9,6 +9,10 @@ function _createSuper(t) { var r = _isNativeReflectConstruct(); return function
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
 import React, { PureComponent } from 'react';
 import ReactDOM from 'react-dom';
+import { fg } from '@atlaskit/platform-feature-flags';
+// Use this context to pass in the reference of the element that should be considered as the outside click target
+// The outside click target is the element that should be clicked outside of to trigger the `handleClickOutside` event
+export var PlainOutsideClickTargetRefContext = /*#__PURE__*/React.createContext(function () {});
 export default function withOuterListeners(Component) {
   return /*#__PURE__*/function (_PureComponent) {
     _inherits(WithOutsideClick, _PureComponent);
@@ -20,13 +24,14 @@ export default function withOuterListeners(Component) {
         args[_key] = arguments[_key];
       }
       _this = _super.call.apply(_super, [this].concat(args));
+      _defineProperty(_assertThisInitialized(_this), "outsideClickTargetRef", /*#__PURE__*/React.createRef());
       _defineProperty(_assertThisInitialized(_this), "handleClick", function (evt) {
-        var domNode = ReactDOM.findDOMNode(_assertThisInitialized(_this)); // eslint-disable-line react/no-find-dom-node
+        var _this$outsideClickTar;
+        var domNode = fg('platform_editor_replace_finddomnode_in_common') ? (_this$outsideClickTar = _this.outsideClickTargetRef.current) === null || _this$outsideClickTar === void 0 ? void 0 : _this$outsideClickTar.deref() : ReactDOM.findDOMNode(_assertThisInitialized(_this)); // eslint-disable-line react/no-find-dom-node
 
         if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
-          if (_this.props.handleClickOutside) {
-            _this.props.handleClickOutside(evt);
-          }
+          var _this$props$handleCli, _this$props;
+          (_this$props$handleCli = (_this$props = _this.props).handleClickOutside) === null || _this$props$handleCli === void 0 || _this$props$handleCli.call(_this$props, evt);
         }
       });
       _defineProperty(_assertThisInitialized(_this), "handleKeydown", function (evt) {
@@ -34,6 +39,9 @@ export default function withOuterListeners(Component) {
           _this.props.handleEscapeKeydown(evt);
         }
       });
+      _defineProperty(_assertThisInitialized(_this), "setOutsideClickTargetRef", function (el) {
+        _this.outsideClickTargetRef.current = el && new WeakRef(el);
+      });
       return _this;
     }
     _createClass(WithOutsideClick, [{
@@ -59,7 +67,9 @@ export default function withOuterListeners(Component) {
     }, {
       key: "render",
       value: function render() {
-        return /*#__PURE__*/React.createElement(Component, this.props);
+        return /*#__PURE__*/React.createElement(PlainOutsideClickTargetRefContext.Provider, {
+          value: this.setOutsideClickTargetRef
+        }, /*#__PURE__*/React.createElement(Component, this.props));
       }
     }]);
     return WithOutsideClick;

package/dist/esm/ui-menu/ColorPickerButton/index.js

@@ -211,6 +211,7 @@ var ColorPickerButton = function ColorPickerButton(props) {
     content: title,
     position: "top"
   }, jsx(Button, {
+    appearance: 'subtle',
     ref: buttonRef,
     "aria-label": title,
     "aria-expanded": props.isAriaExpanded ? isPopupOpen : undefined,

package/dist/esm/ui-react/with-react-editor-view-outer-listeners.js

@@ -30,10 +30,11 @@ var WithOutsideClick = /*#__PURE__*/function (_PureComponent) {
     }
     _this = _super.call.apply(_super, [this].concat(args));
     _defineProperty(_assertThisInitialized(_this), "handleClick", function (evt) {
+      var _this$props$outsideCl;
       if (!_this.props.isActiveComponent || !_this.props.handleClickOutside) {
         return;
       }
-      var domNode = fg('platform_editor_replace_finddomnode_in_common') ? _this.props.outsideClickTargetRef.current : ReactDOM.findDOMNode(_assertThisInitialized(_this));
+      var domNode = fg('platform_editor_replace_finddomnode_in_common') ? (_this$props$outsideCl = _this.props.outsideClickTargetRef.current) === null || _this$props$outsideCl === void 0 ? void 0 : _this$props$outsideCl.deref() : ReactDOM.findDOMNode(_assertThisInitialized(_this));
       if (!domNode || evt.target instanceof Node && !domNode.contains(evt.target)) {
         var _this$props$editorVie;
         _this.props.handleClickOutside(evt);
@@ -111,7 +112,7 @@ export default function withReactEditorViewOuterListeners(Component) {
       setActiveComponent = _useState2[1];
     var outsideClickTargetRef = useRef(null);
     var setOutsideClickTargetRef = useCallback(function (el) {
-      outsideClickTargetRef.current = el;
+      outsideClickTargetRef.current = el && new WeakRef(el);
     }, [outsideClickTargetRef]);
     useEffect(function () {
       requestAnimationFrame(function () {

package/dist/types/media-inline/utils.d.ts

@@ -1,6 +1,6 @@
 /**
  * Enable media inline images feature based on
- * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages and platform FF platform.editor.media.inline-image.base-support
+ * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages
  *
  * The reason not using mediaOption as param is because MediaOption is from editor-plugin-media
  * we want to avoid circular deps

package/dist/types/ui/index.d.ts

@@ -10,7 +10,7 @@ export type { Position as PopupPosition, Props as PopupProps } from './Popup';
 export { default as UnsupportedBlock } from './UnsupportedBlock';
 export { default as UnsupportedInline } from './UnsupportedInline';
 export { BaseTheme, mapBreakpointToLayoutMaxWidth } from './BaseTheme';
-export { default as withOuterListeners } from './with-outer-listeners';
+export { default as withOuterListeners, PlainOutsideClickTargetRefContext, } from './with-outer-listeners';
 export type { WithOutsideClickProps } from './with-outer-listeners';
 export type { CardEventClickHandler, CardSurroundings, EventHandlers, LinkEventClickHandler, MentionEventHandler, MentionEventHandlers, SmartCardEventClickHandler, } from './EventHandlers';
 export { WidthContext, WidthConsumer, WidthProvider, createWidthContext, getBreakpoint, } from './WidthProvider';

package/dist/types/ui/with-outer-listeners.d.ts

@@ -5,5 +5,6 @@ export interface WithOutsideClickProps {
     handleClickOutside?: SimpleEventHandler<MouseEvent>;
     handleEscapeKeydown?: SimpleEventHandler<KeyboardEvent>;
 }
+export declare const PlainOutsideClickTargetRefContext: React.Context<(el: HTMLElement | null) => void>;
 export default function withOuterListeners<P>(Component: React.ComponentType<React.PropsWithChildren<P>>): ComponentClass<P & WithOutsideClickProps>;
 export {};

package/dist/types-ts4.5/media-inline/utils.d.ts

@@ -1,6 +1,6 @@
 /**
  * Enable media inline images feature based on
- * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages and platform FF platform.editor.media.inline-image.base-support
+ * mediaOptions.featureFlags.mediaInline, mediaOptions.allowMediaInlineImages
  *
  * The reason not using mediaOption as param is because MediaOption is from editor-plugin-media
  * we want to avoid circular deps

package/dist/types-ts4.5/ui/index.d.ts

@@ -10,7 +10,7 @@ export type { Position as PopupPosition, Props as PopupProps } from './Popup';
 export { default as UnsupportedBlock } from './UnsupportedBlock';
 export { default as UnsupportedInline } from './UnsupportedInline';
 export { BaseTheme, mapBreakpointToLayoutMaxWidth } from './BaseTheme';
-export { default as withOuterListeners } from './with-outer-listeners';
+export { default as withOuterListeners, PlainOutsideClickTargetRefContext, } from './with-outer-listeners';
 export type { WithOutsideClickProps } from './with-outer-listeners';
 export type { CardEventClickHandler, CardSurroundings, EventHandlers, LinkEventClickHandler, MentionEventHandler, MentionEventHandlers, SmartCardEventClickHandler, } from './EventHandlers';
 export { WidthContext, WidthConsumer, WidthProvider, createWidthContext, getBreakpoint, } from './WidthProvider';

package/dist/types-ts4.5/ui/with-outer-listeners.d.ts

@@ -5,5 +5,6 @@ export interface WithOutsideClickProps {
     handleClickOutside?: SimpleEventHandler<MouseEvent>;
     handleEscapeKeydown?: SimpleEventHandler<KeyboardEvent>;
 }
+export declare const PlainOutsideClickTargetRefContext: React.Context<(el: HTMLElement | null) => void>;
 export default function withOuterListeners<P>(Component: React.ComponentType<React.PropsWithChildren<P>>): ComponentClass<P & WithOutsideClickProps>;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "94.5.1",
+	"version": "94.6.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -231,9 +231,6 @@
 		"platform_editor_breakout_use_css": {
 			"type": "boolean"
 		},
-		"platform.editor.media.inline-image.base-support": {
-			"type": "boolean"
-		},
 		"platform.linking-platform.datasource-assets_objects": {
 			"type": "boolean"
 		},