@atlaskit/editor-common 76.41.0 → 77.0.0

package/CHANGELOG.md

@@ -1,5 +1,85 @@
 # @atlaskit/editor-common
 
+## 77.0.0
+
+### Major Changes
+
+- [#67576](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/67576) [`ebaeefd6ab17`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/ebaeefd6ab17) - [ED-21835] Change EditorAPI type to always union with undefined
+
+  # Breaking change
+
+  ## What
+
+  EditorAPI nows set all plugins as possible `undefined` as default
+
+  ## Why
+
+  That is too guarantee safe-null on runtime, since the EditorBuilderPreset does not guarantee the plugin required is on bundle anymore.
+
+  ## How
+
+  If you have anycode doing usign the editorAPI like this:
+
+  ```
+  editorAPI.core.commands
+  ```
+
+  You will need to safe-null it like this:
+
+  ```
+  editorAPI.core?.commands
+  ```
+
+- [#67576](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/67576) [`0c7a7fae2055`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0c7a7fae2055) - [ED-21835] EditorPresetBuilder.maybeAdd changed to keep the typesafety
+
+  warn This Changeset includes a major change and we STRONGLY recommend adding more information to the changeset:
+  warn WHAT the breaking change is
+  warn WHY the change was made
+  warn HOW a consumer should update their code
+
+  # WHAT the breaking change is
+
+  The Editor Preset creation process. When you need to add a plugin based on some condition, you used to do this:
+
+  ```
+  // BEFORE
+  const preset = new EditorPresetBuilder()
+    .add(pluginOne)
+    .maybeAdd(tablePlugin, (plugin, builder) => {
+
+      if (featureFlag.addTablePlugin) {
+          return builder.add(tablePlugin)
+      }
+      return builder;
+    });
+
+  ```
+
+  # WHY the change was made
+
+  The `maybeAdd` was breaking the whole typesystem always returning a `EditorPresetBuilder<any, any>`.
+
+  # HOW a consumer should update their code
+
+  You need to do a similar change like this below:
+
+  ```
+  // AFTER
+
+  const preset = new EditorPresetBuilder()
+    .add(pluginOne)
+    .maybeAdd(tablePlugin, featureFlag.addTablePlugin);
+
+  ```
+
+  Now, the `maybeAdd` type is `maybeAdd: (plugin, boolean) => EditorPresetBuilder`
+
+## 76.41.1
+
+### Patch Changes
+
+- [#68067](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/68067) [`5b13ed605a1b`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/5b13ed605a1b) - ED-21828 -fix layouts for wide inline images
+
 ## 76.41.0
 
 ### Minor Changes

package/dist/cjs/media-inline/styles.js

@@ -35,7 +35,8 @@ var wrapperStyle = exports.wrapperStyle = (0, _react.css)({
   verticalAlign: 'middle',
   overflow: 'hidden',
   borderRadius: "var(--ds-border-radius, 3px)",
-  aspectRatio: "var(".concat(INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, ", ").concat(_constants.DEFAULT_INLINE_IMAGE_ASPECT_RATIO, ")")
+  aspectRatio: "var(".concat(INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, ", ").concat(_constants.DEFAULT_INLINE_IMAGE_ASPECT_RATIO, ")"),
+  maxWidth: '100%'
 });
 var selectedStyle = exports.selectedStyle = (0, _react.css)({
   cursor: 'pointer',

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "76.41.0";
+var packageVersion = "77.0.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/preset/builder.js

@@ -33,28 +33,24 @@ var EditorPresetBuilder = exports.EditorPresetBuilder = /*#__PURE__*/function ()
        */
       nextOrTuple].concat((0, _toConsumableArray2.default)(this.data)));
     }
-
-    // hasPlugin<Plugin extends NextEditorPlugin<any, any>>(
-    //   pluginToAdd: Plugin,
-    // ): this is TryCastEditorPresetBuilderByCheckingPlugins<this, Plugin> {
-    //   const hasPluginQueryExists = this.data.find((pluginEntry) => {
-    //     const pluginFunction: NextEditorPlugin<any, any> = !Array.isArray(
-    //       pluginEntry,
-    //     )
-    //       ? pluginEntry
-    //       : pluginEntry[0];
-
-    //     return pluginFunction === pluginToAdd;
-    //   });
-
-    //   return Boolean(hasPluginQueryExists);
-    // }
   }, {
     key: "maybeAdd",
-    value: function maybeAdd(pluginToAdd, add) {
-      return add(pluginToAdd,
-      //  @ts-ignore
-      this);
+    value: function maybeAdd(pluginToAdd, shouldAdd) {
+      var pluginOrBuilder = typeof shouldAdd === 'function' ?
+      // @ts-expect-error Argument of type 'SafePresetCheck<ToAddPlugin, StackPlugins>' is not assignable to parameter of type 'ToAddPlugin'.
+      shouldAdd(pluginToAdd, this) : shouldAdd;
+      if (pluginOrBuilder instanceof EditorPresetBuilder) {
+        return pluginOrBuilder;
+      }
+      var nextPluginStack = [
+      /**
+       * re-cast this to NewPlugin as we've done all the type
+       * safety, dependency checking, narrowing, during
+       * `SafePresetCheck & VerifyPluginDependencies`
+       */
+      pluginOrBuilder ? pluginToAdd : undefined].concat((0, _toConsumableArray2.default)(this.data));
+      var nextEditorPresetBuilder = (0, _construct2.default)(EditorPresetBuilder, (0, _toConsumableArray2.default)(nextPluginStack));
+      return nextEditorPresetBuilder;
     }
   }, {
     key: "has",
@@ -83,7 +79,7 @@ var EditorPresetBuilder = exports.EditorPresetBuilder = /*#__PURE__*/function ()
     key: "verifyDuplicatedPlugins",
     value: function verifyDuplicatedPlugins() {
       var cache = new Set();
-      this.data.forEach(function (pluginEntry) {
+      this.data.filter(Boolean).forEach(function (pluginEntry) {
         var _ref2 = Array.isArray(pluginEntry) ? pluginEntry : [pluginEntry, undefined],
           _ref3 = (0, _slicedToArray2.default)(_ref2, 2),
           pluginFn = _ref3[0],
@@ -104,7 +100,7 @@ var EditorPresetBuilder = exports.EditorPresetBuilder = /*#__PURE__*/function ()
       this.verifyDuplicatedPlugins();
       var seen = new Set();
       var pluginsDataCopy = this.data.slice();
-      var plugins = pluginsDataCopy.reverse().map(function (entry) {
+      var plugins = pluginsDataCopy.reverse().filter(Boolean).map(function (entry) {
         var _this$safeEntry = _this.safeEntry(entry),
           _this$safeEntry2 = (0, _slicedToArray2.default)(_this$safeEntry, 2),
           fn = _this$safeEntry2[0],
@@ -143,43 +139,6 @@ var EditorPresetBuilder = exports.EditorPresetBuilder = /*#__PURE__*/function ()
       }
       return plugins;
     }
-
-    // TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-    // import type {
-    //   ExtractPluginDependencies,
-    // } from '../types/next-editor-plugin';
-    // type TryCastEditorPresetBuilderByCheckingDependencies<MaybeEditorPresetBuilder, Plugin> =
-    //   MaybeEditorPresetBuilder extends EditorPresetBuilder<any, infer StackPlugins>
-    //     ? Plugin extends NextEditorPlugin<any, any>
-    //       ? ExtractPluginDependencies<Plugin>[number] extends StackPlugins[number]
-    //         ? MaybeEditorPresetBuilder
-    //         : never
-    //       : never
-    //     : never;
-    //  Because how our plugins are added in the preset, we can't use the type safe system
-    //  in the EditorPresetBuilder.
-    //  TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-    // maybeAdd<
-    //   MaybePlugin extends NextEditorPlugin<any, any>,
-    //   MaybePluginNames extends string[],
-    //   MaybeStackPlugins extends AllEditorPresetPluginTypes[],
-    //   MaybeEditorPresetBuilder extends EditorPresetBuilder<
-    //     MaybePluginNames,
-    //     MaybeStackPlugins
-    //   >,
-    // >(
-    //   pluginToAdd: MaybePlugin,
-    //    add: (
-    //      pluginToAdd: MaybePlugin,
-    //      maybeEditorPresetBuilder: TryCastEditorPresetBuilderByCheckingDependencies<this, MaybePlugin>,
-    //    ) => MaybeEditorPresetBuilder,
-    // ): MaybeEditorPresetBuilder | this {
-    //   return add(
-    //     pluginToAdd,
-    //     //  @ts-ignore
-    //     this as any,
-    //   );
-    // }
   }]);
   return EditorPresetBuilder;
 }();

package/dist/cjs/ui/DropList/index.js

@@ -22,7 +22,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "76.41.0";
+var packageVersion = "77.0.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/es2019/media-inline/styles.js

@@ -63,7 +63,8 @@ export const wrapperStyle = css({
   verticalAlign: 'middle',
   overflow: 'hidden',
   borderRadius: `${"var(--ds-border-radius, 3px)"}`,
-  aspectRatio: `var(${INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY}, ${DEFAULT_INLINE_IMAGE_ASPECT_RATIO})`
+  aspectRatio: `var(${INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY}, ${DEFAULT_INLINE_IMAGE_ASPECT_RATIO})`,
+  maxWidth: '100%'
 });
 export const selectedStyle = css({
   cursor: 'pointer',

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "76.41.0";
+const packageVersion = "77.0.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/preset/builder.js

@@ -13,27 +13,22 @@ export class EditorPresetBuilder {
      */
     nextOrTuple, ...this.data);
   }
-
-  // hasPlugin<Plugin extends NextEditorPlugin<any, any>>(
-  //   pluginToAdd: Plugin,
-  // ): this is TryCastEditorPresetBuilderByCheckingPlugins<this, Plugin> {
-  //   const hasPluginQueryExists = this.data.find((pluginEntry) => {
-  //     const pluginFunction: NextEditorPlugin<any, any> = !Array.isArray(
-  //       pluginEntry,
-  //     )
-  //       ? pluginEntry
-  //       : pluginEntry[0];
-
-  //     return pluginFunction === pluginToAdd;
-  //   });
-
-  //   return Boolean(hasPluginQueryExists);
-  // }
-
-  maybeAdd(pluginToAdd, add) {
-    return add(pluginToAdd,
-    //  @ts-ignore
-    this);
+  maybeAdd(pluginToAdd, shouldAdd) {
+    const pluginOrBuilder = typeof shouldAdd === 'function' ?
+    // @ts-expect-error Argument of type 'SafePresetCheck<ToAddPlugin, StackPlugins>' is not assignable to parameter of type 'ToAddPlugin'.
+    shouldAdd(pluginToAdd, this) : shouldAdd;
+    if (pluginOrBuilder instanceof EditorPresetBuilder) {
+      return pluginOrBuilder;
+    }
+    const nextPluginStack = [
+    /**
+     * re-cast this to NewPlugin as we've done all the type
+     * safety, dependency checking, narrowing, during
+     * `SafePresetCheck & VerifyPluginDependencies`
+     */
+    pluginOrBuilder ? pluginToAdd : undefined, ...this.data];
+    const nextEditorPresetBuilder = new EditorPresetBuilder(...nextPluginStack);
+    return nextEditorPresetBuilder;
   }
   has(plugin) {
     return this.data.some(pluginPreset => {
@@ -56,7 +51,7 @@ export class EditorPresetBuilder {
   }
   verifyDuplicatedPlugins() {
     const cache = new Set();
-    this.data.forEach(pluginEntry => {
+    this.data.filter(Boolean).forEach(pluginEntry => {
       const [pluginFn, _] = Array.isArray(pluginEntry) ? pluginEntry : [pluginEntry, undefined];
       if (cache.has(pluginFn)) {
         throw new Error(`${pluginFn} is already included!`);
@@ -72,7 +67,7 @@ export class EditorPresetBuilder {
     this.verifyDuplicatedPlugins();
     const seen = new Set();
     const pluginsDataCopy = this.data.slice();
-    const plugins = pluginsDataCopy.reverse().map(entry => {
+    const plugins = pluginsDataCopy.reverse().filter(Boolean).map(entry => {
       const [fn, config] = this.safeEntry(entry);
       if (seen.has(fn)) {
         return null;
@@ -104,41 +99,4 @@ export class EditorPresetBuilder {
     }
     return plugins;
   }
-
-  // TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-  // import type {
-  //   ExtractPluginDependencies,
-  // } from '../types/next-editor-plugin';
-  // type TryCastEditorPresetBuilderByCheckingDependencies<MaybeEditorPresetBuilder, Plugin> =
-  //   MaybeEditorPresetBuilder extends EditorPresetBuilder<any, infer StackPlugins>
-  //     ? Plugin extends NextEditorPlugin<any, any>
-  //       ? ExtractPluginDependencies<Plugin>[number] extends StackPlugins[number]
-  //         ? MaybeEditorPresetBuilder
-  //         : never
-  //       : never
-  //     : never;
-  //  Because how our plugins are added in the preset, we can't use the type safe system
-  //  in the EditorPresetBuilder.
-  //  TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-  // maybeAdd<
-  //   MaybePlugin extends NextEditorPlugin<any, any>,
-  //   MaybePluginNames extends string[],
-  //   MaybeStackPlugins extends AllEditorPresetPluginTypes[],
-  //   MaybeEditorPresetBuilder extends EditorPresetBuilder<
-  //     MaybePluginNames,
-  //     MaybeStackPlugins
-  //   >,
-  // >(
-  //   pluginToAdd: MaybePlugin,
-  //    add: (
-  //      pluginToAdd: MaybePlugin,
-  //      maybeEditorPresetBuilder: TryCastEditorPresetBuilderByCheckingDependencies<this, MaybePlugin>,
-  //    ) => MaybeEditorPresetBuilder,
-  // ): MaybeEditorPresetBuilder | this {
-  //   return add(
-  //     pluginToAdd,
-  //     //  @ts-ignore
-  //     this as any,
-  //   );
-  // }
 }

package/dist/es2019/ui/DropList/index.js

@@ -7,7 +7,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
 import { N0, N50A, N60A, N900 } from '@atlaskit/theme/colors';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "76.41.0";
+const packageVersion = "77.0.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/esm/media-inline/styles.js

@@ -28,7 +28,8 @@ export var wrapperStyle = css({
   verticalAlign: 'middle',
   overflow: 'hidden',
   borderRadius: "var(--ds-border-radius, 3px)",
-  aspectRatio: "var(".concat(INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, ", ").concat(DEFAULT_INLINE_IMAGE_ASPECT_RATIO, ")")
+  aspectRatio: "var(".concat(INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, ", ").concat(DEFAULT_INLINE_IMAGE_ASPECT_RATIO, ")"),
+  maxWidth: '100%'
 });
 export var selectedStyle = css({
   cursor: 'pointer',

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "76.41.0";
+var packageVersion = "77.0.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/preset/builder.js

@@ -26,28 +26,24 @@ export var EditorPresetBuilder = /*#__PURE__*/function () {
        */
       nextOrTuple].concat(_toConsumableArray(this.data)));
     }
-
-    // hasPlugin<Plugin extends NextEditorPlugin<any, any>>(
-    //   pluginToAdd: Plugin,
-    // ): this is TryCastEditorPresetBuilderByCheckingPlugins<this, Plugin> {
-    //   const hasPluginQueryExists = this.data.find((pluginEntry) => {
-    //     const pluginFunction: NextEditorPlugin<any, any> = !Array.isArray(
-    //       pluginEntry,
-    //     )
-    //       ? pluginEntry
-    //       : pluginEntry[0];
-
-    //     return pluginFunction === pluginToAdd;
-    //   });
-
-    //   return Boolean(hasPluginQueryExists);
-    // }
   }, {
     key: "maybeAdd",
-    value: function maybeAdd(pluginToAdd, add) {
-      return add(pluginToAdd,
-      //  @ts-ignore
-      this);
+    value: function maybeAdd(pluginToAdd, shouldAdd) {
+      var pluginOrBuilder = typeof shouldAdd === 'function' ?
+      // @ts-expect-error Argument of type 'SafePresetCheck<ToAddPlugin, StackPlugins>' is not assignable to parameter of type 'ToAddPlugin'.
+      shouldAdd(pluginToAdd, this) : shouldAdd;
+      if (pluginOrBuilder instanceof EditorPresetBuilder) {
+        return pluginOrBuilder;
+      }
+      var nextPluginStack = [
+      /**
+       * re-cast this to NewPlugin as we've done all the type
+       * safety, dependency checking, narrowing, during
+       * `SafePresetCheck & VerifyPluginDependencies`
+       */
+      pluginOrBuilder ? pluginToAdd : undefined].concat(_toConsumableArray(this.data));
+      var nextEditorPresetBuilder = _construct(EditorPresetBuilder, _toConsumableArray(nextPluginStack));
+      return nextEditorPresetBuilder;
     }
   }, {
     key: "has",
@@ -76,7 +72,7 @@ export var EditorPresetBuilder = /*#__PURE__*/function () {
     key: "verifyDuplicatedPlugins",
     value: function verifyDuplicatedPlugins() {
       var cache = new Set();
-      this.data.forEach(function (pluginEntry) {
+      this.data.filter(Boolean).forEach(function (pluginEntry) {
         var _ref2 = Array.isArray(pluginEntry) ? pluginEntry : [pluginEntry, undefined],
           _ref3 = _slicedToArray(_ref2, 2),
           pluginFn = _ref3[0],
@@ -97,7 +93,7 @@ export var EditorPresetBuilder = /*#__PURE__*/function () {
       this.verifyDuplicatedPlugins();
       var seen = new Set();
       var pluginsDataCopy = this.data.slice();
-      var plugins = pluginsDataCopy.reverse().map(function (entry) {
+      var plugins = pluginsDataCopy.reverse().filter(Boolean).map(function (entry) {
         var _this$safeEntry = _this.safeEntry(entry),
           _this$safeEntry2 = _slicedToArray(_this$safeEntry, 2),
           fn = _this$safeEntry2[0],
@@ -136,43 +132,6 @@ export var EditorPresetBuilder = /*#__PURE__*/function () {
       }
       return plugins;
     }
-
-    // TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-    // import type {
-    //   ExtractPluginDependencies,
-    // } from '../types/next-editor-plugin';
-    // type TryCastEditorPresetBuilderByCheckingDependencies<MaybeEditorPresetBuilder, Plugin> =
-    //   MaybeEditorPresetBuilder extends EditorPresetBuilder<any, infer StackPlugins>
-    //     ? Plugin extends NextEditorPlugin<any, any>
-    //       ? ExtractPluginDependencies<Plugin>[number] extends StackPlugins[number]
-    //         ? MaybeEditorPresetBuilder
-    //         : never
-    //       : never
-    //     : never;
-    //  Because how our plugins are added in the preset, we can't use the type safe system
-    //  in the EditorPresetBuilder.
-    //  TODO: ED-17023 - Bring back type safety to the EditorPresetBuilder.add preset
-    // maybeAdd<
-    //   MaybePlugin extends NextEditorPlugin<any, any>,
-    //   MaybePluginNames extends string[],
-    //   MaybeStackPlugins extends AllEditorPresetPluginTypes[],
-    //   MaybeEditorPresetBuilder extends EditorPresetBuilder<
-    //     MaybePluginNames,
-    //     MaybeStackPlugins
-    //   >,
-    // >(
-    //   pluginToAdd: MaybePlugin,
-    //    add: (
-    //      pluginToAdd: MaybePlugin,
-    //      maybeEditorPresetBuilder: TryCastEditorPresetBuilderByCheckingDependencies<this, MaybePlugin>,
-    //    ) => MaybeEditorPresetBuilder,
-    // ): MaybeEditorPresetBuilder | this {
-    //   return add(
-    //     pluginToAdd,
-    //     //  @ts-ignore
-    //     this as any,
-    //   );
-    // }
   }]);
   return EditorPresetBuilder;
 }();

package/dist/esm/ui/DropList/index.js

@@ -17,7 +17,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
 import { N0, N50A, N60A, N900 } from '@atlaskit/theme/colors';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "76.41.0";
+var packageVersion = "77.0.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/types/preset/builder.d.ts

@@ -1,4 +1,4 @@
-import type { AllEditorPresetPluginTypes, ExtractPluginNameFromAllBuilderPlugins, NextEditorPlugin, SafePresetCheck } from '../types';
+import type { AllEditorPresetPluginTypes, ExtractPluginNameFromAllBuilderPlugins, MaybePlugin, MaybePluginName, PresetPlugin, SafePresetCheck } from '../types';
 import type { EditorPlugin } from '../types/editor-plugin';
 import type { EditorPluginInjectionAPI } from './plugin-injection-api';
 interface ProcessProps {
@@ -9,17 +9,25 @@ interface BuildProps extends ProcessProps {
     excludePlugins?: Set<string>;
     pluginInjectionAPI?: EditorPluginInjectionAPI;
 }
-export declare class EditorPresetBuilder<PluginNames extends string[] = [], StackPlugins extends AllEditorPresetPluginTypes[] = []> {
+type OldAndDeprecatedAddFunction<T> = (pluginToAdd: T, builder: EditorPresetBuilder<any, any>) => EditorPresetBuilder<any, any>;
+type AllPluginNames = string | MaybePluginName<string>;
+export declare class EditorPresetBuilder<PluginNames extends AllPluginNames[] = [], StackPlugins extends AllEditorPresetPluginTypes[] = []> {
     private readonly data;
     constructor(...more: [...StackPlugins]);
-    add<NewPlugin extends AllEditorPresetPluginTypes>(nextOrTuple: SafePresetCheck<NewPlugin, StackPlugins>): EditorPresetBuilder<[
-        ...PluginNames,
-        ExtractPluginNameFromAllBuilderPlugins<NewPlugin>
+    add<NewPlugin extends PresetPlugin>(nextOrTuple: SafePresetCheck<NewPlugin, StackPlugins>): EditorPresetBuilder<[
+        ExtractPluginNameFromAllBuilderPlugins<NewPlugin>,
+        ...PluginNames
     ], [
         ...[NewPlugin],
         ...StackPlugins
     ]>;
-    maybeAdd<MaybePlugin extends NextEditorPlugin<any, any>, MaybePluginNames extends string[], MaybeStackPlugins extends AllEditorPresetPluginTypes[], MaybeEditorPresetBuilder extends EditorPresetBuilder<MaybePluginNames, MaybeStackPlugins>>(pluginToAdd: MaybePlugin, add: (pluginToAdd: MaybePlugin, maybeEditorPresetBuilder: MaybeEditorPresetBuilder) => MaybeEditorPresetBuilder): MaybeEditorPresetBuilder;
+    maybeAdd<ToAddPlugin extends PresetPlugin>(pluginToAdd: SafePresetCheck<ToAddPlugin, StackPlugins>, shouldAdd: boolean | (() => boolean) | OldAndDeprecatedAddFunction<ToAddPlugin>): EditorPresetBuilder<[
+        MaybePluginName<ExtractPluginNameFromAllBuilderPlugins<ToAddPlugin>>,
+        ...PluginNames
+    ], [
+        MaybePlugin<ToAddPlugin>,
+        ...StackPlugins
+    ]>;
     has(plugin: AllEditorPresetPluginTypes): boolean;
     build({ pluginInjectionAPI, excludePlugins: maybeExcludePlugins, }?: BuildProps): EditorPlugin[];
     private verifyDuplicatedPlugins;

package/dist/types/types/index.d.ts

@@ -28,7 +28,7 @@ export type { EditorReactContext } from './editor-react-context';
 export type { PMPluginFactoryParams, PMPluginFactory, PMPlugin, } from './plugin-factory';
 export type { NodeConfig, MarkConfig, NodeViewConfig, } from './prosemirror-config';
 export type { PluginsOptions, EditorPlugin, getPosHandler, getPosHandlerNode, } from './editor-plugin';
-export type { NextEditorPlugin, AllEditorPresetPluginTypes, PluginDependenciesAPI, ExtractPluginNameFromAllBuilderPlugins, SafePresetCheck, DefaultEditorPlugin, OptionalPlugin, PluginInjectionAPI, CreatePluginDependenciesAPI, NextEditorPluginMetadata, ExtractInjectionAPI, ExtractPluginActions, PluginInjectionAPIWithDependencies, PublicPluginAPI, NextEditorPluginFunctionOptionalConfigDefinition, ExtractNextEditorPlugins, } from './next-editor-plugin';
+export type { NextEditorPlugin, AllEditorPresetPluginTypes, PluginDependenciesAPI, ExtractPluginNameFromAllBuilderPlugins, SafePresetCheck, DefaultEditorPlugin, OptionalPlugin, PluginInjectionAPI, CreatePluginDependenciesAPI, NextEditorPluginMetadata, ExtractInjectionAPI, ExtractPluginActions, PluginInjectionAPIWithDependencies, PublicPluginAPI, NextEditorPluginFunctionOptionalConfigDefinition, ExtractNextEditorPlugins, MaybePlugin, MaybePluginName, PresetPlugin, } from './next-editor-plugin';
 export type { ExtractPublicEditorAPI } from './editor-public-api';
 export type { EditorCommand, EditorCommandWithMetadata, } from './editor-command';
 export type IconProps = {

package/dist/types/types/next-editor-plugin.d.ts

@@ -97,12 +97,15 @@ export type PluginDependenciesAPI<Plugin extends NextEditorPlugin<any, any>> = {
     commands: Plugin extends NextEditorPlugin<any, infer Metadata> ? ExtractCommandsFromMetadata<Metadata> : never;
 };
 export type CreatePluginDependenciesAPI<PluginList extends NextEditorPlugin<any, any>[]> = {
-    [Plugin in PluginList[number] as `${ExtractPluginName<Plugin>}`]: Plugin extends OptionalPlugin<NextEditorPlugin<any, any>> ? PluginDependenciesAPI<Plugin> | undefined : Plugin extends NextEditorPlugin<any, any> ? PluginDependenciesAPI<Plugin> : never;
+    [Plugin in PluginList[number] as `${ExtractPluginName<Plugin>}`]: Plugin extends OptionalPlugin<NextEditorPlugin<any, any>> ? PluginDependenciesAPI<Plugin> | undefined : Plugin extends NextEditorPlugin<any, any> ? PluginDependenciesAPI<Plugin> | undefined : never;
 };
-export type PluginAsArray<Plugin> = undefined extends ExtractPluginConfiguration<Plugin> ? [Plugin, ExtractPluginConfiguration<Plugin>?] : [Plugin, ExtractPluginConfiguration<Plugin>];
-export type AllEditorPresetPluginTypes = PluginAsArray<any> | NextEditorPlugin<any, any>;
-type ExtractNextEditorPlugin<Plugin> = Plugin extends PluginAsArray<any> ? Plugin[0] : never;
-export type VerifyPluginDependencies<Plugin, PluginsStack extends AllEditorPresetPluginTypes[]> = ExtractPluginDependencies<Plugin> extends [] ? Plugin extends PluginAsArray<any> | NextEditorPlugin<any, any> ? Plugin : never : 
+export type PluginWithConfiguration<Plugin> = undefined extends ExtractPluginConfiguration<Plugin> ? [Plugin, ExtractPluginConfiguration<Plugin>?] : [Plugin, ExtractPluginConfiguration<Plugin>];
+export type MaybePluginName<T extends string> = [T];
+export type PresetPlugin = PluginWithConfiguration<any> | NextEditorPlugin<any, any>;
+export type MaybePlugin<T extends PresetPlugin> = T | undefined;
+export type AllEditorPresetPluginTypes = PresetPlugin | MaybePlugin<NextEditorPlugin<any, any>>;
+type ExtractNextEditorPlugin<Plugin> = Plugin extends PluginWithConfiguration<any> ? Plugin[0] : never;
+export type VerifyPluginDependencies<Plugin, PluginsStack extends AllEditorPresetPluginTypes[]> = ExtractPluginDependencies<Plugin> extends [] ? Plugin extends PluginWithConfiguration<any> | NextEditorPlugin<any, any> ? Plugin : never : 
 /**
  * case 1: We're looking for its dependent plugins indexed on `AllEditorPresetPluginTypes`
  */
@@ -120,8 +123,8 @@ export type SafePresetCheck<Plugin, StackPlugins extends AllEditorPresetPluginTy
 type CheckTupleRequirements<Plugin, Config, ArrayType> = unknown extends Config ? Plugin | ArrayType : undefined extends Config ? Plugin | ArrayType : [
     Config
 ] extends [never] ? Plugin : ArrayType;
-type CheckBasicPlugin<Plugin> = Plugin extends (args: any, api: any) => EditorPlugin ? CheckTupleRequirements<Plugin, ExtractPluginConfiguration<Plugin>, PluginAsArray<Plugin>> : never;
-export type ExtractPluginNameFromAllBuilderPlugins<Plugin extends AllEditorPresetPluginTypes> = Plugin extends Array<any> ? Plugin extends [infer MaybePlugin, ...any] ? MaybePlugin extends NextEditorPlugin<any, any> ? ExtractPluginName<MaybePlugin> : never : never : Plugin extends NextEditorPlugin<any, any> ? ExtractPluginName<Plugin> : never;
+type CheckBasicPlugin<Plugin> = Plugin extends (args: any, api: any) => EditorPlugin ? CheckTupleRequirements<Plugin, ExtractPluginConfiguration<Plugin>, PluginWithConfiguration<Plugin>> : never;
+export type ExtractPluginNameFromAllBuilderPlugins<Plugin extends PresetPlugin> = Plugin extends Array<any> ? Plugin extends [infer MPlugin, ...any] ? MPlugin extends NextEditorPlugin<any, any> ? ExtractPluginName<MPlugin> : never : never : Plugin extends NextEditorPlugin<any, any> ? ExtractPluginName<Plugin> : never;
 export type ExtractInjectionAPI<Plugin> = Plugin extends NextEditorPlugin<infer Name, infer Metadata> ? PluginInjectionAPI<Name, Metadata>['dependencies'] : never;
 export type PublicPluginAPI<PluginList extends NextEditorPlugin<any, any>[]> = CreatePluginDependenciesAPI<[...PluginList, CorePlugin]>;
 export type ExtractNextEditorPlugins<Plugins extends AllEditorPresetPluginTypes[]> = {

package/dist/types-ts4.5/preset/builder.d.ts

@@ -1,4 +1,4 @@
-import type { AllEditorPresetPluginTypes, ExtractPluginNameFromAllBuilderPlugins, NextEditorPlugin, SafePresetCheck } from '../types';
+import type { AllEditorPresetPluginTypes, ExtractPluginNameFromAllBuilderPlugins, MaybePlugin, MaybePluginName, PresetPlugin, SafePresetCheck } from '../types';
 import type { EditorPlugin } from '../types/editor-plugin';
 import type { EditorPluginInjectionAPI } from './plugin-injection-api';
 interface ProcessProps {
@@ -9,23 +9,31 @@ interface BuildProps extends ProcessProps {
     excludePlugins?: Set<string>;
     pluginInjectionAPI?: EditorPluginInjectionAPI;
 }
-export declare class EditorPresetBuilder<PluginNames extends string[] = [
+type OldAndDeprecatedAddFunction<T> = (pluginToAdd: T, builder: EditorPresetBuilder<any, any>) => EditorPresetBuilder<any, any>;
+type AllPluginNames = string | MaybePluginName<string>;
+export declare class EditorPresetBuilder<PluginNames extends AllPluginNames[] = [
 ], StackPlugins extends AllEditorPresetPluginTypes[] = [
 ]> {
     private readonly data;
     constructor(...more: [
         ...StackPlugins
     ]);
-    add<NewPlugin extends AllEditorPresetPluginTypes>(nextOrTuple: SafePresetCheck<NewPlugin, StackPlugins>): EditorPresetBuilder<[
-        ...PluginNames,
-        ExtractPluginNameFromAllBuilderPlugins<NewPlugin>
+    add<NewPlugin extends PresetPlugin>(nextOrTuple: SafePresetCheck<NewPlugin, StackPlugins>): EditorPresetBuilder<[
+        ExtractPluginNameFromAllBuilderPlugins<NewPlugin>,
+        ...PluginNames
     ], [
         ...[
             NewPlugin
         ],
         ...StackPlugins
     ]>;
-    maybeAdd<MaybePlugin extends NextEditorPlugin<any, any>, MaybePluginNames extends string[], MaybeStackPlugins extends AllEditorPresetPluginTypes[], MaybeEditorPresetBuilder extends EditorPresetBuilder<MaybePluginNames, MaybeStackPlugins>>(pluginToAdd: MaybePlugin, add: (pluginToAdd: MaybePlugin, maybeEditorPresetBuilder: MaybeEditorPresetBuilder) => MaybeEditorPresetBuilder): MaybeEditorPresetBuilder;
+    maybeAdd<ToAddPlugin extends PresetPlugin>(pluginToAdd: SafePresetCheck<ToAddPlugin, StackPlugins>, shouldAdd: boolean | (() => boolean) | OldAndDeprecatedAddFunction<ToAddPlugin>): EditorPresetBuilder<[
+        MaybePluginName<ExtractPluginNameFromAllBuilderPlugins<ToAddPlugin>>,
+        ...PluginNames
+    ], [
+        MaybePlugin<ToAddPlugin>,
+        ...StackPlugins
+    ]>;
     has(plugin: AllEditorPresetPluginTypes): boolean;
     build({ pluginInjectionAPI, excludePlugins: maybeExcludePlugins, }?: BuildProps): EditorPlugin[];
     private verifyDuplicatedPlugins;

package/dist/types-ts4.5/types/index.d.ts

@@ -28,7 +28,7 @@ export type { EditorReactContext } from './editor-react-context';
 export type { PMPluginFactoryParams, PMPluginFactory, PMPlugin, } from './plugin-factory';
 export type { NodeConfig, MarkConfig, NodeViewConfig, } from './prosemirror-config';
 export type { PluginsOptions, EditorPlugin, getPosHandler, getPosHandlerNode, } from './editor-plugin';
-export type { NextEditorPlugin, AllEditorPresetPluginTypes, PluginDependenciesAPI, ExtractPluginNameFromAllBuilderPlugins, SafePresetCheck, DefaultEditorPlugin, OptionalPlugin, PluginInjectionAPI, CreatePluginDependenciesAPI, NextEditorPluginMetadata, ExtractInjectionAPI, ExtractPluginActions, PluginInjectionAPIWithDependencies, PublicPluginAPI, NextEditorPluginFunctionOptionalConfigDefinition, ExtractNextEditorPlugins, } from './next-editor-plugin';
+export type { NextEditorPlugin, AllEditorPresetPluginTypes, PluginDependenciesAPI, ExtractPluginNameFromAllBuilderPlugins, SafePresetCheck, DefaultEditorPlugin, OptionalPlugin, PluginInjectionAPI, CreatePluginDependenciesAPI, NextEditorPluginMetadata, ExtractInjectionAPI, ExtractPluginActions, PluginInjectionAPIWithDependencies, PublicPluginAPI, NextEditorPluginFunctionOptionalConfigDefinition, ExtractNextEditorPlugins, MaybePlugin, MaybePluginName, PresetPlugin, } from './next-editor-plugin';
 export type { ExtractPublicEditorAPI } from './editor-public-api';
 export type { EditorCommand, EditorCommandWithMetadata, } from './editor-command';
 export type IconProps = {

package/dist/types-ts4.5/types/next-editor-plugin.d.ts

@@ -103,19 +103,24 @@ export type PluginDependenciesAPI<Plugin extends NextEditorPlugin<any, any>> = {
     commands: Plugin extends NextEditorPlugin<any, infer Metadata> ? ExtractCommandsFromMetadata<Metadata> : never;
 };
 export type CreatePluginDependenciesAPI<PluginList extends NextEditorPlugin<any, any>[]> = {
-    [Plugin in PluginList[number] as `${ExtractPluginName<Plugin>}`]: Plugin extends OptionalPlugin<NextEditorPlugin<any, any>> ? PluginDependenciesAPI<Plugin> | undefined : Plugin extends NextEditorPlugin<any, any> ? PluginDependenciesAPI<Plugin> : never;
+    [Plugin in PluginList[number] as `${ExtractPluginName<Plugin>}`]: Plugin extends OptionalPlugin<NextEditorPlugin<any, any>> ? PluginDependenciesAPI<Plugin> | undefined : Plugin extends NextEditorPlugin<any, any> ? PluginDependenciesAPI<Plugin> | undefined : never;
 };
-export type PluginAsArray<Plugin> = undefined extends ExtractPluginConfiguration<Plugin> ? [
+export type PluginWithConfiguration<Plugin> = undefined extends ExtractPluginConfiguration<Plugin> ? [
     Plugin,
     ExtractPluginConfiguration<Plugin>?
 ] : [
     Plugin,
     ExtractPluginConfiguration<Plugin>
 ];
-export type AllEditorPresetPluginTypes = PluginAsArray<any> | NextEditorPlugin<any, any>;
-type ExtractNextEditorPlugin<Plugin> = Plugin extends PluginAsArray<any> ? Plugin[0] : never;
+export type MaybePluginName<T extends string> = [
+    T
+];
+export type PresetPlugin = PluginWithConfiguration<any> | NextEditorPlugin<any, any>;
+export type MaybePlugin<T extends PresetPlugin> = T | undefined;
+export type AllEditorPresetPluginTypes = PresetPlugin | MaybePlugin<NextEditorPlugin<any, any>>;
+type ExtractNextEditorPlugin<Plugin> = Plugin extends PluginWithConfiguration<any> ? Plugin[0] : never;
 export type VerifyPluginDependencies<Plugin, PluginsStack extends AllEditorPresetPluginTypes[]> = ExtractPluginDependencies<Plugin> extends [
-] ? Plugin extends PluginAsArray<any> | NextEditorPlugin<any, any> ? Plugin : never : 
+] ? Plugin extends PluginWithConfiguration<any> | NextEditorPlugin<any, any> ? Plugin : never : 
 /**
  * case 1: We're looking for its dependent plugins indexed on `AllEditorPresetPluginTypes`
  */
@@ -135,11 +140,11 @@ type CheckTupleRequirements<Plugin, Config, ArrayType> = unknown extends Config
 ] extends [
     never
 ] ? Plugin : ArrayType;
-type CheckBasicPlugin<Plugin> = Plugin extends (args: any, api: any) => EditorPlugin ? CheckTupleRequirements<Plugin, ExtractPluginConfiguration<Plugin>, PluginAsArray<Plugin>> : never;
-export type ExtractPluginNameFromAllBuilderPlugins<Plugin extends AllEditorPresetPluginTypes> = Plugin extends Array<any> ? Plugin extends [
-    infer MaybePlugin,
+type CheckBasicPlugin<Plugin> = Plugin extends (args: any, api: any) => EditorPlugin ? CheckTupleRequirements<Plugin, ExtractPluginConfiguration<Plugin>, PluginWithConfiguration<Plugin>> : never;
+export type ExtractPluginNameFromAllBuilderPlugins<Plugin extends PresetPlugin> = Plugin extends Array<any> ? Plugin extends [
+    infer MPlugin,
     ...any
-] ? MaybePlugin extends NextEditorPlugin<any, any> ? ExtractPluginName<MaybePlugin> : never : never : Plugin extends NextEditorPlugin<any, any> ? ExtractPluginName<Plugin> : never;
+] ? MPlugin extends NextEditorPlugin<any, any> ? ExtractPluginName<MPlugin> : never : never : Plugin extends NextEditorPlugin<any, any> ? ExtractPluginName<Plugin> : never;
 export type ExtractInjectionAPI<Plugin> = Plugin extends NextEditorPlugin<infer Name, infer Metadata> ? PluginInjectionAPI<Name, Metadata>['dependencies'] : never;
 export type PublicPluginAPI<PluginList extends NextEditorPlugin<any, any>[]> = CreatePluginDependenciesAPI<[
     ...PluginList,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "76.41.0",
+  "version": "77.0.0",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -105,7 +105,7 @@
     "@atlaskit/editor-palette": "1.5.2",
     "@atlaskit/editor-prosemirror": "1.1.0",
     "@atlaskit/editor-shared-styles": "^2.9.0",
-    "@atlaskit/editor-tables": "^2.3.0",
+    "@atlaskit/editor-tables": "^2.4.0",
     "@atlaskit/emoji": "^67.6.0",
     "@atlaskit/icon": "^22.0.0",
     "@atlaskit/icon-object": "^6.3.0",
@@ -119,13 +119,13 @@
     "@atlaskit/menu": "^2.1.0",
     "@atlaskit/platform-feature-flags": "^0.2.0",
     "@atlaskit/profilecard": "^19.7.0",
-    "@atlaskit/smart-card": "^26.44.0",
+    "@atlaskit/smart-card": "^26.45.0",
     "@atlaskit/smart-user-picker": "^6.4.0",
     "@atlaskit/spinner": "^16.0.0",
     "@atlaskit/task-decision": "^17.9.0",
     "@atlaskit/textfield": "^6.0.0",
     "@atlaskit/theme": "^12.6.0",
-    "@atlaskit/tokens": "^1.33.0",
+    "@atlaskit/tokens": "^1.34.0",
     "@atlaskit/tooltip": "^18.1.0",
     "@atlaskit/ufo": "^0.2.0",
     "@atlaskit/width-detector": "^4.1.0",