@atlaskit/editor-common 76.24.0 → 76.24.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-common
 
+## 76.24.1
+
+### Patch Changes
+
+- [#57610](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/57610) [`587bbbfbf44d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/587bbbfbf44d) - Fix flicker of type-ahead popup in react 18.
+
 ## 76.24.0
 
 ### Minor Changes

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "76.24.0";
+var packageVersion = "76.24.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "76.24.0";
+var packageVersion = "76.24.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/cjs/ui/Popup/index.js

@@ -23,6 +23,7 @@ var _focusTrap = _interopRequireDefault(require("focus-trap"));
 var _rafSchd = _interopRequireDefault(require("raf-schd"));
 var _reactDom = require("react-dom");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("./utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -288,6 +289,10 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
 
       //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
       var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+
+      // If the position is not defined, render null because we haven't
+      // calculated where on the page the children should render yet.
+      var childrenDisplayed = position !== undefined ? this.props.children : null;
       return /*#__PURE__*/_react.default.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({
@@ -299,7 +304,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
         // Indicates component is an editor pop. Required for focus handling in Message.tsx
         ,
         "data-editor-popup": true
-      }, this.props.children);
+      }, (0, _platformFeatureFlags.getBooleanFF)('platform.editor.popup.fix-flicker-react-18') ? childrenDisplayed : this.props.children);
     }
   }, {
     key: "render",

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "76.24.0";
+const packageVersion = "76.24.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/ui/DropList/index.js

@@ -9,7 +9,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "76.24.0";
+const packageVersion = "76.24.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/es2019/ui/Popup/index.js

@@ -4,6 +4,7 @@ import createFocusTrap from 'focus-trap';
 import rafSchedule from 'raf-schd';
 import { createPortal } from 'react-dom';
 import { akEditorFloatingPanelZIndex } from '@atlaskit/editor-shared-styles';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { calculatePlacement, calculatePosition, findOverflowScrollParent, validatePosition } from './utils';
 export default class Popup extends React.Component {
   constructor(...args) {
@@ -242,6 +243,10 @@ export default class Popup extends React.Component {
 
     //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
     const ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+
+    // If the position is not defined, render null because we haven't
+    // calculated where on the page the children should render yet.
+    const childrenDisplayed = position !== undefined ? this.props.children : null;
     return /*#__PURE__*/React.createElement("div", {
       ref: this.handleRef,
       style: {
@@ -255,7 +260,7 @@ export default class Popup extends React.Component {
       // Indicates component is an editor pop. Required for focus handling in Message.tsx
       ,
       "data-editor-popup": true
-    }, this.props.children);
+    }, getBooleanFF('platform.editor.popup.fix-flicker-react-18') ? childrenDisplayed : this.props.children);
   }
   render() {
     const {

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "76.24.0";
+var packageVersion = "76.24.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/ui/DropList/index.js

@@ -19,7 +19,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "76.24.0";
+var packageVersion = "76.24.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/esm/ui/Popup/index.js

@@ -14,6 +14,7 @@ import createFocusTrap from 'focus-trap';
 import rafSchedule from 'raf-schd';
 import { createPortal } from 'react-dom';
 import { akEditorFloatingPanelZIndex } from '@atlaskit/editor-shared-styles';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { calculatePlacement, calculatePosition as _calculatePosition, findOverflowScrollParent, validatePosition } from './utils';
 var Popup = /*#__PURE__*/function (_React$Component) {
   _inherits(Popup, _React$Component);
@@ -275,6 +276,10 @@ var Popup = /*#__PURE__*/function (_React$Component) {
 
       //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
       var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+
+      // If the position is not defined, render null because we haven't
+      // calculated where on the page the children should render yet.
+      var childrenDisplayed = position !== undefined ? this.props.children : null;
       return /*#__PURE__*/React.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({
@@ -286,7 +291,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
         // Indicates component is an editor pop. Required for focus handling in Message.tsx
         ,
         "data-editor-popup": true
-      }, this.props.children);
+      }, getBooleanFF('platform.editor.popup.fix-flicker-react-18') ? childrenDisplayed : this.props.children);
     }
   }, {
     key: "render",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "76.24.0",
+  "version": "76.24.1",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -218,6 +218,9 @@
     },
     "platform.editor.menu.group-items": {
       "type": "boolean"
+    },
+    "platform.editor.popup.fix-flicker-react-18": {
+      "type": "boolean"
     }
   }
 }