@atlaskit/editor-common 75.8.0 → 75.8.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-common
 
+## 75.8.1
+
+### Patch Changes
+
+- [`b1b8c7d356c`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b1b8c7d356c) - [ED-19757] Fix getPos throwing exception for all nodeviews
+
 ## 75.8.0
 
 ### Minor Changes

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "75.8.0";
+var packageVersion = "75.8.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/safe-plugin/index.js

@@ -10,9 +10,47 @@ var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/cl
 var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
 var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime/helpers/possibleConstructorReturn"));
 var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
+var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
+var _toArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toArray"));
 var _state = require("@atlaskit/editor-prosemirror/state");
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
+// Wraper to avoid any exception during the get pos operation
+// See this https://hello.atlassian.net/wiki/spaces/EDITOR/pages/2849713193/ED-19672+Extensions+Regression
+// And this https://discuss.prosemirror.net/t/possible-bug-on-viewdesc-posbeforechild/5783
+var wrapGetPosExceptions = function wrapGetPosExceptions(spec) {
+  var _spec$props;
+  if (!(spec !== null && spec !== void 0 && (_spec$props = spec.props) !== null && _spec$props !== void 0 && _spec$props.nodeViews)) {
+    return spec;
+  }
+  var unsafeNodeViews = spec.props.nodeViews;
+  var safeNodeViews = new Proxy(unsafeNodeViews, {
+    get: function get(target, prop, receiver) {
+      var safeNodeView = new Proxy(Reflect.get(target, prop, receiver), {
+        apply: function apply(target, thisArg, argumentsList) {
+          var _argumentsList = (0, _toArray2.default)(argumentsList),
+            node = _argumentsList[0],
+            view = _argumentsList[1],
+            unsafeGetPos = _argumentsList[2],
+            more = _argumentsList.slice(3);
+          var safeGetPos = function () {
+            try {
+              return unsafeGetPos();
+            } catch (e) {
+              return;
+            }
+            return;
+            // eslint-disable-next-line no-extra-bind
+          }.bind(thisArg);
+          return Reflect.apply(target, thisArg, [node, view, safeGetPos].concat((0, _toConsumableArray2.default)(more)));
+        }
+      });
+      return safeNodeView;
+    }
+  });
+  spec.props.nodeViews = safeNodeViews;
+  return spec;
+};
 var SafePlugin = /*#__PURE__*/function (_Plugin) {
   (0, _inherits2.default)(SafePlugin, _Plugin);
   var _super = _createSuper(SafePlugin);
@@ -22,7 +60,7 @@ var SafePlugin = /*#__PURE__*/function (_Plugin) {
 
   function SafePlugin(spec) {
     (0, _classCallCheck2.default)(this, SafePlugin);
-    return _super.call(this, spec);
+    return _super.call(this, wrapGetPosExceptions(spec));
   }
   return (0, _createClass2.default)(SafePlugin);
 }(_state.Plugin);

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "75.8.0";
+var packageVersion = "75.8.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "75.8.0";
+const packageVersion = "75.8.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/safe-plugin/index.js

@@ -1,10 +1,42 @@
 import { Plugin } from '@atlaskit/editor-prosemirror/state';
+// Wraper to avoid any exception during the get pos operation
+// See this https://hello.atlassian.net/wiki/spaces/EDITOR/pages/2849713193/ED-19672+Extensions+Regression
+// And this https://discuss.prosemirror.net/t/possible-bug-on-viewdesc-posbeforechild/5783
+const wrapGetPosExceptions = spec => {
+  var _spec$props;
+  if (!(spec !== null && spec !== void 0 && (_spec$props = spec.props) !== null && _spec$props !== void 0 && _spec$props.nodeViews)) {
+    return spec;
+  }
+  const unsafeNodeViews = spec.props.nodeViews;
+  const safeNodeViews = new Proxy(unsafeNodeViews, {
+    get(target, prop, receiver) {
+      const safeNodeView = new Proxy(Reflect.get(target, prop, receiver), {
+        apply(target, thisArg, argumentsList) {
+          const [node, view, unsafeGetPos, ...more] = argumentsList;
+          const safeGetPos = (() => {
+            try {
+              return unsafeGetPos();
+            } catch (e) {
+              return;
+            }
+            return;
+            // eslint-disable-next-line no-extra-bind
+          }).bind(thisArg);
+          return Reflect.apply(target, thisArg, [node, view, safeGetPos, ...more]);
+        }
+      });
+      return safeNodeView;
+    }
+  });
+  spec.props.nodeViews = safeNodeViews;
+  return spec;
+};
 export class SafePlugin extends Plugin {
   // This variable isn't (and shouldn't) be used anywhere. Its purpose is
   // to distinguish Plugin from SafePlugin, thus ensuring that an 'unsafe'
   // Plugin cannot be assigned as an item in EditorPlugin → pmPlugins.
 
   constructor(spec) {
-    super(spec);
+    super(wrapGetPosExceptions(spec));
   }
 }

package/dist/es2019/ui/DropList/index.js

@@ -9,7 +9,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "75.8.0";
+const packageVersion = "75.8.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "75.8.0";
+var packageVersion = "75.8.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/safe-plugin/index.js

@@ -3,9 +3,47 @@ import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _inherits from "@babel/runtime/helpers/inherits";
 import _possibleConstructorReturn from "@babel/runtime/helpers/possibleConstructorReturn";
 import _getPrototypeOf from "@babel/runtime/helpers/getPrototypeOf";
+import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
+import _toArray from "@babel/runtime/helpers/toArray";
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 import { Plugin } from '@atlaskit/editor-prosemirror/state';
+// Wraper to avoid any exception during the get pos operation
+// See this https://hello.atlassian.net/wiki/spaces/EDITOR/pages/2849713193/ED-19672+Extensions+Regression
+// And this https://discuss.prosemirror.net/t/possible-bug-on-viewdesc-posbeforechild/5783
+var wrapGetPosExceptions = function wrapGetPosExceptions(spec) {
+  var _spec$props;
+  if (!(spec !== null && spec !== void 0 && (_spec$props = spec.props) !== null && _spec$props !== void 0 && _spec$props.nodeViews)) {
+    return spec;
+  }
+  var unsafeNodeViews = spec.props.nodeViews;
+  var safeNodeViews = new Proxy(unsafeNodeViews, {
+    get: function get(target, prop, receiver) {
+      var safeNodeView = new Proxy(Reflect.get(target, prop, receiver), {
+        apply: function apply(target, thisArg, argumentsList) {
+          var _argumentsList = _toArray(argumentsList),
+            node = _argumentsList[0],
+            view = _argumentsList[1],
+            unsafeGetPos = _argumentsList[2],
+            more = _argumentsList.slice(3);
+          var safeGetPos = function () {
+            try {
+              return unsafeGetPos();
+            } catch (e) {
+              return;
+            }
+            return;
+            // eslint-disable-next-line no-extra-bind
+          }.bind(thisArg);
+          return Reflect.apply(target, thisArg, [node, view, safeGetPos].concat(_toConsumableArray(more)));
+        }
+      });
+      return safeNodeView;
+    }
+  });
+  spec.props.nodeViews = safeNodeViews;
+  return spec;
+};
 export var SafePlugin = /*#__PURE__*/function (_Plugin) {
   _inherits(SafePlugin, _Plugin);
   var _super = _createSuper(SafePlugin);
@@ -15,7 +53,7 @@ export var SafePlugin = /*#__PURE__*/function (_Plugin) {
 
   function SafePlugin(spec) {
     _classCallCheck(this, SafePlugin);
-    return _super.call(this, spec);
+    return _super.call(this, wrapGetPosExceptions(spec));
   }
   return _createClass(SafePlugin);
 }(Plugin);

package/dist/esm/ui/DropList/index.js

@@ -19,7 +19,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "75.8.0";
+var packageVersion = "75.8.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/types/safe-plugin/index.d.ts

@@ -1,4 +1,5 @@
-import { Plugin, SafePluginSpec } from '@atlaskit/editor-prosemirror/state';
+import { Plugin } from '@atlaskit/editor-prosemirror/state';
+import type { SafePluginSpec } from '@atlaskit/editor-prosemirror/state';
 export declare class SafePlugin<T = any> extends Plugin<T> {
     _isATypeSafePlugin: never;
     constructor(spec: SafePluginSpec<T>);

package/dist/types-ts4.5/safe-plugin/index.d.ts

@@ -1,4 +1,5 @@
-import { Plugin, SafePluginSpec } from '@atlaskit/editor-prosemirror/state';
+import { Plugin } from '@atlaskit/editor-prosemirror/state';
+import type { SafePluginSpec } from '@atlaskit/editor-prosemirror/state';
 export declare class SafePlugin<T = any> extends Plugin<T> {
     _isATypeSafePlugin: never;
     constructor(spec: SafePluginSpec<T>);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "75.8.0",
+  "version": "75.8.1",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -101,7 +101,7 @@
     "@atlaskit/icon": "^21.12.0",
     "@atlaskit/icon-object": "^6.3.0",
     "@atlaskit/in-product-testing": "^0.2.0",
-    "@atlaskit/link-datasource": "^1.3.0",
+    "@atlaskit/link-datasource": "^1.4.0",
     "@atlaskit/link-picker": "^1.30.0",
     "@atlaskit/media-card": "^77.0.0",
     "@atlaskit/media-client": "^24.0.0",