@atlaskit/editor-common 75.5.0 → 75.5.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-common
 
+## 75.5.1
+
+### Patch Changes
+
+- [`966f90e1edf`](https://bitbucket.org/atlassian/atlassian-frontend/commits/966f90e1edf) - [ux] [ECA11Y-44] Adjust 'Popup' component so that it doesn't always have to have 'aria-label' attribute displayed
+
 ## 75.5.0
 
 ### Minor Changes

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "75.5.0";
+var packageVersion = "75.5.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "75.5.0";
+var packageVersion = "75.5.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/cjs/ui/Popup/index.js

@@ -272,13 +272,17 @@ var Popup = /*#__PURE__*/function (_React$Component) {
       if (shouldRenderPopup && !shouldRenderPopup(position || {})) {
         return null;
       }
+
+      //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
+      var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
       return /*#__PURE__*/_react.default.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({
           position: 'absolute',
           zIndex: this.props.zIndex || _editorSharedStyles.akEditorFloatingPanelZIndex
         }, position), this.props.style),
-        "aria-label": this.props.ariaLabel || 'Popup'
+        "aria-label": ariaLabel,
+        "data-testid": "popup-wrapper"
         // Indicates component is an editor pop. Required for focus handling in Message.tsx
         ,
         "data-editor-popup": true

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "75.5.0";
+const packageVersion = "75.5.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/ui/DropList/index.js

@@ -9,7 +9,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "75.5.0";
+const packageVersion = "75.5.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/es2019/ui/Popup/index.js

@@ -226,6 +226,9 @@ export default class Popup extends React.Component {
     if (shouldRenderPopup && !shouldRenderPopup(position || {})) {
       return null;
     }
+
+    //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
+    const ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
     return /*#__PURE__*/React.createElement("div", {
       ref: this.handleRef,
       style: {
@@ -234,7 +237,8 @@ export default class Popup extends React.Component {
         ...position,
         ...this.props.style
       },
-      "aria-label": this.props.ariaLabel || 'Popup'
+      "aria-label": ariaLabel,
+      "data-testid": "popup-wrapper"
       // Indicates component is an editor pop. Required for focus handling in Message.tsx
       ,
       "data-editor-popup": true

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "75.5.0";
+var packageVersion = "75.5.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/ui/DropList/index.js

@@ -19,7 +19,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "75.5.0";
+var packageVersion = "75.5.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/esm/ui/Popup/index.js

@@ -259,13 +259,17 @@ var Popup = /*#__PURE__*/function (_React$Component) {
       if (shouldRenderPopup && !shouldRenderPopup(position || {})) {
         return null;
       }
+
+      //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
+      var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
       return /*#__PURE__*/React.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({
           position: 'absolute',
           zIndex: this.props.zIndex || akEditorFloatingPanelZIndex
         }, position), this.props.style),
-        "aria-label": this.props.ariaLabel || 'Popup'
+        "aria-label": ariaLabel,
+        "data-testid": "popup-wrapper"
         // Indicates component is an editor pop. Required for focus handling in Message.tsx
         ,
         "data-editor-popup": true

package/dist/types/ui/Popup/index.d.ts

@@ -1,5 +1,5 @@
 import React from 'react';
-import { Position } from './utils';
+import type { Position } from './utils';
 export interface Props {
     zIndex?: number;
     alignX?: 'left' | 'right' | 'center' | 'end';
@@ -15,7 +15,8 @@ export interface Props {
     shouldRenderPopup?: (position: Position) => boolean;
     scrollableElement?: HTMLElement;
     stick?: boolean;
-    ariaLabel?: string;
+    /** `null` should only be used if we provide enough context to screen readers to exclude aria-label attribute */
+    ariaLabel?: string | null;
     forcePlacement?: boolean;
     allowOutOfBounds?: boolean;
     rect?: DOMRect;

package/dist/types-ts4.5/ui/Popup/index.d.ts

@@ -1,5 +1,5 @@
 import React from 'react';
-import { Position } from './utils';
+import type { Position } from './utils';
 export interface Props {
     zIndex?: number;
     alignX?: 'left' | 'right' | 'center' | 'end';
@@ -18,7 +18,8 @@ export interface Props {
     shouldRenderPopup?: (position: Position) => boolean;
     scrollableElement?: HTMLElement;
     stick?: boolean;
-    ariaLabel?: string;
+    /** `null` should only be used if we provide enough context to screen readers to exclude aria-label attribute */
+    ariaLabel?: string | null;
     forcePlacement?: boolean;
     allowOutOfBounds?: boolean;
     rect?: DOMRect;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "75.5.0",
+  "version": "75.5.1",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"