@atlaskit/editor-common 74.9.0 → 74.9.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-common
 
+## 74.9.2
+
+### Patch Changes
+
+- [`87070f514cd`](https://bitbucket.org/atlassian/atlassian-frontend/commits/87070f514cd) - [ux] ED-18024 Adds an enter keydown handler on the main toolbar droplist (BlockInsertMenuLegacy) to prevent the editor capturing the keypress when the keyboard is used to insert nodes.
+
+## 74.9.1
+
+### Patch Changes
+
+- [`18344c31ea3`](https://bitbucket.org/atlassian/atlassian-frontend/commits/18344c31ea3) - [ED-13910] Fix EditorView getPos type
+
 ## 74.9.0
 
 ### Minor Changes

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "74.9.0";
+var packageVersion = "74.9.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/react-node-view/getInlineNodeViewProducer.js

@@ -178,7 +178,9 @@ function getPortalChildren(_ref2) {
     }, (0, _react2.jsx)("span", {
       className: "".concat(inlineNodeViewClassname, "AddZeroWidthSpace")
     }), _utils.ZERO_WIDTH_SPACE), (0, _react2.jsx)(Component, (0, _extends2.default)({
-      view: nodeViewParams.view,
+      view: nodeViewParams.view
+      // TODO:  ED-13910 - Remove the boolean to fix the prosemirror view type
+      ,
       getPos: nodeViewParams.getPos,
       node: currentNode
     }, extraComponentProps)), (0, _react2.jsx)("span", {

package/dist/cjs/selection-based-node-view/SelectionBasedNodeView.js

@@ -95,8 +95,11 @@ var SelectionBasedNodeView = /*#__PURE__*/function (_ReactNodeView) {
       if (typeof this.getPos === 'boolean') {
         return;
       }
-      this.pos = this.getPos();
-      this.posEnd = this.pos + this.node.nodeSize;
+      var pos = this.getPos();
+      if (typeof pos === 'number') {
+        this.pos = pos;
+        this.posEnd = pos + this.node.nodeSize;
+      }
     }
   }, {
     key: "getPositionsWithDefault",

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "74.9.0";
+var packageVersion = "74.9.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/cjs/ui-menu/DropdownMenu/index.js

@@ -179,6 +179,10 @@ var DropdownMenuWrapper = /*#__PURE__*/function (_PureComponent) {
         isTriggerNotTabbable: true,
         handleClickOutside: this.handleClose,
         handleEscapeKeydown: this.handleCloseAndFocus,
+        handleEnterKeydown: function handleEnterKeydown(e) {
+          e.preventDefault();
+          e.stopPropagation();
+        },
         targetRef: this.state.target
       }, (0, _react2.jsx)("div", {
         style: {

package/dist/cjs/utils/editor-core-utils.js

@@ -91,6 +91,9 @@ function nonNullable(value) {
 
 // checks if the given position is within the ProseMirror document
 var isValidPosition = function isValidPosition(pos, state) {
+  if (typeof pos !== 'number') {
+    return false;
+  }
   if (pos >= 0 && pos <= state.doc.resolve(0).end()) {
     return true;
   }

package/dist/cjs/utils/nodes.js

@@ -79,6 +79,9 @@ var SelectedState = /*#__PURE__*/function (SelectedState) {
  */
 exports.SelectedState = SelectedState;
 var isNodeSelectedOrInRange = function isNodeSelectedOrInRange(anchorPosition, headPosition, nodePosition, nodeSize) {
+  if (typeof nodePosition !== 'number') {
+    return null;
+  }
   var rangeStart = Math.min(anchorPosition, headPosition);
   var rangeEnd = Math.max(anchorPosition, headPosition);
   var nodeStart = nodePosition;

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.9.0",
+	"version": "74.9.2",
 	"sideEffects": false
 }

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "74.9.0";
+const packageVersion = "74.9.2";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/react-node-view/getInlineNodeViewProducer.js

@@ -171,7 +171,9 @@ function getPortalChildren({
     }, jsx("span", {
       className: `${inlineNodeViewClassname}AddZeroWidthSpace`
     }), ZERO_WIDTH_SPACE), jsx(Component, _extends({
-      view: nodeViewParams.view,
+      view: nodeViewParams.view
+      // TODO:  ED-13910 - Remove the boolean to fix the prosemirror view type
+      ,
       getPos: nodeViewParams.getPos,
       node: currentNode
     }, extraComponentProps)), jsx("span", {

package/dist/es2019/selection-based-node-view/SelectionBasedNodeView.js

@@ -80,8 +80,11 @@ export class SelectionBasedNodeView extends ReactNodeView {
     if (typeof this.getPos === 'boolean') {
       return;
     }
-    this.pos = this.getPos();
-    this.posEnd = this.pos + this.node.nodeSize;
+    const pos = this.getPos();
+    if (typeof pos === 'number') {
+      this.pos = pos;
+      this.posEnd = pos + this.node.nodeSize;
+    }
   }
   getPositionsWithDefault(pos, posEnd) {
     return {

package/dist/es2019/ui/DropList/index.js

@@ -8,7 +8,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "74.9.0";
+const packageVersion = "74.9.2";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/es2019/ui-menu/DropdownMenu/index.js

@@ -187,6 +187,10 @@ export default class DropdownMenuWrapper extends PureComponent {
       isTriggerNotTabbable: true,
       handleClickOutside: this.handleClose,
       handleEscapeKeydown: this.handleCloseAndFocus,
+      handleEnterKeydown: e => {
+        e.preventDefault();
+        e.stopPropagation();
+      },
       targetRef: this.state.target
     }, jsx("div", {
       style: {

package/dist/es2019/utils/editor-core-utils.js

@@ -75,6 +75,9 @@ export function nonNullable(value) {
 
 // checks if the given position is within the ProseMirror document
 export const isValidPosition = (pos, state) => {
+  if (typeof pos !== 'number') {
+    return false;
+  }
   if (pos >= 0 && pos <= state.doc.resolve(0).end()) {
     return true;
   }

package/dist/es2019/utils/nodes.js

@@ -53,6 +53,9 @@ export let SelectedState = /*#__PURE__*/function (SelectedState) {
  * is fully selected by a range or if the "inside" of the node has been selected or clicked.
  */
 export const isNodeSelectedOrInRange = (anchorPosition, headPosition, nodePosition, nodeSize) => {
+  if (typeof nodePosition !== 'number') {
+    return null;
+  }
   const rangeStart = Math.min(anchorPosition, headPosition);
   const rangeEnd = Math.max(anchorPosition, headPosition);
   const nodeStart = nodePosition;

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.9.0",
+	"version": "74.9.2",
 	"sideEffects": false
 }

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "74.9.0";
+var packageVersion = "74.9.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/react-node-view/getInlineNodeViewProducer.js

@@ -168,7 +168,9 @@ function getPortalChildren(_ref2) {
     }, jsx("span", {
       className: "".concat(inlineNodeViewClassname, "AddZeroWidthSpace")
     }), ZERO_WIDTH_SPACE), jsx(Component, _extends({
-      view: nodeViewParams.view,
+      view: nodeViewParams.view
+      // TODO:  ED-13910 - Remove the boolean to fix the prosemirror view type
+      ,
       getPos: nodeViewParams.getPos,
       node: currentNode
     }, extraComponentProps)), jsx("span", {

package/dist/esm/selection-based-node-view/SelectionBasedNodeView.js

@@ -89,8 +89,11 @@ export var SelectionBasedNodeView = /*#__PURE__*/function (_ReactNodeView) {
       if (typeof this.getPos === 'boolean') {
         return;
       }
-      this.pos = this.getPos();
-      this.posEnd = this.pos + this.node.nodeSize;
+      var pos = this.getPos();
+      if (typeof pos === 'number') {
+        this.pos = pos;
+        this.posEnd = pos + this.node.nodeSize;
+      }
     }
   }, {
     key: "getPositionsWithDefault",

package/dist/esm/ui/DropList/index.js

@@ -18,7 +18,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "74.9.0";
+var packageVersion = "74.9.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/esm/ui-menu/DropdownMenu/index.js

@@ -169,6 +169,10 @@ var DropdownMenuWrapper = /*#__PURE__*/function (_PureComponent) {
         isTriggerNotTabbable: true,
         handleClickOutside: this.handleClose,
         handleEscapeKeydown: this.handleCloseAndFocus,
+        handleEnterKeydown: function handleEnterKeydown(e) {
+          e.preventDefault();
+          e.stopPropagation();
+        },
         targetRef: this.state.target
       }, jsx("div", {
         style: {

package/dist/esm/utils/editor-core-utils.js

@@ -73,6 +73,9 @@ export function nonNullable(value) {
 
 // checks if the given position is within the ProseMirror document
 export var isValidPosition = function isValidPosition(pos, state) {
+  if (typeof pos !== 'number') {
+    return false;
+  }
   if (pos >= 0 && pos <= state.doc.resolve(0).end()) {
     return true;
   }

package/dist/esm/utils/nodes.js

@@ -66,6 +66,9 @@ export var SelectedState = /*#__PURE__*/function (SelectedState) {
  * is fully selected by a range or if the "inside" of the node has been selected or clicked.
  */
 export var isNodeSelectedOrInRange = function isNodeSelectedOrInRange(anchorPosition, headPosition, nodePosition, nodeSize) {
+  if (typeof nodePosition !== 'number') {
+    return null;
+  }
   var rangeStart = Math.min(anchorPosition, headPosition);
   var rangeEnd = Math.max(anchorPosition, headPosition);
   var nodeStart = nodePosition;

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.9.0",
+	"version": "74.9.2",
 	"sideEffects": false
 }

package/dist/types/react-node-view/getInlineNodeViewProducer.d.ts

@@ -1,22 +1,17 @@
 /** @jsx jsx */
 import React from 'react';
 import { Node as PMNode } from 'prosemirror-model';
-import { EditorProps, EditorView } from 'prosemirror-view';
+import { Decoration, EditorView, NodeView } from 'prosemirror-view';
 import type { PMPluginFactoryParams } from '../types';
 export type InlineNodeViewComponentProps = {
     view: EditorView;
-    getPos: NodeViewParams['getPos'];
+    getPos: () => GetPosReturn;
     node: PMNode;
 };
 type InlineNodeViewComponent<ExtraComponentProps> = React.ComponentType<InlineNodeViewComponentProps & ExtraComponentProps>;
 export declare const inlineNodeViewClassname = "inlineNodeView";
-type NodeViewProducer = NonNullable<EditorProps['nodeViews']>[string];
-type NodeViewParams = {
-    node: Parameters<NodeViewProducer>[0];
-    view: Parameters<NodeViewProducer>[1];
-    getPos: Parameters<NodeViewProducer>[2];
-    decorations: Parameters<NodeViewProducer>[3];
-};
+type NodeViewProducer = (node: PMNode, view: EditorView, getPos: (() => GetPosReturn) | boolean, decorations: Decoration[]) => NodeView;
+type GetPosReturn = number | undefined;
 export declare function getInlineNodeViewProducer<ExtraComponentProps>({ pmPluginFactoryParams, Component, extraComponentProps, }: {
     pmPluginFactoryParams: PMPluginFactoryParams;
     Component: InlineNodeViewComponent<ExtraComponentProps>;

package/dist/types/react-node-view/types.d.ts

@@ -4,7 +4,7 @@ export interface ReactNodeProps {
 }
 export type ProsemirrorGetPosHandler = () => number;
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export type ReactComponentProps = {
     [key: string]: unknown;
 };

package/dist/types/types/editor-plugin.d.ts

@@ -88,5 +88,5 @@ export interface EditorPlugin {
     onEditorViewStateUpdated?: (props: EditorViewStateUpdatedCallbackProps) => void;
 }
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export {};

package/dist/types/utils/editor-core-utils.d.ts

@@ -25,5 +25,5 @@ export declare const isLastItemMediaGroup: (node: Node) => boolean;
 export declare const setNodeSelection: (view: EditorView, pos: number) => void;
 export declare function setTextSelection(view: EditorView, anchor: number, head?: number): void;
 export declare function nonNullable<T>(value: T): value is NonNullable<T>;
-export declare const isValidPosition: (pos: number, state: EditorState) => boolean;
+export declare const isValidPosition: (pos: number | undefined, state: EditorState) => boolean;
 export declare const isInLayoutColumn: (state: EditorState) => boolean;

package/dist/types/utils/nodes.d.ts

@@ -25,7 +25,7 @@ export declare enum SelectedState {
  * If the node is selected then an enum is returned that describes weather the node
  * is fully selected by a range or if the "inside" of the node has been selected or clicked.
  */
-export declare const isNodeSelectedOrInRange: (anchorPosition: number, headPosition: number, nodePosition: number, nodeSize: number) => SelectedState | null;
+export declare const isNodeSelectedOrInRange: (anchorPosition: number, headPosition: number, nodePosition: number | undefined, nodeSize: number) => SelectedState | null;
 /**
  * Checks if a particular node fragment is supported in the parent
  * @param state EditorState

package/dist/types-ts4.5/react-node-view/getInlineNodeViewProducer.d.ts

@@ -1,22 +1,17 @@
 /** @jsx jsx */
 import React from 'react';
 import { Node as PMNode } from 'prosemirror-model';
-import { EditorProps, EditorView } from 'prosemirror-view';
+import { Decoration, EditorView, NodeView } from 'prosemirror-view';
 import type { PMPluginFactoryParams } from '../types';
 export type InlineNodeViewComponentProps = {
     view: EditorView;
-    getPos: NodeViewParams['getPos'];
+    getPos: () => GetPosReturn;
     node: PMNode;
 };
 type InlineNodeViewComponent<ExtraComponentProps> = React.ComponentType<InlineNodeViewComponentProps & ExtraComponentProps>;
 export declare const inlineNodeViewClassname = "inlineNodeView";
-type NodeViewProducer = NonNullable<EditorProps['nodeViews']>[string];
-type NodeViewParams = {
-    node: Parameters<NodeViewProducer>[0];
-    view: Parameters<NodeViewProducer>[1];
-    getPos: Parameters<NodeViewProducer>[2];
-    decorations: Parameters<NodeViewProducer>[3];
-};
+type NodeViewProducer = (node: PMNode, view: EditorView, getPos: (() => GetPosReturn) | boolean, decorations: Decoration[]) => NodeView;
+type GetPosReturn = number | undefined;
 export declare function getInlineNodeViewProducer<ExtraComponentProps>({ pmPluginFactoryParams, Component, extraComponentProps, }: {
     pmPluginFactoryParams: PMPluginFactoryParams;
     Component: InlineNodeViewComponent<ExtraComponentProps>;

package/dist/types-ts4.5/react-node-view/types.d.ts

@@ -4,7 +4,7 @@ export interface ReactNodeProps {
 }
 export type ProsemirrorGetPosHandler = () => number;
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export type ReactComponentProps = {
     [key: string]: unknown;
 };

package/dist/types-ts4.5/types/editor-plugin.d.ts

@@ -88,5 +88,5 @@ export interface EditorPlugin {
     onEditorViewStateUpdated?: (props: EditorViewStateUpdatedCallbackProps) => void;
 }
 export type getPosHandler = getPosHandlerNode | boolean;
-export type getPosHandlerNode = () => number;
+export type getPosHandlerNode = () => number | undefined;
 export {};

package/dist/types-ts4.5/utils/editor-core-utils.d.ts

@@ -25,5 +25,5 @@ export declare const isLastItemMediaGroup: (node: Node) => boolean;
 export declare const setNodeSelection: (view: EditorView, pos: number) => void;
 export declare function setTextSelection(view: EditorView, anchor: number, head?: number): void;
 export declare function nonNullable<T>(value: T): value is NonNullable<T>;
-export declare const isValidPosition: (pos: number, state: EditorState) => boolean;
+export declare const isValidPosition: (pos: number | undefined, state: EditorState) => boolean;
 export declare const isInLayoutColumn: (state: EditorState) => boolean;

package/dist/types-ts4.5/utils/nodes.d.ts

@@ -25,7 +25,7 @@ export declare enum SelectedState {
  * If the node is selected then an enum is returned that describes weather the node
  * is fully selected by a range or if the "inside" of the node has been selected or clicked.
  */
-export declare const isNodeSelectedOrInRange: (anchorPosition: number, headPosition: number, nodePosition: number, nodeSize: number) => SelectedState | null;
+export declare const isNodeSelectedOrInRange: (anchorPosition: number, headPosition: number, nodePosition: number | undefined, nodeSize: number) => SelectedState | null;
 /**
  * Checks if a particular node fragment is supported in the parent
  * @param state EditorState

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "74.9.0",
+  "version": "74.9.2",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"