@atlaskit/editor-common 74.17.0 → 74.17.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-common
 
+## 74.17.1
+
+### Patch Changes
+
+- [`1a852e48b42`](https://bitbucket.org/atlassian/atlassian-frontend/commits/1a852e48b42) - [ED-17438] Check if parent node is empty paragraph before adding horizontal rule
+
 ## 74.17.0
 
 ### Minor Changes

package/dist/cjs/insert/index.js

@@ -229,7 +229,11 @@ var insertSelectedItem = function insertSelectedItem(maybeNode) {
        */
 
       var selectionInsideAPanel = selectionIsInsideAPanel(tr);
-      if (node.type.name === 'rule' && !selectionInsideAPanel) {
+      if (node.type.name === 'rule' && !selectionInsideAPanel &&
+      // ED-17438 If the selection is not an empty paragraph we want to use pmSafeInsert
+      // This fixes a bug where if a rule was inserted using safeInsert and the selection
+      // was an empty paragraph it would not be inserted
+      !(0, _utils.isEmptyParagraph)(tr.selection.$from.parent)) {
         var _safeInsert;
         tr = (_safeInsert = safeInsert(node, tr.selection.from)(tr)) !== null && _safeInsert !== void 0 ? _safeInsert : tr;
       } else {

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "74.17.0";
+var packageVersion = "74.17.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ var _templateObject, _templateObject2, _templateObject3;
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } } /** @jsx jsx */
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "74.17.0";
+var packageVersion = "74.17.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.17.0",
+	"version": "74.17.1",
 	"sideEffects": false
 }

package/dist/es2019/insert/index.js

@@ -221,7 +221,11 @@ export const insertSelectedItem = (maybeNode, opts = {}) => (state, tr, start) =
      */
 
     const selectionInsideAPanel = selectionIsInsideAPanel(tr);
-    if (node.type.name === 'rule' && !selectionInsideAPanel) {
+    if (node.type.name === 'rule' && !selectionInsideAPanel &&
+    // ED-17438 If the selection is not an empty paragraph we want to use pmSafeInsert
+    // This fixes a bug where if a rule was inserted using safeInsert and the selection
+    // was an empty paragraph it would not be inserted
+    !isEmptyParagraph(tr.selection.$from.parent)) {
       var _safeInsert;
       tr = (_safeInsert = safeInsert(node, tr.selection.from)(tr)) !== null && _safeInsert !== void 0 ? _safeInsert : tr;
     } else {

package/dist/es2019/monitoring/error.js

@@ -1,6 +1,6 @@
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "74.17.0";
+const packageVersion = "74.17.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/es2019/ui/DropList/index.js

@@ -8,7 +8,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "74.17.0";
+const packageVersion = "74.17.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 class DropList extends Component {

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.17.0",
+	"version": "74.17.1",
 	"sideEffects": false
 }

package/dist/esm/insert/index.js

@@ -219,7 +219,11 @@ export var insertSelectedItem = function insertSelectedItem(maybeNode) {
        */
 
       var selectionInsideAPanel = selectionIsInsideAPanel(tr);
-      if (node.type.name === 'rule' && !selectionInsideAPanel) {
+      if (node.type.name === 'rule' && !selectionInsideAPanel &&
+      // ED-17438 If the selection is not an empty paragraph we want to use pmSafeInsert
+      // This fixes a bug where if a rule was inserted using safeInsert and the selection
+      // was an empty paragraph it would not be inserted
+      !isEmptyParagraph(tr.selection.$from.parent)) {
         var _safeInsert;
         tr = (_safeInsert = safeInsert(node, tr.selection.from)(tr)) !== null && _safeInsert !== void 0 ? _safeInsert : tr;
       } else {

package/dist/esm/monitoring/error.js

@@ -6,7 +6,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "74.17.0";
+var packageVersion = "74.17.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // TODO: Sanitise the URL instead of just removing it

package/dist/esm/ui/DropList/index.js

@@ -18,7 +18,7 @@ import { themed } from '@atlaskit/theme/components';
 import { borderRadius } from '@atlaskit/theme/constants';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "74.17.0";
+var packageVersion = "74.17.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var DropList = /*#__PURE__*/function (_Component) {

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "74.17.0",
+	"version": "74.17.1",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-common",
-  "version": "74.17.0",
+  "version": "74.17.1",
   "description": "A package that contains common classes and components for editor and renderer",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"