@atlaskit/editor-common 134.9.0 → 134.9.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,20 @@
1
1
  # @atlaskit/editor-common
2
2
 
3
+ ## 134.9.2
4
+
5
+ ### Patch Changes
6
+
7
+ - [`49fcffc905097`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/49fcffc905097) -
8
+ Clean up experiment `platform_editor_use_vanilla_components`, keeping the shipped vanilla DOM
9
+ tooltip implementations and removing the React-based control paths.
10
+ - Updated dependencies
11
+
12
+ ## 134.9.1
13
+
14
+ ### Patch Changes
15
+
16
+ - Updated dependencies
17
+
3
18
  ## 134.9.0
4
19
 
5
20
  ### Minor Changes
@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
27
27
  var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
28
28
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
29
29
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
30
- var packageVersion = "134.8.5";
30
+ var packageVersion = "134.9.1";
31
31
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
32
32
  // Remove URL as it has UGC
33
33
  // Ignored via go/ees007
@@ -23,7 +23,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
23
23
  * @jsx jsx
24
24
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
25
25
  var packageName = "@atlaskit/editor-common";
26
- var packageVersion = "134.8.5";
26
+ var packageVersion = "134.9.1";
27
27
  var halfFocusRing = 1;
28
28
  var dropOffset = '0, 8';
29
29
  // Ignored via go/ees005
@@ -9,7 +9,6 @@ var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/cl
9
9
  var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
10
10
  var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
11
11
  var _bindEventListener = require("bind-event-listener");
12
- var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
13
12
  var _unsafeImperative = require("@atlaskit/popper/unsafe-imperative");
14
13
  var _error = require("../monitoring/error");
15
14
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
@@ -132,12 +131,9 @@ var VanillaTooltip = exports.VanillaTooltip = /*#__PURE__*/function () {
132
131
  this.timeout = timeout;
133
132
  this.onShow = onShow;
134
133
  this.placement = placement;
135
- this.hoistContainer = hoistContainer;
136
134
  // Created in the trigger's own document rather than the global one, so nothing depends on
137
- // the parent realm when the editor renders inside an iframe. Gated alongside the Escape
138
- // listener's window so the whole iframe fix moves as a single unit.
139
- var ownerDocument = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components') ? trigger.ownerDocument : document;
140
- var tooltip = ownerDocument.createElement('span');
135
+ // the parent realm when the editor renders inside an iframe.
136
+ var tooltip = trigger.ownerDocument.createElement('span');
141
137
  tooltip.role = 'tooltip';
142
138
  // eslint-disable-next-line @atlaskit/design-system/no-native-popover-or-dialog -- a plain DOM tooltip for ProseMirror that hides on Escape with its own window listener, outside the shared Escape stack; TODO move to a top-layer primitive
143
139
  tooltip.popover = 'hint';
@@ -146,9 +142,7 @@ var VanillaTooltip = exports.VanillaTooltip = /*#__PURE__*/function () {
146
142
  tooltip.textContent = content;
147
143
 
148
144
  // A tooltip is never a hit target. Set before the caller's styles so it can be overridden.
149
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
150
- tooltip.style.pointerEvents = 'none';
151
- }
145
+ tooltip.style.pointerEvents = 'none';
152
146
  if (styles) {
153
147
  Object.assign(tooltip.style, styles);
154
148
  }
@@ -175,52 +169,25 @@ var VanillaTooltip = exports.VanillaTooltip = /*#__PURE__*/function () {
175
169
  }));
176
170
  });
177
171
 
178
- // Bound for this tooltip's whole lifetime, even while it is off screen. The experiment
179
- // moves this to `show()` so nothing is retained at rest.
180
- if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
181
- this.listeners.push((0, _bindEventListener.bind)(window, {
182
- type: 'keydown',
183
- listener: function listener(e) {
184
- if (e.key === 'Escape') {
185
- _this.hide(true);
186
- }
187
- }
188
- }));
189
- }
190
-
191
172
  // Resets `isDisplayed` when the browser closes the popover without going through `hide()`
192
173
  // (e.g. light-dismissal). Prevents the guard in `show()` from becoming stale.
193
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
194
- this.listeners.push((0, _bindEventListener.bind)(tooltip, {
195
- type: 'toggle',
196
- listener: function listener(event) {
197
- if (event.newState === 'closed') {
198
- _this.isDisplayed = false;
199
- // Cancel a pending show, which would otherwise mark a closed popover as
200
- // displayed and announce a tooltip the user never saw.
201
- //
202
- // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
203
- // is false exactly when the pending timeout is a show. A pending hide
204
- // must survive: it still has the positioning instance to release.
205
- if (!_this.shouldHidePopover && _this.currentTimeoutId !== undefined) {
206
- clearTimeout(_this.currentTimeoutId);
207
- }
174
+ this.listeners.push((0, _bindEventListener.bind)(tooltip, {
175
+ type: 'toggle',
176
+ listener: function listener(event) {
177
+ if (event.newState === 'closed') {
178
+ _this.isDisplayed = false;
179
+ // Cancel a pending show, which would otherwise mark a closed popover as
180
+ // displayed and announce a tooltip the user never saw.
181
+ //
182
+ // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
183
+ // is false exactly when the pending timeout is a show. A pending hide
184
+ // must survive: it still has the positioning instance to release.
185
+ if (!_this.shouldHidePopover && _this.currentTimeoutId !== undefined) {
186
+ clearTimeout(_this.currentTimeoutId);
208
187
  }
209
188
  }
210
- }));
211
- }
212
-
213
- // Hide the tooltip if the hide transition has completed.
214
- //
215
- // Only reachable in the control arm: no consumer declares a transition on the tooltip, so
216
- // this never fires today, and the experiment closes the popover in `hide()` regardless.
217
- if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
218
- this.tooltip.ontransitionend = function () {
219
- if (_this.shouldHidePopover) {
220
- _this.tooltip.hidePopover();
221
- }
222
- };
223
- }
189
+ }
190
+ }));
224
191
  }
225
192
 
226
193
  /**
@@ -299,19 +266,17 @@ var VanillaTooltip = exports.VanillaTooltip = /*#__PURE__*/function () {
299
266
  });
300
267
 
301
268
  // Undoes what the constructor added to the trigger, matching the React `@atlaskit/tooltip`
302
- // callers are moving off, whose unmount took its DOM with it. A hoisted tooltip is removed
303
- // either way: it sits outside the trigger, so nothing else takes it away with it.
304
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components') || this.hoistContainer) {
305
- // A popover removed while still showing is never light-dismissed, so the top layer
306
- // keeps treating it as open.
307
- this.closePopover();
308
- this.tooltip.remove();
309
- if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
310
- this.trigger.removeAttribute('aria-describedby');
311
- }
312
- if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
313
- this.trigger.removeAttribute('popovertarget');
314
- }
269
+ // callers are moving off, whose unmount took its DOM with it.
270
+ //
271
+ // A popover removed while still showing is never light-dismissed, so the top layer
272
+ // keeps treating it as open.
273
+ this.closePopover();
274
+ this.tooltip.remove();
275
+ if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
276
+ this.trigger.removeAttribute('aria-describedby');
277
+ }
278
+ if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
279
+ this.trigger.removeAttribute('popovertarget');
315
280
  }
316
281
  }
317
282
 
@@ -364,79 +329,47 @@ var VanillaTooltip = exports.VanillaTooltip = /*#__PURE__*/function () {
364
329
  this.shouldHidePopover = true;
365
330
  // Disable the event listeners
366
331
  this.currentTimeoutId = setTimeout(function () {
367
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
368
- var _this3$popperInstance;
369
- // Released rather than reconfigured. The instance was previously kept for the
370
- // trigger's whole lifetime, so every element the pointer passed over retained
371
- // one — and an instance owns a detached React root, so that was a retained
372
- // root per hovered trigger.
373
- //
374
- // Destroying is also the only way to release that root's capture-phase
375
- // `scroll`/`resize` listeners, where the `eventListeners: false`
376
- // reconfiguration in the control arm is accepted but does nothing.
377
- (_this3$popperInstance = _this3.popperInstance) === null || _this3$popperInstance === void 0 || _this3$popperInstance.destroy();
378
- _this3.popperInstance = undefined;
379
- _this3.tooltip.style.opacity = '0';
380
- _this3.isDisplayed = false;
332
+ var _this3$popperInstance;
333
+ // Released rather than reconfigured. The instance was previously kept for the
334
+ // trigger's whole lifetime, so every element the pointer passed over retained
335
+ // one — and an instance owns a detached React root, so that was a retained
336
+ // root per hovered trigger.
337
+ //
338
+ // Destroying is also the only way to release that root's capture-phase
339
+ // `scroll`/`resize` listeners, where an `eventListeners: false`
340
+ // reconfiguration is accepted but does nothing.
341
+ (_this3$popperInstance = _this3.popperInstance) === null || _this3$popperInstance === void 0 || _this3$popperInstance.destroy();
342
+ _this3.popperInstance = undefined;
343
+ _this3.tooltip.style.opacity = '0';
344
+ _this3.isDisplayed = false;
381
345
 
382
- // Closed here rather than from `ontransitionend`. No consumer declares a
383
- // transition on the tooltip, so that event never fires and the popover would
384
- // otherwise stay open in the top layer for good.
385
- _this3.closePopover();
386
- // Paired with the `visibility` that `show()` sets, so a popover left open by
387
- // a failed close cannot intercept pointer events over the content.
388
- _this3.tooltip.style.visibility = 'hidden';
389
- } else {
390
- var _this3$popperInstance2;
391
- (_this3$popperInstance2 = _this3.popperInstance) === null || _this3$popperInstance2 === void 0 || _this3$popperInstance2.setOptions(function (options) {
392
- return _objectSpread(_objectSpread({}, options), {}, {
393
- modifiers: [startingOffset, {
394
- name: 'eventListeners',
395
- enabled: false
396
- }]
397
- });
398
- });
399
- _this3.tooltip.style.opacity = '0';
400
- _this3.isDisplayed = false;
401
- // If transition animations are disabled immediately hide the popover
402
- if (_this3.tooltip.style.transition === 'none') {
403
- _this3.tooltip.hidePopover();
404
- }
405
- }
346
+ // Closed here rather than from a transition end. No consumer declares a
347
+ // transition on the tooltip, so that event never fires and the popover would
348
+ // otherwise stay open in the top layer for good.
349
+ _this3.closePopover();
350
+ // Paired with the `visibility` that `show()` sets, so a popover left open by
351
+ // a failed close cannot intercept pointer events over the content.
352
+ _this3.tooltip.style.visibility = 'hidden';
406
353
  }, immediate ? 0 : this.timeout);
407
354
  }
408
355
  }, {
409
356
  key: "show",
410
357
  value: function show() {
411
358
  var _this4 = this;
412
- // Ahead of the `isDisplayed` guard, unlike the equivalent below: `hide()` takes effect
413
- // synchronously but leaves the tooltip on screen until its timeout, so a pointer
414
- // returning in that window finds `isDisplayed` still true and returns early. Cancelling
415
- // first keeps the tooltip up and stops it being left undismissable with a hide pending.
416
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
417
- this.bindEscapeListener();
418
- clearTimeout(this.currentTimeoutId);
419
- this.shouldHidePopover = false;
420
- }
359
+ // Ahead of the `isDisplayed` guard: `hide()` takes effect synchronously but leaves the
360
+ // tooltip on screen until its timeout, so a pointer returning in that window finds
361
+ // `isDisplayed` still true and returns early. Cancelling first keeps the tooltip up and
362
+ // stops it being left undismissable with a hide pending.
363
+ this.bindEscapeListener();
364
+ clearTimeout(this.currentTimeoutId);
365
+ this.shouldHidePopover = false;
421
366
  if (this.isDisplayed) {
422
367
  return;
423
368
  }
424
369
 
425
- // Control only: the experiment cancels above, ahead of the guard. Kept gated rather than
426
- // left unconditional — despite being a no-op once the block above has run — so that
427
- // experiment cleanup can delete it outright instead of having to reason about it.
428
- if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
429
- clearTimeout(this.currentTimeoutId);
430
- this.shouldHidePopover = false;
431
- }
432
-
433
370
  // Make the tooltip visible - but hide until
434
371
  this.tooltip.style.visibility = 'hidden';
435
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_use_vanilla_components')) {
436
- this.openPopover();
437
- } else {
438
- this.tooltip.showPopover();
439
- }
372
+ this.openPopover();
440
373
 
441
374
  // Update its position
442
375
  if (!this.popperInstance) {
@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
13
13
  const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
14
14
  const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
15
15
  const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
16
- const packageVersion = "134.8.5";
16
+ const packageVersion = "134.9.1";
17
17
  const sanitiseSentryEvents = (data, _hint) => {
18
18
  // Remove URL as it has UGC
19
19
  // Ignored via go/ees007
@@ -13,7 +13,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
13
13
  import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
14
14
  import Layer from '../Layer';
15
15
  const packageName = "@atlaskit/editor-common";
16
- const packageVersion = "134.8.5";
16
+ const packageVersion = "134.9.1";
17
17
  const halfFocusRing = 1;
18
18
  const dropOffset = '0, 8';
19
19
  // Ignored via go/ees005
@@ -2,7 +2,6 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
2
2
  // eslint-disable-next-line @atlaskit/design-system/no-third-party-layering -- existing usage from before this rule was added
3
3
 
4
4
  import { bind } from 'bind-event-listener';
5
- import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
6
5
  import { createPopper } from '@atlaskit/popper/unsafe-imperative';
7
6
  import { logException } from '../monitoring/error';
8
7
  const startingOffset = {
@@ -121,12 +120,9 @@ export class VanillaTooltip {
121
120
  this.timeout = timeout;
122
121
  this.onShow = onShow;
123
122
  this.placement = placement;
124
- this.hoistContainer = hoistContainer;
125
123
  // Created in the trigger's own document rather than the global one, so nothing depends on
126
- // the parent realm when the editor renders inside an iframe. Gated alongside the Escape
127
- // listener's window so the whole iframe fix moves as a single unit.
128
- const ownerDocument = isExperimentEnabled('platform_editor_use_vanilla_components') ? trigger.ownerDocument : document;
129
- const tooltip = ownerDocument.createElement('span');
124
+ // the parent realm when the editor renders inside an iframe.
125
+ const tooltip = trigger.ownerDocument.createElement('span');
130
126
  tooltip.role = 'tooltip';
131
127
  // eslint-disable-next-line @atlaskit/design-system/no-native-popover-or-dialog -- a plain DOM tooltip for ProseMirror that hides on Escape with its own window listener, outside the shared Escape stack; TODO move to a top-layer primitive
132
128
  tooltip.popover = 'hint';
@@ -135,9 +131,7 @@ export class VanillaTooltip {
135
131
  tooltip.textContent = content;
136
132
 
137
133
  // A tooltip is never a hit target. Set before the caller's styles so it can be overridden.
138
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
139
- tooltip.style.pointerEvents = 'none';
140
- }
134
+ tooltip.style.pointerEvents = 'none';
141
135
  if (styles) {
142
136
  Object.assign(tooltip.style, styles);
143
137
  }
@@ -160,52 +154,25 @@ export class VanillaTooltip {
160
154
  }));
161
155
  });
162
156
 
163
- // Bound for this tooltip's whole lifetime, even while it is off screen. The experiment
164
- // moves this to `show()` so nothing is retained at rest.
165
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
166
- this.listeners.push(bind(window, {
167
- type: 'keydown',
168
- listener: e => {
169
- if (e.key === 'Escape') {
170
- this.hide(true);
171
- }
172
- }
173
- }));
174
- }
175
-
176
157
  // Resets `isDisplayed` when the browser closes the popover without going through `hide()`
177
158
  // (e.g. light-dismissal). Prevents the guard in `show()` from becoming stale.
178
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
179
- this.listeners.push(bind(tooltip, {
180
- type: 'toggle',
181
- listener: event => {
182
- if (event.newState === 'closed') {
183
- this.isDisplayed = false;
184
- // Cancel a pending show, which would otherwise mark a closed popover as
185
- // displayed and announce a tooltip the user never saw.
186
- //
187
- // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
188
- // is false exactly when the pending timeout is a show. A pending hide
189
- // must survive: it still has the positioning instance to release.
190
- if (!this.shouldHidePopover && this.currentTimeoutId !== undefined) {
191
- clearTimeout(this.currentTimeoutId);
192
- }
159
+ this.listeners.push(bind(tooltip, {
160
+ type: 'toggle',
161
+ listener: event => {
162
+ if (event.newState === 'closed') {
163
+ this.isDisplayed = false;
164
+ // Cancel a pending show, which would otherwise mark a closed popover as
165
+ // displayed and announce a tooltip the user never saw.
166
+ //
167
+ // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
168
+ // is false exactly when the pending timeout is a show. A pending hide
169
+ // must survive: it still has the positioning instance to release.
170
+ if (!this.shouldHidePopover && this.currentTimeoutId !== undefined) {
171
+ clearTimeout(this.currentTimeoutId);
193
172
  }
194
173
  }
195
- }));
196
- }
197
-
198
- // Hide the tooltip if the hide transition has completed.
199
- //
200
- // Only reachable in the control arm: no consumer declares a transition on the tooltip, so
201
- // this never fires today, and the experiment closes the popover in `hide()` regardless.
202
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
203
- this.tooltip.ontransitionend = () => {
204
- if (this.shouldHidePopover) {
205
- this.tooltip.hidePopover();
206
- }
207
- };
208
- }
174
+ }
175
+ }));
209
176
  }
210
177
 
211
178
  /**
@@ -274,19 +241,17 @@ export class VanillaTooltip {
274
241
  });
275
242
 
276
243
  // Undoes what the constructor added to the trigger, matching the React `@atlaskit/tooltip`
277
- // callers are moving off, whose unmount took its DOM with it. A hoisted tooltip is removed
278
- // either way: it sits outside the trigger, so nothing else takes it away with it.
279
- if (isExperimentEnabled('platform_editor_use_vanilla_components') || this.hoistContainer) {
280
- // A popover removed while still showing is never light-dismissed, so the top layer
281
- // keeps treating it as open.
282
- this.closePopover();
283
- this.tooltip.remove();
284
- if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
285
- this.trigger.removeAttribute('aria-describedby');
286
- }
287
- if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
288
- this.trigger.removeAttribute('popovertarget');
289
- }
244
+ // callers are moving off, whose unmount took its DOM with it.
245
+ //
246
+ // A popover removed while still showing is never light-dismissed, so the top layer
247
+ // keeps treating it as open.
248
+ this.closePopover();
249
+ this.tooltip.remove();
250
+ if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
251
+ this.trigger.removeAttribute('aria-describedby');
252
+ }
253
+ if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
254
+ this.trigger.removeAttribute('popovertarget');
290
255
  }
291
256
  }
292
257
 
@@ -330,75 +295,44 @@ export class VanillaTooltip {
330
295
  this.shouldHidePopover = true;
331
296
  // Disable the event listeners
332
297
  this.currentTimeoutId = setTimeout(() => {
333
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
334
- var _this$popperInstance2;
335
- // Released rather than reconfigured. The instance was previously kept for the
336
- // trigger's whole lifetime, so every element the pointer passed over retained
337
- // one — and an instance owns a detached React root, so that was a retained
338
- // root per hovered trigger.
339
- //
340
- // Destroying is also the only way to release that root's capture-phase
341
- // `scroll`/`resize` listeners, where the `eventListeners: false`
342
- // reconfiguration in the control arm is accepted but does nothing.
343
- (_this$popperInstance2 = this.popperInstance) === null || _this$popperInstance2 === void 0 ? void 0 : _this$popperInstance2.destroy();
344
- this.popperInstance = undefined;
345
- this.tooltip.style.opacity = '0';
346
- this.isDisplayed = false;
298
+ var _this$popperInstance2;
299
+ // Released rather than reconfigured. The instance was previously kept for the
300
+ // trigger's whole lifetime, so every element the pointer passed over retained
301
+ // one — and an instance owns a detached React root, so that was a retained
302
+ // root per hovered trigger.
303
+ //
304
+ // Destroying is also the only way to release that root's capture-phase
305
+ // `scroll`/`resize` listeners, where an `eventListeners: false`
306
+ // reconfiguration is accepted but does nothing.
307
+ (_this$popperInstance2 = this.popperInstance) === null || _this$popperInstance2 === void 0 ? void 0 : _this$popperInstance2.destroy();
308
+ this.popperInstance = undefined;
309
+ this.tooltip.style.opacity = '0';
310
+ this.isDisplayed = false;
347
311
 
348
- // Closed here rather than from `ontransitionend`. No consumer declares a
349
- // transition on the tooltip, so that event never fires and the popover would
350
- // otherwise stay open in the top layer for good.
351
- this.closePopover();
352
- // Paired with the `visibility` that `show()` sets, so a popover left open by
353
- // a failed close cannot intercept pointer events over the content.
354
- this.tooltip.style.visibility = 'hidden';
355
- } else {
356
- var _this$popperInstance3;
357
- (_this$popperInstance3 = this.popperInstance) === null || _this$popperInstance3 === void 0 ? void 0 : _this$popperInstance3.setOptions(options => ({
358
- ...options,
359
- modifiers: [startingOffset, {
360
- name: 'eventListeners',
361
- enabled: false
362
- }]
363
- }));
364
- this.tooltip.style.opacity = '0';
365
- this.isDisplayed = false;
366
- // If transition animations are disabled immediately hide the popover
367
- if (this.tooltip.style.transition === 'none') {
368
- this.tooltip.hidePopover();
369
- }
370
- }
312
+ // Closed here rather than from a transition end. No consumer declares a
313
+ // transition on the tooltip, so that event never fires and the popover would
314
+ // otherwise stay open in the top layer for good.
315
+ this.closePopover();
316
+ // Paired with the `visibility` that `show()` sets, so a popover left open by
317
+ // a failed close cannot intercept pointer events over the content.
318
+ this.tooltip.style.visibility = 'hidden';
371
319
  }, immediate ? 0 : this.timeout);
372
320
  }
373
321
  show() {
374
- // Ahead of the `isDisplayed` guard, unlike the equivalent below: `hide()` takes effect
375
- // synchronously but leaves the tooltip on screen until its timeout, so a pointer
376
- // returning in that window finds `isDisplayed` still true and returns early. Cancelling
377
- // first keeps the tooltip up and stops it being left undismissable with a hide pending.
378
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
379
- this.bindEscapeListener();
380
- clearTimeout(this.currentTimeoutId);
381
- this.shouldHidePopover = false;
382
- }
322
+ // Ahead of the `isDisplayed` guard: `hide()` takes effect synchronously but leaves the
323
+ // tooltip on screen until its timeout, so a pointer returning in that window finds
324
+ // `isDisplayed` still true and returns early. Cancelling first keeps the tooltip up and
325
+ // stops it being left undismissable with a hide pending.
326
+ this.bindEscapeListener();
327
+ clearTimeout(this.currentTimeoutId);
328
+ this.shouldHidePopover = false;
383
329
  if (this.isDisplayed) {
384
330
  return;
385
331
  }
386
332
 
387
- // Control only: the experiment cancels above, ahead of the guard. Kept gated rather than
388
- // left unconditional — despite being a no-op once the block above has run — so that
389
- // experiment cleanup can delete it outright instead of having to reason about it.
390
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
391
- clearTimeout(this.currentTimeoutId);
392
- this.shouldHidePopover = false;
393
- }
394
-
395
333
  // Make the tooltip visible - but hide until
396
334
  this.tooltip.style.visibility = 'hidden';
397
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
398
- this.openPopover();
399
- } else {
400
- this.tooltip.showPopover();
401
- }
335
+ this.openPopover();
402
336
 
403
337
  // Update its position
404
338
  if (!this.popperInstance) {
@@ -409,10 +343,10 @@ export class VanillaTooltip {
409
343
 
410
344
  // Enable the event listeners
411
345
  this.currentTimeoutId = setTimeout(() => {
412
- var _this$popperInstance4, _this$onShow;
346
+ var _this$popperInstance3, _this$onShow;
413
347
  this.tooltip.style.opacity = '1';
414
348
  this.tooltip.style.visibility = 'visible';
415
- (_this$popperInstance4 = this.popperInstance) === null || _this$popperInstance4 === void 0 ? void 0 : _this$popperInstance4.setOptions(options => ({
349
+ (_this$popperInstance3 = this.popperInstance) === null || _this$popperInstance3 === void 0 ? void 0 : _this$popperInstance3.setOptions(options => ({
416
350
  ...options,
417
351
  modifiers: [endingOffset, {
418
352
  name: 'eventListeners',
@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
19
19
  var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
20
20
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
21
21
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
22
- var packageVersion = "134.8.5";
22
+ var packageVersion = "134.9.1";
23
23
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
24
24
  // Remove URL as it has UGC
25
25
  // Ignored via go/ees007
@@ -20,7 +20,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
20
20
  import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
21
21
  import Layer from '../Layer';
22
22
  var packageName = "@atlaskit/editor-common";
23
- var packageVersion = "134.8.5";
23
+ var packageVersion = "134.9.1";
24
24
  var halfFocusRing = 1;
25
25
  var dropOffset = '0, 8';
26
26
  // Ignored via go/ees005
@@ -6,7 +6,6 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
6
6
  // eslint-disable-next-line @atlaskit/design-system/no-third-party-layering -- existing usage from before this rule was added
7
7
 
8
8
  import { bind } from 'bind-event-listener';
9
- import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
10
9
  import { createPopper } from '@atlaskit/popper/unsafe-imperative';
11
10
  import { logException } from '../monitoring/error';
12
11
  var startingOffset = {
@@ -127,12 +126,9 @@ export var VanillaTooltip = /*#__PURE__*/function () {
127
126
  this.timeout = timeout;
128
127
  this.onShow = onShow;
129
128
  this.placement = placement;
130
- this.hoistContainer = hoistContainer;
131
129
  // Created in the trigger's own document rather than the global one, so nothing depends on
132
- // the parent realm when the editor renders inside an iframe. Gated alongside the Escape
133
- // listener's window so the whole iframe fix moves as a single unit.
134
- var ownerDocument = isExperimentEnabled('platform_editor_use_vanilla_components') ? trigger.ownerDocument : document;
135
- var tooltip = ownerDocument.createElement('span');
130
+ // the parent realm when the editor renders inside an iframe.
131
+ var tooltip = trigger.ownerDocument.createElement('span');
136
132
  tooltip.role = 'tooltip';
137
133
  // eslint-disable-next-line @atlaskit/design-system/no-native-popover-or-dialog -- a plain DOM tooltip for ProseMirror that hides on Escape with its own window listener, outside the shared Escape stack; TODO move to a top-layer primitive
138
134
  tooltip.popover = 'hint';
@@ -141,9 +137,7 @@ export var VanillaTooltip = /*#__PURE__*/function () {
141
137
  tooltip.textContent = content;
142
138
 
143
139
  // A tooltip is never a hit target. Set before the caller's styles so it can be overridden.
144
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
145
- tooltip.style.pointerEvents = 'none';
146
- }
140
+ tooltip.style.pointerEvents = 'none';
147
141
  if (styles) {
148
142
  Object.assign(tooltip.style, styles);
149
143
  }
@@ -170,52 +164,25 @@ export var VanillaTooltip = /*#__PURE__*/function () {
170
164
  }));
171
165
  });
172
166
 
173
- // Bound for this tooltip's whole lifetime, even while it is off screen. The experiment
174
- // moves this to `show()` so nothing is retained at rest.
175
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
176
- this.listeners.push(bind(window, {
177
- type: 'keydown',
178
- listener: function listener(e) {
179
- if (e.key === 'Escape') {
180
- _this.hide(true);
181
- }
182
- }
183
- }));
184
- }
185
-
186
167
  // Resets `isDisplayed` when the browser closes the popover without going through `hide()`
187
168
  // (e.g. light-dismissal). Prevents the guard in `show()` from becoming stale.
188
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
189
- this.listeners.push(bind(tooltip, {
190
- type: 'toggle',
191
- listener: function listener(event) {
192
- if (event.newState === 'closed') {
193
- _this.isDisplayed = false;
194
- // Cancel a pending show, which would otherwise mark a closed popover as
195
- // displayed and announce a tooltip the user never saw.
196
- //
197
- // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
198
- // is false exactly when the pending timeout is a show. A pending hide
199
- // must survive: it still has the positioning instance to release.
200
- if (!_this.shouldHidePopover && _this.currentTimeoutId !== undefined) {
201
- clearTimeout(_this.currentTimeoutId);
202
- }
169
+ this.listeners.push(bind(tooltip, {
170
+ type: 'toggle',
171
+ listener: function listener(event) {
172
+ if (event.newState === 'closed') {
173
+ _this.isDisplayed = false;
174
+ // Cancel a pending show, which would otherwise mark a closed popover as
175
+ // displayed and announce a tooltip the user never saw.
176
+ //
177
+ // `shouldHidePopover` is set by `hide()` and cleared by `show()`, so it
178
+ // is false exactly when the pending timeout is a show. A pending hide
179
+ // must survive: it still has the positioning instance to release.
180
+ if (!_this.shouldHidePopover && _this.currentTimeoutId !== undefined) {
181
+ clearTimeout(_this.currentTimeoutId);
203
182
  }
204
183
  }
205
- }));
206
- }
207
-
208
- // Hide the tooltip if the hide transition has completed.
209
- //
210
- // Only reachable in the control arm: no consumer declares a transition on the tooltip, so
211
- // this never fires today, and the experiment closes the popover in `hide()` regardless.
212
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
213
- this.tooltip.ontransitionend = function () {
214
- if (_this.shouldHidePopover) {
215
- _this.tooltip.hidePopover();
216
- }
217
- };
218
- }
184
+ }
185
+ }));
219
186
  }
220
187
 
221
188
  /**
@@ -294,19 +261,17 @@ export var VanillaTooltip = /*#__PURE__*/function () {
294
261
  });
295
262
 
296
263
  // Undoes what the constructor added to the trigger, matching the React `@atlaskit/tooltip`
297
- // callers are moving off, whose unmount took its DOM with it. A hoisted tooltip is removed
298
- // either way: it sits outside the trigger, so nothing else takes it away with it.
299
- if (isExperimentEnabled('platform_editor_use_vanilla_components') || this.hoistContainer) {
300
- // A popover removed while still showing is never light-dismissed, so the top layer
301
- // keeps treating it as open.
302
- this.closePopover();
303
- this.tooltip.remove();
304
- if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
305
- this.trigger.removeAttribute('aria-describedby');
306
- }
307
- if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
308
- this.trigger.removeAttribute('popovertarget');
309
- }
264
+ // callers are moving off, whose unmount took its DOM with it.
265
+ //
266
+ // A popover removed while still showing is never light-dismissed, so the top layer
267
+ // keeps treating it as open.
268
+ this.closePopover();
269
+ this.tooltip.remove();
270
+ if (this.trigger.getAttribute('aria-describedby') === this.tooltip.id) {
271
+ this.trigger.removeAttribute('aria-describedby');
272
+ }
273
+ if (this.trigger.getAttribute('popovertarget') === this.tooltip.id) {
274
+ this.trigger.removeAttribute('popovertarget');
310
275
  }
311
276
  }
312
277
 
@@ -359,79 +324,47 @@ export var VanillaTooltip = /*#__PURE__*/function () {
359
324
  this.shouldHidePopover = true;
360
325
  // Disable the event listeners
361
326
  this.currentTimeoutId = setTimeout(function () {
362
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
363
- var _this3$popperInstance;
364
- // Released rather than reconfigured. The instance was previously kept for the
365
- // trigger's whole lifetime, so every element the pointer passed over retained
366
- // one — and an instance owns a detached React root, so that was a retained
367
- // root per hovered trigger.
368
- //
369
- // Destroying is also the only way to release that root's capture-phase
370
- // `scroll`/`resize` listeners, where the `eventListeners: false`
371
- // reconfiguration in the control arm is accepted but does nothing.
372
- (_this3$popperInstance = _this3.popperInstance) === null || _this3$popperInstance === void 0 || _this3$popperInstance.destroy();
373
- _this3.popperInstance = undefined;
374
- _this3.tooltip.style.opacity = '0';
375
- _this3.isDisplayed = false;
327
+ var _this3$popperInstance;
328
+ // Released rather than reconfigured. The instance was previously kept for the
329
+ // trigger's whole lifetime, so every element the pointer passed over retained
330
+ // one — and an instance owns a detached React root, so that was a retained
331
+ // root per hovered trigger.
332
+ //
333
+ // Destroying is also the only way to release that root's capture-phase
334
+ // `scroll`/`resize` listeners, where an `eventListeners: false`
335
+ // reconfiguration is accepted but does nothing.
336
+ (_this3$popperInstance = _this3.popperInstance) === null || _this3$popperInstance === void 0 || _this3$popperInstance.destroy();
337
+ _this3.popperInstance = undefined;
338
+ _this3.tooltip.style.opacity = '0';
339
+ _this3.isDisplayed = false;
376
340
 
377
- // Closed here rather than from `ontransitionend`. No consumer declares a
378
- // transition on the tooltip, so that event never fires and the popover would
379
- // otherwise stay open in the top layer for good.
380
- _this3.closePopover();
381
- // Paired with the `visibility` that `show()` sets, so a popover left open by
382
- // a failed close cannot intercept pointer events over the content.
383
- _this3.tooltip.style.visibility = 'hidden';
384
- } else {
385
- var _this3$popperInstance2;
386
- (_this3$popperInstance2 = _this3.popperInstance) === null || _this3$popperInstance2 === void 0 || _this3$popperInstance2.setOptions(function (options) {
387
- return _objectSpread(_objectSpread({}, options), {}, {
388
- modifiers: [startingOffset, {
389
- name: 'eventListeners',
390
- enabled: false
391
- }]
392
- });
393
- });
394
- _this3.tooltip.style.opacity = '0';
395
- _this3.isDisplayed = false;
396
- // If transition animations are disabled immediately hide the popover
397
- if (_this3.tooltip.style.transition === 'none') {
398
- _this3.tooltip.hidePopover();
399
- }
400
- }
341
+ // Closed here rather than from a transition end. No consumer declares a
342
+ // transition on the tooltip, so that event never fires and the popover would
343
+ // otherwise stay open in the top layer for good.
344
+ _this3.closePopover();
345
+ // Paired with the `visibility` that `show()` sets, so a popover left open by
346
+ // a failed close cannot intercept pointer events over the content.
347
+ _this3.tooltip.style.visibility = 'hidden';
401
348
  }, immediate ? 0 : this.timeout);
402
349
  }
403
350
  }, {
404
351
  key: "show",
405
352
  value: function show() {
406
353
  var _this4 = this;
407
- // Ahead of the `isDisplayed` guard, unlike the equivalent below: `hide()` takes effect
408
- // synchronously but leaves the tooltip on screen until its timeout, so a pointer
409
- // returning in that window finds `isDisplayed` still true and returns early. Cancelling
410
- // first keeps the tooltip up and stops it being left undismissable with a hide pending.
411
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
412
- this.bindEscapeListener();
413
- clearTimeout(this.currentTimeoutId);
414
- this.shouldHidePopover = false;
415
- }
354
+ // Ahead of the `isDisplayed` guard: `hide()` takes effect synchronously but leaves the
355
+ // tooltip on screen until its timeout, so a pointer returning in that window finds
356
+ // `isDisplayed` still true and returns early. Cancelling first keeps the tooltip up and
357
+ // stops it being left undismissable with a hide pending.
358
+ this.bindEscapeListener();
359
+ clearTimeout(this.currentTimeoutId);
360
+ this.shouldHidePopover = false;
416
361
  if (this.isDisplayed) {
417
362
  return;
418
363
  }
419
364
 
420
- // Control only: the experiment cancels above, ahead of the guard. Kept gated rather than
421
- // left unconditional — despite being a no-op once the block above has run — so that
422
- // experiment cleanup can delete it outright instead of having to reason about it.
423
- if (!isExperimentEnabled('platform_editor_use_vanilla_components')) {
424
- clearTimeout(this.currentTimeoutId);
425
- this.shouldHidePopover = false;
426
- }
427
-
428
365
  // Make the tooltip visible - but hide until
429
366
  this.tooltip.style.visibility = 'hidden';
430
- if (isExperimentEnabled('platform_editor_use_vanilla_components')) {
431
- this.openPopover();
432
- } else {
433
- this.tooltip.showPopover();
434
- }
367
+ this.openPopover();
435
368
 
436
369
  // Update its position
437
370
  if (!this.popperInstance) {
@@ -40,21 +40,6 @@ export declare class VanillaTooltip {
40
40
  * `'bottom'` to match its `position="mouse"`, which places the tooltip below the cursor.
41
41
  */
42
42
  private placement;
43
- /**
44
- * Where to append the tooltip, instead of inside the trigger.
45
- *
46
- * Pass a container when anything between the trigger and the viewport is transformed. The
47
- * browser resolves a top-layer popover's position against the viewport, while Popper — which
48
- * reads `offsetParent`, and gets `null` for anything in the top layer — falls back to the
49
- * nearest ancestor with a `transform`. Inside a wide image that ancestor is `.rich-media-item`,
50
- * whose `translateX(-50%)` threw the tooltip off screen (EDITOR-8971). Appended to a container
51
- * with no transform above it, the two measure from the same origin.
52
- *
53
- * Opt-in per caller: the tooltip leaves the trigger's subtree, so anything styling it through
54
- * an ancestor stops matching — including `VANILLA_TOOLTIP_DEFAULT_CLASS`, whose rule is scoped
55
- * under `.ProseMirror`. Pass `styles` for the look instead.
56
- */
57
- private hoistContainer?;
58
43
  private popperInstance;
59
44
  private listeners;
60
45
  private currentTimeoutId;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-common",
3
- "version": "134.9.0",
3
+ "version": "134.9.2",
4
4
  "description": "A package that contains common classes and components for editor and renderer",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -41,7 +41,7 @@
41
41
  "@atlaskit/codemod-utils": "^5.2.0",
42
42
  "@atlaskit/css": "^1.1.0",
43
43
  "@atlaskit/custom-steps": "^1.1.0",
44
- "@atlaskit/dropdown-menu": "^21.0.0",
44
+ "@atlaskit/dropdown-menu": "^21.1.0",
45
45
  "@atlaskit/editor-json-transformer": "^10.0.0",
46
46
  "@atlaskit/editor-palette": "^3.5.0",
47
47
  "@atlaskit/editor-prosemirror": "^9.0.0",
@@ -54,15 +54,15 @@
54
54
  "@atlaskit/feature-gate-js-client": "^8.0.0",
55
55
  "@atlaskit/icon": "^38.0.0",
56
56
  "@atlaskit/link": "^5.1.0",
57
- "@atlaskit/link-datasource": "^7.12.0",
57
+ "@atlaskit/link-datasource": "^7.13.0",
58
58
  "@atlaskit/link-picker": "^6.20.0",
59
59
  "@atlaskit/logo": "^23.3.0",
60
- "@atlaskit/media-card": "^82.2.0",
61
- "@atlaskit/media-client": "^39.3.0",
60
+ "@atlaskit/media-card": "^82.3.0",
61
+ "@atlaskit/media-client": "^39.4.0",
62
62
  "@atlaskit/media-client-react": "^7.0.0",
63
63
  "@atlaskit/media-common": "^14.7.0",
64
64
  "@atlaskit/media-file-preview": "^2.0.0",
65
- "@atlaskit/media-picker": "^73.2.0",
65
+ "@atlaskit/media-picker": "^73.3.0",
66
66
  "@atlaskit/media-ui": "^31.6.0",
67
67
  "@atlaskit/media-viewer": "^54.12.0",
68
68
  "@atlaskit/mention": "^30.7.0",
@@ -73,7 +73,7 @@
73
73
  "@atlaskit/platform-feature-flags": "^2.2.0",
74
74
  "@atlaskit/platform-feature-flags-react": "^1.2.0",
75
75
  "@atlaskit/popper": "^9.4.0",
76
- "@atlaskit/primitives": "^22.6.0",
76
+ "@atlaskit/primitives": "^22.7.0",
77
77
  "@atlaskit/profilecard": "^27.6.0",
78
78
  "@atlaskit/prosemirror-history": "^1.3.0",
79
79
  "@atlaskit/react-compiler-gating": "^0.2.0",
@@ -85,8 +85,8 @@
85
85
  "@atlaskit/task-decision": "^21.14.0",
86
86
  "@atlaskit/teams-app-config": "^3.1.0",
87
87
  "@atlaskit/textfield": "^10.3.0",
88
- "@atlaskit/tmp-editor-statsig": "^258.0.0",
89
- "@atlaskit/tokens": "^20.9.0",
88
+ "@atlaskit/tmp-editor-statsig": "^259.0.0",
89
+ "@atlaskit/tokens": "^20.10.0",
90
90
  "@atlaskit/tooltip": "^24.4.0",
91
91
  "@atlaskit/width-detector": "^7.2.0",
92
92
  "@babel/runtime": "^7.0.0",