@atlaskit/editor-common 134.16.0 → 134.16.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,22 @@
1
1
  # @atlaskit/editor-common
2
2
 
3
+ ## 134.16.2
4
+
5
+ ### Patch Changes
6
+
7
+ - [`6bc3894066dc8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6bc3894066dc8) -
8
+ Clean up the `platform_editor_toolbar_multi_editor_fix` experiment. The selection toolbar now
9
+ always scopes mouseups to its own editor, so it closes correctly when multiple editors are open.
10
+ - Updated dependencies
11
+
12
+ ## 134.16.1
13
+
14
+ ### Patch Changes
15
+
16
+ - [`c523bb44bcb8d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c523bb44bcb8d) -
17
+ Fix stale mention identities and properties when platform_editor_perf_lint_cleanup is enabled.
18
+ - Updated dependencies
19
+
3
20
  ## 134.16.0
4
21
 
5
22
  ### Minor Changes
package/compass.yml CHANGED
@@ -35,7 +35,7 @@ customFields:
35
35
  value: true
36
36
  - name: Reviewer Selection Mechanism
37
37
  type: text
38
- value: random(2)
38
+ value: randomTZIgnored(2)
39
39
  - name: Required Reviewer Approvals
40
40
  type: number
41
41
  value: 1
@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
27
27
  var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
28
28
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
29
29
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
30
- var packageVersion = "134.15.0";
30
+ var packageVersion = "134.16.1";
31
31
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
32
32
  // Remove URL as it has UGC
33
33
  // Ignored via go/ees007
@@ -7,7 +7,6 @@ Object.defineProperty(exports, "__esModule", {
7
7
  exports.EditorToolbarUIProvider = void 0;
8
8
  var _react = _interopRequireWildcard(require("react"));
9
9
  var _uiContext = require("@atlaskit/editor-toolbar/ui-context");
10
- var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
11
10
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
12
11
  var EditorToolbarUIProvider = exports.EditorToolbarUIProvider = function EditorToolbarUIProvider(_ref) {
13
12
  var children = _ref.children,
@@ -27,7 +26,7 @@ var EditorToolbarUIProvider = exports.EditorToolbarUIProvider = function EditorT
27
26
  // When closed via keyboard Escape, keep focus on the trigger for better keyboard UX.
28
27
  var isKeyboardEscape = event instanceof KeyboardEvent && event.key === 'Escape';
29
28
  var shouldFocusEditor = !isKeyboardEscape;
30
- if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_toolbar_multi_editor_fix') && event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
29
+ if (event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
31
30
  return;
32
31
  }
33
32
  if (shouldFocusEditor) {
@@ -23,7 +23,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
23
23
  * @jsx jsx
24
24
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
25
25
  var packageName = "@atlaskit/editor-common";
26
- var packageVersion = "134.15.0";
26
+ var packageVersion = "134.16.1";
27
27
  var halfFocusRing = 1;
28
28
  var dropOffset = '0, 8';
29
29
  // Ignored via go/ees005
@@ -13,6 +13,7 @@ var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/ge
13
13
  var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
14
14
  var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
15
15
  var _react = _interopRequireWildcard(require("react"));
16
+ var _memoizeOne = _interopRequireDefault(require("memoize-one"));
16
17
  var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
17
18
  var _fg = require("@atlaskit/platform-feature-flags/fg");
18
19
  var _mentionAvatar = require("../../mention-avatar");
@@ -23,21 +24,21 @@ function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2.default)(o), (0,
23
24
  function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); } /* eslint-disable @repo/internal/react/no-class-components */
24
25
  var MENTION_PROVIDERS = ['mentionProvider', 'profilecardProvider'];
25
26
  var Mention = exports.default = /*#__PURE__*/function (_PureComponent) {
26
- function Mention(props) {
27
+ function Mention(_props) {
27
28
  var _this;
28
29
  (0, _classCallCheck2.default)(this, Mention);
29
- _this = _callSuper(this, Mention, [props]);
30
+ _this = _callSuper(this, Mention, [_props]);
30
31
  (0, _defineProperty2.default)(_this, "renderWithProvider", function (providers) {
31
- var _this$props = _this.props,
32
- accessLevel = _this$props.accessLevel,
33
- eventHandlers = _this$props.eventHandlers,
34
- id = _this$props.id,
35
- text = _this$props.text,
36
- localId = _this$props.localId,
37
- userType = _this$props.userType,
38
- isDisabled = _this$props.isDisabled,
39
- disabledTooltip = _this$props.disabledTooltip,
40
- mentionNodeDataProvider = _this$props.mentionNodeDataProvider;
32
+ var props = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : _this.props;
33
+ var accessLevel = props.accessLevel,
34
+ eventHandlers = props.eventHandlers,
35
+ id = props.id,
36
+ text = props.text,
37
+ localId = props.localId,
38
+ userType = props.userType,
39
+ isDisabled = props.isDisabled,
40
+ disabledTooltip = props.disabledTooltip,
41
+ mentionNodeDataProvider = props.mentionNodeDataProvider;
41
42
  var mentionProvider = providers.mentionProvider,
42
43
  profilecardProvider = providers.profilecardProvider;
43
44
  var hasProvider = Boolean(mentionNodeDataProvider);
@@ -82,7 +83,13 @@ var Mention = exports.default = /*#__PURE__*/function (_PureComponent) {
82
83
  profilecardProvider: profilecardProvider
83
84
  }));
84
85
  });
85
- _this.providerFactory = props.providers || new _providerFactory.ProviderFactory();
86
+ // WithProviders is pure, so its callback must change when mention props change.
87
+ (0, _defineProperty2.default)(_this, "getRenderWithProvider", (0, _memoizeOne.default)(function (props) {
88
+ return function (providers) {
89
+ return _this.renderWithProvider(providers, props);
90
+ };
91
+ }));
92
+ _this.providerFactory = _props.providers || new _providerFactory.ProviderFactory();
86
93
  return _this;
87
94
  }
88
95
  (0, _inherits2.default)(Mention, _PureComponent);
@@ -98,11 +105,12 @@ var Mention = exports.default = /*#__PURE__*/function (_PureComponent) {
98
105
  }, {
99
106
  key: "render",
100
107
  value: function render() {
101
- var providers = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_perf_lint_cleanup') ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
108
+ var isPerfLintCleanupEnabled = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_perf_lint_cleanup');
109
+ var providers = isPerfLintCleanupEnabled ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
102
110
  return /*#__PURE__*/_react.default.createElement(_providerFactory.WithProviders, {
103
111
  providers: providers,
104
112
  providerFactory: this.providerFactory,
105
- renderNode: this.renderWithProvider
113
+ renderNode: isPerfLintCleanupEnabled ? this.getRenderWithProvider(this.props) : this.renderWithProvider
106
114
  });
107
115
  }
108
116
  }]);
@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
13
13
  const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
14
14
  const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
15
15
  const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
16
- const packageVersion = "134.15.0";
16
+ const packageVersion = "134.16.1";
17
17
  const sanitiseSentryEvents = (data, _hint) => {
18
18
  // Remove URL as it has UGC
19
19
  // Ignored via go/ees007
@@ -1,6 +1,5 @@
1
1
  import React, { useCallback } from 'react';
2
2
  import { ToolbarUIProvider } from '@atlaskit/editor-toolbar/ui-context';
3
- import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
4
3
  export const EditorToolbarUIProvider = ({
5
4
  children,
6
5
  api,
@@ -21,7 +20,7 @@ export const EditorToolbarUIProvider = ({
21
20
  // When closed via keyboard Escape, keep focus on the trigger for better keyboard UX.
22
21
  const isKeyboardEscape = event instanceof KeyboardEvent && event.key === 'Escape';
23
22
  const shouldFocusEditor = !isKeyboardEscape;
24
- if (isExperimentEnabled('platform_editor_toolbar_multi_editor_fix') && event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
23
+ if (event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
25
24
  return;
26
25
  }
27
26
  if (shouldFocusEditor) {
@@ -13,7 +13,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
13
13
  import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
14
14
  import Layer from '../Layer';
15
15
  const packageName = "@atlaskit/editor-common";
16
- const packageVersion = "134.15.0";
16
+ const packageVersion = "134.16.1";
17
17
  const halfFocusRing = 1;
18
18
  const dropOffset = '0, 8';
19
19
  // Ignored via go/ees005
@@ -2,6 +2,7 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
2
2
  /* eslint-disable @repo/internal/react/no-class-components */
3
3
 
4
4
  import React, { PureComponent } from 'react';
5
+ import memoizeOne from 'memoize-one';
5
6
  import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
6
7
  import { fg } from '@atlaskit/platform-feature-flags/fg';
7
8
  import { isMentionAvatarEnabled } from '../../mention-avatar';
@@ -9,9 +10,9 @@ import { ProviderFactory, WithProviders } from '../../provider-factory';
9
10
  import { MissingMentionAvatarProvider, MentionWithAvatarProviders, MentionWithProviders } from './mention-with-providers';
10
11
  const MENTION_PROVIDERS = ['mentionProvider', 'profilecardProvider'];
11
12
  export default class Mention extends PureComponent {
12
- constructor(props) {
13
- super(props);
14
- _defineProperty(this, "renderWithProvider", providers => {
13
+ constructor(_props) {
14
+ super(_props);
15
+ _defineProperty(this, "renderWithProvider", (providers, props = this.props) => {
15
16
  const {
16
17
  accessLevel,
17
18
  eventHandlers,
@@ -22,7 +23,7 @@ export default class Mention extends PureComponent {
22
23
  isDisabled,
23
24
  disabledTooltip,
24
25
  mentionNodeDataProvider
25
- } = this.props;
26
+ } = props;
26
27
  const {
27
28
  mentionProvider,
28
29
  profilecardProvider
@@ -69,7 +70,9 @@ export default class Mention extends PureComponent {
69
70
  profilecardProvider: profilecardProvider
70
71
  }));
71
72
  });
72
- this.providerFactory = props.providers || new ProviderFactory();
73
+ // WithProviders is pure, so its callback must change when mention props change.
74
+ _defineProperty(this, "getRenderWithProvider", memoizeOne(props => providers => this.renderWithProvider(providers, props)));
75
+ this.providerFactory = _props.providers || new ProviderFactory();
73
76
  }
74
77
  componentWillUnmount() {
75
78
  if (!this.props.providers) {
@@ -79,11 +82,12 @@ export default class Mention extends PureComponent {
79
82
  }
80
83
  }
81
84
  render() {
82
- const providers = isExperimentEnabled('platform_editor_perf_lint_cleanup') ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
85
+ const isPerfLintCleanupEnabled = isExperimentEnabled('platform_editor_perf_lint_cleanup');
86
+ const providers = isPerfLintCleanupEnabled ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
83
87
  return /*#__PURE__*/React.createElement(WithProviders, {
84
88
  providers: providers,
85
89
  providerFactory: this.providerFactory,
86
- renderNode: this.renderWithProvider
90
+ renderNode: isPerfLintCleanupEnabled ? this.getRenderWithProvider(this.props) : this.renderWithProvider
87
91
  });
88
92
  }
89
93
  }
@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
19
19
  var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
20
20
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
21
21
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
22
- var packageVersion = "134.15.0";
22
+ var packageVersion = "134.16.1";
23
23
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
24
24
  // Remove URL as it has UGC
25
25
  // Ignored via go/ees007
@@ -1,6 +1,5 @@
1
1
  import React, { useCallback } from 'react';
2
2
  import { ToolbarUIProvider } from '@atlaskit/editor-toolbar/ui-context';
3
- import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
4
3
  export var EditorToolbarUIProvider = function EditorToolbarUIProvider(_ref) {
5
4
  var children = _ref.children,
6
5
  api = _ref.api,
@@ -19,7 +18,7 @@ export var EditorToolbarUIProvider = function EditorToolbarUIProvider(_ref) {
19
18
  // When closed via keyboard Escape, keep focus on the trigger for better keyboard UX.
20
19
  var isKeyboardEscape = event instanceof KeyboardEvent && event.key === 'Escape';
21
20
  var shouldFocusEditor = !isKeyboardEscape;
22
- if (isExperimentEnabled('platform_editor_toolbar_multi_editor_fix') && event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
21
+ if (event instanceof MouseEvent && event.target instanceof Element && !event.target.closest('[role="menu"]')) {
23
22
  return;
24
23
  }
25
24
  if (shouldFocusEditor) {
@@ -20,7 +20,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
20
20
  import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
21
21
  import Layer from '../Layer';
22
22
  var packageName = "@atlaskit/editor-common";
23
- var packageVersion = "134.15.0";
23
+ var packageVersion = "134.16.1";
24
24
  var halfFocusRing = 1;
25
25
  var dropOffset = '0, 8';
26
26
  // Ignored via go/ees005
@@ -9,6 +9,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
9
9
  /* eslint-disable @repo/internal/react/no-class-components */
10
10
 
11
11
  import React, { PureComponent } from 'react';
12
+ import memoizeOne from 'memoize-one';
12
13
  import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
13
14
  import { fg } from '@atlaskit/platform-feature-flags/fg';
14
15
  import { isMentionAvatarEnabled } from '../../mention-avatar';
@@ -16,21 +17,21 @@ import { ProviderFactory, WithProviders } from '../../provider-factory';
16
17
  import { MissingMentionAvatarProvider, MentionWithAvatarProviders, MentionWithProviders } from './mention-with-providers';
17
18
  var MENTION_PROVIDERS = ['mentionProvider', 'profilecardProvider'];
18
19
  var Mention = /*#__PURE__*/function (_PureComponent) {
19
- function Mention(props) {
20
+ function Mention(_props) {
20
21
  var _this;
21
22
  _classCallCheck(this, Mention);
22
- _this = _callSuper(this, Mention, [props]);
23
+ _this = _callSuper(this, Mention, [_props]);
23
24
  _defineProperty(_this, "renderWithProvider", function (providers) {
24
- var _this$props = _this.props,
25
- accessLevel = _this$props.accessLevel,
26
- eventHandlers = _this$props.eventHandlers,
27
- id = _this$props.id,
28
- text = _this$props.text,
29
- localId = _this$props.localId,
30
- userType = _this$props.userType,
31
- isDisabled = _this$props.isDisabled,
32
- disabledTooltip = _this$props.disabledTooltip,
33
- mentionNodeDataProvider = _this$props.mentionNodeDataProvider;
25
+ var props = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : _this.props;
26
+ var accessLevel = props.accessLevel,
27
+ eventHandlers = props.eventHandlers,
28
+ id = props.id,
29
+ text = props.text,
30
+ localId = props.localId,
31
+ userType = props.userType,
32
+ isDisabled = props.isDisabled,
33
+ disabledTooltip = props.disabledTooltip,
34
+ mentionNodeDataProvider = props.mentionNodeDataProvider;
34
35
  var mentionProvider = providers.mentionProvider,
35
36
  profilecardProvider = providers.profilecardProvider;
36
37
  var hasProvider = Boolean(mentionNodeDataProvider);
@@ -75,7 +76,13 @@ var Mention = /*#__PURE__*/function (_PureComponent) {
75
76
  profilecardProvider: profilecardProvider
76
77
  }));
77
78
  });
78
- _this.providerFactory = props.providers || new ProviderFactory();
79
+ // WithProviders is pure, so its callback must change when mention props change.
80
+ _defineProperty(_this, "getRenderWithProvider", memoizeOne(function (props) {
81
+ return function (providers) {
82
+ return _this.renderWithProvider(providers, props);
83
+ };
84
+ }));
85
+ _this.providerFactory = _props.providers || new ProviderFactory();
79
86
  return _this;
80
87
  }
81
88
  _inherits(Mention, _PureComponent);
@@ -91,11 +98,12 @@ var Mention = /*#__PURE__*/function (_PureComponent) {
91
98
  }, {
92
99
  key: "render",
93
100
  value: function render() {
94
- var providers = isExperimentEnabled('platform_editor_perf_lint_cleanup') ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
101
+ var isPerfLintCleanupEnabled = isExperimentEnabled('platform_editor_perf_lint_cleanup');
102
+ var providers = isPerfLintCleanupEnabled ? MENTION_PROVIDERS : ['mentionProvider', 'profilecardProvider'];
95
103
  return /*#__PURE__*/React.createElement(WithProviders, {
96
104
  providers: providers,
97
105
  providerFactory: this.providerFactory,
98
- renderNode: this.renderWithProvider
106
+ renderNode: isPerfLintCleanupEnabled ? this.getRenderWithProvider(this.props) : this.renderWithProvider
99
107
  });
100
108
  }
101
109
  }]);
@@ -23,5 +23,6 @@ export default class Mention extends PureComponent<MentionProps, object> {
23
23
  constructor(props: MentionProps);
24
24
  componentWillUnmount(): void;
25
25
  private renderWithProvider;
26
+ private getRenderWithProvider;
26
27
  render(): React.JSX.Element;
27
28
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-common",
3
- "version": "134.16.0",
3
+ "version": "134.16.2",
4
4
  "description": "A package that contains common classes and components for editor and renderer",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -75,7 +75,7 @@
75
75
  "@atlaskit/popper": "^9.4.0",
76
76
  "@atlaskit/popup": "^10.2.0",
77
77
  "@atlaskit/primitives": "^22.7.0",
78
- "@atlaskit/profilecard": "^27.7.0",
78
+ "@atlaskit/profilecard": "^27.8.0",
79
79
  "@atlaskit/prosemirror-history": "^1.3.0",
80
80
  "@atlaskit/react-compiler-gating": "^0.2.0",
81
81
  "@atlaskit/react-ufo": "^8.4.0",