@atlaskit/editor-common 125.2.1 → 125.3.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/editor-common
 
+## 125.3.0
+
+### Minor Changes
+
+- [`981dd11bb4ed2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/981dd11bb4ed2) -
+  Add opt-in target visibility handling to editor popups, and use it to hide the Jira description
+  block menu while its originating node is outside the visible viewport. The popup reappears when
+  its target returns, preserving an open nested menu, behind the
+  `platform_editor_popup_target_visibility` experiment.
+
+### Patch Changes
+
+- [`e339b127f827a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e339b127f827a) -
+  Route `platform_editor_controls` checks that used `expValEquals` / `expValEqualsNoExposure`
+  through `editorExperiment`, so they respect the per-product experiment key (Confluence
+  `platform_editor_controls`, Jira `platform_editor_controls_jira`). Previously these checks always
+  read the Confluence experiment, which evaluated to control in Jira.
+- Updated dependencies
+
 ## 125.2.1
 
 ### Patch Changes

package/dist/cjs/element-browser/components/ElementBrowserLoader.js

@@ -9,15 +9,11 @@ var _typeof2 = _interopRequireDefault(require("@babel/runtime/helpers/typeof"));
 var _react = _interopRequireDefault(require("react"));
 var _react2 = require("@emotion/react");
 var _reactLoadable = _interopRequireDefault(require("react-loadable"));
-var _reactLooselyLazy = require("react-loosely-lazy");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _spinner = _interopRequireDefault(require("@atlaskit/spinner/spinner"));
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != (0, _typeof2.default)(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); } /**
  * @jsxRuntime classic
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
-// oxlint-disable-next-line @atlassian/no-restricted-imports
-// oxlint-disable-next-line @atlassian/no-restricted-imports
 var spinnerContainer = (0, _react2.css)({
   display: 'flex',
   alignItems: 'center',
@@ -25,23 +21,14 @@ var spinnerContainer = (0, _react2.css)({
   height: '100%',
   width: '100%'
 });
-var loadElementBrowser = function loadElementBrowser() {
-  return Promise.resolve().then(function () {
-    return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-element-browser" */'../ElementBrowser'));
-  }).then(function (module) {
-    return module.default;
-  });
-};
-var ElementBrowserLazy = (0, _reactLooselyLazy.lazy)(function () {
-  return Promise.resolve().then(function () {
-    return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-element-browser" */'../ElementBrowser'));
-  }).then(function (module) {
-    return module.default;
-  });
-});
-ElementBrowserLazy.displayName = 'lazy(ElementBrowser)';
-var ElementBrowserLoadable = (0, _reactLoadable.default)({
-  loader: loadElementBrowser,
+var ElementBrowserLoader = (0, _reactLoadable.default)({
+  loader: function loader() {
+    return Promise.resolve().then(function () {
+      return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-element-browser" */'../ElementBrowser'));
+    }).then(function (module) {
+      return module.default;
+    });
+  },
   loading: function loading() {
     return (0, _react2.jsx)("div", {
       css: spinnerContainer
@@ -51,14 +38,4 @@ var ElementBrowserLoadable = (0, _reactLoadable.default)({
     }));
   }
 });
-var ElementBrowserLoader = function ElementBrowserLoader(props) {
-  return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? (0, _react2.jsx)(_reactLooselyLazy.LazySuspense, {
-    fallback: null
-  }, (0, _react2.jsx)(ElementBrowserLazy, props)) :
-  // eslint-disable-next-line react/jsx-props-no-spreading
-  (0, _react2.jsx)(ElementBrowserLoadable, props);
-};
-ElementBrowserLoader.preload = function () {
-  return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? ElementBrowserLazy.preload() : ElementBrowserLoadable.preload();
-};
 var _default = exports.default = ElementBrowserLoader;

package/dist/cjs/extensions/extension-handlers.js

@@ -15,27 +15,16 @@ exports.getExtensionModuleNodeMaybePreloaded = getExtensionModuleNodeMaybePreloa
 exports.getExtensionModuleNodePrivateProps = getExtensionModuleNodePrivateProps;
 exports.getNodeRenderer = getNodeRenderer;
 var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
-var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
-var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
-var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
-var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime/helpers/possibleConstructorReturn"));
-var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
-var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
-var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
 var _react = _interopRequireDefault(require("react"));
 var _reactIntl = require("react-intl");
 var _reactLoadable = _interopRequireDefault(require("react-loadable"));
-var _reactLooselyLazy = require("react-loosely-lazy");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _manifestHelpers = require("./manifest-helpers");
 var _messages = require("./messages");
 var _resolveImportSync = require("./resolveImportSync");
 var _UnknownMacroPlaceholder = require("./UnknownMacroPlaceholder");
 var _getExtensionManifest = require("./getExtensionManifest");
-function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2.default)(o), (0, _possibleConstructorReturn2.default)(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], (0, _getPrototypeOf2.default)(t).constructor) : o.apply(t, e)); }
-function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); } // oxlint-disable-next-line @atlassian/no-restricted-imports
 function getNodeFromManifest(
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 manifest, extKey, nodeKey, extensionType, extensionKey) {
@@ -131,52 +120,6 @@ function isUnknownConfluenceMacroWithBody(extensionNode) {
   var _extensionNode$parame;
   return extensionNode !== null && extensionNode.type === 'extension' && extensionNode.extensionType === 'com.atlassian.confluence.macro.core' && !!((_extensionNode$parame = extensionNode.parameters) !== null && _extensionNode$parame !== void 0 && (_extensionNode$parame = _extensionNode$parame.macroParams) !== null && _extensionNode$parame !== void 0 && (_extensionNode$parame = _extensionNode$parame.__bodyContent) !== null && _extensionNode$parame !== void 0 && _extensionNode$parame.value);
 }
-// eslint-disable-next-line @repo/internal/react/no-class-components -- error boundaries require a class component
-var ExtensionRendererErrorBoundary = /*#__PURE__*/function (_React$Component) {
-  function ExtensionRendererErrorBoundary() {
-    var _this;
-    (0, _classCallCheck2.default)(this, ExtensionRendererErrorBoundary);
-    for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
-      args[_key] = arguments[_key];
-    }
-    _this = _callSuper(this, ExtensionRendererErrorBoundary, [].concat(args));
-    (0, _defineProperty2.default)(_this, "state", {});
-    return _this;
-  }
-  (0, _inherits2.default)(ExtensionRendererErrorBoundary, _React$Component);
-  return (0, _createClass2.default)(ExtensionRendererErrorBoundary, [{
-    key: "componentDidCatch",
-    value: function componentDidCatch(error) {
-      // eslint-disable-next-line no-console
-      console.error('Error rendering extension', error);
-    }
-  }, {
-    key: "render",
-    value: function render() {
-      return this.state.error ? renderExtensionLoadingError(this.state.error, this.props.fallbackProps) : this.props.children;
-    }
-  }], [{
-    key: "getDerivedStateFromError",
-    value: function getDerivedStateFromError(error) {
-      return {
-        error: error
-      };
-    }
-  }]);
-}(_react.default.Component);
-var noop = function noop() {};
-function renderExtensionLoadingError(error, props) {
-  // Needed because the old react-loadable (older code-splitting library) error handling behaviour might be relied on by extensions.
-  // https://unpkg.com/react-loadable@5.2.2/lib/index.js
-  return /*#__PURE__*/_react.default.createElement(ExtensionLoading, (0, _extends2.default)({
-    isLoading: false,
-    pastDelay: true,
-    timedOut: false,
-    error: error,
-    retry: noop
-    // eslint-disable-next-line react/jsx-props-no-spreading
-  }, props));
-}
 function ExtensionLoading(props) {
   var intl = (0, _reactIntl.useIntl)();
   var extensionNode = props.node;
@@ -199,50 +142,28 @@ function ExtensionLoading(props) {
 
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
 function getNodeRenderer(extensionProvider, extensionType, extensionKey) {
-  var loadNodeRenderer = function loadNodeRenderer() {
-    var _renderSync, _ref;
-    var maybePromise = getExtensionModuleNodeMaybePreloaded(extensionProvider, extensionType, extensionKey);
-    if (maybePromise instanceof Promise) {
-      return maybePromise.then(function (node) {
-        return (0, _manifestHelpers.resolveImport)(node.render());
-      });
-    }
-    var preloaded = maybePromise === null || maybePromise === void 0 || (_renderSync = (_ref = maybePromise).renderSync) === null || _renderSync === void 0 ? void 0 : _renderSync.call(_ref);
-    // Only product implemented preloading will return sync result
-    // However the out-of-box won't handle this. Confluence uses a custom implementation
-    return preloaded ?
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (0, _resolveImportSync.resolveImportSync)(preloaded) : (0, _manifestHelpers.resolveImport)(maybePromise.render());
-  };
-  var LazyNodeRenderer = (0, _reactLooselyLazy.lazy)(function () {
-    return loadNodeRenderer();
-  });
-  LazyNodeRenderer.displayName = 'lazy(NodeRenderer)';
-  // Ignored via go/ees005
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  var LoadableNodeRenderer = (0, _reactLoadable.default)({
-    loader: loadNodeRenderer,
+  return (0, _reactLoadable.default)({
+    loader: function loader() {
+      var maybePromise = getExtensionModuleNodeMaybePreloaded(extensionProvider, extensionType, extensionKey);
+      if (maybePromise instanceof Promise) {
+        return maybePromise.then(function (node) {
+          return (0, _manifestHelpers.resolveImport)(node.render());
+        });
+      } else {
+        var _renderSync, _ref;
+        var preloaded = maybePromise === null || maybePromise === void 0 || (_renderSync = (_ref = maybePromise).renderSync) === null || _renderSync === void 0 ? void 0 : _renderSync.call(_ref);
+        // Only product implemented preloading will return sync result
+        // However the out-of-box won't handle this. Confluence uses a custom implementation
+        return preloaded ?
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        (0, _resolveImportSync.resolveImportSync)(preloaded) : (0, _manifestHelpers.resolveImport)(maybePromise.render());
+      }
+    },
     // react-loadable passes all props from <NodeRenderer> to the loading component at runtime,
     // but its TypeScript types only expect LoadingComponentProps. We cast here because
     // ExtensionLoading accepts additional props (node, showUnknownMacroPlaceholder) that
     // react-loadable will pass through but doesn't know about in its type definitions.
     loading: ExtensionLoading
   });
-  var NodeRenderer = function NodeRenderer(props) {
-    var _props$loadingFallbac;
-    if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration')) {
-      // eslint-disable-next-line react/jsx-props-no-spreading
-      return /*#__PURE__*/_react.default.createElement(LoadableNodeRenderer, props);
-    }
-    return /*#__PURE__*/_react.default.createElement(ExtensionRendererErrorBoundary, {
-      fallbackProps: props
-    }, /*#__PURE__*/_react.default.createElement(_reactLooselyLazy.LazySuspense, {
-      fallback: (_props$loadingFallbac = props.loadingFallback) !== null && _props$loadingFallbac !== void 0 ? _props$loadingFallbac : null
-    }, /*#__PURE__*/_react.default.createElement(LazyNodeRenderer, props)));
-  };
-  NodeRenderer.preload = function () {
-    return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? LazyNodeRenderer.preload() : LoadableNodeRenderer.preload();
-  };
-  return NodeRenderer;
 }
 // eslint-disable-next-line @atlaskit/editor/no-re-export

package/dist/cjs/floating-toolbar/DropdownMenuExtensionItems.js

@@ -11,15 +11,11 @@ var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/sli
 var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
 var _react = _interopRequireWildcard(require("react"));
 var _reactLoadable = _interopRequireDefault(require("react-loadable"));
-var _reactLooselyLazy = require("react-loosely-lazy");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _extensions = require("../extensions");
 var _utils = require("../utils");
 var _DropdownMenuItem = require("./DropdownMenuItem");
 var _DropdownSeparator = require("./DropdownSeparator");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t2 in e) "default" !== _t2 && {}.hasOwnProperty.call(e, _t2) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t2)) && (i.get || i.set) ? o(f, _t2, i) : f[_t2] = e[_t2]); return f; })(e, t); }
-// oxlint-disable-next-line @atlassian/no-restricted-imports
-
 var noop = function noop() {
   return null;
 };
@@ -98,29 +94,12 @@ var DropdownMenuExtensionItem = function DropdownMenuExtensionItem(_ref3) {
   // Use ref to keep icon component stable across renders
   var iconRef = (0, _react.useRef)(null);
   if (!iconRef.current && item.icon) {
-    var loadIcon = function loadIcon() {
-      return resolveExtensionIcon(item.icon);
-    };
-    var IconLazy = (0, _reactLooselyLazy.lazy)(function () {
-      return resolveExtensionIcon(item.icon);
-    });
-    IconLazy.displayName = 'lazy(ExtensionIcon)';
-    var IconLoadable = (0, _reactLoadable.default)({
-      loader: loadIcon,
+    iconRef.current = (0, _reactLoadable.default)({
+      loader: function loader() {
+        return resolveExtensionIcon(item.icon);
+      },
       loading: noop
     });
-    var Icon = function Icon(props) {
-      return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? /*#__PURE__*/_react.default.createElement(_reactLooselyLazy.LazySuspense, {
-        fallback: null
-      }, /*#__PURE__*/_react.default.createElement(IconLazy, props)) :
-      /*#__PURE__*/
-      // eslint-disable-next-line react/jsx-props-no-spreading -- pass icon props to the legacy component
-      _react.default.createElement(IconLoadable, props);
-    };
-    Icon.preload = function () {
-      return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? IconLazy.preload() : IconLoadable.preload();
-    };
-    iconRef.current = Icon;
   }
   var dropdownItem = convertExtensionToDropdownMenuItem({
     item: item,

package/dist/cjs/icons/index.js

@@ -66,10 +66,7 @@ Object.defineProperty(exports, "rainbow", {
   }
 });
 var _typeof2 = _interopRequireDefault(require("@babel/runtime/helpers/typeof"));
-var _react = _interopRequireDefault(require("react"));
 var _reactLoadable = _interopRequireDefault(require("react-loadable"));
-var _reactLooselyLazy = require("react-loosely-lazy");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _PanelInfoIcon = require("./shared/PanelInfoIcon");
 var _PanelWarningIcon = require("./shared/PanelWarningIcon");
 var _PanelErrorIcon = require("./shared/PanelErrorIcon");
@@ -79,36 +76,16 @@ var _BorderIcon = require("./shared/BorderIcon");
 var _SteppedRainbowIconDecoration = require("./shared/SteppedRainbowIconDecoration");
 var _DynamicStrokeIconDecoration = require("./shared/DynamicStrokeIconDecoration");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != (0, _typeof2.default)(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); } // Disable no-re-export rule for entry point files
-/* eslint-disable @atlaskit/editor/no-re-export */ // oxlint-disable-next-line @atlassian/no-restricted-imports
-var loadIconTable = function loadIconTable() {
-  return Promise.resolve().then(function () {
-    return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-icon-table" */'../icons/shared/table'));
-  }).then(function (module) {
-    return module.default;
-  });
-};
-var IconTableLazy = (0, _reactLooselyLazy.lazy)(function () {
-  return Promise.resolve().then(function () {
-    return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-icon-table" */'../icons/shared/table'));
-  }).then(function (module) {
-    return module.default;
-  });
-});
-IconTableLazy.displayName = 'lazy(IconTable)';
-var IconTableLoadable = (0, _reactLoadable.default)({
-  loader: loadIconTable,
+/* eslint-disable @atlaskit/editor/no-re-export */
+var IconTable = exports.IconTable = (0, _reactLoadable.default)({
+  loader: function loader() {
+    return Promise.resolve().then(function () {
+      return _interopRequireWildcard(require( /* webpackChunkName: "@atlaskit-internal_editor-icon-table" */'../icons/shared/table'));
+    }).then(function (module) {
+      return module.default;
+    });
+  },
   loading: function loading() {
     return null;
   }
-});
-var IconTable = exports.IconTable = function IconTable(props) {
-  return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? /*#__PURE__*/_react.default.createElement(_reactLooselyLazy.LazySuspense, {
-    fallback: null
-  }, /*#__PURE__*/_react.default.createElement(IconTableLazy, props)) :
-  /*#__PURE__*/
-  // eslint-disable-next-line react/jsx-props-no-spreading -- pass icon props to the legacy component
-  _react.default.createElement(IconTableLoadable, props);
-};
-IconTable.preload = function () {
-  return (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_loosely_lazy_migration') ? IconTableLazy.preload() : IconTableLoadable.preload();
-};
+});

package/dist/cjs/monitoring/error.js

@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "125.2.0";
+var packageVersion = "125.2.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007