@atlaskit/editor-common 125.1.0 → 125.2.1

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # @atlaskit/editor-common
 
+## 125.2.1
+
+### Patch Changes
+
+- [`a8919aeeabced`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a8919aeeabced) -
+  Remove the shipped `platform_editor_hydration_skip_react_portal` experiment and preserve SSR DOM
+  reuse. The experiment is no longer available in the Statsig configuration; consumers should remove
+  its overrides and checks.
+- Updated dependencies
+
+## 125.2.0
+
+### Minor Changes
+
+- [`111eaadd44c1c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/111eaadd44c1c) -
+  EDITOR-8995: Make the editor find dialog usable in live view. The find dialog now accepts an
+  `allowReplace` prop, and hides the replace label, field, replacement count message, both replace
+  buttons and the horizontal rule when it is false. It also names the dialog "Find" instead of "Find
+  and Replace" in that state. The find plugin derives `allowReplace` from the `editorViewMode`
+  shared state, so view mode never offers replace. A new ProseMirror plugin opens the dialog on
+  `Mod-f` in view mode, where no keymap fires, behind the `platform_editor_collapsible_headings`
+  experiment. The `activated` analytics event gains an `editorViewMode` attribute.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 125.1.0
 
 ### Minor Changes

package/dist/cjs/extensibility/extensionNodeView.js

@@ -17,7 +17,6 @@ var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireWildcard(require("react"));
 var _fg = require("@atlaskit/platform-feature-flags/fg");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _coreUtils = require("../core-utils");
 var _reactNodeView = _interopRequireDefault(require("../react-node-view"));
 var _Extension = require("./Extension");
@@ -140,7 +139,7 @@ var ExtensionNode = exports.ExtensionNode = /*#__PURE__*/function (_ReactNodeVie
     value: function createDomRef() {
       // SSR DOM reuse takes precedence over preset height — when eligible, adopt the
       // server-rendered element directly so React hydration is deferred until update().
-      if (!(0, _coreUtils.isSSR)() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow() && (0, _expValEquals.expValEquals)('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+      if (!(0, _coreUtils.isSSR)() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow()) {
         var ssrElement = this.findSSRElement();
         if (ssrElement) {
           this.didReuseSsrDom = true;
@@ -211,22 +210,18 @@ var ExtensionNode = exports.ExtensionNode = /*#__PURE__*/function (_ReactNodeVie
   }, {
     key: "init",
     value: function init() {
-      if (!(0, _expValEquals.expValEquals)('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
-        _superPropGet(ExtensionNode, "init", this, 3)([]);
-      } else {
-        var isEligibleForSsrReuse = !(0, _coreUtils.isSSR)() && isSSRHydrationEligible(this.node);
-        if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
-          var ssrElement = this.findSSRElement();
-          var shouldSkipInitRender = ssrElement !== null;
-          _superPropGet(ExtensionNode, "init", this, 3)([shouldSkipInitRender]);
-          var identityKey = this.getHydrationIdentityKey();
-          if (identityKey !== null) {
-            // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
-            markHydrationIdentityAsConsumed(this.view, identityKey);
-          }
-        } else {
-          _superPropGet(ExtensionNode, "init", this, 3)([]);
+      var isEligibleForSsrReuse = !(0, _coreUtils.isSSR)() && isSSRHydrationEligible(this.node);
+      if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
+        var ssrElement = this.findSSRElement();
+        var shouldSkipInitRender = ssrElement !== null;
+        _superPropGet(ExtensionNode, "init", this, 3)([shouldSkipInitRender]);
+        var identityKey = this.getHydrationIdentityKey();
+        if (identityKey !== null) {
+          // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
+          markHydrationIdentityAsConsumed(this.view, identityKey);
         }
+      } else {
+        _superPropGet(ExtensionNode, "init", this, 3)([]);
       }
       return this;
     }
@@ -238,7 +233,7 @@ var ExtensionNode = exports.ExtensionNode = /*#__PURE__*/function (_ReactNodeVie
       };
       // Remove extensionNodeWrapper aka span.relative if we previously reused SSR DOM
       // control is back to React afterwards
-      if (this.didReuseSsrDom && (0, _expValEquals.expValEquals)('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+      if (this.didReuseSsrDom) {
         var ssrElement = this.findSSRElement();
         if (ssrElement) {
           var extensionNodeWrapper = ssrElement.querySelector('[data-testid="extension-node-wrapper"]');

package/dist/cjs/messages/find-replace.js

@@ -31,6 +31,11 @@ var findReplaceMessages = exports.findReplaceMessages = (0, _reactIntl.defineMes
     defaultMessage: 'Find and Replace',
     description: 'Aria label for the "Find and Replace" dialog'
   },
+  findDialogAriaLabel: {
+    id: 'fabric.editor.findDialogAriaLabel',
+    defaultMessage: 'Find',
+    description: 'Aria label for the "Find" dialog, used where the dialog offers find without replace'
+  },
   closeFindReplaceDialog: {
     id: 'fabric.editor.closeFindReplaceDialog',
     defaultMessage: 'Close',

package/dist/cjs/monitoring/error.js

@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "125.0.0";
+var packageVersion = "125.2.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "125.0.0";
+var packageVersion = "125.2.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/extensibility/extensionNodeView.js

@@ -1,7 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import React, { useCallback, useState } from 'react';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { isSSR } from '../core-utils';
 import ReactNodeView from '../react-node-view';
 import { Extension } from './Extension';
@@ -106,7 +105,7 @@ export class ExtensionNode extends ReactNodeView {
   createDomRef() {
     // SSR DOM reuse takes precedence over preset height — when eligible, adopt the
     // server-rendered element directly so React hydration is deferred until update().
-    if (!isSSR() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow() && expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+    if (!isSSR() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow()) {
       const ssrElement = this.findSSRElement();
       if (ssrElement) {
         this.didReuseSsrDom = true;
@@ -173,29 +172,25 @@ export class ExtensionNode extends ReactNodeView {
 
   /** Skip React Portal render on first init when reusing SSR DOM. See {@link consumedHydrationIdentitiesByEditor}. */
   init() {
-    if (!expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
-      super.init();
-    } else {
-      const isEligibleForSsrReuse = !isSSR() && isSSRHydrationEligible(this.node);
-      if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
-        const ssrElement = this.findSSRElement();
-        const shouldSkipInitRender = ssrElement !== null;
-        super.init(shouldSkipInitRender);
-        const identityKey = this.getHydrationIdentityKey();
-        if (identityKey !== null) {
-          // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
-          markHydrationIdentityAsConsumed(this.view, identityKey);
-        }
-      } else {
-        super.init();
+    const isEligibleForSsrReuse = !isSSR() && isSSRHydrationEligible(this.node);
+    if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
+      const ssrElement = this.findSSRElement();
+      const shouldSkipInitRender = ssrElement !== null;
+      super.init(shouldSkipInitRender);
+      const identityKey = this.getHydrationIdentityKey();
+      if (identityKey !== null) {
+        // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
+        markHydrationIdentityAsConsumed(this.view, identityKey);
       }
+    } else {
+      super.init();
     }
     return this;
   }
   update(node, decorations, _innerDecorations, validUpdate = () => true) {
     // Remove extensionNodeWrapper aka span.relative if we previously reused SSR DOM
     // control is back to React afterwards
-    if (this.didReuseSsrDom && expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+    if (this.didReuseSsrDom) {
       const ssrElement = this.findSSRElement();
       if (ssrElement) {
         const extensionNodeWrapper = ssrElement.querySelector('[data-testid="extension-node-wrapper"]');

package/dist/es2019/messages/find-replace.js

@@ -25,6 +25,11 @@ export const findReplaceMessages = defineMessages({
     defaultMessage: 'Find and Replace',
     description: 'Aria label for the "Find and Replace" dialog'
   },
+  findDialogAriaLabel: {
+    id: 'fabric.editor.findDialogAriaLabel',
+    defaultMessage: 'Find',
+    description: 'Aria label for the "Find" dialog, used where the dialog offers find without replace'
+  },
   closeFindReplaceDialog: {
     id: 'fabric.editor.closeFindReplaceDialog',
     defaultMessage: 'Close',

package/dist/es2019/monitoring/error.js

@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "125.0.0";
+const packageVersion = "125.2.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "125.0.0";
+const packageVersion = "125.2.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/extensibility/extensionNodeView.js

@@ -11,7 +11,6 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
 function _superPropGet(t, o, e, r) { var p = _get(_getPrototypeOf(1 & r ? t.prototype : t), o, e); return 2 & r && "function" == typeof p ? function (t) { return p.apply(e, t); } : p; }
 import React, { useCallback, useState } from 'react';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { isSSR } from '../core-utils';
 import ReactNodeView from '../react-node-view';
 import { Extension } from './Extension';
@@ -130,7 +129,7 @@ export var ExtensionNode = /*#__PURE__*/function (_ReactNodeView) {
     value: function createDomRef() {
       // SSR DOM reuse takes precedence over preset height — when eligible, adopt the
       // server-rendered element directly so React hydration is deferred until update().
-      if (!isSSR() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow() && expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+      if (!isSSR() && isSSRHydrationEligible(this.node) && this.isInInitialHydrationWindow()) {
         var ssrElement = this.findSSRElement();
         if (ssrElement) {
           this.didReuseSsrDom = true;
@@ -201,22 +200,18 @@ export var ExtensionNode = /*#__PURE__*/function (_ReactNodeView) {
   }, {
     key: "init",
     value: function init() {
-      if (!expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
-        _superPropGet(ExtensionNode, "init", this, 3)([]);
-      } else {
-        var isEligibleForSsrReuse = !isSSR() && isSSRHydrationEligible(this.node);
-        if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
-          var ssrElement = this.findSSRElement();
-          var shouldSkipInitRender = ssrElement !== null;
-          _superPropGet(ExtensionNode, "init", this, 3)([shouldSkipInitRender]);
-          var identityKey = this.getHydrationIdentityKey();
-          if (identityKey !== null) {
-            // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
-            markHydrationIdentityAsConsumed(this.view, identityKey);
-          }
-        } else {
-          _superPropGet(ExtensionNode, "init", this, 3)([]);
+      var isEligibleForSsrReuse = !isSSR() && isSSRHydrationEligible(this.node);
+      if (isEligibleForSsrReuse && this.isInInitialHydrationWindow()) {
+        var ssrElement = this.findSSRElement();
+        var shouldSkipInitRender = ssrElement !== null;
+        _superPropGet(ExtensionNode, "init", this, 3)([shouldSkipInitRender]);
+        var identityKey = this.getHydrationIdentityKey();
+        if (identityKey !== null) {
+          // Close the hydration window — see {@link consumedHydrationIdentitiesByEditor}.
+          markHydrationIdentityAsConsumed(this.view, identityKey);
         }
+      } else {
+        _superPropGet(ExtensionNode, "init", this, 3)([]);
       }
       return this;
     }
@@ -228,7 +223,7 @@ export var ExtensionNode = /*#__PURE__*/function (_ReactNodeView) {
       };
       // Remove extensionNodeWrapper aka span.relative if we previously reused SSR DOM
       // control is back to React afterwards
-      if (this.didReuseSsrDom && expValEquals('platform_editor_hydration_skip_react_portal', 'isEnabled', true)) {
+      if (this.didReuseSsrDom) {
         var ssrElement = this.findSSRElement();
         if (ssrElement) {
           var extensionNodeWrapper = ssrElement.querySelector('[data-testid="extension-node-wrapper"]');

package/dist/esm/messages/find-replace.js

@@ -25,6 +25,11 @@ export var findReplaceMessages = defineMessages({
     defaultMessage: 'Find and Replace',
     description: 'Aria label for the "Find and Replace" dialog'
   },
+  findDialogAriaLabel: {
+    id: 'fabric.editor.findDialogAriaLabel',
+    defaultMessage: 'Find',
+    description: 'Aria label for the "Find" dialog, used where the dialog offers find without replace'
+  },
   closeFindReplaceDialog: {
     id: 'fabric.editor.closeFindReplaceDialog',
     defaultMessage: 'Close',

package/dist/esm/monitoring/error.js

@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "125.0.0";
+var packageVersion = "125.2.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "125.0.0";
+var packageVersion = "125.2.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/analytics/types/find-replace-events.d.ts

@@ -1,6 +1,8 @@
 import type { ACTION, ACTION_SUBJECT, INPUT_METHOD, TRIGGER_METHOD } from './enums';
 import type { TrackAEP, UIAEP } from './utils';
 type ActivateAEP = UIAEP<ACTION.ACTIVATED, ACTION_SUBJECT.FIND_REPLACE_DIALOG, undefined, {
+    /** The editor mode when the dialog opened. */
+    editorViewMode?: 'view' | 'edit';
     inputMethod: INPUT_METHOD.KEYBOARD | INPUT_METHOD.PREFILL;
     triggerMethod: TRIGGER_METHOD.SHORTCUT | TRIGGER_METHOD.TOOLBAR | TRIGGER_METHOD.EXTERNAL;
 }, undefined>;

package/dist/types/messages/find-replace.d.ts

@@ -1,67 +1,72 @@
 export declare const findReplaceMessages: {
-    find: {
-        id: string;
+    closeFindReplaceDialog: {
         defaultMessage: string;
         description: string;
+        id: string;
     };
-    matchCase: {
+    find: {
+        defaultMessage: string;
+        description: string;
         id: string;
+    };
+    findDialogAriaLabel: {
         defaultMessage: string;
         description: string;
+        id: string;
     };
     findNext: {
-        id: string;
         defaultMessage: string;
         description: string;
+        id: string;
     };
     findPrevious: {
-        id: string;
         defaultMessage: string;
         description: string;
+        id: string;
     };
     findReplaceDialogAriaLabel: {
-        id: string;
         defaultMessage: string;
         description: string;
-    };
-    closeFindReplaceDialog: {
         id: string;
-        defaultMessage: string;
-        description: string;
     };
-    noResultsFound: {
-        id: string;
+    findReplaceToolbarButton: {
         defaultMessage: string;
         description: string;
-    };
-    resultsCount: {
         id: string;
-        description: string;
-        defaultMessage: string;
     };
-    findReplaceToolbarButton: {
-        id: string;
+    matchCase: {
         defaultMessage: string;
         description: string;
-    };
-    replaceWith: {
         id: string;
+    };
+    noResultsFound: {
         defaultMessage: string;
         description: string;
+        id: string;
     };
     replace: {
-        id: string;
         defaultMessage: string;
         description: string;
+        id: string;
     };
     replaceAll: {
-        id: string;
         defaultMessage: string;
         description: string;
+        id: string;
     };
     replaceSuccess: {
+        defaultMessage: string;
+        description: string;
+        id: string;
+    };
+    replaceWith: {
+        defaultMessage: string;
+        description: string;
         id: string;
+    };
+    resultsCount: {
         defaultMessage: string;
         description: string;
+        id: string;
     };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "125.1.0",
+	"version": "125.2.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -84,7 +84,7 @@
 		"@atlaskit/task-decision": "^21.10.0",
 		"@atlaskit/teams-app-config": "^3.1.0",
 		"@atlaskit/textfield": "^10.2.0",
-		"@atlaskit/tmp-editor-statsig": "^206.0.0",
+		"@atlaskit/tmp-editor-statsig": "^208.0.0",
 		"@atlaskit/tokens": "^20.0.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@atlaskit/width-detector": "^7.2.0",