@atlaskit/editor-common 123.7.0 → 123.7.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-common
 
+## 123.7.1
+
+### Patch Changes
+
+- [`6d07b4f04155f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6d07b4f04155f) -
+  Cleanup `feature gate` `jim-lower-ranking-in-jira-macro-search`. Quick insert search now always
+  ranks the Jira work items (datasource) item above the legacy Jira macro when their scores are
+  close, and the Jira work items quick insert item always has a priority of 500.
+- Updated dependencies
+
 ## 123.7.0
 
 ### Minor Changes

package/dist/cjs/monitoring/error.js

@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.6.0";
+var packageVersion = "123.7.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/quick-insert/utils.js

@@ -11,7 +11,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _fuse = _interopRequireDefault(require("fuse.js"));
 var _memoizeOne = _interopRequireDefault(require("memoize-one"));
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _boostNativeResultsAboveSkills = require("./boost-native-results-above-skills");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -68,6 +67,7 @@ var options = {
  */
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
 function find(query, items, prioritySortingFn) {
+  var _rerankedResults$data, _rerankedResults$lega;
   if (query === '') {
     // Copy and sort list by priority
     return items.slice(0).sort(function (a, b) {
@@ -88,26 +88,24 @@ function find(query, items, prioritySortingFn) {
 
   // platform_editor_insert_menu_ai: boost native editor elements above skills
   var rerankedResults = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_insert_menu_ai') ? (0, _boostNativeResultsAboveSkills.boostNativeResultsAboveSkills)(results) : results;
-  if ((0, _fg.fg)('jim-lower-ranking-in-jira-macro-search')) {
-    var _rerankedResults$data, _rerankedResults$lega;
-    // searching for jira work items macro first
-    var datasourceIndex = rerankedResults.findIndex(function (r) {
-      var _r$item$keywords;
-      return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
-    });
 
-    //  then searching for the legacy jira macro
-    var legacyIndex = rerankedResults.findIndex(function (r) {
-      return typeof r.item.key === 'string' && r.item.key.endsWith(':jira');
-    });
+  // searching for jira work items macro first
+  var datasourceIndex = rerankedResults.findIndex(function (r) {
+    var _r$item$keywords;
+    return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
+  });
 
-    // the jira legcy macro is found before the jira work items macro then swap the two
-    if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
-      var _rerankedResults$spli = rerankedResults.splice(datasourceIndex, 1),
-        _rerankedResults$spli2 = (0, _slicedToArray2.default)(_rerankedResults$spli, 1),
-        datasource = _rerankedResults$spli2[0];
-      rerankedResults.splice(legacyIndex, 0, datasource);
-    }
+  //  then searching for the legacy jira macro
+  var legacyIndex = rerankedResults.findIndex(function (r) {
+    return typeof r.item.key === 'string' && r.item.key.endsWith(':jira');
+  });
+
+  // the jira legcy macro is found before the jira work items macro then swap the two
+  if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
+    var _rerankedResults$spli = rerankedResults.splice(datasourceIndex, 1),
+      _rerankedResults$spli2 = (0, _slicedToArray2.default)(_rerankedResults$spli, 1),
+      datasource = _rerankedResults$spli2[0];
+    rerankedResults.splice(legacyIndex, 0, datasource);
   }
   return rerankedResults.map(function (result) {
     return result.item;

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.6.0";
+var packageVersion = "123.7.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/monitoring/error.js

@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "123.6.0";
+const packageVersion = "123.7.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/quick-insert/utils.js

@@ -1,7 +1,6 @@
 import Fuse from 'fuse.js';
 import memoizeOne from 'memoize-one';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { boostNativeResultsAboveSkills } from './boost-native-results-above-skills';
 const processQuickInsertItems = (items, intl) => {
   return items.reduce((acc, item) => {
@@ -52,6 +51,7 @@ const options = {
  */
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
 export function find(query, items, prioritySortingFn) {
+  var _rerankedResults$data, _rerankedResults$lega;
   if (query === '') {
     // Copy and sort list by priority
     return items.slice(0).sort((a, b) => (a.priority || Number.POSITIVE_INFINITY) - (b.priority || Number.POSITIVE_INFINITY));
@@ -72,22 +72,20 @@ export function find(query, items, prioritySortingFn) {
 
   // platform_editor_insert_menu_ai: boost native editor elements above skills
   const rerankedResults = isExperimentEnabled('platform_editor_insert_menu_ai') ? boostNativeResultsAboveSkills(results) : results;
-  if (fg('jim-lower-ranking-in-jira-macro-search')) {
-    var _rerankedResults$data, _rerankedResults$lega;
-    // searching for jira work items macro first
-    const datasourceIndex = rerankedResults.findIndex(r => {
-      var _r$item$keywords;
-      return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
-    });
 
-    //  then searching for the legacy jira macro
-    const legacyIndex = rerankedResults.findIndex(r => typeof r.item.key === 'string' && r.item.key.endsWith(':jira'));
+  // searching for jira work items macro first
+  const datasourceIndex = rerankedResults.findIndex(r => {
+    var _r$item$keywords;
+    return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
+  });
 
-    // the jira legcy macro is found before the jira work items macro then swap the two
-    if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
-      const [datasource] = rerankedResults.splice(datasourceIndex, 1);
-      rerankedResults.splice(legacyIndex, 0, datasource);
-    }
+  //  then searching for the legacy jira macro
+  const legacyIndex = rerankedResults.findIndex(r => typeof r.item.key === 'string' && r.item.key.endsWith(':jira'));
+
+  // the jira legcy macro is found before the jira work items macro then swap the two
+  if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
+    const [datasource] = rerankedResults.splice(datasourceIndex, 1);
+    rerankedResults.splice(legacyIndex, 0, datasource);
   }
   return rerankedResults.map(result => result.item);
 }

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "123.6.0";
+const packageVersion = "123.7.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/monitoring/error.js

@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.6.0";
+var packageVersion = "123.7.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/quick-insert/utils.js

@@ -5,7 +5,6 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import Fuse from 'fuse.js';
 import memoizeOne from 'memoize-one';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { boostNativeResultsAboveSkills } from './boost-native-results-above-skills';
 var processQuickInsertItems = function processQuickInsertItems(items, intl) {
   return items.reduce(function (acc, item) {
@@ -60,6 +59,7 @@ var options = {
  */
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
 export function find(query, items, prioritySortingFn) {
+  var _rerankedResults$data, _rerankedResults$lega;
   if (query === '') {
     // Copy and sort list by priority
     return items.slice(0).sort(function (a, b) {
@@ -80,26 +80,24 @@ export function find(query, items, prioritySortingFn) {
 
   // platform_editor_insert_menu_ai: boost native editor elements above skills
   var rerankedResults = isExperimentEnabled('platform_editor_insert_menu_ai') ? boostNativeResultsAboveSkills(results) : results;
-  if (fg('jim-lower-ranking-in-jira-macro-search')) {
-    var _rerankedResults$data, _rerankedResults$lega;
-    // searching for jira work items macro first
-    var datasourceIndex = rerankedResults.findIndex(function (r) {
-      var _r$item$keywords;
-      return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
-    });
 
-    //  then searching for the legacy jira macro
-    var legacyIndex = rerankedResults.findIndex(function (r) {
-      return typeof r.item.key === 'string' && r.item.key.endsWith(':jira');
-    });
+  // searching for jira work items macro first
+  var datasourceIndex = rerankedResults.findIndex(function (r) {
+    var _r$item$keywords;
+    return r.item.id === 'datasource' && ((_r$item$keywords = r.item.keywords) === null || _r$item$keywords === void 0 ? void 0 : _r$item$keywords.includes('jira'));
+  });
 
-    // the jira legcy macro is found before the jira work items macro then swap the two
-    if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
-      var _rerankedResults$spli = rerankedResults.splice(datasourceIndex, 1),
-        _rerankedResults$spli2 = _slicedToArray(_rerankedResults$spli, 1),
-        datasource = _rerankedResults$spli2[0];
-      rerankedResults.splice(legacyIndex, 0, datasource);
-    }
+  //  then searching for the legacy jira macro
+  var legacyIndex = rerankedResults.findIndex(function (r) {
+    return typeof r.item.key === 'string' && r.item.key.endsWith(':jira');
+  });
+
+  // the jira legcy macro is found before the jira work items macro then swap the two
+  if (datasourceIndex > 0 && legacyIndex >= 0 && legacyIndex < datasourceIndex && Math.abs(((_rerankedResults$data = rerankedResults[datasourceIndex].score) !== null && _rerankedResults$data !== void 0 ? _rerankedResults$data : 0) - ((_rerankedResults$lega = rerankedResults[legacyIndex].score) !== null && _rerankedResults$lega !== void 0 ? _rerankedResults$lega : 0)) < 0.2) {
+    var _rerankedResults$spli = rerankedResults.splice(datasourceIndex, 1),
+      _rerankedResults$spli2 = _slicedToArray(_rerankedResults$spli, 1),
+      datasource = _rerankedResults$spli2[0];
+    rerankedResults.splice(legacyIndex, 0, datasource);
   }
   return rerankedResults.map(function (result) {
     return result.item;

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.6.0";
+var packageVersion = "123.7.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "123.7.0",
+	"version": "123.7.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -54,8 +54,8 @@
 		"@atlaskit/feature-gate-js-client": "^6.0.0",
 		"@atlaskit/icon": "^37.7.0",
 		"@atlaskit/link": "^5.1.0",
-		"@atlaskit/link-datasource": "^6.13.0",
-		"@atlaskit/link-picker": "^6.8.0",
+		"@atlaskit/link-datasource": "^6.14.0",
+		"@atlaskit/link-picker": "^6.9.0",
 		"@atlaskit/media-card": "^81.12.0",
 		"@atlaskit/media-client": "^38.1.0",
 		"@atlaskit/media-client-react": "^6.4.0",
@@ -78,14 +78,14 @@
 		"@atlaskit/react-compiler-gating": "^0.2.0",
 		"@atlaskit/react-ufo": "^7.13.0",
 		"@atlaskit/section-message": "^10.2.0",
-		"@atlaskit/smart-card": "^45.26.0",
-		"@atlaskit/smart-user-picker": "^11.8.0",
+		"@atlaskit/smart-card": "^45.28.0",
+		"@atlaskit/smart-user-picker": "^11.9.0",
 		"@atlaskit/spinner": "^20.4.0",
 		"@atlaskit/task-decision": "^21.10.0",
 		"@atlaskit/teams-app-config": "^3.1.0",
 		"@atlaskit/textfield": "^10.2.0",
 		"@atlaskit/tmp-editor-statsig": "^202.0.0",
-		"@atlaskit/tokens": "^18.2.0",
+		"@atlaskit/tokens": "^18.3.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@atlaskit/width-detector": "^7.2.0",
 		"@babel/runtime": "^7.0.0",
@@ -216,9 +216,6 @@
 		"platform_editor_content_mode_button_mvp": {
 			"type": "boolean"
 		},
-		"jim-lower-ranking-in-jira-macro-search": {
-			"type": "boolean"
-		},
 		"people-teams_migrate-user-profile-card": {
 			"type": "boolean"
 		},