@atlaskit/editor-common 123.4.2 → 123.5.1

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # @atlaskit/editor-common
 
+## 123.5.1
+
+### Patch Changes
+
+- [`74360ce048e56`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/74360ce048e56) -
+  FFCLEANUP-196833 Cleanup `platform_editor_adf_validator_stage0`
+- Updated dependencies
+
+## 123.5.0
+
+### Minor Changes
+
+- [`c4d3272bbafce`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c4d3272bbafce) -
+  Add an opt-in LinkPickerOptions.popupContainerSurface ('default' | 'none') that lets a custom link
+  picker component (e.g. RovoLinkPicker) suppress the editor's floating toolbar popup surface
+  (background, box-shadow, border-radius, padding) when it renders its own complete surface.
+  Threaded through FloatingToolbarConfig/Toolbar's new containerSurface prop. Defaults to the
+  existing wrapper surface; only a caller that explicitly opts in is affected.
+
+### Patch Changes
+
+- [`3f8ea6c51b718`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3f8ea6c51b718) -
+  Remove the rolled-out `editor_tinymce_full_width_mode` and
+  `confluence_max_width_content_appearance` experiments and make max-width content behavior
+  permanent.
+- Updated dependencies
+
 ## 123.4.2
 
 ### Patch Changes

package/dist/cjs/extensibility/Extension/Extension/index.js

@@ -85,13 +85,11 @@ function ExtensionWithPluginState(props) {
     return typeof pos !== 'undefined' && !isNaN(pos) && view.state.doc.resolve(pos).depth === 0;
   }, [view, getPos]);
   var layout = node.attrs.layout;
-  var legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && isTopLevelNode && editorAppearance !== 'full-width';
-  var tinymceFullWidthModeEnabled = (0, _expValEquals.expValEquals)('confluence_max_width_content_appearance', 'isEnabled', true);
-  var shouldBreakout = tinymceFullWidthModeEnabled ? (0, _shouldExtensionBreakout.shouldExtensionBreakout)({
+  var shouldBreakout = (0, _shouldExtensionBreakout.shouldExtensionBreakout)({
     layout: layout,
     isTopLevelNode: isTopLevelNode,
     editorAppearance: editorAppearance
-  }) : legacyShouldBreakout;
+  });
 
   // We don't want to show border for non-empty 1p bodied extensions in live pages
   var show1PBodiedExtensionBorder = showUpdatedLivePages1PBodiedExtensionUI ? (0, _extensionUtils.isEmptyBodiedMacro)(node) : true;

package/dist/cjs/extensibility/MultiBodiedExtension/index.js

@@ -270,14 +270,11 @@ var MultiBodiedExtensionWithWidth = function MultiBodiedExtensionWithWidth(_ref2
     return tryExtensionHandler(actions);
   }, [tryExtensionHandler, actions]);
   var layout = node.attrs.layout;
-  var legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && editorAppearance !== 'full-width';
-  var tinymceFullWidthModeEnabled = (0, _expValEquals.expValEquals)('confluence_max_width_content_appearance', 'isEnabled', true);
-  var shouldUseBreakoutFix = tinymceFullWidthModeEnabled;
-  var shouldBreakout = shouldUseBreakoutFix ? (0, _shouldExtensionBreakout.shouldExtensionBreakout)({
+  var shouldBreakout = (0, _shouldExtensionBreakout.shouldExtensionBreakout)({
     layout: layout,
     editorAppearance: editorAppearance,
     isTopLevelNode: true
-  }) : legacyShouldBreakout;
+  });
   var mbeWrapperStyles = {};
   if (shouldBreakout) {
     var _calculateBreakoutSty = (0, _utils.calculateBreakoutStyles)({

package/dist/cjs/monitoring/error.js

@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.4.1";
+var packageVersion = "123.5.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.4.1";
+var packageVersion = "123.5.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/utils/validate-using-spec.js

@@ -13,7 +13,6 @@ Object.defineProperty(exports, "wrapWithUnsupported", {
 });
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _validator = require("@atlaskit/adf-utils/validator");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _analytics = require("../analytics");
 var _ADFStages = require("./ADFStages");
 var _trackUnsupportedContent = require("./track-unsupported-content");
@@ -94,28 +93,14 @@ var validationErrorHandler = exports.validationErrorHandler = function validatio
     }
   }
 
-  // panel_c1 is a ProseMirror-only variant: on save, table-in-panel documents are stored as
-  // plain ADF `panel` nodes containing a `table`. The base validator-spec does not permit
-  // `table` inside `panel`, so suppress the INVALID_CONTENT error when the experiment is active.
-  // This suppression is blunt, allowing a table in every panel, and applies only while
-  // `platform_editor_adf_validator_stage0` is off. With that gate on, adf-utils offers the stage-0
-  // `panel_c1` variants and accepts table-in-panel positionally instead, in `doc`, a layout column
-  // and a synced block only.
-  if (options.allowTableInPanel && !(0, _fg.fg)('platform_editor_adf_validator_stage0')) {
-    var _meta = error.meta;
-    if ((_meta === null || _meta === void 0 ? void 0 : _meta.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'table') {
-      return entity;
-    }
-  }
-
   // panel_c1 is a ProseMirror-only variant: on save, expand-in-panel documents are stored as
   // plain ADF `panel` nodes containing an `expand`. The base validator-spec does not permit
   // `expand` inside `panel` (it's gated behind the consolidated container-in-panel experiment,
   // see `isPanelNestingContainerSupported`), so we suppress the INVALID_CONTENT error when
   // `allowContainerInPanel` is set.
   if (options.allowContainerInPanel) {
-    var _meta2 = error.meta;
-    if ((_meta2 === null || _meta2 === void 0 ? void 0 : _meta2.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'expand') {
+    var _meta = error.meta;
+    if ((_meta === null || _meta === void 0 ? void 0 : _meta.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'expand') {
       return entity;
     }
   }
@@ -179,7 +164,6 @@ var validateADFEntity = exports.validateADFEntity = function validateADFEntity(s
   // because a document holding a stage-0-only construct, such as a `layoutSection` with one column,
   // otherwise has that content wrapped as unsupported. Editors carry such constructs by design,
   // since the editor's own schema enables them, and renderers meet them in stored documents.
-  // `stage0` is only observable while `platform_editor_adf_validator_stage0` is enabled.
   var validate = (0, _validator.validator)(nodes, marks, {
     allowPrivateAttributes: true,
     stage0: adfStage !== _ADFStages.ADFStages.FINAL

package/dist/es2019/extensibility/Extension/Extension/index.js

@@ -78,13 +78,11 @@ function ExtensionWithPluginState(props) {
     return typeof pos !== 'undefined' && !isNaN(pos) && view.state.doc.resolve(pos).depth === 0;
   }, [view, getPos]);
   const layout = node.attrs.layout;
-  const legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && isTopLevelNode && editorAppearance !== 'full-width';
-  const tinymceFullWidthModeEnabled = expValEquals('confluence_max_width_content_appearance', 'isEnabled', true);
-  const shouldBreakout = tinymceFullWidthModeEnabled ? shouldExtensionBreakout({
+  const shouldBreakout = shouldExtensionBreakout({
     layout,
     isTopLevelNode,
     editorAppearance
-  }) : legacyShouldBreakout;
+  });
 
   // We don't want to show border for non-empty 1p bodied extensions in live pages
   const show1PBodiedExtensionBorder = showUpdatedLivePages1PBodiedExtensionUI ? isEmptyBodiedMacro(node) : true;

package/dist/es2019/extensibility/MultiBodiedExtension/index.js

@@ -263,14 +263,11 @@ const MultiBodiedExtensionWithWidth = ({
     return tryExtensionHandler(actions);
   }, [tryExtensionHandler, actions]);
   const layout = node.attrs.layout;
-  const legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && editorAppearance !== 'full-width';
-  const tinymceFullWidthModeEnabled = expValEquals('confluence_max_width_content_appearance', 'isEnabled', true);
-  const shouldUseBreakoutFix = tinymceFullWidthModeEnabled;
-  const shouldBreakout = shouldUseBreakoutFix ? shouldExtensionBreakout({
+  const shouldBreakout = shouldExtensionBreakout({
     layout,
     editorAppearance,
     isTopLevelNode: true
-  }) : legacyShouldBreakout;
+  });
   let mbeWrapperStyles = {};
   if (shouldBreakout) {
     const {

package/dist/es2019/monitoring/error.js

@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "123.4.1";
+const packageVersion = "123.5.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "123.4.1";
+const packageVersion = "123.5.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/utils/validate-using-spec.js

@@ -1,5 +1,4 @@
 import { validator } from '@atlaskit/adf-utils/validator';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { ACTION_SUBJECT_ID } from '../analytics';
 export const UNSUPPORTED_NODE_ATTRIBUTE = 'unsupportedNodeAttribute';
 import { ADFStages } from './ADFStages';
@@ -79,20 +78,6 @@ export const validationErrorHandler = (entity, error, options, marks, validate,
     }
   }
 
-  // panel_c1 is a ProseMirror-only variant: on save, table-in-panel documents are stored as
-  // plain ADF `panel` nodes containing a `table`. The base validator-spec does not permit
-  // `table` inside `panel`, so suppress the INVALID_CONTENT error when the experiment is active.
-  // This suppression is blunt, allowing a table in every panel, and applies only while
-  // `platform_editor_adf_validator_stage0` is off. With that gate on, adf-utils offers the stage-0
-  // `panel_c1` variants and accepts table-in-panel positionally instead, in `doc`, a layout column
-  // and a synced block only.
-  if (options.allowTableInPanel && !fg('platform_editor_adf_validator_stage0')) {
-    const meta = error.meta;
-    if ((meta === null || meta === void 0 ? void 0 : meta.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'table') {
-      return entity;
-    }
-  }
-
   // panel_c1 is a ProseMirror-only variant: on save, expand-in-panel documents are stored as
   // plain ADF `panel` nodes containing an `expand`. The base validator-spec does not permit
   // `expand` inside `panel` (it's gated behind the consolidated container-in-panel experiment,
@@ -160,7 +145,6 @@ export const validateADFEntity = (schema, node, dispatchAnalyticsEvent, validati
   // because a document holding a stage-0-only construct, such as a `layoutSection` with one column,
   // otherwise has that content wrapped as unsupported. Editors carry such constructs by design,
   // since the editor's own schema enables them, and renderers meet them in stored documents.
-  // `stage0` is only observable while `platform_editor_adf_validator_stage0` is enabled.
   const validate = validator(nodes, marks, {
     allowPrivateAttributes: true,
     stage0: adfStage !== ADFStages.FINAL

package/dist/esm/extensibility/Extension/Extension/index.js

@@ -78,13 +78,11 @@ function ExtensionWithPluginState(props) {
     return typeof pos !== 'undefined' && !isNaN(pos) && view.state.doc.resolve(pos).depth === 0;
   }, [view, getPos]);
   var layout = node.attrs.layout;
-  var legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && isTopLevelNode && editorAppearance !== 'full-width';
-  var tinymceFullWidthModeEnabled = expValEquals('confluence_max_width_content_appearance', 'isEnabled', true);
-  var shouldBreakout = tinymceFullWidthModeEnabled ? shouldExtensionBreakout({
+  var shouldBreakout = shouldExtensionBreakout({
     layout: layout,
     isTopLevelNode: isTopLevelNode,
     editorAppearance: editorAppearance
-  }) : legacyShouldBreakout;
+  });
 
   // We don't want to show border for non-empty 1p bodied extensions in live pages
   var show1PBodiedExtensionBorder = showUpdatedLivePages1PBodiedExtensionUI ? isEmptyBodiedMacro(node) : true;

package/dist/esm/extensibility/MultiBodiedExtension/index.js

@@ -263,14 +263,11 @@ var MultiBodiedExtensionWithWidth = function MultiBodiedExtensionWithWidth(_ref2
     return tryExtensionHandler(actions);
   }, [tryExtensionHandler, actions]);
   var layout = node.attrs.layout;
-  var legacyShouldBreakout = ['full-width', 'wide'].includes(layout) && editorAppearance !== 'full-width';
-  var tinymceFullWidthModeEnabled = expValEquals('confluence_max_width_content_appearance', 'isEnabled', true);
-  var shouldUseBreakoutFix = tinymceFullWidthModeEnabled;
-  var shouldBreakout = shouldUseBreakoutFix ? shouldExtensionBreakout({
+  var shouldBreakout = shouldExtensionBreakout({
     layout: layout,
     editorAppearance: editorAppearance,
     isTopLevelNode: true
-  }) : legacyShouldBreakout;
+  });
   var mbeWrapperStyles = {};
   if (shouldBreakout) {
     var _calculateBreakoutSty = calculateBreakoutStyles({

package/dist/esm/monitoring/error.js

@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.4.1";
+var packageVersion = "123.5.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.4.1";
+var packageVersion = "123.5.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/utils/validate-using-spec.js

@@ -2,7 +2,6 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import { validator } from '@atlaskit/adf-utils/validator';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { ACTION_SUBJECT_ID } from '../analytics';
 export var UNSUPPORTED_NODE_ATTRIBUTE = 'unsupportedNodeAttribute';
 import { ADFStages } from './ADFStages';
@@ -81,28 +80,14 @@ export var validationErrorHandler = function validationErrorHandler(entity, erro
     }
   }
 
-  // panel_c1 is a ProseMirror-only variant: on save, table-in-panel documents are stored as
-  // plain ADF `panel` nodes containing a `table`. The base validator-spec does not permit
-  // `table` inside `panel`, so suppress the INVALID_CONTENT error when the experiment is active.
-  // This suppression is blunt, allowing a table in every panel, and applies only while
-  // `platform_editor_adf_validator_stage0` is off. With that gate on, adf-utils offers the stage-0
-  // `panel_c1` variants and accepts table-in-panel positionally instead, in `doc`, a layout column
-  // and a synced block only.
-  if (options.allowTableInPanel && !fg('platform_editor_adf_validator_stage0')) {
-    var _meta = error.meta;
-    if ((_meta === null || _meta === void 0 ? void 0 : _meta.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'table') {
-      return entity;
-    }
-  }
-
   // panel_c1 is a ProseMirror-only variant: on save, expand-in-panel documents are stored as
   // plain ADF `panel` nodes containing an `expand`. The base validator-spec does not permit
   // `expand` inside `panel` (it's gated behind the consolidated container-in-panel experiment,
   // see `isPanelNestingContainerSupported`), so we suppress the INVALID_CONTENT error when
   // `allowContainerInPanel` is set.
   if (options.allowContainerInPanel) {
-    var _meta2 = error.meta;
-    if ((_meta2 === null || _meta2 === void 0 ? void 0 : _meta2.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'expand') {
+    var _meta = error.meta;
+    if ((_meta === null || _meta === void 0 ? void 0 : _meta.parentType) === 'panel' && error.code === 'INVALID_CONTENT' && entity.type === 'expand') {
       return entity;
     }
   }
@@ -166,7 +151,6 @@ export var validateADFEntity = function validateADFEntity(schema, node, dispatch
   // because a document holding a stage-0-only construct, such as a `layoutSection` with one column,
   // otherwise has that content wrapped as unsupported. Editors carry such constructs by design,
   // since the editor's own schema enables them, and renderers meet them in stored documents.
-  // `stage0` is only observable while `platform_editor_adf_validator_stage0` is enabled.
   var validate = validator(nodes, marks, {
     allowPrivateAttributes: true,
     stage0: adfStage !== ADFStages.FINAL

package/dist/types/types/floating-toolbar.d.ts

@@ -329,6 +329,13 @@ export interface FloatingToolbarConfig {
     align?: AlignType;
     /** Class added to Toolbar wrapper */
     className?: string;
+    /**
+     * Controls the Toolbar wrapper's own visual surface (background, shadow, border radius,
+     * padding). Set to `'none'` when a single custom item already renders its own complete
+     * surface (e.g. a custom link picker component), so the wrapper's surface isn't duplicated
+     * behind it. Defaults to `'default'` (the wrapper's surface, as today).
+     */
+    containerSurface?: 'default' | 'none';
     /**
      * Enable Popup component's focus trap
      */

package/dist/types/types/hyperlink.d.ts

@@ -8,8 +8,12 @@ export type LinkInputType = INPUT_METHOD.MANUAL | INPUT_METHOD.TYPEAHEAD;
  * Extends `LinkPickerProps` to provide future extensibility out-of-the-box.
  * Use `popupWidth` and `popupHeight` to control the editor popup container size
  * when providing a custom `component` with non-standard dimensions.
+ * Use `popupContainerSurface: 'none'` when that `component` renders its own complete
+ * surface (background, shadow, border radius, padding), so the popup wrapper's own
+ * surface isn't duplicated behind it. Defaults to `'default'` (the wrapper's surface).
  */
 export type LinkPickerOptions = Partial<LinkPickerProps> & {
+    popupContainerSurface?: 'default' | 'none';
     popupHeight?: number;
     popupWidth?: number;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "123.4.2",
+	"version": "123.5.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -84,7 +84,7 @@
 		"@atlaskit/task-decision": "^21.10.0",
 		"@atlaskit/teams-app-config": "^3.1.0",
 		"@atlaskit/textfield": "^10.2.0",
-		"@atlaskit/tmp-editor-statsig": "^201.0.0",
+		"@atlaskit/tmp-editor-statsig": "^202.0.0",
 		"@atlaskit/tokens": "^18.2.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@atlaskit/width-detector": "^7.2.0",
@@ -162,10 +162,6 @@
 		"platform_editor_hide_configure_lozenge_non_configurable": {
 			"type": "boolean"
 		},
-		"platform_editor_adf_validator_stage0": {
-			"type": "boolean",
-			"referenceOnly": true
-		},
 		"rovo_skill_tag_label_wrapping": {
 			"type": "boolean",
 			"referenceOnly": true