@atlaskit/editor-common 123.4.0 → 123.4.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-common
 
+## 123.4.2
+
+### Patch Changes
+
+- [`64df9f13a541c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/64df9f13a541c) -
+  [ux] Use the yellow accent icon token for the media comment badge icon instead of inheriting
+  `currentColor`. Gated behind the `cc_comments_media_viewer_sidebar` experiment; with the
+  experiment off both `CommentBadge` and `CommentBadgeNext` keep the existing `currentColor` icon.
+
+## 123.4.1
+
+### Patch Changes
+
+- [`f335cea2c93d7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f335cea2c93d7) -
+  Correct the combined extension provider return type to reflect that `preload` is always available.
+- Updated dependencies
+
 ## 123.4.0
 
 ### Minor Changes

package/dist/cjs/media-single/CommentBadge.js

@@ -129,7 +129,7 @@ var CommentBadge = exports.CommentBadge = /*#__PURE__*/(0, _react.forwardRef)(fu
     iconAfter: (0, _react2.jsx)(_comment.default, {
       label: title,
       spacing: "spacious",
-      color: "currentColor"
+      color: (0, _isExperimentEnabled.isExperimentEnabled)('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
     })
   })));
 });

package/dist/cjs/media-single/CommentBadgeNext.js

@@ -9,6 +9,7 @@ exports.CommentBadgeNext = void 0;
 var _react = _interopRequireWildcard(require("react"));
 var _reactIntl = require("react-intl");
 var _comment = _interopRequireDefault(require("@atlaskit/icon/core/comment"));
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _primitives = require("@atlaskit/primitives");
 var _Tooltip = _interopRequireDefault(require("@atlaskit/tooltip/Tooltip"));
 var _media = require("../media");
@@ -55,6 +56,6 @@ var CommentBadgeNext = exports.CommentBadgeNext = function CommentBadgeNext(_ref
   }, /*#__PURE__*/_react.default.createElement(_comment.default, {
     label: title,
     spacing: "spacious",
-    color: "currentColor"
+    color: (0, _isExperimentEnabled.isExperimentEnabled)('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
   })));
 };

package/dist/cjs/monitoring/error.js

@@ -27,7 +27,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.3.0";
+var packageVersion = "123.4.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.3.0";
+var packageVersion = "123.4.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/media-single/CommentBadge.js

@@ -106,7 +106,7 @@ export const CommentBadge = /*#__PURE__*/forwardRef(({
     iconAfter: jsx(CommentIcon, {
       label: title,
       spacing: "spacious",
-      color: "currentColor"
+      color: isExperimentEnabled('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
     })
   })));
 });

package/dist/es2019/media-single/CommentBadgeNext.js

@@ -1,6 +1,7 @@
 import React, { useMemo } from 'react';
 import { useIntl } from 'react-intl';
 import CommentIcon from '@atlaskit/icon/core/comment';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 // eslint-disable-next-line @atlaskit/design-system/no-emotion-primitives -- to be migrated to @atlaskit/primitives/compiled – go/akcss
 import { Pressable, xcss } from '@atlaskit/primitives';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
@@ -45,6 +46,6 @@ export const CommentBadgeNext = ({
   }, /*#__PURE__*/React.createElement(CommentIcon, {
     label: title,
     spacing: "spacious",
-    color: "currentColor"
+    color: isExperimentEnabled('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
   })));
 };

package/dist/es2019/monitoring/error.js

@@ -13,7 +13,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "123.3.0";
+const packageVersion = "123.4.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "123.3.0";
+const packageVersion = "123.4.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/media-single/CommentBadge.js

@@ -114,7 +114,7 @@ export var CommentBadge = /*#__PURE__*/forwardRef(function (_ref, ref) {
     iconAfter: jsx(CommentIcon, {
       label: title,
       spacing: "spacious",
-      color: "currentColor"
+      color: isExperimentEnabled('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
     })
   })));
 });

package/dist/esm/media-single/CommentBadgeNext.js

@@ -1,6 +1,7 @@
 import React, { useMemo } from 'react';
 import { useIntl } from 'react-intl';
 import CommentIcon from '@atlaskit/icon/core/comment';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 // eslint-disable-next-line @atlaskit/design-system/no-emotion-primitives -- to be migrated to @atlaskit/primitives/compiled – go/akcss
 import { Pressable, xcss } from '@atlaskit/primitives';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
@@ -45,6 +46,6 @@ export var CommentBadgeNext = function CommentBadgeNext(_ref) {
   }, /*#__PURE__*/React.createElement(CommentIcon, {
     label: title,
     spacing: "spacious",
-    color: "currentColor"
+    color: isExperimentEnabled('cc_comments_media_viewer_sidebar') ? "var(--ds-icon-accent-yellow, #B38600)" : 'currentColor'
   })));
 };

package/dist/esm/monitoring/error.js

@@ -19,7 +19,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "123.3.0";
+var packageVersion = "123.4.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "123.3.0";
+var packageVersion = "123.4.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/extensions/combine-extension-providers.d.ts

@@ -9,4 +9,6 @@ export default _default;
  * Allow to run methods from the `ExtensionProvider` interface across all providers seamlessly.
  * This handles optional explicit resolution, promise racing, and safely discarded rejections.
  */
-declare function _default(extensionProviders: (ExtensionProvider | Promise<ExtensionProvider>)[], { resolveExtension, resolvePreloadedExtension }?: CombineExtensionProvidersOptions): ExtensionProvider;
+declare function _default(extensionProviders: (ExtensionProvider | Promise<ExtensionProvider>)[], { resolveExtension, resolvePreloadedExtension }?: CombineExtensionProvidersOptions): ExtensionProvider & {
+    preload: () => Promise<void>;
+};

package/dist/types/types/floating-toolbar.d.ts

@@ -329,13 +329,6 @@ export interface FloatingToolbarConfig {
     align?: AlignType;
     /** Class added to Toolbar wrapper */
     className?: string;
-    /**
-     * Controls the Toolbar wrapper's own visual surface (background, shadow, border radius,
-     * padding). Set to `'none'` when a single custom item already renders its own complete
-     * surface (e.g. a custom link picker component), so the wrapper's surface isn't duplicated
-     * behind it. Defaults to `'default'` (the wrapper's surface, as today).
-     */
-    containerSurface?: 'default' | 'none';
     /**
      * Enable Popup component's focus trap
      */

package/dist/types/types/hyperlink.d.ts

@@ -8,12 +8,8 @@ export type LinkInputType = INPUT_METHOD.MANUAL | INPUT_METHOD.TYPEAHEAD;
  * Extends `LinkPickerProps` to provide future extensibility out-of-the-box.
  * Use `popupWidth` and `popupHeight` to control the editor popup container size
  * when providing a custom `component` with non-standard dimensions.
- * Use `popupContainerSurface: 'none'` when that `component` renders its own complete
- * surface (background, shadow, border radius, padding), so the popup wrapper's own
- * surface isn't duplicated behind it. Defaults to `'default'` (the wrapper's surface).
  */
 export type LinkPickerOptions = Partial<LinkPickerProps> & {
-    popupContainerSurface?: 'default' | 'none';
     popupHeight?: number;
     popupWidth?: number;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "123.4.0",
+	"version": "123.4.2",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -29,7 +29,7 @@
 	},
 	"dependencies": {
 		"@atlaskit/activity-provider": "^3.1.0",
-		"@atlaskit/adf-schema": "^57.5.0",
+		"@atlaskit/adf-schema": "^57.6.0",
 		"@atlaskit/adf-utils": "^20.9.0",
 		"@atlaskit/afm-i18n-platform-editor-editor-common": "2.249.0",
 		"@atlaskit/analytics-listeners": "^11.4.0",