@atlaskit/editor-common 119.10.2 → 119.11.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-common
 
+## 119.11.0
+
+### Minor Changes
+
+- [`52e80c8d44e5f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/52e80c8d44e5f) -
+  Behind `platform_editor_sanitize_selection_fragments`, `getFragmentsFromSelection` now sanitises
+  selection fragments via `JSONTransformer.encodeNode` instead of the raw `nodeToJSON`, so the
+  schema-only `panel_c1` container variant no longer leaks to Remix and other AI selection-context
+  consumers when `platform_editor_nest_table_in_panel` is enabled. `keepNestedTables: true` is
+  passed to keep nested tables intact. `encodeNode` and editor-common's `nodeToJSON` now accept
+  `SanitizeNodeOptions`, matching `encode`.
+- [`37cc9ce2fd879`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/37cc9ce2fd879) -
+  Add new analytic entrypoint name for suggestions panel
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 119.10.2
 
 ### Patch Changes

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "119.10.1";
+var packageVersion = "119.10.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/selection/getFragmentsFromSelection.js

@@ -5,12 +5,19 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.getFragmentsFromSelection = void 0;
 var _editorJsonTransformer = require("@atlaskit/editor-json-transformer");
+var _fg = require("@atlaskit/platform-feature-flags/fg");
+var _nodes = require("../utils/nodes");
 var _contextHelpers = require("./context-helpers");
 /**
  * Get the fragments from the selection.
- * @param selection The selection to get the fragments from.
- * @param schema The schema to use to convert the nodes to JSON.
- * @returns The fragments as an array of JSON nodes.
+ *
+ * The result crosses an editor boundary — Remix, Rovo/convo-ai and AIFC treat it as persistable
+ * ADF. The two same-named `nodeToJSON` exports are not interchangeable: `editor-json-transformer`'s
+ * is a verbatim ProseMirror serialisation and leaks schema-only container variants such as
+ * `panel_c1`, while `../utils/nodes` sanitises.
+ *
+ * `keepNestedTables: true` keeps the gate scoped to that strip — the sanitiser would otherwise also
+ * rewrite nested tables into an extension carrying stringified ADF.
  */
 var getFragmentsFromSelection = exports.getFragmentsFromSelection = function getFragmentsFromSelection(selection) {
   if (!selection || selection.empty) {
@@ -18,9 +25,12 @@ var getFragmentsFromSelection = exports.getFragmentsFromSelection = function get
   }
   var slice = (0, _contextHelpers.getSliceFromSelection)(selection);
   var content = slice.content;
+  var sanitizeFragments = (0, _fg.fg)('platform_editor_sanitize_selection_fragments');
   var fragment = [];
   content.forEach(function (node) {
-    fragment.push((0, _editorJsonTransformer.nodeToJSON)(node));
+    fragment.push(sanitizeFragments ? (0, _nodes.nodeToJSON)(node, {
+      keepNestedTables: true
+    }) : (0, _editorJsonTransformer.nodeToJSON)(node));
   });
   return fragment;
 };

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "119.10.1";
+var packageVersion = "119.10.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/utils/nodes.js

@@ -109,8 +109,8 @@ function toJSON(node) {
 }
 
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-function nodeToJSON(node) {
-  return transformer.encodeNode(node);
+function nodeToJSON(node, options) {
+  return transformer.encodeNode(node, options);
 }
 // eslint-disable-next-line @atlaskit/editor/no-re-export
 

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "119.10.1";
+const packageVersion = "119.10.2";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/selection/getFragmentsFromSelection.js

@@ -1,11 +1,18 @@
-import { nodeToJSON } from '@atlaskit/editor-json-transformer';
+import { nodeToJSON as unsanitizedNodeToJSON } from '@atlaskit/editor-json-transformer';
+import { fg } from '@atlaskit/platform-feature-flags/fg';
+import { nodeToJSON } from '../utils/nodes';
 import { getSliceFromSelection } from './context-helpers';
 
 /**
  * Get the fragments from the selection.
- * @param selection The selection to get the fragments from.
- * @param schema The schema to use to convert the nodes to JSON.
- * @returns The fragments as an array of JSON nodes.
+ *
+ * The result crosses an editor boundary — Remix, Rovo/convo-ai and AIFC treat it as persistable
+ * ADF. The two same-named `nodeToJSON` exports are not interchangeable: `editor-json-transformer`'s
+ * is a verbatim ProseMirror serialisation and leaks schema-only container variants such as
+ * `panel_c1`, while `../utils/nodes` sanitises.
+ *
+ * `keepNestedTables: true` keeps the gate scoped to that strip — the sanitiser would otherwise also
+ * rewrite nested tables into an extension carrying stringified ADF.
  */
 export const getFragmentsFromSelection = selection => {
   if (!selection || selection.empty) {
@@ -13,9 +20,12 @@ export const getFragmentsFromSelection = selection => {
   }
   const slice = getSliceFromSelection(selection);
   const content = slice.content;
+  const sanitizeFragments = fg('platform_editor_sanitize_selection_fragments');
   const fragment = [];
   content.forEach(node => {
-    fragment.push(nodeToJSON(node));
+    fragment.push(sanitizeFragments ? nodeToJSON(node, {
+      keepNestedTables: true
+    }) : unsanitizedNodeToJSON(node));
   });
   return fragment;
 };

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "119.10.1";
+const packageVersion = "119.10.2";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/utils/nodes.js

@@ -49,8 +49,8 @@ export function toJSON(node) {
 }
 
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-export function nodeToJSON(node) {
-  return transformer.encodeNode(node);
+export function nodeToJSON(node, options) {
+  return transformer.encodeNode(node, options);
 }
 // eslint-disable-next-line @atlaskit/editor/no-re-export
 export { findChangedNodesFromTransaction } from './findChangedNodesFromTransaction';

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "119.10.1";
+var packageVersion = "119.10.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/selection/getFragmentsFromSelection.js

@@ -1,11 +1,18 @@
-import { nodeToJSON } from '@atlaskit/editor-json-transformer';
+import { nodeToJSON as unsanitizedNodeToJSON } from '@atlaskit/editor-json-transformer';
+import { fg } from '@atlaskit/platform-feature-flags/fg';
+import { nodeToJSON } from '../utils/nodes';
 import { getSliceFromSelection } from './context-helpers';
 
 /**
  * Get the fragments from the selection.
- * @param selection The selection to get the fragments from.
- * @param schema The schema to use to convert the nodes to JSON.
- * @returns The fragments as an array of JSON nodes.
+ *
+ * The result crosses an editor boundary — Remix, Rovo/convo-ai and AIFC treat it as persistable
+ * ADF. The two same-named `nodeToJSON` exports are not interchangeable: `editor-json-transformer`'s
+ * is a verbatim ProseMirror serialisation and leaks schema-only container variants such as
+ * `panel_c1`, while `../utils/nodes` sanitises.
+ *
+ * `keepNestedTables: true` keeps the gate scoped to that strip — the sanitiser would otherwise also
+ * rewrite nested tables into an extension carrying stringified ADF.
  */
 export var getFragmentsFromSelection = function getFragmentsFromSelection(selection) {
   if (!selection || selection.empty) {
@@ -13,9 +20,12 @@ export var getFragmentsFromSelection = function getFragmentsFromSelection(select
   }
   var slice = getSliceFromSelection(selection);
   var content = slice.content;
+  var sanitizeFragments = fg('platform_editor_sanitize_selection_fragments');
   var fragment = [];
   content.forEach(function (node) {
-    fragment.push(nodeToJSON(node));
+    fragment.push(sanitizeFragments ? nodeToJSON(node, {
+      keepNestedTables: true
+    }) : unsanitizedNodeToJSON(node));
   });
   return fragment;
 };

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "119.10.1";
+var packageVersion = "119.10.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/utils/nodes.js

@@ -59,8 +59,8 @@ export function toJSON(node) {
 }
 
 // eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-export function nodeToJSON(node) {
-  return transformer.encodeNode(node);
+export function nodeToJSON(node, options) {
+  return transformer.encodeNode(node, options);
 }
 // eslint-disable-next-line @atlaskit/editor/no-re-export
 export { findChangedNodesFromTransaction } from './findChangedNodesFromTransaction';

package/dist/types/analytics/types/ai-suggestions-events.d.ts

@@ -14,7 +14,7 @@ export type AiSuggestionsEntryPoint = 'primaryToolbar' | 'commentsEmptyState' |
  */
  | 'followUpCard';
 export type AiSuggestionInteractionPoint = 'sidebar' | 'card' | 'statusBar';
-export type AiSuggestionsRightRailEntryPoint = 'suggestionsTab' | 'suggestionCard';
+export type AiSuggestionsRightRailEntryPoint = 'suggestionsPanel' | 'suggestionsTab' | 'suggestionCard';
 export type AiSuggestionsConversationErrorReason = 'agentDeactivated' | 'agentProvisioning' | 'agentExternalConfigReference' | 'conversationSetup' | 'streamError';
 type NoDiffSuggestionAEP = OperationalAEP<ACTION.NO_DIFF_FOUND, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
     suggestionType: string;

package/dist/types/selection/getFragmentsFromSelection.d.ts

@@ -1,9 +1,14 @@
-import type { JSONNode } from '@atlaskit/editor-json-transformer';
+import type { JSONNode } from '@atlaskit/editor-json-transformer/types';
 import type { Selection } from '@atlaskit/editor-prosemirror/state';
 /**
  * Get the fragments from the selection.
- * @param selection The selection to get the fragments from.
- * @param schema The schema to use to convert the nodes to JSON.
- * @returns The fragments as an array of JSON nodes.
+ *
+ * The result crosses an editor boundary — Remix, Rovo/convo-ai and AIFC treat it as persistable
+ * ADF. The two same-named `nodeToJSON` exports are not interchangeable: `editor-json-transformer`'s
+ * is a verbatim ProseMirror serialisation and leaks schema-only container variants such as
+ * `panel_c1`, while `../utils/nodes` sanitises.
+ *
+ * `keepNestedTables: true` keeps the gate scoped to that strip — the sanitiser would otherwise also
+ * rewrite nested tables into an extension carrying stringified ADF.
  */
 export declare const getFragmentsFromSelection: (selection?: Selection) => JSONNode[] | null;

package/dist/types/utils/nodes.d.ts

@@ -1,4 +1,5 @@
 import type { JSONDocNode, JSONNode } from '@atlaskit/editor-json-transformer';
+import type { SanitizeNodeOptions } from '@atlaskit/editor-json-transformer/sanitize/sanitize-node';
 import type { MarkType, NodeType, Mark as PMMark, Node as PMNode, Schema } from '@atlaskit/editor-prosemirror/model';
 import { SelectedState } from './SelectedState';
 /** Validates prosemirror nodes, and returns true only if all nodes are valid */
@@ -16,7 +17,7 @@ export declare const isLinkMark: (node: PMEntities, schema: Schema) => boolean |
  */
 export declare const isNodeSelectedOrInRange: (anchorPosition: number, headPosition: number, nodePosition: number | undefined, nodeSize: number) => SelectedState | null;
 export declare function toJSON(node: PMNode): JSONDocNode;
-export declare function nodeToJSON(node: PMNode): JSONNode;
+export declare function nodeToJSON(node: PMNode, options?: SanitizeNodeOptions): JSONNode;
 export { findChangedNodesFromTransaction } from './findChangedNodesFromTransaction';
 export { validNode } from './validNode';
 export { SelectedState } from './SelectedState';

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "119.10.2",
+	"version": "119.11.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -42,7 +42,7 @@
 		"@atlaskit/css": "^1.0.0",
 		"@atlaskit/custom-steps": "^1.0.0",
 		"@atlaskit/dropdown-menu": "^18.1.0",
-		"@atlaskit/editor-json-transformer": "^9.4.0",
+		"@atlaskit/editor-json-transformer": "^9.5.0",
 		"@atlaskit/editor-palette": "^3.4.0",
 		"@atlaskit/editor-prosemirror": "^8.0.0",
 		"@atlaskit/editor-shared-styles": "^4.0.0",
@@ -57,7 +57,7 @@
 		"@atlaskit/link-datasource": "^6.4.0",
 		"@atlaskit/link-picker": "^6.4.0",
 		"@atlaskit/media-card": "^81.6.0",
-		"@atlaskit/media-client": "^37.3.0",
+		"@atlaskit/media-client": "^37.4.0",
 		"@atlaskit/media-client-react": "^6.1.0",
 		"@atlaskit/media-common": "^14.4.0",
 		"@atlaskit/media-file-preview": "^1.1.0",
@@ -172,6 +172,9 @@
 		"platform_editor_use_new_experiments_api": {
 			"type": "boolean"
 		},
+		"platform_editor_sanitize_selection_fragments": {
+			"type": "boolean"
+		},
 		"platform-dst-popper-consolidation": {
 			"type": "boolean",
 			"referenceOnly": true