@atlaskit/editor-common 118.12.0 → 119.0.0

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # @atlaskit/editor-common
 
+## 119.0.0
+
+### Major Changes
+
+- [`bb37742539a7d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/bb37742539a7d) -
+  Rename Quick Insert category analytics from app counts to macro counts, add reusable extension app
+  identity, and track internal, ecosystem, and all macro/app counts for externally provided items
+  behind `platform_editor_slash_app_category_analytics`. GUID-only app identities are grouped as
+  `unknown`.
+
+  Breaking change: `CategoryInformation` and `QuickInsertInformationAttributes` from
+  `@atlaskit/editor-common/analytics/types/quick-insert-events` have changed shape. Update usages to
+  the new fields (`internalMacroCount`, `internalAppCount`, `internalAppMacroMax`,
+  `ecosystemMacroCount`, `ecosystemAppCount`, `ecosystemAppMacroMax`, `allMacroCount`,
+  `allAppCount`, and `allAppMacroMax`) and add the `allCategories` aggregate. Remove references to
+  the removed `appCount` and `appMacros` fields. `ExtensionApp.ownership` has been replaced by
+  `ExtensionApp.source` (`internal` or `ecosystem`); update app metadata producers accordingly.
+
+### Minor Changes
+
+- [`ddb1f3da1e991`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ddb1f3da1e991) -
+  Track acceptance rate for backend-persisted agent edits. These arrive as remote collab steps
+  rather than frontend-streamed transformations, so they previously started no analytics session and
+  were absent from the metric. They now reuse the existing survival definition, and are recorded
+  only on the requesting user's client.
+
+  Gated by `platform_editor_agent_be_streaming`, which controls whether remote agent steps are
+  annotated at all, and by the agent type allowlist in
+  `platform_editor_backend_review_moment_agent_types`, which defaults to empty. Recording cannot
+  occur unless both permit it.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 118.12.0
 
 ### Minor Changes

package/dist/cjs/extensions/buildMenuItem.js

@@ -6,17 +6,23 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.buildMenuItem = buildMenuItem;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _manifestHelpers = require("./manifest-helpers");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function buildMenuItem(manifest, extensionModule) {
+  var _ref, _extensionModule$app;
   var title = extensionModule.title || manifest.title;
   var key = "".concat(manifest.key, ":").concat(extensionModule.key);
   var node = (0, _manifestHelpers.buildAction)(extensionModule.action, manifest);
   if (!node) {
     throw new Error("Couldn't find any action for ".concat(title, " (").concat(key, ")"));
   }
-  return _objectSpread(_objectSpread({
+  return _objectSpread(_objectSpread(_objectSpread({}, (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_slash_app_category_analytics') ? {
+    app: (_ref = (_extensionModule$app = extensionModule.app) !== null && _extensionModule$app !== void 0 ? _extensionModule$app : manifest.app) !== null && _ref !== void 0 ? _ref : {
+      key: manifest.key
+    }
+  } : {}), {}, {
     key: key,
     title: title,
     extensionType: manifest.type,

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "118.11.0";
+var packageVersion = "118.12.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "118.11.0";
+var packageVersion = "118.12.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/extensions/buildMenuItem.js

@@ -1,5 +1,7 @@
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { buildAction } from './manifest-helpers';
 export function buildMenuItem(manifest, extensionModule) {
+  var _ref, _extensionModule$app;
   const title = extensionModule.title || manifest.title;
   const key = `${manifest.key}:${extensionModule.key}`;
   const node = buildAction(extensionModule.action, manifest);
@@ -7,6 +9,11 @@ export function buildMenuItem(manifest, extensionModule) {
     throw new Error(`Couldn't find any action for ${title} (${key})`);
   }
   return {
+    ...(isExperimentEnabled('platform_editor_slash_app_category_analytics') ? {
+      app: (_ref = (_extensionModule$app = extensionModule.app) !== null && _extensionModule$app !== void 0 ? _extensionModule$app : manifest.app) !== null && _ref !== void 0 ? _ref : {
+        key: manifest.key
+      }
+    } : {}),
     key,
     title,
     extensionType: manifest.type,

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "118.11.0";
+const packageVersion = "118.12.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "118.11.0";
+const packageVersion = "118.12.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/extensions/buildMenuItem.js

@@ -1,15 +1,21 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { buildAction } from './manifest-helpers';
 export function buildMenuItem(manifest, extensionModule) {
+  var _ref, _extensionModule$app;
   var title = extensionModule.title || manifest.title;
   var key = "".concat(manifest.key, ":").concat(extensionModule.key);
   var node = buildAction(extensionModule.action, manifest);
   if (!node) {
     throw new Error("Couldn't find any action for ".concat(title, " (").concat(key, ")"));
   }
-  return _objectSpread(_objectSpread({
+  return _objectSpread(_objectSpread(_objectSpread({}, isExperimentEnabled('platform_editor_slash_app_category_analytics') ? {
+    app: (_ref = (_extensionModule$app = extensionModule.app) !== null && _extensionModule$app !== void 0 ? _extensionModule$app : manifest.app) !== null && _ref !== void 0 ? _ref : {
+      key: manifest.key
+    }
+  } : {}), {}, {
     key: key,
     title: title,
     extensionType: manifest.type,

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "118.11.0";
+var packageVersion = "118.12.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "118.11.0";
+var packageVersion = "118.12.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/analytics/types/quick-insert-events.d.ts

@@ -1,41 +1,22 @@
 import type { ACTION, ACTION_SUBJECT } from './enums';
 import type { OperationalAEP } from './utils';
-type CategoryInformation = {
-    appCount: number;
+export type CategoryInformation = {
+    internalMacroCount: number;
+    internalAppCount: number;
+    internalAppMacroMax: number;
+    ecosystemMacroCount: number;
+    ecosystemAppCount: number;
+    ecosystemAppMacroMax: number;
+    allMacroCount: number;
+    allAppCount: number;
+    allAppMacroMax: number;
 };
+export type CategoryKey = 'blockTemplates' | 'dataAndCharts' | 'embed' | 'media' | 'other' | 'rovo' | 'structure' | 'textFormatting';
+export type LegacyCategoryKey = 'admin' | 'ai' | 'block-templates' | 'communication' | 'confluence-content' | 'data-and-charts' | 'development' | 'embed' | 'external-content' | 'formatting' | 'media' | 'navigation' | 'other' | 'reporting' | 'skills' | 'structure' | 'text-formatting' | 'uncategorized' | 'visuals';
 export type QuickInsertInformationAttributes = {
-    category: {
-        blockTemplates: CategoryInformation;
-        dataAndCharts: CategoryInformation;
-        embed: CategoryInformation;
-        media: CategoryInformation;
-        other: CategoryInformation;
-        rovo: CategoryInformation;
-        structure: CategoryInformation;
-        textFormatting: CategoryInformation;
-    };
-    legacyCategory: {
-        admin: CategoryInformation;
-        ai: CategoryInformation;
-        'block-templates': CategoryInformation;
-        communication: CategoryInformation;
-        'confluence-content': CategoryInformation;
-        'data-and-charts': CategoryInformation;
-        development: CategoryInformation;
-        embed: CategoryInformation;
-        'external-content': CategoryInformation;
-        formatting: CategoryInformation;
-        media: CategoryInformation;
-        navigation: CategoryInformation;
-        other: CategoryInformation;
-        reporting: CategoryInformation;
-        skills: CategoryInformation;
-        structure: CategoryInformation;
-        'text-formatting': CategoryInformation;
-        uncategorized: CategoryInformation;
-        visuals: CategoryInformation;
-    };
+    category: Record<CategoryKey, CategoryInformation>;
+    legacyCategory: Record<LegacyCategoryKey, CategoryInformation>;
+    allCategories: CategoryInformation;
 };
 export type QuickInsertInformationAEP = OperationalAEP<ACTION.QUICK_INSERT_INFORMATION, ACTION_SUBJECT.QUICK_INSERT, undefined, QuickInsertInformationAttributes>;
 export type QuickInsertInformationEventPayload = QuickInsertInformationAEP;
-export {};

package/dist/types/collab/agent-remote-edit-review.d.ts

@@ -67,6 +67,20 @@ export interface AgentRemoteEditReviewData {
      * waiting for the idle debounce. `false`/absent ⇒ rely on the debounce.
      */
     complete?: boolean;
+    /**
+     * Whether the local client is the one that requested this agent edit, resolved by
+     * matching `actorUserId` against the local collab participant's AAID.
+     *
+     * Agent steps are broadcast to every collaborator, so anything that must happen
+     * exactly once per edit (notably acceptance-rate analytics) has to run on a single
+     * client. `false` when the local user is not the requester, and also when either AAID
+     * is unavailable: an unattributable batch would otherwise emit one event per connected
+     * client, and silently inflating a metric is worse than a known gap.
+     *
+     * Optional so producers predating this field stay valid; `undefined` is treated as
+     * "not the requester", keeping the fail-closed behaviour.
+     */
+    isLocalUserRequester?: boolean;
     /**
      * The coarse reviewable segments derived from the batch — one per edited
      * top-level region, with closed whole-node slices. Appended verbatim to

package/dist/types/extensions/types/extension-manifest.d.ts

@@ -26,8 +26,16 @@ export type ExtensionModuleActionObject<T extends Parameters = Parameters> = {
 export type MaybeADFEntity = MaybeESModule<ADFEntity | Array<ADFEntity> | void>;
 export type ExtensionModuleActionHandler = (extensionAPI: ExtensionAPI) => Promise<MaybeADFEntity>;
 export type ExtensionModuleAction<T extends Parameters = Parameters> = ExtensionModuleActionObject<T> | ExtensionModuleActionHandler;
+/** Identifies the app contributing an extension manifest or module. */
+export type ExtensionApp = {
+    /** Stable, non-localized key shared by every extension contributed by the app. */
+    key: string;
+    /** Provenance of the extension contribution. Omit when provenance cannot be determined. */
+    source?: 'internal' | 'ecosystem';
+};
 export type ExtensionModule<T extends Parameters = Parameters> = {
     action: ExtensionModuleAction<T>;
+    app?: ExtensionApp;
     categories?: string[];
     description?: string;
     featured?: boolean;
@@ -103,6 +111,7 @@ export type ExtensionDeprecationStatus = {
     message?: string | React.ReactNode;
 };
 export type ExtensionManifest<T extends Parameters = Parameters> = {
+    app?: ExtensionApp;
     autoConvert?: {
         matchers: Array<AutoConvertMatches>;
     };

package/dist/types/extensions/types/utils.d.ts

@@ -1,7 +1,8 @@
 import type { ReactNode } from 'react';
 import type { ADFEntity } from '@atlaskit/adf-utils/types';
-import type { ExtensionKey, ExtensionModuleActionHandler, ExtensionType, Icon } from './extension-manifest';
+import type { ExtensionApp, ExtensionKey, ExtensionModuleActionHandler, ExtensionType, Icon } from './extension-manifest';
 export type MenuItem = {
+    app?: ExtensionApp;
     categories: string[];
     description?: string;
     documentationUrl?: string;

package/dist/types/provider-factory/quick-insert-provider.d.ts

@@ -2,6 +2,7 @@ import type { Node } from '@atlaskit/editor-prosemirror/model';
 import type { EditorState, Transaction } from '@atlaskit/editor-prosemirror/state';
 import type { RegisterMenuItem } from '@atlaskit/editor-ui-control-model/types';
 import type { INPUT_METHOD } from '../analytics/types/enums';
+import type { ExtensionApp } from '../extensions/types/extension-manifest';
 import type { TypeAheadItem } from '../types/type-ahead';
 export type QuickInsertActionInsert = (node?: Node | Record<string, any> | string, opts?: {
     selectInlineNode?: boolean;
@@ -16,6 +17,8 @@ export type QuickInsertItem = TypeAheadItem & {
      * @see packages/editor/editor-core/src/plugins/insert-block/ui/ToolbarInsertBlock/index.tsx for details
      */
     action: (insert: QuickInsertActionInsert, state: EditorState, source?: INPUT_METHOD.TOOLBAR | INPUT_METHOD.QUICK_INSERT | INPUT_METHOD.ELEMENT_BROWSER) => Transaction | false;
+    /** App contributing this item. */
+    app?: ExtensionApp;
     /** categories where to find the item */
     categories?: Array<string>;
     /** indicates if the item will be highlighted where appropriate (plus menu for now) */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "118.12.0",
+	"version": "119.0.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"