@atlaskit/editor-common 118.10.1 → 118.10.2

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @atlaskit/editor-common
 
+## 118.10.2
+
+### Patch Changes
+
+- [`1d1cb3e25a787`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1d1cb3e25a787) -
+  Fix BE-streaming Review moment data loss and chimera diffs: derive coarse review segments as
+  closed, whole top-level node slices (mapped consistently between the pre-edit and post-edit doc),
+  filter out position-neutral phantom collab touches, and fall back to a safe add-only segment when
+  a change relocates content. Behind the platform_editor_backend_review_moment_agent_types gate.
+- Updated dependencies
+
 ## 118.10.1
 
 ### Patch Changes

package/dist/cjs/collab/agent-remote-edit-review.js

@@ -13,10 +13,21 @@ exports.AGENT_REMOTE_EDIT_REVIEW_DATA = void 0;
  * plugins already depend on.
  *
  * Stamped whenever a received remote-step batch contains agent-authored steps.
- * Consumed by `aiSessionContextPlugin.apply()`,
- * which appends coarse `aiContentPositions` entries — exactly like the in-editor
- * (FE) streaming path's `AI_FINAL_STREAMING_TRANSFORMATION_DATA`, so the whole
- * downstream Review moment pipeline (merge → segment → diff → undo/redo → accept)
- * is reused unchanged.
+ *
+ * The batch is reduced to COARSE segments — one per edited top-level region — in
+ * exactly the shape the AI plugin already stores in `aiContentPositions` for the
+ * FE (`buildCommitTransaction`) path: `[startPos, endPos]` in the live doc plus a
+ * closed `originalSlice` / `newSlice` pair. The AI plugin appends these verbatim,
+ * then the Post Stream Review screen refines them identically to FE
+ * (`calculateTopLevelNodeSegments`, and `calculateDiffSegments` when the
+ * diff-based-segmenting gate is on). Producing coarse segments here (rather than
+ * fine-grained diffs) preserves the screen's two-layer contract; producing them
+ * as CLOSED, whole-top-level-node slices avoids the boundary-bleed / open-slice
+ * data-loss hazards of the earlier hand-rolled per-step slicing.
  */
-var AGENT_REMOTE_EDIT_REVIEW_DATA = exports.AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+var AGENT_REMOTE_EDIT_REVIEW_DATA = exports.AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+
+/**
+ * One coarse reviewable segment for a single edited top-level region, matching the
+ * `aiContentPositions` entry shape the AI plugin stores for FE streaming.
+ */

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "118.10.0";
+var packageVersion = "118.10.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "118.10.0";
+var packageVersion = "118.10.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/collab/agent-remote-edit-review.js

@@ -7,10 +7,21 @@
  * plugins already depend on.
  *
  * Stamped whenever a received remote-step batch contains agent-authored steps.
- * Consumed by `aiSessionContextPlugin.apply()`,
- * which appends coarse `aiContentPositions` entries — exactly like the in-editor
- * (FE) streaming path's `AI_FINAL_STREAMING_TRANSFORMATION_DATA`, so the whole
- * downstream Review moment pipeline (merge → segment → diff → undo/redo → accept)
- * is reused unchanged.
+ *
+ * The batch is reduced to COARSE segments — one per edited top-level region — in
+ * exactly the shape the AI plugin already stores in `aiContentPositions` for the
+ * FE (`buildCommitTransaction`) path: `[startPos, endPos]` in the live doc plus a
+ * closed `originalSlice` / `newSlice` pair. The AI plugin appends these verbatim,
+ * then the Post Stream Review screen refines them identically to FE
+ * (`calculateTopLevelNodeSegments`, and `calculateDiffSegments` when the
+ * diff-based-segmenting gate is on). Producing coarse segments here (rather than
+ * fine-grained diffs) preserves the screen's two-layer contract; producing them
+ * as CLOSED, whole-top-level-node slices avoids the boundary-bleed / open-slice
+ * data-loss hazards of the earlier hand-rolled per-step slicing.
  */
-export const AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+export const AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+
+/**
+ * One coarse reviewable segment for a single edited top-level region, matching the
+ * `aiContentPositions` entry shape the AI plugin stores for FE streaming.
+ */

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "118.10.0";
+const packageVersion = "118.10.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "118.10.0";
+const packageVersion = "118.10.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/collab/agent-remote-edit-review.js

@@ -7,10 +7,21 @@
  * plugins already depend on.
  *
  * Stamped whenever a received remote-step batch contains agent-authored steps.
- * Consumed by `aiSessionContextPlugin.apply()`,
- * which appends coarse `aiContentPositions` entries — exactly like the in-editor
- * (FE) streaming path's `AI_FINAL_STREAMING_TRANSFORMATION_DATA`, so the whole
- * downstream Review moment pipeline (merge → segment → diff → undo/redo → accept)
- * is reused unchanged.
+ *
+ * The batch is reduced to COARSE segments — one per edited top-level region — in
+ * exactly the shape the AI plugin already stores in `aiContentPositions` for the
+ * FE (`buildCommitTransaction`) path: `[startPos, endPos]` in the live doc plus a
+ * closed `originalSlice` / `newSlice` pair. The AI plugin appends these verbatim,
+ * then the Post Stream Review screen refines them identically to FE
+ * (`calculateTopLevelNodeSegments`, and `calculateDiffSegments` when the
+ * diff-based-segmenting gate is on). Producing coarse segments here (rather than
+ * fine-grained diffs) preserves the screen's two-layer contract; producing them
+ * as CLOSED, whole-top-level-node slices avoids the boundary-bleed / open-slice
+ * data-loss hazards of the earlier hand-rolled per-step slicing.
  */
-export var AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+export var AGENT_REMOTE_EDIT_REVIEW_DATA = 'agentRemoteEditReviewData';
+
+/**
+ * One coarse reviewable segment for a single edited top-level region, matching the
+ * `aiContentPositions` entry shape the AI plugin stores for FE streaming.
+ */

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "118.10.0";
+var packageVersion = "118.10.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "118.10.0";
+var packageVersion = "118.10.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/collab/agent-remote-edit-review.d.ts

@@ -8,26 +8,39 @@ import type { Slice } from '@atlaskit/editor-prosemirror/model';
  * plugins already depend on.
  *
  * Stamped whenever a received remote-step batch contains agent-authored steps.
- * Consumed by `aiSessionContextPlugin.apply()`,
- * which appends coarse `aiContentPositions` entries — exactly like the in-editor
- * (FE) streaming path's `AI_FINAL_STREAMING_TRANSFORMATION_DATA`, so the whole
- * downstream Review moment pipeline (merge → segment → diff → undo/redo → accept)
- * is reused unchanged.
+ *
+ * The batch is reduced to COARSE segments — one per edited top-level region — in
+ * exactly the shape the AI plugin already stores in `aiContentPositions` for the
+ * FE (`buildCommitTransaction`) path: `[startPos, endPos]` in the live doc plus a
+ * closed `originalSlice` / `newSlice` pair. The AI plugin appends these verbatim,
+ * then the Post Stream Review screen refines them identically to FE
+ * (`calculateTopLevelNodeSegments`, and `calculateDiffSegments` when the
+ * diff-based-segmenting gate is on). Producing coarse segments here (rather than
+ * fine-grained diffs) preserves the screen's two-layer contract; producing them
+ * as CLOSED, whole-top-level-node slices avoids the boundary-bleed / open-slice
+ * data-loss hazards of the earlier hand-rolled per-step slicing.
  */
 export declare const AGENT_REMOTE_EDIT_REVIEW_DATA = "agentRemoteEditReviewData";
+/**
+ * One coarse reviewable segment for a single edited top-level region, matching the
+ * `aiContentPositions` entry shape the AI plugin stores for FE streaming.
+ */
 export interface AgentRemoteEditReviewSegment {
-    /** Live-doc end of the change after the batch applied. A `remove` is zero-width (`endPos === startPos`). */
+    /** Live-doc end of the applied (new) content. Equals `startPos` for a pure removal. */
     endPos: number;
+    /** Change kind, mirroring the FE coarse-entry classification. */
+    kind: 'add' | 'remove' | 'update';
     /**
-     * Derived from the slice pair: empty original ⇒ `add`, empty new ⇒ `remove`,
-     * else `update`. Carried so the consumer does not re-derive it.
+     * The post-edit content of this region (`tr.doc`), as a CLOSED slice snapped to
+     * whole top-level nodes. `Slice.empty` for a pure removal.
      */
-    kind: 'add' | 'remove' | 'update';
-    /** Content now at [startPos, endPos] AFTER the batch (the agent's content; for redo). */
     newSlice: Slice;
-    /** Content that was at the range BEFORE the batch (for undo / "compare with original"). */
+    /**
+     * The pre-edit content of this region (`tr.before`), as a CLOSED slice snapped
+     * to whole top-level nodes. `Slice.empty` for a pure addition.
+     */
     originalSlice: Slice;
-    /** Live-doc start of the change after the batch applied. */
+    /** Live-doc start of the applied (new) content. */
     startPos: number;
 }
 export interface AgentRemoteEditReviewData {
@@ -54,5 +67,10 @@ export interface AgentRemoteEditReviewData {
      * waiting for the idle debounce. `false`/absent ⇒ rely on the debounce.
      */
     complete?: boolean;
+    /**
+     * The coarse reviewable segments derived from the batch — one per edited
+     * top-level region, with closed whole-node slices. Appended verbatim to
+     * `aiContentPositions` by the AI plugin.
+     */
     segments: AgentRemoteEditReviewSegment[];
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "118.10.1",
+	"version": "118.10.2",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -76,7 +76,7 @@
 		"@atlaskit/profilecard": "^26.17.0",
 		"@atlaskit/prosemirror-history": "^1.1.0",
 		"@atlaskit/react-compiler-gating": "^0.2.0",
-		"@atlaskit/react-ufo": "^7.4.0",
+		"@atlaskit/react-ufo": "^7.5.0",
 		"@atlaskit/section-message": "^10.0.0",
 		"@atlaskit/smart-card": "^45.17.0",
 		"@atlaskit/smart-user-picker": "^11.5.0",