@atlaskit/editor-common 116.41.0 → 116.42.1

package/CHANGELOG.md

@@ -1,5 +1,60 @@
 # @atlaskit/editor-common
 
+## 116.42.1
+
+### Patch Changes
+
+- [`9291603af8830`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/9291603af8830) -
+  Upgrade types to be compatible with React 19.
+
+  This was done with the official React codemod: https://github.com/eps1lon/types-react-codemod/
+
+## 116.42.0
+
+### Minor Changes
+
+- [`782360c1111dc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/782360c1111dc) -
+  Agent-edit shimmer review follow-ups (behind the default-OFF `platform_editor_agent_be_streaming`
+  experiment):
+  - Add a second shimmer phase: after the skeleton loader clears, the changed range shows a purple
+    "just edited" highlight (same colours as the editor AI "improve writing" in-editor highlight)
+    that eases in and out over its lifetime. The Rovo telepointer stays through both phases.
+  - The two phases are sized by independent experiment params: `shimmerDurationMs` (skeleton,
+    renamed from `durationMs`) and `highlightDurationMs` (highlight). `0` on either skips just that
+    phase, `0` on both shows nothing.
+  - Gate the agent-edit shimmer styles behind the experiment in both the emotion and compiled
+    `EditorContentContainer` style entries, using the no-exposure check on the hot render path.
+  - Add an `agentEditReceived` collab-provider analytics event, fired once per received transaction
+    that contains agent-authored steps, with non-PII attributes (agent ids, count, kinds,
+    agent/total step counts).
+  - Add an `agentEditShimmerNotShown` COLLAB operational analytics event for agent edits that apply
+    without the shimmer (`rebasedConcurrentEdit`, `nothingToShow`, `captureThrew`,
+    `tornDownMidAnimation`); neutral action + `reason`, non-PII attributes.
+  - Hoist the top-level block/position helpers in `agent-shimmer-ranges` to reusable module scope,
+    drop the redundant upper-bound clamp in `agent-shimmer-decorations`, and remove the empty
+    `@example` JSDoc tags added in the original PR.
+
+  `@atlaskit/editor-common` gains a new subpath export,
+  `@atlaskit/editor-common/analytics/types/agent-edit-shimmer-events`, exposing the
+  `agentEditShimmerNotShown` operational event types. Usage:
+
+  ```ts
+  import { ACTION, ACTION_SUBJECT, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
+  import type { AgentEditShimmerNotShownReason } from '@atlaskit/editor-common/analytics/types/agent-edit-shimmer-events';
+
+  const reason: AgentEditShimmerNotShownReason = 'captureThrew';
+  editorAnalyticsApi?.fireAnalyticsEvent({
+  	action: ACTION.AGENT_EDIT_SHIMMER_NOT_SHOWN,
+  	actionSubject: ACTION_SUBJECT.COLLAB,
+  	eventType: EVENT_TYPE.OPERATIONAL,
+  	attributes: { reason },
+  });
+  ```
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 116.41.0
 
 ### Minor Changes

package/analytics/types/agent-edit-shimmer-events/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "@atlaskit/editor-common/analytics/types/agent-edit-shimmer-events",
+  "main": "../../../dist/cjs/analytics/types/agent-edit-shimmer-events.js",
+  "module": "../../../dist/esm/analytics/types/agent-edit-shimmer-events.js",
+  "module:es2019": "../../../dist/es2019/analytics/types/agent-edit-shimmer-events.js",
+  "sideEffects": [
+    "**/*.compiled.css"
+  ],
+  "types": "../../../dist/types/analytics/types/agent-edit-shimmer-events.d.ts"
+}

package/dist/cjs/analytics/types/agent-edit-shimmer-events.js

@@ -0,0 +1,5 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});

package/dist/cjs/analytics/types/enums.js

@@ -195,6 +195,7 @@ var ACTION = exports.ACTION = /*#__PURE__*/function (ACTION) {
   ACTION["STEPS_TRACKED"] = "stepsTracked";
   ACTION["ORGANIC_CHANGES_TRACKED"] = "organicChangesTracked";
   ACTION["STEPS_FILTERED"] = "stepsFiltered";
+  ACTION["AGENT_EDIT_SHIMMER_NOT_SHOWN"] = "agentEditShimmerNotShown";
   ACTION["CREATE_NOT_ALLOWED"] = "createNotAllowed";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_SUCCEEDED"] = "unsupportedContentLevelsTrackingSucceeded";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_ERRORED"] = "unsupportedContentLevelsTrackingErrored";

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.40.2";
+var packageVersion = "116.42.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.40.2";
+var packageVersion = "116.42.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/analytics/types/agent-edit-shimmer-events.js

@@ -0,0 +1 @@
+export {};

package/dist/es2019/analytics/types/enums.js

@@ -191,6 +191,7 @@ export let ACTION = /*#__PURE__*/function (ACTION) {
   ACTION["STEPS_TRACKED"] = "stepsTracked";
   ACTION["ORGANIC_CHANGES_TRACKED"] = "organicChangesTracked";
   ACTION["STEPS_FILTERED"] = "stepsFiltered";
+  ACTION["AGENT_EDIT_SHIMMER_NOT_SHOWN"] = "agentEditShimmerNotShown";
   ACTION["CREATE_NOT_ALLOWED"] = "createNotAllowed";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_SUCCEEDED"] = "unsupportedContentLevelsTrackingSucceeded";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_ERRORED"] = "unsupportedContentLevelsTrackingErrored";

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "116.40.2";
+const packageVersion = "116.42.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "116.40.2";
+const packageVersion = "116.42.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/analytics/types/agent-edit-shimmer-events.js

@@ -0,0 +1 @@
+export {};

package/dist/esm/analytics/types/enums.js

@@ -191,6 +191,7 @@ export var ACTION = /*#__PURE__*/function (ACTION) {
   ACTION["STEPS_TRACKED"] = "stepsTracked";
   ACTION["ORGANIC_CHANGES_TRACKED"] = "organicChangesTracked";
   ACTION["STEPS_FILTERED"] = "stepsFiltered";
+  ACTION["AGENT_EDIT_SHIMMER_NOT_SHOWN"] = "agentEditShimmerNotShown";
   ACTION["CREATE_NOT_ALLOWED"] = "createNotAllowed";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_SUCCEEDED"] = "unsupportedContentLevelsTrackingSucceeded";
   ACTION["UNSUPPORTED_CONTENT_LEVELS_TRACKING_ERRORED"] = "unsupportedContentLevelsTrackingErrored";

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.40.2";
+var packageVersion = "116.42.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.40.2";
+var packageVersion = "116.42.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/analytics/types/agent-edit-shimmer-events.d.ts

@@ -0,0 +1,14 @@
+import type { ACTION, ACTION_SUBJECT } from './enums';
+import type { OperationalAEP } from './utils';
+/**
+ * Reasons an agent-authored edit did NOT get the skeleton shimmer / telepointer and instead applied
+ * instantly. Success is the ABSENCE of this event, so a neutral action + `reason` attribute is used
+ * (rather than an error action) to keep benign, expected degrades out of error dashboards.
+ */
+export type AgentEditShimmerNotShownReason = 'rebasedConcurrentEdit' | 'nothingToShow' | 'captureThrew' | 'tornDownMidAnimation';
+export type AgentEditShimmerNotShownAttributes = {
+    agentType?: string;
+    error?: string;
+    reason: AgentEditShimmerNotShownReason;
+};
+export type AgentEditShimmerNotShownAEP = OperationalAEP<ACTION.AGENT_EDIT_SHIMMER_NOT_SHOWN, ACTION_SUBJECT.COLLAB, undefined, AgentEditShimmerNotShownAttributes>;

package/dist/types/analytics/types/enums.d.ts

@@ -187,6 +187,7 @@ export declare enum ACTION {
     STEPS_TRACKED = "stepsTracked",
     ORGANIC_CHANGES_TRACKED = "organicChangesTracked",
     STEPS_FILTERED = "stepsFiltered",
+    AGENT_EDIT_SHIMMER_NOT_SHOWN = "agentEditShimmerNotShown",
     CREATE_NOT_ALLOWED = "createNotAllowed",
     UNSUPPORTED_CONTENT_LEVELS_TRACKING_SUCCEEDED = "unsupportedContentLevelsTrackingSucceeded",
     UNSUPPORTED_CONTENT_LEVELS_TRACKING_ERRORED = "unsupportedContentLevelsTrackingErrored",

package/dist/types/analytics/types/events.d.ts

@@ -4,6 +4,7 @@ import type { NewCollabSyncUpErrorAttributes } from '../../collab';
 import type { UnsupportedContentPayload, UnsupportedContentTooltipPayload, UserBrowserExtensionResults } from '../../utils';
 import type { FireAnalyticsEventOptions } from '../api';
 import type { ActiveSessionEventPayload } from './activity-session-events';
+import type { AgentEditShimmerNotShownAEP } from './agent-edit-shimmer-events';
 import type { AiAutocompleteEventPayload } from './ai-autocomplete-events';
 import type { AICommandPaletteEventPayload } from './ai-command-palette-events';
 import type { AIDefinitionsEventPayload } from './ai-definitions-events';
@@ -71,7 +72,7 @@ export type SimplifiedNode = {
     pos: number;
     type: string;
 };
-export type AnalyticsEventPayload<T = void> = AvatarEventPayload | GeneralEventPayload<T> | FormatEventPayload | SubstituteEventPayload | InsertEventPayload | NodeEventPayload | MoveContentEventPayload | MediaEventPayload | TableEventPayload | PasteEventPayload | PasteActionsMenuEventPayload | CutCopyEventPayload | ErrorEventPayload | TextColorEventPayload | FindReplaceEventPayload | DateEventPayload | SelectionEventPayload | ListEventPayload | ConfigPanelEventPayload | ElementBrowserEventPayload | CreateLinkInlineDialogEventPayload | HighlightActionsEventPayload | UnsupportedContentPayload | ExtensionEventPayload | TransactionEventPayload | TypeAheadPayload | UnlinkToolbarAEP | EditLinkToolbarAEP | PreviewItemClickedAEP | OpenLinkToolbarAEP | OpenSettingsToolbarAEP | CustomPanelEventPayload | FeatureExposureAEP | NewCollabSyncUpErrorAEP | UnsupportedContentTooltipPayload | ReferentialityEventPayload | LoomEventPayload | MBEEventPayload | HighlightEventPayload | DatasourceClickedPayload | ElementEventPayload | VisitedLinkAEP | ViewEventPayload | MediaUploadEventPayload | MentionEventPayload | EngagementPlatformEventPayload | NestedTableActionsEventPayload | ContainerNodeActionsEventPayload | AICommandPaletteEventPayload | AIDefinitionsEventPayload | AIEventPayload | AIStreamingEventPayload | AIProactiveEventPayload | AiAutocompleteEventPayload | AiSuggestionsEventPayload | ContextualTypeaheadEventPayload | AIQuickPromptEventPayload | AIUnifiedEventPayload | BreakoutEventPayload | BlockMenuEventPayload | ActiveSessionEventPayload | AIInlineSuggestionPayload | SelectionExtensionEventPayload | TelepointerClickPayload | SelectionToolbarEventPayload | ExperienceEventPayload | AlignmentEventPayload | UndoRedoAEP | OfflineEditingEventPayload | NcsSessionStepEventAEP | FloatingToolbarOverflowEventPayload | SyncBlockEventPayload | FloatingToolbarEventPayload;
+export type AnalyticsEventPayload<T = void> = AvatarEventPayload | GeneralEventPayload<T> | FormatEventPayload | SubstituteEventPayload | InsertEventPayload | NodeEventPayload | MoveContentEventPayload | MediaEventPayload | TableEventPayload | PasteEventPayload | PasteActionsMenuEventPayload | CutCopyEventPayload | ErrorEventPayload | TextColorEventPayload | FindReplaceEventPayload | DateEventPayload | SelectionEventPayload | ListEventPayload | ConfigPanelEventPayload | ElementBrowserEventPayload | CreateLinkInlineDialogEventPayload | HighlightActionsEventPayload | UnsupportedContentPayload | ExtensionEventPayload | TransactionEventPayload | TypeAheadPayload | UnlinkToolbarAEP | EditLinkToolbarAEP | PreviewItemClickedAEP | OpenLinkToolbarAEP | OpenSettingsToolbarAEP | CustomPanelEventPayload | FeatureExposureAEP | NewCollabSyncUpErrorAEP | UnsupportedContentTooltipPayload | ReferentialityEventPayload | LoomEventPayload | MBEEventPayload | HighlightEventPayload | DatasourceClickedPayload | ElementEventPayload | VisitedLinkAEP | ViewEventPayload | MediaUploadEventPayload | MentionEventPayload | EngagementPlatformEventPayload | NestedTableActionsEventPayload | ContainerNodeActionsEventPayload | AICommandPaletteEventPayload | AIDefinitionsEventPayload | AIEventPayload | AIStreamingEventPayload | AIProactiveEventPayload | AiAutocompleteEventPayload | AiSuggestionsEventPayload | ContextualTypeaheadEventPayload | AIQuickPromptEventPayload | AIUnifiedEventPayload | BreakoutEventPayload | BlockMenuEventPayload | ActiveSessionEventPayload | AIInlineSuggestionPayload | SelectionExtensionEventPayload | TelepointerClickPayload | SelectionToolbarEventPayload | ExperienceEventPayload | AlignmentEventPayload | UndoRedoAEP | OfflineEditingEventPayload | NcsSessionStepEventAEP | AgentEditShimmerNotShownAEP | FloatingToolbarOverflowEventPayload | SyncBlockEventPayload | FloatingToolbarEventPayload;
 type CustomPanelEventPayload = TrackAEP<ACTION.CHANGED_BACKGROUND_COLOR | ACTION.CHANGED_ICON | ACTION.REMOVE_ICON, ACTION_SUBJECT.PANEL, ACTION_SUBJECT_ID.PANEL, {
     newColor: string;
     previousColor: string;

package/dist/types/link/LinkSearch/types.d.ts

@@ -34,8 +34,8 @@ export interface RecentSearchState {
 }
 export type LinkSearchListItemData = {
     container: string;
-    icon?: React.ReactChild | never;
-    iconUrl?: string | never;
+    icon?: React.ReactElement | number | string;
+    iconUrl?: string;
     lastUpdatedDate?: Date;
     lastViewedDate?: Date;
     name: string;
@@ -45,5 +45,5 @@ export type LinkSearchListItemData = {
 } & ({
     iconUrl: string;
 } | {
-    icon: React.ReactChild;
+    icon: React.ReactElement | number | string;
 });

package/dist/types/portal/common.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
 import type { PortalManager } from './PortalManager';
-type RenderFn = (children: () => React.ReactChild | JSX.Element | null, container: HTMLElement, key: string, onBeforeReactDomRender?: () => void, immediate?: boolean) => void;
+type RenderFn = (children: () => React.ReactElement | number | string | JSX.Element | null, container: HTMLElement, key: string, onBeforeReactDomRender?: () => void, immediate?: boolean) => void;
 type RemoveFn = (key: string) => void;
 type DestoryFn = () => void;
 export interface PortalProviderAPI {

package/dist/types/ui-menu/DropdownMenu/types.d.ts

@@ -38,7 +38,7 @@ export interface MenuItem {
     'aria-keyshortcuts'?: React.AriaAttributes['aria-keyshortcuts'];
     'aria-label'?: React.AriaAttributes['aria-label'];
     className?: string;
-    content: string | React.ReactChild | React.ReactFragment;
+    content: React.ReactElement | number | string | React.ReactFragment;
     'data-testid'?: string;
     elemAfter?: React.ReactElement<any>;
     elemBefore?: React.ReactElement<any>;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "116.41.0",
+	"version": "116.42.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -80,7 +80,7 @@
 		"@atlaskit/task-decision": "^21.7.0",
 		"@atlaskit/teams-app-config": "^2.1.0",
 		"@atlaskit/textfield": "^9.1.0",
-		"@atlaskit/tmp-editor-statsig": "^135.0.0",
+		"@atlaskit/tmp-editor-statsig": "^135.2.0",
 		"@atlaskit/tokens": "^16.3.0",
 		"@atlaskit/tooltip": "^23.2.0",
 		"@atlaskit/width-detector": "^6.2.0",
@@ -121,7 +121,9 @@
 	},
 	"devDependencies": {
 		"@atlaskit/media-core": "^38.0.0",
+		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlassian/a11y-jest-testing": "^0.13.0",
+		"@atlassian/experiment-test-utils": "^0.2.0",
 		"@atlassian/feature-flags-test-utils": "^1.2.0",
 		"@atlassian/testing-library": "^0.11.0",
 		"@testing-library/dom": "^10.1.0",