@atlaskit/editor-common 116.23.1 → 116.23.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-common
 
+## 116.23.2
+
+### Patch Changes
+
+- [`d76b4661858ee`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d76b4661858ee) -
+  Fix scrollToPos scrolling to scroll to the correct parent element instead of the editor root
+- Updated dependencies
+
 ## 116.23.1
 
 ### Patch Changes

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.23.0";
+var packageVersion = "116.23.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/preset/core-plugin/index.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.corePlugin = void 0;
 var _model = require("@atlaskit/editor-prosemirror/model");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _nodeAnchorProvider = require("../../node-anchor/node-anchor-provider");
 var _processRawFragmentValue = require("../../utils/processRawFragmentValue");
@@ -86,6 +87,19 @@ var corePlugin = exports.corePlugin = function corePlugin(_ref) {
         if (!isValidPos) {
           return false;
         }
+        if ((0, _platformFeatureFlags.fg)('platform_editor_fix_scroll_to_pos')) {
+          var _ref2, _editorView$domAtPos;
+          // nodeDOM can return a Text node for inline positions
+          var nodeDom = editorView.nodeDOM(pos);
+          var _dom = (_ref2 = nodeDom instanceof Element ? nodeDom : null) !== null && _ref2 !== void 0 ? _ref2 : (_editorView$domAtPos = editorView.domAtPos(pos)) === null || _editorView$domAtPos === void 0 ? void 0 : _editorView$domAtPos.node;
+          if (!(_dom instanceof Element)) {
+            return false;
+          }
+          _dom.scrollIntoView(scrollOptions);
+          return true;
+        }
+
+        // Legacy path — domAtPos interprets block boundaries as the parent container
         var dom = editorView.domAtPos(pos).node;
         if (!(dom instanceof Element)) {
           // If it's not an element (e.g. #text node), we'll try the parent.

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.23.0";
+var packageVersion = "116.23.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "116.23.0";
+const packageVersion = "116.23.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/preset/core-plugin/index.js

@@ -1,4 +1,5 @@
 import { Node } from '@atlaskit/editor-prosemirror/model';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getNodeIdProvider } from '../../node-anchor/node-anchor-provider';
 import { processRawFragmentValue } from '../../utils/processRawFragmentValue';
@@ -82,6 +83,19 @@ export const corePlugin = ({
         if (!isValidPos) {
           return false;
         }
+        if (fg('platform_editor_fix_scroll_to_pos')) {
+          var _ref, _editorView$domAtPos;
+          // nodeDOM can return a Text node for inline positions
+          const nodeDom = editorView.nodeDOM(pos);
+          const dom = (_ref = nodeDom instanceof Element ? nodeDom : null) !== null && _ref !== void 0 ? _ref : (_editorView$domAtPos = editorView.domAtPos(pos)) === null || _editorView$domAtPos === void 0 ? void 0 : _editorView$domAtPos.node;
+          if (!(dom instanceof Element)) {
+            return false;
+          }
+          dom.scrollIntoView(scrollOptions);
+          return true;
+        }
+
+        // Legacy path — domAtPos interprets block boundaries as the parent container
         const dom = editorView.domAtPos(pos).node;
         if (!(dom instanceof Element)) {
           // If it's not an element (e.g. #text node), we'll try the parent.

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "116.23.0";
+const packageVersion = "116.23.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.23.0";
+var packageVersion = "116.23.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/preset/core-plugin/index.js

@@ -1,4 +1,5 @@
 import { Node } from '@atlaskit/editor-prosemirror/model';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getNodeIdProvider } from '../../node-anchor/node-anchor-provider';
 import { processRawFragmentValue } from '../../utils/processRawFragmentValue';
@@ -81,6 +82,19 @@ export var corePlugin = function corePlugin(_ref) {
         if (!isValidPos) {
           return false;
         }
+        if (fg('platform_editor_fix_scroll_to_pos')) {
+          var _ref2, _editorView$domAtPos;
+          // nodeDOM can return a Text node for inline positions
+          var nodeDom = editorView.nodeDOM(pos);
+          var _dom = (_ref2 = nodeDom instanceof Element ? nodeDom : null) !== null && _ref2 !== void 0 ? _ref2 : (_editorView$domAtPos = editorView.domAtPos(pos)) === null || _editorView$domAtPos === void 0 ? void 0 : _editorView$domAtPos.node;
+          if (!(_dom instanceof Element)) {
+            return false;
+          }
+          _dom.scrollIntoView(scrollOptions);
+          return true;
+        }
+
+        // Legacy path — domAtPos interprets block boundaries as the parent container
         var dom = editorView.domAtPos(pos).node;
         if (!(dom instanceof Element)) {
           // If it's not an element (e.g. #text node), we'll try the parent.

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.23.0";
+var packageVersion = "116.23.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "116.23.1",
+	"version": "116.23.2",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -12,9 +12,7 @@
 	"module": "dist/esm/index.js",
 	"module:es2019": "dist/es2019/index.js",
 	"types": "dist/types/index.d.ts",
-	"sideEffects": [
-		"**/*.compiled.css"
-	],
+	"sideEffects": ["**/*.compiled.css"],
 	"atlaskit:src": "src/index.ts",
 	"atlassian": {
 		"react-compiler": {
@@ -61,7 +59,7 @@
 		"@atlaskit/media-file-preview": "^1.1.0",
 		"@atlaskit/media-picker": "^72.1.0",
 		"@atlaskit/media-ui": "^30.6.0",
-		"@atlaskit/media-viewer": "^54.3.0",
+		"@atlaskit/media-viewer": "^54.4.0",
 		"@atlaskit/mention": "^27.5.0",
 		"@atlaskit/menu": "^9.1.0",
 		"@atlaskit/object": "^2.1.0",
@@ -80,10 +78,10 @@
 		"@atlaskit/task-decision": "^21.4.0",
 		"@atlaskit/teams-app-config": "^2.1.0",
 		"@atlaskit/textfield": "^9.1.0",
-		"@atlaskit/tmp-editor-statsig": "^121.2.0",
+		"@atlaskit/tmp-editor-statsig": "^121.3.0",
 		"@atlaskit/tokens": "^15.4.0",
 		"@atlaskit/tooltip": "^23.1.0",
-		"@atlaskit/width-detector": "^6.1.0",
+		"@atlaskit/width-detector": "^6.2.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"@emotion/react": "^11.7.1",
@@ -142,20 +140,13 @@
 	},
 	"techstack": {
 		"@atlassian/frontend": {
-			"circular-dependencies": [
-				"file-level"
-			],
+			"circular-dependencies": ["file-level"],
 			"import-structure": "atlassian-conventions"
 		},
 		"@repo/internal": {
 			"deprecation": "no-deprecated-imports",
-			"design-tokens": [
-				"color"
-			],
-			"styling": [
-				"emotion",
-				"compiled"
-			]
+			"design-tokens": ["color"],
+			"styling": ["emotion", "compiled"]
 		}
 	},
 	"platform-feature-flags": {
@@ -264,6 +255,9 @@
 		},
 		"platform_editor_panel_c1_fallback_transform": {
 			"type": "boolean"
+		},
+		"platform_editor_fix_scroll_to_pos": {
+			"type": "boolean"
 		}
 	}
 }