@atlaskit/editor-common 116.10.1 → 116.11.1

package/CHANGELOG.md

@@ -1,5 +1,50 @@
 # @atlaskit/editor-common
 
+## 116.11.1
+
+### Patch Changes
+
+- [`49b8e9a322976`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/49b8e9a322976) -
+  Reduce q4 lovability experiment exposure noise in code block setup and bookkeeping paths
+- Updated dependencies
+
+## 116.11.0
+
+### Minor Changes
+
+- [`b483e293da76f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b483e293da76f) -
+  Add a gated `isSuggested` attribute to block menu element transformed analytics events so
+  suggested and non-suggested transform selections can be distinguished. The event attribute is
+  gated behind the `platform_editor_blocks_patch_2` feature gate.
+- [`dbf22f118dd9e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/dbf22f118dd9e) -
+  Rewrite Rovo Chat @-mention provider on a single Relay-native RovoChatMentionResource that fires
+  people + agents in parallel via Promise. People render as soon as URS resolves and agents pop in
+  below when ready. New aliased agentStudio_getAgents query consolidates 3 prefetch round trips into
+  1, drops over-fetched fields, and uses real abort plumbing. Adds opt-in subscribeToItemsUpdates
+  multi-emit contract to the editor mention typeahead so progressive emissions are no longer dropped
+  after the first frame.
+- [`77f3d60237123`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/77f3d60237123) -
+  Add a live word count next to the line count in the markdown source view footer
+- [`59f92f7b6fbac`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/59f92f7b6fbac) -
+  EDITOR-7095: Use shorter tooltip for padlock
+
+### Patch Changes
+
+- [`ee28cf33718b0`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ee28cf33718b0) -
+  Add @atlassian/react-compiler-gating as a runtime dependency to enable React Compiler platform
+  gating.
+- [`64a0b50380570`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/64a0b50380570) - -
+  Improve TypeScript auto-detection for class fields and typed arrow function params/return types.
+  - Avoid unnecessary code block node updates when auto-detection re-detects the same language.
+  - Prevent wrap toggles from scrolling long code blocks to the top.
+  - Keep the language picker placement stable while it is open.
+  - Reset language picker search state on reopen so recent selections are not reported as search
+    selections.
+  - Prevent language picker close/selection from scrolling partially visible code blocks while
+    restoring editor focus.
+  - Add auto-detection analytics metadata to distinguish initial detection from re-detection.
+- Updated dependencies
+
 ## 116.10.1
 
 ### Patch Changes

package/afm-cc/tsconfig.json

@@ -184,6 +184,9 @@
 		{
 			"path": "../../../design-system/width-detector/afm-cc/tsconfig.json"
 		},
+		{
+			"path": "../../../react-compiler/react-compiler-gating/afm-cc/tsconfig.json"
+		},
 		{
 			"path": "../../../media/media-core/afm-cc/tsconfig.json"
 		}

package/afm-products/tsconfig.json

@@ -184,6 +184,9 @@
 		{
 			"path": "../../../design-system/width-detector/afm-products/tsconfig.json"
 		},
+		{
+			"path": "../../../react-compiler/react-compiler-gating/afm-products/tsconfig.json"
+		},
 		{
 			"path": "../../../media/media-core/afm-products/tsconfig.json"
 		}

package/dist/cjs/ai-messages/ai-suggestions.js

@@ -121,9 +121,9 @@ var aiSuggestionsMessages = exports.aiSuggestionsMessages = (0, _reactIntl.defin
     defaultMessage: 'Private',
     description: 'Label for the private/lock indicator on the AI suggestions card'
   },
-  cardPrivateTooltipLabel: {
-    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabel.non-final',
-    defaultMessage: 'Only you and those with access to the sources can see this private suggestion.',
+  cardPrivateTooltipLabelShort: {
+    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabelShort.non-final',
+    defaultMessage: 'Visible only to you',
     description: 'Tooltip shown on the private indicator icon in the AI suggestions card'
   },
   cardSourcesButtonLabel: {

package/dist/cjs/code-block/index.js

@@ -11,6 +11,7 @@ var _adfSchema = require("@atlaskit/adf-schema");
 var _transform = require("@atlaskit/editor-prosemirror/transform");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
+var _expValEqualsNoExposure = require("@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure");
 var _slice = require("../utils/slice");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /* eslint-disable @atlaskit/volt-strict-mode/no-multiple-exports */
@@ -26,7 +27,7 @@ var getDefaultCodeBlockAttrs = exports.getDefaultCodeBlockAttrs = function getDe
   var attrsWithLocalId = localId ? _objectSpread(_objectSpread({}, attrs), {}, {
     localId: localId
   }) : attrs;
-  if (!(0, _expValEquals.expValEquals)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!(0, _expValEqualsNoExposure.expValEqualsNoExposure)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return attrsWithLocalId;
   }
 
@@ -130,14 +131,14 @@ var getInsertedCodeBlocksInTransaction = exports.getInsertedCodeBlocksInTransact
 
 var codeBlockFoldStates = new WeakMap();
 var isCodeBlockWordWrapEnabled = exports.isCodeBlockWordWrapEnabled = function isCodeBlockWordWrapEnabled(codeBlockNode) {
-  if ((0, _expValEquals.expValEquals)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if ((0, _expValEqualsNoExposure.expValEqualsNoExposure)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return Boolean(codeBlockNode.attrs.wrap);
   }
   var currentNodeWordWrapState = codeBlockWrappedStates.get(codeBlockNode);
   return currentNodeWordWrapState !== undefined ? currentNodeWordWrapState : defaultWordWrapState;
 };
 var areCodeBlockLineNumbersHidden = exports.areCodeBlockLineNumbersHidden = function areCodeBlockLineNumbersHidden(codeBlockNode) {
-  if (!(0, _expValEquals.expValEquals)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!(0, _expValEqualsNoExposure.expValEqualsNoExposure)('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return false;
   }
   return Boolean(codeBlockNode.attrs.hideLineNumbers);

package/dist/cjs/monitoring/error.js

@@ -28,7 +28,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.10.0";
+var packageVersion = "116.11.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.10.0";
+var packageVersion = "116.11.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/ai-messages/ai-suggestions.js

@@ -115,9 +115,9 @@ export const aiSuggestionsMessages = defineMessages({
     defaultMessage: 'Private',
     description: 'Label for the private/lock indicator on the AI suggestions card'
   },
-  cardPrivateTooltipLabel: {
-    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabel.non-final',
-    defaultMessage: 'Only you and those with access to the sources can see this private suggestion.',
+  cardPrivateTooltipLabelShort: {
+    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabelShort.non-final',
+    defaultMessage: 'Visible only to you',
     description: 'Tooltip shown on the private indicator icon in the AI suggestions card'
   },
   cardSourcesButtonLabel: {

package/dist/es2019/code-block/index.js

@@ -3,6 +3,7 @@ import { uuid } from '@atlaskit/adf-schema';
 import { ReplaceAroundStep, ReplaceStep } from '@atlaskit/editor-prosemirror/transform';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 import { mapSlice } from '../utils/slice';
 export const defaultWordWrapState = false;
 
@@ -17,7 +18,7 @@ export const getDefaultCodeBlockAttrs = attrs => {
     ...attrs,
     localId
   } : attrs;
-  if (!expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return attrsWithLocalId;
   }
 
@@ -114,14 +115,14 @@ export const getInsertedCodeBlocksInTransaction = (tr, codeBlockType, options =
 
 const codeBlockFoldStates = new WeakMap();
 export const isCodeBlockWordWrapEnabled = codeBlockNode => {
-  if (expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return Boolean(codeBlockNode.attrs.wrap);
   }
   const currentNodeWordWrapState = codeBlockWrappedStates.get(codeBlockNode);
   return currentNodeWordWrapState !== undefined ? currentNodeWordWrapState : defaultWordWrapState;
 };
 export const areCodeBlockLineNumbersHidden = codeBlockNode => {
-  if (!expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return false;
   }
   return Boolean(codeBlockNode.attrs.hideLineNumbers);

package/dist/es2019/monitoring/error.js

@@ -14,7 +14,7 @@ const NETWORK_FAILURE_REGEX = /^network failure/i;
 const RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "116.10.0";
+const packageVersion = "116.11.0";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "116.10.0";
+const packageVersion = "116.11.0";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/ai-messages/ai-suggestions.js

@@ -115,9 +115,9 @@ export var aiSuggestionsMessages = defineMessages({
     defaultMessage: 'Private',
     description: 'Label for the private/lock indicator on the AI suggestions card'
   },
-  cardPrivateTooltipLabel: {
-    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabel.non-final',
-    defaultMessage: 'Only you and those with access to the sources can see this private suggestion.',
+  cardPrivateTooltipLabelShort: {
+    id: 'fabric.editor.ai.suggestions.card.privateTooltipLabelShort.non-final',
+    defaultMessage: 'Visible only to you',
     description: 'Tooltip shown on the private indicator icon in the AI suggestions card'
   },
   cardSourcesButtonLabel: {

package/dist/esm/code-block/index.js

@@ -7,6 +7,7 @@ import { uuid } from '@atlaskit/adf-schema';
 import { ReplaceAroundStep, ReplaceStep } from '@atlaskit/editor-prosemirror/transform';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+import { expValEqualsNoExposure } from '@atlaskit/tmp-editor-statsig/exp-val-equals-no-exposure';
 import { mapSlice } from '../utils/slice';
 export var defaultWordWrapState = false;
 
@@ -20,7 +21,7 @@ export var getDefaultCodeBlockAttrs = function getDefaultCodeBlockAttrs(attrs) {
   var attrsWithLocalId = localId ? _objectSpread(_objectSpread({}, attrs), {}, {
     localId: localId
   }) : attrs;
-  if (!expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return attrsWithLocalId;
   }
 
@@ -124,14 +125,14 @@ export var getInsertedCodeBlocksInTransaction = function getInsertedCodeBlocksIn
 
 var codeBlockFoldStates = new WeakMap();
 export var isCodeBlockWordWrapEnabled = function isCodeBlockWordWrapEnabled(codeBlockNode) {
-  if (expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return Boolean(codeBlockNode.attrs.wrap);
   }
   var currentNodeWordWrapState = codeBlockWrappedStates.get(codeBlockNode);
   return currentNodeWordWrapState !== undefined ? currentNodeWordWrapState : defaultWordWrapState;
 };
 export var areCodeBlockLineNumbersHidden = function areCodeBlockLineNumbersHidden(codeBlockNode) {
-  if (!expValEquals('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
+  if (!expValEqualsNoExposure('platform_editor_code_block_q4_lovability', 'isEnabled', true)) {
     return false;
   }
   return Boolean(codeBlockNode.attrs.hideLineNumbers);

package/dist/esm/monitoring/error.js

@@ -20,7 +20,7 @@ var NETWORK_FAILURE_REGEX = /^network failure/i;
 var RESIZE_OBSERVER_LOOP_REGEX = /ResizeObserver loop completed with undelivered notifications/;
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "116.10.0";
+var packageVersion = "116.11.0";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "116.10.0";
+var packageVersion = "116.11.0";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/ai-messages/ai-suggestions.d.ts

@@ -59,7 +59,7 @@ export declare const aiSuggestionsMessages: {
         description: string;
         id: string;
     };
-    cardPrivateTooltipLabel: {
+    cardPrivateTooltipLabelShort: {
         defaultMessage: string;
         description: string;
         id: string;

package/dist/types/analytics/types/block-menu-events.d.ts

@@ -37,6 +37,7 @@ interface ElementTransformAttr {
     inputMethod: INPUT_METHOD.BLOCK_MENU;
     isEmptyLine: boolean;
     isNested: boolean;
+    isSuggested?: boolean;
     outputNodesCount: number;
     sourceNodesCount: number;
     sourceNodesCountByType: Record<string, number>;

package/dist/types/analytics/types/general-events.d.ts

@@ -174,6 +174,7 @@ type CodeBlockLanguageSelectedAEP = TrackAEP<ACTION.LANGUAGE_SELECTED, ACTION_SU
     selectionSource?: 'all' | 'pinned' | 'recentlyUsed' | 'search';
 }, undefined>;
 type CodeBlockLanguageAutoDetectedAEP = TrackAEP<ACTION.LANGUAGE_AUTO_DETECTED, ACTION_SUBJECT.CODE_BLOCK, undefined, {
+    detectionPhase?: 'initial' | 'redetection';
     detectionResult: 'detected' | 'noneDetected';
     language: string;
 }, undefined>;

package/dist/types/types/markdown-mode-plugin-stub.d.ts

@@ -23,6 +23,7 @@ export type _MarkdownModePluginStateStub = {
         columnNumber: number;
         lineCount: number;
         lineNumber: number;
+        wordCount?: number;
     } | null;
     view: 'syntax' | 'split-view' | 'preview';
     wrapSourceCode: boolean;
@@ -59,6 +60,7 @@ export type _MarkdownModePluginStub = NextEditorPlugin<'markdownMode', {
             columnNumber: number;
             lineCount: number;
             lineNumber: number;
+            wordCount?: number;
         } | null) => void;
         setView: (view: 'syntax' | 'split-view' | 'preview') => void;
         setWrapSourceCode: (wrapSourceCode: boolean) => void;

package/dist/types/types/type-ahead.d.ts

@@ -75,6 +75,33 @@ export type TypeAheadSectionTitleUpdate = {
     title: string;
 };
 export type TypeAheadForceSelect = (props: TypeAheadForceSelectProps) => TypeAheadItem | undefined;
+/**
+ * Multi-emit contract returned by `TypeAheadHandler.subscribeToItemsUpdates`.
+ *
+ * The runtime awaits `initial` to render the dropdown's first frame,
+ * then re-renders with whatever each `subscribe` callback delivers
+ * thereafter. The returned unsubscribe function is called when the
+ * query changes or the component unmounts.
+ */
+export type TypeAheadItemsUpdate = {
+    initial: Promise<Array<TypeAheadItem>>;
+    /**
+     * Subscribe to incremental updates from this `TypeAheadItemsUpdate`.
+     *
+     * **Single-subscriber contract.** Implementations are NOT required
+     * to support multiple concurrent subscribers; calling `subscribe`
+     * twice on the same instance may silently overwrite the first
+     * callback. The runtime calls this once per filter cycle, and a
+     * fresh `TypeAheadItemsUpdate` is produced by
+     * `subscribeToItemsUpdates` for every query, so fan-out is never
+     * needed in practice.
+     *
+     * The returned function unsubscribes the callback and releases any
+     * underlying transport. The runtime calls it on query change or
+     * component unmount.
+     */
+    subscribe: (update: (items: Array<TypeAheadItem>) => void) => () => void;
+};
 export type MoreOptionsButtonConfig = {
     ariaLabel?: string;
     iconBefore?: ReactNode;
@@ -119,6 +146,28 @@ export type TypeAheadHandler = {
     onOpen?: (editorState: EditorState) => void;
     /** Handler returns a transaction which inserts the TypeAheadItem into the doc */
     selectItem: TypeAheadSelectItem;
+    /**
+     * Optional opt-in to multi-emit. When implemented, the type-ahead
+     * runtime calls this INSTEAD of `getItems` and renders the dropdown
+     * progressively as updates arrive.
+     *
+     * Returns:
+     *  - `initial`: a Promise that resolves with the first set of items
+     *    to show. Replaces the single-shot `getItems` Promise.
+     *  - `subscribe(update)`: registers a callback that fires with a
+     *    fresh items array whenever the underlying provider has more
+     *    results (for example: "people first, then merged people +
+     *    agents" for the Rovo Chat mention provider). Returns an
+     *    unsubscribe function that the runtime calls on query change
+     *    or component unmount.
+     *
+     * Existing handlers using only `getItems` continue to work
+     * unchanged. This field is purely additive.
+     */
+    subscribeToItemsUpdates?: (props: {
+        editorState: EditorState;
+        query: string;
+    }) => TypeAheadItemsUpdate;
     /** Pattern that will trigger the TypeAhead */
     trigger: string;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "116.10.1",
+	"version": "116.11.1",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -73,16 +73,17 @@
 		"@atlaskit/prosemirror-history": "^1.0.0",
 		"@atlaskit/react-ufo": "^7.1.0",
 		"@atlaskit/section-message": "^9.1.0",
-		"@atlaskit/smart-card": "^45.2.0",
+		"@atlaskit/smart-card": "^45.3.0",
 		"@atlaskit/smart-user-picker": "^11.0.0",
 		"@atlaskit/spinner": "^20.0.0",
 		"@atlaskit/task-decision": "^21.2.0",
 		"@atlaskit/teams-app-config": "^2.0.0",
 		"@atlaskit/textfield": "^9.0.0",
-		"@atlaskit/tmp-editor-statsig": "^109.3.0",
-		"@atlaskit/tokens": "^14.0.0",
+		"@atlaskit/tmp-editor-statsig": "^111.0.0",
+		"@atlaskit/tokens": "^15.0.0",
 		"@atlaskit/tooltip": "^23.0.0",
 		"@atlaskit/width-detector": "^6.0.0",
+		"@atlassian/react-compiler-gating": "^0.2.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"@emotion/react": "^11.7.1",
@@ -121,7 +122,6 @@
 	"devDependencies": {
 		"@atlaskit/media-core": "^38.0.0",
 		"@atlassian/a11y-jest-testing": "^0.12.0",
-		"@atlassian/react-compiler-gating": "workspace:^",
 		"@testing-library/dom": "^10.1.0",
 		"@testing-library/jest-dom": "^6.4.5",
 		"@testing-library/react": "^16.3.0",