@atlaskit/editor-common 115.8.1 → 115.9.0

package/CHANGELOG.md

@@ -1,5 +1,44 @@
 # @atlaskit/editor-common
 
+## 115.9.0
+
+### Minor Changes
+
+- [`92da883bae00d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/92da883bae00d) -
+  Use XPC-wrapped destination URL for link navigation behind `platform_smartlink_xpc_url_wrapping`.
+
+  When the feature gate is enabled, the following link-opening locations now use the cross-product
+  analytics parameter-enriched URL provided by SmartCard instead of the raw node URL:
+  - **Toolbar "Open Link" button** (both smart card and datasource paths) — uses the new
+    `useSmartLinkDestinationUrl` hook from
+    `@atlaskit/smart-card/hook/use-smart-link-destination-url` via a new `OpenLinkToolbarButton`
+    custom toolbar component.
+  - **Inline card overlay anchor** (`InlineCardOverlay`) — `href` updated to use
+    `useSmartLinkDestinationUrl`.
+  - **Hover link overlay** (`HoverLinkOverlay`) — accepts a new optional `destinationUrl` prop; when
+    provided and the gate is on, uses it for both the anchor `href` and double-click `window.open`.
+    The `destinationUrl` is computed by `inlineCardWithAwareness` using `useSmartLinkDestinationUrl`
+    and passed down — keeping `editor-common` free of any SmartCard provider dependency.
+  - **Inline card Cmd/Ctrl+click** — reads `data.destinationUrl` from SmartCard's `onClick` callback
+    (typed as `OnClickCallback` from `@atlaskit/smart-card/card/types`).
+
+  All changes gracefully fall back to the raw URL when the gate is off or the link has not yet
+  resolved.
+
+### Patch Changes
+
+- Updated dependencies
+
+## 115.8.2
+
+### Patch Changes
+
+- [`809a7bb620a33`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/809a7bb620a33) -
+  [ux] Cleanup feature gate `cc_editor_hover_link_overlay_css_fix`. The hover link overlay overflow
+  handling is now always active, so labels reset on hover and hide when the button would overflow
+  its container.
+- Updated dependencies
+
 ## 115.8.1
 
 ### Patch Changes

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t2 in e) "default" !== _t2 && {}.hasOwnProperty.call(e, _t2) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t2)) && (i.get || i.set) ? o(f, _t2, i) : f[_t2] = e[_t2]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "115.8.0";
+var packageVersion = "115.8.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "115.8.0";
+var packageVersion = "115.8.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/ui/HoverLinkOverlay/index.js

@@ -105,6 +105,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
     _ref$isVisible = _ref.isVisible,
     isVisible = _ref$isVisible === void 0 ? false : _ref$isVisible,
     url = _ref.url,
+    destinationUrl = _ref.destinationUrl,
     _ref$compactPadding = _ref.compactPadding,
     compactPadding = _ref$compactPadding === void 0 ? false : _ref$compactPadding,
     editorAnalyticsApi = _ref.editorAnalyticsApi,
@@ -169,13 +170,11 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
     // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
     // the hover button can overflow beyond the container bounds. We detect this by comparing
     // the button's right edge to the container's right edge, and hide the label if it overflows.
-    if ((0, _experiments.editorExperiment)('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (containerRef.current && hoverLinkButtonRef.current) {
-        var containerRight = containerRef.current.getBoundingClientRect().right;
-        var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
-        if (buttonRight > containerRight) {
-          canShowLabel = false;
-        }
+    if (containerRef.current && hoverLinkButtonRef.current) {
+      var containerRight = containerRef.current.getBoundingClientRect().right;
+      var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+      if (buttonRight > containerRight) {
+        canShowLabel = false;
       }
     }
     setShowLabel(canShowLabel);
@@ -185,10 +184,8 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
 
     // Reset label visibility on hover start so we can measure if it overflows.
     // Without this, the label stays hidden from a previous hover and won't be re-measured.
-    if ((0, _experiments.editorExperiment)('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (isHovered) {
-        setShowLabel(true);
-      }
+    if (isHovered) {
+      setShowLabel(true);
     }
   };
   var sendVisitLinkAnalytics = function sendVisitLinkAnalytics(inputMethod) {
@@ -201,7 +198,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
       sendVisitLinkAnalytics(_analytics.INPUT_METHOD.DOUBLE_CLICK);
 
       // Double click opens the link in a new tab
-      window.open(url, '_blank');
+      window.open((0, _platformFeatureFlags.fg)('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url, '_blank');
     }
   };
   var handleClick = function handleClick(event) {
@@ -253,7 +250,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
   }, label)), isHovered && (0, _react2.jsx)(_primitives.Anchor, {
     ref: hoverLinkButtonRef,
     xcss: linkStylesCommon,
-    href: url,
+    href: (0, _platformFeatureFlags.fg)('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url,
     target: "_blank"
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- dynamic paddingBlock value based on experiment flags
     ,

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "115.8.0";
+const packageVersion = "115.8.2";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "115.8.0";
+const packageVersion = "115.8.2";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/ui/HoverLinkOverlay/index.js

@@ -92,6 +92,7 @@ const HoverLinkOverlay = ({
   children,
   isVisible = false,
   url,
+  destinationUrl,
   compactPadding = false,
   editorAnalyticsApi,
   view,
@@ -148,13 +149,11 @@ const HoverLinkOverlay = ({
     // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
     // the hover button can overflow beyond the container bounds. We detect this by comparing
     // the button's right edge to the container's right edge, and hide the label if it overflows.
-    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (containerRef.current && hoverLinkButtonRef.current) {
-        const containerRight = containerRef.current.getBoundingClientRect().right;
-        const buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
-        if (buttonRight > containerRight) {
-          canShowLabel = false;
-        }
+    if (containerRef.current && hoverLinkButtonRef.current) {
+      const containerRight = containerRef.current.getBoundingClientRect().right;
+      const buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+      if (buttonRight > containerRight) {
+        canShowLabel = false;
       }
     }
     setShowLabel(canShowLabel);
@@ -164,10 +163,8 @@ const HoverLinkOverlay = ({
 
     // Reset label visibility on hover start so we can measure if it overflows.
     // Without this, the label stays hidden from a previous hover and won't be re-measured.
-    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (isHovered) {
-        setShowLabel(true);
-      }
+    if (isHovered) {
+      setShowLabel(true);
     }
   };
   const sendVisitLinkAnalytics = inputMethod => {
@@ -180,7 +177,7 @@ const HoverLinkOverlay = ({
       sendVisitLinkAnalytics(INPUT_METHOD.DOUBLE_CLICK);
 
       // Double click opens the link in a new tab
-      window.open(url, '_blank');
+      window.open(fg('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url, '_blank');
     }
   };
   const handleClick = event => {
@@ -228,7 +225,7 @@ const HoverLinkOverlay = ({
   }, label)), isHovered && jsx(Anchor, {
     ref: hoverLinkButtonRef,
     xcss: linkStylesCommon,
-    href: url,
+    href: fg('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url,
     target: "_blank"
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- dynamic paddingBlock value based on experiment flags
     ,

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "115.8.0";
+var packageVersion = "115.8.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "115.8.0";
+var packageVersion = "115.8.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/ui/HoverLinkOverlay/index.js

@@ -92,6 +92,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
     _ref$isVisible = _ref.isVisible,
     isVisible = _ref$isVisible === void 0 ? false : _ref$isVisible,
     url = _ref.url,
+    destinationUrl = _ref.destinationUrl,
     _ref$compactPadding = _ref.compactPadding,
     compactPadding = _ref$compactPadding === void 0 ? false : _ref$compactPadding,
     editorAnalyticsApi = _ref.editorAnalyticsApi,
@@ -156,13 +157,11 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
     // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
     // the hover button can overflow beyond the container bounds. We detect this by comparing
     // the button's right edge to the container's right edge, and hide the label if it overflows.
-    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (containerRef.current && hoverLinkButtonRef.current) {
-        var containerRight = containerRef.current.getBoundingClientRect().right;
-        var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
-        if (buttonRight > containerRight) {
-          canShowLabel = false;
-        }
+    if (containerRef.current && hoverLinkButtonRef.current) {
+      var containerRight = containerRef.current.getBoundingClientRect().right;
+      var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+      if (buttonRight > containerRight) {
+        canShowLabel = false;
       }
     }
     setShowLabel(canShowLabel);
@@ -172,10 +171,8 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
 
     // Reset label visibility on hover start so we can measure if it overflows.
     // Without this, the label stays hidden from a previous hover and won't be re-measured.
-    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
-      if (isHovered) {
-        setShowLabel(true);
-      }
+    if (isHovered) {
+      setShowLabel(true);
     }
   };
   var sendVisitLinkAnalytics = function sendVisitLinkAnalytics(inputMethod) {
@@ -188,7 +185,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
       sendVisitLinkAnalytics(INPUT_METHOD.DOUBLE_CLICK);
 
       // Double click opens the link in a new tab
-      window.open(url, '_blank');
+      window.open(fg('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url, '_blank');
     }
   };
   var handleClick = function handleClick(event) {
@@ -240,7 +237,7 @@ var HoverLinkOverlay = function HoverLinkOverlay(_ref) {
   }, label)), isHovered && jsx(Anchor, {
     ref: hoverLinkButtonRef,
     xcss: linkStylesCommon,
-    href: url,
+    href: fg('platform_smartlink_xpc_url_wrapping') ? destinationUrl !== null && destinationUrl !== void 0 ? destinationUrl : url : url,
     target: "_blank"
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- dynamic paddingBlock value based on experiment flags
     ,

package/dist/types/ui/HoverLinkOverlay/index.d.ts

@@ -5,5 +5,5 @@
 import React from 'react';
 import { jsx } from '@emotion/react';
 import type { HoverLinkOverlayProps } from './types';
-declare const HoverLinkOverlay: ({ children, isVisible, url, compactPadding, editorAnalyticsApi, view, onClick, showPanelButton, showPanelButtonIcon, }: React.PropsWithChildren<HoverLinkOverlayProps>) => jsx.JSX.Element;
+declare const HoverLinkOverlay: ({ children, isVisible, url, destinationUrl, compactPadding, editorAnalyticsApi, view, onClick, showPanelButton, showPanelButtonIcon, }: React.PropsWithChildren<HoverLinkOverlayProps>) => jsx.JSX.Element;
 export default HoverLinkOverlay;

package/dist/types/ui/HoverLinkOverlay/types.d.ts

@@ -2,6 +2,7 @@ import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 import type { EditorAnalyticsAPI } from '../../analytics';
 export type HoverLinkOverlayProps = React.HTMLAttributes<HTMLSpanElement> & {
     compactPadding?: boolean;
+    destinationUrl?: string;
     editorAnalyticsApi?: EditorAnalyticsAPI;
     isVisible?: boolean;
     onClick?: (event: React.MouseEvent<HTMLAnchorElement>) => void;

package/dist/types-ts4.5/ui/HoverLinkOverlay/index.d.ts

@@ -5,5 +5,5 @@
 import React from 'react';
 import { jsx } from '@emotion/react';
 import type { HoverLinkOverlayProps } from './types';
-declare const HoverLinkOverlay: ({ children, isVisible, url, compactPadding, editorAnalyticsApi, view, onClick, showPanelButton, showPanelButtonIcon, }: React.PropsWithChildren<HoverLinkOverlayProps>) => jsx.JSX.Element;
+declare const HoverLinkOverlay: ({ children, isVisible, url, destinationUrl, compactPadding, editorAnalyticsApi, view, onClick, showPanelButton, showPanelButtonIcon, }: React.PropsWithChildren<HoverLinkOverlayProps>) => jsx.JSX.Element;
 export default HoverLinkOverlay;

package/dist/types-ts4.5/ui/HoverLinkOverlay/types.d.ts

@@ -2,6 +2,7 @@ import type { EditorView } from '@atlaskit/editor-prosemirror/view';
 import type { EditorAnalyticsAPI } from '../../analytics';
 export type HoverLinkOverlayProps = React.HTMLAttributes<HTMLSpanElement> & {
     compactPadding?: boolean;
+    destinationUrl?: string;
     editorAnalyticsApi?: EditorAnalyticsAPI;
     isVisible?: boolean;
     onClick?: (event: React.MouseEvent<HTMLAnchorElement>) => void;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "115.8.1",
+	"version": "115.9.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -57,7 +57,7 @@
 		"@atlaskit/editor-tables": "^2.10.0",
 		"@atlaskit/editor-toolbar": "^1.10.0",
 		"@atlaskit/editor-toolbar-model": "^0.5.0",
-		"@atlaskit/emoji": "^70.16.0",
+		"@atlaskit/emoji": "^70.17.0",
 		"@atlaskit/icon": "^35.4.0",
 		"@atlaskit/link": "^3.4.0",
 		"@atlaskit/link-datasource": "^5.6.0",
@@ -77,17 +77,17 @@
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/platform-feature-flags-react": "^0.5.0",
 		"@atlaskit/primitives": "^19.0.0",
-		"@atlaskit/profilecard": "^25.8.0",
+		"@atlaskit/profilecard": "^25.9.0",
 		"@atlaskit/prosemirror-history": "^0.2.0",
 		"@atlaskit/react-ufo": "^6.7.0",
 		"@atlaskit/section-message": "^8.13.0",
-		"@atlaskit/smart-card": "^44.25.0",
+		"@atlaskit/smart-card": "^44.26.0",
 		"@atlaskit/smart-user-picker": "^10.2.0",
 		"@atlaskit/spinner": "^19.1.0",
 		"@atlaskit/task-decision": "^20.1.0",
 		"@atlaskit/teams-app-config": "^1.12.0",
 		"@atlaskit/textfield": "^8.3.0",
-		"@atlaskit/tmp-editor-statsig": "^93.0.0",
+		"@atlaskit/tmp-editor-statsig": "^94.0.0",
 		"@atlaskit/tokens": "^13.3.0",
 		"@atlaskit/tooltip": "^22.6.0",
 		"@atlaskit/width-detector": "^5.1.0",
@@ -273,6 +273,10 @@
 		"people-teams_migrate-user-profile-card": {
 			"type": "boolean"
 		},
+		"platform_smartlink_xpc_url_wrapping": {
+			"type": "boolean",
+			"referenceOnly": true
+		},
 		"platform_editor_ai_selection_local_ids": {
 			"type": "boolean"
 		},