@atlaskit/editor-common 115.10.1 → 115.12.0

package/CHANGELOG.md

@@ -1,5 +1,48 @@
 # @atlaskit/editor-common
 
+## 115.12.0
+
+### Minor Changes
+
+- [`a812261b9c644`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a812261b9c644) -
+  Added analytics for clicking Suggested Edits entry points
+
+### Patch Changes
+
+- [`8430991dd8eb6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8430991dd8eb6) -
+  follow up pr to add affectedBlocks as an attribute to discard analytics
+- Updated dependencies
+
+## 115.11.2
+
+### Patch Changes
+
+- Updated dependencies
+
+## 115.11.1
+
+### Patch Changes
+
+- Updated dependencies
+
+## 115.11.0
+
+### Minor Changes
+
+- [`1dc602ab5b6ec`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1dc602ab5b6ec) -
+  Bug Fix for pop up rendering on the bottom instead of top of pop up modal
+
+### Patch Changes
+
+- Updated dependencies
+
+## 115.10.2
+
+### Patch Changes
+
+- [`50d17160d7177`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/50d17160d7177) -
+  Cleanup FG `platform_editor_ally_remove_role_tabpanel`
+
 ## 115.10.1
 
 ### Patch Changes

package/dist/cjs/element-browser/components/ElementList/ElementList.js

@@ -133,8 +133,8 @@ function ElementList(_ref) {
     css: elementItemsWrapper,
     "data-testid": "element-items",
     id: selectedCategory ? "browse-category-".concat(selectedCategory, "-tab") : 'browse-category-tab',
-    "aria-labelledby": !hasTabListContext && (0, _platformFeatureFlags.fg)('platform_editor_ally_remove_role_tabpanel') ? undefined : selectedCategory ? "browse-category--".concat(selectedCategory, "-button") : 'browse-category-button',
-    role: !hasTabListContext && (0, _platformFeatureFlags.fg)('platform_editor_ally_remove_role_tabpanel') ? undefined : 'tabpanel',
+    "aria-labelledby": !hasTabListContext ? undefined : selectedCategory ? "browse-category--".concat(selectedCategory, "-button") : 'browse-category-button',
+    role: !hasTabListContext ? undefined : 'tabpanel',
     tabIndex: items.length === 0 ? 0 : undefined
   }, !items.length ? emptyStateHandler ? emptyStateHandler({
     mode: mode,

package/dist/cjs/element-browser/components/ElementSearch.js

@@ -116,8 +116,7 @@ function ElementSearch(_ref) {
       }, "\u23CE ", formatMessage(_messages.default.elementAfterInputMessage))),
       placeholder: formatMessage(_messages.default.placeHolderMessage),
       "aria-label": formatMessage((0, _platformFeatureFlags.fg)('ally_30205_accessibility_label_fix') ? _messages.default.searchAriaLabelNew : _messages.default.searchAriaLabel),
-      "aria-labelledby": (0, _platformFeatureFlags.fg)('platform_editor_ally_remove_role_tabpanel') ? undefined : 'search-assistive',
-      "aria-describedby": (0, _platformFeatureFlags.fg)('platform_editor_ally_remove_role_tabpanel') ? 'search-assistive' : undefined
+      "aria-describedby": "search-assistive"
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       ,
       className: "js-search-input",

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t2 in e) "default" !== _t2 && {}.hasOwnProperty.call(e, _t2) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t2)) && (i.get || i.set) ? o(f, _t2, i) : f[_t2] = e[_t2]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "115.10.0";
+var packageVersion = "115.11.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "115.10.0";
+var packageVersion = "115.11.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/ui/Popup/utils.js

@@ -35,7 +35,16 @@ var _validatePosition = require("./validatePosition");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 /**
+ * Determines the optimal vertical placement ('top' or 'bottom') for a popup relative to a target element.
  * Decides if given fitHeight fits below or above the target taking boundaries into account.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitHeight - The desired height of the popup content
+ * @param alignY - Forced alignment direction ('top' or 'bottom')
+ * @param forcePlacement - Whether to force the placement to the alignY value
+ * @param preventOverflow - Whether to prevent overflow by forcing bottom placement when space above is insufficient
+ * @returns The optimal placement direction ('top' or 'bottom')
  */
 function getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow) {
   if (forcePlacement && alignY) {
@@ -64,10 +73,16 @@ function getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forc
       return 'bottom';
     }
   }
-  if (spaceBelow >= fitHeight || spaceBelow >= spaceAbove) {
+  if (spaceBelow >= fitHeight) {
     return 'bottom';
   }
-  return 'top';
+  if (spaceAbove >= fitHeight) {
+    return 'top';
+  }
+
+  // If neither space can accommodate the full height, prefer the one with more space
+  // When spaces are equal, prefer 'top' to show the top portion of the popup
+  return spaceAbove >= spaceBelow ? 'top' : 'bottom';
 }
 
 /**
@@ -101,6 +116,20 @@ function getHorizontalPlacement(target, boundariesElement, fitWidth, alignX, for
   }
   return 'right';
 }
+
+/**
+ * Calculates the optimal placement for a popup element in both vertical and horizontal directions.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitWidth - The desired width of the popup content
+ * @param fitHeight - The desired height of the popup content
+ * @param alignX - Forced horizontal alignment direction
+ * @param alignY - Forced vertical alignment direction
+ * @param forcePlacement - Whether to force the placement to the specified alignment values
+ * @param preventOverflow - Whether to prevent overflow by adjusting placement
+ * @returns A tuple containing the vertical and horizontal placement directions
+ */
 function calculatePlacement(target, boundariesElement, fitWidth, fitHeight, alignX, alignY, forcePlacement, preventOverflow) {
   return [getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow), getHorizontalPlacement(target, boundariesElement, fitWidth, alignX, forcePlacement, preventOverflow)];
 }

package/dist/es2019/element-browser/components/ElementList/ElementList.js

@@ -120,8 +120,8 @@ function ElementList({
     css: elementItemsWrapper,
     "data-testid": "element-items",
     id: selectedCategory ? `browse-category-${selectedCategory}-tab` : 'browse-category-tab',
-    "aria-labelledby": !hasTabListContext && fg('platform_editor_ally_remove_role_tabpanel') ? undefined : selectedCategory ? `browse-category--${selectedCategory}-button` : 'browse-category-button',
-    role: !hasTabListContext && fg('platform_editor_ally_remove_role_tabpanel') ? undefined : 'tabpanel',
+    "aria-labelledby": !hasTabListContext ? undefined : selectedCategory ? `browse-category--${selectedCategory}-button` : 'browse-category-button',
+    role: !hasTabListContext ? undefined : 'tabpanel',
     tabIndex: items.length === 0 ? 0 : undefined
   }, !items.length ? emptyStateHandler ? emptyStateHandler({
     mode,

package/dist/es2019/element-browser/components/ElementSearch.js

@@ -108,8 +108,7 @@ function ElementSearch({
       }, "\u23CE ", formatMessage(commonMessages.elementAfterInputMessage))),
       placeholder: formatMessage(commonMessages.placeHolderMessage),
       "aria-label": formatMessage(fg('ally_30205_accessibility_label_fix') ? commonMessages.searchAriaLabelNew : commonMessages.searchAriaLabel),
-      "aria-labelledby": fg('platform_editor_ally_remove_role_tabpanel') ? undefined : 'search-assistive',
-      "aria-describedby": fg('platform_editor_ally_remove_role_tabpanel') ? 'search-assistive' : undefined
+      "aria-describedby": "search-assistive"
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       ,
       className: "js-search-input",

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "115.10.0";
+const packageVersion = "115.11.2";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "115.10.0";
+const packageVersion = "115.11.2";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/ui/Popup/utils.js

@@ -1,7 +1,16 @@
 import { isBody } from './isBody';
 import { isTextNode } from './isTextNode';
 /**
+ * Determines the optimal vertical placement ('top' or 'bottom') for a popup relative to a target element.
  * Decides if given fitHeight fits below or above the target taking boundaries into account.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitHeight - The desired height of the popup content
+ * @param alignY - Forced alignment direction ('top' or 'bottom')
+ * @param forcePlacement - Whether to force the placement to the alignY value
+ * @param preventOverflow - Whether to prevent overflow by forcing bottom placement when space above is insufficient
+ * @returns The optimal placement direction ('top' or 'bottom')
  */
 export function getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow) {
   if (forcePlacement && alignY) {
@@ -33,10 +42,16 @@ export function getVerticalPlacement(target, boundariesElement, fitHeight, align
       return 'bottom';
     }
   }
-  if (spaceBelow >= fitHeight || spaceBelow >= spaceAbove) {
+  if (spaceBelow >= fitHeight) {
     return 'bottom';
   }
-  return 'top';
+  if (spaceAbove >= fitHeight) {
+    return 'top';
+  }
+
+  // If neither space can accommodate the full height, prefer the one with more space
+  // When spaces are equal, prefer 'top' to show the top portion of the popup
+  return spaceAbove >= spaceBelow ? 'top' : 'bottom';
 }
 
 /**
@@ -72,6 +87,20 @@ export function getHorizontalPlacement(target, boundariesElement, fitWidth, alig
   }
   return 'right';
 }
+
+/**
+ * Calculates the optimal placement for a popup element in both vertical and horizontal directions.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitWidth - The desired width of the popup content
+ * @param fitHeight - The desired height of the popup content
+ * @param alignX - Forced horizontal alignment direction
+ * @param alignY - Forced vertical alignment direction
+ * @param forcePlacement - Whether to force the placement to the specified alignment values
+ * @param preventOverflow - Whether to prevent overflow by adjusting placement
+ * @returns A tuple containing the vertical and horizontal placement directions
+ */
 export function calculatePlacement(target, boundariesElement, fitWidth, fitHeight, alignX, alignY, forcePlacement, preventOverflow) {
   return [getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow), getHorizontalPlacement(target, boundariesElement, fitWidth, alignX, forcePlacement, preventOverflow)];
 }

package/dist/esm/element-browser/components/ElementList/ElementList.js

@@ -122,8 +122,8 @@ function ElementList(_ref) {
     css: elementItemsWrapper,
     "data-testid": "element-items",
     id: selectedCategory ? "browse-category-".concat(selectedCategory, "-tab") : 'browse-category-tab',
-    "aria-labelledby": !hasTabListContext && fg('platform_editor_ally_remove_role_tabpanel') ? undefined : selectedCategory ? "browse-category--".concat(selectedCategory, "-button") : 'browse-category-button',
-    role: !hasTabListContext && fg('platform_editor_ally_remove_role_tabpanel') ? undefined : 'tabpanel',
+    "aria-labelledby": !hasTabListContext ? undefined : selectedCategory ? "browse-category--".concat(selectedCategory, "-button") : 'browse-category-button',
+    role: !hasTabListContext ? undefined : 'tabpanel',
     tabIndex: items.length === 0 ? 0 : undefined
   }, !items.length ? emptyStateHandler ? emptyStateHandler({
     mode: mode,

package/dist/esm/element-browser/components/ElementSearch.js

@@ -106,8 +106,7 @@ function ElementSearch(_ref) {
       }, "\u23CE ", formatMessage(commonMessages.elementAfterInputMessage))),
       placeholder: formatMessage(commonMessages.placeHolderMessage),
       "aria-label": formatMessage(fg('ally_30205_accessibility_label_fix') ? commonMessages.searchAriaLabelNew : commonMessages.searchAriaLabel),
-      "aria-labelledby": fg('platform_editor_ally_remove_role_tabpanel') ? undefined : 'search-assistive',
-      "aria-describedby": fg('platform_editor_ally_remove_role_tabpanel') ? 'search-assistive' : undefined
+      "aria-describedby": "search-assistive"
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       ,
       className: "js-search-input",

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "115.10.0";
+var packageVersion = "115.11.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "115.10.0";
+var packageVersion = "115.11.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/ui/Popup/utils.js

@@ -5,7 +5,16 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import { isBody } from './isBody';
 import { isTextNode } from './isTextNode';
 /**
+ * Determines the optimal vertical placement ('top' or 'bottom') for a popup relative to a target element.
  * Decides if given fitHeight fits below or above the target taking boundaries into account.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitHeight - The desired height of the popup content
+ * @param alignY - Forced alignment direction ('top' or 'bottom')
+ * @param forcePlacement - Whether to force the placement to the alignY value
+ * @param preventOverflow - Whether to prevent overflow by forcing bottom placement when space above is insufficient
+ * @returns The optimal placement direction ('top' or 'bottom')
  */
 export function getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow) {
   if (forcePlacement && alignY) {
@@ -34,10 +43,16 @@ export function getVerticalPlacement(target, boundariesElement, fitHeight, align
       return 'bottom';
     }
   }
-  if (spaceBelow >= fitHeight || spaceBelow >= spaceAbove) {
+  if (spaceBelow >= fitHeight) {
     return 'bottom';
   }
-  return 'top';
+  if (spaceAbove >= fitHeight) {
+    return 'top';
+  }
+
+  // If neither space can accommodate the full height, prefer the one with more space
+  // When spaces are equal, prefer 'top' to show the top portion of the popup
+  return spaceAbove >= spaceBelow ? 'top' : 'bottom';
 }
 
 /**
@@ -71,6 +86,20 @@ export function getHorizontalPlacement(target, boundariesElement, fitWidth, alig
   }
   return 'right';
 }
+
+/**
+ * Calculates the optimal placement for a popup element in both vertical and horizontal directions.
+ * 
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitWidth - The desired width of the popup content
+ * @param fitHeight - The desired height of the popup content
+ * @param alignX - Forced horizontal alignment direction
+ * @param alignY - Forced vertical alignment direction
+ * @param forcePlacement - Whether to force the placement to the specified alignment values
+ * @param preventOverflow - Whether to prevent overflow by adjusting placement
+ * @returns A tuple containing the vertical and horizontal placement directions
+ */
 export function calculatePlacement(target, boundariesElement, fitWidth, fitHeight, alignX, alignY, forcePlacement, preventOverflow) {
   return [getVerticalPlacement(target, boundariesElement, fitHeight, alignY, forcePlacement, preventOverflow), getHorizontalPlacement(target, boundariesElement, fitWidth, alignX, forcePlacement, preventOverflow)];
 }

package/dist/types/analytics/index.d.ts

@@ -59,4 +59,4 @@ export { type NcsSessionStepEventAEP, type NcsSessionStepMetrics, } from './type
 export type { BlockMenuEventPayload } from './types/block-menu-events';
 export type { BreakoutEventPayload, BreakoutSupportedNodes } from './types/breakout-events';
 export type { RendererSyncBlockEventPayload, SyncBlockEventPayload, SyncedBlockSSRErrorAEP, } from './types/sync-block-events';
-export type { AiSuggestionsEventPayload } from './types/ai-suggestions-events';
+export type { AiSuggestionsEntryPoint, AiSuggestionsEventPayload, } from './types/ai-suggestions-events';

package/dist/types/analytics/types/ai-suggestions-events.d.ts

@@ -1,5 +1,6 @@
 import type { ACTION, ACTION_SUBJECT } from './enums';
 import type { OperationalAEP, TrackAEP } from './utils';
+export type AiSuggestionsEntryPoint = 'primaryToolbar' | 'commentsEmptyState';
 type NoDiffSuggestionAEP = OperationalAEP<ACTION.NO_DIFF_FOUND, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
     suggestionType: string;
     toolCalls: {
@@ -8,6 +9,9 @@ type NoDiffSuggestionAEP = OperationalAEP<ACTION.NO_DIFF_FOUND, ACTION_SUBJECT.A
         nodeTypes: string[];
     }[];
 }>;
+type EntryPointClickedAEP = TrackAEP<ACTION.CLICKED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
+    entryPoint: AiSuggestionsEntryPoint;
+}, undefined>;
 type AcceptSuggestionAEP = TrackAEP<ACTION.ACCEPTED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
     affectedBlocks: number;
     charactersAdded: number;
@@ -16,6 +20,7 @@ type AcceptSuggestionAEP = TrackAEP<ACTION.ACCEPTED, ACTION_SUBJECT.AI_SUGGESTIO
     suggestionType: string;
 }, undefined>;
 type DiscardSuggestionAEP = TrackAEP<ACTION.DISCARDED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
+    affectedBlocks: number;
     entryPoint: 'sidebar' | 'card';
     suggestionType: string;
 }, undefined>;
@@ -28,5 +33,5 @@ type ViewSuggestionAEP = TrackAEP<ACTION.VIEWED, ACTION_SUBJECT.AI_SUGGESTIONS,
     suggestionCardCharacterCount: number;
     suggestionType: string;
 }, undefined>;
-export type AiSuggestionsEventPayload = NoDiffSuggestionAEP | AcceptSuggestionAEP | DiscardSuggestionAEP | ViewSuggestionAEP;
+export type AiSuggestionsEventPayload = NoDiffSuggestionAEP | EntryPointClickedAEP | AcceptSuggestionAEP | DiscardSuggestionAEP | ViewSuggestionAEP;
 export {};

package/dist/types/ui/Popup/utils.d.ts

@@ -12,18 +12,40 @@ export interface CalculatePositionParams {
     placement: [string, string];
     popup?: HTMLElement;
     rect?: DOMRect;
+    scrollableElement?: HTMLElement | false;
     stick?: boolean;
     target?: HTMLElement;
-    scrollableElement?: HTMLElement | false;
 }
 /**
+ * Determines the optimal vertical placement ('top' or 'bottom') for a popup relative to a target element.
  * Decides if given fitHeight fits below or above the target taking boundaries into account.
+ *
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitHeight - The desired height of the popup content
+ * @param alignY - Forced alignment direction ('top' or 'bottom')
+ * @param forcePlacement - Whether to force the placement to the alignY value
+ * @param preventOverflow - Whether to prevent overflow by forcing bottom placement when space above is insufficient
+ * @returns The optimal placement direction ('top' or 'bottom')
  */
 export declare function getVerticalPlacement(target: HTMLElement, boundariesElement: HTMLElement, fitHeight?: number, alignY?: string, forcePlacement?: boolean, preventOverflow?: boolean): string;
 /**
  * Decides if given fitWidth fits to the left or to the right of the target taking boundaries into account.
  */
 export declare function getHorizontalPlacement(target: HTMLElement, boundariesElement: HTMLElement, fitWidth?: number, alignX?: string, forcePlacement?: boolean, preventOverflow?: boolean): string;
+/**
+ * Calculates the optimal placement for a popup element in both vertical and horizontal directions.
+ *
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitWidth - The desired width of the popup content
+ * @param fitHeight - The desired height of the popup content
+ * @param alignX - Forced horizontal alignment direction
+ * @param alignY - Forced vertical alignment direction
+ * @param forcePlacement - Whether to force the placement to the specified alignment values
+ * @param preventOverflow - Whether to prevent overflow by adjusting placement
+ * @returns A tuple containing the vertical and horizontal placement directions
+ */
 export declare function calculatePlacement(target: HTMLElement, boundariesElement: HTMLElement, fitWidth?: number, fitHeight?: number, alignX?: string, alignY?: string, forcePlacement?: boolean, preventOverflow?: boolean): [string, string];
 /**
  * Calculates relative coordinates for placing popup along with the target.

package/dist/types-ts4.5/analytics/index.d.ts

@@ -59,4 +59,4 @@ export { type NcsSessionStepEventAEP, type NcsSessionStepMetrics, } from './type
 export type { BlockMenuEventPayload } from './types/block-menu-events';
 export type { BreakoutEventPayload, BreakoutSupportedNodes } from './types/breakout-events';
 export type { RendererSyncBlockEventPayload, SyncBlockEventPayload, SyncedBlockSSRErrorAEP, } from './types/sync-block-events';
-export type { AiSuggestionsEventPayload } from './types/ai-suggestions-events';
+export type { AiSuggestionsEntryPoint, AiSuggestionsEventPayload, } from './types/ai-suggestions-events';

package/dist/types-ts4.5/analytics/types/ai-suggestions-events.d.ts

@@ -1,5 +1,6 @@
 import type { ACTION, ACTION_SUBJECT } from './enums';
 import type { OperationalAEP, TrackAEP } from './utils';
+export type AiSuggestionsEntryPoint = 'primaryToolbar' | 'commentsEmptyState';
 type NoDiffSuggestionAEP = OperationalAEP<ACTION.NO_DIFF_FOUND, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
     suggestionType: string;
     toolCalls: {
@@ -8,6 +9,9 @@ type NoDiffSuggestionAEP = OperationalAEP<ACTION.NO_DIFF_FOUND, ACTION_SUBJECT.A
         nodeTypes: string[];
     }[];
 }>;
+type EntryPointClickedAEP = TrackAEP<ACTION.CLICKED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
+    entryPoint: AiSuggestionsEntryPoint;
+}, undefined>;
 type AcceptSuggestionAEP = TrackAEP<ACTION.ACCEPTED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
     affectedBlocks: number;
     charactersAdded: number;
@@ -16,6 +20,7 @@ type AcceptSuggestionAEP = TrackAEP<ACTION.ACCEPTED, ACTION_SUBJECT.AI_SUGGESTIO
     suggestionType: string;
 }, undefined>;
 type DiscardSuggestionAEP = TrackAEP<ACTION.DISCARDED, ACTION_SUBJECT.AI_SUGGESTIONS, undefined, {
+    affectedBlocks: number;
     entryPoint: 'sidebar' | 'card';
     suggestionType: string;
 }, undefined>;
@@ -28,5 +33,5 @@ type ViewSuggestionAEP = TrackAEP<ACTION.VIEWED, ACTION_SUBJECT.AI_SUGGESTIONS,
     suggestionCardCharacterCount: number;
     suggestionType: string;
 }, undefined>;
-export type AiSuggestionsEventPayload = NoDiffSuggestionAEP | AcceptSuggestionAEP | DiscardSuggestionAEP | ViewSuggestionAEP;
+export type AiSuggestionsEventPayload = NoDiffSuggestionAEP | EntryPointClickedAEP | AcceptSuggestionAEP | DiscardSuggestionAEP | ViewSuggestionAEP;
 export {};

package/dist/types-ts4.5/ui/Popup/utils.d.ts

@@ -15,18 +15,40 @@ export interface CalculatePositionParams {
     ];
     popup?: HTMLElement;
     rect?: DOMRect;
+    scrollableElement?: HTMLElement | false;
     stick?: boolean;
     target?: HTMLElement;
-    scrollableElement?: HTMLElement | false;
 }
 /**
+ * Determines the optimal vertical placement ('top' or 'bottom') for a popup relative to a target element.
  * Decides if given fitHeight fits below or above the target taking boundaries into account.
+ *
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitHeight - The desired height of the popup content
+ * @param alignY - Forced alignment direction ('top' or 'bottom')
+ * @param forcePlacement - Whether to force the placement to the alignY value
+ * @param preventOverflow - Whether to prevent overflow by forcing bottom placement when space above is insufficient
+ * @returns The optimal placement direction ('top' or 'bottom')
  */
 export declare function getVerticalPlacement(target: HTMLElement, boundariesElement: HTMLElement, fitHeight?: number, alignY?: string, forcePlacement?: boolean, preventOverflow?: boolean): string;
 /**
  * Decides if given fitWidth fits to the left or to the right of the target taking boundaries into account.
  */
 export declare function getHorizontalPlacement(target: HTMLElement, boundariesElement: HTMLElement, fitWidth?: number, alignX?: string, forcePlacement?: boolean, preventOverflow?: boolean): string;
+/**
+ * Calculates the optimal placement for a popup element in both vertical and horizontal directions.
+ *
+ * @param target - The target element to position the popup relative to
+ * @param boundariesElement - The boundaries element that constrains the popup positioning
+ * @param fitWidth - The desired width of the popup content
+ * @param fitHeight - The desired height of the popup content
+ * @param alignX - Forced horizontal alignment direction
+ * @param alignY - Forced vertical alignment direction
+ * @param forcePlacement - Whether to force the placement to the specified alignment values
+ * @param preventOverflow - Whether to prevent overflow by adjusting placement
+ * @returns A tuple containing the vertical and horizontal placement directions
+ */
 export declare function calculatePlacement(target: HTMLElement, boundariesElement: HTMLElement, fitWidth?: number, fitHeight?: number, alignX?: string, alignY?: string, forcePlacement?: boolean, preventOverflow?: boolean): [
     string,
     string

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "115.10.1",
+	"version": "115.12.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -43,7 +43,7 @@
 		"@atlaskit/analytics-listeners": "^10.1.0",
 		"@atlaskit/analytics-namespaced-context": "^7.3.0",
 		"@atlaskit/analytics-next": "^11.3.0",
-		"@atlaskit/atlassian-context": "^0.10.0",
+		"@atlaskit/atlassian-context": "^0.11.0",
 		"@atlaskit/browser-apis": "^0.0.2",
 		"@atlaskit/button": "^23.11.0",
 		"@atlaskit/codemod-utils": "^4.3.0",
@@ -81,13 +81,13 @@
 		"@atlaskit/prosemirror-history": "^0.2.0",
 		"@atlaskit/react-ufo": "^6.7.0",
 		"@atlaskit/section-message": "^8.13.0",
-		"@atlaskit/smart-card": "^44.26.0",
+		"@atlaskit/smart-card": "^44.28.0",
 		"@atlaskit/smart-user-picker": "^10.2.0",
 		"@atlaskit/spinner": "^19.1.0",
-		"@atlaskit/task-decision": "^20.1.0",
+		"@atlaskit/task-decision": "^20.2.0",
 		"@atlaskit/teams-app-config": "^1.12.0",
 		"@atlaskit/textfield": "^8.3.0",
-		"@atlaskit/tmp-editor-statsig": "^95.0.0",
+		"@atlaskit/tmp-editor-statsig": "^98.0.0",
 		"@atlaskit/tokens": "^13.3.0",
 		"@atlaskit/tooltip": "^22.6.0",
 		"@atlaskit/width-detector": "^5.1.0",
@@ -249,9 +249,6 @@
 		"ally_30205_accessibility_label_fix": {
 			"type": "boolean"
 		},
-		"platform_editor_ally_remove_role_tabpanel": {
-			"type": "boolean"
-		},
 		"platform_editor_native_anchor_patch_3": {
 			"type": "boolean"
 		},