@atlaskit/editor-common 114.43.0 → 114.44.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,13 @@
1
1
  # @atlaskit/editor-common
2
2
 
3
+ ## 114.44.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`3990f4a500c27`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3990f4a500c27) -
8
+ Fix RovoLinkPicker rendering off-screen by using correct dimensions for popup placement
9
+ calculations
10
+
3
11
  ## 114.43.0
4
12
 
5
13
  ### Minor Changes
@@ -7,12 +7,14 @@ Object.defineProperty(exports, "__esModule", {
7
7
  });
8
8
  exports.HyperlinkAddToolbar = HyperlinkAddToolbar;
9
9
  var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
10
+ var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
10
11
  var _react = _interopRequireWildcard(require("react"));
11
12
  var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
12
13
  var _analytics = require("../../../analytics");
13
14
  var _providerFactory = require("../../../provider-factory");
14
15
  var _EditorLinkPicker = require("../EditorLinkPicker");
15
16
  var _HyperlinkAddToolbar = _interopRequireDefault(require("./HyperlinkAddToolbar"));
17
+ var _excluded = ["popupWidth", "popupHeight"];
16
18
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
17
19
  var HYPERLINK_PROVIDERS = ['activityProvider', 'searchProvider'];
18
20
  /**
@@ -30,7 +32,10 @@ var onSubmitInterface = function onSubmitInterface(onSubmit) {
30
32
  };
31
33
  function HyperlinkAddToolbar(_ref2) {
32
34
  var _ref2$linkPickerOptio = _ref2.linkPickerOptions,
33
- linkPickerOptions = _ref2$linkPickerOptio === void 0 ? {} : _ref2$linkPickerOptio,
35
+ _ref2$linkPickerOptio2 = _ref2$linkPickerOptio === void 0 ? {} : _ref2$linkPickerOptio,
36
+ _popupWidth = _ref2$linkPickerOptio2.popupWidth,
37
+ _popupHeight = _ref2$linkPickerOptio2.popupHeight,
38
+ linkPickerOptions = (0, _objectWithoutProperties2.default)(_ref2$linkPickerOptio2, _excluded),
34
39
  onSubmit = _ref2.onSubmit,
35
40
  displayText = _ref2.displayText,
36
41
  displayUrl = _ref2.displayUrl,
@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
19
19
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
20
20
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
21
21
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
22
- var packageVersion = "114.42.0";
22
+ var packageVersion = "114.43.0";
23
23
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
24
24
  // Remove URL as it has UGC
25
25
  // Ignored via go/ees007
@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
24
24
  * @jsx jsx
25
25
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
26
26
  var packageName = "@atlaskit/editor-common";
27
- var packageVersion = "114.42.0";
27
+ var packageVersion = "114.43.0";
28
28
  var halfFocusRing = 1;
29
29
  var dropOffset = '0, 8';
30
30
  var fadeIn = (0, _react2.keyframes)({
@@ -3,8 +3,14 @@
3
3
  Object.defineProperty(exports, "__esModule", {
4
4
  value: true
5
5
  });
6
- exports.RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = exports.RECENT_SEARCH_WIDTH_IN_PX = exports.RECENT_SEARCH_HEIGHT_IN_PX = exports.LINKPICKER_HEIGHT_IN_PX = void 0;
6
+ exports.ROVO_LINK_PICKER_WIDTH_IN_PX = exports.ROVO_LINK_PICKER_HEIGHT_IN_PX = exports.RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = exports.RECENT_SEARCH_WIDTH_IN_PX = exports.RECENT_SEARCH_HEIGHT_IN_PX = exports.LINKPICKER_HEIGHT_IN_PX = void 0;
7
7
  var RECENT_SEARCH_WIDTH_IN_PX = exports.RECENT_SEARCH_WIDTH_IN_PX = 420;
8
8
  var RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = exports.RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = 360;
9
9
  var RECENT_SEARCH_HEIGHT_IN_PX = exports.RECENT_SEARCH_HEIGHT_IN_PX = 360;
10
- var LINKPICKER_HEIGHT_IN_PX = exports.LINKPICKER_HEIGHT_IN_PX = 570;
10
+ var LINKPICKER_HEIGHT_IN_PX = exports.LINKPICKER_HEIGHT_IN_PX = 570;
11
+
12
+ // Dimensions of RovoLinkPicker — used by the editor popup to prevent off-screen rendering.
13
+ // Note: These values are mirrored from @atlassian/rovo-link-picker. If you change these, update that package's constants file too:
14
+ // platform/packages/linking-platform/rovo-link-picker/src/constants/ROVO_LINK_PICKER_CONSTANTS.ts
15
+ var ROVO_LINK_PICKER_WIDTH_IN_PX = exports.ROVO_LINK_PICKER_WIDTH_IN_PX = 464;
16
+ var ROVO_LINK_PICKER_HEIGHT_IN_PX = exports.ROVO_LINK_PICKER_HEIGHT_IN_PX = 512;
@@ -19,7 +19,11 @@ const onSubmitInterface = onSubmit => ({
19
19
  onSubmit(url, title !== null && title !== void 0 ? title : rawUrl, displayText || undefined, meta.inputMethod === 'manual' ? INPUT_METHOD.MANUAL : INPUT_METHOD.TYPEAHEAD, analytic);
20
20
  };
21
21
  export function HyperlinkAddToolbar({
22
- linkPickerOptions = {},
22
+ linkPickerOptions: {
23
+ popupWidth: _popupWidth,
24
+ popupHeight: _popupHeight,
25
+ ...linkPickerOptions
26
+ } = {},
23
27
  onSubmit,
24
28
  displayText,
25
29
  displayUrl,
@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
4
4
  import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
5
5
  const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
6
6
  const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
7
- const packageVersion = "114.42.0";
7
+ const packageVersion = "114.43.0";
8
8
  const sanitiseSentryEvents = (data, _hint) => {
9
9
  // Remove URL as it has UGC
10
10
  // Ignored via go/ees007
@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
14
14
  import { fg } from '@atlaskit/platform-feature-flags';
15
15
  import Layer from '../Layer';
16
16
  const packageName = "@atlaskit/editor-common";
17
- const packageVersion = "114.42.0";
17
+ const packageVersion = "114.43.0";
18
18
  const halfFocusRing = 1;
19
19
  const dropOffset = '0, 8';
20
20
  const fadeIn = keyframes({
@@ -1,4 +1,10 @@
1
1
  export const RECENT_SEARCH_WIDTH_IN_PX = 420;
2
2
  export const RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = 360;
3
3
  export const RECENT_SEARCH_HEIGHT_IN_PX = 360;
4
- export const LINKPICKER_HEIGHT_IN_PX = 570;
4
+ export const LINKPICKER_HEIGHT_IN_PX = 570;
5
+
6
+ // Dimensions of RovoLinkPicker — used by the editor popup to prevent off-screen rendering.
7
+ // Note: These values are mirrored from @atlassian/rovo-link-picker. If you change these, update that package's constants file too:
8
+ // platform/packages/linking-platform/rovo-link-picker/src/constants/ROVO_LINK_PICKER_CONSTANTS.ts
9
+ export const ROVO_LINK_PICKER_WIDTH_IN_PX = 464;
10
+ export const ROVO_LINK_PICKER_HEIGHT_IN_PX = 512;
@@ -1,4 +1,6 @@
1
1
  import _extends from "@babel/runtime/helpers/extends";
2
+ import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
3
+ var _excluded = ["popupWidth", "popupHeight"];
2
4
  import React, { useCallback, useMemo } from 'react';
3
5
  import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
4
6
  import { INPUT_METHOD } from '../../../analytics';
@@ -21,7 +23,10 @@ var onSubmitInterface = function onSubmitInterface(onSubmit) {
21
23
  };
22
24
  export function HyperlinkAddToolbar(_ref2) {
23
25
  var _ref2$linkPickerOptio = _ref2.linkPickerOptions,
24
- linkPickerOptions = _ref2$linkPickerOptio === void 0 ? {} : _ref2$linkPickerOptio,
26
+ _ref2$linkPickerOptio2 = _ref2$linkPickerOptio === void 0 ? {} : _ref2$linkPickerOptio,
27
+ _popupWidth = _ref2$linkPickerOptio2.popupWidth,
28
+ _popupHeight = _ref2$linkPickerOptio2.popupHeight,
29
+ linkPickerOptions = _objectWithoutProperties(_ref2$linkPickerOptio2, _excluded),
25
30
  onSubmit = _ref2.onSubmit,
26
31
  displayText = _ref2.displayText,
27
32
  displayUrl = _ref2.displayUrl,
@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
10
10
  import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
11
11
  var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
12
12
  var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
13
- var packageVersion = "114.42.0";
13
+ var packageVersion = "114.43.0";
14
14
  var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
15
15
  // Remove URL as it has UGC
16
16
  // Ignored via go/ees007
@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
21
21
  import { fg } from '@atlaskit/platform-feature-flags';
22
22
  import Layer from '../Layer';
23
23
  var packageName = "@atlaskit/editor-common";
24
- var packageVersion = "114.42.0";
24
+ var packageVersion = "114.43.0";
25
25
  var halfFocusRing = 1;
26
26
  var dropOffset = '0, 8';
27
27
  var fadeIn = keyframes({
@@ -1,4 +1,10 @@
1
1
  export var RECENT_SEARCH_WIDTH_IN_PX = 420;
2
2
  export var RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = 360;
3
3
  export var RECENT_SEARCH_HEIGHT_IN_PX = 360;
4
- export var LINKPICKER_HEIGHT_IN_PX = 570;
4
+ export var LINKPICKER_HEIGHT_IN_PX = 570;
5
+
6
+ // Dimensions of RovoLinkPicker — used by the editor popup to prevent off-screen rendering.
7
+ // Note: These values are mirrored from @atlassian/rovo-link-picker. If you change these, update that package's constants file too:
8
+ // platform/packages/linking-platform/rovo-link-picker/src/constants/ROVO_LINK_PICKER_CONSTANTS.ts
9
+ export var ROVO_LINK_PICKER_WIDTH_IN_PX = 464;
10
+ export var ROVO_LINK_PICKER_HEIGHT_IN_PX = 512;
@@ -22,4 +22,4 @@ export interface HyperlinkAddToolbarProps extends Pick<EditorLinkPickerProps, 'o
22
22
  timesViewed?: number;
23
23
  view: EditorView;
24
24
  }
25
- export declare function HyperlinkAddToolbar({ linkPickerOptions, onSubmit, displayText, displayUrl, providerFactory, view, onCancel, invokeMethod, lpLinkPicker, onClose, onEscapeCallback, onClickAwayCallback, editorAppearance, inputMethod, searchSessionId, timesViewed, isOffline, }: HyperlinkAddToolbarProps): React.JSX.Element;
25
+ export declare function HyperlinkAddToolbar({ linkPickerOptions: { popupWidth: _popupWidth, popupHeight: _popupHeight, ...linkPickerOptions }, onSubmit, displayText, displayUrl, providerFactory, view, onCancel, invokeMethod, lpLinkPicker, onClose, onEscapeCallback, onClickAwayCallback, editorAppearance, inputMethod, searchSessionId, timesViewed, isOffline, }: HyperlinkAddToolbarProps): React.JSX.Element;
@@ -5,9 +5,14 @@ import type { EditorAppearance } from './editor-appearance';
5
5
  export type LinkInputType = INPUT_METHOD.MANUAL | INPUT_METHOD.TYPEAHEAD;
6
6
  /**
7
7
  * Configuration for the link picker
8
- * Extends `LinkPickerProps` to provide future extensibility out-of-the-box
8
+ * Extends `LinkPickerProps` to provide future extensibility out-of-the-box.
9
+ * Use `popupWidth` and `popupHeight` to control the editor popup container size
10
+ * when providing a custom `component` with non-standard dimensions.
9
11
  */
10
- export type LinkPickerOptions = Partial<LinkPickerProps>;
12
+ export type LinkPickerOptions = Partial<LinkPickerProps> & {
13
+ popupHeight?: number;
14
+ popupWidth?: number;
15
+ };
11
16
  /**
12
17
  * Configuration for editor linking behaviours
13
18
  */
@@ -2,3 +2,5 @@ export declare const RECENT_SEARCH_WIDTH_IN_PX = 420;
2
2
  export declare const RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = 360;
3
3
  export declare const RECENT_SEARCH_HEIGHT_IN_PX = 360;
4
4
  export declare const LINKPICKER_HEIGHT_IN_PX = 570;
5
+ export declare const ROVO_LINK_PICKER_WIDTH_IN_PX = 464;
6
+ export declare const ROVO_LINK_PICKER_HEIGHT_IN_PX = 512;
@@ -22,4 +22,4 @@ export interface HyperlinkAddToolbarProps extends Pick<EditorLinkPickerProps, 'o
22
22
  timesViewed?: number;
23
23
  view: EditorView;
24
24
  }
25
- export declare function HyperlinkAddToolbar({ linkPickerOptions, onSubmit, displayText, displayUrl, providerFactory, view, onCancel, invokeMethod, lpLinkPicker, onClose, onEscapeCallback, onClickAwayCallback, editorAppearance, inputMethod, searchSessionId, timesViewed, isOffline, }: HyperlinkAddToolbarProps): React.JSX.Element;
25
+ export declare function HyperlinkAddToolbar({ linkPickerOptions: { popupWidth: _popupWidth, popupHeight: _popupHeight, ...linkPickerOptions }, onSubmit, displayText, displayUrl, providerFactory, view, onCancel, invokeMethod, lpLinkPicker, onClose, onEscapeCallback, onClickAwayCallback, editorAppearance, inputMethod, searchSessionId, timesViewed, isOffline, }: HyperlinkAddToolbarProps): React.JSX.Element;
@@ -5,9 +5,14 @@ import type { EditorAppearance } from './editor-appearance';
5
5
  export type LinkInputType = INPUT_METHOD.MANUAL | INPUT_METHOD.TYPEAHEAD;
6
6
  /**
7
7
  * Configuration for the link picker
8
- * Extends `LinkPickerProps` to provide future extensibility out-of-the-box
8
+ * Extends `LinkPickerProps` to provide future extensibility out-of-the-box.
9
+ * Use `popupWidth` and `popupHeight` to control the editor popup container size
10
+ * when providing a custom `component` with non-standard dimensions.
9
11
  */
10
- export type LinkPickerOptions = Partial<LinkPickerProps>;
12
+ export type LinkPickerOptions = Partial<LinkPickerProps> & {
13
+ popupHeight?: number;
14
+ popupWidth?: number;
15
+ };
11
16
  /**
12
17
  * Configuration for editor linking behaviours
13
18
  */
@@ -2,3 +2,5 @@ export declare const RECENT_SEARCH_WIDTH_IN_PX = 420;
2
2
  export declare const RECENT_SEARCH_WIDTH_WITHOUT_ITEMS_IN_PX = 360;
3
3
  export declare const RECENT_SEARCH_HEIGHT_IN_PX = 360;
4
4
  export declare const LINKPICKER_HEIGHT_IN_PX = 570;
5
+ export declare const ROVO_LINK_PICKER_WIDTH_IN_PX = 464;
6
+ export declare const ROVO_LINK_PICKER_HEIGHT_IN_PX = 512;
@@ -0,0 +1,17 @@
1
+ {
2
+ "name": "@atlaskit/editor-common/link-search-constants",
3
+ "main": "../dist/cjs/ui/LinkSearch/const.js",
4
+ "module": "../dist/esm/ui/LinkSearch/const.js",
5
+ "module:es2019": "../dist/es2019/ui/LinkSearch/const.js",
6
+ "sideEffects": [
7
+ "**/*.compiled.css"
8
+ ],
9
+ "types": "../dist/types/ui/LinkSearch/const.d.ts",
10
+ "typesVersions": {
11
+ ">=4.5 <5.9": {
12
+ "*": [
13
+ "../dist/types-ts4.5/ui/LinkSearch/const.d.ts"
14
+ ]
15
+ }
16
+ }
17
+ }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-common",
3
- "version": "114.43.0",
3
+ "version": "114.44.0",
4
4
  "description": "A package that contains common classes and components for editor and renderer",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"