@atlaskit/editor-common 114.3.1 → 114.4.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/editor-common
 
+## 114.4.0
+
+### Minor Changes
+
+- [`2958c4c1d01b8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2958c4c1d01b8) -
+  Perf-linting cleanup: fix performance linting violations in editor-common, gated behind
+  platform_editor_perf_lint_cleanup experiment
+
+### Patch Changes
+
+- [`0242b2a3c1ab9`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0242b2a3c1ab9) -
+  Clean up platform_editor_link_popup_position_fix_aifc feature flag (shipped as true).
+
 ## 114.3.1
 
 ### Patch Changes

package/dist/cjs/media-inline/inline-image-card.js

@@ -9,6 +9,7 @@ var _react2 = require("@emotion/react");
 var _mediaCommon = require("@atlaskit/media-common");
 var _mediaFilePreview = require("@atlaskit/media-file-preview");
 var _mediaUi = require("@atlaskit/media-ui");
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _loadingView = require("./views/loading-view");
 /**
  * @jsxRuntime classic
@@ -45,9 +46,12 @@ var InlineImageCard = exports.InlineImageCard = function InlineImageCard(_ref) {
     preview = _useFilePreview.preview,
     previewError = _useFilePreview.error,
     onImageError = _useFilePreview.onImageError,
-    _onImageLoad = _useFilePreview.onImageLoad,
+    onImageLoad = _useFilePreview.onImageLoad,
     getSsrScriptProps = _useFilePreview.getSsrScriptProps,
     copyNodeRef = _useFilePreview.copyNodeRef;
+  var memoizedOnImageLoad = (0, _react.useCallback)(function () {
+    onImageLoad(preview);
+  }, [onImageLoad, preview]);
   if (previewError) {
     return renderError({
       error: previewError
@@ -59,11 +63,9 @@ var InlineImageCard = exports.InlineImageCard = function InlineImageCard(_ref) {
   return (0, _react2.jsx)(_react.Fragment, null, (0, _react2.jsx)(_mediaUi.MediaImage, {
     dataURI: preview.dataURI,
     alt: alt,
-    previewOrientation: preview.orientation
-    // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-    ,
-    onImageLoad: function onImageLoad() {
-      _onImageLoad(preview);
+    previewOrientation: preview.orientation,
+    onImageLoad: (0, _expValEquals.expValEquals)('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedOnImageLoad : function () {
+      onImageLoad(preview);
     },
     onImageError: onImageError,
     loading: isLazy ? 'lazy' : undefined,

package/dist/cjs/media-inline/media-inline-image-card.js

@@ -16,6 +16,7 @@ var _mediaCard = require("@atlaskit/media-card");
 var _mediaClient = require("@atlaskit/media-client");
 var _mediaClientReact = require("@atlaskit/media-client-react");
 var _mediaViewer = require("@atlaskit/media-viewer");
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _mediaInlineCard = require("../messages/media-inline-card");
 var _constants = require("./constants");
@@ -100,6 +101,11 @@ var MediaInlineImageCardInternal = exports.MediaInlineImageCardInternal = functi
       };
     }
   }, [identifier, mediaClient]);
+  var memoizedRenderError = (0, _react.useCallback)(function () {
+    return (0, _react2.jsx)(_errorView.InlineImageCardErrorView, {
+      message: formatMessage(_mediaInlineCard.messages.unableToLoadContent)
+    });
+  }, [formatMessage]);
   var content = function content(dimensions) {
     if (!mediaClient) {
       return (0, _react2.jsx)(_loadingView.InlineImageCardLoadingView, null);
@@ -143,10 +149,10 @@ var MediaInlineImageCardInternal = exports.MediaInlineImageCardInternal = functi
       value: mediaClient
     }, (0, _react2.jsx)(_inlineImageCard.InlineImageCard, {
       dimensions: dimensions,
-      identifier: identifier
-      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      ,
-      renderError: function renderError() {
+      identifier: identifier,
+      renderError: (0, _expValEquals.expValEquals)('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedRenderError :
+      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+      function () {
         return (0, _react2.jsx)(_errorView.InlineImageCardErrorView, {
           message: formatMessage(_mediaInlineCard.messages.unableToLoadContent)
         });
@@ -213,20 +219,23 @@ var MediaInlineImageCardInternal = exports.MediaInlineImageCardInternal = functi
   var onMediaInlinePreviewClose = (0, _react.useCallback)(function () {
     setMediaViewerVisible(false);
   }, []);
+  var memoizedMediaViewerItems = (0, _react.useMemo)(function () {
+    return [identifier];
+  }, [identifier]);
   var mediaViewer = (0, _react.useMemo)(function () {
     if (isMediaViewerVisible && mediaClient !== null && mediaClient !== void 0 && mediaClient.mediaClientConfig) {
       return /*#__PURE__*/_reactDom.default.createPortal((0, _react2.jsx)(_mediaViewer.MediaViewer, {
-        collectionName: identifier.collectionName || ''
-        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-        ,
-        items: [identifier],
+        collectionName: identifier.collectionName || '',
+        items: (0, _expValEquals.expValEquals)('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedMediaViewerItems :
+        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+        [identifier],
         mediaClientConfig: mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig,
         selectedItem: identifier,
         onClose: onMediaInlinePreviewClose
       }), document.body);
     }
     return null;
-  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose]);
+  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose, memoizedMediaViewerItems]);
   return (0, _react2.jsx)(_react.Fragment, null, (0, _react2.jsx)(_inlineImageWrapper.InlineImageWrapper, {
     isSelected: isSelected,
     aspectRatio: aspectRatio,

package/dist/cjs/media-single/CommentBadge.js

@@ -12,6 +12,7 @@ var _debounce = _interopRequireDefault(require("lodash/debounce"));
 var _customThemeButton = _interopRequireDefault(require("@atlaskit/button/custom-theme-button"));
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
 var _comment = _interopRequireDefault(require("@atlaskit/icon/core/comment"));
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
 var _media = require("../media");
 /**
@@ -85,6 +86,24 @@ var CommentBadge = exports.CommentBadge = /*#__PURE__*/(0, _react.forwardRef)(fu
         return "var(--ds-background-accent-yellow-subtlest, #FEF7C8)";
     }
   }, [status]);
+  var memoizedBadgeStyle = (0, _react.useMemo)(function () {
+    return {
+      height: badgeDimensions,
+      width: badgeDimensions,
+      background: colourToken,
+      display: 'flex',
+      justifyContent: 'center',
+      alignItems: 'center'
+    };
+  }, [badgeDimensions, colourToken]);
+  var badgeStyle = (0, _expValEquals.expValEquals)('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedBadgeStyle : {
+    height: badgeDimensions,
+    width: badgeDimensions,
+    background: colourToken,
+    display: 'flex',
+    justifyContent: 'center',
+    alignItems: 'center'
+  };
   return (0, _react2.jsx)("div", {
     ref: ref,
     css: badgeOffsetRight ? [commentBadgeWrapper,
@@ -98,21 +117,9 @@ var CommentBadge = exports.CommentBadge = /*#__PURE__*/(0, _react.forwardRef)(fu
     position: "top",
     content: title
   }, (0, _react2.jsx)(_customThemeButton.default
-  // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
   , {
-    style: {
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      height: badgeDimensions,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      width: badgeDimensions,
-      background: colourToken,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      display: 'flex',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      justifyContent: 'center',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      alignItems: 'center'
-    },
+    style: badgeStyle,
     onClick: onClick,
     onMouseEnter: onMouseEnter,
     onMouseLeave: onMouseLeave,

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "114.3.0";
+var packageVersion = "114.3.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "114.3.0";
+var packageVersion = "114.3.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/ui/Popup/index.js

@@ -118,7 +118,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
         offset: offset,
         allowOutOfBounds: allowOutOfBounds,
         rect: rect,
-        boundariesElement: (0, _platformFeatureFlags.fg)('platform_editor_link_popup_position_fix_aifc') ? boundariesElement || document.body : undefined,
+        boundariesElement: boundariesElement || document.body,
         minPopupMargin: minPopupMargin
       });
       position = onPositionCalculated ? onPositionCalculated(position) : position;
@@ -182,7 +182,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "initPopup",
     value: function initPopup(popup) {
-      if (this.popupRef.current && (0, _platformFeatureFlags.fg)('platform_editor_link_popup_position_fix_aifc')) {
+      if (this.popupRef.current) {
         var _this$resizeObserver;
         (_this$resizeObserver = this.resizeObserver) === null || _this$resizeObserver === void 0 || _this$resizeObserver.unobserve(this.popupRef.current);
       }
@@ -210,7 +210,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
       if (this.props.focusTrap) {
         this.initFocusTrap();
       }
-      if (this.popupRef.current && (0, _platformFeatureFlags.fg)('platform_editor_link_popup_position_fix_aifc')) {
+      if (this.popupRef.current) {
         var _this$resizeObserver2;
         (_this$resizeObserver2 = this.resizeObserver) === null || _this$resizeObserver2 === void 0 || _this$resizeObserver2.observe(this.popupRef.current);
       }
@@ -286,6 +286,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
+      var _this$resizeObserver3;
       // Ignored via go/ees005
       // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
       window.removeEventListener('resize', this.onResize);
@@ -294,14 +295,7 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
         this.scrollElement.removeEventListener('scroll', this.onResize);
       }
-      if ((0, _platformFeatureFlags.fg)('platform_editor_link_popup_position_fix_aifc')) {
-        var _this$resizeObserver3;
-        (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 || _this$resizeObserver3.disconnect();
-      } else {
-        if (this.scrollParentElement && this.resizeObserver) {
-          this.resizeObserver.unobserve(this.scrollParentElement);
-        }
-      }
+      (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 || _this$resizeObserver3.disconnect();
       this.scheduledUpdatePosition.cancel();
       this.destroyFocusTrap();
       var onUnmount = this.props.onUnmount;

package/dist/es2019/media-inline/inline-image-card.js

@@ -2,13 +2,14 @@
  * @jsxRuntime classic
  * @jsx jsx
  */
-import { Fragment, useMemo } from 'react';
+import { Fragment, useCallback, useMemo } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { jsx } from '@emotion/react';
 import { getRandomHex } from '@atlaskit/media-common';
 import { useFilePreview } from '@atlaskit/media-file-preview';
 import { MediaImage } from '@atlaskit/media-ui';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { InlineImageCardLoadingView } from './views/loading-view';
 export const InlineImageCard = ({
   dimensions,
@@ -41,6 +42,9 @@ export const InlineImageCard = ({
     dimensions,
     traceContext
   });
+  const memoizedOnImageLoad = useCallback(() => {
+    onImageLoad(preview);
+  }, [onImageLoad, preview]);
   if (previewError) {
     return renderError({
       error: previewError
@@ -52,10 +56,8 @@ export const InlineImageCard = ({
   return jsx(Fragment, null, jsx(MediaImage, {
     dataURI: preview.dataURI,
     alt: alt,
-    previewOrientation: preview.orientation
-    // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-    ,
-    onImageLoad: () => {
+    previewOrientation: preview.orientation,
+    onImageLoad: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedOnImageLoad : () => {
       onImageLoad(preview);
     },
     onImageError: onImageError,

package/dist/es2019/media-inline/media-inline-image-card.js

@@ -13,6 +13,7 @@ import { fireFailedMediaInlineEvent, fireSucceededMediaInlineEvent, MediaCardErr
 import { FileFetcherError } from '@atlaskit/media-client';
 import { MediaClientContext } from '@atlaskit/media-client-react';
 import { MediaViewer } from '@atlaskit/media-viewer';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { messages } from '../messages/media-inline-card';
 import { referenceHeights } from './constants';
@@ -78,6 +79,9 @@ export const MediaInlineImageCardInternal = ({
       };
     }
   }, [identifier, mediaClient]);
+  const memoizedRenderError = useCallback(() => jsx(InlineImageCardErrorView, {
+    message: formatMessage(messages.unableToLoadContent)
+  }), [formatMessage]);
   const content = dimensions => {
     if (!mediaClient) {
       return jsx(InlineImageCardLoadingView, null);
@@ -121,10 +125,10 @@ export const MediaInlineImageCardInternal = ({
       value: mediaClient
     }, jsx(InlineImageCard, {
       dimensions: dimensions,
-      identifier: identifier
-      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      ,
-      renderError: () => jsx(InlineImageCardErrorView, {
+      identifier: identifier,
+      renderError: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedRenderError :
+      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+      () => jsx(InlineImageCardErrorView, {
         message: formatMessage(messages.unableToLoadContent)
       }),
       alt: alt,
@@ -188,20 +192,21 @@ export const MediaInlineImageCardInternal = ({
   const onMediaInlinePreviewClose = useCallback(() => {
     setMediaViewerVisible(false);
   }, []);
+  const memoizedMediaViewerItems = useMemo(() => [identifier], [identifier]);
   const mediaViewer = useMemo(() => {
     if (isMediaViewerVisible && mediaClient !== null && mediaClient !== void 0 && mediaClient.mediaClientConfig) {
       return /*#__PURE__*/ReactDOM.createPortal(jsx(MediaViewer, {
-        collectionName: identifier.collectionName || ''
-        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-        ,
-        items: [identifier],
+        collectionName: identifier.collectionName || '',
+        items: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedMediaViewerItems :
+        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+        [identifier],
         mediaClientConfig: mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig,
         selectedItem: identifier,
         onClose: onMediaInlinePreviewClose
       }), document.body);
     }
     return null;
-  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose]);
+  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose, memoizedMediaViewerItems]);
   return jsx(Fragment, null, jsx(InlineImageWrapper, {
     isSelected: isSelected,
     aspectRatio: aspectRatio,

package/dist/es2019/media-single/CommentBadge.js

@@ -9,6 +9,7 @@ import debounce from 'lodash/debounce';
 import CustomThemeButton from '@atlaskit/button/custom-theme-button';
 import { akEditorUnitZIndex } from '@atlaskit/editor-shared-styles';
 import CommentIcon from '@atlaskit/icon/core/comment';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import Tooltip from '@atlaskit/tooltip';
 import { commentMessages as messages } from '../media';
 const commentBadgeWrapper = css({
@@ -70,6 +71,22 @@ export const CommentBadge = /*#__PURE__*/forwardRef(({
         return "var(--ds-background-accent-yellow-subtlest, #FEF7C8)";
     }
   }, [status]);
+  const memoizedBadgeStyle = useMemo(() => ({
+    height: badgeDimensions,
+    width: badgeDimensions,
+    background: colourToken,
+    display: 'flex',
+    justifyContent: 'center',
+    alignItems: 'center'
+  }), [badgeDimensions, colourToken]);
+  const badgeStyle = expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedBadgeStyle : {
+    height: badgeDimensions,
+    width: badgeDimensions,
+    background: colourToken,
+    display: 'flex',
+    justifyContent: 'center',
+    alignItems: 'center'
+  };
   return jsx("div", {
     ref: ref,
     css: badgeOffsetRight ? [commentBadgeWrapper,
@@ -83,21 +100,9 @@ export const CommentBadge = /*#__PURE__*/forwardRef(({
     position: "top",
     content: title
   }, jsx(CustomThemeButton
-  // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
   , {
-    style: {
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      height: badgeDimensions,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      width: badgeDimensions,
-      background: colourToken,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      display: 'flex',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      justifyContent: 'center',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      alignItems: 'center'
-    },
+    style: badgeStyle,
     onClick: onClick,
     onMouseEnter: onMouseEnter,
     onMouseLeave: onMouseLeave,

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "114.3.0";
+const packageVersion = "114.3.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "114.3.0";
+const packageVersion = "114.3.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/ui/Popup/index.js

@@ -95,7 +95,7 @@ export default class Popup extends React.Component {
       offset: offset,
       allowOutOfBounds,
       rect,
-      boundariesElement: fg('platform_editor_link_popup_position_fix_aifc') ? boundariesElement || document.body : undefined,
+      boundariesElement: boundariesElement || document.body,
       minPopupMargin
     });
     position = onPositionCalculated ? onPositionCalculated(position) : position;
@@ -153,7 +153,7 @@ export default class Popup extends React.Component {
    * Checks whether it's possible to position popup along given target, and if it's not throws an error.
    */
   initPopup(popup) {
-    if (this.popupRef.current && fg('platform_editor_link_popup_position_fix_aifc')) {
+    if (this.popupRef.current) {
       var _this$resizeObserver;
       (_this$resizeObserver = this.resizeObserver) === null || _this$resizeObserver === void 0 ? void 0 : _this$resizeObserver.unobserve(this.popupRef.current);
     }
@@ -183,7 +183,7 @@ export default class Popup extends React.Component {
     if (this.props.focusTrap) {
       this.initFocusTrap();
     }
-    if (this.popupRef.current && fg('platform_editor_link_popup_position_fix_aifc')) {
+    if (this.popupRef.current) {
       var _this$resizeObserver2;
       (_this$resizeObserver2 = this.resizeObserver) === null || _this$resizeObserver2 === void 0 ? void 0 : _this$resizeObserver2.observe(this.popupRef.current);
     }
@@ -250,6 +250,7 @@ export default class Popup extends React.Component {
     }
   }
   componentWillUnmount() {
+    var _this$resizeObserver3;
     // Ignored via go/ees005
     // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
     window.removeEventListener('resize', this.onResize);
@@ -258,14 +259,7 @@ export default class Popup extends React.Component {
       // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
       this.scrollElement.removeEventListener('scroll', this.onResize);
     }
-    if (fg('platform_editor_link_popup_position_fix_aifc')) {
-      var _this$resizeObserver3;
-      (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 ? void 0 : _this$resizeObserver3.disconnect();
-    } else {
-      if (this.scrollParentElement && this.resizeObserver) {
-        this.resizeObserver.unobserve(this.scrollParentElement);
-      }
-    }
+    (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 ? void 0 : _this$resizeObserver3.disconnect();
     this.scheduledUpdatePosition.cancel();
     this.destroyFocusTrap();
     const {

package/dist/esm/media-inline/inline-image-card.js

@@ -2,13 +2,14 @@
  * @jsxRuntime classic
  * @jsx jsx
  */
-import { Fragment, useMemo } from 'react';
+import { Fragment, useCallback, useMemo } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { jsx } from '@emotion/react';
 import { getRandomHex } from '@atlaskit/media-common';
 import { useFilePreview } from '@atlaskit/media-file-preview';
 import { MediaImage } from '@atlaskit/media-ui';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { InlineImageCardLoadingView } from './views/loading-view';
 export var InlineImageCard = function InlineImageCard(_ref) {
   var dimensions = _ref.dimensions,
@@ -38,9 +39,12 @@ export var InlineImageCard = function InlineImageCard(_ref) {
     preview = _useFilePreview.preview,
     previewError = _useFilePreview.error,
     onImageError = _useFilePreview.onImageError,
-    _onImageLoad = _useFilePreview.onImageLoad,
+    onImageLoad = _useFilePreview.onImageLoad,
     getSsrScriptProps = _useFilePreview.getSsrScriptProps,
     copyNodeRef = _useFilePreview.copyNodeRef;
+  var memoizedOnImageLoad = useCallback(function () {
+    onImageLoad(preview);
+  }, [onImageLoad, preview]);
   if (previewError) {
     return renderError({
       error: previewError
@@ -52,11 +56,9 @@ export var InlineImageCard = function InlineImageCard(_ref) {
   return jsx(Fragment, null, jsx(MediaImage, {
     dataURI: preview.dataURI,
     alt: alt,
-    previewOrientation: preview.orientation
-    // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-    ,
-    onImageLoad: function onImageLoad() {
-      _onImageLoad(preview);
+    previewOrientation: preview.orientation,
+    onImageLoad: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedOnImageLoad : function () {
+      onImageLoad(preview);
     },
     onImageError: onImageError,
     loading: isLazy ? 'lazy' : undefined,

package/dist/esm/media-inline/media-inline-image-card.js

@@ -17,6 +17,7 @@ import { fireFailedMediaInlineEvent, fireSucceededMediaInlineEvent, MediaCardErr
 import { FileFetcherError } from '@atlaskit/media-client';
 import { MediaClientContext } from '@atlaskit/media-client-react';
 import { MediaViewer } from '@atlaskit/media-viewer';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { messages } from '../messages/media-inline-card';
 import { referenceHeights } from './constants';
@@ -96,6 +97,11 @@ export var MediaInlineImageCardInternal = function MediaInlineImageCardInternal(
       };
     }
   }, [identifier, mediaClient]);
+  var memoizedRenderError = useCallback(function () {
+    return jsx(InlineImageCardErrorView, {
+      message: formatMessage(messages.unableToLoadContent)
+    });
+  }, [formatMessage]);
   var content = function content(dimensions) {
     if (!mediaClient) {
       return jsx(InlineImageCardLoadingView, null);
@@ -139,10 +145,10 @@ export var MediaInlineImageCardInternal = function MediaInlineImageCardInternal(
       value: mediaClient
     }, jsx(InlineImageCard, {
       dimensions: dimensions,
-      identifier: identifier
-      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      ,
-      renderError: function renderError() {
+      identifier: identifier,
+      renderError: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedRenderError :
+      // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+      function () {
         return jsx(InlineImageCardErrorView, {
           message: formatMessage(messages.unableToLoadContent)
         });
@@ -209,20 +215,23 @@ export var MediaInlineImageCardInternal = function MediaInlineImageCardInternal(
   var onMediaInlinePreviewClose = useCallback(function () {
     setMediaViewerVisible(false);
   }, []);
+  var memoizedMediaViewerItems = useMemo(function () {
+    return [identifier];
+  }, [identifier]);
   var mediaViewer = useMemo(function () {
     if (isMediaViewerVisible && mediaClient !== null && mediaClient !== void 0 && mediaClient.mediaClientConfig) {
       return /*#__PURE__*/ReactDOM.createPortal(jsx(MediaViewer, {
-        collectionName: identifier.collectionName || ''
-        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-        ,
-        items: [identifier],
+        collectionName: identifier.collectionName || '',
+        items: expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedMediaViewerItems :
+        // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- intentional fallback for experiment off path
+        [identifier],
         mediaClientConfig: mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig,
         selectedItem: identifier,
         onClose: onMediaInlinePreviewClose
       }), document.body);
     }
     return null;
-  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose]);
+  }, [identifier, isMediaViewerVisible, mediaClient === null || mediaClient === void 0 ? void 0 : mediaClient.mediaClientConfig, onMediaInlinePreviewClose, memoizedMediaViewerItems]);
   return jsx(Fragment, null, jsx(InlineImageWrapper, {
     isSelected: isSelected,
     aspectRatio: aspectRatio,

package/dist/esm/media-single/CommentBadge.js

@@ -10,6 +10,7 @@ import debounce from 'lodash/debounce';
 import CustomThemeButton from '@atlaskit/button/custom-theme-button';
 import { akEditorUnitZIndex } from '@atlaskit/editor-shared-styles';
 import CommentIcon from '@atlaskit/icon/core/comment';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import Tooltip from '@atlaskit/tooltip';
 import { commentMessages as messages } from '../media';
 var commentBadgeWrapper = css({
@@ -76,6 +77,24 @@ export var CommentBadge = /*#__PURE__*/forwardRef(function (_ref, ref) {
         return "var(--ds-background-accent-yellow-subtlest, #FEF7C8)";
     }
   }, [status]);
+  var memoizedBadgeStyle = useMemo(function () {
+    return {
+      height: badgeDimensions,
+      width: badgeDimensions,
+      background: colourToken,
+      display: 'flex',
+      justifyContent: 'center',
+      alignItems: 'center'
+    };
+  }, [badgeDimensions, colourToken]);
+  var badgeStyle = expValEquals('platform_editor_perf_lint_cleanup', 'isEnabled', true) ? memoizedBadgeStyle : {
+    height: badgeDimensions,
+    width: badgeDimensions,
+    background: colourToken,
+    display: 'flex',
+    justifyContent: 'center',
+    alignItems: 'center'
+  };
   return jsx("div", {
     ref: ref,
     css: badgeOffsetRight ? [commentBadgeWrapper,
@@ -89,21 +108,9 @@ export var CommentBadge = /*#__PURE__*/forwardRef(function (_ref, ref) {
     position: "top",
     content: title
   }, jsx(CustomThemeButton
-  // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
   , {
-    style: {
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      height: badgeDimensions,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      width: badgeDimensions,
-      background: colourToken,
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      display: 'flex',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      justifyContent: 'center',
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-      alignItems: 'center'
-    },
+    style: badgeStyle,
     onClick: onClick,
     onMouseEnter: onMouseEnter,
     onMouseLeave: onMouseLeave,

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "114.3.0";
+var packageVersion = "114.3.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "114.3.0";
+var packageVersion = "114.3.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/ui/Popup/index.js

@@ -111,7 +111,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
         offset: offset,
         allowOutOfBounds: allowOutOfBounds,
         rect: rect,
-        boundariesElement: fg('platform_editor_link_popup_position_fix_aifc') ? boundariesElement || document.body : undefined,
+        boundariesElement: boundariesElement || document.body,
         minPopupMargin: minPopupMargin
       });
       position = onPositionCalculated ? onPositionCalculated(position) : position;
@@ -175,7 +175,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "initPopup",
     value: function initPopup(popup) {
-      if (this.popupRef.current && fg('platform_editor_link_popup_position_fix_aifc')) {
+      if (this.popupRef.current) {
         var _this$resizeObserver;
         (_this$resizeObserver = this.resizeObserver) === null || _this$resizeObserver === void 0 || _this$resizeObserver.unobserve(this.popupRef.current);
       }
@@ -203,7 +203,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
       if (this.props.focusTrap) {
         this.initFocusTrap();
       }
-      if (this.popupRef.current && fg('platform_editor_link_popup_position_fix_aifc')) {
+      if (this.popupRef.current) {
         var _this$resizeObserver2;
         (_this$resizeObserver2 = this.resizeObserver) === null || _this$resizeObserver2 === void 0 || _this$resizeObserver2.observe(this.popupRef.current);
       }
@@ -279,6 +279,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
+      var _this$resizeObserver3;
       // Ignored via go/ees005
       // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
       window.removeEventListener('resize', this.onResize);
@@ -287,14 +288,7 @@ var Popup = /*#__PURE__*/function (_React$Component) {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
         this.scrollElement.removeEventListener('scroll', this.onResize);
       }
-      if (fg('platform_editor_link_popup_position_fix_aifc')) {
-        var _this$resizeObserver3;
-        (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 || _this$resizeObserver3.disconnect();
-      } else {
-        if (this.scrollParentElement && this.resizeObserver) {
-          this.resizeObserver.unobserve(this.scrollParentElement);
-        }
-      }
+      (_this$resizeObserver3 = this.resizeObserver) === null || _this$resizeObserver3 === void 0 || _this$resizeObserver3.disconnect();
       this.scheduledUpdatePosition.cancel();
       this.destroyFocusTrap();
       var onUnmount = this.props.onUnmount;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "114.3.1",
+	"version": "114.4.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -178,9 +178,6 @@
 		"media-perf-uplift-mutation-fix": {
 			"type": "boolean"
 		},
-		"platform_editor_link_popup_position_fix_aifc": {
-			"type": "boolean"
-		},
 		"platform_editor_inline_node_virt_threshold_override": {
 			"type": "boolean"
 		},