@atlaskit/editor-common 112.9.1 → 112.10.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/editor-common
 
+## 112.10.0
+
+### Minor Changes
+
+- [`6da6979e0583c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6da6979e0583c) -
+  fix a11y issue for InlineImageWrapper for media inline
+
+### Patch Changes
+
+- [`673732f902814`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/673732f902814) -
+  Add error handling with plugin context to EditorPresetBuilder to improve debugging of plugin
+  initialization failures. When a plugin fails to initialize, the name of the plugin is added to the
+  error message before it's thrown.
+- Updated dependencies
+
 ## 112.9.1
 
 ### Patch Changes

package/dist/cjs/media-inline/inline-image-wrapper.js

@@ -9,6 +9,7 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = require("@emotion/react");
 var _editorPalette = require("@atlaskit/editor-palette");
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _styles = require("./styles");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /**
@@ -35,8 +36,17 @@ var InlineImageWrapper = exports.InlineImageWrapper = function InlineImageWrappe
     onClick = _ref.onClick;
   var borderStyleVars = borderSize && borderColor ? (0, _defineProperty2.default)((0, _defineProperty2.default)({}, _styles.INLINE_IMAGE_BORDER_SIZE_CSS_VAR_KEY, borderSize), _styles.INLINE_IMAGE_BORDER_COLOR_CSS_VAR_KEY, (0, _editorPalette.hexToEditorBorderPaletteColor)(borderColor) || borderColor) : {};
   var aspectStyleVars = aspectRatio ? (0, _defineProperty2.default)({}, _styles.INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, aspectRatio) : {};
+  var onKeyDown = function onKeyDown(e) {
+    if ((0, _expValEquals.expValEquals)('editor_a11y__enghealth-46814_fy26', 'isEnabled', true)) {
+      if (e.key === 'Enter' || e.key === ' ') {
+        e.preventDefault();
+        onClick(e);
+      }
+    }
+    return undefined;
+  };
   return (
-    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives, @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
+    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives
     (0, _react.jsx)("span", (0, _extends2.default)({
       // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
       style: _objectSpread(_objectSpread({}, borderStyleVars), aspectStyleVars)
@@ -51,7 +61,10 @@ var InlineImageWrapper = exports.InlineImageWrapper = function InlineImageWrappe
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
       isSelected && _styles.selectedStyle],
       "data-testid": "inline-image-wrapper",
-      onClick: onClick
+      role: (0, _expValEquals.expValEquals)('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 'button' : undefined,
+      tabIndex: (0, _expValEquals.expValEquals)('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 0 : undefined,
+      onClick: onClick,
+      onKeyDown: onKeyDown
       // Ignored via go/ees005
       // eslint-disable-next-line react/jsx-props-no-spreading
     }, htmlAttrs), (0, _react.jsx)("span", {

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "0.0.0-development";
+var packageVersion = "112.9.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/preset/builder.js

@@ -11,6 +11,7 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _eventDispatcher = require("../event-dispatcher");
 /*********************
  *                    *
@@ -635,12 +636,28 @@ var EditorPresetBuilder = exports.EditorPresetBuilder = /*#__PURE__*/function ()
         if (typeof fn !== 'function') {
           return null;
         }
-        var plugin = pluginInjectionAPI ? fn({
-          config: config,
-          api: pluginInjectionAPI.api()
-        }) : fn({
-          config: config
-        });
+        var plugin;
+        if ((0, _expValEquals.expValEquals)('platform_editor_improve_preset_builder_logging', 'isEnabled', true)) {
+          try {
+            plugin = pluginInjectionAPI ? fn({
+              config: config,
+              api: pluginInjectionAPI.api()
+            }) : fn({
+              config: config
+            });
+          } catch (error) {
+            var pluginName = fn.name || 'unknown';
+            var enhancedError = error instanceof Error ? new Error("Failed to initialize plugin '".concat(pluginName, "': ").concat(error.message)) : new Error("Failed to initialize plugin '".concat(pluginName, "'"));
+            throw enhancedError;
+          }
+        } else {
+          plugin = pluginInjectionAPI ? fn({
+            config: config,
+            api: pluginInjectionAPI.api()
+          }) : fn({
+            config: config
+          });
+        }
         if (plugin && excludePlugins !== null && excludePlugins !== void 0 && excludePlugins.has(plugin.name)) {
           return null;
         }

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "0.0.0-development";
+var packageVersion = "112.9.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/media-inline/inline-image-wrapper.js

@@ -7,6 +7,7 @@ import _extends from "@babel/runtime/helpers/extends";
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled, @typescript-eslint/consistent-type-imports -- Ignored via go/DSP-18766; jsx required at runtime for @jsxRuntime classic
 import { css, jsx } from '@emotion/react';
 import { hexToEditorBorderPaletteColor } from '@atlaskit/editor-palette';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { borderStyle, INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, INLINE_IMAGE_BORDER_COLOR_CSS_VAR_KEY, INLINE_IMAGE_BORDER_SIZE_CSS_VAR_KEY, INLINE_IMAGE_WRAPPER_CLASS_NAME, selectedStyle, wrapperStyle } from './styles';
 
 // The MediaImage component needs to obtain its parent's dimensions.
@@ -34,8 +35,17 @@ export const InlineImageWrapper = ({
   const aspectStyleVars = aspectRatio ? {
     [INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY]: aspectRatio
   } : {};
+  const onKeyDown = e => {
+    if (expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true)) {
+      if (e.key === 'Enter' || e.key === ' ') {
+        e.preventDefault();
+        onClick(e);
+      }
+    }
+    return undefined;
+  };
   return (
-    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives, @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
+    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives
     jsx("span", _extends({
       // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
       style: {
@@ -53,7 +63,10 @@ export const InlineImageWrapper = ({
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
       isSelected && selectedStyle],
       "data-testid": "inline-image-wrapper",
-      onClick: onClick
+      role: expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 'button' : undefined,
+      tabIndex: expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 0 : undefined,
+      onClick: onClick,
+      onKeyDown: onKeyDown
       // Ignored via go/ees005
       // eslint-disable-next-line react/jsx-props-no-spreading
     }, htmlAttrs), jsx("span", {

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "0.0.0-development";
+const packageVersion = "112.9.1";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/preset/builder.js

@@ -1,4 +1,5 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { EventDispatcher } from '../event-dispatcher';
 
 /*********************
@@ -632,12 +633,28 @@ export class EditorPresetBuilder {
       if (typeof fn !== 'function') {
         return null;
       }
-      const plugin = pluginInjectionAPI ? fn({
-        config,
-        api: pluginInjectionAPI.api()
-      }) : fn({
-        config
-      });
+      let plugin;
+      if (expValEquals('platform_editor_improve_preset_builder_logging', 'isEnabled', true)) {
+        try {
+          plugin = pluginInjectionAPI ? fn({
+            config,
+            api: pluginInjectionAPI.api()
+          }) : fn({
+            config
+          });
+        } catch (error) {
+          const pluginName = fn.name || 'unknown';
+          const enhancedError = error instanceof Error ? new Error(`Failed to initialize plugin '${pluginName}': ${error.message}`) : new Error(`Failed to initialize plugin '${pluginName}'`);
+          throw enhancedError;
+        }
+      } else {
+        plugin = pluginInjectionAPI ? fn({
+          config,
+          api: pluginInjectionAPI.api()
+        }) : fn({
+          config
+        });
+      }
       if (plugin && excludePlugins !== null && excludePlugins !== void 0 && excludePlugins.has(plugin.name)) {
         return null;
       }

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "0.0.0-development";
+const packageVersion = "112.9.1";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/media-inline/inline-image-wrapper.js

@@ -10,6 +10,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled, @typescript-eslint/consistent-type-imports -- Ignored via go/DSP-18766; jsx required at runtime for @jsxRuntime classic
 import { css, jsx } from '@emotion/react';
 import { hexToEditorBorderPaletteColor } from '@atlaskit/editor-palette';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { borderStyle, INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, INLINE_IMAGE_BORDER_COLOR_CSS_VAR_KEY, INLINE_IMAGE_BORDER_SIZE_CSS_VAR_KEY, INLINE_IMAGE_WRAPPER_CLASS_NAME, selectedStyle, wrapperStyle } from './styles';
 
 // The MediaImage component needs to obtain its parent's dimensions.
@@ -32,8 +33,17 @@ export var InlineImageWrapper = function InlineImageWrapper(_ref) {
     onClick = _ref.onClick;
   var borderStyleVars = borderSize && borderColor ? _defineProperty(_defineProperty({}, INLINE_IMAGE_BORDER_SIZE_CSS_VAR_KEY, borderSize), INLINE_IMAGE_BORDER_COLOR_CSS_VAR_KEY, hexToEditorBorderPaletteColor(borderColor) || borderColor) : {};
   var aspectStyleVars = aspectRatio ? _defineProperty({}, INLINE_IMAGE_ASPECT_RATIO_CSS_VAR_KEY, aspectRatio) : {};
+  var onKeyDown = function onKeyDown(e) {
+    if (expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true)) {
+      if (e.key === 'Enter' || e.key === ' ') {
+        e.preventDefault();
+        onClick(e);
+      }
+    }
+    return undefined;
+  };
   return (
-    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives, @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
+    // eslint-disable-next-line @atlaskit/design-system/prefer-primitives
     jsx("span", _extends({
       // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
       style: _objectSpread(_objectSpread({}, borderStyleVars), aspectStyleVars)
@@ -48,7 +58,10 @@ export var InlineImageWrapper = function InlineImageWrapper(_ref) {
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
       isSelected && selectedStyle],
       "data-testid": "inline-image-wrapper",
-      onClick: onClick
+      role: expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 'button' : undefined,
+      tabIndex: expValEquals('editor_a11y__enghealth-46814_fy26', 'isEnabled', true) ? 0 : undefined,
+      onClick: onClick,
+      onKeyDown: onKeyDown
       // Ignored via go/ees005
       // eslint-disable-next-line react/jsx-props-no-spreading
     }, htmlAttrs), jsx("span", {

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "0.0.0-development";
+var packageVersion = "112.9.1";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/preset/builder.js

@@ -4,6 +4,7 @@ import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _createClass from "@babel/runtime/helpers/createClass";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { EventDispatcher } from '../event-dispatcher';
 
 /*********************
@@ -666,12 +667,28 @@ export var EditorPresetBuilder = /*#__PURE__*/function () {
         if (typeof fn !== 'function') {
           return null;
         }
-        var plugin = pluginInjectionAPI ? fn({
-          config: config,
-          api: pluginInjectionAPI.api()
-        }) : fn({
-          config: config
-        });
+        var plugin;
+        if (expValEquals('platform_editor_improve_preset_builder_logging', 'isEnabled', true)) {
+          try {
+            plugin = pluginInjectionAPI ? fn({
+              config: config,
+              api: pluginInjectionAPI.api()
+            }) : fn({
+              config: config
+            });
+          } catch (error) {
+            var pluginName = fn.name || 'unknown';
+            var enhancedError = error instanceof Error ? new Error("Failed to initialize plugin '".concat(pluginName, "': ").concat(error.message)) : new Error("Failed to initialize plugin '".concat(pluginName, "'"));
+            throw enhancedError;
+          }
+        } else {
+          plugin = pluginInjectionAPI ? fn({
+            config: config,
+            api: pluginInjectionAPI.api()
+          }) : fn({
+            config: config
+          });
+        }
         if (plugin && excludePlugins !== null && excludePlugins !== void 0 && excludePlugins.has(plugin.name)) {
           return null;
         }

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "0.0.0-development";
+var packageVersion = "112.9.1";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/media-inline/inline-image-wrapper.d.ts

@@ -13,7 +13,7 @@ type Props = {
         [key: string]: string | number | undefined;
     };
     isSelected?: boolean;
-    onClick?: React.EventHandler<React.MouseEvent | React.KeyboardEvent>;
+    onClick: React.EventHandler<React.MouseEvent | React.KeyboardEvent>;
 };
 export declare const InlineImageWrapper: ({ children, isSelected, aspectRatio, borderSize, borderColor, htmlAttrs, onClick, }: React.PropsWithChildren<Props>) => jsx.JSX.Element;
 export {};

package/dist/types-ts4.5/media-inline/inline-image-wrapper.d.ts

@@ -13,7 +13,7 @@ type Props = {
         [key: string]: string | number | undefined;
     };
     isSelected?: boolean;
-    onClick?: React.EventHandler<React.MouseEvent | React.KeyboardEvent>;
+    onClick: React.EventHandler<React.MouseEvent | React.KeyboardEvent>;
 };
 export declare const InlineImageWrapper: ({ children, isSelected, aspectRatio, borderSize, borderColor, htmlAttrs, onClick, }: React.PropsWithChildren<Props>) => jsx.JSX.Element;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "112.9.1",
+	"version": "112.10.0",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -51,7 +51,7 @@
 		"@atlaskit/editor-toolbar": "^0.20.0",
 		"@atlaskit/editor-toolbar-model": "^0.4.0",
 		"@atlaskit/emoji": "^69.10.0",
-		"@atlaskit/icon": "^33.0.0",
+		"@atlaskit/icon": "^33.1.0",
 		"@atlaskit/icon-object": "^7.5.0",
 		"@atlaskit/link": "^3.3.0",
 		"@atlaskit/link-datasource": "^4.34.0",
@@ -81,7 +81,7 @@
 		"@atlaskit/status": "^3.1.0",
 		"@atlaskit/task-decision": "^19.3.0",
 		"@atlaskit/textfield": "^8.2.0",
-		"@atlaskit/tmp-editor-statsig": "^46.0.0",
+		"@atlaskit/tmp-editor-statsig": "^46.1.0",
 		"@atlaskit/tokens": "^11.2.0",
 		"@atlaskit/tooltip": "^21.0.0",
 		"@atlaskit/width-detector": "^5.0.0",