@atlaskit/editor-common 110.41.7 → 110.41.8

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-common
 
+## 110.41.8
+
+### Patch Changes
+
+- [`cb319ae5e7782`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cb319ae5e7782) -
+  EDITOR-2864 - Address HoverLinkOverlay label spilling out beyond the margins of its container on
+  hover. For example, when a smart link is inside a table, and it is broken into 1+ line, the label
+  on hover will not break and will therefore appear hovering out of the table.
+- Updated dependencies
+
 ## 110.41.7
 
 ### Patch Changes

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "0.0.0-development";
+var packageVersion = "110.41.7";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "0.0.0-development";
+var packageVersion = "110.41.7";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/cjs/ui/HoverLinkOverlay/index.js

@@ -184,10 +184,31 @@ var HoverLinkOverlayOriginal = function HoverLinkOverlayOriginal(_ref) {
     }
     var openTextWidth = openTextWidthRef.current || DEFAULT_OPEN_TEXT_WIDTH;
     var canShowLabel = cardWidth - openTextWidth > MIN_AVAILABLE_SPACE_WITH_LABEL_OVERLAY + ICON_WIDTH;
+
+    // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
+    // the hover button can overflow beyond the container bounds. We detect this by comparing
+    // the button's right edge to the container's right edge, and hide the label if it overflows.
+    if ((0, _experiments.editorExperiment)('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (containerRef.current && hoverLinkButtonRef.current) {
+        var containerRight = containerRef.current.getBoundingClientRect().right;
+        var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+        if (buttonRight > containerRight) {
+          canShowLabel = false;
+        }
+      }
+    }
     setShowLabel(canShowLabel);
   }, [isVisible, isHovered]);
   var handleOverlayChange = function handleOverlayChange(isHovered) {
     setHovered(isHovered);
+
+    // Reset label visibility on hover start so we can measure if it overflows.
+    // Without this, the label stays hidden from a previous hover and won't be re-measured.
+    if ((0, _experiments.editorExperiment)('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (isHovered) {
+        setShowLabel(true);
+      }
+    }
   };
   var sendVisitLinkAnalytics = function sendVisitLinkAnalytics(inputMethod) {
     if (editorAnalyticsApi && view) {

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "0.0.0-development";
+const packageVersion = "110.41.7";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "0.0.0-development";
+const packageVersion = "110.41.7";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/es2019/ui/HoverLinkOverlay/index.js

@@ -163,11 +163,32 @@ const HoverLinkOverlayOriginal = ({
       return;
     }
     const openTextWidth = openTextWidthRef.current || DEFAULT_OPEN_TEXT_WIDTH;
-    const canShowLabel = cardWidth - openTextWidth > MIN_AVAILABLE_SPACE_WITH_LABEL_OVERLAY + ICON_WIDTH;
+    let canShowLabel = cardWidth - openTextWidth > MIN_AVAILABLE_SPACE_WITH_LABEL_OVERLAY + ICON_WIDTH;
+
+    // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
+    // the hover button can overflow beyond the container bounds. We detect this by comparing
+    // the button's right edge to the container's right edge, and hide the label if it overflows.
+    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (containerRef.current && hoverLinkButtonRef.current) {
+        const containerRight = containerRef.current.getBoundingClientRect().right;
+        const buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+        if (buttonRight > containerRight) {
+          canShowLabel = false;
+        }
+      }
+    }
     setShowLabel(canShowLabel);
   }, [isVisible, isHovered]);
   const handleOverlayChange = isHovered => {
     setHovered(isHovered);
+
+    // Reset label visibility on hover start so we can measure if it overflows.
+    // Without this, the label stays hidden from a previous hover and won't be re-measured.
+    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (isHovered) {
+        setShowLabel(true);
+      }
+    }
   };
   const sendVisitLinkAnalytics = inputMethod => {
     if (editorAnalyticsApi && view) {

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "0.0.0-development";
+var packageVersion = "110.41.7";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "0.0.0-development";
+var packageVersion = "110.41.7";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/esm/ui/HoverLinkOverlay/index.js

@@ -170,10 +170,31 @@ var HoverLinkOverlayOriginal = function HoverLinkOverlayOriginal(_ref) {
     }
     var openTextWidth = openTextWidthRef.current || DEFAULT_OPEN_TEXT_WIDTH;
     var canShowLabel = cardWidth - openTextWidth > MIN_AVAILABLE_SPACE_WITH_LABEL_OVERLAY + ICON_WIDTH;
+
+    // When a smart link wraps to multiple lines in a constrained container (e.g. table cell),
+    // the hover button can overflow beyond the container bounds. We detect this by comparing
+    // the button's right edge to the container's right edge, and hide the label if it overflows.
+    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (containerRef.current && hoverLinkButtonRef.current) {
+        var containerRight = containerRef.current.getBoundingClientRect().right;
+        var buttonRight = hoverLinkButtonRef.current.getBoundingClientRect().right;
+        if (buttonRight > containerRight) {
+          canShowLabel = false;
+        }
+      }
+    }
     setShowLabel(canShowLabel);
   }, [isVisible, isHovered]);
   var handleOverlayChange = function handleOverlayChange(isHovered) {
     setHovered(isHovered);
+
+    // Reset label visibility on hover start so we can measure if it overflows.
+    // Without this, the label stays hidden from a previous hover and won't be re-measured.
+    if (editorExperiment('cc_editor_hover_link_overlay_css_fix', true)) {
+      if (isHovered) {
+        setShowLabel(true);
+      }
+    }
   };
   var sendVisitLinkAnalytics = function sendVisitLinkAnalytics(inputMethod) {
     if (editorAnalyticsApi && view) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "110.41.7",
+	"version": "110.41.8",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -81,7 +81,7 @@
 		"@atlaskit/task-decision": "^19.2.0",
 		"@atlaskit/textfield": "^8.2.0",
 		"@atlaskit/theme": "^21.0.0",
-		"@atlaskit/tmp-editor-statsig": "^15.7.0",
+		"@atlaskit/tmp-editor-statsig": "^15.9.0",
 		"@atlaskit/tokens": "^8.4.0",
 		"@atlaskit/tooltip": "^20.11.0",
 		"@atlaskit/width-detector": "^5.0.0",