@atlaskit/editor-common 110.41.1 → 110.41.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-common
 
+## 110.41.3
+
+### Patch Changes
+
+- [`7c295bfea1292`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/7c295bfea1292) -
+  EDITOR-3380 Use preserved selection when deleting selected range
+- Updated dependencies
+
+## 110.41.2
+
+### Patch Changes
+
+- [`4ac3023fb991b`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/4ac3023fb991b) -
+  EDITOR-2478 Clean up experiment `platform_editor_nested_table_detection`
+- Updated dependencies
+
 ## 110.41.1
 
 ### Patch Changes

package/afm-cc/tsconfig.json

@@ -5,7 +5,8 @@
 		"target": "es5",
 		"outDir": "../../../../../confluence/tsDist/@atlaskit__editor-common",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/afm-jira/tsconfig.json

@@ -5,7 +5,8 @@
 		"target": "es5",
 		"outDir": "../../../../../jira/tsDist/@atlaskit__editor-common/app",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/afm-products/tsconfig.json

@@ -5,7 +5,8 @@
 		"target": "es5",
 		"outDir": "../../../../../tsDist/@atlaskit__editor-common/app",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/dist/cjs/monitoring/error.js

@@ -19,7 +19,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "110.41.0";
+var packageVersion = "0.0.0-development";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/nesting/utilities.js

@@ -5,7 +5,6 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.isSelectionTableNestedInTable = exports.isNestedTablesSupported = exports.getPositionAfterTopParentNodeOfType = exports.getParentOfTypeCount = void 0;
 var _editorTables = require("@atlaskit/editor-tables");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 /*
  * Returns the level of nesting of a given `nodeType` in the current position.
  * eg. table > table is nested 1 level, table > table > table is nested 2 levels.
@@ -76,9 +75,6 @@ var isSelectionTableNestedInTable = exports.isSelectionTableNestedInTable = func
  */
 var isNestedTablesSupported = exports.isNestedTablesSupported = function isNestedTablesSupported(schema) {
   var _tableCell$contentMat, _tableHeader$contentM;
-  if (!(0, _expValEquals.expValEquals)('platform_editor_nested_table_detection', 'isEnabled', true)) {
-    return true;
-  }
   var _schema$nodes = schema.nodes,
     table = _schema$nodes.table,
     tableCell = _schema$nodes.tableCell,

package/dist/cjs/selection/utils.js

@@ -130,15 +130,19 @@ var expandSelectionBounds = exports.expandSelectionBounds = function expandSelec
 /**
  * Delete what is selected in the given transaction.
  * @param tr the transaction to delete the selection from
+ * @param selectionToUse optional selection to delete instead of the transaction's current selection
  * @returns the updated transaction
  */
-var deleteSelectedRange = exports.deleteSelectedRange = function deleteSelectedRange(tr) {
-  var selection = tr.selection;
+var deleteSelectedRange = exports.deleteSelectedRange = function deleteSelectedRange(tr, selectionToUse) {
+  var selection = selectionToUse || tr.selection;
   var from = selection.$from.pos;
   var to = selection.$to.pos;
   if (selection instanceof _state.TextSelection) {
-    from = from - 1;
-    to = to + 1;
+    // Expand just the from position to the start of the block
+    // This ensures entire paragraphs are deleted instead of just
+    // the text content, which avoids leaving an empty line behind
+    var expanded = expandToBlockRange(selection.$from, selection.$to);
+    from = expanded.$from.pos;
   } else if ((0, _utils.isTableSelected)(selection)) {
     var table = (0, _utils.findTable)(selection);
     if (table) {

package/dist/cjs/ui/DropList/index.js

@@ -24,7 +24,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "110.41.0";
+var packageVersion = "0.0.0-development";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = (0, _react2.keyframes)({

package/dist/es2019/monitoring/error.js

@@ -4,7 +4,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "110.41.0";
+const packageVersion = "0.0.0-development";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/nesting/utilities.js

@@ -1,5 +1,4 @@
 import { findTable } from '@atlaskit/editor-tables';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 
 /*
  * Returns the level of nesting of a given `nodeType` in the current position.
@@ -67,9 +66,6 @@ export const isSelectionTableNestedInTable = state => {
  */
 export const isNestedTablesSupported = schema => {
   var _tableCell$contentMat, _tableHeader$contentM;
-  if (!expValEquals('platform_editor_nested_table_detection', 'isEnabled', true)) {
-    return true;
-  }
   const {
     table,
     tableCell,

package/dist/es2019/selection/utils.js

@@ -129,15 +129,19 @@ export const expandSelectionBounds = ($anchor, $head) => {
 /**
  * Delete what is selected in the given transaction.
  * @param tr the transaction to delete the selection from
+ * @param selectionToUse optional selection to delete instead of the transaction's current selection
  * @returns the updated transaction
  */
-export const deleteSelectedRange = tr => {
-  const selection = tr.selection;
+export const deleteSelectedRange = (tr, selectionToUse) => {
+  const selection = selectionToUse || tr.selection;
   let from = selection.$from.pos;
   let to = selection.$to.pos;
   if (selection instanceof TextSelection) {
-    from = from - 1;
-    to = to + 1;
+    // Expand just the from position to the start of the block
+    // This ensures entire paragraphs are deleted instead of just
+    // the text content, which avoids leaving an empty line behind
+    const expanded = expandToBlockRange(selection.$from, selection.$to);
+    from = expanded.$from.pos;
   } else if (isTableSelected(selection)) {
     const table = findTable(selection);
     if (table) {

package/dist/es2019/ui/DropList/index.js

@@ -14,7 +14,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "110.41.0";
+const packageVersion = "0.0.0-development";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 const fadeIn = keyframes({

package/dist/esm/monitoring/error.js

@@ -10,7 +10,7 @@ import { isFedRamp } from './environment';
 import { normaliseSentryBreadcrumbs, SERIALIZABLE_ATTRIBUTES } from './normalise-sentry-breadcrumbs';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "110.41.0";
+var packageVersion = "0.0.0-development";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/nesting/utilities.js

@@ -1,5 +1,4 @@
 import { findTable } from '@atlaskit/editor-tables';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 
 /*
  * Returns the level of nesting of a given `nodeType` in the current position.
@@ -71,9 +70,6 @@ export var isSelectionTableNestedInTable = function isSelectionTableNestedInTabl
  */
 export var isNestedTablesSupported = function isNestedTablesSupported(schema) {
   var _tableCell$contentMat, _tableHeader$contentM;
-  if (!expValEquals('platform_editor_nested_table_detection', 'isEnabled', true)) {
-    return true;
-  }
   var _schema$nodes = schema.nodes,
     table = _schema$nodes.table,
     tableCell = _schema$nodes.tableCell,

package/dist/esm/selection/utils.js

@@ -117,15 +117,19 @@ export var expandSelectionBounds = function expandSelectionBounds($anchor, $head
 /**
  * Delete what is selected in the given transaction.
  * @param tr the transaction to delete the selection from
+ * @param selectionToUse optional selection to delete instead of the transaction's current selection
  * @returns the updated transaction
  */
-export var deleteSelectedRange = function deleteSelectedRange(tr) {
-  var selection = tr.selection;
+export var deleteSelectedRange = function deleteSelectedRange(tr, selectionToUse) {
+  var selection = selectionToUse || tr.selection;
   var from = selection.$from.pos;
   var to = selection.$to.pos;
   if (selection instanceof TextSelection) {
-    from = from - 1;
-    to = to + 1;
+    // Expand just the from position to the start of the block
+    // This ensures entire paragraphs are deleted instead of just
+    // the text content, which avoids leaving an empty line behind
+    var expanded = expandToBlockRange(selection.$from, selection.$to);
+    from = expanded.$from.pos;
   } else if (isTableSelected(selection)) {
     var table = findTable(selection);
     if (table) {

package/dist/esm/ui/DropList/index.js

@@ -21,7 +21,7 @@ import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import { fg } from '@atlaskit/platform-feature-flags';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "110.41.0";
+var packageVersion = "0.0.0-development";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 var fadeIn = keyframes({

package/dist/types/selection/utils.d.ts

@@ -1,5 +1,6 @@
-import type { ResolvedPos, Node as PMNode } from '@atlaskit/editor-prosemirror/model';
+import type { Node as PMNode, ResolvedPos } from '@atlaskit/editor-prosemirror/model';
 import type { EditorState, Transaction } from '@atlaskit/editor-prosemirror/state';
+import { type Selection } from '@atlaskit/editor-prosemirror/state';
 export declare const isSelectionAtStartOfNode: ($pos: ResolvedPos, parentNode?: PMNode) => boolean;
 export declare const isSelectionAtEndOfNode: ($pos: ResolvedPos, parentNode?: PMNode) => boolean;
 export declare function atTheEndOfDoc(state: EditorState): boolean;
@@ -21,9 +22,10 @@ export declare const expandSelectionBounds: ($anchor: ResolvedPos, $head: Resolv
 /**
  * Delete what is selected in the given transaction.
  * @param tr the transaction to delete the selection from
+ * @param selectionToUse optional selection to delete instead of the transaction's current selection
  * @returns the updated transaction
  */
-export declare const deleteSelectedRange: (tr: Transaction) => Transaction;
+export declare const deleteSelectedRange: (tr: Transaction, selectionToUse?: Selection) => Transaction;
 /**
  * This expands the given $from and $to resolved positions to the block boundaries
  * spanning all nodes in the range up to the nearest common ancestor.

package/dist/types-ts4.5/selection/utils.d.ts

@@ -1,5 +1,6 @@
-import type { ResolvedPos, Node as PMNode } from '@atlaskit/editor-prosemirror/model';
+import type { Node as PMNode, ResolvedPos } from '@atlaskit/editor-prosemirror/model';
 import type { EditorState, Transaction } from '@atlaskit/editor-prosemirror/state';
+import { type Selection } from '@atlaskit/editor-prosemirror/state';
 export declare const isSelectionAtStartOfNode: ($pos: ResolvedPos, parentNode?: PMNode) => boolean;
 export declare const isSelectionAtEndOfNode: ($pos: ResolvedPos, parentNode?: PMNode) => boolean;
 export declare function atTheEndOfDoc(state: EditorState): boolean;
@@ -21,9 +22,10 @@ export declare const expandSelectionBounds: ($anchor: ResolvedPos, $head: Resolv
 /**
  * Delete what is selected in the given transaction.
  * @param tr the transaction to delete the selection from
+ * @param selectionToUse optional selection to delete instead of the transaction's current selection
  * @returns the updated transaction
  */
-export declare const deleteSelectedRange: (tr: Transaction) => Transaction;
+export declare const deleteSelectedRange: (tr: Transaction, selectionToUse?: Selection) => Transaction;
 /**
  * This expands the given $from and $to resolved positions to the block boundaries
  * spanning all nodes in the range up to the nearest common ancestor.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "110.41.1",
+	"version": "110.41.3",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -81,7 +81,7 @@
 		"@atlaskit/task-decision": "^19.2.0",
 		"@atlaskit/textfield": "^8.1.0",
 		"@atlaskit/theme": "^21.0.0",
-		"@atlaskit/tmp-editor-statsig": "^15.3.0",
+		"@atlaskit/tmp-editor-statsig": "^15.6.0",
 		"@atlaskit/tokens": "^8.4.0",
 		"@atlaskit/tooltip": "^20.11.0",
 		"@atlaskit/width-detector": "^5.0.0",