@atlaskit/editor-common 106.6.1 → 106.6.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-common
 
+## 106.6.2
+
+### Patch Changes
+
+- [#170866](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/170866)
+  [`0d19a8feca6a0`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0d19a8feca6a0) -
+  Fixing a bug where we were unsubscribing the wrong provider call-back
+
 ## 106.6.1
 
 ### Patch Changes

package/dist/cjs/element-browser/components/ElementList/ElementList.js

@@ -290,6 +290,8 @@ var ElementListMultipleColumns = function ElementListMultipleColumns(props) {
         // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766 -- Ignored via go/DSP-18766
         ,
         className: "element-item-wrapper",
+        role: "gridcell",
+        tabIndex: 0,
         css: elementItemWrapper,
         onKeyDown: function onKeyDown(e) {
           if (e.key === 'Tab') {
@@ -326,6 +328,7 @@ var ElementListMultipleColumns = function ElementListMultipleColumns(props) {
   // eslint-disable-next-line react-hooks/exhaustive-deps
   [cache, items, fullMode, selectedItemIndex, columnCount, focusedItemIndex, selectedCategoryIndex, setFocusedCategoryIndex, setFocusedItemIndex, props]);
   return (0, _react2.jsx)(_reactVirtualized.Grid, (0, _extends2.default)({
+    containerRole: "row",
     cellRenderer: cellRenderer,
     height: height,
     width: containerWidth - _constants.ELEMENT_LIST_PADDING * 2 // containerWidth - padding on Left/Right (for focus outline)

package/dist/cjs/monitoring/error.js

@@ -16,7 +16,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "106.6.1";
+var packageVersion = "106.6.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/provider-factory/with-providers.js

@@ -12,6 +12,7 @@ var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/ge
 var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = require("react");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2.default)(o), (0, _possibleConstructorReturn2.default)(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], (0, _getPrototypeOf2.default)(t).constructor) : o.apply(t, e)); }
@@ -70,7 +71,7 @@ var WithProviders = exports.WithProviders = /*#__PURE__*/function (_PureComponen
         providers = _this$props.providers,
         providerFactory = _this$props.providerFactory;
       providers.forEach(function (name) {
-        providerFactory.unsubscribe(name, _this2.handleProvider);
+        providerFactory.unsubscribe(name, (0, _platformFeatureFlags.fg)('platform_editor_fix_unsubscribe_of_provider') ? _this2.handleProviderIfMounted : _this2.handleProvider);
       });
     }
   }, {

package/dist/cjs/ui/DropList/index.js

@@ -23,7 +23,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "106.6.1";
+var packageVersion = "106.6.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/es2019/element-browser/components/ElementList/ElementList.js

@@ -280,6 +280,8 @@ const ElementListMultipleColumns = props => {
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766 -- Ignored via go/DSP-18766
       ,
       className: "element-item-wrapper",
+      role: "gridcell",
+      tabIndex: 0,
       css: elementItemWrapper,
       onKeyDown: e => {
         if (e.key === 'Tab') {
@@ -315,6 +317,7 @@ const ElementListMultipleColumns = props => {
   // eslint-disable-next-line react-hooks/exhaustive-deps
   [cache, items, fullMode, selectedItemIndex, columnCount, focusedItemIndex, selectedCategoryIndex, setFocusedCategoryIndex, setFocusedItemIndex, props]);
   return jsx(Grid, _extends({
+    containerRole: "row",
     cellRenderer: cellRenderer,
     height: height,
     width: containerWidth - ELEMENT_LIST_PADDING * 2 // containerWidth - padding on Left/Right (for focus outline)

package/dist/es2019/monitoring/error.js

@@ -1,7 +1,7 @@
 import { isFedRamp } from './environment';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "106.6.1";
+const packageVersion = "106.6.2";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/provider-factory/with-providers.js

@@ -1,6 +1,7 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 /* eslint-disable @repo/internal/react/no-class-components */
 import { PureComponent } from 'react';
+import { fg } from '@atlaskit/platform-feature-flags';
 // Ignored via go/ees005
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class WithProviders extends PureComponent {
@@ -51,7 +52,7 @@ export class WithProviders extends PureComponent {
       providerFactory
     } = this.props;
     providers.forEach(name => {
-      providerFactory.unsubscribe(name, this.handleProvider);
+      providerFactory.unsubscribe(name, fg('platform_editor_fix_unsubscribe_of_provider') ? this.handleProviderIfMounted : this.handleProvider);
     });
   }
   render() {

package/dist/es2019/ui/DropList/index.js

@@ -13,7 +13,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "106.6.1";
+const packageVersion = "106.6.2";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/esm/element-browser/components/ElementList/ElementList.js

@@ -279,6 +279,8 @@ var ElementListMultipleColumns = function ElementListMultipleColumns(props) {
         // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766 -- Ignored via go/DSP-18766
         ,
         className: "element-item-wrapper",
+        role: "gridcell",
+        tabIndex: 0,
         css: elementItemWrapper,
         onKeyDown: function onKeyDown(e) {
           if (e.key === 'Tab') {
@@ -315,6 +317,7 @@ var ElementListMultipleColumns = function ElementListMultipleColumns(props) {
   // eslint-disable-next-line react-hooks/exhaustive-deps
   [cache, items, fullMode, selectedItemIndex, columnCount, focusedItemIndex, selectedCategoryIndex, setFocusedCategoryIndex, setFocusedItemIndex, props]);
   return jsx(Grid, _extends({
+    containerRole: "row",
     cellRenderer: cellRenderer,
     height: height,
     width: containerWidth - ELEMENT_LIST_PADDING * 2 // containerWidth - padding on Left/Right (for focus outline)

package/dist/esm/monitoring/error.js

@@ -7,7 +7,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import { isFedRamp } from './environment';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "106.6.1";
+var packageVersion = "106.6.2";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/provider-factory/with-providers.js

@@ -10,6 +10,7 @@ function _callSuper(t, o, e) { return o = _getPrototypeOf(o), _possibleConstruct
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
 /* eslint-disable @repo/internal/react/no-class-components */
 import { PureComponent } from 'react';
+import { fg } from '@atlaskit/platform-feature-flags';
 // Ignored via go/ees005
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export var WithProviders = /*#__PURE__*/function (_PureComponent) {
@@ -64,7 +65,7 @@ export var WithProviders = /*#__PURE__*/function (_PureComponent) {
         providers = _this$props.providers,
         providerFactory = _this$props.providerFactory;
       providers.forEach(function (name) {
-        providerFactory.unsubscribe(name, _this2.handleProvider);
+        providerFactory.unsubscribe(name, fg('platform_editor_fix_unsubscribe_of_provider') ? _this2.handleProviderIfMounted : _this2.handleProvider);
       });
     }
   }, {

package/dist/esm/ui/DropList/index.js

@@ -20,7 +20,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "106.6.1";
+var packageVersion = "106.6.2";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/types/provider-factory/with-providers.d.ts

@@ -1,6 +1,6 @@
 import { PureComponent } from 'react';
 import type ProviderFactory from './provider-factory';
-import { type ProviderName, type Providers } from './types';
+import type { ProviderName, Providers } from './types';
 export interface Props {
     providerFactory: ProviderFactory;
     providers: ProviderName[];

package/dist/types-ts4.5/provider-factory/with-providers.d.ts

@@ -1,6 +1,6 @@
 import { PureComponent } from 'react';
 import type ProviderFactory from './provider-factory';
-import { type ProviderName, type Providers } from './types';
+import type { ProviderName, Providers } from './types';
 export interface Props {
     providerFactory: ProviderFactory;
     providers: ProviderName[];

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "106.6.1",
+	"version": "106.6.2",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -147,7 +147,7 @@
 		"@atlaskit/link-datasource": "^4.11.0",
 		"@atlaskit/link-picker": "^3.5.0",
 		"@atlaskit/media-card": "^79.3.0",
-		"@atlaskit/media-client": "^33.3.0",
+		"@atlaskit/media-client": "^33.4.0",
 		"@atlaskit/media-client-react": "^4.1.0",
 		"@atlaskit/media-common": "^12.1.0",
 		"@atlaskit/media-file-preview": "^0.11.0",
@@ -397,6 +397,9 @@
 		},
 		"platform_editor_breakout_resizing_hello_release": {
 			"type": "boolean"
+		},
+		"platform_editor_fix_unsubscribe_of_provider": {
+			"type": "boolean"
 		}
 	}
 }