@atlaskit/editor-common 103.9.2 → 103.9.3

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-common
 
+## 103.9.3
+
+### Patch Changes
+
+- [#138479](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/138479)
+  [`058e8050f1a78`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/058e8050f1a78) -
+  [A11Y-9995] Popup aria label removed fallback and added aria label where it fits in places that
+  uses the component
+
 ## 103.9.2
 
 ### Patch Changes

package/dist/cjs/monitoring/error.js

@@ -17,7 +17,7 @@ function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "103.9.2";
+var packageVersion = "103.9.3";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/cjs/ui/DropList/index.js

@@ -23,7 +23,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsx jsx
  */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "103.9.2";
+var packageVersion = "103.9.3";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/cjs/ui/Popup/index.js

@@ -16,6 +16,7 @@ var _focusTrap = _interopRequireDefault(require("focus-trap"));
 var _rafSchd = _interopRequireDefault(require("raf-schd"));
 var _reactDom = require("react-dom");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("./utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -293,14 +294,19 @@ var Popup = exports.default = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "renderPopup",
     value: function renderPopup() {
+      var _this$props$ariaLabel;
       var position = this.state.position;
       var shouldRenderPopup = this.props.shouldRenderPopup;
       if (shouldRenderPopup && !shouldRenderPopup(position || {})) {
         return null;
       }
 
-      //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
-      var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+      /**
+       * https://a11y.atlassian.net/browse/A11Y-9995
+       * We set aria-label to undefined if it's null, no more 'Popup' fallback.
+       * It is meaningless for screen readers and causes confusion.
+       */
+      var ariaLabel = (0, _platformFeatureFlags.fg)('editor_a11y_aria_label_removal_popup') ? (_this$props$ariaLabel = this.props.ariaLabel) !== null && _this$props$ariaLabel !== void 0 ? _this$props$ariaLabel : undefined : this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
       return /*#__PURE__*/_react.default.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({

package/dist/es2019/monitoring/error.js

@@ -1,7 +1,7 @@
 import { isFedRamp } from './environment';
 const SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 const packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-const packageVersion = "103.9.2";
+const packageVersion = "103.9.3";
 const sanitiseSentryEvents = (data, _hint) => {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/es2019/ui/DropList/index.js

@@ -13,7 +13,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 const packageName = "@atlaskit/editor-common";
-const packageVersion = "103.9.2";
+const packageVersion = "103.9.3";
 const halfFocusRing = 1;
 const dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/es2019/ui/Popup/index.js

@@ -4,6 +4,7 @@ import createFocusTrap from 'focus-trap';
 import rafSchedule from 'raf-schd';
 import { createPortal, flushSync } from 'react-dom';
 import { akEditorFloatingPanelZIndex } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { calculatePlacement, calculatePosition, findOverflowScrollParent, validatePosition } from './utils';
 // Ignored via go/ees005
 // eslint-disable-next-line @repo/internal/react/no-class-components
@@ -254,6 +255,7 @@ export default class Popup extends React.Component {
     }
   }
   renderPopup() {
+    var _this$props$ariaLabel;
     const {
       position
     } = this.state;
@@ -264,8 +266,12 @@ export default class Popup extends React.Component {
       return null;
     }
 
-    //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
-    const ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+    /**
+     * https://a11y.atlassian.net/browse/A11Y-9995
+     * We set aria-label to undefined if it's null, no more 'Popup' fallback.
+     * It is meaningless for screen readers and causes confusion.
+     */
+    const ariaLabel = fg('editor_a11y_aria_label_removal_popup') ? (_this$props$ariaLabel = this.props.ariaLabel) !== null && _this$props$ariaLabel !== void 0 ? _this$props$ariaLabel : undefined : this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
     return /*#__PURE__*/React.createElement("div", {
       ref: this.handleRef,
       style: {

package/dist/esm/monitoring/error.js

@@ -7,7 +7,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import { isFedRamp } from './environment';
 var SENTRY_DSN = 'https://0b10c8e02fb44d8796c047b102c9bee8@o55978.ingest.sentry.io/4505129224110080';
 var packageName = 'editor-common'; // Sentry doesn't accept '/' in its releases https://docs.sentry.io/platforms/javascript/configuration/releases/
-var packageVersion = "103.9.2";
+var packageVersion = "103.9.3";
 var sanitiseSentryEvents = function sanitiseSentryEvents(data, _hint) {
   // Remove URL as it has UGC
   // Ignored via go/ees007

package/dist/esm/ui/DropList/index.js

@@ -20,7 +20,7 @@ import withAnalyticsContext from '@atlaskit/analytics-next/withAnalyticsContext'
 import withAnalyticsEvents from '@atlaskit/analytics-next/withAnalyticsEvents';
 import Layer from '../Layer';
 var packageName = "@atlaskit/editor-common";
-var packageVersion = "103.9.2";
+var packageVersion = "103.9.3";
 var halfFocusRing = 1;
 var dropOffset = '0, 8';
 // Ignored via go/ees005

package/dist/esm/ui/Popup/index.js

@@ -13,6 +13,7 @@ import createFocusTrap from 'focus-trap';
 import rafSchedule from 'raf-schd';
 import { createPortal, flushSync } from 'react-dom';
 import { akEditorFloatingPanelZIndex } from '@atlaskit/editor-shared-styles';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { calculatePlacement, calculatePosition as _calculatePosition, findOverflowScrollParent, validatePosition } from './utils';
 // Ignored via go/ees005
 // eslint-disable-next-line @repo/internal/react/no-class-components
@@ -286,14 +287,19 @@ var Popup = /*#__PURE__*/function (_React$Component) {
   }, {
     key: "renderPopup",
     value: function renderPopup() {
+      var _this$props$ariaLabel;
       var position = this.state.position;
       var shouldRenderPopup = this.props.shouldRenderPopup;
       if (shouldRenderPopup && !shouldRenderPopup(position || {})) {
         return null;
       }
 
-      //In some cases we don't want to use default "Popup" text as an aria-label. It might be tedious for screen reader users.
-      var ariaLabel = this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
+      /**
+       * https://a11y.atlassian.net/browse/A11Y-9995
+       * We set aria-label to undefined if it's null, no more 'Popup' fallback.
+       * It is meaningless for screen readers and causes confusion.
+       */
+      var ariaLabel = fg('editor_a11y_aria_label_removal_popup') ? (_this$props$ariaLabel = this.props.ariaLabel) !== null && _this$props$ariaLabel !== void 0 ? _this$props$ariaLabel : undefined : this.props.ariaLabel === null ? undefined : this.props.ariaLabel || 'Popup';
       return /*#__PURE__*/React.createElement("div", {
         ref: this.handleRef,
         style: _objectSpread(_objectSpread({

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-common",
-	"version": "103.9.2",
+	"version": "103.9.3",
 	"description": "A package that contains common classes and components for editor and renderer",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -335,6 +335,9 @@
 		"platform_editor_lcm_nested_panel_icon_fix": {
 			"type": "boolean"
 		},
+		"editor_a11y_aria_label_removal_popup": {
+			"type": "boolean"
+		},
 		"platform_fix_media_image_resizing": {
 			"type": "boolean"
 		}