@atlaskit/dynamic-table 15.2.0 → 16.0.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/dynamic-table
 
+## 16.0.0
+
+### Major Changes
+
+- [#150464](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/150464)
+  [`b813bd74ede6d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/b813bd74ede6d) -
+  Migrates usage of react-beautiful-dnd to pragmatic-dnd using the interop-layer from PDND. There
+  are no breaking changes however there may be minor behavioural and visual chagnes as a result
+  since the experiences are fundamentally different.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 15.2.0
 
 ### Minor Changes

package/dist/cjs/components/rankable/body.js

@@ -14,7 +14,7 @@ var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime
 var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireDefault(require("react"));
-var _reactBeautifulDnd = require("react-beautiful-dnd");
+var _pragmaticDragAndDropReactBeautifulDndMigration = require("@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration");
 var _withSortedPageRows = _interopRequireDefault(require("../../hoc/with-sorted-page-rows"));
 var _tableRow = _interopRequireDefault(require("./table-row"));
 function _createSuper(t) { var r = _isNativeReflectConstruct(); return function () { var e, o = (0, _getPrototypeOf2.default)(t); if (r) { var s = (0, _getPrototypeOf2.default)(this).constructor; e = Reflect.construct(o, arguments, s); } else e = o.apply(this, arguments); return (0, _possibleConstructorReturn2.default)(this, e); }; }
@@ -87,10 +87,10 @@ var RankableBody = exports.RankableBody = /*#__PURE__*/function (_React$Componen
         isRankingDisabled = _this$props2.isRankingDisabled,
         testId = _this$props2.testId,
         forwardedRef = _this$props2.forwardedRef;
-      return /*#__PURE__*/_react.default.createElement(_reactBeautifulDnd.DragDropContext, {
+      return /*#__PURE__*/_react.default.createElement(_pragmaticDragAndDropReactBeautifulDndMigration.DragDropContext, {
         onBeforeDragStart: this.onBeforeDragStart,
         onDragEnd: this.onDragEnd
-      }, /*#__PURE__*/_react.default.createElement(_reactBeautifulDnd.Droppable, {
+      }, /*#__PURE__*/_react.default.createElement(_pragmaticDragAndDropReactBeautifulDndMigration.Droppable, {
         droppableId: "dynamic-table-droppable",
         isDropDisabled: isRankingDisabled
       }, function (provided) {
@@ -114,7 +114,7 @@ var RankableBody = exports.RankableBody = /*#__PURE__*/function (_React$Componen
             row: row,
             isRankingDisabled: isRankingDisabled,
             isHighlighted: !!highlightedRowIndex && (typeof highlightedRowIndex === 'number' ? highlightedRowIndex === rowIndex : highlightedRowIndex.indexOf(rowIndex) > -1),
-            testId: testId && "".concat(testId, "--rankable--table--row")
+            testId: testId && "".concat(testId, "--").concat(row.key, "--rankable--table--row")
           });
         }), provided.placeholder);
       }));

package/dist/cjs/components/rankable/table-row.js

@@ -15,7 +15,7 @@ var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime
 var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireDefault(require("react"));
-var _reactBeautifulDnd = require("react-beautiful-dnd");
+var _pragmaticDragAndDropReactBeautifulDndMigration = require("@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration");
 var _withDimensions = _interopRequireDefault(require("../../hoc/with-dimensions"));
 var _helpers = require("../../internal/helpers");
 var _tableRow = require("../../styled/rankable/table-row");
@@ -69,7 +69,7 @@ var RankableTableRow = exports.RankableTableRow = /*#__PURE__*/function (_React$
       if (typeof key !== 'string' && !isRankingDisabled) {
         throw new Error('dynamic-table: ranking is not possible because table row does not have a key. Add the key to the row or disable ranking.');
       }
-      return /*#__PURE__*/_react.default.createElement(_reactBeautifulDnd.Draggable, {
+      return /*#__PURE__*/_react.default.createElement(_pragmaticDragAndDropReactBeautifulDndMigration.Draggable, {
         draggableId: key || rowIndex.toString(),
         index: rowIndex,
         isDragDisabled: isRankingDisabled

package/dist/cjs/components/stateless.js

@@ -86,14 +86,14 @@ var DynamicTable = function DynamicTable(_ref) {
     action: 'sorted',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   var onRankEnd = (0, _analyticsNext.usePlatformLeafEventHandler)({
     fn: providedOnRankEnd,
     action: 'ranked',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   (0, _react.useEffect)(function () {
     (0, _helpers.validateSortKey)(sortKey, head);

package/dist/cjs/styled/table-head.js

@@ -10,6 +10,7 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
 var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
 var _react = require("react");
 var _react2 = require("@emotion/react");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _colors = require("@atlaskit/theme/colors");
 var _constants = require("../internal/constants");
 var _theme = require("../theme");
@@ -42,6 +43,20 @@ var Head = exports.Head = function Head(_ref) {
   }, props));
 };
 var headCellBaseStyles = (0, _react2.css)({
+  boxSizing: 'border-box',
+  position: 'relative',
+  border: 'none',
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  borderBlockEnd: "2px solid ".concat(_theme.tableBorder.borderColor),
+  color: "var(--ds-text-subtlest, ".concat("var(".concat(CSS_VAR_TEXT_COLOR, ")"), ")"),
+  font: "var(--ds-font-heading-xxsmall, normal 600 12px/16px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, system-ui, \"Helvetica Neue\", sans-serif)",
+  textAlign: 'left',
+  verticalAlign: 'top',
+  '&:focus-visible': {
+    outline: "solid 2px ".concat("var(--ds-border-focused, ".concat(_colors.B100, ")"))
+  }
+});
+var headCellBaseStylesModernized = (0, _react2.css)({
   boxSizing: 'border-box',
   position: 'relative',
   border: 'none',
@@ -182,7 +197,7 @@ var HeadCell = exports.HeadCell = /*#__PURE__*/(0, _react.forwardRef)(function (
     style: mergedStyles,
     css: [
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
-    _constants2.cellStyles, headCellBaseStyles, onClick && onClickStyles,
+    _constants2.cellStyles, (0, _platformFeatureFlags.fg)('design_system_team_dynamic_table_typography') ? headCellBaseStylesModernized : headCellBaseStyles, onClick && onClickStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
     _constants2.truncationWidthStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766

package/dist/es2019/components/rankable/body.js

@@ -4,7 +4,7 @@ import React from 'react';
 
 // Allowing existing usage of non Pragmatic drag and drop solution
 // eslint-disable-next-line @atlaskit/design-system/no-unsupported-drag-and-drop-libraries
-import { DragDropContext, Droppable } from 'react-beautiful-dnd';
+import { DragDropContext, Droppable } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import withSortedPageRows from '../../hoc/with-sorted-page-rows';
 import TableRow from './table-row';
 // computes destination of ranking
@@ -105,7 +105,7 @@ export class RankableBody extends React.Component {
       row: row,
       isRankingDisabled: isRankingDisabled,
       isHighlighted: !!highlightedRowIndex && (typeof highlightedRowIndex === 'number' ? highlightedRowIndex === rowIndex : highlightedRowIndex.indexOf(rowIndex) > -1),
-      testId: testId && `${testId}--rankable--table--row`
+      testId: testId && `${testId}--${row.key}--rankable--table--row`
     })), provided.placeholder)));
   }
 }

package/dist/es2019/components/rankable/table-row.js

@@ -4,7 +4,7 @@ import React from 'react';
 
 // Allowing existing usage of non Pragmatic drag and drop solution
 // eslint-disable-next-line @atlaskit/design-system/no-unsupported-drag-and-drop-libraries
-import { Draggable } from 'react-beautiful-dnd';
+import { Draggable } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import withDimensions from '../../hoc/with-dimensions';
 import { inlineStylesIfRanking } from '../../internal/helpers';
 import { RankableTableBodyRow } from '../../styled/rankable/table-row';

package/dist/es2019/components/stateless.js

@@ -60,14 +60,14 @@ const DynamicTable = ({
     action: 'sorted',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   const onRankEnd = usePlatformLeafEventHandler({
     fn: providedOnRankEnd,
     action: 'ranked',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   useEffect(() => {
     validateSortKey(sortKey, head);

package/dist/es2019/styled/table-head.js

@@ -8,6 +8,7 @@ import { forwardRef } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { css, jsx } from '@emotion/react';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { B100, N30A } from '@atlaskit/theme/colors';
 import { ASC, DESC } from '../internal/constants';
 import { arrow, head, MSThemeColors, tableBorder } from '../theme';
@@ -31,6 +32,20 @@ export const Head = ({
   }, props));
 };
 const headCellBaseStyles = css({
+  boxSizing: 'border-box',
+  position: 'relative',
+  border: 'none',
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  borderBlockEnd: `2px solid ${tableBorder.borderColor}`,
+  color: `var(--ds-text-subtlest, ${`var(${CSS_VAR_TEXT_COLOR})`})`,
+  font: "var(--ds-font-heading-xxsmall, normal 600 12px/16px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, system-ui, \"Helvetica Neue\", sans-serif)",
+  textAlign: 'left',
+  verticalAlign: 'top',
+  '&:focus-visible': {
+    outline: `solid 2px ${`var(--ds-border-focused, ${B100})`}`
+  }
+});
+const headCellBaseStylesModernized = css({
   boxSizing: 'border-box',
   position: 'relative',
   border: 'none',
@@ -176,7 +191,7 @@ export const HeadCell = /*#__PURE__*/forwardRef(({
     style: mergedStyles,
     css: [
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
-    cellStyles, headCellBaseStyles, onClick && onClickStyles,
+    cellStyles, fg('design_system_team_dynamic_table_typography') ? headCellBaseStylesModernized : headCellBaseStyles, onClick && onClickStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
     truncationWidthStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766

package/dist/esm/components/rankable/body.js

@@ -12,7 +12,7 @@ import React from 'react';
 
 // Allowing existing usage of non Pragmatic drag and drop solution
 // eslint-disable-next-line @atlaskit/design-system/no-unsupported-drag-and-drop-libraries
-import { DragDropContext, Droppable } from 'react-beautiful-dnd';
+import { DragDropContext, Droppable } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import withSortedPageRows from '../../hoc/with-sorted-page-rows';
 import TableRow from './table-row';
 // computes destination of ranking
@@ -109,7 +109,7 @@ export var RankableBody = /*#__PURE__*/function (_React$Component) {
             row: row,
             isRankingDisabled: isRankingDisabled,
             isHighlighted: !!highlightedRowIndex && (typeof highlightedRowIndex === 'number' ? highlightedRowIndex === rowIndex : highlightedRowIndex.indexOf(rowIndex) > -1),
-            testId: testId && "".concat(testId, "--rankable--table--row")
+            testId: testId && "".concat(testId, "--").concat(row.key, "--rankable--table--row")
           });
         }), provided.placeholder);
       }));

package/dist/esm/components/rankable/table-row.js

@@ -16,7 +16,7 @@ import React from 'react';
 
 // Allowing existing usage of non Pragmatic drag and drop solution
 // eslint-disable-next-line @atlaskit/design-system/no-unsupported-drag-and-drop-libraries
-import { Draggable } from 'react-beautiful-dnd';
+import { Draggable } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import withDimensions from '../../hoc/with-dimensions';
 import { inlineStylesIfRanking } from '../../internal/helpers';
 import { RankableTableBodyRow } from '../../styled/rankable/table-row';

package/dist/esm/components/stateless.js

@@ -76,14 +76,14 @@ var DynamicTable = function DynamicTable(_ref) {
     action: 'sorted',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   var onRankEnd = usePlatformLeafEventHandler({
     fn: providedOnRankEnd,
     action: 'ranked',
     componentName: 'dynamicTable',
     packageName: "@atlaskit/dynamic-table",
-    packageVersion: "15.2.0"
+    packageVersion: "16.0.0"
   });
   useEffect(function () {
     validateSortKey(sortKey, head);

package/dist/esm/styled/table-head.js

@@ -14,6 +14,7 @@ import { forwardRef } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { css, jsx } from '@emotion/react';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { B100, N30A } from '@atlaskit/theme/colors';
 import { ASC, DESC } from '../internal/constants';
 import { arrow, head, MSThemeColors, tableBorder } from '../theme';
@@ -36,6 +37,20 @@ export var Head = function Head(_ref) {
   }, props));
 };
 var headCellBaseStyles = css({
+  boxSizing: 'border-box',
+  position: 'relative',
+  border: 'none',
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/ui-styling-standard/no-unsafe-values -- Ignored via go/DSP-18766
+  borderBlockEnd: "2px solid ".concat(tableBorder.borderColor),
+  color: "var(--ds-text-subtlest, ".concat("var(".concat(CSS_VAR_TEXT_COLOR, ")"), ")"),
+  font: "var(--ds-font-heading-xxsmall, normal 600 12px/16px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, system-ui, \"Helvetica Neue\", sans-serif)",
+  textAlign: 'left',
+  verticalAlign: 'top',
+  '&:focus-visible': {
+    outline: "solid 2px ".concat("var(--ds-border-focused, ".concat(B100, ")"))
+  }
+});
+var headCellBaseStylesModernized = css({
   boxSizing: 'border-box',
   position: 'relative',
   border: 'none',
@@ -176,7 +191,7 @@ export var HeadCell = /*#__PURE__*/forwardRef(function (_ref2, ref) {
     style: mergedStyles,
     css: [
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
-    cellStyles, headCellBaseStyles, onClick && onClickStyles,
+    cellStyles, fg('design_system_team_dynamic_table_typography') ? headCellBaseStylesModernized : headCellBaseStyles, onClick && onClickStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
     truncationWidthStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766

package/dist/types/components/rankable/body.d.ts

@@ -1,5 +1,5 @@
 import React from 'react';
-import { type DragStart, type DropResult } from 'react-beautiful-dnd';
+import { type DragStart, type DropResult } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import { type WithSortedPageRowsProps } from '../../hoc/with-sorted-page-rows';
 import { type HeadType, type RankEnd, type RankStart } from '../../types';
 export interface RankableBodyProps extends WithSortedPageRowsProps {

package/dist/types-ts4.5/components/rankable/body.d.ts

@@ -1,5 +1,5 @@
 import React from 'react';
-import { type DragStart, type DropResult } from 'react-beautiful-dnd';
+import { type DragStart, type DropResult } from '@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration';
 import { type WithSortedPageRowsProps } from '../../hoc/with-sorted-page-rows';
 import { type HeadType, type RankEnd, type RankStart } from '../../types';
 export interface RankableBodyProps extends WithSortedPageRowsProps {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/dynamic-table",
-	"version": "15.2.0",
+	"version": "16.0.0",
 	"description": "A dynamic table displays rows of data with built-in pagination, sorting, and re-ordering functionality.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -38,8 +38,10 @@
 	},
 	"dependencies": {
 		"@atlaskit/analytics-next": "^10.1.0",
-		"@atlaskit/ds-lib": "^3.0.0",
+		"@atlaskit/ds-lib": "^3.1.0",
 		"@atlaskit/pagination": "^14.9.0",
+		"@atlaskit/platform-feature-flags": "^0.3.0",
+		"@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration": "^1.2.1",
 		"@atlaskit/spinner": "^16.3.0",
 		"@atlaskit/theme": "^13.0.0",
 		"@atlaskit/tokens": "^2.0.0",
@@ -81,5 +83,10 @@
 				"emotion"
 			]
 		}
+	},
+	"platform-feature-flags": {
+		"design_system_team_dynamic_table_typography": {
+			"type": "boolean"
+		}
 	}
 }