@atlaskit/dynamic-table 14.8.15 → 14.8.17

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,17 @@
1
1
  # @atlaskit/dynamic-table
2
2
 
3
+ ## 14.8.17
4
+
5
+ ### Patch Changes
6
+
7
+ - [`cdb1910463d`](https://bitbucket.org/atlassian/atlassian-frontend/commits/cdb1910463d) - [ux] Adds buttons to sortable table head cells for better accessibility for keyboard and assistive technology users.
8
+
9
+ ## 14.8.16
10
+
11
+ ### Patch Changes
12
+
13
+ - [`4ba10567310`](https://bitbucket.org/atlassian/atlassian-frontend/commits/4ba10567310) - Internal changes.
14
+
3
15
  ## 14.8.15
4
16
 
5
17
  ### Patch Changes
@@ -29,7 +29,7 @@ var _tableHead = _interopRequireDefault(require("./table-head"));
29
29
  function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
30
30
  function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
31
31
  var packageName = "@atlaskit/dynamic-table";
32
- var packageVersion = "14.8.15";
32
+ var packageVersion = "14.8.17";
33
33
  function toggleSortOrder(currentSortOrder) {
34
34
  switch (currentSortOrder) {
35
35
  case _constants.DESC:
@@ -227,7 +227,7 @@ var DynamicTable = /*#__PURE__*/function (_React$Component) {
227
227
  sortKey: sortKey,
228
228
  sortOrder: sortOrder,
229
229
  isRanking: this.state.isRanking,
230
- isRankable: canRank,
230
+ isRankable: isRankable,
231
231
  testId: testId
232
232
  }), rowsExist && (canRank ? /*#__PURE__*/_react.default.createElement(_body2.default, (0, _extends2.default)({}, bodyProps, {
233
233
  isRanking: this.state.isRanking,
@@ -9,7 +9,7 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
9
9
  var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
10
10
  var _react = _interopRequireDefault(require("react"));
11
11
  var _tableHead = require("../styled/table-head");
12
- var _excluded = ["content", "inlineStyles", "testId", "isRanking", "innerRef", "isSortable"];
12
+ var _excluded = ["content", "inlineStyles", "testId", "isRanking", "innerRef", "isSortable", "onClick"];
13
13
  var TableHeadCell = function TableHeadCell(_ref) {
14
14
  var content = _ref.content,
15
15
  inlineStyles = _ref.inlineStyles,
@@ -17,6 +17,7 @@ var TableHeadCell = function TableHeadCell(_ref) {
17
17
  isRanking = _ref.isRanking,
18
18
  innerRef = _ref.innerRef,
19
19
  isSortable = _ref.isSortable,
20
+ onClick = _ref.onClick,
20
21
  rest = (0, _objectWithoutProperties2.default)(_ref, _excluded);
21
22
  return /*#__PURE__*/_react.default.createElement(_tableHead.HeadCell, (0, _extends2.default)({
22
23
  style: inlineStyles,
@@ -24,9 +25,12 @@ var TableHeadCell = function TableHeadCell(_ref) {
24
25
  ref: typeof innerRef !== 'string' ? innerRef : null // string refs must be discarded as LegacyRefs are not compatible with FC forwardRefs
25
26
  // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
26
27
  }, rest, {
27
- tabIndex: isSortable ? 0 : undefined,
28
+ onClick: onClick,
28
29
  isSortable: isSortable
29
- }), /*#__PURE__*/_react.default.createElement("span", null, content));
30
+ }), isSortable ? /*#__PURE__*/_react.default.createElement("button", {
31
+ type: "button",
32
+ "aria-roledescription": "Sort button"
33
+ }, content) : /*#__PURE__*/_react.default.createElement("span", null, content));
30
34
  };
31
35
 
32
36
  // eslint-disable-next-line @repo/internal/react/require-jsdoc
@@ -9,11 +9,9 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
9
9
  var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
10
10
  var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
11
11
  var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
12
- var _assertThisInitialized2 = _interopRequireDefault(require("@babel/runtime/helpers/assertThisInitialized"));
13
12
  var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
14
13
  var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime/helpers/possibleConstructorReturn"));
15
14
  var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
16
- var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
17
15
  var _react = _interopRequireDefault(require("react"));
18
16
  var _helpers = require("../internal/helpers");
19
17
  var _tableHead = require("../styled/table-head");
@@ -27,16 +25,8 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
27
25
  (0, _inherits2.default)(TableHead, _React$Component);
28
26
  var _super = _createSuper(TableHead);
29
27
  function TableHead() {
30
- var _this;
31
28
  (0, _classCallCheck2.default)(this, TableHead);
32
- for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
33
- args[_key] = arguments[_key];
34
- }
35
- _this = _super.call.apply(_super, [this].concat(args));
36
- (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "canSortOnEnterPressed", function (e, isSortable) {
37
- return isSortable && e.key === 'Enter';
38
- });
39
- return _this;
29
+ return _super.apply(this, arguments);
40
30
  }
41
31
  (0, _createClass2.default)(TableHead, [{
42
32
  key: "UNSAFE_componentWillMount",
@@ -53,7 +43,6 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
53
43
  }, {
54
44
  key: "render",
55
45
  value: function render() {
56
- var _this2 = this;
57
46
  var _this$props = this.props,
58
47
  head = _this$props.head,
59
48
  sortKey = _this$props.sortKey,
@@ -94,9 +83,6 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
94
83
  isRanking: isRanking,
95
84
  key: key || index,
96
85
  onClick: isSortable ? onSort(cell) : undefined,
97
- onKeyDown: function onKeyDown(e) {
98
- return _this2.canSortOnEnterPressed(e, isSortable) ? onSort(cell)() : undefined;
99
- },
100
86
  testId: cellTestId || testId,
101
87
  shouldTruncate: shouldTruncate,
102
88
  sortOrder: key === sortKey ? sortOrder : undefined,
@@ -33,10 +33,7 @@ exports.Container = Container;
33
33
  var spinnerBackdropStyles = (0, _react2.css)({
34
34
  display: 'flex',
35
35
  position: 'absolute',
36
- top: 0,
37
- right: 0,
38
- bottom: 0,
39
- left: 0,
36
+ inset: 0,
40
37
  alignItems: 'center',
41
38
  justifyContent: 'center',
42
39
  pointerEvents: 'none'
@@ -52,6 +49,7 @@ var SpinnerBackdrop = function SpinnerBackdrop(_ref) {
52
49
  exports.SpinnerBackdrop = SpinnerBackdrop;
53
50
  var spinnerContainerStyles = (0, _react2.css)({
54
51
  position: 'relative',
52
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
55
53
  top: 0
56
54
  });
57
55
  var SpinnerContainer = /*#__PURE__*/(0, _react.forwardRef)(function (_ref2, ref) {
@@ -42,10 +42,7 @@ exports.ContentsContainer = ContentsContainer;
42
42
  var spinnerContainerStyles = (0, _react.css)({
43
43
  display: 'flex',
44
44
  position: 'absolute',
45
- top: 0,
46
- right: 0,
47
- bottom: 0,
48
- left: 0,
45
+ inset: 0,
49
46
  alignItems: 'center',
50
47
  justifyContent: 'center'
51
48
  });
@@ -62,28 +62,39 @@ var onClickStyles = (0, _react2.css)({
62
62
  }
63
63
  });
64
64
  var baseStyles = (0, _react2.css)({
65
- '& > span': {
65
+ '& > button': {
66
+ padding: "var(--ds-space-0, 0)",
66
67
  position: 'relative',
68
+ appearance: 'none',
69
+ background: 'none',
70
+ border: 'none',
71
+ color: 'inherit',
72
+ cursor: 'inherit',
73
+ fontSize: 'inherit',
74
+ fontWeight: 'inherit',
67
75
  '&::before, &::after': {
68
76
  display: 'block',
69
77
  width: 0,
70
78
  height: 0,
71
79
  position: 'absolute',
80
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
72
81
  right: "-".concat(gridSize, "px"),
73
82
  border: '3px solid transparent',
74
83
  content: '""'
75
84
  },
76
85
  '&::before': {
86
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
77
87
  bottom: '8px',
78
88
  borderBottom: "3px solid ".concat(_theme.arrow.defaultColor)
79
89
  },
80
90
  '&::after': {
91
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
81
92
  bottom: 0,
82
93
  borderTop: "3px solid ".concat(_theme.arrow.defaultColor)
83
94
  }
84
95
  },
85
96
  '@media (forced-colors: active)': {
86
- '& > span': {
97
+ '& > button': {
87
98
  '&::before, &::after': {
88
99
  border: "3px solid ".concat(_theme.MSThemeColors.Background)
89
100
  },
@@ -97,13 +108,13 @@ var baseStyles = (0, _react2.css)({
97
108
  }
98
109
  });
99
110
  var ascendingStyles = (0, _react2.css)({
100
- '& > span': {
111
+ '& > button': {
101
112
  '&::before': {
102
113
  borderBottom: "3px solid ".concat(_theme.arrow.selectedColor)
103
114
  }
104
115
  },
105
116
  '@media (forced-colors: active)': {
106
- '& > span': {
117
+ '& > button': {
107
118
  '&::before': {
108
119
  borderBottom: "3px solid ".concat(_theme.MSThemeColors.SelectedBackground)
109
120
  }
@@ -111,13 +122,13 @@ var ascendingStyles = (0, _react2.css)({
111
122
  }
112
123
  });
113
124
  var descendingStyles = (0, _react2.css)({
114
- '& > span': {
125
+ '& > button': {
115
126
  '&::after': {
116
127
  borderTop: "3px solid ".concat(_theme.arrow.selectedColor)
117
128
  }
118
129
  },
119
130
  '@media (forced-colors: active)': {
120
- '& > span': {
131
+ '& > button': {
121
132
  '&::after': {
122
133
  borderTop: "3px solid ".concat(_theme.MSThemeColors.SelectedBackground)
123
134
  }
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/dynamic-table",
3
- "version": "14.8.15",
3
+ "version": "14.8.17",
4
4
  "sideEffects": false
5
5
  }
@@ -14,7 +14,7 @@ import ManagedPagination from './managed-pagination';
14
14
  import RankableTableBody from './rankable/body';
15
15
  import TableHead from './table-head';
16
16
  const packageName = "@atlaskit/dynamic-table";
17
- const packageVersion = "14.8.15";
17
+ const packageVersion = "14.8.17";
18
18
  function toggleSortOrder(currentSortOrder) {
19
19
  switch (currentSortOrder) {
20
20
  case DESC:
@@ -201,7 +201,7 @@ class DynamicTable extends React.Component {
201
201
  sortKey: sortKey,
202
202
  sortOrder: sortOrder,
203
203
  isRanking: this.state.isRanking,
204
- isRankable: canRank,
204
+ isRankable: isRankable,
205
205
  testId: testId
206
206
  }), rowsExist && (canRank ? /*#__PURE__*/React.createElement(RankableTableBody, _extends({}, bodyProps, {
207
207
  isRanking: this.state.isRanking,
@@ -8,6 +8,7 @@ const TableHeadCell = ({
8
8
  isRanking,
9
9
  innerRef,
10
10
  isSortable,
11
+ onClick,
11
12
  ...rest
12
13
  }) => {
13
14
  return /*#__PURE__*/React.createElement(HeadCell, _extends({
@@ -16,9 +17,12 @@ const TableHeadCell = ({
16
17
  ref: typeof innerRef !== 'string' ? innerRef : null // string refs must be discarded as LegacyRefs are not compatible with FC forwardRefs
17
18
  // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
18
19
  }, rest, {
19
- tabIndex: isSortable ? 0 : undefined,
20
+ onClick: onClick,
20
21
  isSortable: isSortable
21
- }), /*#__PURE__*/React.createElement("span", null, content));
22
+ }), isSortable ? /*#__PURE__*/React.createElement("button", {
23
+ type: "button",
24
+ "aria-roledescription": "Sort button"
25
+ }, content) : /*#__PURE__*/React.createElement("span", null, content));
22
26
  };
23
27
 
24
28
  // eslint-disable-next-line @repo/internal/react/require-jsdoc
@@ -1,15 +1,10 @@
1
1
  import _extends from "@babel/runtime/helpers/extends";
2
- import _defineProperty from "@babel/runtime/helpers/defineProperty";
3
2
  import React from 'react';
4
3
  import { validateSortKey } from '../internal/helpers';
5
4
  import { Head } from '../styled/table-head';
6
5
  import RankableHeadCell from './rankable/table-head-cell';
7
6
  import HeadCell from './table-head-cell';
8
7
  class TableHead extends React.Component {
9
- constructor(...args) {
10
- super(...args);
11
- _defineProperty(this, "canSortOnEnterPressed", (e, isSortable) => isSortable && e.key === 'Enter');
12
- }
13
8
  UNSAFE_componentWillMount() {
14
9
  validateSortKey(this.props.sortKey, this.props.head);
15
10
  }
@@ -66,7 +61,6 @@ class TableHead extends React.Component {
66
61
  isRanking: isRanking,
67
62
  key: key || index,
68
63
  onClick: isSortable ? onSort(cell) : undefined,
69
- onKeyDown: e => this.canSortOnEnterPressed(e, isSortable) ? onSort(cell)() : undefined,
70
64
  testId: cellTestId || testId,
71
65
  shouldTruncate: shouldTruncate,
72
66
  sortOrder: key === sortKey ? sortOrder : undefined,
@@ -25,10 +25,7 @@ export const Container = props => {
25
25
  const spinnerBackdropStyles = css({
26
26
  display: 'flex',
27
27
  position: 'absolute',
28
- top: 0,
29
- right: 0,
30
- bottom: 0,
31
- left: 0,
28
+ inset: 0,
32
29
  alignItems: 'center',
33
30
  justifyContent: 'center',
34
31
  pointerEvents: 'none'
@@ -42,6 +39,7 @@ export const SpinnerBackdrop = ({
42
39
  }, children);
43
40
  const spinnerContainerStyles = css({
44
41
  position: 'relative',
42
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
45
43
  top: 0
46
44
  });
47
45
  export const SpinnerContainer = /*#__PURE__*/forwardRef(({
@@ -31,10 +31,7 @@ export const ContentsContainer = ({
31
31
  const spinnerContainerStyles = css({
32
32
  display: 'flex',
33
33
  position: 'absolute',
34
- top: 0,
35
- right: 0,
36
- bottom: 0,
37
- left: 0,
34
+ inset: 0,
38
35
  alignItems: 'center',
39
36
  justifyContent: 'center'
40
37
  });
@@ -49,28 +49,39 @@ const onClickStyles = css({
49
49
  }
50
50
  });
51
51
  const baseStyles = css({
52
- '& > span': {
52
+ '& > button': {
53
+ padding: "var(--ds-space-0, 0)",
53
54
  position: 'relative',
55
+ appearance: 'none',
56
+ background: 'none',
57
+ border: 'none',
58
+ color: 'inherit',
59
+ cursor: 'inherit',
60
+ fontSize: 'inherit',
61
+ fontWeight: 'inherit',
54
62
  '&::before, &::after': {
55
63
  display: 'block',
56
64
  width: 0,
57
65
  height: 0,
58
66
  position: 'absolute',
67
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
59
68
  right: `-${gridSize}px`,
60
69
  border: '3px solid transparent',
61
70
  content: '""'
62
71
  },
63
72
  '&::before': {
73
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
64
74
  bottom: '8px',
65
75
  borderBottom: `3px solid ${arrow.defaultColor}`
66
76
  },
67
77
  '&::after': {
78
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
68
79
  bottom: 0,
69
80
  borderTop: `3px solid ${arrow.defaultColor}`
70
81
  }
71
82
  },
72
83
  '@media (forced-colors: active)': {
73
- '& > span': {
84
+ '& > button': {
74
85
  '&::before, &::after': {
75
86
  border: `3px solid ${MSThemeColors.Background}`
76
87
  },
@@ -84,13 +95,13 @@ const baseStyles = css({
84
95
  }
85
96
  });
86
97
  const ascendingStyles = css({
87
- '& > span': {
98
+ '& > button': {
88
99
  '&::before': {
89
100
  borderBottom: `3px solid ${arrow.selectedColor}`
90
101
  }
91
102
  },
92
103
  '@media (forced-colors: active)': {
93
- '& > span': {
104
+ '& > button': {
94
105
  '&::before': {
95
106
  borderBottom: `3px solid ${MSThemeColors.SelectedBackground}`
96
107
  }
@@ -98,13 +109,13 @@ const ascendingStyles = css({
98
109
  }
99
110
  });
100
111
  const descendingStyles = css({
101
- '& > span': {
112
+ '& > button': {
102
113
  '&::after': {
103
114
  borderTop: `3px solid ${arrow.selectedColor}`
104
115
  }
105
116
  },
106
117
  '@media (forced-colors: active)': {
107
- '& > span': {
118
+ '& > button': {
108
119
  '&::after': {
109
120
  borderTop: `3px solid ${MSThemeColors.SelectedBackground}`
110
121
  }
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/dynamic-table",
3
- "version": "14.8.15",
3
+ "version": "14.8.17",
4
4
  "sideEffects": false
5
5
  }
@@ -22,7 +22,7 @@ import ManagedPagination from './managed-pagination';
22
22
  import RankableTableBody from './rankable/body';
23
23
  import TableHead from './table-head';
24
24
  var packageName = "@atlaskit/dynamic-table";
25
- var packageVersion = "14.8.15";
25
+ var packageVersion = "14.8.17";
26
26
  function toggleSortOrder(currentSortOrder) {
27
27
  switch (currentSortOrder) {
28
28
  case DESC:
@@ -220,7 +220,7 @@ var DynamicTable = /*#__PURE__*/function (_React$Component) {
220
220
  sortKey: sortKey,
221
221
  sortOrder: sortOrder,
222
222
  isRanking: this.state.isRanking,
223
- isRankable: canRank,
223
+ isRankable: isRankable,
224
224
  testId: testId
225
225
  }), rowsExist && (canRank ? /*#__PURE__*/React.createElement(RankableTableBody, _extends({}, bodyProps, {
226
226
  isRanking: this.state.isRanking,
@@ -1,6 +1,6 @@
1
1
  import _extends from "@babel/runtime/helpers/extends";
2
2
  import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
3
- var _excluded = ["content", "inlineStyles", "testId", "isRanking", "innerRef", "isSortable"];
3
+ var _excluded = ["content", "inlineStyles", "testId", "isRanking", "innerRef", "isSortable", "onClick"];
4
4
  import React from 'react';
5
5
  import { HeadCell } from '../styled/table-head';
6
6
  var TableHeadCell = function TableHeadCell(_ref) {
@@ -10,6 +10,7 @@ var TableHeadCell = function TableHeadCell(_ref) {
10
10
  isRanking = _ref.isRanking,
11
11
  innerRef = _ref.innerRef,
12
12
  isSortable = _ref.isSortable,
13
+ onClick = _ref.onClick,
13
14
  rest = _objectWithoutProperties(_ref, _excluded);
14
15
  return /*#__PURE__*/React.createElement(HeadCell, _extends({
15
16
  style: inlineStyles,
@@ -17,9 +18,12 @@ var TableHeadCell = function TableHeadCell(_ref) {
17
18
  ref: typeof innerRef !== 'string' ? innerRef : null // string refs must be discarded as LegacyRefs are not compatible with FC forwardRefs
18
19
  // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
19
20
  }, rest, {
20
- tabIndex: isSortable ? 0 : undefined,
21
+ onClick: onClick,
21
22
  isSortable: isSortable
22
- }), /*#__PURE__*/React.createElement("span", null, content));
23
+ }), isSortable ? /*#__PURE__*/React.createElement("button", {
24
+ type: "button",
25
+ "aria-roledescription": "Sort button"
26
+ }, content) : /*#__PURE__*/React.createElement("span", null, content));
23
27
  };
24
28
 
25
29
  // eslint-disable-next-line @repo/internal/react/require-jsdoc
@@ -2,11 +2,9 @@ import _extends from "@babel/runtime/helpers/extends";
2
2
  import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
3
3
  import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
4
4
  import _createClass from "@babel/runtime/helpers/createClass";
5
- import _assertThisInitialized from "@babel/runtime/helpers/assertThisInitialized";
6
5
  import _inherits from "@babel/runtime/helpers/inherits";
7
6
  import _possibleConstructorReturn from "@babel/runtime/helpers/possibleConstructorReturn";
8
7
  import _getPrototypeOf from "@babel/runtime/helpers/getPrototypeOf";
9
- import _defineProperty from "@babel/runtime/helpers/defineProperty";
10
8
  var _excluded = ["cells"],
11
9
  _excluded2 = ["colSpan", "content", "isSortable", "key", "shouldTruncate", "testId", "width"];
12
10
  function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
@@ -20,16 +18,8 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
20
18
  _inherits(TableHead, _React$Component);
21
19
  var _super = _createSuper(TableHead);
22
20
  function TableHead() {
23
- var _this;
24
21
  _classCallCheck(this, TableHead);
25
- for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
26
- args[_key] = arguments[_key];
27
- }
28
- _this = _super.call.apply(_super, [this].concat(args));
29
- _defineProperty(_assertThisInitialized(_this), "canSortOnEnterPressed", function (e, isSortable) {
30
- return isSortable && e.key === 'Enter';
31
- });
32
- return _this;
22
+ return _super.apply(this, arguments);
33
23
  }
34
24
  _createClass(TableHead, [{
35
25
  key: "UNSAFE_componentWillMount",
@@ -46,7 +36,6 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
46
36
  }, {
47
37
  key: "render",
48
38
  value: function render() {
49
- var _this2 = this;
50
39
  var _this$props = this.props,
51
40
  head = _this$props.head,
52
41
  sortKey = _this$props.sortKey,
@@ -87,9 +76,6 @@ var TableHead = /*#__PURE__*/function (_React$Component) {
87
76
  isRanking: isRanking,
88
77
  key: key || index,
89
78
  onClick: isSortable ? onSort(cell) : undefined,
90
- onKeyDown: function onKeyDown(e) {
91
- return _this2.canSortOnEnterPressed(e, isSortable) ? onSort(cell)() : undefined;
92
- },
93
79
  testId: cellTestId || testId,
94
80
  shouldTruncate: shouldTruncate,
95
81
  sortOrder: key === sortKey ? sortOrder : undefined,
@@ -25,10 +25,7 @@ export var Container = function Container(props) {
25
25
  var spinnerBackdropStyles = css({
26
26
  display: 'flex',
27
27
  position: 'absolute',
28
- top: 0,
29
- right: 0,
30
- bottom: 0,
31
- left: 0,
28
+ inset: 0,
32
29
  alignItems: 'center',
33
30
  justifyContent: 'center',
34
31
  pointerEvents: 'none'
@@ -43,6 +40,7 @@ export var SpinnerBackdrop = function SpinnerBackdrop(_ref) {
43
40
  };
44
41
  var spinnerContainerStyles = css({
45
42
  position: 'relative',
43
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
46
44
  top: 0
47
45
  });
48
46
  export var SpinnerContainer = /*#__PURE__*/forwardRef(function (_ref2, ref) {
@@ -32,10 +32,7 @@ export var ContentsContainer = function ContentsContainer(_ref2) {
32
32
  var spinnerContainerStyles = css({
33
33
  display: 'flex',
34
34
  position: 'absolute',
35
- top: 0,
36
- right: 0,
37
- bottom: 0,
38
- left: 0,
35
+ inset: 0,
39
36
  alignItems: 'center',
40
37
  justifyContent: 'center'
41
38
  });
@@ -54,28 +54,39 @@ var onClickStyles = css({
54
54
  }
55
55
  });
56
56
  var baseStyles = css({
57
- '& > span': {
57
+ '& > button': {
58
+ padding: "var(--ds-space-0, 0)",
58
59
  position: 'relative',
60
+ appearance: 'none',
61
+ background: 'none',
62
+ border: 'none',
63
+ color: 'inherit',
64
+ cursor: 'inherit',
65
+ fontSize: 'inherit',
66
+ fontWeight: 'inherit',
59
67
  '&::before, &::after': {
60
68
  display: 'block',
61
69
  width: 0,
62
70
  height: 0,
63
71
  position: 'absolute',
72
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
64
73
  right: "-".concat(gridSize, "px"),
65
74
  border: '3px solid transparent',
66
75
  content: '""'
67
76
  },
68
77
  '&::before': {
78
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
69
79
  bottom: '8px',
70
80
  borderBottom: "3px solid ".concat(arrow.defaultColor)
71
81
  },
72
82
  '&::after': {
83
+ // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage-spacing
73
84
  bottom: 0,
74
85
  borderTop: "3px solid ".concat(arrow.defaultColor)
75
86
  }
76
87
  },
77
88
  '@media (forced-colors: active)': {
78
- '& > span': {
89
+ '& > button': {
79
90
  '&::before, &::after': {
80
91
  border: "3px solid ".concat(MSThemeColors.Background)
81
92
  },
@@ -89,13 +100,13 @@ var baseStyles = css({
89
100
  }
90
101
  });
91
102
  var ascendingStyles = css({
92
- '& > span': {
103
+ '& > button': {
93
104
  '&::before': {
94
105
  borderBottom: "3px solid ".concat(arrow.selectedColor)
95
106
  }
96
107
  },
97
108
  '@media (forced-colors: active)': {
98
- '& > span': {
109
+ '& > button': {
99
110
  '&::before': {
100
111
  borderBottom: "3px solid ".concat(MSThemeColors.SelectedBackground)
101
112
  }
@@ -103,13 +114,13 @@ var ascendingStyles = css({
103
114
  }
104
115
  });
105
116
  var descendingStyles = css({
106
- '& > span': {
117
+ '& > button': {
107
118
  '&::after': {
108
119
  borderTop: "3px solid ".concat(arrow.selectedColor)
109
120
  }
110
121
  },
111
122
  '@media (forced-colors: active)': {
112
- '& > span': {
123
+ '& > button': {
113
124
  '&::after': {
114
125
  borderTop: "3px solid ".concat(MSThemeColors.SelectedBackground)
115
126
  }
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/dynamic-table",
3
- "version": "14.8.15",
3
+ "version": "14.8.17",
4
4
  "sideEffects": false
5
5
  }
@@ -1,4 +1,4 @@
1
- import React, { FC, KeyboardEvent, LegacyRef } from 'react';
1
+ import React, { FC, LegacyRef } from 'react';
2
2
  import { SortOrderType } from '../types';
3
3
  export interface TableHeadCellProps {
4
4
  colSpan?: number;
@@ -10,7 +10,6 @@ export interface TableHeadCellProps {
10
10
  inlineStyles?: {};
11
11
  content?: React.ReactNode;
12
12
  onClick?: () => void;
13
- onKeyDown?: (e: KeyboardEvent) => void;
14
13
  shouldTruncate?: boolean;
15
14
  testId?: string;
16
15
  width?: number;
@@ -1,4 +1,4 @@
1
- import React, { KeyboardEvent } from 'react';
1
+ import React from 'react';
2
2
  import { HeadType, RowCellType, SortOrderType } from '../types';
3
3
  interface TableHeadProps {
4
4
  head: HeadType;
@@ -13,7 +13,6 @@ interface TableHeadProps {
13
13
  declare class TableHead extends React.Component<TableHeadProps, {}> {
14
14
  UNSAFE_componentWillMount(): void;
15
15
  UNSAFE_componentWillReceiveProps(nextProps: TableHeadProps): void;
16
- canSortOnEnterPressed: (e: KeyboardEvent, isSortable: Boolean | void) => boolean | void;
17
16
  render(): JSX.Element | null;
18
17
  }
19
18
  export default TableHead;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/dynamic-table",
3
- "version": "14.8.15",
3
+ "version": "14.8.17",
4
4
  "description": "A dynamic table displays rows of data with built-in pagination, sorting, and re-ordering functionality.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"