@atlaskit/dropdown-menu 12.21.0 → 12.21.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/dropdown-menu
 
+## 12.21.1
+
+### Patch Changes
+
+- [#157534](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/157534)
+  [`ca0824645f3a5`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/ca0824645f3a5) -
+  Remove the use of Math.random for the generation of IDs
+
 ## 12.21.0
 
 ### Minor Changes

package/dist/cjs/internal/utils/use-generated-id.js

@@ -5,22 +5,14 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.PREFIX = void 0;
 exports.default = useGeneratedId;
-var _react = require("react");
+var _useId = require("@atlaskit/ds-lib/use-id");
 var PREFIX = exports.PREFIX = 'ds--dropdown--';
-var generateRandomString = function generateRandomString() {
-  return (// This string is used only on client side usually triggered after a user interaction.
-    // Therefore, so there is no risk of mismatch
-    // between server and client generated markup.
-    // eslint-disable-next-line @repo/internal/react/disallow-unstable-values
-    "".concat(PREFIX).concat(Math.random().toString(16).substr(2, 8))
-  );
-};
 
 /**
  * useGeneratedId generates a random string which remains constant across
  * renders when called without any parameter.
  */
 function useGeneratedId() {
-  var cachedId = (0, _react.useRef)(generateRandomString());
-  return cachedId.current;
+  var id = (0, _useId.useId)();
+  return "".concat(PREFIX).concat(id);
 }

package/dist/es2019/internal/utils/use-generated-id.js

@@ -1,17 +1,11 @@
-import { useRef } from 'react';
+import { useId } from '@atlaskit/ds-lib/use-id';
 export const PREFIX = 'ds--dropdown--';
-const generateRandomString = () =>
-// This string is used only on client side usually triggered after a user interaction.
-// Therefore, so there is no risk of mismatch
-// between server and client generated markup.
-// eslint-disable-next-line @repo/internal/react/disallow-unstable-values
-`${PREFIX}${Math.random().toString(16).substr(2, 8)}`;
 
 /**
  * useGeneratedId generates a random string which remains constant across
  * renders when called without any parameter.
  */
 export default function useGeneratedId() {
-  const cachedId = useRef(generateRandomString());
-  return cachedId.current;
+  const id = useId();
+  return `${PREFIX}${id}`;
 }

package/dist/esm/internal/utils/use-generated-id.js

@@ -1,19 +1,11 @@
-import { useRef } from 'react';
+import { useId } from '@atlaskit/ds-lib/use-id';
 export var PREFIX = 'ds--dropdown--';
-var generateRandomString = function generateRandomString() {
-  return (// This string is used only on client side usually triggered after a user interaction.
-    // Therefore, so there is no risk of mismatch
-    // between server and client generated markup.
-    // eslint-disable-next-line @repo/internal/react/disallow-unstable-values
-    "".concat(PREFIX).concat(Math.random().toString(16).substr(2, 8))
-  );
-};
 
 /**
  * useGeneratedId generates a random string which remains constant across
  * renders when called without any parameter.
  */
 export default function useGeneratedId() {
-  var cachedId = useRef(generateRandomString());
-  return cachedId.current;
+  var id = useId();
+  return "".concat(PREFIX).concat(id);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/dropdown-menu",
-	"version": "12.21.0",
+	"version": "12.21.1",
 	"description": "A dropdown menu displays a list of actions or options to a user.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -26,7 +26,7 @@
 		"@atlaskit/button": "^20.3.0",
 		"@atlaskit/codemod-utils": "^4.2.0",
 		"@atlaskit/ds-lib": "^3.1.0",
-		"@atlaskit/icon": "^22.23.0",
+		"@atlaskit/icon": "^22.24.0",
 		"@atlaskit/layering": "^0.7.0",
 		"@atlaskit/menu": "^2.13.0",
 		"@atlaskit/platform-feature-flags": "^0.3.0",