@atlaskit/dropdown-menu 11.3.0 → 11.3.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/dropdown-menu
 
+## 11.3.1
+
+### Patch Changes
+
+- [`61d8af6f398`](https://bitbucket.org/atlassian/atlassian-frontend/commits/61d8af6f398) - Adjusted the fallback placements for dropdown-menu to reduce how frequently the menu jumps while scrolling
+
 ## 11.3.0
 
 ### Minor Changes

package/dist/cjs/dropdown-menu.js

@@ -63,7 +63,31 @@ var spinnerContainerStyles = (0, _core.css)({
   justifyContent: 'center'
 });
 var MAX_HEIGHT = "calc(100vh - ".concat(gridSize * 2, "px)");
-var fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start', 'auto'];
+var opposites = {
+  top: 'bottom',
+  bottom: 'top',
+  left: 'right',
+  right: 'left',
+  start: 'end',
+  auto: 'auto',
+  end: 'start'
+};
+
+var getFallbackPlacements = function getFallbackPlacements(placement) {
+  var placementPieces = placement.split('-');
+  var mainAxis = placementPieces[0]; // Left, right and auto placements can rely on standard popper sliding behaviour
+
+  if (!['top', 'bottom'].includes(mainAxis)) {
+    return undefined;
+  } // Top and bottom placements need to flip to the right/left to ensure
+  // long lists don't extend off the screen
+  else if (placementPieces.length === 2 && ['start', 'end'].includes(placementPieces[1])) {
+    var crossAxis = placementPieces[1];
+    return ["".concat(mainAxis), "".concat(mainAxis, "-").concat(opposites[crossAxis]), "".concat(opposites[mainAxis], "-").concat(crossAxis), "".concat(opposites[mainAxis]), "".concat(opposites[mainAxis], "-").concat(opposites[crossAxis]), 'auto'];
+  } else {
+    return ["".concat(mainAxis, "-start"), "".concat(mainAxis, "-end"), "".concat(opposites[mainAxis]), "".concat(opposites[mainAxis], "-start"), "".concat(opposites[mainAxis], "-end"), "auto"];
+  }
+};
 /**
  * __Dropdown menu__
  *
@@ -74,6 +98,7 @@ var fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start', '
  * - [Usage](https://atlassian.design/components/dropdown-menu/usage)
  */
 
+
 var DropdownMenu = function DropdownMenu(props) {
   var _props$defaultOpen = props.defaultOpen,
       defaultOpen = _props$defaultOpen === void 0 ? false : _props$defaultOpen,
@@ -108,6 +133,9 @@ var DropdownMenu = function DropdownMenu(props) {
       isTriggeredUsingKeyboard = _useState2[0],
       setTriggeredUsingKeyboard = _useState2[1];
 
+  var fallbackPlacements = (0, _react.useMemo)(function () {
+    return getFallbackPlacements(placement);
+  }, [placement]);
   var handleTriggerClicked = (0, _react.useCallback)( // TODO: event is an `any` and is being cast incorrectly
   // This means that the public type for `onOpenChange` is incorrect
   // current: (event: React.MouseEvent | React.KeyboardEvent) => void;
@@ -202,7 +230,7 @@ var DropdownMenu = function DropdownMenu(props) {
         isSelected: isLocalOpen,
         iconAfter: (0, _core.jsx)(_chevronDown.default, {
           size: "medium",
-          label: "expand"
+          label: ""
         }),
         onClick: handleTriggerClicked,
         testId: testId && "".concat(testId, "--trigger")

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/dropdown-menu",
-	"version": "11.3.0",
+	"version": "11.3.1",
 	"sideEffects": false
 }

package/dist/es2019/dropdown-menu.js

@@ -1,7 +1,7 @@
 import _extends from "@babel/runtime/helpers/extends";
 
 /** @jsx jsx */
-import { useCallback, useEffect, useState } from 'react';
+import { useCallback, useEffect, useMemo, useState } from 'react';
 import { css, jsx } from '@emotion/core';
 import { bind } from 'bind-event-listener';
 import Button from '@atlaskit/button/standard-button';
@@ -26,7 +26,31 @@ const spinnerContainerStyles = css({
   justifyContent: 'center'
 });
 const MAX_HEIGHT = `calc(100vh - ${gridSize * 2}px)`;
-const fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start', 'auto'];
+const opposites = {
+  top: 'bottom',
+  bottom: 'top',
+  left: 'right',
+  right: 'left',
+  start: 'end',
+  auto: 'auto',
+  end: 'start'
+};
+
+const getFallbackPlacements = placement => {
+  const placementPieces = placement.split('-');
+  const mainAxis = placementPieces[0]; // Left, right and auto placements can rely on standard popper sliding behaviour
+
+  if (!['top', 'bottom'].includes(mainAxis)) {
+    return undefined;
+  } // Top and bottom placements need to flip to the right/left to ensure
+  // long lists don't extend off the screen
+  else if (placementPieces.length === 2 && ['start', 'end'].includes(placementPieces[1])) {
+    const crossAxis = placementPieces[1];
+    return [`${mainAxis}`, `${mainAxis}-${opposites[crossAxis]}`, `${opposites[mainAxis]}-${crossAxis}`, `${opposites[mainAxis]}`, `${opposites[mainAxis]}-${opposites[crossAxis]}`, 'auto'];
+  } else {
+    return [`${mainAxis}-start`, `${mainAxis}-end`, `${opposites[mainAxis]}`, `${opposites[mainAxis]}-start`, `${opposites[mainAxis]}-end`, `auto`];
+  }
+};
 /**
  * __Dropdown menu__
  *
@@ -37,6 +61,7 @@ const fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start',
  * - [Usage](https://atlassian.design/components/dropdown-menu/usage)
  */
 
+
 const DropdownMenu = props => {
   const {
     defaultOpen = false,
@@ -54,6 +79,7 @@ const DropdownMenu = props => {
   } = props;
   const [isLocalOpen, setLocalIsOpen] = useControlledState(isOpen, () => defaultOpen);
   const [isTriggeredUsingKeyboard, setTriggeredUsingKeyboard] = useState(false);
+  const fallbackPlacements = useMemo(() => getFallbackPlacements(placement), [placement]);
   const handleTriggerClicked = useCallback( // TODO: event is an `any` and is being cast incorrectly
   // This means that the public type for `onOpenChange` is incorrect
   // current: (event: React.MouseEvent | React.KeyboardEvent) => void;
@@ -152,7 +178,7 @@ const DropdownMenu = props => {
         isSelected: isLocalOpen,
         iconAfter: jsx(ExpandIcon, {
           size: "medium",
-          label: "expand"
+          label: ""
         }),
         onClick: handleTriggerClicked,
         testId: testId && `${testId}--trigger`

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/dropdown-menu",
-	"version": "11.3.0",
+	"version": "11.3.1",
 	"sideEffects": false
 }

package/dist/esm/dropdown-menu.js

@@ -9,7 +9,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
 /** @jsx jsx */
-import { useCallback, useEffect, useState } from 'react';
+import { useCallback, useEffect, useMemo, useState } from 'react';
 import { css, jsx } from '@emotion/core';
 import { bind } from 'bind-event-listener';
 import Button from '@atlaskit/button/standard-button';
@@ -34,7 +34,31 @@ var spinnerContainerStyles = css({
   justifyContent: 'center'
 });
 var MAX_HEIGHT = "calc(100vh - ".concat(gridSize * 2, "px)");
-var fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start', 'auto'];
+var opposites = {
+  top: 'bottom',
+  bottom: 'top',
+  left: 'right',
+  right: 'left',
+  start: 'end',
+  auto: 'auto',
+  end: 'start'
+};
+
+var getFallbackPlacements = function getFallbackPlacements(placement) {
+  var placementPieces = placement.split('-');
+  var mainAxis = placementPieces[0]; // Left, right and auto placements can rely on standard popper sliding behaviour
+
+  if (!['top', 'bottom'].includes(mainAxis)) {
+    return undefined;
+  } // Top and bottom placements need to flip to the right/left to ensure
+  // long lists don't extend off the screen
+  else if (placementPieces.length === 2 && ['start', 'end'].includes(placementPieces[1])) {
+    var crossAxis = placementPieces[1];
+    return ["".concat(mainAxis), "".concat(mainAxis, "-").concat(opposites[crossAxis]), "".concat(opposites[mainAxis], "-").concat(crossAxis), "".concat(opposites[mainAxis]), "".concat(opposites[mainAxis], "-").concat(opposites[crossAxis]), 'auto'];
+  } else {
+    return ["".concat(mainAxis, "-start"), "".concat(mainAxis, "-end"), "".concat(opposites[mainAxis]), "".concat(opposites[mainAxis], "-start"), "".concat(opposites[mainAxis], "-end"), "auto"];
+  }
+};
 /**
  * __Dropdown menu__
  *
@@ -45,6 +69,7 @@ var fallbackPlacements = ['bottom', 'bottom-end', 'right-start', 'left-start', '
  * - [Usage](https://atlassian.design/components/dropdown-menu/usage)
  */
 
+
 var DropdownMenu = function DropdownMenu(props) {
   var _props$defaultOpen = props.defaultOpen,
       defaultOpen = _props$defaultOpen === void 0 ? false : _props$defaultOpen,
@@ -79,6 +104,9 @@ var DropdownMenu = function DropdownMenu(props) {
       isTriggeredUsingKeyboard = _useState2[0],
       setTriggeredUsingKeyboard = _useState2[1];
 
+  var fallbackPlacements = useMemo(function () {
+    return getFallbackPlacements(placement);
+  }, [placement]);
   var handleTriggerClicked = useCallback( // TODO: event is an `any` and is being cast incorrectly
   // This means that the public type for `onOpenChange` is incorrect
   // current: (event: React.MouseEvent | React.KeyboardEvent) => void;
@@ -174,7 +202,7 @@ var DropdownMenu = function DropdownMenu(props) {
         isSelected: isLocalOpen,
         iconAfter: jsx(ExpandIcon, {
           size: "medium",
-          label: "expand"
+          label: ""
         }),
         onClick: handleTriggerClicked,
         testId: testId && "".concat(testId, "--trigger")

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/dropdown-menu",
-	"version": "11.3.0",
+	"version": "11.3.1",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/dropdown-menu",
-  "version": "11.3.0",
+  "version": "11.3.1",
   "description": "A dropdown menu displays a list of actions or options to a user.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"