@atlaskit/datetime-picker 12.0.0 → 12.1.2

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # @atlaskit/datetime-picker
 
+## 12.1.2
+
+### Patch Changes
+
+- [`df3d5287649`](https://bitbucket.org/atlassian/atlassian-frontend/commits/df3d5287649) - Internal code change turning on new linting rules.
+- [`429a576a4b2`](https://bitbucket.org/atlassian/atlassian-frontend/commits/429a576a4b2) - fix change-event firing for invalid inputs in datetime-picker select.
+- [`84afee665fc`](https://bitbucket.org/atlassian/atlassian-frontend/commits/84afee665fc) - [ux] Implemented missing functionality to submit forms on enter press after a date has been selected in DatePicker
+- [`2a2dcc1cf91`](https://bitbucket.org/atlassian/atlassian-frontend/commits/2a2dcc1cf91) - Updated styles to use new input design tokens. Fixed bug where border radius on datePicker rendered incorrectly.
+- Updated dependencies
+
+## 12.1.1
+
+### Patch Changes
+
+- [`3fa327b5d01`](https://bitbucket.org/atlassian/atlassian-frontend/commits/3fa327b5d01) - [ux] Border on a subtle appearance date-picker will now persist after a date is selected and field is in focus
+
+## 12.1.0
+
+### Minor Changes
+
+- [`58d4cd75f7a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/58d4cd75f7a) - Removed deprecated hideIcon prop from DateTimePicker because it is unused and serves no functionality.
+  Removed the deprecation notice for the formatDisplayLabel prop in TimePicker
+
+### Patch Changes
+
+- [`c3a1b950d49`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c3a1b950d49) - DSP-3301 specifies label to input id
+- [`c2f866d31d1`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c2f866d31d1) - [ux] Fix timepicker clear icon alignment
+- [`7566be18f20`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7566be18f20) - [ux] Time picker no longer loses focus to the document when tabbing through it in a popup.
+- [`574b6c8ba7f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/574b6c8ba7f) - [ux] DSP-2987 Add code to catch console error
+- Updated dependencies
+
 ## 12.0.0
 
 ### Major Changes

package/dist/cjs/components/{DatePicker.js → date-picker.js}

@@ -51,7 +51,7 @@ var _constants = require("@atlaskit/theme/constants");
 
 var _internal = require("../internal");
 
-var _FixedLayer = _interopRequireDefault(require("../internal/FixedLayer"));
+var _fixedLayer = _interopRequireDefault(require("../internal/fixed-layer"));
 
 var _utils = require("./utils");
 
@@ -68,7 +68,7 @@ function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflec
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 
 var packageName = "@atlaskit/datetime-picker";
-var packageVersion = "12.0.0";
+var packageVersion = "12.1.2";
 /* eslint-disable react/no-unused-prop-types */
 
 function getDateObj(date) {
@@ -86,15 +86,16 @@ function getValidDate(iso) {
 
 var menuStyles = (0, _core.css)({
   zIndex: _constants.layers.dialog(),
-  backgroundColor: "var(--ds-surface, ".concat(_colors.N20, ")"),
+  backgroundColor: "var(--ds-surface-overlay, ".concat(_colors.N20, ")"),
   borderRadius: "".concat((0, _constants.borderRadius)(), "px"),
-  boxShadow: "var(--ds-shadow-overlay, ".concat("0 4px 8px -2px ".concat(_colors.N50A, ", 0 0 1px ").concat(_colors.N60A), ")")
+  boxShadow: "var(--ds-shadow-overlay, ".concat("0 4px 8px -2px ".concat(_colors.N50A, ", 0 0 1px ").concat(_colors.N60A), ")"),
+  overflow: 'hidden'
 });
 
 var Menu = function Menu(_ref) {
   var selectProps = _ref.selectProps,
       innerProps = _ref.innerProps;
-  return (0, _core.jsx)(_FixedLayer.default, {
+  return (0, _core.jsx)(_fixedLayer.default, {
     inputValue: selectProps.inputValue,
     containerRef: selectProps.calendarContainerRef,
     content: (0, _core.jsx)("div", (0, _extends2.default)({
@@ -112,7 +113,8 @@ var Menu = function Menu(_ref) {
       selected: [selectProps.calendarValue],
       locale: selectProps.calendarLocale,
       testId: selectProps.testId && "".concat(selectProps.testId, "--calendar"),
-      weekStartDay: selectProps.calendarWeekStartDay
+      weekStartDay: selectProps.calendarWeekStartDay,
+      tabIndex: -1
     }))),
     testId: selectProps.testId
   });
@@ -215,7 +217,8 @@ var DatePicker = /*#__PURE__*/function (_Component) {
         });
       } else {
         _this.setState({
-          isOpen: false
+          isOpen: false,
+          isFocused: false
         });
       }
 
@@ -234,7 +237,8 @@ var DatePicker = /*#__PURE__*/function (_Component) {
       } else {
         _this.setState({
           isOpen: true,
-          view: value
+          view: value,
+          isFocused: true
         });
       }
 
@@ -315,12 +319,21 @@ var DatePicker = /*#__PURE__*/function (_Component) {
           break;
 
         case 'enter':
-          // Prevent form submission when a date is selected
+          if (!_this.state.isOpen) {
+            return;
+          } // Prevent form submission when a date is selected
           // using enter. See https://product-fabric.atlassian.net/browse/DSP-2501
           // for more details.
+
+
           event.preventDefault();
 
           if (!_this.isDateDisabled(view)) {
+            var _this$getSafeState3 = _this.getSafeState(),
+                _value = _this$getSafeState3.value;
+
+            var valueChanged = view !== _value;
+
             _this.setState({
               inputValue: '',
               isOpen: false,
@@ -329,7 +342,9 @@ var DatePicker = /*#__PURE__*/function (_Component) {
               view: view
             });
 
-            _this.props.onChange(view);
+            if (valueChanged) {
+              _this.props.onChange(view);
+            }
           }
 
           break;
@@ -385,10 +400,10 @@ var DatePicker = /*#__PURE__*/function (_Component) {
         _this.forceUpdate();
       }
     });
-    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "getSubtleControlStyles", function (isOpen) {
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "getSubtleControlStyles", function () {
       return {
-        border: "2px solid ".concat(isOpen ? "var(--ds-border-focused, ".concat(_colors.B100, ")") : "transparent"),
-        backgroundColor: 'transparent',
+        border: "2px solid ".concat(_this.getSafeState().isFocused ? "var(--ds-border-focused, ".concat(_colors.B100, ")") : "transparent"),
+        backgroundColor: _this.getSafeState().isOpen ? "var(--ds-background-input-pressed, transparent)" : 'transparent',
         padding: '1px'
       };
     });
@@ -401,8 +416,8 @@ var DatePicker = /*#__PURE__*/function (_Component) {
         return parseInputValue(date, dateFormat || _internal.defaultDateFormat);
       }
 
-      var _this$getSafeState3 = _this.getSafeState(),
-          l10n = _this$getSafeState3.l10n;
+      var _this$getSafeState4 = _this.getSafeState(),
+          l10n = _this$getSafeState4.l10n;
 
       return l10n.parseDate(date);
     });
@@ -411,8 +426,8 @@ var DatePicker = /*#__PURE__*/function (_Component) {
           formatDisplayLabel = _this$props2.formatDisplayLabel,
           dateFormat = _this$props2.dateFormat;
 
-      var _this$getSafeState4 = _this.getSafeState(),
-          l10n = _this$getSafeState4.l10n;
+      var _this$getSafeState5 = _this.getSafeState(),
+          l10n = _this$getSafeState5.l10n;
 
       if (formatDisplayLabel) {
         return formatDisplayLabel(value, dateFormat || _internal.defaultDateFormat);
@@ -428,8 +443,8 @@ var DatePicker = /*#__PURE__*/function (_Component) {
         return placeholder;
       }
 
-      var _this$getSafeState5 = _this.getSafeState(),
-          l10n = _this$getSafeState5.l10n;
+      var _this$getSafeState6 = _this.getSafeState(),
+          l10n = _this$getSafeState6.l10n;
 
       return l10n.formatDate(_internal.placeholderDatetime);
     });
@@ -441,6 +456,7 @@ var DatePicker = /*#__PURE__*/function (_Component) {
 
     _this.state = {
       isOpen: _this.props.defaultIsOpen,
+      isFocused: false,
       clearingFromIcon: false,
       inputValue: _this.props.selectProps.inputValue,
       selectedValue: _this.props.value || _this.props.defaultValue,
@@ -486,14 +502,13 @@ var DatePicker = /*#__PURE__*/function (_Component) {
           locale = _this$props3.locale,
           testId = _this$props3.testId,
           weekStartDay = _this$props3.weekStartDay;
-      var BORDER_WIDTH = 2;
       var ICON_PADDING = 2;
 
-      var _this$getSafeState6 = this.getSafeState(),
-          value = _this$getSafeState6.value,
-          view = _this$getSafeState6.view,
-          isOpen = _this$getSafeState6.isOpen,
-          inputValue = _this$getSafeState6.inputValue;
+      var _this$getSafeState7 = this.getSafeState(),
+          value = _this$getSafeState7.value,
+          view = _this$getSafeState7.view,
+          isOpen = _this$getSafeState7.isOpen,
+          inputValue = _this$getSafeState7.inputValue;
 
       var menuIsOpen = isOpen && !isDisabled;
       var showClearIndicator = Boolean((value || inputValue) && !hideIcon);
@@ -509,7 +524,7 @@ var DatePicker = /*#__PURE__*/function (_Component) {
 
       var _selectProps$styles = selectProps.styles,
           selectStyles = _selectProps$styles === void 0 ? {} : _selectProps$styles;
-      var controlStyles = appearance === 'subtle' ? this.getSubtleControlStyles(isOpen) : {};
+      var controlStyles = appearance === 'subtle' ? this.getSubtleControlStyles() : {};
       var disabledStyle = isDisabled ? {
         pointerEvents: 'none'
       } : {};
@@ -537,6 +552,7 @@ var DatePicker = /*#__PURE__*/function (_Component) {
         ref: this.getContainerRef,
         "data-testid": testId && "".concat(testId, "--container")
       }), (0, _core.jsx)("input", {
+        id: selectProps.inputId,
         name: name,
         type: "hidden",
         value: value,
@@ -561,7 +577,7 @@ var DatePicker = /*#__PURE__*/function (_Component) {
           indicatorsContainer: function indicatorsContainer(base) {
             return _objectSpread(_objectSpread({}, base), {}, {
               paddingLeft: ICON_PADDING,
-              paddingRight: (0, _constants.gridSize)() - BORDER_WIDTH
+              paddingRight: (0, _constants.gridSize)() - ICON_PADDING
             });
           }
         }),

package/dist/cjs/components/{DateTimePicker.js → date-time-picker.js}

@@ -43,9 +43,9 @@ var _constants = require("@atlaskit/theme/constants");
 
 var _internal = require("../internal");
 
-var _DatePicker = _interopRequireDefault(require("./DatePicker"));
+var _datePicker = _interopRequireDefault(require("./date-picker"));
 
-var _TimePicker = _interopRequireDefault(require("./TimePicker"));
+var _timePicker = _interopRequireDefault(require("./time-picker"));
 
 var _utils = require("./utils");
 
@@ -58,7 +58,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
 var packageName = "@atlaskit/datetime-picker";
-var packageVersion = "12.0.0";
+var packageVersion = "12.1.2";
 /* eslint-disable react/no-unused-prop-types */
 
 var isInvalidBorderStyles = (0, _core.css)({
@@ -68,16 +68,20 @@ var isFocusedBorderStyles = (0, _core.css)({
   borderColor: "var(--ds-border-focused, ".concat(_colors.B100, ")")
 });
 var isFocusedStyles = (0, _core.css)({
-  backgroundColor: "var(--ds-surface, ".concat(_colors.N0, ")")
+  backgroundColor: "var(--ds-background-input-pressed, ".concat(_colors.N0, ")")
 });
 var subtleBgStyles = (0, _core.css)({
   backgroundColor: 'transparent',
   borderColor: 'transparent'
 });
+var subtleFocusedBgStyles = (0, _core.css)({
+  backgroundColor: "var(--ds-background-input-pressed, transparent)",
+  borderColor: 'transparent'
+});
 var hoverStyles = (0, _core.css)({
   '&:hover': {
     backgroundColor: "var(--ds-background-input-hovered, ".concat(_colors.N30, ")"),
-    borderColor: "var(--ds-border, ".concat(_colors.N30, ")")
+    borderColor: "var(--ds-border-input, ".concat(_colors.N30, ")")
   }
 });
 var isInvalidHoverStyles = (0, _core.css)({
@@ -93,8 +97,8 @@ var isDisabledStyles = (0, _core.css)({
 });
 var baseContainerStyles = (0, _core.css)({
   display: 'flex',
-  backgroundColor: "var(--ds-background-neutral, ".concat(_colors.N20, ")"),
-  border: "2px solid ".concat("var(--ds-border, ".concat(_colors.N20, ")")),
+  backgroundColor: "var(--ds-background-input, ".concat(_colors.N20, ")"),
+  border: "2px solid ".concat("var(--ds-border-input, ".concat(_colors.N20, ")")),
   borderRadius: "".concat((0, _constants.borderRadius)(), "px"),
   transition: 'background-color 200ms ease-in-out, border-color 200ms ease-in-out',
   '&:hover': {
@@ -326,17 +330,19 @@ var DateTimePicker = /*#__PURE__*/function (_React$Component) {
 
       var isClearable = Boolean(dateValue || timeValue);
       var notFocusedOrIsDisabled = !(isFocused || isDisabled);
+      var labelId = (datePickerSelectProps === null || datePickerSelectProps === void 0 ? void 0 : datePickerSelectProps.inputId) || (timePickerSelectProps === null || timePickerSelectProps === void 0 ? void 0 : timePickerSelectProps.inputId) || '';
       return (0, _core.jsx)("div", (0, _extends2.default)({
-        css: [baseContainerStyles, isDisabled && isDisabledStyles, isFocused && isFocusedStyles, bothProps.appearance === 'subtle' && subtleBgStyles, isFocused && isFocusedBorderStyles, bothProps.isInvalid && isInvalidBorderStyles, notFocusedOrIsDisabled && (bothProps.isInvalid ? isInvalidHoverStyles : hoverStyles)]
+        css: [baseContainerStyles, isDisabled && isDisabledStyles, isFocused && isFocusedStyles, bothProps.appearance === 'subtle' && (isFocused ? subtleFocusedBgStyles : subtleBgStyles), isFocused && isFocusedBorderStyles, bothProps.isInvalid && isInvalidBorderStyles, notFocusedOrIsDisabled && (bothProps.isInvalid ? isInvalidHoverStyles : hoverStyles)]
       }, innerProps, {
         "data-testid": testId
       }), (0, _core.jsx)("input", {
+        id: labelId,
         name: name,
         type: "hidden",
         value: value
       }), (0, _core.jsx)("div", {
         css: datePickerContainerStyles
-      }, (0, _core.jsx)(_DatePicker.default, (0, _extends2.default)({}, bothProps, {
+      }, (0, _core.jsx)(_datePicker.default, (0, _extends2.default)({}, bothProps, {
         autoFocus: autoFocus,
         dateFormat: dateFormat,
         hideIcon: true,
@@ -348,7 +354,7 @@ var DateTimePicker = /*#__PURE__*/function (_React$Component) {
         testId: testId && "".concat(testId, "--datepicker")
       }, datePickerProps))), (0, _core.jsx)("div", {
         css: timePickerContainerStyles
-      }, (0, _core.jsx)(_TimePicker.default, (0, _extends2.default)({}, bothProps, {
+      }, (0, _core.jsx)(_timePicker.default, (0, _extends2.default)({}, bothProps, {
         hideIcon: true,
         onChange: this.onTimeChange,
         selectProps: mergedTimePickerSelectProps,

package/dist/cjs/components/{TimePicker.js → time-picker.js}

@@ -45,9 +45,9 @@ var _constants = require("@atlaskit/theme/constants");
 
 var _internal = require("../internal");
 
-var _FixedLayer = _interopRequireDefault(require("../internal/FixedLayer"));
+var _fixedLayer = _interopRequireDefault(require("../internal/fixed-layer"));
 
-var _parseTime = _interopRequireDefault(require("../internal/parseTime"));
+var _parseTime = _interopRequireDefault(require("../internal/parse-time"));
 
 var _utils = require("./utils");
 
@@ -67,7 +67,7 @@ function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflec
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 
 var packageName = "@atlaskit/datetime-picker";
-var packageVersion = "12.0.0";
+var packageVersion = "12.1.2";
 var menuStyles = {
   /* Need to remove default absolute positioning as that causes issues with position fixed */
   position: 'static',
@@ -82,7 +82,7 @@ var menuStyles = {
 var FixedLayerMenu = function FixedLayerMenu(_ref) {
   var selectProps = _ref.selectProps,
       rest = (0, _objectWithoutProperties2.default)(_ref, _excluded);
-  return /*#__PURE__*/_react.default.createElement(_FixedLayer.default, {
+  return /*#__PURE__*/_react.default.createElement(_fixedLayer.default, {
     inputValue: selectProps.inputValue,
     containerRef: selectProps.fixedLayerRef,
     content: /*#__PURE__*/_react.default.createElement(_select.components.Menu, (0, _extends2.default)({}, rest, {
@@ -165,7 +165,15 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
         var _this$props = _this.props,
             parseInputValue = _this$props.parseInputValue,
             _timeFormat = _this$props.timeFormat;
-        var formattedValue = (0, _dateFns.format)(parseInputValue(inputValue, _timeFormat || _internal.defaultTimeFormat), 'HH:mm') || '';
+        var sanitizedInput;
+
+        try {
+          sanitizedInput = parseInputValue(inputValue, _timeFormat || _internal.defaultTimeFormat);
+        } catch (e) {
+          return; // do nothing, the main validation should happen in the form
+        }
+
+        var formattedValue = (0, _dateFns.format)(sanitizedInput, 'HH:mm') || '';
 
         _this.setState({
           value: formattedValue
@@ -237,7 +245,7 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "getSubtleControlStyles", function (selectStyles) {
       return !selectStyles.control ? {
         border: "2px solid ".concat(_this.getSafeState().isFocused ? "var(--ds-border-focused, ".concat(_colors.B100, ")") : "transparent"),
-        backgroundColor: 'transparent',
+        backgroundColor: _this.getSafeState().isFocused ? "var(--ds-background-input-pressed, transparent)" : 'transparent',
         padding: '1px'
       } : {};
     });
@@ -323,7 +331,6 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
           spacing = _this$props3.spacing,
           testId = _this$props3.testId;
       var ICON_PADDING = 2;
-      var BORDER_WIDTH = 2;
 
       var _this$getSafeState3 = this.getSafeState(),
           _this$getSafeState3$v = _this$getSafeState3.value,
@@ -349,7 +356,7 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
         selectComponents.ClearIndicator = _internal.EmptyClearIndicator;
       }
 
-      var renderIconContainer = Boolean(hideIcon && value);
+      var renderIconContainer = Boolean(!hideIcon && value);
       var mergedStyles = (0, _select.mergeStyles)(selectStyles, {
         control: function control(base) {
           return _objectSpread(_objectSpread({}, base), controlStyles);
@@ -364,7 +371,7 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
         indicatorsContainer: function indicatorsContainer(base) {
           return _objectSpread(_objectSpread({}, base), {}, {
             paddingLeft: renderIconContainer ? ICON_PADDING : 0,
-            paddingRight: renderIconContainer ? (0, _constants.gridSize)() - BORDER_WIDTH : 0
+            paddingRight: renderIconContainer ? (0, _constants.gridSize)() - ICON_PADDING : 0
           });
         }
       });
@@ -376,6 +383,7 @@ var TimePicker = /*#__PURE__*/function (_React$Component) {
           "data-testid": testId && "".concat(testId, "--container"),
           onKeyDown: this.onSelectKeyDown
         }), /*#__PURE__*/_react.default.createElement("input", {
+          id: selectProps.inputId,
           name: name,
           type: "hidden",
           value: value

package/dist/cjs/index.js

@@ -8,24 +8,24 @@ Object.defineProperty(exports, "__esModule", {
 Object.defineProperty(exports, "DatePicker", {
   enumerable: true,
   get: function get() {
-    return _DatePicker.default;
+    return _datePicker.default;
   }
 });
 Object.defineProperty(exports, "DateTimePicker", {
   enumerable: true,
   get: function get() {
-    return _DateTimePicker.default;
+    return _dateTimePicker.default;
   }
 });
 Object.defineProperty(exports, "TimePicker", {
   enumerable: true,
   get: function get() {
-    return _TimePicker.default;
+    return _timePicker.default;
   }
 });
 
-var _DatePicker = _interopRequireDefault(require("./components/DatePicker"));
+var _datePicker = _interopRequireDefault(require("./components/date-picker"));
 
-var _TimePicker = _interopRequireDefault(require("./components/TimePicker"));
+var _timePicker = _interopRequireDefault(require("./components/time-picker"));
 
-var _DateTimePicker = _interopRequireDefault(require("./components/DateTimePicker"));
+var _dateTimePicker = _interopRequireDefault(require("./components/date-time-picker"));

package/dist/cjs/internal/{FixedLayer.js → fixed-layer.js}

@@ -25,6 +25,8 @@ var _react = _interopRequireDefault(require("react"));
 
 var _reactScrolllock = _interopRequireDefault(require("react-scrolllock"));
 
+var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
+
 var _icon = require("@atlaskit/icon");
 
 var _popper = require("@atlaskit/popper");
@@ -59,7 +61,7 @@ var FixedLayer = /*#__PURE__*/function (_React$Component) {
     }
 
     _this = _super.call.apply(_super, [this].concat(args));
-    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "update", function () {});
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "update", _noop.default);
     return _this;
   }
 

package/dist/cjs/internal/index.js

@@ -12,6 +12,7 @@ exports.placeholderDatetime = void 0;
 
 var _react = _interopRequireDefault(require("react"));
 
+/* eslint-disable @repo/internal/react/require-jsdoc */
 var EmptyClearIndicator = null; // This date was chosen to clearly show date and time formats (day > 12)
 // e.g. 18/02/1993 vs. 2/18/1993 and 1:00 PM vs 13:00
 

package/dist/cjs/internal/{parseTime.js → parse-time.js}

@@ -123,14 +123,14 @@ function _default(time) {
   var trimmedTime = time.toString().trim();
 
   if (!isValid(trimmedTime)) {
-    return 'invalid time format';
+    throw RangeError('invalid time format');
   }
 
   var time1 = removeSpacer(trimmedTime);
   var time2 = convertTo24hrTime(time1);
 
   if (!time2) {
-    return 'invalid time format';
+    throw RangeError('invalid time format');
   }
 
   return assignToDate(time2);

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/datetime-picker",
-	"version": "12.0.0",
+	"version": "12.1.2",
 	"sideEffects": false
 }

package/dist/es2019/components/{DatePicker.js → date-picker.js}

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import _extends from "@babel/runtime/helpers/extends";
 
+/* eslint-disable @repo/internal/react/use-noop */
+
 /** @jsx jsx */
 import { Component } from 'react';
 import { css, jsx } from '@emotion/core'; // eslint-disable-next-line no-restricted-imports
@@ -15,10 +17,10 @@ import Select, { mergeStyles } from '@atlaskit/select';
 import { B100, N20, N50A, N60A } from '@atlaskit/theme/colors';
 import { borderRadius, gridSize, layers } from '@atlaskit/theme/constants';
 import { defaultDateFormat, EmptyClearIndicator, padToTwo, placeholderDatetime } from '../internal';
-import FixedLayer from '../internal/FixedLayer';
+import FixedLayer from '../internal/fixed-layer';
 import { convertTokens } from './utils';
 const packageName = "@atlaskit/datetime-picker";
-const packageVersion = "12.0.0";
+const packageVersion = "12.1.2";
 /* eslint-disable react/no-unused-prop-types */
 
 function getDateObj(date) {
@@ -36,9 +38,10 @@ function getValidDate(iso) {
 
 const menuStyles = css({
   zIndex: layers.dialog(),
-  backgroundColor: `var(--ds-surface, ${N20})`,
+  backgroundColor: `var(--ds-surface-overlay, ${N20})`,
   borderRadius: `${borderRadius()}px`,
-  boxShadow: `var(--ds-shadow-overlay, ${`0 4px 8px -2px ${N50A}, 0 0 1px ${N60A}`})`
+  boxShadow: `var(--ds-shadow-overlay, ${`0 4px 8px -2px ${N50A}, 0 0 1px ${N60A}`})`,
+  overflow: 'hidden'
 });
 
 const Menu = ({
@@ -62,7 +65,8 @@ const Menu = ({
     selected: [selectProps.calendarValue],
     locale: selectProps.calendarLocale,
     testId: selectProps.testId && `${selectProps.testId}--calendar`,
-    weekStartDay: selectProps.calendarWeekStartDay
+    weekStartDay: selectProps.calendarWeekStartDay,
+    tabIndex: -1
   }))),
   testId: selectProps.testId
 });
@@ -160,7 +164,8 @@ class DatePicker extends Component {
         });
       } else {
         this.setState({
-          isOpen: false
+          isOpen: false,
+          isFocused: false
         });
       }
 
@@ -181,7 +186,8 @@ class DatePicker extends Component {
       } else {
         this.setState({
           isOpen: true,
-          view: value
+          view: value,
+          isFocused: true
         });
       }
 
@@ -258,12 +264,20 @@ class DatePicker extends Component {
           break;
 
         case 'enter':
-          // Prevent form submission when a date is selected
+          if (!this.state.isOpen) {
+            return;
+          } // Prevent form submission when a date is selected
           // using enter. See https://product-fabric.atlassian.net/browse/DSP-2501
           // for more details.
+
+
           event.preventDefault();
 
           if (!this.isDateDisabled(view)) {
+            const {
+              value
+            } = this.getSafeState();
+            const valueChanged = view !== value;
             this.setState({
               inputValue: '',
               isOpen: false,
@@ -271,7 +285,10 @@ class DatePicker extends Component {
               value: view,
               view
             });
-            this.props.onChange(view);
+
+            if (valueChanged) {
+              this.props.onChange(view);
+            }
           }
 
           break;
@@ -334,9 +351,9 @@ class DatePicker extends Component {
       }
     });
 
-    _defineProperty(this, "getSubtleControlStyles", isOpen => ({
-      border: `2px solid ${isOpen ? `var(--ds-border-focused, ${B100})` : `transparent`}`,
-      backgroundColor: 'transparent',
+    _defineProperty(this, "getSubtleControlStyles", () => ({
+      border: `2px solid ${this.getSafeState().isFocused ? `var(--ds-border-focused, ${B100})` : `transparent`}`,
+      backgroundColor: this.getSafeState().isOpen ? "var(--ds-background-input-pressed, transparent)" : 'transparent',
       padding: '1px'
     }));
 
@@ -395,6 +412,7 @@ class DatePicker extends Component {
     } = getDateObj(new Date());
     this.state = {
       isOpen: this.props.defaultIsOpen,
+      isFocused: false,
       clearingFromIcon: false,
       inputValue: this.props.selectProps.inputValue,
       selectedValue: this.props.value || this.props.defaultValue,
@@ -437,7 +455,6 @@ class DatePicker extends Component {
       testId,
       weekStartDay
     } = this.props;
-    const BORDER_WIDTH = 2;
     const ICON_PADDING = 2;
     const {
       value,
@@ -460,7 +477,7 @@ class DatePicker extends Component {
     const {
       styles: selectStyles = {}
     } = selectProps;
-    const controlStyles = appearance === 'subtle' ? this.getSubtleControlStyles(isOpen) : {};
+    const controlStyles = appearance === 'subtle' ? this.getSubtleControlStyles() : {};
     const disabledStyle = isDisabled ? {
       pointerEvents: 'none'
     } : {};
@@ -488,6 +505,7 @@ class DatePicker extends Component {
       ref: this.getContainerRef,
       "data-testid": testId && `${testId}--container`
     }), jsx("input", {
+      id: selectProps.inputId,
       name: name,
       type: "hidden",
       value: value,
@@ -512,7 +530,7 @@ class DatePicker extends Component {
         }),
         indicatorsContainer: base => ({ ...base,
           paddingLeft: ICON_PADDING,
-          paddingRight: gridSize() - BORDER_WIDTH
+          paddingRight: gridSize() - ICON_PADDING
         })
       }),
       placeholder: this.getPlaceholder(),