@atlaskit/codemod-cli 1.0.0 → 1.0.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/codemod-cli
 
+## 1.0.2
+
+### Patch Changes
+
+- [`dc456d412b841`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/dc456d412b841) -
+  Fixed lozenge-appearance-semantic-migration codemod incorrectly flagging already-migrated semantic
+  values as unknown.
+
+## 1.0.1
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 1.0.0
 
 ### Major Changes

package/dist/cjs/main.js

@@ -367,7 +367,7 @@ function _main() {
         case 4:
           _yield$parseArgs = _context6.sent;
           packages = _yield$parseArgs.packages;
-          _process$env$_PACKAGE = "0.0.0-development", _PACKAGE_VERSION_ = _process$env$_PACKAGE === void 0 ? '0.0.0-dev' : _process$env$_PACKAGE;
+          _process$env$_PACKAGE = "1.0.1", _PACKAGE_VERSION_ = _process$env$_PACKAGE === void 0 ? '0.0.0-dev' : _process$env$_PACKAGE;
           logger.log(_chalk.default.bgBlue(_chalk.default.black("\uD83D\uDCDA Atlassian-Frontend codemod library @ ".concat(_PACKAGE_VERSION_, " \uD83D\uDCDA"))));
           if (packages && packages.length > 0) {
             logger.log(_chalk.default.gray("Searching for codemods for newer versions of the following packages: ".concat(packages.map(function (pkg) {

package/dist/cjs/presets/lozenge-appearance-semantic-migration/codemods/lozenge-appearance-semantic-migration.js

@@ -1,9 +1,11 @@
 "use strict";
 
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = transformer;
+var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 var _utils = require("@hypermod/utils");
 var _codemodUtils = require("@atlaskit/codemod-utils");
 var LOZENGE_ENTRY_POINT = '@atlaskit/lozenge';
@@ -20,6 +22,9 @@ var OLD_TO_NEW_APPEARANCE_MAP = {
   removed: 'danger',
   success: 'success'
 };
+
+// New semantic values that are already valid and should be left unchanged
+var NEW_SEMANTIC_VALUES = new Set(Object.values(OLD_TO_NEW_APPEARANCE_MAP));
 /**
  * Codemod to migrate Lozenge component appearance semantic values.
  *
@@ -117,9 +122,11 @@ function transformer(file, api) {
           if (appearanceValue === 'dynamic') {
             // For dynamic values, add a comment
             (0, _codemodUtils.addCommentBefore)(j, j(path), "FIXME: This Lozenge component uses a dynamic `appearance` prop with updated semantic values.\nPlease verify that the values being passed use the new semantic values: neutral, information, warning, discovery, danger, success.\nOld values mapping: default\u2192neutral, inprogress\u2192information, moved\u2192warning, new\u2192discovery, removed\u2192danger, success\u2192success.");
+          } else if (appearanceValue && NEW_SEMANTIC_VALUES.has(appearanceValue)) {
+            // Already using new semantic values, skip
           } else if (appearanceValue && !OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             // For invalid string values, add a warning comment
-            (0, _codemodUtils.addCommentBefore)(j, j(path), "FIXME: This Lozenge component uses an unknown `appearance` value \"".concat(appearanceValue, "\".\nValid new semantic appearance values are: ").concat(Object.values(OLD_TO_NEW_APPEARANCE_MAP).join(', '), ".\nPlease update this value to a valid semantic appearance value."));
+            (0, _codemodUtils.addCommentBefore)(j, j(path), "FIXME: This Lozenge component uses an unknown `appearance` value \"".concat(appearanceValue, "\".\nValid new semantic appearance values are: ").concat((0, _toConsumableArray2.default)(NEW_SEMANTIC_VALUES).join(', '), ".\nPlease update this value to a valid semantic appearance value."));
           } else if (appearanceValue && OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             var _attr$value3;
             // For valid string values, update the value to the new semantic value

package/dist/es2019/presets/lozenge-appearance-semantic-migration/codemods/lozenge-appearance-semantic-migration.js

@@ -14,6 +14,9 @@ const OLD_TO_NEW_APPEARANCE_MAP = {
   removed: 'danger',
   success: 'success'
 };
+
+// New semantic values that are already valid and should be left unchanged
+const NEW_SEMANTIC_VALUES = new Set(Object.values(OLD_TO_NEW_APPEARANCE_MAP));
 /**
  * Codemod to migrate Lozenge component appearance semantic values.
  *
@@ -115,10 +118,12 @@ export default function transformer(file, api) {
             addCommentBefore(j, j(path), `FIXME: This Lozenge component uses a dynamic \`appearance\` prop with updated semantic values.
 Please verify that the values being passed use the new semantic values: neutral, information, warning, discovery, danger, success.
 Old values mapping: default→neutral, inprogress→information, moved→warning, new→discovery, removed→danger, success→success.`);
+          } else if (appearanceValue && NEW_SEMANTIC_VALUES.has(appearanceValue)) {
+            // Already using new semantic values, skip
           } else if (appearanceValue && !OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             // For invalid string values, add a warning comment
             addCommentBefore(j, j(path), `FIXME: This Lozenge component uses an unknown \`appearance\` value "${appearanceValue}".
-Valid new semantic appearance values are: ${Object.values(OLD_TO_NEW_APPEARANCE_MAP).join(', ')}.
+Valid new semantic appearance values are: ${[...NEW_SEMANTIC_VALUES].join(', ')}.
 Please update this value to a valid semantic appearance value.`);
           } else if (appearanceValue && OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             var _attr$value3;

package/dist/esm/main.js

@@ -360,7 +360,7 @@ function _main() {
         case 4:
           _yield$parseArgs = _context6.sent;
           packages = _yield$parseArgs.packages;
-          _process$env$_PACKAGE = "0.0.0-development", _PACKAGE_VERSION_ = _process$env$_PACKAGE === void 0 ? '0.0.0-dev' : _process$env$_PACKAGE;
+          _process$env$_PACKAGE = "1.0.1", _PACKAGE_VERSION_ = _process$env$_PACKAGE === void 0 ? '0.0.0-dev' : _process$env$_PACKAGE;
           logger.log(chalk.bgBlue(chalk.black("\uD83D\uDCDA Atlassian-Frontend codemod library @ ".concat(_PACKAGE_VERSION_, " \uD83D\uDCDA"))));
           if (packages && packages.length > 0) {
             logger.log(chalk.gray("Searching for codemods for newer versions of the following packages: ".concat(packages.map(function (pkg) {

package/dist/esm/presets/lozenge-appearance-semantic-migration/codemods/lozenge-appearance-semantic-migration.js

@@ -1,3 +1,4 @@
+import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 import { getImportDeclaration } from '@hypermod/utils';
 import { addCommentBefore } from '@atlaskit/codemod-utils';
 var LOZENGE_ENTRY_POINT = '@atlaskit/lozenge';
@@ -14,6 +15,9 @@ var OLD_TO_NEW_APPEARANCE_MAP = {
   removed: 'danger',
   success: 'success'
 };
+
+// New semantic values that are already valid and should be left unchanged
+var NEW_SEMANTIC_VALUES = new Set(Object.values(OLD_TO_NEW_APPEARANCE_MAP));
 /**
  * Codemod to migrate Lozenge component appearance semantic values.
  *
@@ -111,9 +115,11 @@ export default function transformer(file, api) {
           if (appearanceValue === 'dynamic') {
             // For dynamic values, add a comment
             addCommentBefore(j, j(path), "FIXME: This Lozenge component uses a dynamic `appearance` prop with updated semantic values.\nPlease verify that the values being passed use the new semantic values: neutral, information, warning, discovery, danger, success.\nOld values mapping: default\u2192neutral, inprogress\u2192information, moved\u2192warning, new\u2192discovery, removed\u2192danger, success\u2192success.");
+          } else if (appearanceValue && NEW_SEMANTIC_VALUES.has(appearanceValue)) {
+            // Already using new semantic values, skip
           } else if (appearanceValue && !OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             // For invalid string values, add a warning comment
-            addCommentBefore(j, j(path), "FIXME: This Lozenge component uses an unknown `appearance` value \"".concat(appearanceValue, "\".\nValid new semantic appearance values are: ").concat(Object.values(OLD_TO_NEW_APPEARANCE_MAP).join(', '), ".\nPlease update this value to a valid semantic appearance value."));
+            addCommentBefore(j, j(path), "FIXME: This Lozenge component uses an unknown `appearance` value \"".concat(appearanceValue, "\".\nValid new semantic appearance values are: ").concat(_toConsumableArray(NEW_SEMANTIC_VALUES).join(', '), ".\nPlease update this value to a valid semantic appearance value."));
           } else if (appearanceValue && OLD_TO_NEW_APPEARANCE_MAP[appearanceValue]) {
             var _attr$value3;
             // For valid string values, update the value to the new semantic value

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/codemod-cli",
-	"version": "1.0.0",
+	"version": "1.0.2",
 	"description": "A cli for distributing codemods for atlassian-frontend components and services",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -31,7 +31,7 @@
 		"@atlaskit/codemod-utils": "^4.2.0",
 		"@atlaskit/icon": "^34.0.0",
 		"@atlaskit/icon-lab": "^6.4.0",
-		"@atlaskit/tokens": "^11.4.0",
+		"@atlaskit/tokens": "^12.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@codeshift/utils": "^0.2.4",
 		"@hypermod/utils": "^0.4.2",