@atlaskit/button 16.18.0 → 16.18.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/button
 
+## 16.18.1
+
+### Patch Changes
+
+- [#58871](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/58871) [`4c7dc39947e8`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/4c7dc39947e8) - Add code docs for icon button and update types
+
 ## 16.18.0
 
 ### Minor Changes

package/dist/cjs/new-button/variants/shared/use-button-base.js

@@ -117,7 +117,7 @@ var useButtonBase = function useButtonBase(_ref) {
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext,
     actionSubject: buttonType
   });

package/dist/cjs/old-button/shared/button-base.js

@@ -118,7 +118,7 @@ var _default = exports.default = /*#__PURE__*/_react.default.forwardRef(function
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext
   });
 

package/dist/es2019/new-button/variants/shared/use-button-base.js

@@ -98,7 +98,7 @@ const useButtonBase = ({
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext,
     actionSubject: buttonType
   });

package/dist/es2019/old-button/shared/button-base.js

@@ -103,7 +103,7 @@ export default /*#__PURE__*/React.forwardRef(function ButtonBase(props, ref) {
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext
   });
 

package/dist/esm/new-button/variants/shared/use-button-base.js

@@ -109,7 +109,7 @@ var useButtonBase = function useButtonBase(_ref) {
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext,
     actionSubject: buttonType
   });

package/dist/esm/old-button/shared/button-base.js

@@ -109,7 +109,7 @@ export default /*#__PURE__*/React.forwardRef(function ButtonBase(props, ref) {
     action: 'clicked',
     componentName: 'button',
     packageName: "@atlaskit/button",
-    packageVersion: "16.18.0",
+    packageVersion: "16.18.1",
     analyticsData: analyticsContext
   });
 

package/dist/types/new-button/variants/default/button.d.ts

@@ -11,5 +11,5 @@ export type ButtonProps = CommonDefaultButtonProps & CommonButtonVariantProps;
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const Button: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonDefaultButtonProps & import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<React.ButtonHTMLAttributes<HTMLButtonElement>>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & React.RefAttributes<HTMLButtonElement>>>;
+declare const Button: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonDefaultButtonProps & import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & React.RefAttributes<HTMLButtonElement>>>;
 export default Button;

package/dist/types/new-button/variants/default/link.d.ts

@@ -1,7 +1,7 @@
 import React, { type Ref } from 'react';
-import { type CommonLinkVariantProps } from '../types';
+import { type AdditionalDefaultLinkVariantProps, type CommonLinkVariantProps } from '../types';
 import { type CommonDefaultButtonProps } from './types';
-export type LinkButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonDefaultButtonProps & CommonLinkVariantProps<RouterLinkConfig>;
+export type LinkButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonDefaultButtonProps & CommonLinkVariantProps<RouterLinkConfig> & AdditionalDefaultLinkVariantProps;
 declare const LinkButtonBase: <RouterLinkConfig extends Record<string, any> = never>({ analyticsContext, autoFocus, appearance, spacing, isDisabled, isSelected, iconBefore, UNSAFE_iconBefore_size, iconAfter, UNSAFE_iconAfter_size, children, shouldFitContainer, interactionName, overlay, onClick, onMouseDownCapture, onMouseUpCapture, onKeyDownCapture, onKeyUpCapture, onTouchStartCapture, onTouchEndCapture, onPointerDownCapture, onPointerUpCapture, onClickCapture, testId, href, ...rest }: LinkButtonProps<RouterLinkConfig>, ref: Ref<HTMLAnchorElement>) => JSX.Element;
 /**
  * __Link Button__
@@ -12,7 +12,7 @@ declare const LinkButtonBase: <RouterLinkConfig extends Record<string, any> = ne
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const LinkButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonDefaultButtonProps & import("../types").AdditionalLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & {
+declare const LinkButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonDefaultButtonProps & import("../types").AdditionalCommonLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href" | "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & AdditionalDefaultLinkVariantProps & {
     ref?: React.Ref<HTMLAnchorElement> | undefined;
 }) => ReturnType<typeof LinkButtonBase>;
 export default LinkButton;

package/dist/types/new-button/variants/default/types.d.ts

@@ -1,7 +1,12 @@
+/// <reference types="react" />
 import { type IconProp, type IconSize } from '../types';
 export type CommonDefaultButtonProps = {
     /**
-     * Places an icon within the button, after the button's text
+     * Text content to be rendered in the button. Required so that screen readers always have an accessible label provided for the button.
+     */
+    children: React.ReactNode;
+    /**
+     * Places an icon within the button, after the button's text.
      */
     iconAfter?: IconProp;
     /**
@@ -10,7 +15,7 @@ export type CommonDefaultButtonProps = {
      */
     UNSAFE_iconAfter_size?: IconSize;
     /**
-     * Places an icon within the button, before the button's text
+     * Places an icon within the button, before the button's text.
      */
     iconBefore?: IconProp;
     /**
@@ -19,7 +24,7 @@ export type CommonDefaultButtonProps = {
      */
     UNSAFE_iconBefore_size?: IconSize;
     /**
-     * Option to fit button width to its parent width
+     * Option to fit button width to its parent width.
      */
     shouldFitContainer?: boolean;
 };

package/dist/types/new-button/variants/icon/button.d.ts

@@ -1,7 +1,7 @@
 import React from 'react';
 import { type CommonButtonVariantProps } from '../types';
 import { type CommonIconButtonProps } from './types';
-export type IconButtonProps = CommonIconButtonProps & Omit<CommonButtonVariantProps, 'children' | 'appearance'>;
+export type IconButtonProps = CommonButtonVariantProps & CommonIconButtonProps;
 /**
  * __Icon Button__
  *
@@ -11,5 +11,5 @@ export type IconButtonProps = CommonIconButtonProps & Omit<CommonButtonVariantPr
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const IconButton: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonIconButtonProps & Omit<CommonButtonVariantProps, "children" | "appearance"> & React.RefAttributes<HTMLButtonElement>>>;
+declare const IconButton: React.MemoExoticComponent<React.ForwardRefExoticComponent<import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & CommonIconButtonProps & React.RefAttributes<HTMLButtonElement>>>;
 export default IconButton;

package/dist/types/new-button/variants/icon/link.d.ts

@@ -1,7 +1,7 @@
 import React, { type Ref } from 'react';
 import { type CommonLinkVariantProps } from '../types';
 import { type CommonIconButtonProps } from './types';
-export type LinkIconButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonIconButtonProps & Omit<CommonLinkVariantProps<RouterLinkConfig>, 'children' | 'appearance'>;
+export type LinkIconButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonIconButtonProps & CommonLinkVariantProps<RouterLinkConfig>;
 declare const LinkIconButtonBase: <RouterLinkConfig extends Record<string, any> = never>({ analyticsContext, autoFocus, appearance, spacing, isDisabled, isSelected, icon, interactionName, label, overlay, onClick, onMouseDownCapture, onMouseUpCapture, onKeyDownCapture, onKeyUpCapture, onTouchStartCapture, onTouchEndCapture, onPointerDownCapture, onPointerUpCapture, onClickCapture, shape, testId, UNSAFE_size, href, ...rest }: LinkIconButtonProps<RouterLinkConfig>, ref: Ref<HTMLAnchorElement>) => JSX.Element;
 /**
  * __Link Icon Button__
@@ -12,7 +12,7 @@ declare const LinkIconButtonBase: <RouterLinkConfig extends Record<string, any>
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const LinkIconButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonIconButtonProps & Omit<CommonLinkVariantProps<RouterLinkConfig>, "children" | "appearance"> & {
+declare const LinkIconButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonIconButtonProps & import("../types").AdditionalCommonLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href" | "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & {
     ref?: React.Ref<HTMLAnchorElement> | undefined;
 }) => ReturnType<typeof LinkIconButtonBase>;
 export default LinkIconButton;

package/dist/types/new-button/variants/icon/types.d.ts

@@ -1,24 +1,24 @@
 import { type IconButtonAppearance, type IconProp, type IconSize } from '../types';
 export type CommonIconButtonProps = {
     /**
-     * The button style variation
+     * The button style variation.
      */
     appearance?: IconButtonAppearance;
     /**
-     * Places an icon within the button
+     * Places an icon within the button.
      */
     icon: IconProp;
     /**
-     * Provide an accessible label, often used by screen readers
+     * Provide an accessible label, often used by screen readers.
      */
     label: string;
     /**
-     * Set the shape of the icon, defaults to square with rounded corners
+     * Set the shape of the icon, defaults to square with rounded corners.
      */
     shape?: 'default' | 'circle';
     /**
      * Set the size of the icon. `medium` is default, so it does not need to be specified.
-     * This is UNSAFE as it will be removed in future in favor of a 100% bounded API
+     * This is UNSAFE as it will be removed in future in favor of a 100% bounded API.
      */
     UNSAFE_size?: IconSize;
 };

package/dist/types/new-button/variants/shared/use-button-base.d.ts

@@ -15,7 +15,8 @@ export type UseButtonBaseArgs<TagName extends HTMLElement> = {
     hasIconAfter?: boolean;
     shouldFitContainer?: boolean;
     appearance?: Appearance;
-} & Pick<CommonButtonProps<TagName>, 'analyticsContext' | 'autoFocus' | 'children' | 'interactionName' | 'isDisabled' | 'isSelected' | 'overlay' | 'spacing'> & ControlledEventsPassed<TagName>;
+    children: React.ReactNode;
+} & Pick<CommonButtonProps<TagName>, 'analyticsContext' | 'autoFocus' | 'interactionName' | 'isDisabled' | 'isSelected' | 'overlay' | 'spacing'> & ControlledEventsPassed<TagName>;
 export type UseButtonBaseReturn<TagName extends HTMLElement> = {
     xcss: ReturnType<typeof xcss>;
     ref(node: TagName | null): void;

package/dist/types/new-button/variants/types.d.ts

@@ -11,52 +11,48 @@ export type IconSize = 'small' | 'large' | 'xlarge';
 type Combine<First, Second> = Omit<First, keyof Second> & Second;
 export type CommonButtonProps<TagName extends HTMLElement> = {
     /**
-     * Set the button to autofocus on mount
+     * Set the button to autofocus on mount.
      */
     autoFocus?: boolean;
     /**
-     * Used to 'overlay' something over a button. This is commonly used to display a loading spinner
+     * Used to 'overlay' something over a button. This is commonly used to display a loading spinner.
      */
     overlay?: React.ReactNode;
     /**
-     * Disable the button to prevent user interaction
+     * Disable the button to prevent user interaction.
      */
     isDisabled?: boolean;
     /**
-     * Indicates that the button is selected
+     * Indicates that the button is selected.
      */
     isSelected?: boolean;
     /**
-     * Handler to be called on blur
+     * Handler to be called on blur.
      */
     onBlur?: React.FocusEventHandler<TagName>;
     /**
-     * Handler to be called on click. The second argument can be used to track analytics data. See the tutorial in the analytics-next package for details
+     * Handler to be called on click. The second argument can be used to track analytics data. See the tutorial in the analytics-next package for details.
      */
     onClick?: (e: React.MouseEvent<TagName>, analyticsEvent: UIAnalyticsEvent) => void;
     /**
-     * Handler to be called on focus
+     * Handler to be called on focus.
      */
     onFocus?: React.FocusEventHandler<TagName>;
     /**
-     * Controls the amount of padding in the button
+     * Controls the amount of padding in the button.
      */
     spacing?: Spacing;
     /**
-     * Text content to be rendered in the button. Required so that screen readers always have an accessible label provided for the button
-     */
-    children: React.ReactNode;
-    /**
-     * A unique string that appears as data attribute `data-testid` in the rendered code, serving as a hook for automated tests
+     * A unique string that appears as data attribute `data-testid` in the rendered code, serving as a hook for automated tests.
      */
     testId?: string;
     /**
      * An optional name used to identify this component to press listeners. For example, interaction tracing. For more information,
-     * see [UFO integration into Design System components](https://go.atlassian.com/react-ufo-dst-integration)
+     * see [UFO integration into Design System components](https://go.atlassian.com/react-ufo-dst-integration).
      */
     interactionName?: string;
     /**
-     * Additional information to be included in the `context` of analytics events that come from button
+     * Additional information to be included in the `context` of analytics events that come from button.
      */
     analyticsContext?: Record<string, any>;
 };
@@ -70,7 +66,7 @@ export type AdditionalHTMLElementPropsExtender<Props extends SupportedElementAtt
  */
 export type AdditionalButtonVariantProps = {
     /**
-     * The button style variation
+     * The button style variation.
      */
     appearance?: ButtonAppearance;
 };
@@ -81,22 +77,27 @@ export type CombinedButtonProps<TagName extends HTMLElement, HTMLAttributes exte
 /**
  * Common props for Button `<button>` variants
  */
-export type CommonButtonVariantProps = AdditionalButtonVariantProps & CombinedButtonProps<HTMLButtonElement, AdditionalHTMLElementPropsExtender<React.ButtonHTMLAttributes<HTMLButtonElement>>>;
+export type CommonButtonVariantProps = AdditionalButtonVariantProps & CombinedButtonProps<HTMLButtonElement, AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, 'children'>>>;
 /**
- * Common additional props for Link `<a>` Button variants
+ * Common additional props for Link `<a>` Button variants, including icon and default buttons
  */
-export type AdditionalLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = {
-    /**
-     * The button style variation
-     */
-    appearance?: LinkButtonAppearance;
+export type AdditionalCommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = {
     /**
      * Provides a URL for link buttons. When using an AppProvider with a configured router link component, a `RouterLinkConfig` object type can be provided for advanced usage. See the [Link Button routing example](https://atlassian.design/components/button/button-new/examples#routing) for more details.
      */
     href: string | RouterLinkConfig;
 };
+/**
+ * Additional props for default Link `<a>` Button variants
+ */
+export type AdditionalDefaultLinkVariantProps = {
+    /**
+     * The button style variation.
+     */
+    appearance?: LinkButtonAppearance;
+};
 /**
  * Common props for Link `<a>` Button variants
  */
-export type CommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = AdditionalLinkVariantProps<RouterLinkConfig> & CombinedButtonProps<HTMLAnchorElement, AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href'>>>;
+export type CommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = AdditionalCommonLinkVariantProps<RouterLinkConfig> & CombinedButtonProps<HTMLAnchorElement, AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href' | 'children'>>>;
 export {};

package/dist/types-ts4.5/new-button/variants/default/button.d.ts

@@ -11,5 +11,5 @@ export type ButtonProps = CommonDefaultButtonProps & CommonButtonVariantProps;
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const Button: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonDefaultButtonProps & import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<React.ButtonHTMLAttributes<HTMLButtonElement>>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & React.RefAttributes<HTMLButtonElement>>>;
+declare const Button: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonDefaultButtonProps & import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & React.RefAttributes<HTMLButtonElement>>>;
 export default Button;

package/dist/types-ts4.5/new-button/variants/default/link.d.ts

@@ -1,7 +1,7 @@
 import React, { type Ref } from 'react';
-import { type CommonLinkVariantProps } from '../types';
+import { type AdditionalDefaultLinkVariantProps, type CommonLinkVariantProps } from '../types';
 import { type CommonDefaultButtonProps } from './types';
-export type LinkButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonDefaultButtonProps & CommonLinkVariantProps<RouterLinkConfig>;
+export type LinkButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonDefaultButtonProps & CommonLinkVariantProps<RouterLinkConfig> & AdditionalDefaultLinkVariantProps;
 declare const LinkButtonBase: <RouterLinkConfig extends Record<string, any> = never>({ analyticsContext, autoFocus, appearance, spacing, isDisabled, isSelected, iconBefore, UNSAFE_iconBefore_size, iconAfter, UNSAFE_iconAfter_size, children, shouldFitContainer, interactionName, overlay, onClick, onMouseDownCapture, onMouseUpCapture, onKeyDownCapture, onKeyUpCapture, onTouchStartCapture, onTouchEndCapture, onPointerDownCapture, onPointerUpCapture, onClickCapture, testId, href, ...rest }: LinkButtonProps<RouterLinkConfig>, ref: Ref<HTMLAnchorElement>) => JSX.Element;
 /**
  * __Link Button__
@@ -12,7 +12,7 @@ declare const LinkButtonBase: <RouterLinkConfig extends Record<string, any> = ne
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const LinkButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonDefaultButtonProps & import("../types").AdditionalLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & {
+declare const LinkButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonDefaultButtonProps & import("../types").AdditionalCommonLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href" | "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & AdditionalDefaultLinkVariantProps & {
     ref?: React.Ref<HTMLAnchorElement> | undefined;
 }) => ReturnType<typeof LinkButtonBase>;
 export default LinkButton;

package/dist/types-ts4.5/new-button/variants/default/types.d.ts

@@ -1,7 +1,12 @@
+/// <reference types="react" />
 import { type IconProp, type IconSize } from '../types';
 export type CommonDefaultButtonProps = {
     /**
-     * Places an icon within the button, after the button's text
+     * Text content to be rendered in the button. Required so that screen readers always have an accessible label provided for the button.
+     */
+    children: React.ReactNode;
+    /**
+     * Places an icon within the button, after the button's text.
      */
     iconAfter?: IconProp;
     /**
@@ -10,7 +15,7 @@ export type CommonDefaultButtonProps = {
      */
     UNSAFE_iconAfter_size?: IconSize;
     /**
-     * Places an icon within the button, before the button's text
+     * Places an icon within the button, before the button's text.
      */
     iconBefore?: IconProp;
     /**
@@ -19,7 +24,7 @@ export type CommonDefaultButtonProps = {
      */
     UNSAFE_iconBefore_size?: IconSize;
     /**
-     * Option to fit button width to its parent width
+     * Option to fit button width to its parent width.
      */
     shouldFitContainer?: boolean;
 };

package/dist/types-ts4.5/new-button/variants/icon/button.d.ts

@@ -1,7 +1,7 @@
 import React from 'react';
 import { type CommonButtonVariantProps } from '../types';
 import { type CommonIconButtonProps } from './types';
-export type IconButtonProps = CommonIconButtonProps & Omit<CommonButtonVariantProps, 'children' | 'appearance'>;
+export type IconButtonProps = CommonButtonVariantProps & CommonIconButtonProps;
 /**
  * __Icon Button__
  *
@@ -11,5 +11,5 @@ export type IconButtonProps = CommonIconButtonProps & Omit<CommonButtonVariantPr
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const IconButton: React.MemoExoticComponent<React.ForwardRefExoticComponent<CommonIconButtonProps & Omit<CommonButtonVariantProps, "children" | "appearance"> & React.RefAttributes<HTMLButtonElement>>>;
+declare const IconButton: React.MemoExoticComponent<React.ForwardRefExoticComponent<import("../types").AdditionalButtonVariantProps & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLButtonElement> & CommonIconButtonProps & React.RefAttributes<HTMLButtonElement>>>;
 export default IconButton;

package/dist/types-ts4.5/new-button/variants/icon/link.d.ts

@@ -1,7 +1,7 @@
 import React, { type Ref } from 'react';
 import { type CommonLinkVariantProps } from '../types';
 import { type CommonIconButtonProps } from './types';
-export type LinkIconButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonIconButtonProps & Omit<CommonLinkVariantProps<RouterLinkConfig>, 'children' | 'appearance'>;
+export type LinkIconButtonProps<RouterLinkConfig extends Record<string, any> = never> = CommonIconButtonProps & CommonLinkVariantProps<RouterLinkConfig>;
 declare const LinkIconButtonBase: <RouterLinkConfig extends Record<string, any> = never>({ analyticsContext, autoFocus, appearance, spacing, isDisabled, isSelected, icon, interactionName, label, overlay, onClick, onMouseDownCapture, onMouseUpCapture, onKeyDownCapture, onKeyUpCapture, onTouchStartCapture, onTouchEndCapture, onPointerDownCapture, onPointerUpCapture, onClickCapture, shape, testId, UNSAFE_size, href, ...rest }: LinkIconButtonProps<RouterLinkConfig>, ref: Ref<HTMLAnchorElement>) => JSX.Element;
 /**
  * __Link Icon Button__
@@ -12,7 +12,7 @@ declare const LinkIconButtonBase: <RouterLinkConfig extends Record<string, any>
  * - [Code](https://atlassian.design/components/button/code)
  * - [Usage](https://atlassian.design/components/button/usage)
  */
-declare const LinkIconButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonIconButtonProps & Omit<CommonLinkVariantProps<RouterLinkConfig>, "children" | "appearance"> & {
+declare const LinkIconButton: <RouterLinkConfig extends Record<string, any> = never>(props: CommonIconButtonProps & import("../types").AdditionalCommonLinkVariantProps<RouterLinkConfig> & Omit<import("../types").AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, "href" | "children">>, keyof import("../types").CommonButtonProps<TagName>> & import("../types").CommonButtonProps<HTMLAnchorElement> & {
     ref?: React.Ref<HTMLAnchorElement> | undefined;
 }) => ReturnType<typeof LinkIconButtonBase>;
 export default LinkIconButton;

package/dist/types-ts4.5/new-button/variants/icon/types.d.ts

@@ -1,24 +1,24 @@
 import { type IconButtonAppearance, type IconProp, type IconSize } from '../types';
 export type CommonIconButtonProps = {
     /**
-     * The button style variation
+     * The button style variation.
      */
     appearance?: IconButtonAppearance;
     /**
-     * Places an icon within the button
+     * Places an icon within the button.
      */
     icon: IconProp;
     /**
-     * Provide an accessible label, often used by screen readers
+     * Provide an accessible label, often used by screen readers.
      */
     label: string;
     /**
-     * Set the shape of the icon, defaults to square with rounded corners
+     * Set the shape of the icon, defaults to square with rounded corners.
      */
     shape?: 'default' | 'circle';
     /**
      * Set the size of the icon. `medium` is default, so it does not need to be specified.
-     * This is UNSAFE as it will be removed in future in favor of a 100% bounded API
+     * This is UNSAFE as it will be removed in future in favor of a 100% bounded API.
      */
     UNSAFE_size?: IconSize;
 };

package/dist/types-ts4.5/new-button/variants/shared/use-button-base.d.ts

@@ -15,7 +15,8 @@ export type UseButtonBaseArgs<TagName extends HTMLElement> = {
     hasIconAfter?: boolean;
     shouldFitContainer?: boolean;
     appearance?: Appearance;
-} & Pick<CommonButtonProps<TagName>, 'analyticsContext' | 'autoFocus' | 'children' | 'interactionName' | 'isDisabled' | 'isSelected' | 'overlay' | 'spacing'> & ControlledEventsPassed<TagName>;
+    children: React.ReactNode;
+} & Pick<CommonButtonProps<TagName>, 'analyticsContext' | 'autoFocus' | 'interactionName' | 'isDisabled' | 'isSelected' | 'overlay' | 'spacing'> & ControlledEventsPassed<TagName>;
 export type UseButtonBaseReturn<TagName extends HTMLElement> = {
     xcss: ReturnType<typeof xcss>;
     ref(node: TagName | null): void;

package/dist/types-ts4.5/new-button/variants/types.d.ts

@@ -11,52 +11,48 @@ export type IconSize = 'small' | 'large' | 'xlarge';
 type Combine<First, Second> = Omit<First, keyof Second> & Second;
 export type CommonButtonProps<TagName extends HTMLElement> = {
     /**
-     * Set the button to autofocus on mount
+     * Set the button to autofocus on mount.
      */
     autoFocus?: boolean;
     /**
-     * Used to 'overlay' something over a button. This is commonly used to display a loading spinner
+     * Used to 'overlay' something over a button. This is commonly used to display a loading spinner.
      */
     overlay?: React.ReactNode;
     /**
-     * Disable the button to prevent user interaction
+     * Disable the button to prevent user interaction.
      */
     isDisabled?: boolean;
     /**
-     * Indicates that the button is selected
+     * Indicates that the button is selected.
      */
     isSelected?: boolean;
     /**
-     * Handler to be called on blur
+     * Handler to be called on blur.
      */
     onBlur?: React.FocusEventHandler<TagName>;
     /**
-     * Handler to be called on click. The second argument can be used to track analytics data. See the tutorial in the analytics-next package for details
+     * Handler to be called on click. The second argument can be used to track analytics data. See the tutorial in the analytics-next package for details.
      */
     onClick?: (e: React.MouseEvent<TagName>, analyticsEvent: UIAnalyticsEvent) => void;
     /**
-     * Handler to be called on focus
+     * Handler to be called on focus.
      */
     onFocus?: React.FocusEventHandler<TagName>;
     /**
-     * Controls the amount of padding in the button
+     * Controls the amount of padding in the button.
      */
     spacing?: Spacing;
     /**
-     * Text content to be rendered in the button. Required so that screen readers always have an accessible label provided for the button
-     */
-    children: React.ReactNode;
-    /**
-     * A unique string that appears as data attribute `data-testid` in the rendered code, serving as a hook for automated tests
+     * A unique string that appears as data attribute `data-testid` in the rendered code, serving as a hook for automated tests.
      */
     testId?: string;
     /**
      * An optional name used to identify this component to press listeners. For example, interaction tracing. For more information,
-     * see [UFO integration into Design System components](https://go.atlassian.com/react-ufo-dst-integration)
+     * see [UFO integration into Design System components](https://go.atlassian.com/react-ufo-dst-integration).
      */
     interactionName?: string;
     /**
-     * Additional information to be included in the `context` of analytics events that come from button
+     * Additional information to be included in the `context` of analytics events that come from button.
      */
     analyticsContext?: Record<string, any>;
 };
@@ -70,7 +66,7 @@ export type AdditionalHTMLElementPropsExtender<Props extends SupportedElementAtt
  */
 export type AdditionalButtonVariantProps = {
     /**
-     * The button style variation
+     * The button style variation.
      */
     appearance?: ButtonAppearance;
 };
@@ -81,22 +77,27 @@ export type CombinedButtonProps<TagName extends HTMLElement, HTMLAttributes exte
 /**
  * Common props for Button `<button>` variants
  */
-export type CommonButtonVariantProps = AdditionalButtonVariantProps & CombinedButtonProps<HTMLButtonElement, AdditionalHTMLElementPropsExtender<React.ButtonHTMLAttributes<HTMLButtonElement>>>;
+export type CommonButtonVariantProps = AdditionalButtonVariantProps & CombinedButtonProps<HTMLButtonElement, AdditionalHTMLElementPropsExtender<Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, 'children'>>>;
 /**
- * Common additional props for Link `<a>` Button variants
+ * Common additional props for Link `<a>` Button variants, including icon and default buttons
  */
-export type AdditionalLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = {
-    /**
-     * The button style variation
-     */
-    appearance?: LinkButtonAppearance;
+export type AdditionalCommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = {
     /**
      * Provides a URL for link buttons. When using an AppProvider with a configured router link component, a `RouterLinkConfig` object type can be provided for advanced usage. See the [Link Button routing example](https://atlassian.design/components/button/button-new/examples#routing) for more details.
      */
     href: string | RouterLinkConfig;
 };
+/**
+ * Additional props for default Link `<a>` Button variants
+ */
+export type AdditionalDefaultLinkVariantProps = {
+    /**
+     * The button style variation.
+     */
+    appearance?: LinkButtonAppearance;
+};
 /**
  * Common props for Link `<a>` Button variants
  */
-export type CommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = AdditionalLinkVariantProps<RouterLinkConfig> & CombinedButtonProps<HTMLAnchorElement, AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href'>>>;
+export type CommonLinkVariantProps<RouterLinkConfig extends Record<string, any> = never> = AdditionalCommonLinkVariantProps<RouterLinkConfig> & CombinedButtonProps<HTMLAnchorElement, AdditionalHTMLElementPropsExtender<Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href' | 'children'>>>;
 export {};

package/extract-react-types/new-button/variants/default/link-button-props.tsx

@@ -1,5 +1,10 @@
-import { AdditionalLinkVariantProps } from '../../../../src/new-button/variants/types';
+import {
+  type AdditionalCommonLinkVariantProps,
+  type AdditionalDefaultLinkVariantProps,
+} from '../../../../src/new-button/variants/types';
 
-export default function LinkButtonProps(props: AdditionalLinkVariantProps) {
+export default function LinkButtonProps(
+  props: AdditionalCommonLinkVariantProps & AdditionalDefaultLinkVariantProps,
+) {
   return null;
 }

package/extract-react-types/new-button/variants/icon-button/common-icon-button-props.tsx

@@ -0,0 +1,11 @@
+import { type CommonIconButtonProps } from '../../../../src/new-button/variants/icon/types';
+import {
+  type CommonButtonProps,
+  type SupportedElements,
+} from '../../../../src/new-button/variants/types';
+
+export default function CommonProps(
+  props: CommonButtonProps<SupportedElements> & CommonIconButtonProps,
+) {
+  return null;
+}

package/extract-react-types/new-button/variants/icon-button/link-icon-button-props.tsx

@@ -0,0 +1,7 @@
+import { type AdditionalCommonLinkVariantProps } from '../../../../src/new-button/variants/types';
+
+export default function LinkButtonProps(
+  props: AdditionalCommonLinkVariantProps,
+) {
+  return null;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/button",
-  "version": "16.18.0",
+  "version": "16.18.1",
   "description": "A button triggers an event or action. They let users know what will happen next.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"