@atlashub/smartstack-mcp 1.13.0 → 1.14.0

package/dist/index.js

@@ -558,7 +558,7 @@ var ConfigSchema = z.object({
 });
 var ValidateConventionsInputSchema = z.object({
   path: z.string().optional().describe("Project path to validate (default: SmartStack.app path)"),
-  checks: z.array(z.enum(["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers", "all"])).default(["all"]).describe("Types of checks to perform")
+  checks: z.array(z.enum(["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers", "layouts", "tabs", "all"])).default(["all"]).describe("Types of checks to perform")
 });
 var CheckMigrationsInputSchema = z.object({
   projectPath: z.string().optional().describe("EF Core project path"),
@@ -914,7 +914,7 @@ var validateConventionsTool = {
         type: "array",
         items: {
           type: "string",
-          enum: ["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers", "all"]
+          enum: ["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers", "layouts", "tabs", "all"]
         },
         description: "Types of checks to perform",
         default: ["all"]
@@ -925,7 +925,7 @@ var validateConventionsTool = {
 async function handleValidateConventions(args, config) {
   const input = ValidateConventionsInputSchema.parse(args);
   const projectPath = input.path || config.smartstack.projectPath;
-  const checks = input.checks.includes("all") ? ["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers"] : input.checks;
+  const checks = input.checks.includes("all") ? ["tables", "migrations", "services", "namespaces", "entities", "tenants", "controllers", "layouts", "tabs"] : input.checks;
   logger.info("Validating conventions", { projectPath, checks });
   const result = {
     valid: true,
@@ -955,6 +955,12 @@ async function handleValidateConventions(args, config) {
   if (checks.includes("controllers")) {
     await validateControllerRoutes(structure, config, result);
   }
+  if (checks.includes("layouts")) {
+    await validateLayouts(structure, config, result);
+  }
+  if (checks.includes("tabs")) {
+    await validateTabs(structure, config, result);
+  }
   result.valid = result.errors.length === 0;
   result.summary = generateSummary(result, checks);
   return formatResult(result);
@@ -1385,6 +1391,132 @@ async function validateControllerRoutes(structure, _config, result) {
     });
   }
 }
+async function validateLayouts(structure, _config, result) {
+  if (!structure.web) {
+    result.warnings.push({
+      type: "warning",
+      category: "layouts",
+      message: "Web project not found, skipping layout validation"
+    });
+    return;
+  }
+  const layoutFiles = await findFiles("**/layouts/**/*.tsx", { cwd: structure.web });
+  if (layoutFiles.length === 0) {
+    result.warnings.push({
+      type: "warning",
+      category: "layouts",
+      message: "No layout files found in web/src/layouts/"
+    });
+    return;
+  }
+  for (const file of layoutFiles) {
+    const content = await readText(file);
+    const fileName = path6.basename(file);
+    const lines = content.split("\n");
+    let hasMaxWidth = false;
+    for (const line of lines) {
+      if (line.trim().startsWith("//") || line.trim().startsWith("*")) continue;
+      if (/className.*max-w-/.test(line)) {
+        hasMaxWidth = true;
+        break;
+      }
+    }
+    if (hasMaxWidth) {
+      result.errors.push({
+        type: "error",
+        category: "layouts",
+        message: `Layout "${fileName}" uses max-w-* constraint which limits content width`,
+        file: path6.relative(structure.root, file),
+        suggestion: "Remove max-w-* class. Content should occupy full available width."
+      });
+    }
+    let hasStandardPadding = false;
+    for (const line of lines) {
+      if (line.trim().startsWith("//") || line.trim().startsWith("*")) continue;
+      if (/className.*lg:px-10/.test(line)) {
+        hasStandardPadding = true;
+        break;
+      }
+    }
+    if (!hasStandardPadding) {
+      result.warnings.push({
+        type: "warning",
+        category: "layouts",
+        message: `Layout "${fileName}" may be missing standard horizontal padding`,
+        file: path6.relative(structure.root, file),
+        suggestion: "Use lg:px-10 for consistent horizontal padding across layouts"
+      });
+    }
+    let hasScrollPattern = false;
+    for (const line of lines) {
+      if (line.trim().startsWith("//") || line.trim().startsWith("*")) continue;
+      if (/className.*h-full/.test(line) && /className.*overflow-auto/.test(line)) {
+        hasScrollPattern = true;
+        break;
+      }
+    }
+    if (!hasScrollPattern) {
+      result.warnings.push({
+        type: "warning",
+        category: "layouts",
+        message: `Layout "${fileName}" may be missing scroll container pattern`,
+        file: path6.relative(structure.root, file),
+        suggestion: "Use h-full overflow-auto for proper internal scrolling"
+      });
+    }
+  }
+}
+async function validateTabs(structure, _config, result) {
+  if (!structure.web) {
+    result.warnings.push({
+      type: "warning",
+      category: "tabs",
+      message: "Web project not found, skipping tab validation"
+    });
+    return;
+  }
+  const pageFiles = await findFiles("**/pages/**/*.tsx", { cwd: structure.web });
+  let tabPagesCount = 0;
+  let hookUsageCount = 0;
+  for (const file of pageFiles) {
+    const content = await readText(file);
+    const fileName = path6.basename(file);
+    const lines = content.split("\n");
+    let hasTabPattern = false;
+    for (const line of lines) {
+      const trimmed = line.trim();
+      if (trimmed.startsWith("//") || trimmed.startsWith("*") || trimmed.startsWith("/*") || trimmed === "") {
+        continue;
+      }
+      if (/<Tabs|<TabList|activeTab\s*[,=})]|setActiveTab\s*[({]/.test(line)) {
+        hasTabPattern = true;
+        break;
+      }
+    }
+    if (hasTabPattern) {
+      tabPagesCount++;
+      const usesHook = content.includes("useTabNavigation");
+      if (usesHook) {
+        hookUsageCount++;
+      } else {
+        result.errors.push({
+          type: "error",
+          category: "tabs",
+          message: `Page "${fileName}" has tabs but doesn't use useTabNavigation hook`,
+          file: path6.relative(structure.root, file),
+          suggestion: "Use useTabNavigation hook to sync tab state with URL: const { activeTab, setActiveTab } = useTabNavigation(defaultTab, VALID_TABS)"
+        });
+      }
+    }
+  }
+  if (tabPagesCount > 0) {
+    result.warnings.push({
+      type: "warning",
+      category: "tabs",
+      message: `Tab summary: ${hookUsageCount}/${tabPagesCount} pages with tabs use useTabNavigation hook`
+    });
+  }
+}
 function generateSummary(result, checks) {
   const parts = [];
   parts.push(`Checks performed: ${checks.join(", ")}`);
@@ -10468,6 +10600,76 @@ All tenant-related tables use the \`tenant_\` prefix:
 
 ---
 
+## 10. Frontend Conventions
+
+### Layout Standards
+
+All context layouts MUST follow the AdminLayout pattern for consistent user experience.
+
+#### Standard Structure
+
+\`\`\`tsx
+<main className={\`pt-16 transition-all duration-300 \${
+  showSidebar ? (isCollapsed ? 'lg:pl-16' : 'lg:pl-64') : ''
+}\`}>
+  <div className="p-4 sm:p-6 lg:px-10 h-full overflow-auto">
+    <Outlet />
+  </div>
+</main>
+\`\`\`
+
+#### Layout Rules
+
+| Rule | Description |
+|------|-------------|
+| No \`max-w-*\` | Content MUST occupy full available width |
+| Horizontal padding | Use \`lg:px-10\` for consistent padding |
+| Scroll container | Use \`h-full overflow-auto\` for internal scrolling |
+| Sidebar conditional | \`showSidebar = !!currentAppCode\` |
+
+### Tab Navigation with URL
+
+Pages with tabs MUST synchronize tab state with URL for shareable links and browser navigation.
+
+#### useTabNavigation Hook
+
+\`\`\`tsx
+import { useTabNavigation } from '@/hooks/useTabNavigation';
+
+// 1. Define valid tabs
+const VALID_TABS = ['info', 'settings', 'permissions'] as const;
+type TabId = typeof VALID_TABS[number];
+
+// 2. Use the hook
+const { activeTab, setActiveTab } = useTabNavigation<TabId>('info', VALID_TABS);
+
+// 3. Use in JSX
+<button onClick={() => setActiveTab('settings')}>Settings</button>
+\`\`\`
+
+#### URL Behavior
+
+| URL | Active Tab |
+|-----|------------|
+| \`/page\` | Default tab (e.g., \`info\`) |
+| \`/page?tab=settings\` | \`settings\` |
+| \`/page?tab=invalid\` | Default tab (fallback) |
+
+#### Hook Characteristics
+
+- URL is clean for default tab (no \`?tab=\` parameter)
+- Invalid tabs fallback to default
+- Uses \`replace: true\` to avoid polluting browser history
+
+### Frontend Validation Checks
+
+| Check | Description |
+|-------|-------------|
+| \`layouts\` | Verify no \`max-w-*\` in content wrapper, standard padding present |
+| \`tabs\` | Verify \`useTabNavigation\` hook usage for pages with tabs |
+
+---
+
 ## Quick Reference
 
 | Category | Convention | Example |
@@ -10500,6 +10702,10 @@ All tenant-related tables use the \`tenant_\` prefix:
 | Validation | \`withValidation: true\` | FluentValidation validators |
 | Repository | \`withRepository: true\` | Interface + Implementation |
 | Migration naming | \`suggest_migration\` | {context}_v{version}_{seq}_{Desc} |
+| Layout wrapper | No \`max-w-*\` | Content fills available width |
+| Layout padding | \`lg:px-10\` | Standard horizontal padding |
+| Tab navigation | \`useTabNavigation\` hook | Sync tabs with URL |
+| Tab URL | \`?tab=name\` | Shareable deep links to tabs |
 
 ---