@atlashub/smartstack-cli 4.81.0 → 5.0.0

package/templates/mcp-scaffolding/tests/validator.test.cs.hbs

@@ -1,428 +0,0 @@
-{{!-- SmartStack Validator Test Template --}}
-{{!-- Generates unit tests for FluentValidation validators following SmartStack conventions --}}
-
-using FluentAssertions;
-using FluentValidation.TestHelper;
-using Xunit;
-using {{namespace}}.Application.DTOs;
-using {{namespace}}.Application.Validators;
-
-namespace {{namespace}}.Tests.Unit.Validators;
-
-/// <summary>
-/// Unit tests for <see cref="{{name}}Validator"/>.
-/// Follows SmartStack testing conventions: {Method}_When{Condition}_Should{Result}
-/// </summary>
-public class {{name}}ValidatorTests
-{
-    private readonly Create{{name}}RequestValidator _createValidator;
-    private readonly Update{{name}}RequestValidator _updateValidator;
-
-    public {{name}}ValidatorTests()
-    {
-        _createValidator = new Create{{name}}RequestValidator();
-        _updateValidator = new Update{{name}}RequestValidator();
-    }
-
-    #region Create Request - Code Validation
-
-    [Fact]
-    public void CreateValidator_WhenCodeIsValid_ShouldNotHaveErrors()
-    {
-        // Arrange
-        var request = new Create{{name}}Request { Code = "VALID-001" };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveValidationErrorFor(x => x.Code);
-    }
-
-    [Theory]
-    [InlineData(null)]
-    [InlineData("")]
-    [InlineData("   ")]
-    public void CreateValidator_WhenCodeIsNullOrEmpty_ShouldHaveError(string? invalidCode)
-    {
-        // Arrange
-        var request = new Create{{name}}Request { Code = invalidCode! };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Code)
-            .WithErrorMessage("*required*");
-    }
-
-    [Fact]
-    public void CreateValidator_WhenCodeExceedsMaxLength_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = new string('A', 101) // Exceeds 100 char limit
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Code)
-            .WithErrorMessage("*100 characters*");
-    }
-
-    [Theory]
-    [InlineData("valid-code")]
-    [InlineData("VALID_CODE_123")]
-    [InlineData("Code.With.Dots")]
-    public void CreateValidator_WhenCodeHasValidFormat_ShouldNotHaveErrors(string validCode)
-    {
-        // Arrange
-        var request = new Create{{name}}Request { Code = validCode };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveValidationErrorFor(x => x.Code);
-    }
-
-    [Theory]
-    [InlineData("code with spaces")]
-    [InlineData("code<script>")]
-    [InlineData("code;drop")]
-    public void CreateValidator_WhenCodeHasInvalidCharacters_ShouldHaveError(string invalidCode)
-    {
-        // Arrange
-        var request = new Create{{name}}Request { Code = invalidCode };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Code)
-            .WithErrorMessage("*invalid characters*");
-    }
-
-    #endregion
-
-    #region Create Request - Name Validation
-
-    [Fact]
-    public void CreateValidator_WhenNameIsValid_ShouldNotHaveErrors()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Name = "Valid Name"
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveValidationErrorFor(x => x.Name);
-    }
-
-    [Fact]
-    public void CreateValidator_WhenNameExceedsMaxLength_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Name = new string('A', 256) // Exceeds 255 char limit
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Name)
-            .WithErrorMessage("*255 characters*");
-    }
-
-    #endregion
-
-    #region Update Request Validation
-
-    [Fact]
-    public void UpdateValidator_WhenValidData_ShouldNotHaveErrors()
-    {
-        // Arrange
-        var request = new Update{{name}}Request
-        {
-            Name = "Updated Name",
-            // Add other updatable properties
-        };
-
-        // Act
-        var result = _updateValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveAnyValidationErrors();
-    }
-
-    [Fact]
-    public void UpdateValidator_WhenOptionalFieldsAreNull_ShouldNotHaveErrors()
-    {
-        // Arrange
-        var request = new Update{{name}}Request
-        {
-            Name = null, // Optional field can be null
-        };
-
-        // Act
-        var result = _updateValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveAnyValidationErrors();
-    }
-
-    #endregion
-
-    #region Date Validation (if applicable)
-
-    [Fact]
-    public void CreateValidator_WhenStartDateIsInPast_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            StartDate = DateTime.UtcNow.AddDays(-1)
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.StartDate)
-            .WithErrorMessage("*future*");
-    }
-
-    [Fact]
-    public void CreateValidator_WhenEndDateBeforeStartDate_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            StartDate = DateTime.UtcNow.AddDays(10),
-            EndDate = DateTime.UtcNow.AddDays(5)
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.EndDate)
-            .WithErrorMessage("*after start date*");
-    }
-
-    #endregion
-
-    #region Numeric Validation (if applicable)
-
-    [Theory]
-    [InlineData(-1)]
-    [InlineData(-100)]
-    public void CreateValidator_WhenQuantityIsNegative_ShouldHaveError(int invalidQuantity)
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Quantity = invalidQuantity
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Quantity)
-            .WithErrorMessage("*greater than*0*");
-    }
-
-    [Theory]
-    [InlineData(0)]
-    [InlineData(1)]
-    [InlineData(1000)]
-    public void CreateValidator_WhenQuantityIsValid_ShouldNotHaveErrors(int validQuantity)
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Quantity = validQuantity
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveValidationErrorFor(x => x.Quantity);
-    }
-
-    #endregion
-
-    #region Email Validation (if applicable)
-
-    [Theory]
-    [InlineData("valid@example.com")]
-    [InlineData("user.name@domain.org")]
-    [InlineData("user+tag@example.co.uk")]
-    public void CreateValidator_WhenEmailIsValid_ShouldNotHaveErrors(string validEmail)
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Email = validEmail
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldNotHaveValidationErrorFor(x => x.Email);
-    }
-
-    [Theory]
-    [InlineData("invalid")]
-    [InlineData("invalid@")]
-    [InlineData("@invalid.com")]
-    [InlineData("invalid@.com")]
-    public void CreateValidator_WhenEmailIsInvalid_ShouldHaveError(string invalidEmail)
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Email = invalidEmail
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Email)
-            .WithErrorMessage("*valid email*");
-    }
-
-    #endregion
-
-    #region Collection Validation (if applicable)
-
-    [Fact]
-    public void CreateValidator_WhenItemsCollectionIsEmpty_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Items = new List<string>()
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Items)
-            .WithErrorMessage("*at least one item*");
-    }
-
-    [Fact]
-    public void CreateValidator_WhenItemsExceedMaxCount_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Items = Enumerable.Range(1, 101).Select(i => $"Item-{i}").ToList()
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Items)
-            .WithErrorMessage("*maximum*100*");
-    }
-
-    #endregion
-
-    #region Cross-Field Validation
-
-    [Fact]
-    public void CreateValidator_WhenDependentFieldsMissing_ShouldHaveError()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            RequiresApproval = true,
-            ApproverEmail = null // Required when RequiresApproval is true
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.ApproverEmail)
-            .WithErrorMessage("*required when*");
-    }
-
-    #endregion
-
-    #region Security Validation
-
-    [Theory]
-    [InlineData("<script>alert('xss')</script>")]
-    [InlineData("'; DROP TABLE Users; --")]
-    [InlineData("{{'{{'}}constructor{{'}}'}}")]
-    public void CreateValidator_WhenInputContainsMaliciousContent_ShouldHaveError(string maliciousInput)
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "TEST",
-            Description = maliciousInput
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.ShouldHaveValidationErrorFor(x => x.Description)
-            .WithErrorMessage("*invalid characters*");
-    }
-
-    #endregion
-
-    #region Error Message Format
-
-    [Fact]
-    public void CreateValidator_WhenMultipleErrors_ShouldReturnAllErrors()
-    {
-        // Arrange
-        var request = new Create{{name}}Request
-        {
-            Code = "",     // Invalid
-            Name = new string('A', 500), // Too long
-        };
-
-        // Act
-        var result = _createValidator.TestValidate(request);
-
-        // Assert
-        result.Errors.Should().HaveCountGreaterThan(1);
-        result.ShouldHaveValidationErrorFor(x => x.Code);
-        result.ShouldHaveValidationErrorFor(x => x.Name);
-    }
-
-    #endregion
-}

package/templates/skills/_resources/config-safety.md

@@ -1,61 +0,0 @@
-# Configuration File Safety Rules
-
-## appsettings*.json Protection
-
-### MANDATORY Rules
-
-1. **NEVER use Write tool on `appsettings*.json`** — ALWAYS use Edit for targeted changes
-2. **NEVER remove existing top-level sections** — only add or modify values within existing structure
-3. **NEVER delete configuration keys** — replace secret VALUES with `<CONFIGURE_HERE>` placeholder
-4. **When adding a new section**, use Edit to insert at the correct location (before the closing `}`)
-
-### WHY
-
-Claude's Write tool replaces the entire file. If you read a 200-line appsettings.json but only reproduce 150 lines in the Write, 50 lines of configuration are permanently lost. This has caused production incidents where entire authentication, logging, or integration sections disappeared.
-
-### Correct Patterns
-
-| Action | Tool | Approach |
-|--------|------|----------|
-| Add new section | Edit | Find closing `}`, replace with new section + `}` |
-| Modify a value | Edit | Target the specific key-value pair |
-| Add a key to section | Edit | Find the section's closing `}`, add key before it |
-| Replace secrets | Edit | Replace the VALUE only, keep the key |
-
-### Example: Adding a New Section
-
-```
-// Use Edit tool with:
-// old_string:   "Serilog": { ... }\n}
-// new_string:   "Serilog": { ... },\n  "NewSection": { "Key": "<CONFIGURE_HERE>" }\n}
-```
-
-### Secret Value Handling
-
-```json
-// WRONG - removing the key entirely
-"Jwt": { }
-
-// WRONG - deleting the section
-// (section missing from file)
-
-// CORRECT - placeholder value preserving structure
-"Jwt": {
-  "SecretKey": "<CONFIGURE_HERE>",
-  "Issuer": "<CONFIGURE_HERE>",
-  "Audience": "<CONFIGURE_HERE>",
-  "ExpirationMinutes": 60
-}
-```
-
-### Exception: New File Creation
-
-Write is acceptable ONLY when creating a NEW `appsettings.*.json` file that does not yet exist on disk (e.g., `appsettings.Local.json` during `/gitflow start`). The PreToolUse hook automatically allows this case.
-
-### Protection Layers
-
-| Layer | Mechanism | When |
-|-------|-----------|------|
-| Hook `appsettings-guard.sh` | PreToolUse on Write | Blocks Write if top-level sections would be lost |
-| Commit agent step 2b | During `/gitflow commit` | Detects section removal vs HEAD before staging |
-| These instructions | During development | Prevents the issue from occurring |

package/templates/skills/_resources/context-digest-template.md

@@ -1,53 +0,0 @@
-# Context Digest Pattern
-
-## Purpose
-
-Reduces token usage between multi-step skill executions (BA, business-analyse-develop) by compressing step outputs into compact summaries.
-
-## How It Works
-
-```
-Step N completes
-    ↓
-Generate digest (max 50 lines)
-    ↓
-Pass digest to Step N+1 (in-context)
-    ↓
-Step N+1 reads:
-  - Digest from previous step (compact)
-  - 00-context.md for state variables
-  - Full output files ONLY if digest indicates need
-```
-
-## Digest Sections
-
-| Section | Max Lines | Content |
-|---------|-----------|---------|
-| Changes | 10 | Files modified with brief description |
-| Decisions | 10 | Key architectural decisions |
-| Findings | 10 | Issues found, patterns identified |
-| State | 5 | Updated state variables |
-| Blockers | 5 | Open issues, unresolved questions |
-| Next | 5 | What the next step needs to know |
-
-## Token Savings Estimate
-
-| Scenario | Without Digest | With Digest | Savings |
-|----------|---------------|-------------|---------|
-| step-01 → step-02 | ~2000 tokens | ~500 tokens | 75% |
-| step-02 → step-03 | ~1500 tokens | ~400 tokens | 73% |
-| step-03 → step-04 | ~1800 tokens | ~450 tokens | 75% |
-| **Total workflow** | ~5300 tokens | ~1350 tokens | **~75%** |
-
-## Applies To
-
-- BA skill (between phases)
-- Ralph-loop skill (between tasks)
-- Any future multi-step skill
-
-## Resume Exception
-
-When a skill resumes via `-r` flag:
-- Digest is ephemeral (not saved to disk)
-- Resume reads full output files from `.claude/output/` or `.business-analyse/`
-- This ensures complete state restoration after session break

package/templates/skills/_resources/doc-context-cache.md

@@ -1,60 +0,0 @@
-# Documentation Context Cache
-
-## Purpose
-
-Caches the output of `docs-context-reader` agent to avoid redundant documentation scans.
-
-## Location
-
-`.claude/cache/docs-context.json`
-
-## Schema
-
-```json
-{
-  "generatedAt": "ISO-date",
-  "commitHash": "git-sha",
-  "ttl": 86400,
-  "summary": {
-    "totalModules": 5,
-    "documented": 3,
-    "synced": 2,
-    "drift": 1,
-    "missing": 2
-  },
-  "modules": {
-    "business/support/sla": {
-      "featureId": "FEAT-003",
-      "status": "synced",
-      "useCaseCount": 4,
-      "ruleCount": 6,
-      "permissionCount": 5,
-      "sections": ["overview", "useCases", "benefits", "features", "steps", "technicalRef"],
-      "missingSections": ["beforeAfter", "faq"]
-    }
-  }
-}
-```
-
-## TTL (Time To Live)
-
-| Condition | Cache Valid |
-|-----------|------------|
-| Same git commit hash | Yes |
-| Different git commit hash | No (invalidate) |
-| > 24 hours old | No (invalidate) |
-| docs-manifest.json modified | No (invalidate) |
-
-## Usage
-
-1. **Before launching docs-context-reader agent**: Check cache
-2. **If cache valid**: Use cached summary (0 tokens)
-3. **If cache invalid**: Launch agent, save result to cache
-4. **On commit**: Invalidate cache (commit changes may affect docs)
-
-## Integration Points
-
-| Consumer | Check Cache? |
-|----------|-------------|
-| BA step-01 (discover) | Yes |
-| docs-sync-checker agent | No (always fresh) |