@atlashub/smartstack-cli 4.74.0 → 4.76.0

package/templates/skills/business-analyse-html/steps/step-04-verify.md

@@ -8,7 +8,7 @@ model: opus
 
 ## YOUR TASK
 
-Run 9 blocking validations on the generated HTML file and display the completion summary.
+Run 16 blocking validations on the generated HTML file and display the completion summary.
 
 ---
 
@@ -105,11 +105,97 @@ IF "modules" is missing:
   BLOCKING_ERROR("FEATURE_DATA.modules missing — page will crash")
 ```
 
-> **IF any check fails:** fix the issue and re-run the failing step before completing.
+> **IF any check fails (1-9):** fix the issue and re-run the failing step before completing.
+
+### 2. Content Quality Validations (NEW)
+
+**Check 10 — Language coherence:**
+```
+Read FEATURE_DATA.metadata.language (or config.json language field)
+IF language is set (e.g., "fr"):
+  FOR each module in FEATURE_DATA.modules:
+    const spec = FEATURE_DATA.moduleSpecs[module.code]
+
+    // Check UC names
+    FOR each uc in spec.useCases:
+      IF language == "fr" AND uc.name matches /^(Create|Update|Delete|View|List|Manage|Submit|Approve|Reject|Export)\b/:
+        WARNING("Module {module.code}: UC '{uc.name}' appears English (expected French)")
+
+    // Check BR statements
+    FOR each br in spec.businessRules:
+      IF language == "fr" AND br.statement matches /\b(must|should|cannot|when|if the|is required)\b/i:
+        WARNING("Module {module.code}: BR '{br.name}' statement appears English (expected French)")
+
+  Count total warnings. IF > 20% of items are in wrong language:
+    WARNING("⚠ Significant language mismatch: {count} items in wrong language")
+```
+
+**Check 11 — Business rules have examples:**
+```
+FOR each module in FEATURE_DATA.modules:
+  const brs = FEATURE_DATA.moduleSpecs[module.code].businessRules || []
+  IF brs.length === 0: SKIP
+  const withExamples = brs.filter(br => br.example && br.example.trim() !== '')
+  const rate = withExamples.length / brs.length
+  IF rate < 0.5:
+    WARNING("Module {module.code}: only {withExamples.length}/{brs.length} BRs have examples ({rate*100}%)")
+```
+
+**Check 12 — Entity attributes have type field:**
+```
+FOR each module in FEATURE_DATA.modules:
+  const entities = FEATURE_DATA.moduleSpecs[module.code].entities || []
+  FOR each entity in entities:
+    const attrs = entity.attributes || []
+    const withType = attrs.filter(a => a.type && a.type.trim() !== '' && a.type !== 'string')
+    IF attrs.length > 3 AND withType.length === 0:
+      WARNING("Module {module.code}: entity '{entity.name}' — all {attrs.length} attributes default to 'string' (types may be missing)")
+```
+
+**Check 13 — Permissions populated per module:**
+```
+FOR each module in FEATURE_DATA.modules:
+  const perms = FEATURE_DATA.moduleSpecs[module.code].permissions || []
+  IF perms.length === 0:
+    WARNING("Module {module.code}: 0 permissions — permission grid will be empty")
+```
+
+**Check 14 — Mockups not empty (screens with actual resources):**
+```
+FOR each module in FEATURE_DATA.modules:
+  const screens = FEATURE_DATA.moduleSpecs[module.code].screens || []
+  const wireframes = EMBEDDED_ARTIFACTS.wireframes?.[module.code] || []
+  IF screens.length === 0 AND wireframes.length === 0:
+    WARNING("Module {module.code}: no screens and no wireframes — Mockups tab will show 'Aucune maquette'")
+  ELSE IF screens.length > 0:
+    const totalResources = screens.reduce((sum, s) => sum + (s.resources || []).length, 0)
+    IF totalResources === 0:
+      WARNING("Module {module.code}: has screens[] but 0 resources — mockups will appear empty despite data existing")
+```
+
+**Check 15 — MCD diagram present (multi-module projects):**
+```
+const diagrams = FEATURE_DATA.consolidation?.mermaidDiagrams || {}
+IF FEATURE_DATA.modules.length > 1:
+  IF !diagrams.erd:
+    WARNING("No ERD diagram — data model section will have no visual")
+  IF !diagrams.mcd:
+    WARNING("No MCD diagram — conceptual model not generated")
+```
+
+**Check 16 — Use Case diagrams present:**
+```
+const ucDiagrams = diagrams.useCases || {}
+const totalUCs = Object.values(FEATURE_DATA.moduleSpecs).reduce((sum, s) => sum + (s.useCases?.length || 0), 0)
+IF Object.keys(ucDiagrams).length === 0 AND totalUCs > 0:
+  WARNING("No use case diagrams generated — UC tabs will have no UML visual")
+```
+
+> **Checks 10-16 produce WARNINGs (non-blocking).** Display all warnings in the completion summary so the user is aware of potential quality issues.
 
 ---
 
-### 2. Display Completion Summary
+### 3. Display Completion Summary
 
 ```
 ══════════════════════════════════════════════════════════════
@@ -131,5 +217,8 @@ Modules: {count} ({names})
   4. If approved: /business-analyse-handoff then /business-analyse-develop to begin development
   5. If corrections needed: export ba-review.json from the HTML, then run /business-analyse-review
 
+Quality Warnings: {warning_count}
+{FOR each warning: display warning message}
+
 ══════════════════════════════════════════════════════════════
 ```